In case big number need to be freed, data it contains should be cleared
before especially if it is critical data like private keys.
Fixes: 3e9d6bd447fb ("crypto/openssl: add RSA and mod asym operations")
Signed-off-by: Arek Kusztal
---
config/common_base | 4 ++--
dri
ANSI C memcmp is not constant time function per spec so it should
be avoided in cryptography usage.
Fixes: d61f70b4c918 ("crypto/libcrypto: add driver for OpenSSL library")
Signed-off-by: Arek Kusztal
---
drivers/crypto/openssl/rte_openssl_pmd.c | 4 ++--
1 file changed, 2 insertions(+), 2 dele
On 5/2/2019 1:11 PM, Tom Barbette wrote:
> Use rxtx callback to demonstrate a way to use rte_eth_read_clock to
> convert the hardware timestamps to an amount of cycles.
>
> This allows to get the amount of time the packet spent since its entry
> in the device. While the regular latency only shows
On 5/2/2019 1:11 PM, Tom Barbette wrote:
> Some NICs allow to timestamp packets, but do not support the full
> PTP synchronization process. Hence, the value set in the mbuf
> timestamp field is only the raw value of an internal clock.
>
> To make sense of this value, one at least needs to be able
Minor nit, this should be a V1 instead of V10 after your RFC.
On 05/31, Jakub Grajciar wrote:
>Memory interface (memif), provides high performance
>packet transfer over shared memory.
It'd be better to have more descrition of this new PMD in the commit log,
something
like you have in memif.rst
> -Original Message-
> From: Govindarajan, LavanyaX
> Sent: Monday, April 15, 2019 1:40 PM
> To: dev@dpdk.org
> Cc: Pattan, Reshma ; olivier.m...@6wind.com;
> Richardson, Bruce ; Govindarajan, LavanyaX
>
> Subject: [PATCH] app/test: add unit test cases for mbuf library APIs
>
> __fu
Currently clear_data (dpdk-devbind.py) doesn't work as expected since
"global devices" is missing and so "devices" is considered a local variable.
This commit changes "clear_data" function in order to really clear
devices by adding "global devices".
CC: sta...@dpdk.org
Signed-off-by: Timothy Red
On 29/05/2019 13:43, Reshma Pattan wrote:
Free the `values` pointer before returning
from rte_telemetry_command_ports_all_stat_values()
to avoid memory leak.
Fixes: c12cefa379 ("telemetry: fix mapping of statistics")
CC: sta...@dpdk.org
CC: bruce.richard...@intel.com
Signed-off-by: Reshma Patta
On 17/05/2019 17:07, Reshma Pattan wrote:
telemetry has support for fetching port based stats
from metrics library.
Metrics library also has global stats which are
not fetched by telemetry, so extend telemetry to
fetch the global metrics.
Signed-off-by: Reshma Pattan
---
doc/guides/howto/t
On Fri, 2019-05-31 at 13:11 +0200, Timothy Redaelli wrote:
> Currently clear_data (dpdk-devbind.py) doesn't work as expected since
> "global devices" is missing and so "devices" is considered a local
> variable.
>
> This commit changes "clear_data" function in order to really clear
> devices by ad
Major changes:
- Cipher field was introduced
- Padding struct was created
- PKCS1-v1_5 Block type 0 was removed
- Fixed comments about prime numbers, etc.
Arek Kusztal (3):
cryptodev: rework api of rsa algorithm
crypto/openssl: rework openssl rsa implementation
test: rework rsa test implemen
This patch reworks API of RSA algorithm.
Major changes:
- Cipher field was introduced
- Padding struct was created
- PKCS1-v1_5 Block type 0 was removed
- Fixed comments about prime numbers
Signed-off-by: Arek Kusztal
---
lib/librte_cryptodev/rte_crypto_asym.h | 149 +
This commit reworks implementation of RSA algorithm
in OPENSSL PMD to be conformant to API changes.
Signed-off-by: Arek Kusztal
---
drivers/crypto/openssl/rte_openssl_pmd.c | 14 ++
1 file changed, 6 insertions(+), 8 deletions(-)
diff --git a/drivers/crypto/openssl/rte_openssl_pmd.c
This commit reworks rsa test implementation to be conformant
to the RSA API.
Signed-off-by: Arek Kusztal
---
app/test/test_cryptodev_asym.c | 11 +++
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/app/test/test_cryptodev_asym.c b/app/test/test_cryptodev_asym.c
index fc92d3
> -Original Message-
> From: Legacy, Allain
> Sent: Monday, May 27, 2019 1:03 PM
> To: tho...@monjalon.net
> Cc: dev@dpdk.org; ferruh.yi...@intel.com; Peters, Matt
> Subject: [PATCH v2] net/avp: remove resources when port is closed
>
> The rte_eth_dev_close() function now handles freein
> -Original Message-
> From: Wang, Xiao W
> Sent: Wednesday, May 15, 2019 2:59 PM
> To: Singh, Jasvinder
> Cc: dev@dpdk.org; Dumitrescu, Cristian ;
> Wang, Xiao W ; sta...@dpdk.org
> Subject: [PATCH] net/softnic: fix pipeline time calculation
>
> When a new pipeline is added to a threa
> -Original Message-
> From: Kusztal, ArkadiuszX
> Sent: Friday, May 31, 2019 7:59 AM
> To: dev@dpdk.org
> Cc: akhil.go...@nxp.com; Trahe, Fiona ; Doherty, Declan
> ; Kusztal, ArkadiuszX
> Subject: [PATCH] crypto/openssl: fix usage of non constant time memcmp for
> mac and signature
>
On 05/27, Allain Legacy wrote:
>The rte_eth_dev_close() function now handles freeing resources for
>devices (e.g., mac_addrs). To conform with the new close() behaviour we
>are asserting the RTE_ETH_DEV_CLOSE_REMOVE flag so that
>rte_eth_dev_close() releases all device level dynamic memory.
>
>Sec
From: Stephen Hemminger
Purely cosmetic change, use unsigned int instead of unsigned alone.
Signed-off-by: Stephen Hemminger
Signed-off-by: David Marchand
---
lib/librte_eal/common/include/rte_lcore.h | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
Changelog since v3:
- up
From: Stephen Hemminger
The fields of the internal EAL core configuration are currently
laid bare as part of the API. This is not good practice and limits
fixing issues with layout and sizes.
Make new accessor functions for the fields used by current drivers
and examples.
Signed-off-by: Stephen
This set of patches makes the lcore_config structure less visible
as part of the ABI. This version does not break the ABI (yet)
follow on patch moves lcore_config into eal_private.h
Changelog since v4:
The only change is in patch 2: marked new apis as experimental.
Changelog since v3:
I took the
From: Stephen Hemminger
The lcore_config structure will be hidden in future release.
Signed-off-by: Stephen Hemminger
Signed-off-by: David Marchand
---
drivers/bus/dpaa/dpaa_bus.c | 6 --
drivers/bus/fslmc/portal/dpaa2_hw_dpio.c | 4 +++-
2 files changed, 7 insertions(+), 3 d
From: Stephen Hemminger
Referring to lcore_config directly is no longer recommended.
Also remove unnecessary assignment of slave_core_id.
Signed-off-by: Stephen Hemminger
Signed-off-by: David Marchand
---
examples/bond/main.c | 13 +++--
1 file changed, 7 insertions(+), 6 deletions(-)
From: Stephen Hemminger
Don't refer to lcore_config directly.
Signed-off-by: Stephen Hemminger
Signed-off-by: David Marchand
---
app/test/test_cryptodev.c | 2 +-
app/test/test_ring_perf.c | 22 --
app/test/test_stack_perf.c | 20 ++--
3 files changed, 2
Hi Konstantin
On 30.05.2019 18:51, Ananyev, Konstantin wrote:
> Hi Lukasz,
>
>> diff --git a/lib/librte_ipsec/esp_outb.c b/lib/librte_ipsec/esp_outb.c
>> index c798bc4..ed5974b 100644
>> --- a/lib/librte_ipsec/esp_outb.c
>> +++ b/lib/librte_ipsec/esp_outb.c
>> @@ -126,11 +126,11 @@ outb_tun_pkt_p
https://bugs.dpdk.org/show_bug.cgi?id=289
Bug ID: 289
Summary: mlx5: 100G interface capability not recognized
Product: DPDK
Version: 17.11
Hardware: All
OS: All
Status: CONFIRMED
Severity: normal
This RFC suggest possible API to implement generic MACSEC HW
offload in DPDK infrastructure.
Right now two PMDs implementing MACSEC hw offload via private
API: ixgbe (Intel) and atlantic (Aquantia).
During that private API discussion it was decided to go further
with well defined public API, base
Here we create/get security mempool, get sec_ctx, and then
request session creation with macsec specific session configuration.
encrypt and replay_protection parameters are really not a global macsec
attributes, they are related to tx and rx security connection properties.
But we keep testpmd com
draft on how macsec off command will looks like
Signed-off-by: Igor Russkikh
---
app/test-pmd/cmdline.c | 22 +-
1 file changed, 17 insertions(+), 5 deletions(-)
diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
index dbee3d958c2e..af7c2853fd2c 100644
--- a/app/te
---
app/test-pmd/cmdline.c | 40
1 file changed, 32 insertions(+), 8 deletions(-)
diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
index af7c2853fd2c..1bcf63e31ee3 100644
--- a/app/test-pmd/cmdline.c
+++ b/app/test-pmd/cmdline.c
@@ -14083,6 +14
---
drivers/net/atlantic/atl_ethdev.c | 116 ++
drivers/net/atlantic/meson.build | 1 +
2 files changed, 117 insertions(+)
diff --git a/drivers/net/atlantic/atl_ethdev.c
b/drivers/net/atlantic/atl_ethdev.c
index c9c1795a1639..b6fcf36f0f27 100644
--- a/drivers/net/a
When users call rte_eth_dev_close() and rte_dev_remove(), the af_xdp
pmd return -1 (EPERM) due to eth_dev == NULL.
Since the af_xdp pmd driver advertises RTE_ETH_DEV_CLOSE_REMOVE, all
the resources are freed on rte_eth_dev_close(). rte_dev_remove() tries
to detach device and subsequently calls rt
This commit enables the "FD ID" or flow-director mark
capability with the SSE vector PMD for 32 byte descriptors.
Suggested-by: Mesut Ergin
Signed-off-by: Harry van Haaren
---
Hey Folks,
This v1 is expected to have some performance impact due to adding stores
to the data path. These can be re
This patch rectifies slave_id passed to rte_eal_wait_lcore()
to point to valid cores in read-write lock-free concurrency test.
It also replaces a 'for' loop with RTE_LCORE_FOREACH API.
Fixes: dfd9d5537e876 ("test/hash: use existing lcore API")
Cc: sta...@dpdk.org
Signed-off-by: Dharmik Thakkar
From: Jerin Jacob
This patch set adds initial driver support for OCTEON TX2 SoC.
OCTEON TX2 is an armv8.2 SoC with integrated HW based mempool, ethdev,
cryptodev, compressdev, and eventdev devices.
This patch set adds common driver and mempool device driver for OCTEON TX2 SoC.
There will be thr
From: Jerin Jacob
Add the make and meson based build infrastructure along with
HW definition header file.
This patch adds skeleton otx2_mbox.c file to make sure
all header files are intact, subsequent patches add content
to otx2_mbox.c
This patch also updates CONFIG_RTE_MAX_VFIO_GROUPS
value to
From: Jerin Jacob
The admin function driver sits in Linux kernel as mailbox
server. The DPDK AF mailbox client, send the message to mailbox
server to complete the administrative task such as get mac
address.
This patch adds mailbox request and response definition of
existing mailbox defined betw
From: Jerin Jacob
This patch adds mailbox init and fini support.
Each RVU device has a dedicated 64KB mailbox region
shared with its peer for communication. RVU AF has
a separate mailbox region shared with each of RVU PFs
and an RVU PF has a separate region shared with
each of it's VF.
Signed-of
From: Jerin Jacob
Various octeontx2 drivers use IO handling API, added octeontx2
specific IO handling routines in the common code.
Since some of those implementations are based on arm64 instructions
added the stub to compile the code on non arm64 ISA.
The non arm64 ISA stub is possible due to th
From: Jerin Jacob
Various consumers of this common code need runtime
logging infrastructure. This patch adds the same.
Signed-off-by: Jerin Jacob
---
drivers/common/octeontx2/Makefile | 1 +
drivers/common/octeontx2/meson.build | 1 +
drivers/common/octeontx2/otx2_common
From: Jerin Jacob
Each RVU device has a dedicated 64KB mailbox region
shared with its peer for communication. RVU AF has
a separate mailbox region shared with each of RVU PFs
and an RVU PF has a separate region shared with each of
it's VF.
This patch add use 64KB memory and implemented mailbox
s
From: Jerin Jacob
All PCIe drivers(ethdev, mempool, cryptodev and eventdev) in octeontx2,
needs to handle interrupt for mailbox and error handling.
Create a helper function over rte interrupt API to register,
unregister, disable interrupts.
Signed-off-by: Jerin Jacob
Signed-off-by: Vamsi Attunu
From: Nithin Dabilpuram
This patch adds support for AF to PF mailbox interrupt and message
handling. PF writes the message on mapped mailbox region
followed by writing the mailbox doorbell register. Upon receiving,
the mailbox request in AF(In Linux kernel), It processes the messages
and update t
From: Jerin Jacob
The mempool device(NPA) may be provisioned as a standalone device or
it can be part of ethdev/eventdev device. In order to address
mempool as standalone or integrated with ethdev/eventdev device,
An intra device structure being introduced.
When the _first_ ethdev/eventdev PCIe
From: Nithin Dabilpuram
PF has additional responsibility being server for VF messages
and forward to AF and once AF process it then forward
the response back to VF.
otx2_vf_pf_mbox_irq() will process the VF mailbox request and
af_pf_wait_msg() will until getting a response back from AF.
Signed-o
From: Jerin Jacob
This patch adds support for PF <-> VF mailbox interrupt
mailbox message interrupt handling.
Signed-off-by: Jerin Jacob
---
drivers/common/octeontx2/otx2_dev.c | 78 -
1 file changed, 76 insertions(+), 2 deletions(-)
diff --git a/drivers/common/oct
From: Jerin Jacob
Introduce otx2_dev class to hold octeontx2 PCIe device specific
information and operations.
All PCIe drivers(ethdev, mempool, cryptodev and eventdev) in octeontx2,
inherits this base object to avail the common functionalities such
as mailbox creation, interrupt registration, et
From: Jerin Jacob
Add the make and meson based build infrastructure along
with the mempool(NPA) device probe.
Signed-off-by: Jerin Jacob
Signed-off-by: Pavan Nikhilesh
---
config/common_base| 5 ++
drivers/common/Makefile | 3 +
drivers/memp
From: Nithin Dabilpuram
The events like PHY link status change by AF or PHY configuration
change by PF would call for the uplink message.
The AF initiated uplink would land it in PF and PF would further
forward to VF(if it is intended for that specific VF)
The PF initiated uplink would be distri
From: Nithin Dabilpuram
Upon receiving FLR request from VF, It is PF responsibly
forward to AF and enable FLR for VFs.
This patch adds support for VF FLR support in PF.
This patch also add otx2_dev_active_vfs() API to find
the number of active VF for given PF.
Signed-off-by: Nithin Dabilpuram
From: Jerin Jacob
Implement the low-level NPA HW operations such as
alloc, free memory, etc.
Signed-off-by: Jerin Jacob
Signed-off-by: Kiran Kumar K
---
drivers/mempool/octeontx2/otx2_mempool.h | 146 +++
1 file changed, 146 insertions(+)
diff --git a/drivers/mempool/octe
From: Jerin Jacob
Register and implement NPA IRQ handler for RAS and all type of
error interrupts to get the fatal errors from HW.
Signed-off-by: Jerin Jacob
Signed-off-by: Harman Kalra
---
drivers/mempool/octeontx2/Makefile | 3 +-
drivers/mempool/octeontx2/meson.build|
From: Jerin Jacob
The DPDK mempool free operation frees HW AURA
and POOL reserved in alloc operation. In addition to that it free all
the memory resources allocated in mempool alloc operations.
Cc: Olivier Matz
Signed-off-by: Jerin Jacob
---
drivers/mempool/octeontx2/otx2_mempool_ops.c | 104
From: Jerin Jacob
NPA object needs to initialize memory for queue interrupts context,
pool resource management, etc. This patch adds support for initializing
and finalizing the NPA object.
This patch also updates the otx2_npa_lf definition to meet the init/fini
requirements.
Signed-off-by: Jeri
From: Jerin Jacob
Add remaining get_count(), calc_mem_size() and populate() slow path
mempool operations.
Signed-off-by: Jerin Jacob
Signed-off-by: Pavan Nikhilesh
---
drivers/mempool/octeontx2/otx2_mempool_ops.c | 62
1 file changed, 62 insertions(+)
diff --git a/driver
From: Jerin Jacob
Add a helper function to dump aura and pool context for NPA debugging.
Signed-off-by: Jerin Jacob
Signed-off-by: Vivek Sharma
---
drivers/mempool/octeontx2/Makefile| 3 +-
drivers/mempool/octeontx2/meson.build | 1 +
drivers/mempool/octeontx2/otx2_mem
From: Jerin Jacob
The DPDK mempool allocation reserves a single HW AURA
and POOL in 1:1 map mode. Upon reservation, SW programs the slow path
operations such as allocate stack memory for DMA and
bunch HW configurations to respective HW blocks.
Cc: Olivier Matz
Signed-off-by: Jerin Jacob
---
From: Pavan Nikhilesh
This patch adds an optimized arm64 instruction based routine to leverage
CPU pipeline characteristics of octeontx2. The theme is to fill the
pipeline with CASP operations as much HW can do so that HW can do alloc()
HW ops in full throttle.
Cc: Olivier Matz
Cc: Aaron Conole
From: Jerin Jacob
Add enqueue and dequeue mempool fastpath operations.
Cc: Olivier Matz
Signed-off-by: Jerin Jacob
Signed-off-by: Pavan Nikhilesh
---
drivers/mempool/octeontx2/otx2_mempool_ops.c | 57
1 file changed, 57 insertions(+)
diff --git a/drivers/mempool/octeon
From: Jerin Jacob
The maximum number of mempools per application needs to be configured
on HW during mempool driver initialization. HW can support up to 1M
mempools, Since each mempool costs set of HW resources, the max_pools
devargs parameter is being introduced to configure the number of
mempoo
From: Jerin Jacob
Add Marvell OCTEON TX2 mempool documentation.
This patch also updates the MAINTAINERS file and
updates shared library versions in release_19_08.rst.
Cc: John McNamara
Cc: Thomas Monjalon
Signed-off-by: Jerin Jacob
Signed-off-by: Vivek Sharma
Signed-off-by: Vamsi Attunuru
61 matches
Mail list logo
