[dpdk-dev] [PATCH] devtools: better freebsd support

2019-05-23 Thread Olivier Matz
- As "readlink -e" and "readlink -m" do not exist on freebsd, use "readlink -f", it should not have any impact in these cases. - "sed -ri" is invalid on freebsd and should be replaced by "sed -r -i ''" - Use gmake instead of make. This fixes the following command: SYSDIR=/usr/src/sys ./devto

[dpdk-dev] [PATCH] devtools: pass custom options to checkpatch

2019-05-23 Thread Olivier Matz
Add the ability to pass custom options to checkpatch script. An example of use is to change the output format so it can run in emacs compilation mode: DPDK_CHECKPATCH_PATH=/path/to/linux/scripts/checkpatch.pl \ DPDK_CHECKPATCH_OPTIONS='--emacs --showfile --no-color' \ /path/to/dpdk.org/d

[dpdk-dev] [PATCH v1 01/27] common/octeontx2: add build infrastructure and HW definition

2019-05-23 Thread jerinj
From: Jerin Jacob Add the make and meson based build infrastructure along with HW definition header file. This patch adds skeleton otx2_mbox.c file to make sure all header files are intact, subsequent patches add content to otx2_mbox.c Signed-off-by: Jerin Jacob Signed-off-by: Pavan Nikhilesh

[dpdk-dev] [PATCH v1 00/27] OCTEON TX2 common and mempool driver

2019-05-23 Thread jerinj
From: Jerin Jacob This patch set adds initial driver support for OCTEON TX2 SoC. OCTEON TX2 is an armv8.2 SoC with integrated HW based mempool, ethdev, cryptodev, compressdev, and eventdev devices. This patch set adds common driver and mempool device driver for OCTEON TX2 SoC. There will be thr

[dpdk-dev] [PATCH v1 07/27] common/octeontx2: introduce common device class

2019-05-23 Thread jerinj
From: Jerin Jacob Introduce otx2_dev class to hold octeontx2 PCIe device specific information and operations. All PCIe drivers(ethdev, mempool, cryptodev and eventdev) in octeontx2, inherits this base object to avail the common functionalities such as mailbox creation, interrupt registration, et

[dpdk-dev] [PATCH v1 14/27] common/octeontx2: add FLR IRQ handler

2019-05-23 Thread jerinj
From: Nithin Dabilpuram Upon receiving FLR request from VF, It is PF responsibly forward to AF and enable FLR for VFs. This patch adds support for VF FLR support in PF. This patch also add otx2_dev_active_vfs() API to find the number of active VF for given PF. Signed-off-by: Nithin Dabilpuram

[dpdk-dev] [PATCH v1 08/27] common/octeontx2: introduce irq handling functions

2019-05-23 Thread jerinj
From: Jerin Jacob All PCIe drivers(ethdev, mempool, cryptodev and eventdev) in octeontx2, needs to handle interrupt for mailbox and error handling. Create a helper function over rte interrupt API to register, unregister, disable interrupts. Signed-off-by: Jerin Jacob Signed-off-by: Vamsi Attunu

[dpdk-dev] [PATCH v1 20/27] mempool/octeontx2: add context dump support

2019-05-23 Thread jerinj
From: Jerin Jacob Add a helper function to dump aura and pool context for NPA debugging. Signed-off-by: Jerin Jacob Signed-off-by: Vivek Sharma --- drivers/mempool/octeontx2/Makefile| 3 +- drivers/mempool/octeontx2/meson.build | 1 + drivers/mempool/octeontx2/otx2_mem

[dpdk-dev] [PATCH v1 02/27] common/octeontx2: add IO handling APIs

2019-05-23 Thread jerinj
From: Jerin Jacob Various octeontx2 drivers use IO handling API, added octeontx2 specific IO handling routines in the common code. Since some of those implementations are based on arm64 instructions added the stub to compile the code on non arm64 ISA. The non arm64 ISA stub is possible due to th

[dpdk-dev] [PATCH v1 04/27] common/octeontx2: add mailbox base support infra

2019-05-23 Thread jerinj
From: Jerin Jacob This patch adds mailbox init and fini support. Each RVU device has a dedicated 64KB mailbox region shared with its peer for communication. RVU AF has a separate mailbox region shared with each of RVU PFs and an RVU PF has a separate region shared with each of it's VF. Signed-of

[dpdk-dev] [PATCH v1 03/27] common/octeontx2: add mbox request and response definition

2019-05-23 Thread jerinj
From: Jerin Jacob The admin function driver sits in Linux kernel as mailbox server. The DPDK AF mailbox client, send the message to mailbox server to complete the administrative task such as get mac address. This patch adds mailbox request and response definition of existing mailbox defined betw

[dpdk-dev] [PATCH v1 06/27] common/octeontx2: add mailbox send and receive support

2019-05-23 Thread jerinj
From: Jerin Jacob Each RVU device has a dedicated 64KB mailbox region shared with its peer for communication. RVU AF has a separate mailbox region shared with each of RVU PFs and an RVU PF has a separate region shared with each of it's VF. This patch add use 64KB memory and implemented mailbox s

[dpdk-dev] [PATCH v1 05/27] common/octeontx2: add runtime log infra

2019-05-23 Thread jerinj
From: Jerin Jacob Various consumers of this common code need runtime logging infrastructure. This patch adds the same. Signed-off-by: Jerin Jacob --- drivers/common/octeontx2/Makefile | 1 + drivers/common/octeontx2/meson.build | 1 + drivers/common/octeontx2/otx2_common

[dpdk-dev] [PATCH v1 09/27] common/octeontx2: handle intra device operations

2019-05-23 Thread jerinj
From: Jerin Jacob The mempool device(NPA) may be provisioned as a standalone device or it can be part of ethdev/eventdev device. In order to address mempool as standalone or integrated with ethdev/eventdev device, An intra device structure being introduced. When the _first_ ethdev/eventdev PCIe

[dpdk-dev] [PATCH v1 27/27] doc: add Marvell OCTEON TX2 mempool documentation

2019-05-23 Thread jerinj
From: Jerin Jacob Add Marvell OCTEON TX2 mempool documentation. This patch also updates the MAINTAINERS file and updates shared library versions in release_19_08.rst. Cc: John McNamara Cc: Thomas Monjalon Signed-off-by: Jerin Jacob Signed-off-by: Vivek Sharma Signed-off-by: Vamsi Attunuru

[dpdk-dev] [PATCH v1 21/27] mempool/octeontx2: add mempool alloc op

2019-05-23 Thread jerinj
From: Jerin Jacob The DPDK mempool allocation reserves a single HW AURA and POOL in 1:1 map mode. Upon reservation, SW programs the slow path operations such as allocate stack memory for DMA and bunch HW configurations to respective HW blocks. Cc: Olivier Matz Signed-off-by: Jerin Jacob ---

[dpdk-dev] [PATCH v1 10/27] common/octeontx2: add AF to PF mailbox IRQ and msg handlers

2019-05-23 Thread jerinj
From: Nithin Dabilpuram This patch adds support for AF to PF mailbox interrupt and message handling. PF writes the message on mapped mailbox region followed by writing the mailbox doorbell register. Upon receiving, the mailbox request in AF(In Linux kernel), It processes the messages and update t

[dpdk-dev] [PATCH v1 12/27] common/octeontx2: add VF mailbox IRQ and msg handler

2019-05-23 Thread jerinj
From: Jerin Jacob This patch adds support for PF <-> VF mailbox interrupt mailbox message interrupt handling. Signed-off-by: Jerin Jacob --- drivers/common/octeontx2/otx2_dev.c | 78 - 1 file changed, 76 insertions(+), 2 deletions(-) diff --git a/drivers/common/oct

[dpdk-dev] [PATCH v1 16/27] mempool/octeontx2: add build infra and device probe

2019-05-23 Thread jerinj
From: Jerin Jacob Add the make and meson based build infrastructure along with the mempool(NPA) device probe. Signed-off-by: Jerin Jacob Signed-off-by: Pavan Nikhilesh --- config/common_base| 5 ++ drivers/common/Makefile | 3 + drivers/memp

[dpdk-dev] [PATCH v1 25/27] mempool/octeontx2: add optimized dequeue operation for arm64

2019-05-23 Thread jerinj
From: Pavan Nikhilesh This patch adds an optimized arm64 instruction based routine to leverage CPU pipeline characteristics of octeontx2. The theme is to fill the pipeline with CASP operations as much HW can do so that HW can do alloc() HW ops in full throttle. Cc: Olivier Matz Signed-off-by:

[dpdk-dev] [PATCH v1 11/27] common/octeontx2: add PF to VF mailbox IRQ and msg handlers

2019-05-23 Thread jerinj
From: Nithin Dabilpuram PF has additional responsibility being server for VF messages and forward to AF and once AF process it then forward the response back to VF. otx2_vf_pf_mbox_irq() will process the VF mailbox request and af_pf_wait_msg() will until getting a response back from AF. Signed-o

[dpdk-dev] [PATCH v1 18/27] mempool/octeontx2: add NPA HW operations

2019-05-23 Thread jerinj
From: Jerin Jacob Implement the low-level NPA HW operations such as alloc, free memory, etc. Signed-off-by: Jerin Jacob Signed-off-by: Kiran Kumar K --- drivers/mempool/octeontx2/otx2_mempool.h | 146 +++ 1 file changed, 146 insertions(+) diff --git a/drivers/mempool/octe

[dpdk-dev] [PATCH v1 26/27] mempool/octeontx2: add devargs for max pool selection

2019-05-23 Thread jerinj
From: Jerin Jacob The maximum number of mempools per application needs to be configured on HW during mempool driver initialization. HW can support up to 1M mempools, Since each mempool costs set of HW resources, the max_pools devargs parameter is being introduced to configure the number of mempoo

[dpdk-dev] [PATCH v1 23/27] mempool/octeontx2: add remaining slow path ops

2019-05-23 Thread jerinj
From: Jerin Jacob Add remaining get_count(), calc_mem_size() and populate() slow path mempool operations. Signed-off-by: Jerin Jacob Signed-off-by: Pavan Nikhilesh --- drivers/mempool/octeontx2/otx2_mempool_ops.c | 62 1 file changed, 62 insertions(+) diff --git a/driver

[dpdk-dev] [PATCH v1 17/27] drivers: add init and fini on octeontx2 NPA object

2019-05-23 Thread jerinj
From: Jerin Jacob NPA object needs to initialize memory for queue interrupts context, pool resource management, etc. This patch adds support for initializing and finalizing the NPA object. This patch also updates the otx2_npa_lf definition to meet the init/fini requirements. Signed-off-by: Jeri

[dpdk-dev] [PATCH v1 13/27] common/octeontx2: add uplink message support

2019-05-23 Thread jerinj
From: Nithin Dabilpuram The events like PHY link status change by AF or PHY configuration change by PF would call for the uplink message. The AF initiated uplink would land it in PF and PF would further forward to VF(if it is intended for that specific VF) The PF initiated uplink would be distri

[dpdk-dev] [PATCH v1 19/27] mempool/octeontx2: add NPA IRQ handler

2019-05-23 Thread jerinj
From: Jerin Jacob Register and implement NPA IRQ handler for RAS and all type of error interrupts to get the fatal errors from HW. Signed-off-by: Jerin Jacob Signed-off-by: Harman Kalra --- drivers/mempool/octeontx2/Makefile | 3 +- drivers/mempool/octeontx2/meson.build|

[dpdk-dev] [PATCH v1 22/27] mempool/octeontx2: add mempool free op

2019-05-23 Thread jerinj
From: Jerin Jacob The DPDK mempool free operation frees HW AURA and POOL reserved in alloc operation. In addition to that it free all the memory resources allocated in mempool alloc operations. Cc: Olivier Matz Signed-off-by: Jerin Jacob --- drivers/mempool/octeontx2/otx2_mempool_ops.c | 104

[dpdk-dev] [PATCH v1 24/27] mempool/octeontx2: add fast path mempool ops

2019-05-23 Thread jerinj
From: Jerin Jacob Add enqueue and dequeue mempool fastpath operations. Cc: Olivier Matz Signed-off-by: Jerin Jacob Signed-off-by: Pavan Nikhilesh --- drivers/mempool/octeontx2/otx2_mempool_ops.c | 57 1 file changed, 57 insertions(+) diff --git a/drivers/mempool/octeon

Re: [dpdk-dev] [PATCH] librte_eal: ease init in a docker container

2019-05-23 Thread Burakov, Anatoly
On 22-May-19 5:08 PM, Nicolas Dichtel wrote: Le 22/05/2019 à 17:57, Burakov, Anatoly a écrit : On 22-May-19 4:41 PM, Nicolas Dichtel wrote: move_pages() is only used to get the numa node id, but this function is not allowed by default in docker (it needs CAP_SYS_NICE and an update of the secco

Re: [dpdk-dev] [PATCH] librte_eal: ease init in a docker container

2019-05-23 Thread Burakov, Anatoly
On 22-May-19 4:41 PM, Nicolas Dichtel wrote: move_pages() is only used to get the numa node id, but this function is not allowed by default in docker (it needs CAP_SYS_NICE and an update of the seccomp profile). get_mempolicy() also requires CAP_SYS_NICE but doesn't need any change in the default

Re: [dpdk-dev] [PATCH] librte_eal: ease init in a docker container

2019-05-23 Thread David Marchand
s/librte_eal/mem/ for the title prefix. On Thu, May 23, 2019 at 10:56 AM Burakov, Anatoly wrote: > On 22-May-19 4:41 PM, Nicolas Dichtel wrote: > > move_pages() is only used to get the numa node id, but this function > > is not allowed by default in docker (it needs CAP_SYS_NICE and an update >

[dpdk-dev] [PATCH] net/i40e: i40e rework for ipn3ke

2019-05-23 Thread Andy Pei
Add switch_mode argument for i40e PF to specify the specific FPGA that i40e PF is connected to. i40e PF get link status update via the connected FPGA. Fixes: c60869e2b742 ("net/i40e: fix link status update") Cc: roy.fan.zh...@intel.com Cc: qi.z.zh...@intel.com Cc: jingjing...@intel.com Cc: beilei.

[dpdk-dev] [PATCH v2] mem: ease init in a docker container

2019-05-23 Thread Nicolas Dichtel
move_pages() is only used to get the numa node id, but this function is not allowed by default in docker (it needs CAP_SYS_NICE and an update of the seccomp profile). get_mempolicy() also requires CAP_SYS_NICE but doesn't need any change in the default seccomp profile. Note that the returned value

Re: [dpdk-dev] [PATCH 1/2] mk: add Marvell ARMADA architecture based on armv8-a

2019-05-23 Thread Ruifeng Wang (Arm Technology China)
Hi Liron, > -Original Message- > From: dev On Behalf Of lir...@marvell.com > Sent: Saturday, May 18, 2019 05:27 > To: tho...@monjalon.net > Cc: dev@dpdk.org; Liron Himi > Subject: [dpdk-dev] [PATCH 1/2] mk: add Marvell ARMADA architecture > based on armv8-a > > From: Liron Himi > > Th

Re: [dpdk-dev] [PATCH] devtools: better freebsd support

2019-05-23 Thread Bruce Richardson
On Thu, May 23, 2019 at 09:43:18AM +0200, Olivier Matz wrote: > - As "readlink -e" and "readlink -m" do not exist on freebsd, > use "readlink -f", it should not have any impact in these cases. > - "sed -ri" is invalid on freebsd and should be replaced by > "sed -r -i ''" > - Use gmake instead o

Re: [dpdk-dev] [PATCH 1/2] mk: add Marvell ARMADA architecture based on armv8-a

2019-05-23 Thread Liron Himi
Hi, This patch can only work with MUSDK newer than 18.09. Do you have access to a newer version? Regards, Liron -Original Message- From: Ruifeng Wang (Arm Technology China) Sent: Thursday, May 23, 2019 13:11 To: Liron Himi ; tho...@monjalon.net Cc: dev@dpdk.org; nd Subject: [EXT] RE:

Re: [dpdk-dev] [PATCH] devtools: better freebsd support

2019-05-23 Thread David Marchand
On Thu, May 23, 2019 at 12:47 PM Bruce Richardson < bruce.richard...@intel.com> wrote: > On Thu, May 23, 2019 at 09:43:18AM +0200, Olivier Matz wrote: > > - As "readlink -e" and "readlink -m" do not exist on freebsd, > > use "readlink -f", it should not have any impact in these cases. > > - "sed

Re: [dpdk-dev] [PATCH v6 00/11] al: replace calls to rte_panic and refrain from new instances

2019-05-23 Thread Thomas Monjalon
Hi Arnon, Any update about this work? Would be good to merge these patches early in 19.08 release. If you need help or more time for some of the patches, do not hesitate to split the work. We could merge obvious patches first. Thanks 09/05/2019 15:16, Thomas Monjalon: > 09/05/2019 14:05, Burako

Re: [dpdk-dev] [PATCH 1/3] doc: robustify PDF build

2019-05-23 Thread Mcnamara, John
> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Wednesday, May 22, 2019 9:29 PM > To: dev@dpdk.org; Mcnamara, John ; Kovacevic, > Marko > Cc: sta...@dpdk.org > Subject: [PATCH 1/3] doc: robustify PDF build > > In some environment like the current dpdk.

Re: [dpdk-dev] [PATCH 3/3] doc: clean PDF config

2019-05-23 Thread Mcnamara, John
> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Wednesday, May 22, 2019 9:29 PM > To: dev@dpdk.org; Mcnamara, John ; Kovacevic, > Marko > Subject: [PATCH 3/3] doc: clean PDF config > > Some font options do not look necessary. > Acked-by: John McNamar

Re: [dpdk-dev] [PATCH 2/3] doc: fix PDF with greek letter

2019-05-23 Thread Mcnamara, John
> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Wednesday, May 22, 2019 9:29 PM > To: dev@dpdk.org; Mcnamara, John ; Kovacevic, > Marko > Cc: sta...@dpdk.org > Subject: [PATCH 2/3] doc: fix PDF with greek letter > > For an unknown reason, the sign "μ" i

Re: [dpdk-dev] [PATCH 00/15] prefix network structures

2019-05-23 Thread Maxime Coquelin
On 5/21/19 6:13 PM, Olivier Matz wrote: The rte_net headers conflict with the libc headers, because some definitions are duplicated, sometimes with few differences. This patchset adds the rte_ (or RTE_) prefix to all structures, functions and defines in rte_net library. This is a big changese

Re: [dpdk-dev] [PATCH 01/11] net/bnxt: move tx bd checking to header file

2019-05-23 Thread Maxime Coquelin
On 5/21/19 11:39 PM, Ajit Khaparde wrote: From: Lance Richardson To allow sharing of tx_bds_in_hw() and bnxt_tx_avail() between vector-mode and non-vector transmit functions, move these functions into bnxt_txr.h. Signed-off-by: Lance Richardson Reviewed-by: Ajit Khaparde --- drivers/net

[dpdk-dev] DPDK Release Status Meeting 23/5/2019

2019-05-23 Thread Mcnamara, John
Minutes 23 May 2019 --- Agenda: * Release Dates * Subtrees * LTS * OvS * Opens Participants: * ARM * Broadcom * Debian/Microsoft * Intel * Marvell * Mellanox * RedHat Release Dates - * v19.08 dates: * Proposal/V1 Monday 03 June 2019 * Integrati

Re: [dpdk-dev] [PATCH 02/11] net/bnxt: compute and store scattered RX status

2019-05-23 Thread Maxime Coquelin
On 5/21/19 11:39 PM, Ajit Khaparde wrote: From: Lance Richardson In preparation for a bnxt vector-mode driver, compute and store scattered_rx status for the device when started. Signed-off-by: Lance Richardson Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_ethdev.c | 23 +

Re: [dpdk-dev] [PATCH] devtools: pass custom options to checkpatch

2019-05-23 Thread Thomas Monjalon
23/05/2019 09:45, Olivier Matz: > Add the ability to pass custom options to checkpatch script. An example > of use is to change the output format so it can run in emacs compilation > mode: > > DPDK_CHECKPATCH_PATH=/path/to/linux/scripts/checkpatch.pl \ > DPDK_CHECKPATCH_OPTIONS='--emacs --sh

[dpdk-dev] [PATCH v2] ipsec: include high order bytes of esn in pkt len

2019-05-23 Thread Lukasz Bartosik
When esn is used then high-order 32 bits are included in ICV calculation however are not transmitted. Update packet length to be consistent with auth data offset and length before crypto operation. High-order 32 bits of esn will be removed from packet length in crypto post processing. Signed-off-b

Re: [dpdk-dev] [PATCH 03/11] net/bnxt: implement vector mode driver

2019-05-23 Thread Maxime Coquelin
On 5/21/19 11:39 PM, Ajit Khaparde wrote: From: Lance Richardson Introduce vector mode support for the bnxt pmd. Signed-off-by: Lance Richardson Signed-off-by: Ajit Khaparde --- config/common_base | 1 + drivers/net/bnxt/Makefile| 1 + drivers/net/bnx

Re: [dpdk-dev] [PATCH 04/11] net/bnxt: fix double counting VLAN tags

2019-05-23 Thread Maxime Coquelin
On 5/21/19 11:39 PM, Ajit Khaparde wrote: From: Lance Richardson When determining whether scattered receive mode is needed, the size of a QinQ header is being added to rxmode.max_rx_pkt_len before comparing to the receive buffer size, however max_rx_pkt_len already accounts for the QinQ head

Re: [dpdk-dev] [PATCH v2 1/2] test/hash: use existing lcore API

2019-05-23 Thread Maxime Coquelin
On 5/22/19 5:06 PM, David Marchand wrote: Prefer the existing apis rather than direct access the configuration structure. test_hash_multi_add_lookup() currently starts n readers and N writers using rte_eal_remote_launch(). It then waits for the N writers to complete with a custom multi_writer

Re: [dpdk-dev] [PATCH 2/3] net/i40e: add runtime option to disable vector rx

2019-05-23 Thread Jerin Jacob Kollanukkaran
> -Original Message- > From: dev On Behalf Of Zhang, Qi Z > Sent: Wednesday, May 22, 2019 8:03 PM > To: Thomas Monjalon ; Ananyev, Konstantin > > Cc: Ergin, Mesut A ; Xing, Beilei > ; dev@dpdk.org; Yigit, Ferruh > ; Andrew Rybchenko > > Subject: Re: [dpdk-dev] [PATCH 2/3] net/i40e: add r

Re: [dpdk-dev] [PATCH v6 00/11] al: replace calls to rte_panic and refrain from new instances

2019-05-23 Thread Arnon Warshavsky
Hi, I plan to work on it on the first week of June. Will be pretty much off-grid till then. thanks /Arnon

Re: [dpdk-dev] [PATCH] devtools: pass custom options to checkpatch

2019-05-23 Thread Bruce Richardson
On Thu, May 23, 2019 at 01:50:41PM +0200, Thomas Monjalon wrote: > 23/05/2019 09:45, Olivier Matz: > > Add the ability to pass custom options to checkpatch script. An example > > of use is to change the output format so it can run in emacs compilation > > mode: > > > > DPDK_CHECKPATCH_PATH=/path

[dpdk-dev] [PATCH v2] doc/testpmd: update compile steps for bpf examples

2019-05-23 Thread Vipin Varghese
Add note in the missing arguments for compiling BPF examples. Signed-off-by: Vipin Varghese Acked-by: John McNamara --- V2: - ACK for documentation - John McNamara - move to compile section - Thomas Monjalon --- doc/guides/testpmd_app_ug/testpmd_funcs.rst | 4 1 file changed, 4 inserti

Re: [dpdk-dev] DPDK Release Status Meeting 23/5/2019

2019-05-23 Thread David Marchand
On Thu, May 23, 2019 at 1:47 PM Mcnamara, John wrote: > Minutes 23 May 2019 > --- > > [snip] OvS > --- > > * 18.11.2 RC1 is out. > * Need to look at the impact of the rte_prefix. > It has an impact on OvS (checked with dpdk-latest) even if the fix should be not that difficult an

[dpdk-dev] [PATCH v4 0/5] make lcore_config internal

2019-05-23 Thread David Marchand
This set of patches makes the lcore_config structure less visible as part of the ABI. This version does not break the ABI (yet) follow on patch moves lcore_config into eal_private.h Changelog since v3: I took the liberty of taking over Stephen series. I rebased and did some adjustments following

[dpdk-dev] [PATCH v4 1/5] eal: use unsigned int in lcore API prototypes

2019-05-23 Thread David Marchand
From: Stephen Hemminger Purely cosmetic change, use unsigned int instead of unsigned alone. Signed-off-by: Stephen Hemminger Signed-off-by: David Marchand --- lib/librte_eal/common/include/rte_lcore.h | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) Changelog since v3: - up

[dpdk-dev] [PATCH v4 2/5] eal: add lcore accessors

2019-05-23 Thread David Marchand
From: Stephen Hemminger The fields of the internal EAL core configuration are currently laid bare as part of the API. This is not good practice and limits fixing issues with layout and sizes. Make new accessor functions for the fields used by current drivers and examples. Signed-off-by: Stephen

[dpdk-dev] [PATCH v4 3/5] drivers/bus: use lcore accessors

2019-05-23 Thread David Marchand
From: Stephen Hemminger The lcore_config structure will be hidden in future release. Signed-off-by: Stephen Hemminger Signed-off-by: David Marchand --- drivers/bus/dpaa/dpaa_bus.c | 6 -- drivers/bus/fslmc/portal/dpaa2_hw_dpio.c | 4 +++- 2 files changed, 7 insertions(+), 3 d

[dpdk-dev] [PATCH v4 5/5] test: use lcore accessors

2019-05-23 Thread David Marchand
From: Stephen Hemminger Don't refer to lcore_config directly. Signed-off-by: Stephen Hemminger Signed-off-by: David Marchand --- app/test/test_cryptodev.c | 2 +- app/test/test_ring_perf.c | 22 -- app/test/test_stack_perf.c | 20 ++-- 3 files changed, 2

[dpdk-dev] [PATCH v4 4/5] examples/bond: use lcore accessors

2019-05-23 Thread David Marchand
From: Stephen Hemminger Referring to lcore_config directly is no longer recommended. Also remove unnecessary assignment of slave_core_id. Signed-off-by: Stephen Hemminger Signed-off-by: David Marchand --- examples/bond/main.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-)

Re: [dpdk-dev] [PATCH v2 2/2] test/rcu: use existing lcore API

2019-05-23 Thread Maxime Coquelin
On 5/22/19 5:06 PM, David Marchand wrote: Prefer the existing apis rather than direct access lcore_config that is going to disappear. Fixes: b87089b0bb19 ("test/rcu: add API and functional tests") Cc: sta...@dpdk.org Signed-off-by: David Marchand Reviewed-by: Maxime Coquelin Acked-by: Honn

Re: [dpdk-dev] [PATCH] devtools: skip the symbol check when map file under drivers

2019-05-23 Thread Jerin Jacob Kollanukkaran
> -Original Message- > From: Neil Horman > Sent: Thursday, May 23, 2019 12:29 AM > To: Jerin Jacob Kollanukkaran > Cc: Bruce Richardson ; dev@dpdk.org; > tho...@monjalon.net; sta...@dpdk.org > Subject: Re: [EXT] Re: [dpdk-dev] Re: [PATCH] devtools: skip the symbol > check when map file

[dpdk-dev] [Bug 284] Secondary not able to Rx/TX after primary dies in symmetric multiprocess

2019-05-23 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=284 Bug ID: 284 Summary: Secondary not able to Rx/TX after primary dies in symmetric multiprocess Product: DPDK Version: 18.11 Hardware: x86 OS: Linux Status

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] mem: ease init in a docker container

2019-05-23 Thread David Marchand
On Thu, May 23, 2019 at 11:53 AM Nicolas Dichtel wrote: > move_pages() is only used to get the numa node id, but this function > is not allowed by default in docker (it needs CAP_SYS_NICE and an update of > the seccomp profile). > get_mempolicy() also requires CAP_SYS_NICE but doesn't need any ch

Re: [dpdk-dev] [PATCH 3/5] vhost: do not inline unlikely fragmented buffers code

2019-05-23 Thread Maxime Coquelin
Hi Mattias, On 5/21/19 9:43 PM, Mattias Rönnblom wrote: On 2019-05-17 14:22, Maxime Coquelin wrote: Handling of fragmented virtio-net header and indirect descriptors tables was implemented to fix CVE-2018-1059. It should not never happen with healthy guests and so are already considered as unli

[dpdk-dev] [PATCH 1/2] examples: strip directory and use suffix as name

2019-05-23 Thread Ali Alnubani
This would allow correctly naming an application residing in a subdirectory. For example, if the example is set to 'path/to/app', then the name would be 'app'. This doesn't affect the naming of an example that isn't in a subdirectory. Signed-off-by: Ali Alnubani --- examples/meson.build | 2 +-

[dpdk-dev] [PATCH 2/2] examples: enable building multiprocess applications

2019-05-23 Thread Ali Alnubani
This enables building the example multiprocess applications in the subdirectory multi_process. Signed-off-by: Ali Alnubani --- examples/meson.build | 8 +++- .../client_server_mp/mp_client/meson.build | 14 ++ .../client_server_mp/mp_server/

Re: [dpdk-dev] [PATCH v4 0/5] make lcore_config internal

2019-05-23 Thread Stephen Hemminger
On Thu, 23 May 2019 15:58:56 +0200 David Marchand wrote: > This set of patches makes the lcore_config structure less visible > as part of the ABI. This version does not break the ABI (yet) > follow on patch moves lcore_config into eal_private.h > > Changelog since v3: > I took the liberty of ta

Re: [dpdk-dev] [PATCH 3/5] vhost: do not inline unlikely fragmented buffers code

2019-05-23 Thread Mattias Rönnblom
On 2019-05-23 16:30, Maxime Coquelin wrote: Hi Mattias, On 5/21/19 9:43 PM, Mattias Rönnblom wrote: On 2019-05-17 14:22, Maxime Coquelin wrote: Handling of fragmented virtio-net header and indirect descriptors tables was implemented to fix CVE-2018-1059. It should not never happen with healthy

Re: [dpdk-dev] [PATCH 2/2] examples: enable building multiprocess applications

2019-05-23 Thread Bruce Richardson
On Thu, May 23, 2019 at 02:54:13PM +, Ali Alnubani wrote: > This enables building the example multiprocess applications in > the subdirectory multi_process. > > Signed-off-by: Ali Alnubani > --- > examples/meson.build | 8 +++- > .../client_server_mp/mp_cli

Re: [dpdk-dev] [PATCH 3/5] vhost: do not inline unlikely fragmented buffers code

2019-05-23 Thread Maxime Coquelin
On 5/23/19 5:17 PM, Mattias Rönnblom wrote: On 2019-05-23 16:30, Maxime Coquelin wrote: Hi Mattias, On 5/21/19 9:43 PM, Mattias Rönnblom wrote: On 2019-05-17 14:22, Maxime Coquelin wrote: Handling of fragmented virtio-net header and indirect descriptors tables was implemented to fix CVE-20

[dpdk-dev] [PATCH 1/2] examples: strip directory and use suffix as name

2019-05-23 Thread Ali Alnubani
This would allow correctly naming an application residing in a subdirectory. For example, if the example is set to 'path/to/app', then the name would be 'app'. This doesn't affect the naming of an example that isn't in a subdirectory. Signed-off-by: Ali Alnubani --- examples/meson.build | 2 +-

[dpdk-dev] [PATCH 2/2] examples: enable building multiprocess applications

2019-05-23 Thread Ali Alnubani
This enables building the example multiprocess applications in the subdirectory multi_process. Signed-off-by: Ali Alnubani --- Changes in v2: - Removed unnecessary name assignment. - Reordered all_examples list. examples/meson.build| 7 ++- .../client_se

Re: [dpdk-dev] [PATCH 2/3] net/i40e: add runtime option to disable vector rx

2019-05-23 Thread Ergin, Mesut A
> > > > > If you plan to use FD mode on your device, why not enable it > > > > > at setup phase via rte_eth_dev_configure()? > > > > > Then proper rx function would be selected. > > > > > > > > > > > > > FDIR_MODE was designed to bind late automatically -- it is set when the > first > > > > filter

Re: [dpdk-dev] [PATCH 2/2] examples: enable building multiprocess applications

2019-05-23 Thread Ali Alnubani
Hi Bruce, Comments are inline. > -Original Message- > From: Bruce Richardson > Sent: Thursday, May 23, 2019 6:33 PM > To: Ali Alnubani > Cc: dev@dpdk.org; bl...@debian.org > Subject: Re: [PATCH 2/2] examples: enable building multiprocess applications > > On Thu, May 23, 2019 at 02:54:13

[dpdk-dev] [PATCH] net/i40e: Fail rte_flow MARK requests if RX func was vectorized

2019-05-23 Thread Mesut Ali Ergin
Runtime requests to install an rte_flow with MARK action should fail if a vector RX function was already chosen for the device during configuration time. Currently, i40e rte_flow driver would successfully install the flow with MARK action, even when vector RX functions are in use. However, those v

Re: [dpdk-dev] [PATCH] devtools: skip the symbol check when map file under drivers

2019-05-23 Thread Neil Horman
On Thu, May 23, 2019 at 02:21:29PM +, Jerin Jacob Kollanukkaran wrote: > > > > -Original Message- > > From: Neil Horman > > Sent: Thursday, May 23, 2019 12:29 AM > > To: Jerin Jacob Kollanukkaran > > Cc: Bruce Richardson ; dev@dpdk.org; > > tho...@monjalon.net; sta...@dpdk.org > > S

Re: [dpdk-dev] [PATCH 3/3] net/i40e: fix inadvertent override of vector RX allowance

2019-05-23 Thread Ergin, Mesut A
Hi Qi, > -Original Message- > From: Zhang, Qi Z > Sent: Wednesday, May 22, 2019 5:42 AM > To: Ergin, Mesut A ; Xing, Beilei > > Cc: dev@dpdk.org > Subject: RE: [PATCH 3/3] net/i40e: fix inadvertent override of vector RX > allowance > > Hi Mesut: > > > -Original Message- > > From

Re: [dpdk-dev] [PATCH 1/2] examples: strip directory and use suffix as name

2019-05-23 Thread Luca Boccassi
On Thu, 2019-05-23 at 17:40 +, Ali Alnubani wrote: > This would allow correctly naming an application residing > in a subdirectory. For example, if the example is set to > 'path/to/app', > then the name would be 'app'. > This doesn't affect the naming of an example that isn't in a > subdirector

Re: [dpdk-dev] [PATCH 2/2] examples: enable building multiprocess applications

2019-05-23 Thread Luca Boccassi
On Thu, 2019-05-23 at 17:40 +, Ali Alnubani wrote: > This enables building the example multiprocess applications in > the subdirectory multi_process. > > Signed-off-by: Ali Alnubani < > alia...@mellanox.com > > > --- > Changes in v2: > - Removed unnecessary name assignment. > - Reordered a

Re: [dpdk-dev] [PATCH 04/11] net/bnxt: fix double counting VLAN tags

2019-05-23 Thread Lance Richardson
On Thu, May 23, 2019 at 8:21 AM Maxime Coquelin wrote: ... > Isn't it fixing patch 2? > If so, Fixes line is wrong, and it should be squashed directly into > patch 2. Yes... thanks, will fix in v2. Lance

Re: [dpdk-dev] [PATCH] devtools: skip the symbol check when map file under drivers

2019-05-23 Thread Thomas Monjalon
23/05/2019 19:57, Neil Horman: > On Thu, May 23, 2019 at 02:21:29PM +, Jerin Jacob Kollanukkaran wrote: > > From: Neil Horman > > > > > > > > IMO, The name prefix matters. The rte_* should denote it a > > > > > > > > DPDK API and application suppose to use it. > > > > > > > > > > > > > > > It

Re: [dpdk-dev] [PATCH 03/11] net/bnxt: implement vector mode driver

2019-05-23 Thread Lance Richardson
Hi Maxime, thanks for taking the time to review this. On Thu, May 23, 2019 at 8:18 AM Maxime Coquelin wrote: ... > How do we enable it with Meson build? It seems to be missing. Ah, thanks for pointing that out, I had completely missed the Meson piece. Will fix in v2. > > I think we would better

Re: [dpdk-dev] [PATCH] devtools: skip the symbol check when map file under drivers

2019-05-23 Thread Neil Horman
On Thu, May 23, 2019 at 08:59:07PM +0200, Thomas Monjalon wrote: > 23/05/2019 19:57, Neil Horman: > > On Thu, May 23, 2019 at 02:21:29PM +, Jerin Jacob Kollanukkaran wrote: > > > From: Neil Horman > > > > > > > > > IMO, The name prefix matters. The rte_* should denote it a > > > > > > > > > DP

[dpdk-dev] [PATCH] net/vdev_netvsc: print warning if Mellanox devices are not configured

2019-05-23 Thread Stephen Hemminger
Several users have run into problems where the MLX drivers were not enabled in their build. And then trying to run their DPDK application on Azure. What happens is that all packets go over the slow path, and failsafe repeatedly probes for never existing sub-device. Both Mellanox drivers should be

[dpdk-dev] [PATCH] net/ixgbe: enable new device

2019-05-23 Thread Beilei Xing
This patch enables new device, the device id is 0x15B0. Signed-off-by: Beilei Xing --- drivers/net/ixgbe/ixgbe_ethdev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c index 2470c89..ae8cb48 100644 --- a/drivers/net/ixgbe/ix

Re: [dpdk-dev] [PATCH] net/i40e: i40e rework for ipn3ke

2019-05-23 Thread Xu, Rosen
Hi, > -Original Message- > From: Pei, Andy > Sent: Thursday, May 23, 2019 17:15 > To: dev@dpdk.org > Cc: Pei, Andy ; Zhang, Roy Fan > ; Zhang, Qi Z ; Wu, > Jingjing ; Xing, Beilei ; Yigit, > Ferruh ; Xu, Rosen > Subject: [PATCH] net/i40e: i40e rework for ipn3ke > Add switch_mode argument

Re: [dpdk-dev] [PATCH 1/2] mk: add Marvell ARMADA architecture based on armv8-a

2019-05-23 Thread Ruifeng Wang (Arm Technology China)
Hi, > -Original Message- > From: Liron Himi > Sent: Thursday, May 23, 2019 18:51 > To: Ruifeng Wang (Arm Technology China) ; > tho...@monjalon.net > Cc: dev@dpdk.org; nd ; Liron Himi > Subject: RE: [dpdk-dev] [PATCH 1/2] mk: add Marvell ARMADA architecture > based on armv8-a > > Hi, >

Re: [dpdk-dev] [dpdk-stable] [PATCH] app/testpmd: fix offloads overwrite by default configuration

2019-05-23 Thread Zhao1, Wei
Hi, Ferruh > -Original Message- > From: Yigit, Ferruh > Sent: Tuesday, May 21, 2019 11:43 PM > To: Zhao1, Wei ; dev@dpdk.org > Cc: sta...@dpdk.org; Peng, Yuan ; Lu, Wenzhuo > > Subject: Re: [dpdk-stable] [PATCH] app/testpmd: fix offloads overwrite by > default configuration > > On 5/21/

Re: [dpdk-dev] [PATCH 3/3] net/i40e: fix inadvertent override of vector RX allowance

2019-05-23 Thread Zhang, Qi Z
Hi Meset: > -Original Message- > From: Ergin, Mesut A > Sent: Friday, May 24, 2019 2:26 AM > To: Zhang, Qi Z ; Xing, Beilei > Cc: dev@dpdk.org > Subject: RE: [PATCH 3/3] net/i40e: fix inadvertent override of vector RX > allowance > > Hi Qi, > > > -Original Message- > > From: Zha

Re: [dpdk-dev] [PATCH] net/i40e: Fail rte_flow MARK requests if RX func was vectorized

2019-05-23 Thread Zhang, Qi Z
Hi Mesut: > -Original Message- > From: Ergin, Mesut A > Sent: Friday, May 24, 2019 1:57 AM > To: Xing, Beilei ; Zhang, Qi Z > Cc: dev@dpdk.org; Ergin, Mesut A > Subject: [PATCH] net/i40e: Fail rte_flow MARK requests if RX func was > vectorized > > Runtime requests to install an rte_flow

Re: [dpdk-dev] [DPDK] net/ipn3ke: modifications on AFU configurations

2019-05-23 Thread Xu, Rosen
Hi, > -Original Message- > From: Wei, Dan > Sent: Friday, May 24, 2019 23:01 > To: dev@dpdk.org > Cc: Yigit, Ferruh ; Chen, Santos > ; Wei, Dan ; Xu, Rosen > ; sta...@dpdk.org > Subject: [DPDK] net/ipn3ke: modifications on AFU configurations Pls figure out exact modification in title. My