Re: [dpdk-dev] [PATCH] ipsec: include high order bytes of esn in pkt len

2019-05-19 Thread Ananyev, Konstantin
Hi Lukasz, Thanks for clarifications. Looks good in general. Few small comments below. Konstantin > When esn is used then high-order 32 bits are included in ICV > calculation however are not transmitted. Update packet length > to be consistent with auth data offset and length before crypto > op

Re: [dpdk-dev] [PATCH v1] lib/ipsec: add support for header construction

2019-05-19 Thread Ananyev, Konstantin
Hi, > > Add support for RFC 4301(5.1.2) to update of > Type of service field and Traffic class field > bits inside ipv4/ipv6 packets for outbound cases > and inbound cases which deals with the update of > the DSCP/ENC bits inside each of the fields. > > Signed-off-by: Marko Kovacevic > --- > e

Re: [dpdk-dev] [PATCH 1/6] eal: replace libc-based random number generation with LFSR

2019-05-19 Thread Neil Horman
On Fri, May 17, 2019 at 11:10:25PM +0200, Mattias Rönnblom wrote: > On 2019-05-17 21:27, Neil Horman wrote: > > > > > > diff --git a/lib/librte_eal/common/rte_random.c > > > > > b/lib/librte_eal/common/rte_random.c > > > > > new file mode 100644 > > > > > index 0..4d3cf5226 > > > > > ---

Re: [dpdk-dev] Instability of port ids

2019-05-19 Thread Jay Rolette
On Fri, May 17, 2019 at 1:46 PM Stephen Hemminger < step...@networkplumber.org> wrote: > Several customers have reported similar issues with how the owned/stack > device model > works in DPDK. With failsafe/tap and VF or netvsc and VF there are DPDK > ports which > are marked as owned and therefor

Re: [dpdk-dev] [PATCH v4] vhost: support inflight share memory protocol feature

2019-05-19 Thread Tiwei Bie
On Fri, May 17, 2019 at 05:47:07PM +0200, Maxime Coquelin wrote: > On 5/5/19 11:02 AM, Li Lin wrote: [...] > > /** > >* Device structure contains all configuration information relating > >* to the device. > > @@ -303,6 +314,7 @@ struct virtio_net { > > uint32_tnr_vring

Re: [dpdk-dev] [PATCH v2 1/5] vhost: un-inline dirty pages logging functions

2019-05-19 Thread Tiwei Bie
On Fri, May 17, 2019 at 05:06:09PM +0200, Maxime Coquelin wrote: [...] > +void > +__vhost_log_cache_write(struct virtio_net *dev, struct vhost_virtqueue *vq, > + uint64_t addr, uint64_t len) > +{ > + uint64_t page; > + > + if (unlikely(!dev->log_base || !len)) > +

Re: [dpdk-dev] [PATCH v2 2/5] vhost: do not inline packed and split functions

2019-05-19 Thread Tiwei Bie
On Fri, May 17, 2019 at 05:06:10PM +0200, Maxime Coquelin wrote: > At runtime either packed Tx/Rx functions will always be called, > or split Tx/Rx functions will always be called. > > This patch removes the forced inlining in order to reduce > the I-cache pressure. > > Signed-off-by: Maxime Coqu

Re: [dpdk-dev] [PATCH v2 3/5] vhost: do not inline unlikely fragmented buffers code

2019-05-19 Thread Tiwei Bie
On Fri, May 17, 2019 at 05:06:11PM +0200, Maxime Coquelin wrote: [...] > > +static void > +copy_vnet_hdr_from_desc(struct virtio_net_hdr *hdr, > + struct buf_vector *buf_vec) > +{ > + uint64_t len; > + uint64_t remain = sizeof(struct virtio_net_hdr); > + uint64_t src; > +