[dpdk-dev] [PATCH 1/3] net/i40e: fix invalid Tx threshold setup

Tx desc's DD status is not cleaned by NIC automatically after packets have been transmitted until software refill a new packet during next loop. So when tx_free_thresh + tx_rs_thresh > nb_desc, it is possible that an outdated DD status be checked as tx_next_dd, then segment fault happen due to free

[dpdk-dev] [PATCH 0/3] fix invalid Tx threshhold setup

When tx_free_thresh + tx_rs_thresh > nb_desc, it is possible that an outdated DD status be checked as tx_next_dd, then segment fault happen due to free a NULL mbuf pointer. The issue usually happens with an aggresive tx_free_thresh, for example: ./testpmd -c 0x3 -n 4 -- -i --rxq=16 --txq=16 --rxd

[dpdk-dev] [PATCH 3/3] net/ixgbe: fix invalid Tx threshold setup

Tx desc's DD status is not cleaned by NIC automatically after packets have been transmitted until software refill a new packet during next loop. So when tx_free_thresh + tx_rs_thresh > nb_desc, it is possible that an outdated DD status be checked as tx_next_dd, then segment fault happen due to free

[dpdk-dev] [PATCH 2/3] net/ice: fix invalid Tx threshold setup

Tx desc's DD status is not cleaned by NIC automatically after packets have been transmitted until software refill a new packet during next loop. So when tx_free_thresh + tx_rs_thresh > nb_desc, it is possible that an outdated DD status be checked as tx_next_dd, then segment fault happen due to free

[dpdk-dev] [PATCH] net/ice: set min and max MTU

This commit sets the min and max supported MTU values for ice devices via the i40e_dev_info_get() function. Min MTU supported is set to ETHER_MIN_MTU and max mtu is calculated as the max packet length supported minus the transport overhead. Signed-off-by: Qi Zhang --- drivers/net/ice/ice_ethdev.

[dpdk-dev] [PATCH] net/iavf: enable more link speed

Enable advanced link speed mode (VIRTCHNL_VF_CAP_ADV_LINK_SPEED) so iavf PMD can identify more link speed that reported by pf. Cc: sta...@dpdk.org Signed-off-by: Qi Zhang --- drivers/net/iavf/base/virtchnl.h | 17 - drivers/net/iavf/iavf.h | 2 +- drivers/net/iavf/iavf

Re: [dpdk-dev] [PATCH] doc: add cryptodev gcm iv deprecation notice

+1 Regards, Liron -Original Message- From: Trahe, Fiona Sent: Friday, May 3, 2019 9:10 PM To: Doherty, Declan ; ravi1.ku...@amd.com; t...@semihalf.com; Liron Himi ; Alan Winkowski Cc: De Lara Guarch, Pablo ; dev@dpdk.org; Kusztal, ArkadiuszX ; Anoob Joseph ; Shally Verma ; akhil.go

Re: [dpdk-dev] [PATCH v2] cryptodev: add an option to support both iv and J0 for GCM

> -Original Message- > From: dev On Behalf Of Arek Kusztal > Sent: Wednesday, April 17, 2019 9:28 PM > To: dev@dpdk.org > Cc: akhil.go...@nxp.com; fiona.tr...@intel.com; > pablo.de.lara.gua...@intel.com; Arek Kusztal > Subject: [dpdk-dev] [PATCH v2] cryptodev: add an option to support bot

Re: [dpdk-dev] [PATCH] Revert "app/testpmd: set fixed flag for exact link speed"

02/05/2019 22:27, Thomas Monjalon: > 02/05/2019 20:31, Ferruh Yigit: > > On 4/29/2019 10:52 AM, Thomas Monjalon wrote: > > > 25/04/2019 17:27, Ferruh Yigit: > > >> On 4/25/2019 2:29 PM, Thomas Monjalon wrote: > > >>> 25/04/2019 13:47, Ferruh Yigit: > > On 4/25/2019 9:19 AM, Thomas Monjalon wro

Re: [dpdk-dev] [PATCH v3] app/test: replace TEST_SKIPPED with -ENOTSUP

24/04/2019 21:28, Ayuj Verma: > - Return -ENOTSUP for unsupported tests Sorry if you already explained it before, please could you add the reason for this change in the commit log?

Re: [dpdk-dev] [dpdk-stable] [PATCH] test: clean remaining trace of removed devargs ut

30/04/2019 12:15, Gaëtan Rivet: > Hello David, > > On Mon, Apr 29, 2019 at 04:32:45PM +0200, David Marchand wrote: > > This test has been removed by the commit 83945fbd7c49 ("test: remove > > devargs unit tests") which left some trace in meson and reintroduced in > > autotest by the second commit

Re: [dpdk-dev] [PATCH] test: load tests symbols from binary at init

29/04/2019 16:41, Burakov, Anatoly: > On 29-Apr-19 3:28 PM, David Marchand wrote: > > Rather than call nm on the test application binary for each test to > > consider, call it once at the object init. > > > > Signed-off-by: David Marchand > > LGTM > > Acked-by: Anatoly Burakov Applied, thanks

Re: [dpdk-dev] [PATCH v8] app/pdump: add pudmp exits with primary support

Hi, 03/05/2019 07:48, Suanming. Mou: > When primary app exits, the residual running pdump will stop the > primary app to restart. Add pdump exits with primary support. Sorry I fail to parse this sentence. Maybe it should be longer to be more explicit about what it the current issue and how it is

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] doc: update references to removed function

> > Remove references to the (deleted) rte_event_port_enqueue_depth() function > > in the Doxygen comments for rte_event_enqueue_burst() and friends, and > > replace with references to rte_event_port_attr_get(). > > > > Fixes: 78ffab961155 ("eventdev: add port attribute function") > > Fixes: c9bf8

Re: [dpdk-dev] [PATCH] doc: fix rte_hash_hash comment for ambiguity

> > rte_hash_hash is multi-thread safe but not multi-process safe because of > > the use of function pointers. Previous document and comment says the other > > way around. This commit fixes the issue. > > Acked-by: John McNamara Applied, thanks

Re: [dpdk-dev] [PATCH] doc: fix broken link in programmers guide lpm library references

01/05/2019 16:12, Mcnamara, John: > From: Lipiec, Herakliusz > > > > Bugzilla ID: 235 > > The fix is good and should be applied. > > However, if viewed strictly, that `Link text `_ syntax is only > required if the link text and the url are different. > > So in this case you could

Re: [dpdk-dev] [PATCH] doc: update release notes for new armv8 targets

> > From: Jerin Jacob > > > > Added documentation for the new armv8 targets supported in 19.05 release. > > Acked-by: John McNamara Changed the formatting and applied, thanks.

Re: [dpdk-dev] [PATCH v2] doc: update release notes for windows support

23/04/2019 20:12, Pallavi Kadam: > Added documentation for Windows support on 19.05 release. > > Signed-off-by: Pallavi Kadam > Reviewed-by: Anand Rawat > Reviewed-by: Ranjit Menon > --- > +* **Added Windows Support.** > + > + Added Windows support to compile and build Hello World Sample Appli

Re: [dpdk-dev] [PATCH v8 0/2] guide to debug and troubleshoot.

09/04/2019 08:33, Vipin Varghese: > The patch series adds a how-to guide for debugging and > troubleshooting tips. > > Motivation > == > > DPDK proc-info tool is been enhanced to accommodate the debug information > for the port, traffic manager crypto, ring and mempool contents. With thes

[dpdk-dev] [dpdk-announce] release candidate 19.05-rc3

A new DPDK release candidate is ready for testing: https://git.dpdk.org/dpdk/tag/?id=v19.05-rc3 The release notes are almost complete: http://doc.dpdk.org/guides/rel_notes/release_19_05.html Please hurry up to do the last checks and bug fixes this week, in order to have DPDK 19.05

Re: [dpdk-dev] [PATCH v8] app/pdump: add pudmp exits with primary support

On 2019/5/5 5:17, Thomas Monjalon wrote: Hi, 03/05/2019 07:48, Suanming. Mou: When primary app exits, the residual running pdump will stop the primary app to restart. Add pdump exits with primary support. Sorry I fail to parse this sentence. Maybe it should be longer to be more explicit abou

Re: [dpdk-dev] [PATCH] net/iavf: enable more link speed

Acked-by: Wei Zhao > -Original Message- > From: Zhang, Qi Z > Sent: Saturday, May 4, 2019 10:09 PM > To: Lu, Wenzhuo ; Zhao1, Wei > Cc: Stillwell Jr, Paul M ; dev@dpdk.org; Zhang, > Qi Z ; sta...@dpdk.org > Subject: [PATCH] net/iavf: enable more link speed > > Enable advanced link spee

[dpdk-dev] [PATCH] net/i40e: add new device id for X710/XXV710 of IPN3KE

New pci device ids are created to support X710/XXV710 of Intel FPGA Programmable Acceleration card N3000, also called ipn3ke. Signed-off-by: Rosen Xu --- drivers/net/i40e/base/i40e_common.c | 2 ++ drivers/net/i40e/base/i40e_devids.h | 2 ++ drivers/net/i40e/i40e_ethdev.c | 2 ++ 3 files ch

[dpdk-dev] [PATCH] net/ice: minor code cleanups

This patch is a cleanup on comment, variable modifier, coding style. Signed-off-by: Xiao Wang --- drivers/net/ice/ice_ethdev.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c index 1f06a2c80..706632424 100644 -

[dpdk-dev] [PATCH] net/ice: fix EEPROM range check

The last word should not cross shadow RAM boundary. Fixes: 68a1ab82ad74 ("net/ice: speed up to retrieve EEPROM") Cc: sta...@dpdk.org Signed-off-by: Xiao Wang --- drivers/net/ice/ice_ethdev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ice/ice_ethdev.c b/d