Hi Yongseok,
PSB,
Ori
> -Original Message-
> From: Yongseok Koh
> Sent: Wednesday, April 24, 2019 12:03 AM
> To: Ori Kam
> Cc: Shahaf Shuler ; Matan Azrad
> ; dev@dpdk.org
> Subject: Re: [PATCH] net/mlx5: fix E-Switch flow without port item
>
> On Tue, Apr 23, 2019 at 11:19:16AM +,
> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of simei
> Sent: Wednesday, April 24, 2019 3:06 PM
> To: qi.zi.zh...@intel.com; Lu, Wenzhuo ; Yang,
> Qiming
> Cc: dev@dpdk.org; Su, Simei ; sta...@dpdk.org
> Subject: [dpdk-dev] [DPDK] net/ice: fix Rx statistics
>
On Wed, Apr 24, 2019 at 9:47 AM simei wrote:
> The RX stats will increase even no packets sent, this patch fix this issue
> by modifying ipackets and ibytes statistics based on vsi instead of port
> to avoid statistics error.
>
> Fixes: a37bde56314d ("net/ice: support statistics")
> Cc: sta...@dp
Hi David:
> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of David Marchand
> Sent: Thursday, April 25, 2019 3:13 PM
> To: Su, Simei
> Cc: qi.zi.zh...@intel.com; Lu, Wenzhuo ; Yang,
> Qiming ; dev ; dpdk stable
>
> Subject: Re: [dpdk-dev] [DPDK] net/ice: fix Rx s
On Thu, Apr 25, 2019 at 9:30 AM Zhang, Qi Z wrote:
> Hi David:
>
> > -Original Message-
> > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of David Marchand
> > Sent: Thursday, April 25, 2019 3:13 PM
> > To: Su, Simei
> > Cc: qi.zi.zh...@intel.com; Lu, Wenzhuo ; Yang,
> > Qiming ; dev
From: Jerin Jacob
Added documentation for the new armv8 targets supported in 19.05 release.
Signed-off-by: Jerin Jacob
---
doc/guides/rel_notes/release_19_05.rst | 7 +++
1 file changed, 7 insertions(+)
diff --git a/doc/guides/rel_notes/release_19_05.rst
b/doc/guides/rel_notes/release_19
From: lilin24
This patch introduces two new messages VHOST_USER_GET_INFLIGHT_FD
and VHOST_USER_SET_INFLIGHT_FD to support transferring a shared
buffer between qemu and backend.
Firstly, qemu uses VHOST_USER_GET_INFLIGHT_FD to get the
shared buffer from backend. Then qemu should send it back
thro
25/04/2019 00:03, Ferruh Yigit:
> This reverts commit bdca79053b6aea504d02691d9319fa976062457f.
>
> Not all PMDs support the fixed link speed set, and link speed can be set
> even with auto negotiation enabled. Reverting the patch to not break
> existing usage.
Which PMDs do not support this flag
This patch fixes null pointer dereference and control
flow issues reported in event crypto adapter by coverity
Coverity issue: 279439 Dereference null return value
Coverity issue: 279446 Logically dead code
Coverity issue: 279450 Logically dead code
Coverity issue: 279462 Logically dead code
Fixes
On 23-Apr-19 6:43 PM, Herakliusz Lipiec wrote:
When sending multiple requests, rte_mp_request_sync
can succeed sending a few of those requests, but then
fail on a later one and in the end return with rc=-1.
The upper layers - e.g. device hotplug - currently
handles this case as if no messages wer
Traditionally, only a single buffer pool per port
(or, per-port-per-socket) is created in l3fwd application.
If separate pools are created per-port, it might lead to gain in
performance as packet alloc/dealloc requests would be isolated
across ports (and their corresponding lcores).
This patch ad
On 25/04/2019 06:42, Nikhil Rao wrote:
> Add the experimental tag back to the Rx event adapter callback,
> the Rx event callback register and the Rx event adapter statistics
> retrieval functions due to API change to be proposed in a
> future patch.
>
> This patch also adds the experimental tag to
Acked-by: Vladimir Medvedkin
On 24/04/2019 16:35, Herakliusz Lipiec wrote:
Bugzilla ID: 235
Fixes: fc1f2750a3ec ("doc: programmers guide")
Cc: bernard.iremon...@intel.com
Cc: sta...@dpdk.org
Signed-off-by: Herakliusz Lipiec
---
doc/guides/prog_guide/lpm_lib.rst | 2 +-
1 file changed, 1 ins
> -Original Message-
> From: Ayuj Verma [mailto:ayve...@marvell.com]
> Sent: Wednesday, April 24, 2019 8:28 PM
> To: akhil.go...@nxp.com; Kusztal, ArkadiuszX ;
> Trahe, Fiona
>
> Cc: shal...@marvell.com; ss...@marvell.com; kkotamar...@marvell.com;
> ade...@marvell.com;
> dev@dpdk.org;
Li Lin 于2019年4月25日周四 下午3:57写道：
>
> From: lilin24
>
> This patch introduces two new messages VHOST_USER_GET_INFLIGHT_FD
> and VHOST_USER_SET_INFLIGHT_FD to support transferring a shared
> buffer between qemu and backend.
>
> Firstly, qemu uses VHOST_USER_GET_INFLIGHT_FD to get the
> shared buffer
From: lilin24
This patch introduces two new messages VHOST_USER_GET_INFLIGHT_FD
and VHOST_USER_SET_INFLIGHT_FD to support transferring a shared
buffer between qemu and backend.
Firstly, qemu uses VHOST_USER_GET_INFLIGHT_FD to get the
shared buffer from backend. Then qemu should send it back
thro
When sending synchronous IPC requests, the caller must free the response
buffer if the request was successful and reply is no longer needed.
Fix the code to correctly
use the IPC API.
Bugzilla ID: 228
Fixes: c9aa56edec8e ("net/tap: access primary process queues from secondary")
Cc: rasl...@mellano
When sending multiple requests, rte_mp_request_sync
can succeed sending a few of those requests, but then
fail on a later one and in the end return with rc=-1.
The upper layers - e.g. device hotplug - currently
handles this case as if no messages were sent and no
memory for response buffers was all
When sending multiple requests, rte_mp_request_sync
can succeed sending a few of those requests, but then
fail on a later one and in the end return with rc=-1.
The upper layers - e.g. device hotplug - currently
handles this case as if no messages were sent and no
memory for response buffers was all
On 4/25/2019 9:19 AM, Thomas Monjalon wrote:
> 25/04/2019 00:03, Ferruh Yigit:
>> This reverts commit bdca79053b6aea504d02691d9319fa976062457f.
>>
>> Not all PMDs support the fixed link speed set, and link speed can be set
>> even with auto negotiation enabled. Reverting the patch to not break
>> e
When creating a flow rule without the port_id pattern item, always the
PF was selected.
This commit fixes this issue, if no port_id pattern item is available
then we use the port that the flow was created on as source port.
Fixes: 822fb3195348 ("net/mlx5: add port id item to Direct Verbs")
Signe
Currently, IPC API will silently ignore unsupported IPC.
Fix the API call and its callers to explicitly handle
unsupported IPC cases.
For primary processes, it is OK to not have IPC because
there may not be any secondary processes in the first place,
and there are valid use cases that disable IPC
Currently, IPC API will silently ignore unsupported IPC.
Fix the API call and its callers to explicitly handle
unsupported IPC cases.
Signed-off-by: Anatoly Burakov
---
lib/librte_eal/common/eal_common_proc.c | 6 ++
lib/librte_eal/common/include/rte_eal.h | 3 +++
2 files changed, 9 inserti
Currently, IPC API will silently ignore unsupported IPC.
Fix the API call and its callers to explicitly handle
unsupported IPC cases.
Signed-off-by: Anatoly Burakov
---
lib/librte_eal/common/eal_common_proc.c | 3 ++-
lib/librte_eal/freebsd/eal/eal.c| 2 +-
lib/librte_eal/linux/eal/eal.c
Currently, IPC API will silently ignore unsupported IPC.
Fix the API call to explicitly handle unsupported IPC cases.
Signed-off-by: Anatoly Burakov
---
lib/librte_eal/common/eal_common_proc.c | 3 ++-
lib/librte_eal/common/include/rte_eal.h | 3 +++
2 files changed, 5 insertions(+), 1 deletion(
Currently, IPC API will silently ignore unsupported IPC.
Fix the API call and its callers to explicitly handle
unsupported IPC cases.
Signed-off-by: Anatoly Burakov
---
drivers/net/mlx4/mlx4_mp.c | 5 +++--
drivers/net/mlx5/mlx5_mp.c | 5 +++--
lib/librte_eal/common/e
Currently, unregister will be attempted even if IPC wasn't
supported in the first place. It is harmless, but for
consistency reasons, update the unregister API call to
exit early when IPC is not supported.
Signed-off-by: Anatoly Burakov
---
lib/librte_eal/common/eal_common_proc.c | 5 +
1 fi
When sending multiple requests, rte_mp_request_sync
can succeed sending a few of those requests, but then
fail on a later one and in the end return with rc=-1.
The upper layers - e.g. device hotplug - currently
handles this case as if no messages were sent and no
memory for response buffers was all
On 25-Apr-19 12:43 PM, Herakliusz Lipiec wrote:
When sending multiple requests, rte_mp_request_sync
can succeed sending a few of those requests, but then
fail on a later one and in the end return with rc=-1.
The upper layers - e.g. device hotplug - currently
handles this case as if no messages we
When sending multiple requests, rte_mp_request_sync
can succeed sending a few of those requests, but then
fail on a later one and in the end return with rc=-1.
The upper layers - e.g. device hotplug - currently
handles this case as if no messages were sent and no
memory for response buffers was all
When sending synchronous IPC requests, the caller must free the response
buffer if the request was successful and reply is no longer needed.
Fix the code to correctly
use the IPC API.
Bugzilla ID: 228
Fixes: c9aa56edec8e ("net/tap: access primary process queues from secondary")
Cc: rasl...@mellano
On 25-Apr-19 1:48 PM, Herakliusz Lipiec wrote:
When sending multiple requests, rte_mp_request_sync
can succeed sending a few of those requests, but then
fail on a later one and in the end return with rc=-1.
The upper layers - e.g. device hotplug - currently
handles this case as if no messages wer
Minutes 25 April 2019
-
Agenda:
* Release Dates
* RC2 status
* Subtrees
* OvS
* Opens
Participants:
* Debian
* Intel
* Marvell
* Mellanox
* NXP
* RedHat
Release Dates
-
* v19.05 dates, RC3 date pushed to Thursday, 2 May:
* RC2 is released on Monday, 22 April
IPC is a big part of secondary process infrastructure now,
and I have been de-facto maintainer for it since 18.05.
Update MAINTAINERS file to match.
Signed-off-by: Anatoly Burakov
---
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 4493aa636..b729d
25/04/2019 15:17, Anatoly Burakov:
> IPC is a big part of secondary process infrastructure now,
> and I have been de-facto maintainer for it since 18.05.
> Update MAINTAINERS file to match.
>
> Signed-off-by: Anatoly Burakov
> ---
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -202,6 +202,7 @@ F: d
25/04/2019 13:47, Ferruh Yigit:
> On 4/25/2019 9:19 AM, Thomas Monjalon wrote:
> > 25/04/2019 00:03, Ferruh Yigit:
> >> This reverts commit bdca79053b6aea504d02691d9319fa976062457f.
> >>
> >> Not all PMDs support the fixed link speed set, and link speed can be set
> >> even with auto negotiation en
Identified by LGTM, the loop was incorrectly incrementing a different
variable and conditional on another.
Fixes: fe2b986ac662 ("net/dpaa2: support generic flow")
Cc: sunil.k...@nxp.com
Suggested-by: Ferruh Yigit
Signed-off-by: Shreyansh Jain
---
drivers/net/dpaa2/dpaa2_flow.c | 2 +-
1 file c
>
> 17/04/2019 06:13, Honnappa Nagarahalli:
> > Dharmik Thakkar (1):
> > test/rcu_qsbr: add API and functional tests
> >
> > Honnappa Nagarahalli (2):
> > rcu: add RCU library supporting QSBR mechanism
> > doc/rcu: add lib_rcu documentation
>
> Sorry I cannot merge this library in DPDK 19.0
> >
> > 17/04/2019 06:13, Honnappa Nagarahalli:
> > > Dharmik Thakkar (1):
> > > test/rcu_qsbr: add API and functional tests
> > >
> > > Honnappa Nagarahalli (2):
> > > rcu: add RCU library supporting QSBR mechanism
> > > doc/rcu: add lib_rcu documentation
> >
> > Sorry I cannot merge this li
If primary app exited, meaningless for pdump keeps running anymore.
Signed-off-by: Suanming.Mou
---
app/pdump/main.c | 4
1 file changed, 4 insertions(+)
diff --git a/app/pdump/main.c b/app/pdump/main.c
index 3d208548fa13..f1ff2a3ceb4f 100644
--- a/app/pdump/main.c
+++ b/app/pdump/main.c
@
On Thu, Apr 25, 2019 at 4:19 PM Honnappa Nagarahalli <
honnappa.nagaraha...@arm.com> wrote:
> > - shared link is broken because of rcu_log_type not exported
> I am not sure what this is. Is this shared library compilation? Can you
> please let me know how to reproduce this?
>
> > - some public sym
On 25-Apr-19 2:26 PM, Thomas Monjalon wrote:
25/04/2019 15:17, Anatoly Burakov:
IPC is a big part of secondary process infrastructure now,
and I have been de-facto maintainer for it since 18.05.
Update MAINTAINERS file to match.
Signed-off-by: Anatoly Burakov
---
--- a/MAINTAINERS
+++ b/MAINTA
On 25-Apr-19 4:17 PM, Burakov, Anatoly wrote:
On 25-Apr-19 2:26 PM, Thomas Monjalon wrote:
25/04/2019 15:17, Anatoly Burakov:
IPC is a big part of secondary process infrastructure now,
and I have been de-facto maintainer for it since 18.05.
Update MAINTAINERS file to match.
Signed-off-by: Anat
On 4/25/2019 2:29 PM, Thomas Monjalon wrote:
> 25/04/2019 13:47, Ferruh Yigit:
>> On 4/25/2019 9:19 AM, Thomas Monjalon wrote:
>>> 25/04/2019 00:03, Ferruh Yigit:
This reverts commit bdca79053b6aea504d02691d9319fa976062457f.
Not all PMDs support the fixed link speed set, and link spe
https://bugs.dpdk.org/show_bug.cgi?id=258
Bug ID: 258
Summary: Tap driver unnecessarily triggers timeout on failure
Product: DPDK
Version: 19.05
Hardware: All
OS: All
Status: CONFIRMED
Severity: minor
On 4/25/2019 2:34 PM, Shreyansh Jain wrote:
> Identified by LGTM, the loop was incorrectly incrementing a different
> variable and conditional on another.
>
> Fixes: fe2b986ac662 ("net/dpaa2: support generic flow")
> Cc: sunil.k...@nxp.com
>
> Suggested-by: Ferruh Yigit
> Signed-off-by: Shreyans
Hi,
snipped
> @@ -847,6 +847,10 @@ struct parse_val {
> pdump_rxtx(pt->rx_ring, pt->rx_vdev_id, &pt->stats);
> if (pt->dir & RTE_PDUMP_FLAG_TX)
> pdump_rxtx(pt->tx_ring, pt->tx_vdev_id, &pt->stats);
> +
> + /* Once primary exits, so will I. */
> + if (!rte
On 27/03/2019 11:53, Akhil Goyal wrote:
> session inq and qp are assigned for each core from which the
> packets arrive. This was not correctly handled while supporting
> multiple sessions per queue pair.
> This patch fixes the attach and detach of queues for each core.
>
> Fixes: e79416d10fa3 ("c
When secondary to primary process synchronization occours
there is no check for number of fds which could cause buffer overrun.
Bugzilla ID: 252
Fixes: c9aa56edec8e ("net/tap: access primary process queues from secondary")
Cc: rasl...@mellanox.com
Cc: sta...@dpdk.org
Signed-off-by: Herakliusz Lip
On 4/24/19 8:34 PM, Tom Barbette wrote:
Add rte_eth_read_clock to read the raw clock of a devide.
Typo above "devide"
The main use is to get the device clock conversion co-efficients to be
able to translate the raw clock of the timestamp field of the pkt mbuf
to a local synced time value.
Th
When secondary to primary process synchronization occours
there is no check for number of fds which could cause buffer overrun.
Bugzilla ID: 252
Fixes: c9aa56edec8e ("net/tap: access primary process queues from secondary")
Cc: rasl...@mellanox.com
Cc: sta...@dpdk.org
Signed-off-by: Herakliusz Lip
Systemd uses this and it looks like a useful addition to the DPDK source
base. Especially since we now have Windows developers.
https://editorconfig.org/
On 25/04/2019 17:24, Kevin Traynor wrote:
> On 27/03/2019 11:53, Akhil Goyal wrote:
>> session inq and qp are assigned for each core from which the
>> packets arrive. This was not correctly handled while supporting
>> multiple sessions per queue pair.
>> This patch fixes the attach and detach of qu
> On Apr 25, 2019, at 12:02 AM, Ori Kam wrote:
>
> Hi Yongseok,
> PSB,
>
> Ori
>
>> -Original Message-
>> From: Yongseok Koh
>> Sent: Wednesday, April 24, 2019 12:03 AM
>> To: Ori Kam
>> Cc: Shahaf Shuler ; Matan Azrad
>> ; dev@dpdk.org
>> Subject: Re: [PATCH] net/mlx5: fix E-Switch
> On Apr 25, 2019, at 5:20 AM, Ori Kam wrote:
>
> When creating a flow rule without the port_id pattern item, always the
> PF was selected.
>
> This commit fixes this issue, if no port_id pattern item is available
> then we use the port that the flow was created on as source port.
>
> Fixes:
> On Apr 25, 2019, at 7:48 AM, Lipiec, Herakliusz
> wrote:
>
> When sending synchronous IPC requests, the caller must free the response
> buffer if the request was successful and reply is no longer needed.
> Fix the code to correctly
> use the IPC API.
>
> Bugzilla ID: 228
> Fixes: c9aa56ede
Hi-
The following describes the tests that we ran on top of the 19.05 branch
on IBM Power9 hardware.
* Single port stability test using l3fwd (16 cpus) and TRex, tested 64
and 1500 byte packets at a 0.0% drop rate for 4 hours each.
No errors or regressions were seen.
System tested:
- IBM P
> On Apr 24, 2019, at 12:34 PM, Tom Barbette wrote:
>
> Add rte_eth_read_clock to read the raw clock of a devide.
>
> The main use is to get the device clock conversion co-efficients to be
> able to translate the raw clock of the timestamp field of the pkt mbuf
> to a local synced time value.
Lock-less data structures provide scalability and determinism.
They enable use cases where locking may not be allowed
(for ex: real-time applications).
In the following paras, the term 'memory' refers to memory allocated
by typical APIs like malloc or anything that is representative of
memory, for
Add RCU library supporting quiescent state based memory reclamation method.
This library helps identify the quiescent state of the reader threads so
that the writers can free the memory associated with the lock less data
structures.
Signed-off-by: Honnappa Nagarahalli
Reviewed-by: Steve Capper
R
From: Dharmik Thakkar
Add API positive/negative test cases, functional tests and
performance tests.
Signed-off-by: Malvika Gupta
Signed-off-by: Dharmik Thakkar
Signed-off-by: Honnappa Nagarahalli
Reviewed-by: Gavin Hu
Acked-by: Konstantin Ananyev
---
app/test/Makefile |2 +
Add lib_rcu QSBR API and programmer guide documentation.
Signed-off-by: Honnappa Nagarahalli
Reviewed-by: Marko Kovacevic
---
doc/api/doxy-api-index.md | 3 +-
doc/api/doxy-api.conf.in | 1 +
.../prog_guide/img/rcu_general_info.svg | 509 ++
Added RCU library addition to the release notes
Signed-off-by: Honnappa Nagarahalli
---
doc/guides/rel_notes/release_19_05.rst | 8
1 file changed, 8 insertions(+)
diff --git a/doc/guides/rel_notes/release_19_05.rst
b/doc/guides/rel_notes/release_19_05.rst
index d5ed564ab..687c01bc1 1
Since 18.11, it is suggested that driver should release all its private
resources at the dev_close routine. So all resources previously released
in remove routine are now released at the dev_close routine, and the
dev_close routine will be called in driver remove routine in order to
support removin
As af_xdp pmd doesn't allocate MAC addresses dynamically, it needs to be
set as NULL, so it won't be released by rte_eth_dev_release_port(),
otherwise, there would be "EAL: Error: Invalid memory" error.
Signed-off-by: Xiaolong Ye
---
drivers/net/af_xdp/rte_eth_af_xdp.c | 6 ++
1 file changed
Hi,
This series is to support the RTE_ETH_DEV_CLOSE_REMOVE in AF_XDP pmd.
Xiaolong Ye (2):
net/af_xdp: remove resources when port is closed
net/af_xdp: set MAC addrs field to NULL
drivers/net/af_xdp/rte_eth_af_xdp.c | 47 +++--
1 file changed, 25 insertions(+), 22 de
66 matches
Mail list logo
