Re: [dpdk-dev] [PATCH 07/12] net/mlx5: fix incorrect rxq errors stat

2019-03-05 Thread Shahaf Shuler
Monday, March 4, 2019 1:19 PM, David Marchand: > Subject: [PATCH 07/12] net/mlx5: fix incorrect rxq errors stat > > Transmit errors must not be reported in q_errors[] which is for reception. > > Fixes: 87011737b715 ("mlx5: add software counters") > Fixes: 9f9a48eb2978 ("net/mlx5: fix Tx stats err

Re: [dpdk-dev] [PATCH 06/12] net/mlx4: fix incorrect rxq errors stat

2019-03-05 Thread Shahaf Shuler
Monday, March 4, 2019 1:18 PM, David Marchand: > Subject: [PATCH 06/12] net/mlx4: fix incorrect rxq errors stat > > Transmit errors must not be reported in q_errors[] which is for reception. > > Fixes: 7fae69eeff13 ("mlx4: new poll mode driver") > Cc: sta...@dpdk.org > Cc: Matan Azrad > Cc: Shah

Re: [dpdk-dev] [PATCH v1 1/6] net/af_xdp: introduce AF_XDP PMD driver

2019-03-05 Thread David Marchand
On Fri, Mar 1, 2019 at 9:13 AM Xiaolong Ye wrote: > diff --git a/doc/guides/rel_notes/release_18_11.rst > b/doc/guides/rel_notes/release_18_11.rst > index 65bab557d..e0918441a 100644 > --- a/doc/guides/rel_notes/release_18_11.rst > +++ b/doc/guides/rel_notes/release_18_11.rst > @@ -229,6 +229,13

Re: [dpdk-dev] [PATCH v1 2/6] lib/mbuf: enable parse flags when create mempool

2019-03-05 Thread David Marchand
On Fri, Mar 1, 2019 at 9:13 AM Xiaolong Ye wrote: > This give the option that applicaiton can configure each > memory chunk's size precisely. (by MEMPOOL_F_NO_SPREAD). > > Signed-off-by: Qi Zhang > Signed-off-by: Xiaolong Ye > Cc: maintainer --- > lib/librte_mbuf/rte_mbuf.c | 15

Re: [dpdk-dev] [RFC v2] net/mlx5: support new naming scheme for representors

2019-03-05 Thread Dekel Peled
Thanks, PSB. > -Original Message- > From: Stephen Hemminger > Sent: Monday, March 4, 2019 9:14 PM > To: Dekel Peled > Cc: Shahaf Shuler ; Yongseok Koh > ; dev@dpdk.org; Ori Kam ; > Matan Azrad > Subject: Re: [dpdk-dev] [RFC v2] net/mlx5: support new naming scheme for > representors > >

Re: [dpdk-dev] [PATCH v2 0/3] adding rsa priv key feature flag

2019-03-05 Thread Ayuj Verma
Hi Akhil, Did you get a chance to look into these. Thanks and regards Ayuj Verma From: Ayuj Verma Sent: 27 February 2019 19:03:31 To: akhil.go...@nxp.com Cc: arkadiuszx.kusz...@intel.com; fiona.tr...@intel.com; Shally Verma; Sunila Sahu; Kanaka Durga Kotamart

Re: [dpdk-dev] [PATCH 4/4] net/failsafe: support secondary process

2019-03-05 Thread Raslan Darawsheh
Hi Stephen, > -Original Message- > From: Stephen Hemminger > Sent: Thursday, February 28, 2019 7:25 PM > To: Raslan Darawsheh > Cc: gaetan.ri...@6wind.com; dev@dpdk.org; Thomas Monjalon > > Subject: Re: [dpdk-dev] [PATCH 4/4] net/failsafe: support secondary process > > On Thu, 28 Feb

[dpdk-dev] [PATCH v2 4/4] net/failsafe: support secondary process

2019-03-05 Thread Raslan Darawsheh
Add implementation for probe in secondary. Failsafe will attempt to attach all the sub-devices in secondary process. Signed-off-by: Raslan Darawsheh Signed-off-by: Thomas Monjalon --- v2: changed devargs_alread_listed return value to be bool. --- drivers/net/failsafe/failsafe.c | 45 ++

[dpdk-dev] [PATCH v2 2/4] net/failsafe: change back-reference from sub-device

2019-03-05 Thread Raslan Darawsheh
In multiprocess context, the sub-device structure is shared between processes. The reference to the failsafe device was a per process pointer. It's changed to port id which is the same for all processes. Signed-off-by: Raslan Darawsheh Signed-off-by: Thomas Monjalon --- v2: changed macro to an i

[dpdk-dev] [PATCH v2 3/4] net/failsafe: replace local sub-device with shared data

2019-03-05 Thread Raslan Darawsheh
In multiprocess context, the pointer to sub-device is shared between processes. Previously, it was a pointer to per process eth_dev so it's needed to replace this dependency. Signed-off-by: Thomas Monjalon Signed-off-by: Raslan Darawsheh --- v2: - moved comment in fs_sdev about subs to this comm

[dpdk-dev] [PATCH v2 1/4] net/failsafe: replace local device with shared data

2019-03-05 Thread Raslan Darawsheh
In multiprocess context, the private structure is shared between processes. The back reference from private to generic data was using a pointer to a per process eth_dev. It's now changed to a reference of the shared data. Signed-off-by: Raslan Darawsheh Signed-off-by: Thomas Monjalon --- driver

Re: [dpdk-dev] [PATCH v2 3/4] net/failsafe: replace local sub-device with shared data

2019-03-05 Thread Thomas Monjalon
05/03/2019 10:52, Raslan Darawsheh: > +/* > + * Allocated in shared memory. > + */ > struct sub_device { > /* Exhaustive DPDK device description */ > struct sub_device *next; > struct rte_devargs devargs; > - struct rte_bus *bus; > - struct rte_device *dev; > - struct

Re: [dpdk-dev] [PATCH 4/4] net/failsafe: support secondary process

2019-03-05 Thread Thomas Monjalon
05/03/2019 10:33, Raslan Darawsheh: > Hi Stephen, > > From: Stephen Hemminger > > On Thu, 28 Feb 2019 15:49:28 + > > Raslan Darawsheh wrote: > > > > > + eth_dev->rx_pkt_burst = > > (eth_rx_burst_t)&failsafe_rx_burst; > > > + eth_dev->tx_pkt_burst = > > (eth_tx_burst_t)&fail

Re: [dpdk-dev] [PATCH] malloc: add rte_realloc_socket function

2019-03-05 Thread Burakov, Anatoly
On 01-Mar-19 8:46 AM, Tomasz Jozwiak wrote: Currently, rte_realloc will not respect original allocation's NUMA node when memory cannot be resized, and there is no NUMA-aware equivalent of rte_realloc. This patch adds such a function. The new API will ensure that reallocated memory stays on reque

Re: [dpdk-dev] [PATCH] doc: remove reference to rte.doc.mk in programmers guide

2019-03-05 Thread Ferruh Yigit
On 2/25/2019 3:37 PM, Rami Rosen wrote: > This patch removes the reference to rte.doc.mk in > DPDK programmers guide. > > Fixes: ee801f6cc7b8 ("mk: clean dead doc rules") > Cc: sta...@dpdk.org > > Signed-off-by: Rami Rosen Reviewed-by: Ferruh Yigit Applied, thanks.

Re: [dpdk-dev] [PATCH] examples/ethtool: fix 2 typos

2019-03-05 Thread Ferruh Yigit
On 2/26/2019 11:09 AM, Remy Horton wrote: > > On 25/02/2019 19:21, Rami Rosen wrote: > [snip] >> Signed-off-by: Rami Rosen >> --- >> examples/ethtool/lib/rte_ethtool.h | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) > > Acked-by: Remy Horton > Applied, thanks.

Re: [dpdk-dev] [dpdk-stable] [PATCH] doc: fix wrong link in gsg

2019-03-05 Thread Ferruh Yigit
On 3/1/2019 11:50 AM, Rami Rosen wrote: > This patch fixes a wrong link in gsg. The > Documentation/kernel-parameters.txt file from the kernel > source tree was moved quite a time ago to > Documentation/admin-guide/kernel-parameters.txt. > > Fixes: 1ab07743b21b ("doc: getting started guide for

[dpdk-dev] [PATCH] app/testpmd: fix help info for interactive commands

2019-03-05 Thread Agalya Babu RadhaKrishnan
From: Agalya Babu RadhaKrishnan Added some missing help info for interactive mode commands Fixes: 6673fe0ce2 ("app/testpmd: add TM commands to mark packets") Fixes: c73a907187 ("app/testpmd: add commands to test new offload API") Fixes: e977e4199a ("app/testpmd: add commands to load/unload BPF f

Re: [dpdk-dev] [dpdk-stable] [PATCH] doc: fix PCI whitelist typo in prog guide

2019-03-05 Thread Ferruh Yigit
On 2/25/2019 5:23 AM, Rami Rosen wrote: > On Mon, Feb 25, 2019 at 12:33 AM Thomas Monjalon > wrote: > >> The placeholder for PCI address should be named DBDF >> which stands for Domain/Bus/Device/Function. >> >> Fixes: 33af337773ac ("ethdev: add common devargs parser") >> Cc: remy.hor...@intel.c

Re: [dpdk-dev] [PATCH v1] mk: remove AVX512 disabled warning on non x86

2019-03-05 Thread Ferruh Yigit
On 2/24/2019 6:27 PM, Jerin Jacob Kollanukkaran wrote: > AVX512 is a x86 specific feature, So, enable AVX512 > warning only on x86. Changed to a fix: mk: fix AVX512 disabled warning on non x86 ... Fixes: a32ca9a4ebc1 ("mk: fix scope of disabling AVX512F support") Cc: sta...@dpdk

Re: [dpdk-dev] [PATCH] app/testpmd: fix help info for interactive commands

2019-03-05 Thread Rami Rosen
Hi, Agalya, Minors: partciular=>particular per port.testpmd=> per port. testpmd or maybe: per port. Testpmd + "bpf-load rx|tx (port) (queue) (J|M|B) (file_name)\n" + "Load an eBPF program as a callback" + " for partciular RX/TX queue\n\n" + + "bpf-unload rx|tx (port) (queue)\n" + "Unload

Re: [dpdk-dev] [PATCH 0/2] small fixes for vdev hotplug

2019-03-05 Thread Ferruh Yigit
On 2/21/2019 7:01 PM, Thomas Monjalon wrote: > These are 2 small fixes. > > A bigger cleanup may be needed in vdev: > rte_vdev_init() can be replaced by rte_dev_probe(). > Any volunteer? Note: vdev has no maintainer. > > > Raslan Darawsheh (1): > bus/vdev: fix hotplug twice > > Thomas Monjalo

[dpdk-dev] [PATCH v4] drivers: fix possible overflow with strcat

2019-03-05 Thread Chaitanya Babu Talluri
strcat does not check the destination length and there might be chances of string overflow so instead of strcat, strlcat is used. Fixes: 6f4eec2565 ("test/crypto: enhance scheduler unit tests") Fixes: 540a211084 ("bnx2x: driver core") Fixes: e163c18a15 ("net/i40e: update ptype and pctype info") Fi

[dpdk-dev] [PATCH v3 1/6] vfio: allow DMA map of memory for the default vfio fd

2019-03-05 Thread Shahaf Shuler
Enable users the option to call rte_vfio_dma_map with request to map to the default vfio fd. Signed-off-by: Shahaf Shuler Acked-by: Anatoly Burakov --- doc/guides/rel_notes/release_19_05.rst | 3 +++ lib/librte_eal/common/include/rte_vfio.h | 8 ++-- lib/librte_eal/linuxapp/eal/eal_vfio

[dpdk-dev] [PATCH v3 6/6] doc: deprecation notice for VFIO DMA map APIs

2019-03-05 Thread Shahaf Shuler
As those should be replaced by rte_dev_dma_map and rte_dev_dma_unmap APIs. Signed-off-by: Shahaf Shuler --- doc/guides/prog_guide/env_abstraction_layer.rst | 2 +- doc/guides/rel_notes/deprecation.rst| 4 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/doc/guides/p

[dpdk-dev] [PATCH v3 3/6] bus: introduce device level DMA memory mapping

2019-03-05 Thread Shahaf Shuler
The DPDK APIs expose 3 different modes to work with memory used for DMA: 1. Use the DPDK owned memory (backed by the DPDK provided hugepages). This memory is allocated by the DPDK libraries, included in the DPDK memory system (memseg lists) and automatically DMA mapped by the DPDK layers. 2. Use

[dpdk-dev] [PATCH v3 2/6] vfio: don't fail to DMA map if memory is already mapped

2019-03-05 Thread Shahaf Shuler
Currently vfio DMA map function will fail in case the same memory segment is mapped twice. This is too strict, as this is not an error to map the same memory twice. Instead, use the kernel return value to detect such state and have the DMA function to return as successful. For type1 mapping the

[dpdk-dev] [PATCH v3 0/6] introduce DMA memory mapping for external memory

2019-03-05 Thread Shahaf Shuler
The DPDK APIs expose 3 different modes to work with memory used for DMA: 1. Use the DPDK owned memory (backed by the DPDK provided hugepages). This memory is allocated by the DPDK libraries, included in the DPDK memory system (memseg lists) and automatically DMA mapped by the DPDK layers. 2. Use

[dpdk-dev] [PATCH v3 5/6] net/mlx5: support PCI device DMA map and unmap

2019-03-05 Thread Shahaf Shuler
The implementation reuses the external memory registration work done by commit[1]. Note about representors: The current representor design will not work with those map and unmap functions. The reason is that for representors we have multiple IB devices share the same PCI function, so mapping will

[dpdk-dev] [PATCH v3 4/6] net/mlx5: refactor external memory registration

2019-03-05 Thread Shahaf Shuler
Move the memory region creation to a separate function to prepare the ground for the reuse of it on the PCI driver map and unmap functions. Signed-off-by: Shahaf Shuler --- drivers/net/mlx5/mlx5_mr.c | 86 +++-- 1 file changed, 57 insertions(+), 29 deletions(-

[dpdk-dev] [PATCH] ipsec-secgw: fix AES-CTR block size in legacy mode

2019-03-05 Thread Fan Zhang
This patch fixes the incorrect block size for AES-CTR in legacy mode. Originally, wrong block size will cause esp_inbound() drop AES-CTR encrypted packets if the payload sizes not equal to multiple times of 16. Fixes: 4470c22de2e1 ("examples/ipsec-secgw: add AES-CTR") Cc: sta...@dpdk.org Signed-o

Re: [dpdk-dev] [PATCH 2/2] doc: add notes regarding eventdev producer consumer dependency

2019-03-05 Thread Jerin Jacob Kollanukkaran
On Wed, 2019-02-27 at 20:00 +, Pavan Nikhilesh Bhagavatula wrote: > From: Pavan Nikhilesh > > EventDev i.e consumer needs to be started before starting the > event producers. > Update documentation of EventDev and EventDev adapters. > Adding all the eventdev adapter maintainers for the fee

Re: [dpdk-dev] [PATCH v1] net/i40e: support request any number of queues

2019-03-05 Thread Kevin Traynor
On 17/01/2019 07:26, Yan, Zhirun wrote: > > >> -Original Message- >> From: Kevin Traynor [mailto:ktray...@redhat.com] >> Sent: Wednesday, January 16, 2019 1:34 AM >> To: Yan, Zhirun ; dev@dpdk.org; Zhang, Qi Z >> >> Subject: Re: [dpdk-dev] [PATCH v1] net/i40e: support request any number

[dpdk-dev] [PATCH] meson: fix building subdirectories seperately

2019-03-05 Thread Andrius Sirvys
If for debugging we disable the driver directory in the meson.build file, we get an error because the variable "driver_classes" does not exist. This is because driver_classes is only defined in the drivers/meson.build file. Defining driver_classes in dpdk/meson.build file will make it easier for co

[dpdk-dev] [PATCH v2] meson: fix building subdirectories separately

2019-03-05 Thread Andrius Sirvys
If for debugging we disable the driver directory in the meson.build file, we get an error because the variable "driver_classes" does not exist. This is because driver_classes is only defined in the drivers/meson.build file. Defining driver_classes in dpdk/meson.build file will make it easier for co

[dpdk-dev] [PATCH 1/2] net/i40e: fix negative check on unsigned queue pairs

2019-03-05 Thread Kevin Traynor
Fix the check and associated log. Also, fix a typo in other log. Fixes: 03d478e9609d ("net/i40e: support PF respond VF request more queues") Cc: sta...@dpdk.org Cc: zhirun@intel.com Signed-off-by: Kevin Traynor --- drivers/net/i40e/i40e_pf.c | 10 -- 1 file changed, 4 insertions(+),

[dpdk-dev] [RFC 2/2] net/i40e: update requested queue pair num check for rounding

2019-03-05 Thread Kevin Traynor
Since rounding up the requested queue pairs to allow the vf to request a non-aligned number was added, it may happen that the requested number is less than the available num of queues but the rounded up number is greater. In this case, it is not caught with the usual checks but later when there is

Re: [dpdk-dev] [PATCH v3 3/6] bus: introduce device level DMA memory mapping

2019-03-05 Thread Burakov, Anatoly
On 05-Mar-19 1:59 PM, Shahaf Shuler wrote: The DPDK APIs expose 3 different modes to work with memory used for DMA: 1. Use the DPDK owned memory (backed by the DPDK provided hugepages). This memory is allocated by the DPDK libraries, included in the DPDK memory system (memseg lists) and automati

[dpdk-dev] [PATCH v2 1/8] stack: introduce rte stack library

2019-03-05 Thread Gage Eads
The rte_stack library provides an API for configuration and use of a bounded stack of pointers. Push and pop operations are MT-safe, allowing concurrent access, and the interface supports pushing and popping multiple pointers at a time. The library's interface is modeled after another DPDK data st

[dpdk-dev] [PATCH v2 0/8] Add stack library and new mempool handler

2019-03-05 Thread Gage Eads
This patchset introduces a stack library, supporting both lock-based and lock-free stacks, and a lock-free stack mempool handler. The lock-based stack code is derived from the existing stack mempool handler, and that handler is refactored to use the stack library. The lock-free stack mempool hand

[dpdk-dev] [PATCH v2 2/8] mempool/stack: convert mempool to use rte stack

2019-03-05 Thread Gage Eads
The new rte_stack library is derived from the mempool handler, so this commit removes duplicated code and simplifies the handler by migrating it to this new API. Signed-off-by: Gage Eads Reviewed-by: Olivier Matz --- MAINTAINERS | 2 +- drivers/mempool/stack/Makef

[dpdk-dev] [PATCH v2 3/8] test/stack: add stack test

2019-03-05 Thread Gage Eads
stack_autotest performs positive and negative testing of the stack API, and exercises the push and pop datapath functions with all available lcores. Signed-off-by: Gage Eads --- MAINTAINERS| 1 + test/test/Makefile | 2 + test/test/meson.build | 3 + test/test/test_stack.c

[dpdk-dev] [PATCH v2 4/8] test/stack: add stack perf test

2019-03-05 Thread Gage Eads
stack_perf_autotest tests the following with one lcore: - Cycles to attempt to pop an empty stack - Cycles to push then pop a single object - Cycles to push then pop a burst of 32 objects It also tests the cycles to push then pop a burst of 8 and 32 objects with the following lcore combinations (i

[dpdk-dev] [PATCH v2 7/8] test/stack: add lock-free stack tests

2019-03-05 Thread Gage Eads
This commit adds lock-free stack variants of stack_autotest (stack_lf_autotest) and stack_perf_autotest (stack_lf_perf_autotest), which differ only in that the lock-free versions pass the RTE_STACK_F_LF flag to all rte_stack_create() calls. Signed-off-by: Gage Eads Reviewed-by: Olivier Matz ---

[dpdk-dev] [PATCH v2 6/8] stack: add C11 atomic implementation

2019-03-05 Thread Gage Eads
This commit adds an implementation of the lock-free stack push, pop, and length functions that use __atomic builtins, for systems that benefit from the finer-grained memory ordering control. Signed-off-by: Gage Eads --- lib/librte_stack/Makefile| 3 +- lib/librte_stack/meson.build

[dpdk-dev] [PATCH v2 5/8] stack: add lock-free stack implementation

2019-03-05 Thread Gage Eads
This commit adds support for a lock-free (linked list based) stack to the stack API. This behavior is selected through a new rte_stack_create() flag, RTE_STACK_F_LF. The stack consists of a linked list of elements, each containing a data pointer and a next pointer, and an atomic stack depth counte

[dpdk-dev] [PATCH v2 8/8] mempool/stack: add lock-free stack mempool handler

2019-03-05 Thread Gage Eads
This commit adds support for lock-free (linked list based) stack mempool handler. In mempool_perf_autotest the lock-based stack outperforms the lock-free handler for certain lcore/alloc count/free count combinations*, however: - For applications with preemptible pthreads, a standard (lock-based)

Re: [dpdk-dev] [PATCH v2 1/4] net/failsafe: replace local device with shared data

2019-03-05 Thread Gaëtan Rivet
Hello Raslan, Sorry for the delay. I have had a little trouble reading the patches. I think the 3 first should be squashed into a single one, it would be more coherent. I think I have seen a few points where doing so would have prevented some unnecessary changes for example, simplifying the seri

Re: [dpdk-dev] [PATCH v2 2/4] net/failsafe: change back-reference from sub-device

2019-03-05 Thread Gaëtan Rivet
Beside the squash referenced in p1, On Tue, Mar 05, 2019 at 09:52:05AM +, Raslan Darawsheh wrote: > In multiprocess context, the sub-device structure is shared > between processes. The reference to the failsafe device was > a per process pointer. It's changed to port id which is the > same for

Re: [dpdk-dev] [PATCH v2] meson: fix building subdirectories separately

2019-03-05 Thread Bruce Richardson
On Tue, Mar 05, 2019 at 04:29:25PM +, Andrius Sirvys wrote: > If for debugging we disable the driver directory in the meson.build file, > we get an error because the variable "driver_classes" does not exist. > This is because driver_classes is only defined in the > drivers/meson.build file. Def

Re: [dpdk-dev] [PATCH v2] meson: fix building subdirectories separately

2019-03-05 Thread Bruce Richardson
On Tue, Mar 05, 2019 at 05:21:12PM +, Bruce Richardson wrote: > On Tue, Mar 05, 2019 at 04:29:25PM +, Andrius Sirvys wrote: > > If for debugging we disable the driver directory in the meson.build file, > > we get an error because the variable "driver_classes" does not exist. > > This is bec

Re: [dpdk-dev] [PATCH v2 3/4] net/failsafe: replace local sub-device with shared data

2019-03-05 Thread Gaëtan Rivet
On Tue, Mar 05, 2019 at 09:52:05AM +, Raslan Darawsheh wrote: > In multiprocess context, the pointer to sub-device is shared between > processes. Previously, it was a pointer to per process eth_dev so > it's needed to replace this dependency. > > Signed-off-by: Thomas Monjalon > Signed-off-by

Re: [dpdk-dev] [PATCH v2 1/4] net/failsafe: replace local device with shared data

2019-03-05 Thread Gaëtan Rivet
On Tue, Mar 05, 2019 at 05:43:26PM +0100, Gaëtan Rivet wrote: > Hello Raslan, > > Sorry for the delay. > > I have had a little trouble reading the patches. I think the 3 first > should be squashed into a single one, it would be more coherent. > > I think I have seen a few points where doing so w

[dpdk-dev] [PATCH v5 0/6] Add lock-free ring and mempool handler

2019-03-05 Thread Gage Eads
For some users, the rte ring's "non-preemptive" constraint is not acceptable; for example, if the application uses a mixture of pinned high-priority threads and multiplexed low-priority threads that share a mempool. This patchset introduces a lock-free ring and a mempool based on it. The lock-free

[dpdk-dev] [PATCH v5 2/6] ring: add a ring start marker

2019-03-05 Thread Gage Eads
This marker allows us to replace "&r[1]" with "&r->ring" to locate the start of the ring. Signed-off-by: Gage Eads --- lib/librte_ring/rte_ring.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/lib/librte_ring/rte_ring.h b/lib/librte_ring/rte_ring.h index c78db6916..f16d

[dpdk-dev] [PATCH v5 1/6] ring: add a pointer-width headtail structure

2019-03-05 Thread Gage Eads
For 64-bit systems, at current CPU speeds, 64-bit head and tail indexes will not wrap-around within the author's lifetime. This is important to avoiding the ABA problem -- in which a thread mistakes reading the same tail index in two accesses to mean that the ring was not modified in the intervenin

[dpdk-dev] [PATCH v5 4/6] test_ring: add lock-free ring autotest

2019-03-05 Thread Gage Eads
ring_nb_autotest re-uses the ring_autotest code by wrapping its top-level function with one that takes a 'flags' argument. Signed-off-by: Gage Eads --- test/test/test_ring.c | 61 --- 1 file changed, 38 insertions(+), 23 deletions(-) diff --git a/

[dpdk-dev] [PATCH v5 3/6] ring: add a lock-free implementation

2019-03-05 Thread Gage Eads
This commit adds support for lock-free circular ring enqueue and dequeue functions. The ring is supported on 32- and 64-bit architectures, however it uses a 128-bit compare-and-swap instruction when run on a 64-bit architecture, and thus is currently limited to x86_64. The algorithm is based on Ol

[dpdk-dev] [PATCH v5 5/6] test_ring_perf: add lock-free ring perf test

2019-03-05 Thread Gage Eads
nb_ring_perf_autotest re-uses the ring_perf_autotest code by wrapping its top-level function with one that takes a 'flags' argument. Signed-off-by: Gage Eads --- test/test/test_ring_perf.c | 19 --- 1 file changed, 16 insertions(+), 3 deletions(-) diff --git a/test/test/test_rin

Re: [dpdk-dev] [PATCH v2 1/4] net/failsafe: replace local device with shared data

2019-03-05 Thread Thomas Monjalon
05/03/2019 18:40, Gaëtan Rivet: > On Tue, Mar 05, 2019 at 05:43:26PM +0100, Gaëtan Rivet wrote: > > I have had a little trouble reading the patches. I think the 3 first > > should be squashed into a single one, it would be more coherent. > > > > I think I have seen a few points where doing so woul

[dpdk-dev] [PATCH v5 6/6] mempool/ring: add lock-free ring handlers

2019-03-05 Thread Gage Eads
These handlers allow an application to create a mempool based on the lock-free ring, with any combination of single/multi producer/consumer. Also, add a note to the programmer's guide's "known issues" section. Signed-off-by: Gage Eads Acked-by: Andrew Rybchenko --- doc/guides/prog_guide/env_ab

Re: [dpdk-dev] [PATCH v2 3/4] net/failsafe: replace local sub-device with shared data

2019-03-05 Thread Thomas Monjalon
Hi, 05/03/2019 18:38, Gaëtan Rivet: > > fs_dev_remove(struct sub_device *sdev) [...] > > - rte_eth_dev_close(PORT_ID(sdev)); > > + rte_eth_dev_close(edev->data->port_id); > > Ok I see. I missed that during the first reading, the private_data is > zeroed on dev_close(), so ETH

Re: [dpdk-dev] [PATCH v2] meson: fix building subdirectories separately

2019-03-05 Thread Ranjit Menon
On 3/5/2019 9:26 AM, Bruce Richardson wrote: On Tue, Mar 05, 2019 at 05:21:12PM +, Bruce Richardson wrote: On Tue, Mar 05, 2019 at 04:29:25PM +, Andrius Sirvys wrote: If for debugging we disable the driver directory in the meson.build file, we get an error because the variable "drive

Re: [dpdk-dev] [PATCH v3] net/nfb: new netcope driver

2019-03-05 Thread Rami Rosen
Hi, Added new net driver for Netcope nfb cards Signed-off-by: Rastislav Cernay Reviewed-by: Rami Rosen --- v2: remove unnecessary cast remove unnecessary zeroing move declaration to not mix with code restore skeleton example v3: add release notes add doc to doc index add arc

Re: [dpdk-dev] [PATCH v3] net/nfb: new netcope driver

2019-03-05 Thread Luca Boccassi
On Fri, 2019-03-01 at 15:37 +0100, Rastislav Cernay wrote: > From: Rastislav Cernay > > Added new net driver for Netcope nfb cards > > Signed-off-by: Rastislav Cernay > --- > v2: remove unnecessary cast > remove unnecessary zeroing > move declaration to not mix with code > restore s

Re: [dpdk-dev] [PATCH v3 0/2] Timer library changes

2019-03-05 Thread Carrillo, Erik G
Hi all, I'd like to bring this patch proposal up again and see if I can get any more feedback from the maintainer or others. I need to update the map file to reflect the next release, so I'll add those changes in if any other modifications are suggested. Thanks, Erik ML: https://mails.dpdk.o

Re: [dpdk-dev] [dpdk-techboard] [PATCH v3 0/2] Timer library changes

2019-03-05 Thread Thomas Monjalon
05/03/2019 23:41, Carrillo, Erik G: > Hi all, > > I'd like to bring this patch proposal up again and see if I can get any more > feedback from the maintainer or others. > > I need to update the map file to reflect the next release, so I'll add those > changes in if any other modifications are s

Re: [dpdk-dev] [PATCH 0/6] HelloWorld example for Windows

2019-03-05 Thread Anand Rawat
On 3/4/2019 2:13 AM, David Marchand wrote: On Fri, Mar 1, 2019 at 2:48 PM Bruce Richardson mailto:bruce.richard...@intel.com>> wrote: On Thu, Feb 28, 2019 at 11:18:41PM -0800, Anand Rawat wrote: > Helloworld example for Windows. > Includes Windows-specific EAL changes and meson

Re: [dpdk-dev] [PATCH 2/2] doc: add notes regarding eventdev producer consumer dependency

2019-03-05 Thread Carrillo, Erik G
> -Original Message- > From: Jerin Jacob Kollanukkaran [mailto:jer...@marvell.com] > Sent: Tuesday, March 5, 2019 9:16 AM > To: Pavan Nikhilesh Bhagavatula > Cc: Mcnamara, John ; Rao, Nikhil > ; Carrillo, Erik G ; Gujjar, > Abhinandan S ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 2/2]

[dpdk-dev] [Bug 221] How to classifier ipv6 packets with flow classification library

2019-03-05 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=221 Bug ID: 221 Summary: How to classifier ipv6 packets with flow classification library Product: DPDK Version: 17.11 Hardware: x86 OS: Linux Status: CONFIR

Re: [dpdk-dev] [PATCH] app/testpmd: fix help info for interactive commands

2019-03-05 Thread Wu, Jingjing
Glad to see the help info is added. Could you categorize this related TM commands to a new group? As you know, the commands in "help config" almost over flow. Thanks Jingjing > -Original Message- > From: Babu Radhakrishnan, AgalyaX > Sent: Tuesday, March 5, 2019 7:28 PM > To: dev@dpdk.or

Re: [dpdk-dev] [PATCH 1/2] net/ice: suppport package download

2019-03-05 Thread Yang, Qiming
Yes, I will add the document update when I send v2 out. Thanks > -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Friday, March 1, 2019 9:40 PM > To: Yang, Qiming > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 1/2] net/ice: suppport package download >

Re: [dpdk-dev] [PATCH v3 0/2] Timer library changes

2019-03-05 Thread Varghese, Vipin
Hi Erik, Apologies if I am reaching out a bit late. Please find my query below > > This enables primary and secondary processes to modify the same timer > > list, which enables some multi-process use cases that were not > > previously possible; e.g. a secondary process can start a timer whose >

Re: [dpdk-dev] [RFC] net/mlx4: add secondary process support

2019-03-05 Thread Arthas Kang
you can modify rdma-core libibverbs contain "MADV_DONTFORK" code. On Sun, Mar 3, 2019 at 3:11 PM Shahaf Shuler wrote: > Same question regarding patchwork. > > Friday, March 1, 2019 3:27 AM, Yongseok Koh: > > Subject: [RFC] net/mlx4: add secondary process support > > > > In 19.05, mlx4 PMD will

[dpdk-dev] [PATCH v1] ring: enforce reading the tails before ring operations

2019-03-05 Thread gavin hu
In weak memory models, like arm64, reading the {prod,cons}.tail may get reordered after reading or writing the ring slots, which corrupts the ring and stale data is observed. This issue was reported by NXP on 8-A72 DPAA2 board. The problem is most likely caused by missing the acquire semantics when

[dpdk-dev] [PATCH v2 0/6] HelloWorld example for windows

2019-03-05 Thread Anand Rawat
Includes Windows-specific EAL changes and meson changes to build the code on windows. v2 Changes: Incorporated reviews from v1. Fixed license period for updated files. Renamed 'winapp' folder to 'windows'. Cleaned unneeded meson changes. Fixed code style warnings. Added maintainers information fo

[dpdk-dev] [PATCH v2 2/6] eal: add header files to support windows

2019-03-05 Thread Anand Rawat
Added header files to support windows on x86 platforms. Updated rte_config to include rte_windows.h for windows build. Signed-off-by: Anand Rawat Signed-off-by: Pallavi Kadam Reviewed-by: Jeff Shaw Reviewed-by: Ranjit Menon --- config/rte_config.h | 7 +- .../ea

[dpdk-dev] [PATCH v2 3/6] eal: add headers for compatibility with windows environment

2019-03-05 Thread Anand Rawat
Added headers to support windows environment for common source. These headers will have windows specific implementions of the system library apis provided in linux and freebsd. Signed-off-by: Anand Rawat Signed-off-by: Pallavi Kadam Reviewed-by: Jeff Shaw Reviewed-by: Ranjit Menon --- .../win

[dpdk-dev] [PATCH v2 1/6] eal: eal stub to add windows support

2019-03-05 Thread Anand Rawat
Added initial stub source files for windows support and meson changes to build them. Signed-off-by: Anand Rawat Signed-off-by: Pallavi Kadam Reviewed-by: Jeff Shaw Reviewed-by: Ranjit Menon --- config/meson.build | 22 --- config/x86/meson.build | 14

[dpdk-dev] [PATCH v2 6/6] doc: add documention for windows

2019-03-05 Thread Anand Rawat
Added documentation to build helloworld example on windows using meson and clang. Updated the maintainers list to include windows maintainers. Signed-off-by: Anand Rawat Signed-off-by: Pallavi Kadam Reviewed-by: Jeff Shaw Reviewed-by: Ranjit Menon --- MAINTAINERS |

[dpdk-dev] [PATCH v2 4/6] eal: add minimum viable code for eal on windows

2019-03-05 Thread Anand Rawat
Add windows specific logic for eal.c, eal_lcore.c, eal_debug.c and eal_thread.c. Update meson logic to build eal on windows. Signed-off-by: Anand Rawat Signed-off-by: Pallavi Kadam Reviewed-by: Jeff Shaw Reviewed-by: Ranjit Menon --- lib/librte_eal/common/meson.build | 94 +--

[dpdk-dev] [PATCH v2 5/6] examples: add meson changes for windows

2019-03-05 Thread Anand Rawat
Add meson changes to build helloworld example on windows. Only EAL is supported currently. Signed-off-by: Anand Rawat Signed-off-by: Pallavi Kadam Reviewed-by: Jeff Shaw Reviewed-by: Ranjit Menon --- examples/meson.build | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --g

Re: [dpdk-dev] [PATCH 2/2] doc: add notes regarding eventdev producer consumer dependency

2019-03-05 Thread Gujjar, Abhinandan S
> -Original Message- > From: Jerin Jacob Kollanukkaran > Sent: Tuesday, March 5, 2019 8:46 PM > To: Pavan Nikhilesh Bhagavatula > Cc: Mcnamara, John ; Rao, Nikhil > ; Carrillo, Erik G ; Gujjar, > Abhinandan S ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 2/2] doc: add notes regarding e

Re: [dpdk-dev] Segfault when eal thread executing mlx5 nic‘s lsc event

2019-03-05 Thread Shahaf Shuler
Hi Yunjian, Wednesday, March 6, 2019 5:06 AM, Zhaohui (zhaohui, Polestar): > Subject: [dpdk-dev] Segfault when eal thread executing mlx5 nic‘s lsc event > > Hi: > I think the flow list may be accessed in the same time by two different > threads and may cause some errors. Do it need a lock to

Re: [dpdk-dev] [PATCH] app/testpmd: fix help info for interactive commands

2019-03-05 Thread Rami Rosen
+1 > > Could you categorize this related TM commands to a new group? As you know, > the commands in "help config" almost over flow. > > Thanks > Jingjing > >