Re: [dpdk-dev] [PATCH] vhost: remove vhost-net requirements from generic vhost APIs

2019-02-27 Thread Maxime Coquelin
On 2/25/19 12:35 AM, Dariusz Stojaczyk wrote: From: Darek Stojaczyk The rte_vhost API to put data into virtqueues operates on mbufs and hence it is strictly vhost-net specific. External backends need to implement virtqueue handling from scratch and that's just not possible without APIs to ge

Re: [dpdk-dev] [PATCH 0/4] Some fixes for vhost zero copy

2019-02-27 Thread Maxime Coquelin
On 2/22/19 3:42 AM, Tiwei Bie wrote: Tiwei Bie (4): vhost: restore mbuf first when freeing zmbuf vhost: fix potential use-after-free for zero copy mbuf vhost: fix potential use-after-free for memory region doc: improve vhost zero copy guide doc/guides/prog_guide/vhost_lib.rst |

Re: [dpdk-dev] [PATCH 0/4] Some fixes for vhost zero copy

2019-02-27 Thread Maxime Coquelin
On 2/27/19 2:52 AM, Tiwei Bie wrote: On Tue, Feb 26, 2019 at 03:46:41PM +0100, Maxime Coquelin wrote: On 2/22/19 3:42 AM, Tiwei Bie wrote: Tiwei Bie (4): vhost: restore mbuf first when freeing zmbuf vhost: fix potential use-after-free for zero copy mbuf vhost: fix potential use-a

Re: [dpdk-dev] [PATCH v8 6/6] build: use dependency for pcap and fallback to find_library

2019-02-27 Thread Thomas Monjalon
26/02/2019 18:49, Luca Boccassi: > On Tue, 2019-02-26 at 17:46 +, luca.bocca...@gmail.com wrote: > > From: Luca Boccassi > > > > pcap has historically shipped a custom pcap-config binary tool which > > does the job of pkg-config. It was never compatible with cross > > compilation. > > Meson u

[dpdk-dev] [PATCH] vhost: prevent disabled rings to be processed with zero-copy

2019-02-27 Thread Maxime Coquelin
The vhost-user spec says that once the vring is disabled, the client has to stop processing it. But it can happen when dequeue zero-copy is enabled if outstanding descriptors buffers are still being processed by an extranl NIC or another guest. The fix consists in draining the zmbufs list to ensur

Re: [dpdk-dev] locking around rx_intr_enable/disable?

2019-02-27 Thread Andrew Rybchenko
On 2/26/19 9:14 PM, Stephen Hemminger wrote: I noticed an anomaly in how receive interrupt control is done. In l3fwd-power there is a per-port lock around calls to enable interrupts but no locking around the call to disable interrupts. This looks broken since intr_disable requires multiple oper

Re: [dpdk-dev] vhost: add virtio configuration space access socket messages

2019-02-27 Thread Maxime Coquelin
On 2/26/19 3:07 PM, Ilya Maximets wrote: On 26.02.2019 16:43, Maxime Coquelin wrote: On 2/26/19 2:36 PM, Ilya Maximets wrote: On 26.02.2019 15:32, Maxime Coquelin wrote: On 2/26/19 9:42 AM, Ilya Maximets wrote: On 26.02.2019 11:13, Liu, Changpeng wrote: -Original Message- F

Re: [dpdk-dev] vhost: add virtio configuration space access socket messages

2019-02-27 Thread Maxime Coquelin
On 2/27/19 2:31 AM, Liu, Changpeng wrote: -Original Message- From: Maxime Coquelin [mailto:maxime.coque...@redhat.com] Sent: Tuesday, February 26, 2019 8:32 PM To: Ilya Maximets ; Liu, Changpeng ; dev@dpdk.org Cc: Stojaczyk, Dariusz ; Bie, Tiwei ; Wang, Zhihong ; Jason Wang Subject

Re: [dpdk-dev] [PATCH 1/6] net/dpaa2: add support for VLAN tpid config

2019-02-27 Thread Ferruh Yigit
On 2/22/2019 11:15 AM, Hemant Agrawal wrote: > This patch add support to config custom tpid in dpni. > i.e. value other than 0x8100 and 0x88A8 > > Signed-off-by: Hemant Agrawal Series applied to dpdk-next-net/master, thanks. Hi Hemant, What do you think adding a release notes update related to

Re: [dpdk-dev] [dpdk-stable] [PATCH v3] drivers: fix to replace strcat with strlcat

2019-02-27 Thread Ferruh Yigit
On 2/27/2019 6:02 AM, Chaitanya Babu Talluri wrote: > Strcat does not check the destination length and there might be > chances of string overflow so instead of strcat, strlcat is used. > > Fixes: 540a211084 ("bnx2x: driver core") > Fixes: e163c18a15 ("net/i40e: update ptype and pctype info") > Fi

Re: [dpdk-dev] [PATCH v8 6/6] build: use dependency for pcap and fallback to find_library

2019-02-27 Thread Bruce Richardson
On Wed, Feb 27, 2019 at 09:33:12AM +0100, Thomas Monjalon wrote: > 26/02/2019 18:49, Luca Boccassi: > > On Tue, 2019-02-26 at 17:46 +, luca.bocca...@gmail.com wrote: > > > From: Luca Boccassi > > > > > > pcap has historically shipped a custom pcap-config binary tool which > > > does the job o

Re: [dpdk-dev] vhost: add virtio configuration space access socket messages

2019-02-27 Thread Liu, Changpeng
> -Original Message- > From: Maxime Coquelin [mailto:maxime.coque...@redhat.com] > Sent: Wednesday, February 27, 2019 5:12 PM > To: Liu, Changpeng ; Ilya Maximets > ; dev@dpdk.org > Cc: Stojaczyk, Dariusz ; Bie, Tiwei > ; Wang, Zhihong ; Jason Wang > > Subject: Re: vhost: add virtio conf

Re: [dpdk-dev] [PATCH v3] drivers: fix to replace strcat with strlcat

2019-02-27 Thread Bruce Richardson
On Wed, Feb 27, 2019 at 06:02:51AM +, Chaitanya Babu Talluri wrote: > Strcat does not check the destination length and there might be > chances of string overflow so instead of strcat, strlcat is used. > > Fixes: 540a211084 ("bnx2x: driver core") > Fixes: e163c18a15 ("net/i40e: update ptype an

[dpdk-dev] [RFC 1/2] vhost: add API to set protocol features flags

2019-02-27 Thread Maxime Coquelin
rte_vhost_driver_set_protocol_features API is to be used by external backends to advertize vhost-user protocol features it supports. It has to be called after rte_vhost_driver_register() and before rte_vhost_driver_start(). Example of usage to advertize VHOST_USER_PROTOCOL_F_FOOBAR protocol featu

[dpdk-dev] [RFC 0/2] vhost: Support external backend only vhost-user requests

2019-02-27 Thread Maxime Coquelin
The goals of this series is to provide more flexibility to external backends to implement their specific vhost-user request handling without having to patch vhost-user library. First patch implements a new API for external backend to advertize its specific protocol features to vhost-user master.

[dpdk-dev] [RFC 2/2] vhost: support vhost-user request only handled by external backend

2019-02-27 Thread Maxime Coquelin
External backends may have specific requests to handle, and so we don't want the vhost-user lib to handle these requests as errors. This patch also catch the case where a request is neither handled by the external backend nor by the vhost library. Signed-off-by: Maxime Coquelin --- lib/librte_v

Re: [dpdk-dev] vhost: add virtio configuration space access socket messages

2019-02-27 Thread Maxime Coquelin
On 2/27/19 10:50 AM, Liu, Changpeng wrote: What we need to do is fix vhost lib so that you don't have anything to do in dpdk to add support for the new requests. So we need to fix the few bits in vhost_user_msg_handler() I mentionned yesterday. And I also notice we are missing rte_vhost_drive

Re: [dpdk-dev] [PATCH v2 2/4] ethdev: add siblings iterators

2019-02-27 Thread Gaëtan Rivet
Hi Thomas, On Wed, Feb 20, 2019 at 11:10:49PM +0100, Thomas Monjalon wrote: > If multiple ports share the same hardware device (rte_device), > they are siblings and can be found thanks to the new functions > and loop macros. > One iterator takes a port id as reference, > while the other one direct

Re: [dpdk-dev] [PATCH] vhost: prevent disabled rings to be processed with zero-copy

2019-02-27 Thread Tiwei Bie
On Wed, Feb 27, 2019 at 09:54:28AM +0100, Maxime Coquelin wrote: > The vhost-user spec says that once the vring is disabled, the > client has to stop processing it. But it can happen when > dequeue zero-copy is enabled if outstanding descriptors buffers > are still being processed by an extranl NIC

Re: [dpdk-dev] [PATCH] vhost: prevent disabled rings to be processed with zero-copy

2019-02-27 Thread Maxime Coquelin
On 2/27/19 11:10 AM, Tiwei Bie wrote: On Wed, Feb 27, 2019 at 09:54:28AM +0100, Maxime Coquelin wrote: The vhost-user spec says that once the vring is disabled, the client has to stop processing it. But it can happen when dequeue zero-copy is enabled if outstanding descriptors buffers are sti

[dpdk-dev] [PATCH v2] test: add snow3g test cases when digest is encrypted

2019-02-27 Thread Lukasz Krakowiak
Add test case for encryption, dectryption for snow3g when digest is encrypted Signed-off-by: Lukasz Krakowiak --- test/test/test_cryptodev.c| 91 ++-- .../test/test_cryptodev_snow3g_test_vectors.h | 132 +- 2 files changed, 210 insertions(+), 13 delet

Re: [dpdk-dev] [PATCH v3] drivers: fix to replace strcat with strlcat

2019-02-27 Thread Pattan, Reshma
> -Original Message- > From: Chaitanya Babu, TalluriX > Sent: Wednesday, February 27, 2019 6:03 AM > To: dev@dpdk.org > diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c > index dca61f03a..fac4e943f 100644 > --- a/drivers/net/i40e/i40e_ethdev.c > +++ b/drivers/

Re: [dpdk-dev] [PATCH v8 6/6] build: use dependency for pcap and fallback to find_library

2019-02-27 Thread Luca Boccassi
On Wed, 2019-02-27 at 09:47 +, Bruce Richardson wrote: > On Wed, Feb 27, 2019 at 09:33:12AM +0100, Thomas Monjalon wrote: > > 26/02/2019 18:49, Luca Boccassi: > > > On Tue, 2019-02-26 at 17:46 +, luca.bocca...@gmail.com wrote: > > > > From: Luca Boccassi > > > > > > > > pcap has historica

Re: [dpdk-dev] [PATCH v2 2/4] ethdev: add siblings iterators

2019-02-27 Thread Thomas Monjalon
27/02/2019 11:07, Gaëtan Rivet: > Hi Thomas, > > On Wed, Feb 20, 2019 at 11:10:49PM +0100, Thomas Monjalon wrote: > > If multiple ports share the same hardware device (rte_device), > > they are siblings and can be found thanks to the new functions > > and loop macros. > > One iterator takes a port

[dpdk-dev] [PATCH 1/2] metrics: new API to deinitialise metrics library

2019-02-27 Thread Harman Kalra
Once the library usage is over, it must be deinitialized which will free the shared memory reserved during initialization. Fixes: observed an issue while running 'metrics_autotest' continuously without quiting. For the first run 'metrics_autotest' passes all test cases but second run onwards first

Re: [dpdk-dev] [PATCH] vhost: fix interrupt suppression for the split ring

2019-02-27 Thread Tiwei Bie
On Wed, Feb 27, 2019 at 01:38:28PM +0800, Hu, Jiayu wrote: > > -Original Message- > > From: Bie, Tiwei > > Sent: Monday, February 25, 2019 3:07 PM > > To: Hu, Jiayu > > Cc: dev@dpdk.org; maxime.coque...@redhat.com; sta...@dpdk.org > > Subject: Re: [PATCH] vhost: fix interrupt suppression f

Re: [dpdk-dev] [PATCH v8 6/6] build: use dependency for pcap and fallback to find_library

2019-02-27 Thread Thomas Monjalon
27/02/2019 11:50, Luca Boccassi: > On Wed, 2019-02-27 at 09:47 +, Bruce Richardson wrote: > > On Wed, Feb 27, 2019 at 09:33:12AM +0100, Thomas Monjalon wrote: > > > 26/02/2019 18:49, Luca Boccassi: > > > > On Tue, 2019-02-26 at 17:46 +, luca.bocca...@gmail.com wrote: > > > > > From: Luca Bo

Re: [dpdk-dev] [PATCH 5/5] sfc: don't use RTE_LOGTYPE_PMD

2019-02-27 Thread Ferruh Yigit
On 2/26/2019 9:34 PM, Stephen Hemminger wrote: > The sfc driver was still using RTE_LOGTYPE_PMD which was superseded > by local logging. > > Signed-off-by: Stephen Hemminger > --- > drivers/net/sfc/sfc.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/sf

Re: [dpdk-dev] [PATCH 5/5] sfc: don't use RTE_LOGTYPE_PMD

2019-02-27 Thread Andrew Rybchenko
On 2/27/19 2:21 PM, Ferruh Yigit wrote: On 2/26/2019 9:34 PM, Stephen Hemminger wrote: The sfc driver was still using RTE_LOGTYPE_PMD which was superseded by local logging. Signed-off-by: Stephen Hemminger --- drivers/net/sfc/sfc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

Re: [dpdk-dev] [PATCH v8 1/6] build: bump minimum Meson version to 0.47.1

2019-02-27 Thread Thomas Monjalon
26/02/2019 18:46, luca.bocca...@gmail.com: > From: Luca Boccassi > > Meson 0.47.1 fixed a bug that is difficult to work around, which causes > the linker flag of dependencies to be repeated dozens of times, which > causes issues especially when using the built-in dependency() API. > Bump the mini

Re: [dpdk-dev] [PATCH v6] doc/patches: add meson build to contributing guide

2019-02-27 Thread Thomas Monjalon
13/02/2019 06:41, Vipin Varghese: > Patches has to be validated for meson devtool script for > code and document changes. Updating documentation for meson > build steps in checking Compilation category. > > Signed-off-by: Vipin Varghese > Tested-by: Marko Kovacevic > Acked-by: Marko Kovacevic

[dpdk-dev] [PATCH v2] net/nfb: new Netcope driver

2019-02-27 Thread Rastislav Cernay
From: Rastislav Cernay Added new net driver for Netcope nfb cards Signed-off-by: Rastislav Cernay --- v2: remove unnecessary cast remove unnecessary zeroing move declaration to not mix with code restore skeleton example MAINTAINERS | 7 + config/common_base

Re: [dpdk-dev] vhost: add virtio configuration space access socket messages

2019-02-27 Thread Ilya Maximets
On 27.02.2019 12:04, Maxime Coquelin wrote: > > > On 2/26/19 3:07 PM, Ilya Maximets wrote: >> On 26.02.2019 16:43, Maxime Coquelin wrote: >>> >>> >>> On 2/26/19 2:36 PM, Ilya Maximets wrote: On 26.02.2019 15:32, Maxime Coquelin wrote: > > > On 2/26/19 9:42 AM, Ilya Maximets wrote

Re: [dpdk-dev] [PATCH 5/5] sfc: don't use RTE_LOGTYPE_PMD

2019-02-27 Thread Ferruh Yigit
On 2/27/2019 11:24 AM, Andrew Rybchenko wrote: > On 2/27/19 2:21 PM, Ferruh Yigit wrote: >> On 2/26/2019 9:34 PM, Stephen Hemminger wrote: >>> The sfc driver was still using RTE_LOGTYPE_PMD which was superseded >>> by local logging. >>> >>> Signed-off-by: Stephen Hemminger >>> --- >>> drivers/ne

Re: [dpdk-dev] [PATCH v2] app/pdump: only remove created vdevs

2019-02-27 Thread Ferruh Yigit
On 2/26/2019 4:04 PM, Gage Eads wrote: > This commit fixes a bug in which a unidirectional pdump could attempt to > remove devices it didn't create. > > Fixes: 35cb223ab7be ("app/pdump: fix vdev cleanup") > Cc: sta...@dpdk.org > > Signed-off-by: Gage Eads > Acked-by: Reshma Pattan Applied to d

Re: [dpdk-dev] [PATCH v8 6/6] build: use dependency for pcap and fallback to find_library

2019-02-27 Thread Luca Boccassi
On Wed, 2019-02-27 at 11:56 +0100, Thomas Monjalon wrote: > 27/02/2019 11:50, Luca Boccassi: > > On Wed, 2019-02-27 at 09:47 +, Bruce Richardson wrote: > > > On Wed, Feb 27, 2019 at 09:33:12AM +0100, Thomas Monjalon wrote: > > > > 26/02/2019 18:49, Luca Boccassi: > > > > > On Tue, 2019-02-26 at

Re: [dpdk-dev] [PATCH v6] doc/patches: add meson build to contributing guide

2019-02-27 Thread Varghese, Vipin
Thanks > -Original Message- > From: Thomas Monjalon > Sent: Wednesday, February 27, 2019 5:11 PM > To: Varghese, Vipin > Cc: dev@dpdk.org; Mcnamara, John ; Kovacevic, > Marko ; Yigit, Ferruh ; > Richardson, Bruce ; Padubidri, Sanjay A > ; Patel, Amol > Subject: Re: [dpdk-dev] [PATCH v6]

Re: [dpdk-dev] [PATCH v2] build: mention machine=default and its use in documentation

2019-02-27 Thread Luca Boccassi
On Mon, 2019-01-14 at 13:41 +, Luca Boccassi wrote: > Document the new value, as it's useful for distributions and users > who need to use a stable baseline -march > > Signed-off-by: Luca Boccassi > Reviewed-by: Christian Ehrhardt > --- > v2: fix typo, add commit body and reviewed-by > > d

Re: [dpdk-dev] [PATCH 5/5] sfc: don't use RTE_LOGTYPE_PMD

2019-02-27 Thread Ferruh Yigit
On 2/27/2019 11:50 AM, Ferruh Yigit wrote: > On 2/27/2019 11:24 AM, Andrew Rybchenko wrote: >> On 2/27/19 2:21 PM, Ferruh Yigit wrote: >>> On 2/26/2019 9:34 PM, Stephen Hemminger wrote: The sfc driver was still using RTE_LOGTYPE_PMD which was superseded by local logging. Signed-

Re: [dpdk-dev] [PATCH v3] build: use generic march on arm64 when using 'default' machine

2019-02-27 Thread Luca Boccassi
On Mon, 2019-01-07 at 14:11 +, Luca Boccassi wrote: > When building for generic distribution we need a stable baseline > architecture, or depending on the build worker the result will vary. > > Force the default flags if the user explicitly sets machine=default > at configuration time. > > Fi

Re: [dpdk-dev] [PATCH 5/5] sfc: don't use RTE_LOGTYPE_PMD

2019-02-27 Thread Andrew Rybchenko
On 2/27/19 3:19 PM, Ferruh Yigit wrote: On 2/27/2019 11:50 AM, Ferruh Yigit wrote: On 2/27/2019 11:24 AM, Andrew Rybchenko wrote: On 2/27/19 2:21 PM, Ferruh Yigit wrote: On 2/26/2019 9:34 PM, Stephen Hemminger wrote: The sfc driver was still using RTE_LOGTYPE_PMD which was superseded by local

Re: [dpdk-dev] [RFC 2/2] vhost: support vhost-user request only handled by external backend

2019-02-27 Thread Ilya Maximets
On 27.02.2019 13:02, Maxime Coquelin wrote: > External backends may have specific requests to handle, and so > we don't want the vhost-user lib to handle these requests as > errors. > > This patch also catch the case where a request is neither handled > by the external backend nor by the vhost lib

[dpdk-dev] [PATCH v2 1/3] lib/cryptodev: add rsa priv key feature flag

2019-02-27 Thread Ayuj Verma
Add feature flag to reflect RSA private key operation support using quintuple (crt) or exponent type key. if PMD support both, then it should set both. App should query cryptodev feature flag to check if Sign and Decryt with CRT keys or exponent is supported, thus call operation with relevant key

[dpdk-dev] [PATCH v2 2/3] crypto/openssl: set rsa private op feature flag

2019-02-27 Thread Ayuj Verma
openssl PMD support RSA private key operation using both qt and exp key type. Set both feature flag in PMD capability Signed-off-by: Ayuj Verma Signed-off-by: Shally Verma --- drivers/crypto/openssl/rte_openssl_pmd.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers

[dpdk-dev] [PATCH v2 0/3] adding rsa priv key feature flag

2019-02-27 Thread Ayuj Verma
Some PMDs can only support RSA private key operations using CRT (quintuple) or exponent key only. Thus it is required to add feature flag (ff) in PMD to reflect which key type is supported to perform sign and decrypt ops. Thus add feature flags RTE_CRYPTODEV_FF_RSA_PRIV_OP_KEY_EXP and RTE_CRYPTODE

[dpdk-dev] [PATCH v2 3/3] test/crypto: check for rsa key type feature flag

2019-02-27 Thread Ayuj Verma
Check for RSA private key type feature flag in private key operations Signed-off-by: Ayuj Verma Signed-off-by: Shally Verma --- test/test/test_cryptodev_asym.c | 26 ++ 1 file changed, 26 insertions(+) diff --git a/test/test/test_cryptodev_asym.c b/test/test/test_crypto

Re: [dpdk-dev] [PATCH v8 6/6] build: use dependency for pcap and fallback to find_library

2019-02-27 Thread Bruce Richardson
On Wed, Feb 27, 2019 at 12:03:48PM +, Luca Boccassi wrote: > On Wed, 2019-02-27 at 11:56 +0100, Thomas Monjalon wrote: > > 27/02/2019 11:50, Luca Boccassi: > > > On Wed, 2019-02-27 at 09:47 +, Bruce Richardson wrote: > > > > On Wed, Feb 27, 2019 at 09:33:12AM +0100, Thomas Monjalon wrote: >

Re: [dpdk-dev] [PATCH v5 2/2] ci: Introduce travis builds for github repositories

2019-02-27 Thread Thomas Monjalon
Hi, 07/02/2019 23:01, Michael Santana: > GitHub is a service used by developers to store repositories. GitHub > provides service integrations that allow 3rd party services to access > developer repositories and perform actions. One of these services is > Travis-CI, a simple continuous integratio

Re: [dpdk-dev] Question about DPDK hugepage fd change

2019-02-27 Thread Iain Barker
Original Message from: Burakov, Anatoly [mailto:anatoly.bura...@intel.com] >I just realized that, unless you're using --legacy-mem switch, one other >way to alleviate the issue would be to use --single-file-segments >option. This will still store the fd's, however it will only do so per >memse

[dpdk-dev] [RFC] net/mlx5: add support for direct rule lib

2019-02-27 Thread Ori Kam
A number of applications that are based on the DPDK like OVS and other vswitch applications, require for their correct use, very high flow insertion rate. In current implementation each flow is downloaded to the device using RDMA-Core, Kernel and FW. The main bottleneck is the FW. The solution

Re: [dpdk-dev] [PATCH v5 1/2] examples/vhost_scsi: Don't build without virtio_scsi.h

2019-02-27 Thread Thomas Monjalon
07/02/2019 23:01, Michael Santana: > From: Aaron Conole > > The vhost_scsi example code is set to build, even if the requisite header > file virtio_scsi.h isn't available. This happens on some Ubuntu systems > when some versions of the libc-dev package aren't available. > > Check whether the vi

Re: [dpdk-dev] [PATCH v5 2/2] ci: Introduce travis builds for github repositories

2019-02-27 Thread Aaron Conole
Thomas Monjalon writes: > Hi, > > 07/02/2019 23:01, Michael Santana: >> GitHub is a service used by developers to store repositories. GitHub >> provides service integrations that allow 3rd party services to access >> developer repositories and perform actions. One of these services is >> Travis

Re: [dpdk-dev] [PATCH v5 2/2] ci: Introduce travis builds for github repositories

2019-02-27 Thread Thomas Monjalon
27/02/2019 15:35, Aaron Conole: > Thomas Monjalon writes: > > 07/02/2019 23:01, Michael Santana: > >> +# Just used for the 'classic' configuration system (ie: make) > > > > I am not sure about supporting the legacy system in a new CI. > > For now, documentation all says that the legacy system is

Re: [dpdk-dev] [PATCH v2] net/nfb: new Netcope driver

2019-02-27 Thread Ferruh Yigit
On 2/27/2019 11:43 AM, Rastislav Cernay wrote: > From: Rastislav Cernay > > Added new net driver for Netcope nfb cards > > Signed-off-by: Rastislav Cernay > --- > v2: remove unnecessary cast > remove unnecessary zeroing > move declaration to not mix with code > restore skeleton exam

[dpdk-dev] [PATCH] vfio: document multiprocess limitation for container API

2019-02-27 Thread Anatoly Burakov
Currently, there is no support for sharing custom VFIO containers between multiple processes, but it is not documented. Document this limitation. Cc: sta...@dpdk.org Signed-off-by: Anatoly Burakov --- lib/librte_eal/common/include/rte_vfio.h | 4 1 file changed, 4 insertions(+) diff --gi

Re: [dpdk-dev] [PATCH v5 2/2] ci: Introduce travis builds for github repositories

2019-02-27 Thread Aaron Conole
Thomas Monjalon writes: > 27/02/2019 15:35, Aaron Conole: >> Thomas Monjalon writes: >> > 07/02/2019 23:01, Michael Santana: >> >> +# Just used for the 'classic' configuration system (ie: make) >> > >> > I am not sure about supporting the legacy system in a new CI. >> >> For now, documentation

Re: [dpdk-dev] [PATCH v5 2/2] ci: Introduce travis builds for github repositories

2019-02-27 Thread Luca Boccassi
On Wed, 2019-02-27 at 10:53 -0500, Aaron Conole wrote: > Thomas Monjalon writes: > > > 27/02/2019 15:35, Aaron Conole: > > > Thomas Monjalon writes: > > > > 07/02/2019 23:01, Michael Santana: > > > > > +python3.5 -m pip install --upgrade meson --user > > > > > > > > Which distributions have pyt

[dpdk-dev] [PATCH v2] net/sfc: do not use PMD logtype

2019-02-27 Thread Ferruh Yigit
From: Stephen Hemminger The sfc driver was still using RTE_LOGTYPE_PMD which was superseded by local logging. Signed-off-by: Stephen Hemminger --- v2: * Replaced all RTE_LOGTYPE_PMD instances in sfc_register_logtype() * ternary replaced with if and multiple return because of the compiler erro

Re: [dpdk-dev] [PATCH v5 2/2] ci: Introduce travis builds for github repositories

2019-02-27 Thread Aaron Conole
Luca Boccassi writes: > On Wed, 2019-02-27 at 10:53 -0500, Aaron Conole wrote: >> Thomas Monjalon writes: >> >> > 27/02/2019 15:35, Aaron Conole: >> > > Thomas Monjalon writes: >> > > > 07/02/2019 23:01, Michael Santana: >> > > > > +python3.5 -m pip install --upgrade meson --user >> > > > >>

Re: [dpdk-dev] [RFC v4] /net: memory interface (memif)

2019-02-27 Thread Ferruh Yigit
On 2/20/2019 11:52 AM, Jakub Grajciar wrote: > Memory interface (memif), provides high performance > packet transfer over shared memory. > > Signed-off-by: Jakub Grajciar > --- > MAINTAINERS |6 + > config/common_base |5 + > confi

[dpdk-dev] [PATCH v5] lib/metrics: add unregister api for metrics

2019-02-27 Thread Junjie Wan
From: junka The bitmap will help maintain the metrics. We can dynamically add and remove metrics data. For example, after uninit latency lib, it could remove itself from the metrics. This could make the result from rte_metrics_get_names much more simple to display the wanted metrics data only. S

Re: [dpdk-dev] [PATCH 5/5] sfc: don't use RTE_LOGTYPE_PMD

2019-02-27 Thread Stephen Hemminger
On Wed, 27 Feb 2019 14:24:21 +0300 Andrew Rybchenko wrote: > On 2/27/19 2:21 PM, Ferruh Yigit wrote: > > On 2/26/2019 9:34 PM, Stephen Hemminger wrote: > >> The sfc driver was still using RTE_LOGTYPE_PMD which was superseded > >> by local logging. > >> > >> Signed-off-by: Stephen Hemminger > >

[dpdk-dev] [PATCH 1/2] app/eventdev: start event producers after eventdev is started

2019-02-27 Thread Pavan Nikhilesh Bhagavatula
From: Pavan Nikhilesh Start event producers after eventdev i.e. consumer is started as in some architectures it might lead to undefined behaviour or events being dropped. Signed-off-by: Pavan Nikhilesh --- app/test-eventdev/test_perf_atq.c | 31 + app/test-eventde

[dpdk-dev] [PATCH 2/2] doc: add notes regarding eventdev producer consumer dependency

2019-02-27 Thread Pavan Nikhilesh Bhagavatula
From: Pavan Nikhilesh EventDev i.e consumer needs to be started before starting the event producers. Update documentation of EventDev and EventDev adapters. Signed-off-by: Pavan Nikhilesh --- doc/guides/prog_guide/event_crypto_adapter.rst | 5 + doc/guides/prog_guide/event_ethernet_rx

[dpdk-dev] DPDK port for vcpkg

2019-02-27 Thread Ernest Zed
Hi, I've submitted a PR to vcpkg vcpkg overview: "Vcpkg helps you manage C and C++ libraries on Windows, Linux and MacOS. This tool and ecosystem are constantly evolving; your involvement is vital to its success!" I

[dpdk-dev] [PATCH v1 1/6] ethdev: add min/max MTU to device info

2019-02-27 Thread Ian Stokes
From: Stephen Hemminger This addresses the usability issue raised by OVS at DPDK Userspace summit. It adds general min/max mtu into device info. For compatiablity, and to save space, it fits in a hole in existing structure. The initial version sets max mtu to normal Ethernet, it is up to PMD to

[dpdk-dev] [PATCH v1 0/6] ethdev: add min/max MTU to device info

2019-02-27 Thread Ian Stokes
Building upon the discussion around [1], this series introduces MTU min and MTU max variables. It also provides updates to PMD implementations for ixgbe, i40e and IGB devices so that these variables are populated for use when retrieving device info. This series was tested with OVS DPDK and functio

[dpdk-dev] [PATCH v1 2/6] net/i40e: set min and max MTU for i40e devices

2019-02-27 Thread Ian Stokes
This commit sets the min and max supported MTU values for i40e devices via the i40e_dev_info_get() function. Min MTU supported is set to ETHER_MIN_MTU and max mtu is calculated as the max packet length supported minus the transport overhead. Signed-off-by: Ian Stokes --- drivers/net/i40e/i40e_et

[dpdk-dev] [PATCH v1 6/6] net/e1000: set min and max MTU for igb devices

2019-02-27 Thread Ian Stokes
This commit sets the min and max supported MTU values for igb devices via the eth_igb_info_get() function. Min MTU supported is set to ETHER_MIN_MTU and max mtu is calculated as the max packet length supported minus the transport overhead. To aid in these calculations a new MACRO 'E1000_ETH_OVERHEA

[dpdk-dev] [PATCH v1 5/6] net/ixgbe: set min and max MTU for ixgbe VF devices

2019-02-27 Thread Ian Stokes
This commit sets the min and max supported MTU values for ixgbe VF devices via the ixgbevf_dev_set_mtu() function. Min MTU supported is set to ETHER_MIN_MTU and max mtu is calculated as the max packet length supported minus the transport overhead. As transport overhead is the same for VF and PF ixg

[dpdk-dev] [PATCH v1 4/6] net/ixgbe: set min and max MTU for ixgbe devices

2019-02-27 Thread Ian Stokes
This commit sets the min and max supported MTU values for ixgbe devices via the ixgbe_dev_info_get() function. Min MTU supported is set to ETHER_MIN_MTU and max mtu is calculated as the max packet length supported minus the transport overhead. To aid in these calculations a new MACRO 'IXGBE_ETH_OVE

[dpdk-dev] [PATCH v1 3/6] net/i40e: set min and max MTU for i40e VF devices

2019-02-27 Thread Ian Stokes
This commit sets the min and max supported MTU values for i40e VF devices via the i40evf_dev_info_get() function. Min MTU supported is set to ETHER_MIN_MTU and max mtu is calculated as the max packet length supported minus the transport overhead. Signed-off-by: Ian Stokes --- drivers/net/i40e/i4

Re: [dpdk-dev] [RFC 1/6] ethdev: add min/max MTU to device info

2019-02-27 Thread Ian Stokes
On 2/25/2019 7:40 AM, Andrew Rybchenko wrote: On 2/20/19 6:57 PM, Ian Stokes wrote: From: Stephen Hemminger This addresses the usability issue raised by OVS at DPDK Userspace summit. It adds general min/max mtu into device info. For compatiablity, and to save space, it fits in a hole in existin

[dpdk-dev] [dpdk-announce] DPDK development process and tools survey

2019-02-27 Thread Honnappa Nagarahalli
Hello, There have been questions/comments in the past DPDK summits on improving the development process and the tools being used. This survey is being conducted to better understand the pain points and arrive at a set of tools to use going forward. The survey itself will be done in 2 st

Re: [dpdk-dev] [PATCH v3] net/ice: faster bit check

2019-02-27 Thread Zhang, Qi Z
> -Original Message- > From: Zhang, Qi Z > Sent: Monday, February 18, 2019 8:47 PM > To: Stillwell Jr, Paul M > Cc: dev@dpdk.org; Brandeburg, Jesse > Subject: RE: [PATCH v3] net/ice: faster bit check > > > > > -Original Message- > > From: Stillwell Jr, Paul M > > Sent: Satur

Re: [dpdk-dev] [PATCH 3/7] test/stack: add stack test

2019-02-27 Thread Eads, Gage
> -Original Message- > From: Olivier Matz [mailto:olivier.m...@6wind.com] > Sent: Monday, February 25, 2019 4:59 AM > To: Eads, Gage > Cc: dev@dpdk.org; arybche...@solarflare.com; Richardson, Bruce > ; Ananyev, Konstantin > ; gavin...@arm.com; > honnappa.nagaraha...@arm.com; n...@arm.co

Re: [dpdk-dev] [PATCH 1/7] stack: introduce rte stack library

2019-02-27 Thread Eads, Gage
> -Original Message- > From: Olivier Matz [mailto:olivier.m...@6wind.com] > Sent: Monday, February 25, 2019 4:43 AM > To: Eads, Gage > Cc: dev@dpdk.org; arybche...@solarflare.com; Richardson, Bruce > ; Ananyev, Konstantin > ; gavin...@arm.com; > honnappa.nagaraha...@arm.com; n...@arm.co

[dpdk-dev] [PATCH 00/37] share code update.

2019-02-27 Thread Qi Zhang
Main changes: 1. add DCB/FDIR support. 2. add more APIs in switch module. 3. code clean and bug fix. Qi Zhang (37): net/ice/base: add switch resource allocation and free net/ice/base: improve comments net/ice/base: add two helper functions net/ice/base: add helper macros net/ice/base: a

[dpdk-dev] [PATCH 01/37] net/ice/base: add switch resource allocation and free

2019-02-27 Thread Qi Zhang
Add two APIs ice_alloc_sw and ice_free_sw to support switch related resource allocation and free. Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_switch.c | 150 ++ drivers/net/ice/base/ice_switch.h | 5 ++ 2 files ch

[dpdk-dev] [PATCH 04/37] net/ice/base: add helper macros

2019-02-27 Thread Qi Zhang
1. Add macro ice_for_each_traffic_class to loop for each traffic class. 2. Add macro MIN_T to wrap min with type conversion. Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_common.c | 2 +- drivers/net/ice/base/ice_nvm.c| 7 --- drivers/net/ice/

[dpdk-dev] [PATCH 03/37] net/ice/base: add two helper functions

2019-02-27 Thread Qi Zhang
Add two helper functions in common module. 1. ice_aq_set_mac_cfg to help configure maximum frame size with AQ command 2. ice_get_ctx help to extract context bits from a packet structure. Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_adminq_cmd.h | 20 +

[dpdk-dev] [PATCH 07/37] net/ice/base: declare functions as external

2019-02-27 Thread Qi Zhang
Remove static of below functions and declare them as external APIs. ice_aq_add_vsi ice_aq_free_vsi ice_aq_update_vsi ice_aq_add_lan_txq ice_init_pkg Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_common.c| 2 +- drivers/net/ice/base/ice_common.h

[dpdk-dev] [PATCH 05/37] net/ice/base: allow package copy to be used after resets

2019-02-27 Thread Qi Zhang
For components that make a copy of an external pipeline package file (i.e. the Linux and FreeBSD drivers), save the size of the package file along with the copy so that both can be used when calling ice_init_pkg() after a CORER/GLOBR reset. Also, do not free the copy of the package file in ice_ini

[dpdk-dev] [PATCH 06/37] net/ice/base: code clean

2019-02-27 Thread Qi Zhang
Remove unnecessary macro and data structure. Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_adminq_cmd.h | 2 - drivers/net/ice/base/ice_flex_pipe.c | 2 - drivers/net/ice/base/ice_flow.c | 136 -- drivers/net/i

[dpdk-dev] [PATCH 12/37] net/ice/base: add APIs to alloc/free VLAN resource counter

2019-02-27 Thread Qi Zhang
1. ice_alloc_res_cntr - allocate resource counter 2. ice_free_res_cntr - free resource counter 3. ice_alloc_vlan_res_counter - allocate vlan resource counter 4. ice_free_vlan_res_counter - free vlan resource counter Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/ice/

[dpdk-dev] [PATCH 14/37] net/ice/base: add MAC filter with marker and counter

2019-02-27 Thread Qi Zhang
1. ice_add_mac_with_sw_marker - add filter with software marker. 2. ice_add_mac_with_counter - add filter with counter enabled. Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_switch.c | 328 ++ drivers/net/ice/base/ice

[dpdk-dev] [PATCH 09/37] net/ice/base: add VSI queue context framework

2019-02-27 Thread Qi Zhang
Added code to allocate VSI queue contexts to save the queue specific information like bandwidth etc. Signed-off-by: Victor Raj Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_sched.c | 52 +++ drivers/net/ice/base/ice

[dpdk-dev] [PATCH 11/37] net/ice/base: add APIs to get allocated resources

2019-02-27 Thread Qi Zhang
1. ice_aq_get_res_alloc - get allocated resources. 2. ice_aq_get_res_descs - get allocated resource descriptors. Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_adminq_cmd.h | 53 +- drivers/net/ice/base/ice_switch.c | 83 +

[dpdk-dev] [PATCH 13/37] net/ice/base: add APIs to get VSI promiscuous mode

2019-02-27 Thread Qi Zhang
1. ice_get_vsi_promisc - get promiscuous mode of give VSI. 2. ice_get_vsi_vlan_promisc - get VLAN promiscuous mode of given VSI. Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_switch.c | 79 +++ drivers/net/ice/base/ic

[dpdk-dev] [PATCH 10/37] net/ice/base: add APIs to add remove ethertype filter

2019-02-27 Thread Qi Zhang
Add API ice_remove_eth_mac and ice_add_eth_mac to support adding / removing ethertype (or MAC) based filter rules. Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_switch.c | 57 +++ drivers/net/ice/base/ice_switch.h |

[dpdk-dev] [PATCH 08/37] net/ice/base: add more APIs in switch module

2019-02-27 Thread Qi Zhang
Add below APIs in switch module 1. ice_aq_get_vsi_params - get VSI context info 2. ice_aq_add_update_mir_rule - add/update mirror rule 3. ice_aq_delete_mir_rule - delete mirror rule 4. ice_aq_set_storm_ctrl - set storm control configuration 5. ice_aq_get_storm_ctrl - get storm control configurati

[dpdk-dev] [PATCH 15/37] net/ice/base: add two helper functions for flow management

2019-02-27 Thread Qi Zhang
1. ice_rem_all_sw_rules_info - remove all switch rules. 2. ice_reply_all_fltr - replay all filters stored in book keeping list. Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_switch.c | 107 ++ drivers/net/ice/base/ice

[dpdk-dev] [PATCH 16/37] net/ice/base: minor fix

2019-02-27 Thread Qi Zhang
1. ICE_SW_LKUP_LAST need to be handled correctly in ice_aq_alloc_free_vsi_list and ice_update_vsi_list_rule 2. ICE_SW_LKUP_ETHERTYPE_MAC need to be handled correctly in ice_update_vsi_lkup_fltr 3. free package segment pointer during ice_deinit_hw Signed-off-by: Paul M Stillwell Jr Signed-off-by:

[dpdk-dev] [PATCH 17/37] net/ice/base: update macros

2019-02-27 Thread Qi Zhang
Update macros for metadata and package flags. Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_common.c| 36 - drivers/net/ice/base/ice_flow.h | 17 ++-- drivers/net/ice/base/ice_lan_tx_rx.h | 77 +++

[dpdk-dev] [PATCH 18/37] net/ice/base: code clean

2019-02-27 Thread Qi Zhang
Change below function as static and also relocated code line to align with kernel driver. ice_aq_move_sched_elems ice_sched_get_agg_node ice_sched_set_node_bw_lmt ice_sched_cfg_node_bw_alloc ice_sched_add_agg_cfg ice_sched_rm_agg_cfg ice_sched_move_vsi_to_agg ice_sched_del_rl_profile ice_sched_rm_

[dpdk-dev] [PATCH 20/37] net/ice/base: ensure only valid bits are set

2019-02-27 Thread Qi Zhang
In the ice_aq_set_phy_cfg AQ command, the 16.4 bit is reserved. This patch will make sure that this bit will never be set to 1. Signed-off-by: Chinh T Cao Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_adminq_cmd.h | 1 + drivers/net/ice/base/ice_common

[dpdk-dev] [PATCH 21/37] net/ice/base: enhance get link status command

2019-02-27 Thread Qi Zhang
Extend the functionality of the admin queue command by including additional status and ID bits to improve link topology configuration. Signed-off-by: Matthew Vick Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_adminq_cmd.h | 7 ++- 1 file changed, 6

[dpdk-dev] [PATCH 19/37] net/ice/base: enable VSI queue context

2019-02-27 Thread Qi Zhang
The patch added to retrieve the queue context and update the queue handle for lan queues. Signed-off-by: Victor Raj Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_common.c | 60 --- drivers/net/ice/base/ice_common.h |

[dpdk-dev] [PATCH 25/37] net/ice/base: minor fix

2019-02-27 Thread Qi Zhang
1. Fix some problems with filling the HW tables. 2. Fix a logic error in ice_rem_prof_from_list. Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_flex_pipe.c | 18 +++--- 1 file changed, 15 insertions(+), 3 deletions(-) diff --git a/drivers/ne

[dpdk-dev] [PATCH 27/37] net/ice/base: resolve static analysis reported issues

2019-02-27 Thread Qi Zhang
Resolve static analysis reported issue in ice_get_itr_intrl_gran and ice_ptg_find_ptype. Signed-off-by: Bruce Allan Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_common.c| 12 ++-- drivers/net/ice/base/ice_flex_pipe.c | 7 +-- 2 files

  1   2   >