Re: [dpdk-dev] vhost: add virtio configuration space access socket messages

> -Original Message- > From: Ilya Maximets [mailto:i.maxim...@samsung.com] > Sent: Tuesday, February 26, 2019 3:39 PM > To: Liu, Changpeng ; dev@dpdk.org > Cc: Stojaczyk, Dariusz ; > maxime.coque...@redhat.com; Bie, Tiwei ; Wang, > Zhihong ; Jason Wang > Subject: Re: vhost: add virtio co

Re: [dpdk-dev] vhost: add virtio configuration space access socket messages

On 26.02.2019 11:13, Liu, Changpeng wrote: > > >> -Original Message- >> From: Ilya Maximets [mailto:i.maxim...@samsung.com] >> Sent: Tuesday, February 26, 2019 3:39 PM >> To: Liu, Changpeng ; dev@dpdk.org >> Cc: Stojaczyk, Dariusz ; >> maxime.coque...@redhat.com; Bie, Tiwei ; Wang, >> Zhi

Re: [dpdk-dev] [PATCH v2 1/5] test/cmdline_test: move to app directory

19/02/2019 15:53, Bruce Richardson: > Move app to "app" directory and enable with meson build. > > CC: Olivier Matz > Signed-off-by: Bruce Richardson > --- > MAINTAINERS | 2 +- > app/Makefile| 1 + > {test => app}/cmdline_

[dpdk-dev] [PATCH] net/tap: fix multi process request

The structure was not initialized. Fixes: c9aa56edec8e ("net/tap: access primary process queues from secondary") Cc: sta...@dpdk.org Signed-off-by: Raslan Darawsheh --- drivers/net/tap/rte_eth_tap.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/

Re: [dpdk-dev] [PATCH v2 1/5] test/cmdline_test: move to app directory

On Tue, Feb 26, 2019 at 10:14:08AM +0100, Thomas Monjalon wrote: > 19/02/2019 15:53, Bruce Richardson: > > Move app to "app" directory and enable with meson build. > > > > CC: Olivier Matz > > Signed-off-by: Bruce Richardson > > --- > > MAINTAINERS | 2 +- > >

[dpdk-dev] [PATCH] doc: update release notes for iavf renaming

Update DPDK 19.05 release notes for iavf renaming. Signed-off-by: Leyi Rong --- doc/guides/rel_notes/release_19_05.rst | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/doc/guides/rel_notes/release_19_05.rst b/doc/guides/rel_notes/release_19_05.rst index c0390ca16..

Re: [dpdk-dev] [PATCH] net/tap: fix multi process request

Reviewed-by: Rami Rosen On Tue, Feb 26, 2019 at 11:51 AM Raslan Darawsheh wrote: > The structure was not initialized. > > Fixes: c9aa56edec8e ("net/tap: access primary process queues from > secondary") > Cc: sta...@dpdk.org > > Signed-off-by: Raslan Darawsheh > --- > drivers/net/tap/rte_eth_

Re: [dpdk-dev] [PATCH] drivers/net: fix shifting 32-bit signed variable 31 times

On 2/19/2019 1:24 PM, Andrius Sirvys wrote: > Shifting signed 32-bit values by 31-bits has the potential for > unexpected outcomes as compiler can overwrite a bit. > Specified that values are unsigned. > > Errors are observed from running cppcheck. > > Bugzilla ID: 58 > Fixes: 69e209be5464 ("net

Re: [dpdk-dev] [PATCH] doc: update release notes for iavf renaming

On 2/26/2019 5:58 PM, Leyi Rong wrote: > Update DPDK 19.05 release notes for iavf renaming. > > Signed-off-by: Leyi Rong > --- > doc/guides/rel_notes/release_19_05.rst | 10 -- > 1 file changed, 8 insertions(+), 2 deletions(-) > > diff --git a/doc/guides/rel_notes/release_19_05.rst > b

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/tap: fix multi process request

On 2/26/2019 10:13 AM, Rami Rosen wrote: > Reviewed-by: Rami Rosen > > > On Tue, Feb 26, 2019 at 11:51 AM Raslan Darawsheh > wrote: > >> The structure was not initialized. >> >> Fixes: c9aa56edec8e ("net/tap: access primary process queues from >> secondary") >> Cc: sta...@dpdk.org >> >> Signed

Re: [dpdk-dev] [PATCH] examples/ethtool: fix 2 typos

On 25/02/2019 19:21, Rami Rosen wrote: [snip] Signed-off-by: Rami Rosen --- examples/ethtool/lib/rte_ethtool.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Acked-by: Remy Horton

Re: [dpdk-dev] [PATCH v2 1/5] test/cmdline_test: move to app directory

On Tue, Feb 26, 2019 at 10:14:08AM +0100, Thomas Monjalon wrote: > 19/02/2019 15:53, Bruce Richardson: > > Move app to "app" directory and enable with meson build. > > > > CC: Olivier Matz > > Signed-off-by: Bruce Richardson > > --- > > MAINTAINERS | 2 +- > >

[dpdk-dev] [PATCH v3 0/5] consolidate testing apps to app dir

The apps for testing are split between the "test" and "app" directories, with a not-very-clear distinction between the two (at least to my mind). Given how the apps are being built, the easiest path to having cmdline_test, test-acl and test-pipeline build using meson is to consolidate all these ap

[dpdk-dev] [PATCH v3 2/5] test/test-acl: move to app directory

Move to "app" directory and enable with meson build. CC: Konstantin Ananyev Signed-off-by: Bruce Richardson --- MAINTAINERS | 2 +- app/Makefile| 1 + app/meson.build | 1 + {test => app}/test-acl/Makefile | 0 {test => app}/test-acl/main.

[dpdk-dev] [PATCH v3 1/5] test/cmdline_test: move to app directory

Move app to "app" directory and enable with meson build. For consistency of naming, the subdirectory is also renamed from cmdline_test to test-cmdline. CC: Olivier Matz Signed-off-by: Bruce Richardson --- MAINTAINERS | 2 +- app/Makefile

[dpdk-dev] [PATCH v3 3/5] test/test-pipeline: move to app directory

Move to the app directory, and add to meson build. CC: Cristian Dumitrescu Signed-off-by: Bruce Richardson --- MAINTAINERS | 2 +- app/Makefile| 1 + app/meson.build | 1 + {test => app}/t

Re: [dpdk-dev] [PATCH v2 1/5] test/cmdline_test: move to app directory

On Tue, Feb 26, 2019 at 11:24:28AM +, Bruce Richardson wrote: > On Tue, Feb 26, 2019 at 10:14:08AM +0100, Thomas Monjalon wrote: > > 19/02/2019 15:53, Bruce Richardson: > > > Move app to "app" directory and enable with meson build. > > > > > > CC: Olivier Matz > > > Signed-off-by: Bruce Richa

[dpdk-dev] [PATCH v3 4/5] test/bpf: move to examples folder

The bpf folder didn't actual contain a test application, but instead basic examples of BPF code for use with testpmd. Therefore we can move it to the `examples` folder. Being different, it also needs a README with it, explaining what it is and how to use it. References to the code from the testpmd

[dpdk-dev] [PATCH v3 5/5] test/test: move to app folder

Since all other apps have been moved to the "app" folder, the autotest app remains alone in the test folder. Rather than having an entire top-level folder for this, we can move it back to where it all started in early versions of DPDK - the "app/" folder. This move has a couple of advantages: * Th

Re: [dpdk-dev] [PATCH v3 2/5] test/test-acl: move to app directory

> -Original Message- > From: Richardson, Bruce > Sent: Tuesday, February 26, 2019 12:19 PM > To: tho...@monjalon.net > Cc: dev@dpdk.org; Richardson, Bruce ; Ananyev, > Konstantin > Subject: [PATCH v3 2/5] test/test-acl: move to app directory > > Move to "app" directory and enable with

[dpdk-dev] [PATCH] usertools: add octeontx2 SSO and NPA PCIe devices

Add the Marvell's octeontx2's SSO and NPA PCIe devices as eventdev, mempool devices in devbind script. Signed-off-by: Jerin Jacob --- usertools/dpdk-devbind.py | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/usertools/dpdk-devbind.py b/usertools/dpdk-devbind.py index

Re: [dpdk-dev] vhost: add virtio configuration space access socket messages

On 2/26/19 9:42 AM, Ilya Maximets wrote: On 26.02.2019 11:13, Liu, Changpeng wrote: -Original Message- From: Ilya Maximets [mailto:i.maxim...@samsung.com] Sent: Tuesday, February 26, 2019 3:39 PM To: Liu, Changpeng ; dev@dpdk.org Cc: Stojaczyk, Dariusz ; maxime.coque...@redhat.com;

[dpdk-dev] [PATCH] net/nfb: new Netcope driver

From: Rastislav Cernay This patch implements new Netcope driver for NFB cards. Goal is to gradually stop using and end support for old szedata2 driver and move to NFB. Driver has dependency on netcope-common package, for now published on google drive and mentioned link in doc/guides. Rastislav C

[dpdk-dev] [PATCH] net/nfb: new netcope driver

From: Rastislav Cernay Added new net driver for Netcope nfb cards Signed-off-by: Rastislav Cernay --- MAINTAINERS | 7 + config/common_base | 4 + devtools/test-build.sh | 1 + doc/guides/nics/features/nfb.ini | 17 ++ doc/guides/nics/nfb.rst

Re: [dpdk-dev] vhost: add virtio configuration space access socket messages

On 26.02.2019 15:32, Maxime Coquelin wrote: > > > On 2/26/19 9:42 AM, Ilya Maximets wrote: >> On 26.02.2019 11:13, Liu, Changpeng wrote: >>> >>> -Original Message- From: Ilya Maximets [mailto:i.maxim...@samsung.com] Sent: Tuesday, February 26, 2019 3:39 PM To: Liu, Cha

Re: [dpdk-dev] vhost: add virtio configuration space access socket messages

On 2/26/19 2:36 PM, Ilya Maximets wrote: On 26.02.2019 15:32, Maxime Coquelin wrote: On 2/26/19 9:42 AM, Ilya Maximets wrote: On 26.02.2019 11:13, Liu, Changpeng wrote: -Original Message- From: Ilya Maximets [mailto:i.maxim...@samsung.com] Sent: Tuesday, February 26, 2019 3:39

Re: [dpdk-dev] vhost: add virtio configuration space access socket messages

On 26.02.2019 16:43, Maxime Coquelin wrote: > > > On 2/26/19 2:36 PM, Ilya Maximets wrote: >> On 26.02.2019 15:32, Maxime Coquelin wrote: >>> >>> >>> On 2/26/19 9:42 AM, Ilya Maximets wrote: On 26.02.2019 11:13, Liu, Changpeng wrote: > > >> -Original Message- >> From:

Re: [dpdk-dev] [PATCH] pdump: only remove created vdevs

> -Original Message- > From: Eads, Gage > Sent: Monday, February 25, 2019 5:14 PM > To: dev@dpdk.org > Cc: Yigit, Ferruh ; Pattan, Reshma > ; sta...@dpdk.org > Subject: [PATCH] pdump: only remove created vdevs > > This commit fixes a bug in which pdump -- particularly when used in a > u

[dpdk-dev] [PATCH] devtools/test-meson-builds: add verbose output options

When running ninja, the commands are, by default, always printed on top of each other. For those who want more detail in the output, two levels of verbose output has been added to the test-meson-builds script. When "-v" is passed, or the "TEST_MESON_BUILD_VERBOSE" flag is set in the environment, th

[dpdk-dev] [PATCH] build: add meson support for icc

When building with mason, checks if the compiler is icc. If they match, the warning_flags are changed to ensure icc compilation is successful. Disabled error 3656: "variable may be used before its value is set" in librte_telemetry, bnx2x, ixgbe and sfc as they were false positives. Signed-off-by:

Re: [dpdk-dev] [PATCH] net/nfb: new netcope driver

Hi, Cernay, > delete mode 100644 examples/skeleton/basicfwd.c It seems that this patch deletes examples/skeleton/basicfwd.c, (instead of patching it ?!), maybe by mistake. Reviewed-by: Rami Rosen Rami Rosen On Tue, Feb 26, 2019 at 3:04 PM Rastislav Cernay wrote: > From: Rastislav Cernay >

Re: [dpdk-dev] [PATCH] build: add meson support for icc

On Tue, Feb 26, 2019 at 02:18:09PM +, Andrius Sirvys wrote: > When building with mason, checks if the compiler is icc. If they match, > the warning_flags are changed to ensure icc compilation is successful. > > Disabled error 3656: "variable may be used before its value is set" > in librte_tel

Re: [dpdk-dev] [PATCH] net/nfb: new netcope driver

Hi, examples/skeleton/basicfwd.c should not be touched in any way, it is mistake. *Rastislav Černay I Software DeveloperNetcope Technologies, a.s.T: +420 530 510 680 <+420%20530%20510%20680>A: Sochorova 3232/34, Brno, 616 00, Czech Republic

Re: [dpdk-dev] [PATCH v3 0/5] consolidate testing apps to app dir

26/02/2019 13:18, Bruce Richardson: > The apps for testing are split between the "test" and "app" directories, > with a not-very-clear distinction between the two (at least to my mind). > > Given how the apps are being built, the easiest path to having > cmdline_test, test-acl and test-pipeline bu

Re: [dpdk-dev] [PATCH 1/4] vhost: restore mbuf first when freeing zmbuf

On 2/22/19 3:42 AM, Tiwei Bie wrote: The mbufs should also be restored in free_zmbufs(). Fixes: b0a985d1f340 ("vhost: add dequeue zero copy") Fixes: 3ebd930588b7 ("vhost: fix mbuf free") Cc: sta...@dpdk.org Signed-off-by: Tiwei Bie --- lib/librte_vhost/vhost.h | 16

Re: [dpdk-dev] [PATCH 2/4] vhost: fix potential use-after-free for zero copy mbuf

On 2/22/19 3:42 AM, Tiwei Bie wrote: Don't free the zero copy mbufs before they have been consumed, otherwise there could be use-after-free. Fixes: b0a985d1f340 ("vhost: add dequeue zero copy") Cc:sta...@dpdk.org Signed-off-by: Tiwei Bie --- lib/librte_vhost/vhost.h | 12

Re: [dpdk-dev] [PATCH 3/4] vhost: fix potential use-after-free for memory region

On 2/22/19 3:42 AM, Tiwei Bie wrote: Reclaim outstanding zmbufs first before freeing memory regions, otherwise there could be use-after-free. Fixes: b0a985d1f340 ("vhost: add dequeue zero copy") Cc:sta...@dpdk.org Signed-off-by: Tiwei Bie --- lib/librte_vhost/vhost.h | 6 + lib/

Re: [dpdk-dev] [PATCH 4/4] doc: improve vhost zero copy guide

On 2/22/19 3:42 AM, Tiwei Bie wrote: Highlight that vhost zero copy mbufs should be consumed as soon as possible. Signed-off-by: Tiwei Bie --- doc/guides/prog_guide/vhost_lib.rst | 3 +++ 1 file changed, 3 insertions(+) diff --git a/doc/guides/prog_guide/vhost_lib.rst b/doc/guides/prog_

Re: [dpdk-dev] [PATCH 0/4] Some fixes for vhost zero copy

On 2/22/19 3:42 AM, Tiwei Bie wrote: Tiwei Bie (4): vhost: restore mbuf first when freeing zmbuf vhost: fix potential use-after-free for zero copy mbuf vhost: fix potential use-after-free for memory region doc: improve vhost zero copy guide doc/guides/prog_guide/vhost_lib.rst |

Re: [dpdk-dev] [PATCH] pdump: only remove created vdevs

> -Original Message- > From: Pattan, Reshma > Sent: Tuesday, February 26, 2019 8:15 AM > To: Eads, Gage ; dev@dpdk.org > Cc: Yigit, Ferruh ; sta...@dpdk.org > Subject: RE: [PATCH] pdump: only remove created vdevs > > > > > -Original Message- > > From: Eads, Gage > > Sent: Mond

Re: [dpdk-dev] [PATCH 0/3] small fixes for FreeBSD builds

25/02/2019 16:23, Bruce Richardson: > Set of three one-line fixes to improve the FreeBSD builds, particularly with > -Dexamples=all set for meson builds. > > Bruce Richardson (3): > test/compress: fix missing header include > examples/ip_pipeline: disable build when no epoll > examples/vhost

Re: [dpdk-dev] [PATCH] net/nfb: new netcope driver

On Tue, 26 Feb 2019 13:57:04 +0100 Rastislav Cernay wrote: > +static void > +nfb_eth_dev_info(struct rte_eth_dev *dev, > + struct rte_eth_dev_info *dev_info) > +{ > + dev_info->if_index = 0; > + dev_info->max_mac_addrs = 1; > + dev_info->max_rx_pktlen = (uint32_t)-1; > + dev_i

[dpdk-dev] [PATCH v2] app/pdump: only remove created vdevs

This commit fixes a bug in which a unidirectional pdump could attempt to remove devices it didn't create. Fixes: 35cb223ab7be ("app/pdump: fix vdev cleanup") Cc: sta...@dpdk.org Signed-off-by: Gage Eads Acked-by: Reshma Pattan --- v2: Tweak commit message app/pdump/main.c | 17 ---

Re: [dpdk-dev] [PATCH v4] lib/metrics: add unregister api for metrics

This patch has checkpatch errors that will need to be fixed: ERROR:SPACING: space prohibited before that close parenthesis ')' #179: FILE: lib/librte_metrics/rte_metrics.c:233: + if (count < 1 ) ERROR:TRAILING_WHITESPACE: trailing whitespace #242: FILE: lib/librte_metrics/rte_metrics.c:298

[dpdk-dev] [Bug 215] IPC socket of 2 primary processes may conflict

https://bugs.dpdk.org/show_bug.cgi?id=215 Bug ID: 215 Summary: IPC socket of 2 primary processes may conflict Product: DPDK Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: normal

[dpdk-dev] [Bug 215] IPC socket of 2 primary processes may conflict

https://bugs.dpdk.org/show_bug.cgi?id=215 Anatoly Burakov (anatoly.bura...@intel.com) changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Res

Re: [dpdk-dev] [PATCH] devtools/test-meson-builds.sh: add support for FreeBSD

25/02/2019 16:40, Bruce Richardson: > readlink option "-m" is not supported on FreeBSD (checked on BSD 11), > so change to the largely-equivalent "-f" flag. > > Signed-off-by: Bruce Richardson Fixes: a55277a788df ("devtools: add test script for meson builds") Cc: sta...@dpdk.org Applied

[dpdk-dev] [PATCH] fbarray: add internal tailq for mapped areas

Currently, there are numerous reliability issues with fbarray, such as: - There is no way to prevent attaching to overlapping memory areas - There is no way to prevent double-detach - Failed destroy leaves fbarray in an invalid state (fbarray itself is valid, but its backing memory area is alre

Re: [dpdk-dev] [PATCH] build: set RTE_ARCH_64 based on pointer size

26/09/2018 12:18, Luca Boccassi: > On Wed, 2018-09-26 at 10:15 +0100, Bruce Richardson wrote: > > Rather than relying on the target machine architecture, use the > > size of a pointer from the compiler to determine if we are 64-bits > > or not. This allows correct behaviour when you pass -m32 as a

Re: [dpdk-dev] [PATCH] build: add meson support for icc

26/02/2019 15:18, Andrius Sirvys: > When building with mason, checks if the compiler is icc. If they match, > the warning_flags are changed to ensure icc compilation is successful. > > Disabled error 3656: "variable may be used before its value is set" > in librte_telemetry, bnx2x, ixgbe and sfc a

[dpdk-dev] [PATCH v8 1/6] build: bump minimum Meson version to 0.47.1

From: Luca Boccassi Meson 0.47.1 fixed a bug that is difficult to work around, which causes the linker flag of dependencies to be repeated dozens of times, which causes issues especially when using the built-in dependency() API. Bump the minimum version and remove obsolete version checks. Signed

[dpdk-dev] [PATCH v8 4/6] build: use dependency() for libbsd instead of manual append to ldflags

From: Luca Boccassi Move libbsd inclusion to librte_eal, so that all other libraries and PMDs will inherit it. Signed-off-by: Luca Boccassi Acked-by: Bruce Richardson --- v3: only add dependency to librte_eal and let it propagate from there v4: add acked-by config/meson.build | 10 ++

[dpdk-dev] [PATCH v8 2/6] build: use dependency() instead of find_library()

From: Luca Boccassi Whenever possible (if the library ships a pkg-config file) use meson's dependency() function to look for it, as it will automatically add it to the Requires.private list if needed, to allow for static builds to succeed for reverse dependencies of DPDK. Otherwise the recursive

[dpdk-dev] [PATCH v8 3/6] build: reorder libraries and build eal before cmdline

From: Luca Boccassi Most libraries and PMDs depend on eal, and eal depends only on kvargs, so reorder the list in Meson to reflect this and take advantage of this dependency chain. Signed-off-by: Luca Boccassi Acked-by: Bruce Richardson --- v3: added this patch to let the next just update libr

[dpdk-dev] [PATCH v8 5/6] build: use integers for numerical options

From: Luca Boccassi Now that the minimum Meson version has been bumped past 0.45 we can use integer as an option type directly. Signed-off-by: Luca Boccassi Acked-by: Bruce Richardson --- v6: added following Bruce's suggestion v7: add acked-by meson_options.txt | 4 ++-- 1 file changed, 2 in

[dpdk-dev] [PATCH v8 6/6] build: use dependency for pcap and fallback to find_library

From: Luca Boccassi pcap has historically shipped a custom pcap-config binary tool which does the job of pkg-config. It was never compatible with cross compilation. Meson uses it when using dependency(), which then means cross compilation fails. Set pcap-config to empty in the meson cross compila

Re: [dpdk-dev] [PATCH v8 6/6] build: use dependency for pcap and fallback to find_library

On Tue, 2019-02-26 at 17:46 +, luca.bocca...@gmail.com wrote: > From: Luca Boccassi > > pcap has historically shipped a custom pcap-config binary tool which > does the job of pkg-config. It was never compatible with cross > compilation. > Meson uses it when using dependency(), which then mean

[dpdk-dev] locking around rx_intr_enable/disable?

I noticed an anomaly in how receive interrupt control is done. In l3fwd-power there is a per-port lock around calls to enable interrupts but no locking around the call to disable interrupts. This looks broken since intr_disable requires multiple operations on some hardware. There are three bette

Re: [dpdk-dev] [v3, PATCH 1/2] build: add option to override max ethports

07/02/2019 16:53, Chas Williams: > Allow users and packagers to override the default RTE_MAX_ETHPORTS. > This adds a new meson option, max_ethports which defaults to the > current value. > > Signed-off-by: Chas Williams <3ch...@gmail.com> > Acked-by: Bruce Richardson > --- > --- a/meson_options.t

Re: [dpdk-dev] [v3,PATCH 2/2] build: fix option ordering

07/02/2019 17:35, Bruce Richardson: > On Thu, Feb 07, 2019 at 10:53:18AM -0500, Chas Williams wrote: > > Sort the options alphabetically and make a note of the preferred > > order at the top of the file. > > > > Signed-off-by: Chas Williams <3ch...@gmail.com> > Acked-by: Bruce Richardson Series

[dpdk-dev] [PATCH 0/5] no longer use RTE_LOGTYPE_PMD

Almost all usages of RTE_LOGTYPE_PMD have been replaced by per driver log types in current version. This patch series fixes the few remaining stragglers to use local logging. Stephen Hemminger (5): eal: drop unused RTE_PROC_PRIMARY_OR macros crypto/virtio: use local log type eventdev: use sa

[dpdk-dev] [PATCH 2/5] crypto/virtio: use local log type

The virtio crypto driver was using PMD log type and it should be using the local log type. Fixes: 25500d4b8076 ("crypto/virtio: support device init") Signed-off-by: Stephen Hemminger --- drivers/crypto/virtio/virtio_logs.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/dr

[dpdk-dev] [PATCH 1/5] eal: drop unused RTE_PROC_PRIMARY_OR macros

No usage in current DPDK code base. Signed-off-by: Stephen Hemminger --- lib/librte_eal/common/include/rte_dev.h | 15 --- 1 file changed, 15 deletions(-) diff --git a/lib/librte_eal/common/include/rte_dev.h b/lib/librte_eal/common/include/rte_dev.h index a9724dc9181c..5e16a4f86b70

[dpdk-dev] [PATCH 5/5] sfc: don't use RTE_LOGTYPE_PMD

The sfc driver was still using RTE_LOGTYPE_PMD which was superseded by local logging. Signed-off-by: Stephen Hemminger --- drivers/net/sfc/sfc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/sfc/sfc.c b/drivers/net/sfc/sfc.c index 898603884fa0..2cd7126015fd

[dpdk-dev] [PATCH 4/5] eal: remove RTE_PMD_DEBUG_TRACE

The RTE_PMD_DEBUG_TRACE was only enabled for EVENTDEV_DEBUG and that configuration is now handled by RTE_EDEV_LOG macros. Signed-off-by: Stephen Hemminger --- lib/librte_eal/common/include/rte_dev.h | 41 ++--- 1 file changed, 2 insertions(+), 39 deletions(-) diff --git a/li

[dpdk-dev] [PATCH 3/5] eventdev: use same log macro for all unsupported calls

The driver already hase RTE_EDEV_XXX log macros so use them in two more places. Signed-off-by: Stephen Hemminger --- lib/librte_eventdev/rte_eventdev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/librte_eventdev/rte_eventdev.c b/lib/librte_eventdev/rte_eventdev.c

[dpdk-dev] [PATCH v4 0/3] Replace compilation time options with log level

Currently, in test code, for printing extra information, compilation time options are used. This approach does not compile the code always. Macro needs to be set for the code to compile. This patchset replaces compilation time option with log level based approach, thus enabling compilation of code

[dpdk-dev] [PATCH v4 2/3] test/efd: enable unit test compilation always

This patch enables compilation of print_key_info() always using log-level based approach instead of a macro. Need to set efd log type to debug to print debug information, using the following eal parameter: --log-level=test.efd:debug Suggested-by: Thomas Monjalon Signed-off-by: Dharmik Thakkar Re

[dpdk-dev] [PATCH v4 3/3] test/timer: enable unit test compilation always

This patch replaces macro with log-level based approach to print debug information. Need to set timer log type to debug using the following eal parameter: --log-level=test.timer:debug Suggested-by: Thomas Monjalon Signed-off-by: Dharmik Thakkar Reviewed-by: Honnappa Nagarahalli Reviewed-by: Ga

[dpdk-dev] [PATCH v4 1/3] test/hash: replace macro with log-level approach

Need to set hash log type to debug to print debug information, using following eal parameter: --log-level=test.hash:debug Suggested-by: Thomas Monjalon Signed-off-by: Dharmik Thakkar Reviewed-by: Honnappa Nagarahalli Reviewed-by: Gavin Hu Reviewed-by: Phil Yang Reviewed-by: Ferruh Yigit ---

Re: [dpdk-dev] [PATCH v3 0/3] Replace compilation time options with log level

> On Feb 20, 2019, at 5:08 PM, Stephen Hemminger > wrote: > > On Wed, 20 Feb 2019 17:00:20 -0600 > Dharmik Thakkar wrote: > >> Currently, in test code, for printing extra information, >> compilation time options are used. This approach does not compile the >> code always. Macro needs to be

Re: [dpdk-dev] vhost: add virtio configuration space access socket messages

> -Original Message- > From: Maxime Coquelin [mailto:maxime.coque...@redhat.com] > Sent: Tuesday, February 26, 2019 8:32 PM > To: Ilya Maximets ; Liu, Changpeng > ; dev@dpdk.org > Cc: Stojaczyk, Dariusz ; Bie, Tiwei > ; Wang, Zhihong ; Jason Wang > > Subject: Re: vhost: add virtio config

Re: [dpdk-dev] vhost: add virtio configuration space access socket messages

On Tue, Feb 26, 2019 at 01:32:24PM +0100, Maxime Coquelin wrote: > On 2/26/19 9:42 AM, Ilya Maximets wrote: > > On 26.02.2019 11:13, Liu, Changpeng wrote: > > > > > > > > > > -Original Message- > > > > From: Ilya Maximets [mailto:i.maxim...@samsung.com] > > > > Sent: Tuesday, February 26,

Re: [dpdk-dev] [PATCH 0/4] Some fixes for vhost zero copy

On Tue, Feb 26, 2019 at 03:46:41PM +0100, Maxime Coquelin wrote: > On 2/22/19 3:42 AM, Tiwei Bie wrote: > > Tiwei Bie (4): > >vhost: restore mbuf first when freeing zmbuf > >vhost: fix potential use-after-free for zero copy mbuf > >vhost: fix potential use-after-free for memory region >

Re: [dpdk-dev] [PATCH v2] net/mlx4: fix default flow rule create

> On Feb 24, 2019, at 1:41 AM, Dekel Peled wrote: > > Original patch changed logic of function mlx4_flow_merge_eth(). > The setting of flow->promisc was wrongly removed. > This patch adds the removed setting of flow->promisc, to restore > the required behavior. > > Fixes: c0d239263156 ("net/ml

[dpdk-dev] [Bug 216] rte_eth_rx_burst nb_pkts issue

https://bugs.dpdk.org/show_bug.cgi?id=216 Bug ID: 216 Summary: rte_eth_rx_burst nb_pkts issue Product: DPDK Version: 18.11 Hardware: All OS: Linux Status: CONFIRMED Severity: major Priority:

Re: [dpdk-dev] [PATCH] vhost: fix interrupt suppression for the split ring

> -Original Message- > From: Bie, Tiwei > Sent: Monday, February 25, 2019 3:07 PM > To: Hu, Jiayu > Cc: dev@dpdk.org; maxime.coque...@redhat.com; sta...@dpdk.org > Subject: Re: [PATCH] vhost: fix interrupt suppression for the split ring > > On Fri, Feb 22, 2019 at 04:13:50PM +0800, Jiay

[dpdk-dev] [PATCH v3] drivers: fix to replace strcat with strlcat

Strcat does not check the destination length and there might be chances of string overflow so instead of strcat, strlcat is used. Fixes: 540a211084 ("bnx2x: driver core") Fixes: e163c18a15 ("net/i40e: update ptype and pctype info") Fixes: ef28aa96e5 ("net/nfp: support multiprocess") Fixes: 6f4eec2