[dpdk-dev] [PATCH v2] app/testbbdev: fix sprintf with snprintf or strlcpy

sprintf function is not secure as it doesn't check the length of string. More secure function snprintf and strlcpy is used. Fixes: f714a18885 ("app/testbbdev: add test application for bbdev") Cc: sta...@dpdk.org Signed-off-by: Pallantla Poornima --- v2: Used strlcpy instead of snprintf as sugges

Re: [dpdk-dev] [PATCH 2/2] net/ixgbe: add support of loopback for X540/X550

Hi all, Sorry for the delay. See my reply inline. On 12/02/2019 07:37, Zhao1, Wei wrote: > HI, Meunier && qi > > Is it possible to add these two function of ixgbe_setup_phy_autoneg_x540 and > ixgbe_setup_phy_autoneg_x550 in a file out of base folder? We need to avoid > change code in that, is t

Re: [dpdk-dev] [PATCH v2] test/pmd_perf: fix the way to drain the port

Hi, Sorry for the delay. Inline reply. On 07/02/2019 13:28, Ferruh Yigit wrote: > On 2/3/2019 7:42 PM, Julien Meunier wrote: >> If the port has received less than ``pkt_per_port`` packets (for >> example, the port has missed some packets), the test is in an infinite >> loop. >> >> Instead of expe

[dpdk-dev] [PATCH] net/bonding: fix reset active slave

test_alb_reply_from_client test fails due to incorrect active slave array's index. This was due to invalid active slave count. Count of internals->active_slave is not updated even when active slave is deactivated. Hence active slave count always keeps incrementing beyond the actual active slaves.

Re: [dpdk-dev] [PATCH 0/6] introduce DMA memory mapping for external memory

On 17-Feb-19 6:18 AM, Shahaf Shuler wrote: Thursday, February 14, 2019 6:20 PM, Burakov, Anatoly: Subject: Re: [dpdk-dev] [PATCH 0/6] introduce DMA memory mapping for external memory On 14-Feb-19 1:28 PM, Shahaf Shuler wrote: Thursday, February 14, 2019 12:19 PM, Burakov, Anatoly: Subject: Re

Re: [dpdk-dev] [PATCH] net/avf: enable admin queue interrupt

> -Original Message- > From: Zhao1, Wei > Sent: Wednesday, February 13, 2019 4:54 PM > To: dev@dpdk.org > Cc: Wu, Jingjing ; Zhang, Qi Z ; > Zhao1, Wei > Subject: [PATCH] net/avf: enable admin queue interrupt > Change title to "enable CLEARPBA bit" > There is need to enble CLEARPBA bi

Re: [dpdk-dev] [PATCH v2] test/pmd_perf: fix the way to drain the port

On 2/18/2019 11:25 AM, Meunier, Julien (Nokia - FR/Paris-Saclay) wrote: > Hi, > > Sorry for the delay. Inline reply. > > On 07/02/2019 13:28, Ferruh Yigit wrote: >> On 2/3/2019 7:42 PM, Julien Meunier wrote: >>> If the port has received less than ``pkt_per_port`` packets (for >>> example, the por

[dpdk-dev] [PATCH] doc: deprecate KNI ethtool support

Remove KNI ethtool support. Signed-off-by: Ferruh Yigit --- RFC Patch: https://patches.dpdk.org/patch/49025/ --- doc/guides/rel_notes/deprecation.rst | 8 1 file changed, 8 insertions(+) diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst index 1b4

Re: [dpdk-dev] [RFC] kni: remove ethtool support

On 2/6/2019 1:12 PM, Igor Ryzhov wrote: > Hi Ferruh, > > What's the plan with this patch? Hi Igor, I just sent a deprecation notice for this: https://patches.dpdk.org/patch/50347/ If the deprecation notice approved, requires 3 acks, note will go into 19.05 And later this patch can go in 19.08

Re: [dpdk-dev] [RFC 00/14] prefix network structures

On 2/13/2019 11:48 AM, Yigit, Ferruh wrote: > On 12/27/2018 9:35 AM, Olivier Matz wrote: >> Hi, >> >> On Fri, Dec 21, 2018 at 03:14:29PM +, Ferruh Yigit wrote: >>> On 12/21/2018 2:38 PM, Wiles, Keith wrote: > On Dec 20, 2018, at 5:48 PM, Stephen Hemminger > wrote: >

Re: [dpdk-dev] [PATCH v2] net/ice: enable VLAN filter offloads support

> -Original Message- > From: Zhao1, Wei > Sent: Wednesday, February 13, 2019 11:50 AM > To: dev@dpdk.org > Cc: sta...@dpdk.org; Zhang, Qi Z ; Zhao1, Wei > > Subject: [PATCH v2] net/ice: enable VLAN filter offloads support I think this is a fix, since vlan filter is already be promised

Re: [dpdk-dev] [PATCH v3] net/ice: faster bit check

> -Original Message- > From: Stillwell Jr, Paul M > Sent: Saturday, February 16, 2019 2:13 AM > To: Zhang, Qi Z > Cc: dev@dpdk.org; Brandeburg, Jesse ; Stillwell > Jr, > Paul M > Subject: [PATCH v3] net/ice: faster bit check > > From: Jesse Brandeburg > > Implement a slightly faste

Re: [dpdk-dev] [RFC] kni: remove ethtool support

Hi Ferruh, Thanks. Should I be a maintainer to ack the patch? Best regards, Igor On Mon, Feb 18, 2019 at 3:33 PM Ferruh Yigit wrote: > On 2/6/2019 1:12 PM, Igor Ryzhov wrote: > > Hi Ferruh, > > > > What's the plan with this patch? > > Hi Igor, > > I just sent a deprecation notice for this: > h

Re: [dpdk-dev] [RFC] kni: remove ethtool support

On 2/18/2019 1:07 PM, Igor Ryzhov wrote: > Hi Ferruh, > > Thanks. Should I be a maintainer to ack the patch? No, everyone can (n)ack a patch, though maintainers have more weight. > > Best regards, > Igor > > On Mon, Feb 18, 2019 at 3:33 PM Ferruh Yigit > wrote:

Re: [dpdk-dev] [PATCH] doc: deprecate KNI ethtool support

On Mon, Feb 18, 2019 at 12:30:02PM +, Ferruh Yigit wrote: > Remove KNI ethtool support. > > Signed-off-by: Ferruh Yigit > --- > RFC Patch: https://patches.dpdk.org/patch/49025/ > --- > doc/guides/rel_notes/deprecation.rst | 8 > 1 file changed, 8 insertions(+) > > diff --git a/doc/

Re: [dpdk-dev] [PATCH] doc: deprecate KNI ethtool support

Acked-by: Igor Ryzhov On Mon, Feb 18, 2019 at 3:30 PM Ferruh Yigit wrote: > Remove KNI ethtool support. > > Signed-off-by: Ferruh Yigit > --- > RFC Patch: https://patches.dpdk.org/patch/49025/ > --- > doc/guides/rel_notes/deprecation.rst | 8 > 1 file changed, 8 insertions(+) > > dif

Re: [dpdk-dev] [PATCH] doc: deprecate KNI ethtool support

On Mon, 2019-02-18 at 12:30 +, Ferruh Yigit wrote: > Remove KNI ethtool support. > > Signed-off-by: Ferruh Yigit > Acked-by: Jerin Jacob > --- > RFC Patch: https://patches.dpdk.org/patch/49025/ > --- > doc/guides/rel_notes/deprecation.rst | 8 > 1 file changed, 8 insertions(+) >

[dpdk-dev] [PATCH v2 1/2] test/distributor: flush with worker shutdown test fails

On restarting worker 0 after shutdown, packets handled by worker 0 must be incremented only when a packet is received by it. Signed-off-by: Harman Kalra --- test/test/test_distributor.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/test/test/test_distributor.c b/test/test

[dpdk-dev] [PATCH v2 2/2] distributor: imposing additional check on no of workers

no of workers should never exceed RTE_MAX_LCORE Signed-off-by: Harman Kalra --- lib/librte_distributor/rte_distributor.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/lib/librte_distributor/rte_distributor.c b/lib/librte_distributor/rte_distributor.c index d505

Re: [dpdk-dev] [PATCH 2/2] net/bonding: avoid the next active slave going out of bound

On 2/11/2019 10:25 AM, Parthasarathy, JananeeX M wrote: > Hi > >> -Original Message- >> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Chas Williams >> Sent: Saturday, February 09, 2019 6:47 PM >> To: Hyong Youb Kim ; Yigit, Ferruh >> ; Doherty, Declan ; Chas >> Williams >> Cc: dev@

Re: [dpdk-dev] [dpdk-stable] [PATCH] app/testpmd: fix crash when doing port info of vdev

On 2/16/2019 1:36 AM, Stephen Hemminger wrote: > From: Stephen Hemminger > > Noticed a SEGV in testpmd doing: > > show port info 1 > on Hyper-V with failsafe/tap PMD. > > A vdev may not have an associated device (i.e NULL) and therefore > testpmd should skip devargs in that case. > > Fixes: cf

Re: [dpdk-dev] [dpdk-stable] [PATCH v3] mem: Fix anonymous mapping on Power9.

Hi, Long time no talk about the IBM Power support status. 16/11/2018 18:35, David Wilder: > --- a/doc/guides/rel_notes/release_18_11.rst > +++ b/doc/guides/rel_notes/release_18_11.rst > +* IBM Power8 is not supported by this release of DPDK. IBM Power9 is > supported. The config file is defconf

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] net/bonding: fix slave tx burst for mode 4

On 2/14/2019 7:09 PM, Chas Williams wrote: > From: Chas Williams > > The tx burst routine always needs to check for pending LACPDUs > and send them if available. Do this first to prioritize the > control traffic. We can still early exit, before calculating > the distribution slaves, if there isn

Re: [dpdk-dev] [PATCH] net/bonding: fix reset active slave

On 2/18/2019 11:59 AM, Hari Kumar Vemula wrote: test_alb_reply_from_client test fails due to incorrect active slave array's index. This was due to invalid active slave count. Count of internals->active_slave is not updated even when active slave is deactivated. Hence active slave count always

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/bonding: fix invalid link status

On 2/14/2019 7:11 PM, Chas Williams wrote: > From: Chas Williams > > Copying the link properties of the first slave added may copy an > invalid link status. The speed and duplex of the slave may not > be known at this time. Delay setting the properties until the > first slave reports as link up.

[dpdk-dev] [PATCH 2/4] ipsec-secgw: add test scripts for aes ctr

This patch adds the functional test scripts to ipsec-secgw sample application for both transport and tunnel working mode. Updated a bit on common_defs to use "mktemp" instead of "tempfile" as Fedora does not like the command. Signed-off-by: Fan Zhang --- examples/ipsec-secgw/test/common_defs.sh

[dpdk-dev] [PATCH 3/4] ipsec: add 3DES-CBC algorithm support

This patch adds triple-des CBC mode cipher algorithm to ipsec library. Signed-off-by: Fan Zhang --- lib/librte_ipsec/sa.c | 10 ++ lib/librte_ipsec/sa.h | 6 ++ 2 files changed, 16 insertions(+) diff --git a/lib/librte_ipsec/sa.c b/lib/librte_ipsec/sa.c index e34dd320a..5c59c4b67 1

[dpdk-dev] [PATCH 1/4] ipsec: add AES-CTR algorithm support

This patch adds AES-CTR cipher algorithm support to ipsec library. Signed-off-by: Fan Zhang --- lib/librte_ipsec/crypto.h | 17 ++ lib/librte_ipsec/sa.c | 133 ++ lib/librte_ipsec/sa.h | 18 +++ 3 files changed, 147 insertions(+), 21

[dpdk-dev] [PATCH 0/4] ipsec: add AES-CTR and 3DES-CBC support

This patchset adds the AES-CTR and 3DES-CBC cipher algorithms support to ipsec library. The test scripts for ipsec-secgw sample application are added too. Fan Zhang (4): ipsec: add AES-CTR algorithm support ipsec-secgw: add test scripts for aes ctr ipsec: add 3DES-CBC algorithm support ips

[dpdk-dev] [PATCH 4/4] ipsec-secgw: add 3des test files

This patch adds the functional test scripts to ipsec-secgw sample application for both transport and tunnel working mode. Signed-off-by: Fan Zhang --- examples/ipsec-secgw/test/run_test.sh | 10 ++- .../test/trs_3descbc_sha1_common_defs.sh | 73 ++ exam

Re: [dpdk-dev] [PATCH] net/ena: get device info statically

On 2/15/2019 8:36 AM, Michal Krawczyk wrote: > Whenever the app is calling rte_eth_dev_info_get(), it shouldn't use the > admin command. It was causing problems, if it was called from the > secondary process - the main process was crashing, and the secondary app > wasn't getting any result, as the

Re: [dpdk-dev] [PATCH] doc: fix a minor typo in testpmd guide

On 2/18/2019 1:26 AM, Zhao1, Wei wrote: > > >> -Original Message- >> From: Rami Rosen [mailto:ramir...@gmail.com] >> Sent: Saturday, February 16, 2019 7:13 PM >> To: dev@dpdk.org >> Cc: Zhao1, Wei ; sta...@dpdk.org; Rami Rosen >> >> Subject: [PATCH] doc: fix a minor typo in testpmd guid

Re: [dpdk-dev] [RFC 00/14] prefix network structures

On Mon, Feb 18, 2019 at 12:37:41PM +, Ferruh Yigit wrote: > On 2/13/2019 11:48 AM, Yigit, Ferruh wrote: > > On 12/27/2018 9:35 AM, Olivier Matz wrote: > >> Hi, > >> > >> On Fri, Dec 21, 2018 at 03:14:29PM +, Ferruh Yigit wrote: > >>> On 12/21/2018 2:38 PM, Wiles, Keith wrote: > >

Re: [dpdk-dev] [PATCH] ethdev: remove unused variable

On 2/14/2019 5:34 PM, Andrew Rybchenko wrote: > On 2/14/19 7:29 PM, Thomas Monjalon wrote: >> When removing the old attach function, the racy variable for getting >> the last port id became unused. >> >> Fixes: c9cce42876f5 ("ethdev: remove deprecated attach/detach functions") >> Cc: sta...@dpdk.or

Re: [dpdk-dev] [PATCH v2 3/3] net/af_packet: get 'framesz' from the iface's MTU

On 11/28/2018 1:12 PM, Lam, Tiago wrote: > On 27/11/2018 17:43, Ferruh Yigit wrote: >> On 11/20/2018 10:26 AM, Tiago Lam wrote: >>> Use the underlying MTU to calculate the framsize to be used for the mmap >>> RINGs. This is to make it more flexible on deployments with different >>> MTU requirements

Re: [dpdk-dev] [PATCH 1/1] net/qede: fix tx_pkt_prepare for tunnel packets

On 2/13/2019 5:53 PM, Shahed Shaikh wrote: > This patch fixes a regression introduced by > commit 49d3978d5723("net/qede: fix Tx tunnel offload support mask") > in which qede_xmit_prep_pkts() breaks the loop for successful > check of Tunneling offload flags instead of continuing, resulting > in tx_

Re: [dpdk-dev] [PATCH] doc: deprecate KNI ethtool support

Acked-by: Rami Rosen בתאריך יום ב׳, 18 בפבר׳ 2019, 14:30, מאת Ferruh Yigit < ferruh.yi...@intel.com>: > Remove KNI ethtool support. > > Signed-off-by: Ferruh Yigit > --- > RFC Patch: https://patches.dpdk.org/patch/49025/ > --- > doc/guides/rel_notes/deprecation.rst | 8 > 1 file chang

Re: [dpdk-dev] [PATCH 1/5] app/testpmd: remove unused fwd_ctx field

I believe this patch should be cc'ed/sent to sta...@dpdk.org Reviewed-by: Rami Rosen On Thu, Feb 14, 2019 at 5:43 PM David Marchand wrote: > Remove some leftover from a previous rework. > > Fixes: c4bcc342c8ee ("app/testpmd: refactor ieee1588 forwarding") > Signed-off-by: David Marchand > ---

Re: [dpdk-dev] [PATCH v3] service: fix parameter type

Reviewed-by: Rami Rosen On Fri, Feb 15, 2019 at 12:29 PM Nikhil Rao wrote: > The type of value parameter to rte_service_attr_get > should be uint64_t *, since the attributes > are of type uint64_t. > > Fixes: 4d55194d76a4 ("service: add attribute get function") > > Reviewed-by: Gage Eads > Sig

Re: [dpdk-dev] [PATCH 2/5] app/testpmd: add missing newline when showing statistics

+1 Reviewed-by: Rami Rosen On Thu, Feb 14, 2019 at 5:43 PM David Marchand wrote: > Having the standard stats and the rx burst stats on the same line gives a > really long line and is not consistent with the rest. > > Before: > RX-packets: 3542977TX-packets: 3542971TX-dropped:

[dpdk-dev] [PATCH] mbuf: move headers not fragmented check to checksum

rte_validate_tx_offload() is used in Tx prepare callbacks (RTE_LIBRTE_ETHDEV_DEBUG only) to check Tx offloads consistency. Requirement that packet headers should not be fragmented is not documented and unclear where it comes from except rte_net_intel_cksum_prepare() functions which relies on it. I

[dpdk-dev] [PATCH] app/testpmd: fix tx vlan and qinq insert enable

Tx VLAN & QinQ insert enable need not depend on Rx VLAN offload ETH_VLAN_EXTEND_OFFLOAD. Also enable DEV_TX_OFFLOAD_VLAN_INSERT for tx_qinq_set() as it takes both vlan id's. Signed-off-by: Nithin Dabilpuram --- app/test-pmd/config.c | 15 ++- 1 file changed, 2 insertions(+), 13 delet