Replace strcat with concatenation logic to avoid buffer overflow.
Fixes: a6a47ac9c2 ("cfgfile: rework load function")
Cc: sta...@dpdk.org
Signed-off-by: Chaitanya Babu Talluri
---
lib/librte_cfgfile/rte_cfgfile.c | 10 +-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/lib/
Replace strcat with concatenation logic to avoid buffer overflow.
Fixes: a6a47ac9c2 ("cfgfile: rework load function")
Cc: sta...@dpdk.org
Signed-off-by: Chaitanya Babu Talluri
---
lib/librte_cfgfile/rte_cfgfile.c | 10 +-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/lib/
On 13-Feb-19 4:13 PM, David Marchand wrote:
Spawning the ctrl threads on anything that is not part of the eal
coremask is not that polite to the rest of the system.
Rather than introduce yet another eal options for this, let's take
the startup cpu affinity as a reference and remove the eal corem
sprintf function is not secure as it doesn't check the length of string.
replaced sprintf with strlcpy.
Fixes: f74df2c57e ("test/distributor: test single and burst API")
Cc: sta...@dpdk.org
Signed-off-by: Pallantla Poornima
---
v2: Addressed review comment to replace snprintf to strlcpy.
---
t
On Thu, Feb 14, 2019 at 10:39 AM Burakov, Anatoly
wrote:
> On 13-Feb-19 4:13 PM, David Marchand wrote:
> > Spawning the ctrl threads on anything that is not part of the eal
> > coremask is not that polite to the rest of the system.
> >
> > Rather than introduce yet another eal options for this, l
The type of value parameter to rte_service_attr_get
should be uint64_t *, since the attributes
are of type uint64_t.
Fixes: 4d55194d76a4 ("service: add attribute get function")
Reviewed-by: Gage Eads
Signed-off-by: Nikhil Rao
Acked-by: Harry van Haaren
---
lib/librte_eal/common/include/rte_se
On 14-Feb-19 9:53 AM, David Marchand wrote:
On Thu, Feb 14, 2019 at 10:39 AM Burakov, Anatoly
mailto:anatoly.bura...@intel.com>> wrote:
On 13-Feb-19 4:13 PM, David Marchand wrote:
> Spawning the ctrl threads on anything that is not part of the eal
> coremask is not that polite to
On Thu, Feb 14, 2019 at 11:05 AM Burakov, Anatoly
wrote:
> On 14-Feb-19 9:53 AM, David Marchand wrote:
>
> > A bit more context then, if you want to clearly pin cpu resources for
> > the processes on your system (let's say having virtual machines and a
> > popular vswitch), I can only think of tw
On 13-Feb-19 7:24 PM, Shahaf Shuler wrote:
Wednesday, February 13, 2019 1:43 PM, Alejandro Lucero:
Subject: Re: [dpdk-dev] [PATCH 0/6] introduce DMA memory mapping for
external memory
On Wed, Feb 13, 2019 at 9:11 AM Shahaf Shuler
wrote:
This series is in continue to RFC[1].
The DPDK APIs ex
On Wed, Feb 13, 2019 at 07:11:35PM +, Shahaf Shuler wrote:
> Wednesday, February 13, 2019 1:44 PM, Gaëtan Rivet:
> > Subject: Re: [PATCH 5/6] net/mlx5: support PCI device DMA map and unmap
> >
> > On Wed, Feb 13, 2019 at 12:35:04PM +0100, Gaëtan Rivet wrote:
> > > On Wed, Feb 13, 2019 at 11:10
On Wed, Feb 13, 2019 at 5:14 PM David Marchand
wrote:
> Spawning the ctrl threads on anything that is not part of the eal
> coremask is not that polite to the rest of the system.
>
> Rather than introduce yet another eal options for this, let's take
> the startup cpu affinity as a reference and r
Hi all,
Are there plans to add support for modifying rules using the rte_flow API ?
The first problem with destroy+create is atomicity. During the process
some packets will get lost.
Then the second problem is performance. We measured Mellanox CX5 (mlx5
driver) to be able to "update" at best
On Wed, Feb 13, 2019 at 7:24 PM Shahaf Shuler wrote:
> Wednesday, February 13, 2019 1:43 PM, Alejandro Lucero:
> > Subject: Re: [dpdk-dev] [PATCH 0/6] introduce DMA memory mapping for
> > external memory
> >
> > On Wed, Feb 13, 2019 at 9:11 AM Shahaf Shuler
> > wrote:
> >
> > > This series is in
On Thu, Feb 14, 2019 at 12:22 PM Alejandro Lucero <
alejandro.luc...@netronome.com> wrote:
>
>
> On Wed, Feb 13, 2019 at 7:24 PM Shahaf Shuler
> wrote:
>
>> Wednesday, February 13, 2019 1:43 PM, Alejandro Lucero:
>> > Subject: Re: [dpdk-dev] [PATCH 0/6] introduce DMA memory mapping for
>> > exter
These are the features that we plan to submit for the 19.05 release:
Intel® QuickAssist Technology (Intel® QAT) Asymmetric Crypto: The initial
implementation will provide support for modexp and modinv. Additional
algorithms will be supported in future releases.
Intel® QAT AES-XTS Support
Int
sprintf function is not secure as it doesn't check the length of string.
More secure function snprintf is used.
Fixes: 473d1bebce ("hash: allow to store data in hash table")
Cc: sta...@dpdk.org
Signed-off-by: Pallantla Poornima
---
v2: Addressed review comment to correct the format specifier of
Hi Tom,
Thursday, February 14, 2019 1:31 PM, Tom Barbette:
> Subject: rte_flow update support?
>
> Hi all,
>
> Are there plans to add support for modifying rules using the rte_flow API ?
>
> The first problem with destroy+create is atomicity. During the process some
> packets will get lost.
>
pthread_getaffinity_np returns a >0 value when failing.
This is mainly for the sake of correctness.
The only case where it could fail is when passing an incorrect cpuset
size wrt to the kernel.
Fixes: 2eba8d21f3c9 ("eal: restrict cores auto detection")
Signed-off-by: David Marchand
---
lib/libr
Thursday, February 14, 2019 12:19 PM, Burakov, Anatoly:
> Subject: Re: [dpdk-dev] [PATCH 0/6] introduce DMA memory mapping for
> external memory
>
> On 13-Feb-19 7:24 PM, Shahaf Shuler wrote:
> > Wednesday, February 13, 2019 1:43 PM, Alejandro Lucero:
> >> Subject: Re: [dpdk-dev] [PATCH 0/6] intro
pthread_setaffinity_np returns a >0 value on error.
We could end up letting the ctrl threads on the current process cpu
affinity.
Fixes: d651ee4919cd ("eal: set affinity for control threads")
Signed-off-by: David Marchand
---
lib/librte_eal/common/eal_common_thread.c | 2 +-
1 file changed, 1 in
Spawning the ctrl threads on anything that is not part of the eal
coremask is not that polite to the rest of the system, especially
when you took good care to pin your processes on cpu resources with
tools like taskset (linux) / cpuset (freebsd).
Rather than introduce yet another eal options to co
Variable pfi_str is removed since it is unused.
Fixes: 450f079131 ("power: add traffic pattern aware power control")
Cc: sta...@dpdk.org
Signed-off-by: Pallantla Poornima
---
v2: Removed unused variable as suggested.
---
lib/librte_power/rte_power_empty_poll.c | 3 ---
1 file changed, 3 deletio
Thursday, February 14, 2019 2:22 PM, Alejandro Lucero:
>On Wed, Feb 13, 2019 at 7:24 PM Shahaf Shuler wrote:
>Wednesday, February 13, 2019 1:43 PM, Alejandro Lucero:
>> Subject: Re: [dpdk-dev] [PATCH 0/6] introduce DMA memory mapping for
>> external memory
>>
>> On Wed, Feb 13, 2019 at 9:11 AM Sha
On Thu, Feb 14, 2019 at 09:30:31AM +, Chaitanya Babu Talluri wrote:
> Replace strcat with concatenation logic to avoid buffer overflow.
>
> Fixes: a6a47ac9c2 ("cfgfile: rework load function")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Chaitanya Babu Talluri
> ---
> lib/librte_cfgfile/rte_cfgf
On Wed, Feb 13, 2019 at 07:07:11PM +, Shahaf Shuler wrote:
> Wednesday, February 13, 2019 1:17 PM, Gaëtan Rivet:
> > Subject: Re: [PATCH 3/6] bus: introduce DMA memory mapping for external
> > memory
> >
> > On Wed, Feb 13, 2019 at 11:10:23AM +0200, Shahaf Shuler wrote:
> > > The DPDK APIs exp
On Wed, Feb 13, 2019 at 07:16:24PM +, Van Haaren, Harry wrote:
> > -Original Message-
> > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Michael Santana
> > Sent: Wednesday, February 13, 2019 7:08 PM
> > To: dev@dpdk.org
> > Cc: Thomas Monjalon
> > Subject: [dpdk-dev] [PATCH 1/2]
On 2/7/19 5:01 PM, Michael Santana wrote:
ping
This series introduces the ability for any github mirrors of the DPDK
project, including developer mirrors, to kick off builds under the
travis CI infrastructure. For now, this just means compilation - no
other kinds of automated run exists yet. In
Hi,
I would suggest to consider to add:
Fixes: 450f0791312c ("power: add traffic pattern aware power control")
Reviewed-By: Rami Rosen
Here is a little series that makes it possible to display and clear
testpmd fwd engines while they run without having to stop them.
This is mostly handy when running stress tests and you look for packets
drops without having to stop/start testpmd forwarding.
Example:
testpmd> show fwd stats all
Remove some leftover from a previous rework.
Fixes: c4bcc342c8ee ("app/testpmd: refactor ieee1588 forwarding")
Signed-off-by: David Marchand
---
app/test-pmd/testpmd.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/app/test-pmd/testpmd.h b/app/test-pmd/testpmd.h
index fa48878..85b791b 100644
Having the standard stats and the rx burst stats on the same line gives a
really long line and is not consistent with the rest.
Before:
RX-packets: 3542977TX-packets: 3542971TX-dropped: 6
RX-bursts : 499440 [24% of 2 pkts + 15% of 1 pkts + 61% of others]
TX-burst
Caught by code review while investigating the stats display code.
Switching all port and fwd engine statistics to uint64_t makes it
possible to drop all casts.
Signed-off-by: David Marchand
---
app/test-pmd/testpmd.c | 62 ++
app/test-pmd/testpmd.h
Add a new "show/clear fwd stats all" command to display fwd and port
statistics on the fly.
To be able to do so, rte_port can't be used to maintain any statistics.
Moved the stats dump parts from stop_packet_forwarding() and merge with
fwd_port_stats_display() into fwd_stats_display().
fwd engine
pmd can report transmit errors but those stats are not accounted here.
Signed-off-by: David Marchand
---
app/test-pmd/testpmd.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
index 984155a..3acd97b 100644
--- a/app/test-pmd/testpmd.c
+++ b/app
On 14-Feb-19 1:28 PM, Shahaf Shuler wrote:
Thursday, February 14, 2019 12:19 PM, Burakov, Anatoly:
Subject: Re: [dpdk-dev] [PATCH 0/6] introduce DMA memory mapping for
external memory
On 13-Feb-19 7:24 PM, Shahaf Shuler wrote:
Wednesday, February 13, 2019 1:43 PM, Alejandro Lucero:
Subject: R
On 14-Feb-19 1:30 PM, David Marchand wrote:
pthread_setaffinity_np returns a >0 value on error.
We could end up letting the ctrl threads on the current process cpu
affinity.
Fixes: d651ee4919cd ("eal: set affinity for control threads")
Signed-off-by: David Marchand
---
lib/librte_eal/common/e
When removing the old attach function, the racy variable for getting
the last port id became unused.
Fixes: c9cce42876f5 ("ethdev: remove deprecated attach/detach functions")
Cc: sta...@dpdk.org
Signed-off-by: Thomas Monjalon
---
lib/librte_ethdev/rte_ethdev.c | 3 ---
1 file changed, 3 deletio
On Thu, Feb 14, 2019 at 04:42:50PM +0100, David Marchand wrote:
> pmd can report transmit errors but those stats are not accounted here.
>
> Signed-off-by: David Marchand
> ---
> app/test-pmd/testpmd.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/app/test-pmd/testpmd.c b/app/test-pm
On 14-Feb-19 1:41 PM, Shahaf Shuler wrote:
Thursday, February 14, 2019 2:22 PM, Alejandro Lucero:
>Any current NIC or device will work with virtual addresses if IOMMU is
in place, not matter if the device is IOMMU-aware or not.
Not sure what you mean here. For example Intel devices works w/
On 14-Feb-19 1:27 PM, David Marchand wrote:
pthread_getaffinity_np returns a >0 value when failing.
This is mainly for the sake of correctness.
The only case where it could fail is when passing an incorrect cpuset
size wrt to the kernel.
Fixes: 2eba8d21f3c9 ("eal: restrict cores auto detection"
On 2/14/19 7:29 PM, Thomas Monjalon wrote:
When removing the old attach function, the racy variable for getting
the last port id became unused.
Fixes: c9cce42876f5 ("ethdev: remove deprecated attach/detach functions")
Cc: sta...@dpdk.org
Signed-off-by: Thomas Monjalon
Reviewed-by: Andrew Rybc
On Thu, Feb 14, 2019 at 5:30 PM Bruce Richardson
wrote:
> On Thu, Feb 14, 2019 at 04:42:50PM +0100, David Marchand wrote:
> > pmd can report transmit errors but those stats are not accounted here.
> >
> > Signed-off-by: David Marchand
> > ---
> > app/test-pmd/testpmd.c | 1 +
> > 1 file changed
On Thu, Feb 14, 2019 at 5:44 PM Burakov, Anatoly
wrote:
> On 14-Feb-19 1:27 PM, David Marchand wrote:
> > pthread_getaffinity_np returns a >0 value when failing.
> >
> > This is mainly for the sake of correctness.
> > The only case where it could fail is when passing an incorrect cpuset
> > size
On Thu, Feb 14, 2019 at 5:12 PM Burakov, Anatoly
wrote:
> On 14-Feb-19 1:30 PM, David Marchand wrote:
> > pthread_setaffinity_np returns a >0 value on error.
> > We could end up letting the ctrl threads on the current process cpu
> > affinity.
> >
> > Fixes: d651ee4919cd ("eal: set affinity for c
Commit cdc242f260e7 says:
For Linux kernel 4.0 and newer, the ability to obtain
physical page frame numbers for unprivileged users from
/proc/self/pagemap was removed. Instead, when an IOMMU
is present, simply choose our own DMA addresses instead.
In this case the user still sees e
Hi,
I'm afraid there is a problem with the strlcpy change in the nfp code.
Using the rte_strlcpy makes the fw upload failing.
I will send a patch asap using memcpy instead.
On Mon, Jan 7, 2019 at 8:57 PM Yongseok Koh wrote:
> Hi all,
>
> Here is a list of patches targeted for LTS release 17.
Minutes 14 February 2019
Agenda:
* Release Dates
* Subtrees
* GSoC
* OvS
* Meson-Ninja
* Opens
Participants:
* Arm
* Debian
* Intel
* Mellanox
* RedHat
Release Dates
-
* v19.05 dates:
* Proposal Deadline: Friday, 1 March
* RC1: Friday, 29 March
* Rel
On Thu, Feb 14, 2019 at 6:39 PM David Marchand
wrote:
> On Thu, Feb 14, 2019 at 5:30 PM Bruce Richardson <
> bruce.richard...@intel.com> wrote:
>
>> On Thu, Feb 14, 2019 at 04:42:50PM +0100, David Marchand wrote:
>> > pmd can report transmit errors but those stats are not accounted here.
>> >
>>
From: Chas Williams
The tx burst routine always needs to check for pending LACPDUs
and send them if available. Do this first to prioritize the
control traffic. We can still early exit, before calculating
the distribution slaves, if there isn't any data packets.
Fixes: 09150784a776 ("net/bonding
From: Chas Williams
Copying the link properties of the first slave added may copy an
invalid link status. The speed and duplex of the slave may not
be known at this time. Delay setting the properties until the
first slave reports as link up. Note that we are still ignoring
an error from link_prop
Kevin Traynor writes:
> Commit cdc242f260e7 says:
> For Linux kernel 4.0 and newer, the ability to obtain
> physical page frame numbers for unprivileged users from
> /proc/self/pagemap was removed. Instead, when an IOMMU
> is present, simply choose our own DMA addresses instead.
>
Fix trivial bug. In sh shell, 'foo = 1' is not the same as
'foo=1'. Using 'foo = 1' makes the shell attempt to interpret foo
as a command, rather than a simple variable assignment.
Signed-off-by: Michael Santana
Fixes: dafc04c15174 ("hash: fix out-of-bound write while freeing key slot")
---
v2:
Enable codespell by default.
codespell is a feature by checkpatch.pl that
checks for common spelling mistakes in patches.
This feature is disabled by default. To enable it one must add
the '--codespell' flag to the $options variable in
checkpatches.sh. With this change codespell is enabled by defa
Fixed a minor bug with variable assignment, as well as added an
option for checkpatches
v1->v2:
Enable codespell by default. Disable via config file
Michael Santana (2):
Enable codespell by default. Can be disabled from config file.
Fix variable assignment.
devtools/checkpatches.sh | 8 ++
54 matches
Mail list logo
