Hi Shally,
Thanks for your feedback.
> -Original Message-
> From: Shally Verma [mailto:shal...@marvell.com]
> Sent: Wednesday, February 6, 2019 6:08 AM
> To: Kusztal, ArkadiuszX ; dev@dpdk.org
> Cc: akhil.go...@nxp.com; Trahe, Fiona ;
> sunila.s...@caviumnetworks.com; ashish.gu...@caviumn
>-Original Message-
>From: Kusztal, ArkadiuszX
>Sent: 06 February 2019 15:04
>To: Shally Verma ; dev@dpdk.org
>Cc: akhil.go...@nxp.com; Trahe, Fiona ;
>sunila.s...@caviumnetworks.com;
>ashish.gu...@caviumnetworks.com; umesh.kar...@caviumnetworks.com
>Subject: [EXT] RE: [PATCH v2] crypt
> -Original Message-
> From: Shally Verma [mailto:shal...@marvell.com]
> Sent: Wednesday, February 6, 2019 10:38 AM
> To: Kusztal, ArkadiuszX ; dev@dpdk.org
> Cc: akhil.go...@nxp.com; Trahe, Fiona ;
> sunila.s...@caviumnetworks.com; ashish.gu...@caviumnetworks.com;
> umesh.kar...@caviumn
Let's start a new release cycle!
I know it is uncommon to start so early in the month :)
The earlier we start, the less delay we will have.
This 19.05 release is expected to be big.
We must be very active in reviews.
Note: providing some reviews increases your chances to be reviewed.
Thank you
> -Original Message-
> From: Thomas Monjalon [mailto:tho...@monjalon.net]
> Sent: Saturday, February 2, 2019 3:35 PM
> To: Mcnamara, John ; Kovacevic, Marko
>
> Cc: dev@dpdk.org
> Subject: [PATCH] version: 19.05-rc0
>
Acked-by: John McNamara
This patch changes modular exponentiation and modular multiplicative
inverse API comments to make it more precise.
Signed-off-by: Arek Kusztal
---
v2:
- grammar fixes
v3:
- remove information about positive integer
lib/librte_cryptodev/rte_crypto_asym.h | 43 ++
sprintf function is not secure as it doesn't check the length of string.
More secure function snprintf is used.
Fixes: f74df2c57e ("test/distributor: test single and burst API")
Cc: sta...@dpdk.org
Signed-off-by: Pallantla Poornima
---
test/test/test_distributor.c | 6 --
1 file changed, 4
05/02/2019 14:57, Vladimir Medvedkin:
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> +M: Vladimir Medvedkin
> +F: lib/librte_hash/rte_thash.h
I'm not sure about adding maintainership for one file.
You are the author of this file, so you should be consulted
during reviews if you don't catch them by you
05/02/2019 14:57, Vladimir Medvedkin:
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> LPM
> M: Bruce Richardson
> +M: Vladimir Medvedkin
> F: lib/librte_lpm/
> F: doc/guides/prog_guide/lpm*
> F: test/test/test_lpm*
Acked-by: Bruce Richardson
(from v1)
Applied, thanks
sprintf function is not secure as it doesn't check the length of string.
More secure function snprintf is used.
Fixes: 2a9c83ae3b ("test/eventdev: add multi-ports test")
Cc: sta...@dpdk.org
Signed-off-by: Pallantla Poornima
---
test/test/test_event_eth_rx_adapter.c | 3 ++-
1 file changed, 2 in
> -Original Message-
> From: Kusztal, ArkadiuszX
> Sent: Wednesday, February 6, 2019 10:34 AM
> To: dev@dpdk.org
> Cc: akhil.go...@nxp.com; Trahe, Fiona ;
> shally.ve...@caviumnetworks.com;
> sunila.s...@caviumnetworks.com; ashish.gu...@caviumnetworks.com;
> umesh.kar...@caviumnetworks.
05/02/2019 14:57, Vladimir Medvedkin:
> +/* SPDX-License-Identifier: BSD-3-Clause
> + * Copyright(c) 2015-2019 Vladimir Medvedkin
> */
Applied, thanks
On Wed, Feb 06, 2019 at 10:39:07AM +, Pallantla Poornima wrote:
> sprintf function is not secure as it doesn't check the length of string.
> More secure function snprintf is used.
>
> Fixes: f74df2c57e ("test/distributor: test single and burst API")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Pa
>-Original Message-
>From: Arek Kusztal
>Sent: 06 February 2019 16:04
>To: dev@dpdk.org
>Cc: akhil.go...@nxp.com; fiona.tr...@intel.com;
>shally.ve...@caviumnetworks.com; sunila.s...@caviumnetworks.com;
>ashish.gu...@caviumnetworks.com; umesh.kar...@caviumnetworks.com; Arek Kusztal
>
sprintf function is not secure as it doesn't check the length of string.
More secure function snprintf is used.
Fixes: 473d1bebce ("hash: allow to store data in hash table")
Cc: sta...@dpdk.org
Signed-off-by: Pallantla Poornima
---
test/test/test_hash_perf.c | 6 --
1 file changed, 4 insert
On 01/31/2019 04:13 PM, Slava Ovsiienko wrote:
> Hi, Kevin
>
Hi Slava,
> It is rather refactoring, not new feature, tunnel inner items support is
> partially present in 18.11.
> Yes, this patchset is too big to be simple fix, and updates not so much to be
> new feature.
> It is very early pat
Hi,
Do you know what is the expectation from the PMD with related to MTU check on
TX operation?
Should it check if the requested mbuf's l3 length is bigger than the MTU and if
so mark error?
I didn't find any PMD checking for it.
Thanks,
Liron
Since compat library is only a single header, we can easily move it into
the EAL common headers instead of tracking it separately. The downside of
this is that it becomes a little more difficult to have any libs that are
built before EAL depend on it. Thankfully, this is not a major problem as
the
Some PMDs can only support RSA private key operations using CRT keys
(quintuple) only. Thus it is required to add in PMD RSA xform
capability which key type is supported to perform sign and decrypt ops.
Thus add an another op_type RTE_CRYPTO_OP_TYPE_SIGN_CRT and
RTE_CRYPTO_OP_TYPE_DECRYPT_CRT, whi
Add a rsa xform capability check in test functions,
to check for supported sign and decrypt op_types
Signed-off-by: Ayuj Verma
Signed-off-by: Shally Verma
---
test/test/test_cryptodev_asym.c | 47 +
1 file changed, 47 insertions(+)
diff --git a/test/test/test_cr
add new asym op_types RTE_CRYPTO_ASYM_OP_SIGN_CRT and
RTE_CRYPTO_ASYM_OP_DECRYPT_CRT in capability structure
Signed-off-by: Ayuj Verma
Signed-off-by: Shally Verma
---
drivers/crypto/openssl/rte_openssl_pmd_ops.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/cryp
Add CRT variant of RTE_CRYPTO_ASYM_SIGN and DECRYPT operation,
to perform RSA Sign and Decrypt using CRT quintuple keys only
PMD would reflect its capability to support these
operations using its op_type mask. App should query
RSA xform capability API to check if specific op_type is
supported, thu
Hi, Kevin
> As it's a bit grey, I will backport to 18.11 on the understanding that it
> will be
> supported by Mellanox and you will test one of the 18.11.1-RC's to make sure
> there are no regressions on the existing behavior - is that reasonable?
>
Yes, it is quite reasonable, I will test it. T
The frequency list buffer was already validated in
power_acpi_cpufreq_freqs(), so the newly added check was redundant.
To keep consistency with power_pstate_cpufreq_freqs(), remove the
original check and update the log message.
Fixes: 2e6ccdb4e088 ("power: fix frequency list to handle null buffer"
On Wed, Feb 06, 2019 at 11:01:30AM +, Bruce Richardson wrote:
> Since compat library is only a single header, we can easily move it into
> the EAL common headers instead of tracking it separately. The downside of
> this is that it becomes a little more difficult to have any libs that are
> buil
Good work, Stephen.
It should also be documented how PMDs should interpret this MTU.
Obviously, a VLAN tagged Ethernet frame grows from 1518 to 1522 bytes incl.
header and CRC, and should be allowed with an Ethernet MTU of 1500 bytes.
There's even a #define ETHER_MAX_VLAN_FRAME_LEN for this, bu
Hi Ferruh,
What's the plan with this patch?
Best regards,
Igor
On Sat, Jan 5, 2019 at 7:55 PM Igor Ryzhov wrote:
> Hi Ferruh,
>
> I answered in another thread.
>
> Regarding this patch – I have no objections now.
>
> Best regards,
> Igor
>
> On Tue, Dec 18, 2018 at 9:17 PM Ferruh Yigit
> wrot
> Can you use 1G hugepages instead of 2M pages or a combo of the two, not sure
> how dpdk handles having both in the system?
Unfortunately, no. Some of our customer deployments are tenancies on KVM hosts
and low-end appliances, which are not configurable by the end user to enable 1G
huge pages.
On Wed, Feb 06, 2019 at 07:22:54AM -0500, Neil Horman wrote:
> On Wed, Feb 06, 2019 at 11:01:30AM +, Bruce Richardson wrote:
> > Since compat library is only a single header, we can easily move it into
> > the EAL common headers instead of tracking it separately. The downside of
> > this is tha
On 01/07/2019 02:40 PM, David Hunt wrote:
> The cpufreq test breakes when the system is using the intel_pstate
> driver for frequency management. The power library has recentyly been
> updated to allow use of the intel_pstate driver, this patch fixes the
> cpufreq test so that it can now use either
On 01/14/2019 09:16 PM, Yongseok Koh wrote:
> On replenishing Rx buffers for vectorized Rx, mbuf->buf_addr isn't needed
> to be accessed as it is static and easily calculated from the mbuf address.
> Accessing the mbuf content causes unnecessary load stall and it is worsened
> on ARM.
>
> Fixes: 5
On Wed, 6 Feb 2019 14:05:34 +0100
Morten Brørup wrote:
> Good work, Stephen.
>
> It should also be documented how PMDs should interpret this MTU.
>
> Obviously, a VLAN tagged Ethernet frame grows from 1518 to 1522 bytes incl.
> header and CRC, and should be allowed with an Ethernet MTU of 1500
On 01/17/2019 05:17 PM, Harry van Haaren wrote:
> This commit reworks the checks for binutils 2.30 and how
> the flags to disable AVX512F are passed to the compiler.
>
> Previously the #define for including AVX512 code was set,
> while the -mno-avx512f argument was given to the compiler.
> This wo
On Wed, 6 Feb 2019 10:52:17 +
Pallantla Poornima wrote:
> + snprintf(name, sizeof(name), "test_hash%d_data",
> + hashtest_key_lens[table_index]);
It looks like %u should be used since hashtest_key_lens is unsigned
32 bit value.
Since the values in ta
Hi Kevin,
On 6/2/2019 3:47 PM, Kevin Traynor wrote:
On 01/07/2019 02:40 PM, David Hunt wrote:
The cpufreq test breakes when the system is using the intel_pstate
driver for frequency management. The power library has recentyly been
updated to allow use of the intel_pstate driver, this patch fixe
Meson 0.47.1 fixed a bug that is difficult to work around, which causes
the linker flag of dependencies to be repeated dozens of times, which
causes issues especially when using the built-in dependency() API.
Bump the minimum version and remove obsolete version checks.
Signed-off-by: Luca Boccassi
Whenever possible (if the library ships a pkg-config file) use meson's
dependency() function to look for it, as it will automatically add it
to the Requires.private list if needed, to allow for static builds to
succeed for reverse dependencies of DPDK. Otherwise the recursive
dependencies are not p
Most libraries and PMDs depend on eal, and eal depends only on kvargs,
so reorder the list in Meson to reflect this and take advantage of this
dependency chain.
Signed-off-by: Luca Boccassi
Acked-by: Bruce Richardson
---
v3: added this patch to let the next just update librte_eal instead of
Move libbsd inclusion to librte_eal, so that all other libraries and
PMDs will inherit it.
Signed-off-by: Luca Boccassi
Acked-by: Bruce Richardson
---
v3: only add dependency to librte_eal and let it propagate from there
v4: add acked-by
config/meson.build | 10 +-
lib/librte_e
Now that the minimum Meson version has been bumped past 0.45 we can use
integer as an option type directly.
Signed-off-by: Luca Boccassi
---
v6: added following Bruce's suggestion
meson_options.txt | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/meson_options.txt b/meson
On Thu, 2019-01-31 at 09:32 +, Bruce Richardson wrote:
> On Wed, Jan 30, 2019 at 09:18:58PM -0500, Chas Williams wrote:
> > Allow users and packagers to override the default RTE_MAX_ETHPORTS.
> > This adds a new meson option, max_ethports which defaults to the
> > current value.
> >
> > Signed
Hi Michael/Aaron,
Thanks for adding the Arm build. I have few comments inline.
> -Original Message-
> From: Michael Santana
> Sent: Friday, February 1, 2019 10:48 AM
> To: dev@dpdk.org
> Cc: Aaron Conole ; Bruce Richardson
> ; Honnappa Nagarahalli
> ; tho...@monjalon.net
> Subject
Honnappa Nagarahalli writes:
> Hi Michael/Aaron,
> Thanks for adding the Arm build. I have few comments inline.
>
>> -Original Message-
>> From: Michael Santana
>> Sent: Friday, February 1, 2019 10:48 AM
>> To: dev@dpdk.org
>> Cc: Aaron Conole ; Bruce Richardson
>> ; Honnappa Nagar
> From: dev on behalf of Stephen Hemminger
> On Wed, 6 Feb 2019 14:05:34 +0100
> Morten Brørup wrote:
>
> > Good work, Stephen.
> >
> > It should also be documented how PMDs should interpret this MTU.
> >
> > Obviously, a VLAN tagged Ethernet frame grows from 1518 to 1522 bytes incl.
> > heade
The API function rte_eth_dev_fw_version_get() is querying drivers
via the operation callback fw_version_get().
The implementation of this operation is added for mlx4 and mlx5.
Both functions are copying the same ibverbs field fw_ver
which is retrieved when calling ibv_query_device[_ex]()
during the
When fslmc is built as part of a general distribution, the
bus code will log errors when other devices are present.
This could confuse users it is not an error.
Fixes: 50245be05d1a ("bus/fslmc: support device blacklisting")
Signed-off-by: Stephen Hemminger
---
drivers/bus/fslmc/fslmc_bus.c | 2
The fslmc bus code was duplicating the device name and
doing extra initialization. The code can be simplified
to just use the device name directly.
Compile tested only; do not have this hardware.
Signed-off-by: Stephen Hemminger
---
This patch assumes the previous log fix.
Since it is only a cle
This series introduces the ability for any github mirrors of the DPDK
project, including developer mirrors, to kick off builds under the
travis CI infrastructure. For now, this just means compilation - no
other kinds of automated run exists yet. In the future, this can be
expanded to execute and
From: Aaron Conole
The vhost_scsi example code is set to build, even if the requisite header
file virtio_scsi.h isn't available. This happens on some Ubuntu systems
when some versions of the libc-dev package aren't available.
Check whether the virtio_scsi.h file exists, and if not, set the buil
GitHub is a service used by developers to store repositories. GitHub
provides service integrations that allow 3rd party services to access
developer repositories and perform actions. One of these services is
Travis-CI, a simple continuous integration platform.
This is a simple initial implementa
On Wed, 6 Feb 2019 22:59:09 +0100
Thomas Monjalon wrote:
> The API function rte_eth_dev_fw_version_get() is querying drivers
> via the operation callback fw_version_get().
> The implementation of this operation is added for mlx4 and mlx5.
> Both functions are copying the same ibverbs field fw_ve
06/02/2019 23:16, Stephen Hemminger:
> On Wed, 6 Feb 2019 22:59:09 +0100
> Thomas Monjalon wrote:
>
> > The API function rte_eth_dev_fw_version_get() is querying drivers
> > via the operation callback fw_version_get().
> > The implementation of this operation is added for mlx4 and mlx5.
> > Both
The API function rte_eth_dev_fw_version_get() is querying drivers
via the operation callback fw_version_get().
The implementation of this operation is added for mlx4 and mlx5.
Both functions are copying the same ibverbs field fw_ver
which is retrieved when calling ibv_query_device[_ex]()
during the
On Wed, 06 Feb 2019 23:23:07 +0100
Thomas Monjalon wrote:
> 06/02/2019 23:16, Stephen Hemminger:
> > On Wed, 6 Feb 2019 22:59:09 +0100
> > Thomas Monjalon wrote:
> >
> > > The API function rte_eth_dev_fw_version_get() is querying drivers
> > > via the operation callback fw_version_get().
> >
All drivers should have SPDX on the first line of the source
files in the format
/* SPDX-License-Identifier: ...
Several files used minor modifications which were inconsistent
with the pattern. Fix it to make scanning tools easier.
Signed-off-by: Stephen Hemminger
---
drivers/bus/fslmc/qbman/
55 matches
Mail list logo
