Re: [dpdk-dev] [PATCH v5] net/ixgbe: fix over using multicast table for VF

2019-01-07 Thread Zhang, Qi Z
> -Original Message- > From: Zhao1, Wei > Sent: Monday, January 7, 2019 3:23 PM > To: dev@dpdk.org > Cc: sta...@dpdk.org; Zhang, Qi Z ; Wu, Jingjing > ; Zhao1, Wei > Subject: [PATCH v5] net/ixgbe: fix over using multicast table for VF > > According to the current implementation, all VF

[dpdk-dev] [PATCH v2 1/3] mbuf: add sanity checks on segment metadata

2019-01-07 Thread David Marchand
From: David Marchand Add some basic checks on the segments offset and length metadata: always funny to have a < 0 tailroom cast to uint16_t ;-). Signed-off-by: David Marchand Signed-off-by: David Marchand Acked-by: Olivier Matz --- lib/librte_mbuf/rte_mbuf.c | 4 1 file changed, 4 inser

[dpdk-dev] [PATCH v2 2/3] mbuf: add a non fatal sanity check helper

2019-01-07 Thread David Marchand
From: David Marchand Let's add a little helper that does the same as rte_mbuf_sanity_check but without the panic. Signed-off-by: David Marchand Signed-off-by: David Marchand Acked-by: Olivier Matz --- lib/librte_mbuf/Makefile | 2 + lib/librte_mbuf/meson.build | 2 + l

[dpdk-dev] [PATCH v2 0/3] segment sanity checks

2019-01-07 Thread David Marchand
Resubmitting this series that I did not finish in my previous life (6WIND people are okay with this). Here is a little series which helped me identify a multi segment issue. Hope it can help others. The difference since the RFC patches I sent some time ago is that, rather than force the user to b

[dpdk-dev] [PATCH v2 3/3] app/testpmd: check mbufs in verbose mode

2019-01-07 Thread David Marchand
Let's check the received/sent mbufs, it can help debugging. Signed-off-by: David Marchand --- app/test-pmd/util.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/app/test-pmd/util.c b/app/test-pmd/util.c index 687bfa4..6b0791d 100644 --- a/app/test-pmd/util.c +++ b/app/test-pmd/util.c @@

Re: [dpdk-dev] [PATCH] doc: fix a typo in programmer's guide

2019-01-07 Thread Hunt, David
Hi Yong Wang, On 7/1/2019 2:50 AM, Yong Wang wrote: This patch fixes a typo in programmer's guide. It should be Frequence, not Fequence. It should be Frequency. Rgds, Dave. Fixes: 450f0791312c ("power: add traffic pattern aware power control") Signed-off-by: Yong Wang --- doc/guides/

[dpdk-dev] [PATCH v2] doc: fix a typo in programmer's guide

2019-01-07 Thread Yong Wang
This patch fixes a typo in programmer's guide. It should be Frequency, not Fequence. Fixes: 450f0791312c ("power: add traffic pattern aware power control") Signed-off-by: Yong Wang --- v2: modify Frequence to Frequency --- doc/guides/prog_guide/power_man.rst | 2 +- 1 file changed, 1 insertion

[dpdk-dev] [PATCH v8 1/7] app/procinfo: prepare for new debug functions

2019-01-07 Thread Vipin Varghese
Update code base and meson build file to accomadate changes for the new functionality. Signed-off-by: Vipin Varghese Acked-by: Reshma Pattan --- app/proc-info/main.c | 13 + app/proc-info/meson.build | 2 +- 2 files changed, 14 insertions(+), 1 deletion(-) diff --git a/app/p

[dpdk-dev] [PATCH v8 2/7] app/procinfo: add support for show port

2019-01-07 Thread Vipin Varghese
Function show_port is used for displaying the port PMD information under primary process. The information shows basic, per queue and security. Signed-off-by: Vipin Varghese Acked-by: Reshma Pattan Acked-by: John McNamara --- app/proc-info/main.c | 106 +++

[dpdk-dev] [PATCH v8 3/7] app/procinfo: add support for show tm

2019-01-07 Thread Vipin Varghese
Function show_tm is used for displaying the tm PMD under the primary process. This covers basic and per node|level details with statistics. Signed-off-by: Vipin Varghese Acked-by: Reshma Pattan Acked-by: John McNamara --- app/proc-info/main.c | 290 -

[dpdk-dev] [PATCH v8 4/7] app/procinfo: add support for show crypto

2019-01-07 Thread Vipin Varghese
Function show_crypto is used for displaying the crypto PMD under primary process. Signed-off-by: Vipin Varghese Acked-by: Reshma Pattan Acked-by: John McNamara --- app/proc-info/main.c | 94 +- doc/guides/tools/proc_info.rst | 6 ++- 2 files changed,

[dpdk-dev] [PATCH v8 0/7] app/proc-info: enhance debug of proc-info tool

2019-01-07 Thread Vipin Varghese
This patch adds new debug functions to existing proc-info tool. Motivation == DPDK proc-info tool is been widely used as secondary process to collect stats for any primary process. But these are limited to DPDK NIC ports and basic memory usage. The patch series tries to address the missi

[dpdk-dev] [PATCH v8 5/7] app/procinfo: add support for debug ring

2019-01-07 Thread Vipin Varghese
Function show_ring is used for displaying information of RING instance of the primary process. Signed-off-by: Vipin Varghese Acked-by: Reshma Pattan Acked-by: John McNamara --- app/proc-info/main.c | 52 +- doc/guides/tools/proc_info.rst | 8 +-

[dpdk-dev] [PATCH v8 6/7] app/procinfo: add support for show mempool

2019-01-07 Thread Vipin Varghese
Function show_mempool is used for displaying valid MEMPOOL. In case of invalid or no name, whole list is dump. Signed-off-by: Vipin Varghese Acked-by: Reshma Pattan Acked-by: John McNamara --- app/proc-info/main.c | 65 +- doc/guides/tools/proc_info.r

[dpdk-dev] [PATCH v8 7/7] app/procinfo: add support for iter mempool

2019-01-07 Thread Vipin Varghese
Function iter_mempool is used for iterating slected mempool elements and display the contents of elements for a max of 256 bytes. In case of invalid or no name for mempool, no information is displayed. Signed-off-by: Vipin Varghese Acked-by: Reshma Pattan Acked-by: John McNamara --- app/proc-

Re: [dpdk-dev] [PATCH] net/ixgbe: add support of loopback for X540/X550

2019-01-07 Thread Zhao1, Wei
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Julien Meunier > Sent: Thursday, January 3, 2019 12:01 AM > To: Ananyev, Konstantin ; Lu, Wenzhuo > > Cc: dev@dpdk.org > Subject: [dpdk-dev] [PATCH] net/ixgbe: add support of loopback for > X540/X550 > > Loopba

[dpdk-dev] [PATCH v3] eal: fix core number validation

2019-01-07 Thread Hari Kumar Vemula
When incorrect core value or range provided, as part of -l command line option, a crash occurs. Added valid range checks to fix the crash. Added ut check for negative core values. Added unit test case for invalid core number range. Fixes: d888cb8b9613 ("eal: add core list input format") Cc: sta.

Re: [dpdk-dev] [RFC] virtio-user: ctrl vq support for packed

2019-01-07 Thread Maxime Coquelin
Hi Jens, On 12/21/18 4:29 PM, Jens Freimann wrote: This adds support to virtio-user for control virtqueues and reverts commit "5e4e7a752 net/virtio-user: fail if cq used with packed vq". I add a struct virtio_user_queue to have a place for wrap counters and avail/used index (which is not needed

Re: [dpdk-dev] [PATCH v3 3/3] doc: update ISA-L guide to reflect checksum support

2019-01-07 Thread Daly, Lee
Hi Vipin, thanks for your suggestion. I will send another version with the change. /Lee. > -Original Message- > From: Varghese, Vipin > Sent: Friday, December 28, 2018 5:05 AM > To: Daly, Lee ; akhil.go...@nxp.com > Cc: dev@dpdk.org; Daly, Lee > Subject: RE: [dpdk-dev] [PATCH v3 3/3] doc

[dpdk-dev] [PATCH] drivers: fix sprintf with snprintf

2019-01-07 Thread Pallantla Poornima
sprintf function is not secure as it doesn't check the length of string. More secure function snprintf is used Fixes: 828d51d8fc ("bus/fslmc: refactor scan and probe functions") Fixes: c22fab9a6c ("raw/dpaa2_qdma: support configuration APIs") Fixes: e5cbdfc537 ("crypto/dpaa2_sec: add basic operati

Re: [dpdk-dev] Compiler for Windows

2019-01-07 Thread Burakov, Anatoly
On 03-Jan-19 6:33 AM, Stephen Hemminger wrote: What about Gcc under the WSL thing (ie Linux emulation in Windows). Much better than Cygwin type stuff. WSL is dog-slow with any kind of disk I/O, at least currently, so while i do use WSL to fool my IDE into thinking it's running on Linux, the

[dpdk-dev] [PATCH] examples/power: fix wrong core_id with JSON cmds

2019-01-07 Thread David Hunt
This patch fixes a bug introduced in the 64-core limtation enhancement where the core_id is inadvertently converted from virtual to physical even though it may already be a physical core_id. We should be using the core_type field, and only converting via hypervisor when core_type is set to CORE_TY

[dpdk-dev] reply: [PATCH] hash: fix possible uninitialized variable

2019-01-07 Thread 谭海洋
> -Original Message- > From: Dumitrescu, Cristian > 发送时间: 2018年12月24日 18:30 > 收件人: Stephen Hemminger ; > haiyangtan > Cc: dev@dpdk.org > Subject: RE: [dpdk-dev] [PATCH] hash: fix possible uninitialized > variable(Internet > mail) > > > > > -Original Message- > > From: Stephe

Re: [dpdk-dev] [RFC v2 2/2] test/rcu_qsbr: add API and functional tests

2019-01-07 Thread Paul E. McKenney
On Sat, Dec 22, 2018 at 11:30:51PM -0800, Stephen Hemminger wrote: > On Fri, 21 Dec 2018 20:14:20 -0600 > Honnappa Nagarahalli wrote: > > > From: Dharmik Thakkar > > > > Add API positive/negative test cases and functional tests. > > > > Signed-off-by: Malvika Gupta > > Signed-off-by: Dharmik

Re: [dpdk-dev] [PATCH] build: use generic march on arm64 when using 'default' machine

2019-01-07 Thread Bruce Richardson
On Mon, Dec 24, 2018 at 01:56:27PM +0100, Luca Boccassi wrote: > When building for generic distribution we need a stable baseline > architecture, or depending on the build worker the result will vary. > > Force the default flags if the user explicitly sets marchine=default typo: marchine > at con

[dpdk-dev] [PATCH] net/bonding: fix create bonded device test failure

2019-01-07 Thread Hari Kumar Vemula
Create bonded device test is failing due to improper initialisation in bonded device configuration. which leads to crash while setting up queues. The value of nb_rx_desc is checked if it is not in range of rx_desc_lim of bonded device which fails. This is due to "rx_desc_lim" is set to 0 as defaul

Re: [dpdk-dev] [PATCH v3 3/3] doc: update ISA-L guide to reflect checksum support

2019-01-07 Thread Varghese, Vipin
Thanks Lee for understanding > -Original Message- > From: Daly, Lee > Sent: Monday, January 7, 2019 4:07 PM > To: Varghese, Vipin ; akhil.go...@nxp.com > Cc: dev@dpdk.org > Subject: RE: [dpdk-dev] [PATCH v3 3/3] doc: update ISA-L guide to reflect > checksum support > > Hi Vipin, thanks fo

[dpdk-dev] [PATCH v2] build: use generic march on arm64 when using 'default' machine

2019-01-07 Thread Luca Boccassi
When building for generic distribution we need a stable baseline architecture, or depending on the build worker the result will vary. Force the default flags if the user explicitly sets machine=default at configuration time. Fixes: b1d48c41189a ("build: support ARM with meson") Cc: sta...@dpdk.or

Re: [dpdk-dev] [PATCH] build: use generic march on arm64 when using 'default' machine

2019-01-07 Thread Luca Boccassi
On Mon, 2019-01-07 at 12:24 +, Bruce Richardson wrote: > On Mon, Dec 24, 2018 at 01:56:27PM +0100, Luca Boccassi wrote: > > When building for generic distribution we need a stable baseline > > architecture, or depending on the build worker the result will > > vary. > > > > Force the default fl

Re: [dpdk-dev] [PATCH] build: use generic march on arm64 when using 'default' machine

2019-01-07 Thread Luca Boccassi
On Mon, 2019-01-07 at 12:24 +, Bruce Richardson wrote: > On Mon, Dec 24, 2018 at 01:56:27PM +0100, Luca Boccassi wrote: > > When building for generic distribution we need a stable baseline > > architecture, or depending on the build worker the result will > > vary. > > > > Force the default fl

[dpdk-dev] [PATCH v3] build: use generic march on arm64 when using 'default' machine

2019-01-07 Thread Luca Boccassi
When building for generic distribution we need a stable baseline architecture, or depending on the build worker the result will vary. Force the default flags if the user explicitly sets machine=default at configuration time. Fixes: b1d48c41189a ("build: support ARM with meson") Cc: sta...@dpdk.or

Re: [dpdk-dev] [PATCH 2/2] build: use dependency() instead of find_library()

2019-01-07 Thread Bruce Richardson
On Thu, Jan 03, 2019 at 06:57:25PM +0100, Luca Boccassi wrote: > Whenever possible (if the library ships a pkg-config file) use meson's > dependency() function to look for it, as it will automatically add it > to the Requires.private list if needed, to allow for static builds to > succeed for rever

Re: [dpdk-dev] [PATCH] gro: fix overflow of TCP Options length calculation

2019-01-07 Thread Bruce Richardson
On Fri, Jan 04, 2019 at 09:57:16AM +0800, Jiayu Hu wrote: > If we receive a packet with an invalid TCP header, whose > TCP header length is less than 20 bytes (the minimal TCP > header length), the calculated TCP Options length will > overflow and result in incorrect reassembly behaviors. Please e

[dpdk-dev] [PATCH] lib/power: fix freq list function to handle null

2019-01-07 Thread David Hunt
This patch fixes a segfault in the case where a null buffer is passed to the following functions: power_acpi_cpufreq_freqs() power_pstate_cpufreq_freqs() Fixes: 445c6528b55f ("power: common interface for guest and host") Signed-off-by: David Hunt --- lib/librte_power/power_acpi_cpufreq.c

[dpdk-dev] [PATCH] ethdev: report error on name truncation

2019-01-07 Thread Nithin Kumar Dabilpuram
Signed-off-by: Nithin Dabilpuram --- lib/librte_ethdev/rte_ethdev.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/lib/librte_ethdev/rte_ethdev.c b/lib/librte_ethdev/rte_ethdev.c index 9d5107d..bd45445 100644 --- a/lib/librte_ethdev/rte_ethdev.c +++ b/lib/librte

[dpdk-dev] [PATCH] lib/power: fix return code to unsigned value

2019-01-07 Thread David Hunt
The power_pstate_cpufreq_freqs() function was returning -1 in an unsigned int, causing buffer over-runs when the results were being processed. This function should be returning zero for all error conditions, similar to it's acpi relation, power_acpi_cpufreq_freqs(). Fixes: e6c6dc0f96c8 ("power: ad

[dpdk-dev] [PATCH] test/power: fix unit test to handle pstate mode

2019-01-07 Thread David Hunt
The cpufreq test breakes when the system is using the intel_pstate driver for frequency management. The power library has recentyly been updated to allow use of the intel_pstate driver, this patch fixes the cpufreq test so that it can now use either acpi or pstate modes. The library will auto-detec

Re: [dpdk-dev] [PATCH] ethdev: report error on name truncation

2019-01-07 Thread Andrew Rybchenko
On 1/7/19 5:40 PM, Nithin Kumar Dabilpuram wrote: Signed-off-by: Nithin Dabilpuram --- lib/librte_ethdev/rte_ethdev.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/lib/librte_ethdev/rte_ethdev.c b/lib/librte_ethdev/rte_ethdev.c index 9d5107d..bd45445 100644

Re: [dpdk-dev] [PATCH] ethdev: report error on name truncation

2019-01-07 Thread Thomas Monjalon
Hi, Please provide an explanation of the current behaviour. 07/01/2019 15:40, Nithin Kumar Dabilpuram: > - snprintf(z_name, sizeof(z_name), "eth_p%d_q%d_%s", > - dev->data->port_id, queue_id, ring_name); > + rc = snprintf(z_name, sizeof(z_name), "%s_%s_%d_%d", > +

[dpdk-dev] [Bug 183] Problem using cloned rte_mbuf buffers with KNI interface

2019-01-07 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=183 Bug ID: 183 Summary: Problem using cloned rte_mbuf buffers with KNI interface Product: DPDK Version: 18.11 Hardware: All OS: Linux Status: CONFIRMED

Re: [dpdk-dev] DSW eventdev and multi-process DPDK

2019-01-07 Thread Mattias Rönnblom
On 2018-12-21 20:12, Venky Venkatesh wrote: On 12/21/18, 10:59 AM, "Mattias Rönnblom" wrote: On 2018-12-21 19:34, Venky Venkatesh wrote: > > > On 12/21/18, 10:24 AM, "Mattias Rönnblom" wrote: > > On 2018-12-21 06:13, Venky Venkatesh wrote: > >

[dpdk-dev] [PATCH v2 1/6] mk: introduce helper to check valid compiler argument

2019-01-07 Thread Pavan Nikhilesh Bhagavatula
From: Jerin Jacob Kollanukkaran Introduce rte_cc_has_argument() Makefile helper to check a given argument is support by the compiler. Example Usage: include $(RTE_SDK)/mk/rte.helper.mk MACHINE_CFLAGS += $(call rte_cc_has_argument, -mcpu=octeontx2) This would allow adding -mcpu=octeontx2 in MAC

[dpdk-dev] [PATCH v2 3/6] config: add octeontx2 machine config

2019-01-07 Thread Pavan Nikhilesh Bhagavatula
From: Jerin Jacob Kollanukkaran Optimized configuration for Marvell octeontx2 SoC. Signed-off-by: Jerin Jacob --- config/defconfig_arm64-octeontx2-linuxapp-gcc | 18 ++ mk/machine/octeontx2/rte.vars.mk | 34 +++ 2 files changed, 52 insertions(+) create mod

[dpdk-dev] [PATCH v2 4/6] meson: add infra to support machine specific flags

2019-01-07 Thread Pavan Nikhilesh Bhagavatula
From: Pavan Nikhilesh Currently, RTE_* flags are set based on the implementer ID but there might be some micro arch specific differences from the same vendor eg. CACHE_LINESIZE. Add support to set micro arch specific flags. Signed-off-by: Pavan Nikhilesh --- config/arm/meson.build | 53 +++

[dpdk-dev] [PATCH v2 2/6] config: add thunderx2 machine config

2019-01-07 Thread Pavan Nikhilesh Bhagavatula
From: Jerin Jacob Kollanukkaran Optimized configuration for Marvell thunderx2 SoC. Product details are here: https://www.marvell.com/server-processors/thunderx2-arm-processors/ Signed-off-by: Jerin Jacob --- config/defconfig_arm64-thunderx2-linuxapp-gcc | 11 ++ mk/machine/thunderx2/rte.

[dpdk-dev] [PATCH v2 5/6] meson: add thunderx2 machine config

2019-01-07 Thread Pavan Nikhilesh Bhagavatula
From: Pavan Nikhilesh Meson configuration for Marvell thunderx2 SoC. Signed-off-by: Pavan Nikhilesh --- config/arm/meson.build | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/config/arm/meson.build b/config/arm/meson.build index 576363fc0..aca285b6a 100644 --- a/con

[dpdk-dev] [PATCH v2 6/6] meson: add octeontx2 machine config

2019-01-07 Thread Pavan Nikhilesh Bhagavatula
From: Pavan Nikhilesh Meson configuration for Marvell octeontx2 SoC. Signed-off-by: Pavan Nikhilesh --- config/arm/meson.build | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/config/arm/meson.build b/config/arm/meson.build index aca285b6a..8086357a1 100644 --- a/c

Re: [dpdk-dev] Compiler for Windows

2019-01-07 Thread Stephen Hemminger
On Mon, 7 Jan 2019 10:56:57 + "Burakov, Anatoly" wrote: > On 03-Jan-19 6:33 AM, Stephen Hemminger wrote: > > What about Gcc under the WSL thing (ie Linux emulation in Windows). > > Much better than Cygwin type stuff. > > > > WSL is dog-slow with any kind of disk I/O, at least currently, s

Re: [dpdk-dev] [PATCH] net/ixgbe: add support of loopback for X540/X550

2019-01-07 Thread Meunier, Julien (Nokia - FR/Paris-Saclay)
Hi, Mmm, you're right. However, as like for the 82599, the pmd skips the link configuration, so, it should not enable the autoneg. During my tests, I had a 10G connectivity, and I didn't notice any problem. I used the DPDK application "test", with the test pmd_perf_autotest. Should I need to

Re: [dpdk-dev] [PATCH] ethdev: report error on name truncation

2019-01-07 Thread Stephen Hemminger
On Mon, 7 Jan 2019 17:47:08 +0300 Andrew Rybchenko wrote: > On 1/7/19 5:40 PM, Nithin Kumar Dabilpuram wrote: > > Signed-off-by: Nithin Dabilpuram > > --- > > lib/librte_ethdev/rte_ethdev.c | 12 ++-- > > 1 file changed, 10 insertions(+), 2 deletions(-) > > > > diff --git a/lib/librte

Re: [dpdk-dev] [PATCH v4 1/2] lib/librte_meter: add RFC4115 trTCM meter support

2019-01-07 Thread Dumitrescu, Cristian
> -Original Message- > From: Eelco Chaudron [mailto:echau...@redhat.com] > Sent: Monday, January 7, 2019 7:42 AM > To: Stephen Hemminger ; Dumitrescu, > Cristian > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v4 1/2] lib/librte_meter: add RFC4115 trTCM > meter support > > > > On

Re: [dpdk-dev] [PATCH v4 0/2] lib/librte_meter: add RFC4115 trTCM meter support

2019-01-07 Thread Dumitrescu, Cristian
> -Original Message- > From: Eelco Chaudron [mailto:echau...@redhat.com] > Sent: Friday, January 4, 2019 2:00 PM > To: Dumitrescu, Cristian > Cc: dev@dpdk.org > Subject: [PATCH v4 0/2] lib/librte_meter: add RFC4115 trTCM meter support > > This patch adds support for RFC4115 trTCM meters

Re: [dpdk-dev] [PATCH] net/ixgbe: add support of loopback for X540/X550

2019-01-07 Thread Meunier, Julien (Nokia - FR/Paris-Saclay)
Inline reply On 07/01/2019 11:05, Zhao1, Wei wrote: > > >> -Original Message- >> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Julien Meunier >> Sent: Thursday, January 3, 2019 12:01 AM >> To: Ananyev, Konstantin ; Lu, Wenzhuo >> >> Cc: dev@dpdk.org >> Subject: [dpdk-dev] [PATCH]

Re: [dpdk-dev] Compiler for Windows

2019-01-07 Thread Bruce Richardson
On Mon, Jan 07, 2019 at 07:51:38AM -0800, Stephen Hemminger wrote: > On Mon, 7 Jan 2019 10:56:57 + > "Burakov, Anatoly" wrote: > > > On 03-Jan-19 6:33 AM, Stephen Hemminger wrote: > > > What about Gcc under the WSL thing (ie Linux emulation in Windows). > > > Much better than Cygwin type stuf

Re: [dpdk-dev] [PATCH] ethdev: report error on name truncation

2019-01-07 Thread Andrew Rybchenko
On 1/7/19 6:53 PM, Stephen Hemminger wrote: On Mon, 7 Jan 2019 17:47:08 +0300 Andrew Rybchenko wrote: On 1/7/19 5:40 PM, Nithin Kumar Dabilpuram wrote: Signed-off-by: Nithin Dabilpuram --- lib/librte_ethdev/rte_ethdev.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-)

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/fm10k: initialize sm_down variable

2019-01-07 Thread Meunier, Julien (Nokia - FR/Paris-Saclay)
Hi, Inline reply, On 04/01/2019 18:34, Ferruh Yigit wrote: > On 1/4/2019 1:04 PM, Zhang, Qi Z wrote: >> >> >>> -Original Message- >>> From: Wang, Xiao W >>> Sent: Thursday, January 3, 2019 10:10 AM >>> To: Julien Meunier ; Zhang, Qi Z >>> >>> Cc: dev@dpdk.org; sta...@dpdk.org >>> Subject

Re: [dpdk-dev] Compiler for Windows

2019-01-07 Thread Burakov, Anatoly
On 07-Jan-19 4:15 PM, Bruce Richardson wrote: On Mon, Jan 07, 2019 at 07:51:38AM -0800, Stephen Hemminger wrote: On Mon, 7 Jan 2019 10:56:57 + "Burakov, Anatoly" wrote: On 03-Jan-19 6:33 AM, Stephen Hemminger wrote: What about Gcc under the WSL thing (ie Linux emulation in Windows). Much

Re: [dpdk-dev] [dpdk-stable] [PATCH 2/2] build: use dependency() instead of find_library()

2019-01-07 Thread Luca Boccassi
On Mon, 2019-01-07 at 14:28 +, Bruce Richardson wrote: > On Thu, Jan 03, 2019 at 06:57:25PM +0100, Luca Boccassi wrote: > > Whenever possible (if the library ships a pkg-config file) use > > meson's > > dependency() function to look for it, as it will automatically add > > it > > to the Require

Re: [dpdk-dev] [PATCH] ethdev: support double precision RED queue weight

2019-01-07 Thread Dumitrescu, Cristian
Hi Nikhil, > -Original Message- > From: Rao, Nikhil > Sent: Thursday, November 29, 2018 5:55 AM > To: Dumitrescu, Cristian ; Singh, Jasvinder > > Cc: dev@dpdk.org; Rao, Nikhil > Subject: [PATCH] ethdev: support double precision RED queue weight > > RED queue weight is currently specifie

[dpdk-dev] [PATCH v4] mk: fix scope of disabling AVX512F support

2019-01-07 Thread Ferruh Yigit
AVX512 was disabled for GCC because of Bugzilla issue 97 [1], the GCC defect submitted for the issue [2] highlighted that this is a known binutils version 2.30 issue. Narrowed the scope of no-avx512 to the this specific binutils version. [1] https://bugs.dpdk.org/show_bug.cgi?id=97 [2] https://g

Re: [dpdk-dev] [PATCH] net/softnic: add support for service cores

2019-01-07 Thread Dumitrescu, Cristian
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Cristian Dumitrescu > Sent: Thursday, January 3, 2019 4:05 PM > To: dev@dpdk.org > Cc: Singh, Jasvinder > Subject: [dpdk-dev] [PATCH] net/softnic: add support for service cores > > Add support to run the Soft N

Re: [dpdk-dev] Compiler for Windows

2019-01-07 Thread Stephen Hemminger
On Mon, 7 Jan 2019 16:29:25 + "Burakov, Anatoly" wrote: > On 07-Jan-19 4:15 PM, Bruce Richardson wrote: > > On Mon, Jan 07, 2019 at 07:51:38AM -0800, Stephen Hemminger wrote: > >> On Mon, 7 Jan 2019 10:56:57 + > >> "Burakov, Anatoly" wrote: > >> > >>> On 03-Jan-19 6:33 AM, Stephen He

Re: [dpdk-dev] [dpdk-stable] [PATCH 2/2] build: use dependency() instead of find_library()

2019-01-07 Thread Bruce Richardson
On Mon, Jan 07, 2019 at 04:39:34PM +, Luca Boccassi wrote: > On Mon, 2019-01-07 at 14:28 +, Bruce Richardson wrote: > > On Thu, Jan 03, 2019 at 06:57:25PM +0100, Luca Boccassi wrote: > > > Whenever possible (if the library ships a pkg-config file) use > > > meson's > > > dependency() functi

Re: [dpdk-dev] [PATCH v2 5/6] meson: add thunderx2 machine config

2019-01-07 Thread Thomas Monjalon
07/01/2019 16:42, Pavan Nikhilesh Bhagavatula: > From: Pavan Nikhilesh > > Meson configuration for Marvell thunderx2 SoC. > > Signed-off-by: Pavan Nikhilesh > --- > config/arm/meson.build | 9 - > 1 file changed, 8 insertions(+), 1 deletion(-) I think it can be merged with the patch d

[dpdk-dev] [pull-request] next-qos 19.02 pre-rc2

2019-01-07 Thread Cristian Dumitrescu
The following changes since commit 9d1d6a7c7747173b4cb5a882316a0e3b5e1585dc: net/ice: fix build with debug enabled (2019-01-03 13:41:07 +0100) are available in the Git repository at: http://dpdk.org/git/next/dpdk-next-qos for you to fetch changes up to 2b7c1fc2fddd0e178a7af45c791d3c7361765

Re: [dpdk-dev] Compiler for Windows

2019-01-07 Thread Bruce Richardson
On Mon, Jan 07, 2019 at 08:51:25AM -0800, Stephen Hemminger wrote: > On Mon, 7 Jan 2019 16:29:25 + > "Burakov, Anatoly" wrote: > > > On 07-Jan-19 4:15 PM, Bruce Richardson wrote: > > > On Mon, Jan 07, 2019 at 07:51:38AM -0800, Stephen Hemminger wrote: > > >> On Mon, 7 Jan 2019 10:56:57 +000

Re: [dpdk-dev] Compiler for Windows

2019-01-07 Thread Thomas Monjalon
07/01/2019 17:51, Stephen Hemminger: > On Mon, 7 Jan 2019 16:29:25 + > "Burakov, Anatoly" wrote: > > > On 07-Jan-19 4:15 PM, Bruce Richardson wrote: > > > On Mon, Jan 07, 2019 at 07:51:38AM -0800, Stephen Hemminger wrote: > > >> On Mon, 7 Jan 2019 10:56:57 + > > >> "Burakov, Anatoly" w

Re: [dpdk-dev] [dpdk-techboard] [dpdk-stable] [PATCH 2/2] build: use dependency() instead of find_library()

2019-01-07 Thread Thomas Monjalon
07/01/2019 17:55, Bruce Richardson: > On Mon, Jan 07, 2019 at 04:39:34PM +, Luca Boccassi wrote: > > On Mon, 2019-01-07 at 14:28 +, Bruce Richardson wrote: > > > However, in > > > conjunction with meson version checks, I believe this was done this > > > way > > > originally because of a mes

Re: [dpdk-dev] Compiler for Windows

2019-01-07 Thread Thomas Monjalon
07/01/2019 18:00, Bruce Richardson: > I think for windows we probably want to start with the MS compiler first, > since from my understanding it's probably the default go-to compiler for > developers on windows, and look at alternatives from there. Not sure. I feel clang is a better option. This

Re: [dpdk-dev] [dpdk-stable] [dpdk-techboard] [PATCH 2/2] build: use dependency() instead of find_library()

2019-01-07 Thread Thomas Monjalon
07/01/2019 18:03, Thomas Monjalon: > 07/01/2019 17:55, Bruce Richardson: > > On Mon, Jan 07, 2019 at 04:39:34PM +, Luca Boccassi wrote: > > > On Mon, 2019-01-07 at 14:28 +, Bruce Richardson wrote: > > > > However, in > > > > conjunction with meson version checks, I believe this was done thi

[dpdk-dev] Projects depending on make (versus meson)

2019-01-07 Thread Stephen Hemminger
I recently bumped into NFF-go which probably will have problems with meson build. It puts dpdk and pktgen-dpdk in as git submodules and then builds it all together with Go environment. The current model is a nuisance because can't get Mellanox drivers for Azure by default.

Re: [dpdk-dev] [PATCH] net/bonding: fix create bonded device test failure

2019-01-07 Thread Chas Williams
On 1/7/19 8:01 AM, Hari Kumar Vemula wrote: Create bonded device test is failing due to improper initialisation in bonded device configuration. which leads to crash while setting up queues. The value of nb_rx_desc is checked if it is not in range of rx_desc_lim of bonded device which fails. T

[dpdk-dev] [PATCH] [pktgen] Fix string truncation warnings

2019-01-07 Thread Stephen Hemminger
From: Stephen Hemminger The strncatf macro will cause warnings with latest GCC if the sizeof the destination buffer is smaller than the temporary buffer. Resolve by adjusting buffer sizes. Such as: git/pktgen-dpdk/app/pktgen-capture.c: In function ‘pktgen_set_capture’: git/pktgen-dpdk/app/pktge

[dpdk-dev] 17.11.5-rc1 patches review and test

2019-01-07 Thread Yongseok Koh
Hi all, Here is a list of patches targeted for LTS release 17.11.5. Please help review and test RC1. The planned date for the final release is 18 Jan 2019 unless there's need for RC2. Before that, please shout if anyone has objections with these patches being applied. Also for the companies commi

Re: [dpdk-dev] [dpdk-stable] [dpdk-techboard] [PATCH 2/2] build: use dependency() instead of find_library()

2019-01-07 Thread Luca Boccassi
On Mon, 2019-01-07 at 18:45 +0100, Thomas Monjalon wrote: > 07/01/2019 18:03, Thomas Monjalon: > > 07/01/2019 17:55, Bruce Richardson: > > > On Mon, Jan 07, 2019 at 04:39:34PM +, Luca Boccassi wrote: > > > > On Mon, 2019-01-07 at 14:28 +, Bruce Richardson wrote: > > > > > However, in > > >

Re: [dpdk-dev] [dpdk-stable] [dpdk-techboard] [PATCH 2/2] build: use dependency() instead of find_library()

2019-01-07 Thread Luca Boccassi
On Mon, 2019-01-07 at 21:09 +, Luca Boccassi wrote: > On Mon, 2019-01-07 at 18:45 +0100, Thomas Monjalon wrote: > > 07/01/2019 18:03, Thomas Monjalon: > > > 07/01/2019 17:55, Bruce Richardson: > > > > On Mon, Jan 07, 2019 at 04:39:34PM +, Luca Boccassi wrote: > > > > > On Mon, 2019-01-07 at

Re: [dpdk-dev] [PATCH] gro: fix overflow of TCP Options length calculation

2019-01-07 Thread Hu, Jiayu
> -Original Message- > From: Richardson, Bruce > Sent: Monday, January 7, 2019 10:30 PM > To: Hu, Jiayu > Cc: dev@dpdk.org; Bie, Tiwei ; sta...@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] gro: fix overflow of TCP Options length > calculation > > On Fri, Jan 04, 2019 at 09:57:16AM +0800,

Re: [dpdk-dev] [PATCH] examples/power: fix wrong core_id with JSON cmds

2019-01-07 Thread Yao, Lei A
> -Original Message- > From: Hunt, David > Sent: Monday, January 7, 2019 7:39 PM > To: dev@dpdk.org > Cc: Hunt, David ; Yao, Lei A > Subject: [PATCH] examples/power: fix wrong core_id with JSON cmds > > This patch fixes a bug introduced in the 64-core limtation > enhancement where the

[dpdk-dev] TX unable to enqueue packets to NIC

2019-01-07 Thread Soni, Shivam
Hi All, We are facing one weird issue. After the deployment, in few of the hosts we see an issue where TX is unable to enqueue packets to NIC. On rebouncing or restarting our packet processor daemon, issue gets resolved. We are using IntelDPDK version 17.11.4 and i40e drivers. I have verified

Re: [dpdk-dev] [PATCH] doc: add GRO API requirement in prog_guide

2019-01-07 Thread Hu, Jiayu
Hi Stephen, > -Original Message- > From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Saturday, January 5, 2019 3:36 AM > To: Hu, Jiayu > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] doc: add GRO API requirement in > prog_guide > > On Tue, 18 Dec 2018 12:25:19 +080

Re: [dpdk-dev] [PATCH] net/ixgbe: add support of loopback for X540/X550

2019-01-07 Thread Zhao1, Wei
Hi,Meunier, Julien > -Original Message- > From: Meunier, Julien (Nokia - FR/Paris-Saclay) > [mailto:julien.meun...@nokia.com] > Sent: Tuesday, January 8, 2019 12:05 AM > To: Zhao1, Wei ; Ananyev, Konstantin > ; Lu, Wenzhuo > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: ad

Re: [dpdk-dev] [PATCH v4] mk: fix scope of disabling AVX512F support

2019-01-07 Thread Varghese, Vipin
diff --git a/doc/guides/rel_notes/known_issues.rst b/doc/guides/rel_notes/known_issues.rst index a1face9c1..b0057a2bc 100644 --- a/doc/guides/rel_notes/known_issues.rst +++ b/doc/guides/rel_notes/known_issues.rst @@ -826,3 +826,35 @@ Kernel crash when hot-unplug igb_uio device while DPDK applic

Re: [dpdk-dev] [EXT] Re: [PATCH] ethdev: report error on name truncation

2019-01-07 Thread Nithin Kumar Dabilpuram
Hi Thomas, Sorry, missed to notice that format changed by your commit recently got overridden during some of our internal branch merging. I'll send a v2 with same format. -- Thanks Nithin From: Thomas Monjalon Sent: Monday, January 7, 2019 8:20 PM To: Nithin Kumar Dabilpuram Cc: Ferruh Yigi

Re: [dpdk-dev] [EXT] Re: [PATCH] ethdev: report error on name truncation

2019-01-07 Thread Nithin Kumar Dabilpuram
Sure. Format change was unintentional and happened during internal merge, I’ll fix that and remove function name and send V2. -- Thanks Nithin From: Andrew Rybchenko Sent: Monday, January 7, 2019 8:17 PM To: Nithin Kumar Dabilpuram ; Thomas Monjalon ; Ferruh Yigit ; Andrew Rybchenko Cc: dev@

[dpdk-dev] [PATCH] gro: add missing invalid packet checks

2019-01-07 Thread Jiayu Hu
Currently, GRO library doesn't check if input packets have invalid headers. The packets with invalid headers will also be processed by GRO. However, GRO shouldn't process invalid packets. This patch adds missing invalid packet checks. Fixes: 0d2cbe59b719 ("lib/gro: support TCP/IPv4") Fixes: 9e0b9

Re: [dpdk-dev] [PATCH] gro: fix overflow of TCP Options length calculation

2019-01-07 Thread Stephen Hemminger
On Tue, 8 Jan 2019 01:22:18 + "Hu, Jiayu" wrote: > > -Original Message- > > From: Richardson, Bruce > > Sent: Monday, January 7, 2019 10:30 PM > > To: Hu, Jiayu > > Cc: dev@dpdk.org; Bie, Tiwei ; sta...@dpdk.org > > Subject: Re: [dpdk-dev] [PATCH] gro: fix overflow of TCP Options len

Re: [dpdk-dev] [PATCH] gro: add missing invalid packet checks

2019-01-07 Thread Stephen Hemminger
On Tue, 8 Jan 2019 14:08:45 +0800 Jiayu Hu wrote: > + /* > + * Don't process the packet whose Ethernet, IPv4 and TCP header > + * lengths are invalid. In addition, if the IPv4 header contains > + * Options, the packet shouldn't be processed. > + */ > + if (unlikely(IL