Re: [dpdk-dev] [PATCH v1] examples/l3fwd: enable hash multi lookup for ARM

2019-01-03 Thread Hemant Agrawal
On 02-Jan-19 11:53 PM, Honnappa Nagarahalli wrote: > Thanks Ruifeng for the patch. I have one question inline. > > Jerin/Hemant, > It would be good if you could test this on your platforms, since this > is being made default. > > Thanks, > Honnappa > >> -Original Message- >> From: R

Re: [dpdk-dev] [PATCH v5 1/3] test/ring: ring perf test case enhancement

2019-01-03 Thread Gavin Hu (Arm Technology China)
> -Original Message- > From: Thomas Monjalon > Sent: Thursday, January 3, 2019 3:40 PM > To: Gavin Hu (Arm Technology China) > Cc: dev@dpdk.org; nd ; jer...@marvell.com; > hemant.agra...@nxp.com; Honnappa Nagarahalli > ; olivier.m...@6wind.com; > bruce.richard...@intel.com; ferruh.yi..

Re: [dpdk-dev] [PATCH v3 3/3] net/mlx5: support flow counters using devx

2019-01-03 Thread Shahaf Shuler
Moti, Wednesday, January 2, 2019 11:43 AM, Mordechay Haimovsky: > Subject: [dpdk-dev] [PATCH v3 3/3] net/mlx5: support flow counters using devx > > This commit adds counters support when creating flows via direct verbs. The > implementation uses devx interface in order to create query and delete

[dpdk-dev] [PATCH] net/nfp: add CPP bridge as service

2019-01-03 Thread Alejandro Lucero
The Netronome's Network Flow Processor chip is highly programmable with the goal of processing packets at high speed. Processing units and other chip components are available from the host through the PCIe CPP(Command Push Pull bus) interface. The NFP PF PMD configures a CPP handler for setting up

[dpdk-dev] [PATCH] eal/atomic: reimplement rte atomic APIs with atomic builtins

2019-01-03 Thread Phil Yang
'__sync' builtins are deprecated, enable '__atomic' builtins for generic atomic operations. Signed-off-by: Phil Yang Reviewed-by: Gavin Hu Tested-by: Phil Yang --- lib/librte_eal/common/include/generic/rte_atomic.h | 80 ++ 1 file changed, 80 insertions(+) diff --git a/li

[dpdk-dev] [PATCH] packet_ordering: replace sync builtins with atomic builtins

2019-01-03 Thread Phil Yang
'__sync' builtins are deprecated, use '__atomic' builtins instead for packet_ordering. Fixes: 850f373 ("examples/packet_ordering: new sample app") Signed-off-by: Phil Yang Reviewed-by: Gavin Hu Reviewed-by: Ruifeng Wang --- examples/packet_ordering/main.c | 27 +++ 1

Re: [dpdk-dev] [PATCH 2/2] net/virtio-user: fix supported features list

2019-01-03 Thread Maxime Coquelin
On 1/3/19 3:40 AM, Tiwei Bie wrote: Currently virtio-user doesn't support event idx. Fixes: aea29aa5d37b ("net/virtio: enable packed virtqueues by default") Signed-off-by: Tiwei Bie --- drivers/net/virtio/virtio_user/virtio_user_dev.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(

Re: [dpdk-dev] [PATCH 1/2] net/virtio-user: fix packed vq option parsing

2019-01-03 Thread Maxime Coquelin
On 1/3/19 3:40 AM, Tiwei Bie wrote: Add the RING_PACKED feature to dev->unsupported_features when it's disabled, and add the missing packed vq param string. And also revert the unexpected change to MAC option introduced when adding packed vq option. Fixes: 34f3966c7f81 ("net/virtio-user: add

Re: [dpdk-dev] [PATCH v1] examples/l3fwd: enable hash multi lookup for ARM

2019-01-03 Thread Ruifeng Wang (Arm Technology China)
Hi Hemant, > -Original Message- > From: Hemant Agrawal > Sent: Thursday, January 3, 2019 16:05 > To: Honnappa Nagarahalli ; Ruifeng Wang > (Arm Technology China) ; dev@dpdk.org > Cc: tho...@monjalon.net; jer...@marvell.com; bruce.richard...@intel.com; > chao...@linux.vnet.ibm.com; nd ; >

[dpdk-dev] [PATCH] examples/l3fwd: support separate buffer pool per port

2019-01-03 Thread Shreyansh Jain
Traditionally, only a single buffer pool per port (or, per-port-per-socket) is created in l3fwd application. If separate pools are created per-port, it might lead to gain in performance as packet alloc/dealloc requests would be isolated across ports (and their corresponding lcores). This patch ad

[dpdk-dev] Only one Rx/Tx queue pair is assigned by DPDK PMD "net_bnxt" for BCM57414 VF

2019-01-03 Thread Vishnuvardhan Reddy Malispatel
Hi, I have a guest virtual machine attached with BCM57414 Virtual Function . - When the BCM VF is owned by Linux driver "bnxt_en", I am seeing two Rx/Tx queues are assigned by the driver. - When the same device is owned by DPDK PMD "net_bnxt" , I am seeing only one Rx/Tx

[dpdk-dev] [PATCH v2] eal: fix core number validation

2019-01-03 Thread Hari kumar Vemula
When incorrect core value or range provided, as part of -l command line option, a crash occurs. Added valid range checks to fix the crash. Fixes: d888cb8b9613 ("eal: add core list input format") Cc: sta...@dpdk.org -- v2: Replace strtoul with strtol Modified log message -- Signed-off-by: Ha

Re: [dpdk-dev] [PATCH] net/ice: fix build with debug enabled

2019-01-03 Thread Ferruh Yigit
On 12/27/2018 6:06 AM, Jerin Jacob Kollanukkaran wrote: > When RTE_LIBRTE_MBUF_DEBUG enabled, rte_mbuf_sanity_check() > function defined in rte_mbuf.so library, > add it while linking the librte_pmd_ice.so library to fix > the build issue. > > error log: > /usr/bin/ld: ice_rxtx.o: in function `ice

Re: [dpdk-dev] [PATCH v2] net/mlx5: add ConnectX-6 device IDs

2019-01-03 Thread Thomas Monjalon
01/01/2019 06:51, Shahaf Shuler: > Monday, December 31, 2018 2:44 PM, Wisam Monther: > > Subject: [PATCH v2] net/mlx5: add ConnectX-6 device IDs > > > > This commit includes the add of: > > - ConnectX-6 device ID > > - ConnectX-6 SRIOV device ID > > > > Signed-off-by: Wisam Jaddo > > Pay attent

Re: [dpdk-dev] [PATCH v2] eal: fix core number validation

2019-01-03 Thread David Marchand
On Thu, Jan 3, 2019 at 1:28 PM Hari kumar Vemula < hari.kumarx.vem...@intel.com> wrote: > When incorrect core value or range provided, > as part of -l command line option, a crash occurs. > > Added valid range checks to fix the crash. > > Fixes: d888cb8b9613 ("eal: add core list input format") > C

[dpdk-dev] [PATCH] doc: fix MAC address rewrite actions documentation

2019-01-03 Thread Dekel Peled
This patch fixes a typo in SET_MAC_DST action description. It also adds restriction note for set MAC src/dst actions description. Fixes: 15dbcdaada77 ("ethdev: add generic MAC address rewrite actions") Cc: jack...@mellanox.com Signed-off-by: Dekel Peled --- doc/guides/prog_guide/rte_flow.rst |

Re: [dpdk-dev] [PATCH] net/ixgbe: fix MAT enable for VF in multicast

2019-01-03 Thread Zhang, Qi Z
Hi Wei > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Wei Zhao > Sent: Wednesday, January 2, 2019 2:33 PM > To: dev@dpdk.org > Cc: sta...@dpdk.org; Wu, Jingjing ; Zhao1, Wei > > Subject: [dpdk-dev] [PATCH] net/ixgbe: fix MAT enable for VF in multicast What is

Re: [dpdk-dev] [PATCH] doc: fix a parameter name in testpmd guide

2019-01-03 Thread Iremonger, Bernard
Hi Rami, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Rami Rosen > Sent: Tuesday, December 25, 2018 1:37 PM > To: dev@dpdk.org > Cc: sta...@dpdk.org; Rami Rosen > Subject: [dpdk-dev] [PATCH] doc: fix a parameter name in testpmd guide > > There is no paramet

Re: [dpdk-dev] [PATCH] doc: fix a typo in testpmd user guide

2019-01-03 Thread Iremonger, Bernard
Hi Rami, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Rami Rosen > Sent: Thursday, December 27, 2018 7:59 PM > To: dev@dpdk.org > Cc: sta...@dpdk.org; wis...@mellanox.com; Rami Rosen > > Subject: [dpdk-dev] [PATCH] doc: fix a typo in testpmd user guide > >

Re: [dpdk-dev] [PATCH] doc: fix MAC address rewrite actions documentation

2019-01-03 Thread Ori Kam
PSB > -Original Message- > From: dev On Behalf Of Dekel Peled > Sent: Thursday, January 3, 2019 3:09 PM > To: Adrien Mazarguil > Cc: dev@dpdk.org; Ori Kam ; Dekel Peled > ; Jack Min > Subject: [dpdk-dev] [PATCH] doc: fix MAC address rewrite actions > documentation > > This patch fixes

[dpdk-dev] [PATCH v4 0/3] support flow counters using devx

2019-01-03 Thread Mordechay Haimovsky
This series of commits add support for creating, allocating, querying and destroying flow counters in mlx5 PMD using the devx interface. Moti Haimovsky (3): net/mlx5: fix shared counter allocation logic net/mlx5: add devx functions to glue net/mlx5: support flow counters using devx drivers

[dpdk-dev] [PATCH v4 1/3] net/mlx5: fix shared counter allocation logic

2019-01-03 Thread Mordechay Haimovsky
This commit fixes the logic for searching and allocating a shared counter in mlx5_flow_verbs. Now only the shared counters in the counters list are checked for a match and not all the counters as before. Fixes: 84c406e74524 ("net/mlx5: add flow translate function") Cc: sta...@dpdk.org Signed-off-

[dpdk-dev] [PATCH v4 2/3] net/mlx5: add devx functions to glue

2019-01-03 Thread Mordechay Haimovsky
This patch adds glue functions for operations: - dv_open_device. - devx object create, destroy, query and modify. - devx general command The new operations depend on HAVE_IBV_DEVX_OBJ. Signed-off-by: Moti Haimovsky --- v2: * Modifications according to review inputs. see message Id: 154574

[dpdk-dev] [PATCH v4 3/3] net/mlx5: support flow counters using devx

2019-01-03 Thread Mordechay Haimovsky
This commit adds counters support when creating flows via direct verbs. The implementation uses devx interface in order to create query and delete the counters. This support requires MLNX_OFED_LINUX-4.5-0.1.0.1 installation. Signed-off-by: Moti Haimovsky --- --- v2: * Modifications according to c

[dpdk-dev] [PATCH] net/softnic: add support for service cores

2019-01-03 Thread Cristian Dumitrescu
Add support to run the Soft NIC device on service cores, based on the value of the sc parameter: 0: The current Soft NIC device is run explicitly by the application. The firmware creates one or several pipelines for this dev and maps them to CPU cores that should not be service cores. The ap

[dpdk-dev] [PATCH v3] mk: fix scope of disabling AVX512F support

2019-01-03 Thread Ferruh Yigit
AVX512 was disabled for GCC because of Bugzilla issue 97 [1], the GCC defect submitted for the issue [2] highlighted that this is a known binutils version 2.30 issue. Narrowed the scope of no-avx512 to the this specific binutils version. [1] https://bugs.dpdk.org/show_bug.cgi?id=97 [2] https://g

Re: [dpdk-dev] [dpdk-stable] [PATCH] doc: fix a typo in testpmd user guide

2019-01-03 Thread Ferruh Yigit
On 1/3/2019 2:00 PM, Iremonger, Bernard wrote: > Hi Rami, > >> -Original Message- >> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Rami Rosen >> Sent: Thursday, December 27, 2018 7:59 PM >> To: dev@dpdk.org >> Cc: sta...@dpdk.org; wis...@mellanox.com; Rami Rosen >> >> Subject: [dpd

[dpdk-dev] [PATCH] app/test-pmd: stop all ports before any close

2019-01-03 Thread Cristian Dumitrescu
This patch proposes a slightly different test-pmd quit operation: stop all devices before starting to close any device. Basically, stop all moving parts before beginning to remove them. The current test-pmd quit is stoping and closing each device before moving to the next device. If all devices in

Re: [dpdk-dev] [PATCH v2] net/mlx5: add ConnectX-6 device IDs

2019-01-03 Thread Ferruh Yigit
On 1/3/2019 12:49 PM, Thomas Monjalon wrote: > 01/01/2019 06:51, Shahaf Shuler: >> Monday, December 31, 2018 2:44 PM, Wisam Monther: >>> Subject: [PATCH v2] net/mlx5: add ConnectX-6 device IDs >>> >>> This commit includes the add of: >>> - ConnectX-6 device ID >>> - ConnectX-6 SRIOV device ID >>> >

Re: [dpdk-dev] VF of a X520 card does not process VLAN packets

2019-01-03 Thread Eelco Chaudron
Hi maintainers, any feedback on the below? Thanks, Eelco On 18 Dec 2018, at 12:06, Eelco Chaudron wrote: Hi, I’m assigning a VF of an X520 card for DPDK/testpmd/OVS but it's not accepting tagged VLAN packets (it does accept tag 0). Is this a known bug/limitation of the 82599ES chipset?

Re: [dpdk-dev] Compiler for Windows

2019-01-03 Thread Jason Messer
+Jeffrey, Manasi We will get the most traction from the Windows developer community if we use msvc. The only thing preventing that last time was GNU extensions used in DPDK source which were not ISO C standards compliant. We were also experimenting with Clang/LLVM running natively on Windows ho

Re: [dpdk-dev] Compiler for Windows

2019-01-03 Thread Thomas Monjalon
Hi Jason, We need to get facts in order to do a good decision. Please, let's give detailed feedback for each option. 03/01/2019 18:10, Jason Messer: > +Jeffrey, Manasi > > We will get the most traction from the Windows developer community > if we use msvc. The only thing preventing that last tim

[dpdk-dev] [PATCH 2/2] build: use dependency() instead of find_library()

2019-01-03 Thread Luca Boccassi
Whenever possible (if the library ships a pkg-config file) use meson's dependency() function to look for it, as it will automatically add it to the Requires.private list if needed, to allow for static builds to succeed for reverse dependencies of DPDK. Otherwise the recursive dependencies are not p

[dpdk-dev] [PATCH 1/2] build: use static deps of libs for pkg-config libs.private

2019-01-03 Thread Luca Boccassi
Dependencies of the RTE libraries were not being added to the Requires.private field of the pc file since the variable used for dynamic linking was passed to the related field of pkg.generate. Use the static one so that dependencies are included. Fixes: 57ae0ec62620 ("build: add dependency on tele

Re: [dpdk-dev] [EXT] [PATCH v3 3/6] test/spinlock: get timestamp more precisely

2019-01-03 Thread Honnappa Nagarahalli
> > On Thu, 2018-12-27 at 12:13 +0800, Gavin Hu wrote: > > --- > > --- > > To precisely benchmark the spinlock performance, uses the precise > > version of getting timestamps, which enforces the timestamps are > > obtained at the expe

Re: [dpdk-dev] [EXT] [PATCH v3 6/6] spinlock: ticket based to improve fairness

2019-01-03 Thread Honnappa Nagarahalli
> > > > > > > > > > On Thu, 2018-12-27 at 12:13 +0800, Gavin Hu wrote: > > > > > > --- > > > > > > > > > > > > > > > > > > --- > > > > > > From: Joyce Kong > > > > > > > > > > > > The old implementation is unfair, some threads may t

Re: [dpdk-dev] [EXT] [PATCH v3 6/6] spinlock: ticket based to improve fairness

2019-01-03 Thread Stephen Hemminger
On Thu, 3 Jan 2019 18:35:31 + Honnappa Nagarahalli wrote: > > > > > > > > > > > > On Thu, 2018-12-27 at 12:13 +0800, Gavin Hu wrote: > > > > > > > --- > > > > > > > > > > > > > > > > > > > > > --- > > > > > > > From: Joyce Ko

[dpdk-dev] [PATCH v6 01/10] cryptodev: add opaque userdata pointer into crypto sym session

2019-01-03 Thread Konstantin Ananyev
Add 'uint64_t opaque_data' inside struct rte_cryptodev_sym_session. That allows upper layer to easily associate some user defined data with the session. Signed-off-by: Konstantin Ananyev Acked-by: Fiona Trahe Acked-by: Mohammad Abdul Awal Acked-by: Declan Doherty Acked-by: Akhil Goyal --- li

[dpdk-dev] [PATCH v6 00/10] ipsec: new library for IPsec data-path processing

2019-01-03 Thread Konstantin Ananyev
v5 -> v6 - Fix issues reported by Akhil: rte_ipsec_session_prepare() fails for lookaside-proto v4 -> v5 - Fix issue with SQN overflows - Address Akhil comments: documentation update spell checks spacing etc. fix input crypto_xform check/prepcess test cases for lookaside

[dpdk-dev] [PATCH v6 02/10] security: add opaque userdata pointer into security session

2019-01-03 Thread Konstantin Ananyev
Add 'uint64_t opaque_data' inside struct rte_security_session. That allows upper layer to easily associate some user defined data with the session. Signed-off-by: Konstantin Ananyev Acked-by: Mohammad Abdul Awal Acked-by: Declan Doherty Acked-by: Akhil Goyal --- lib/librte_security/rte_securi

[dpdk-dev] [PATCH v6 03/10] net: add ESP trailer structure definition

2019-01-03 Thread Konstantin Ananyev
define esp_tail structure. Signed-off-by: Konstantin Ananyev Acked-by: Mohammad Abdul Awal Acked-by: Declan Doherty Acked-by: Akhil Goyal --- lib/librte_net/rte_esp.h | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/lib/librte_net/rte_esp.h b/lib/librte_net/rte_es

[dpdk-dev] [PATCH v6 06/10] ipsec: implement SA data-path API

2019-01-03 Thread Konstantin Ananyev
Provide implementation for rte_ipsec_pkt_crypto_prepare() and rte_ipsec_pkt_process(). Current implementation: - supports ESP protocol tunnel mode. - supports ESP protocol transport mode. - supports ESN and replay window. - supports algorithms: AES-CBC, AES-GCM, HMAC-SHA1, NULL. - covers all c

[dpdk-dev] [PATCH v6 07/10] ipsec: rework SA replay window/SQN for MT environment

2019-01-03 Thread Konstantin Ananyev
With these changes functions: - rte_ipsec_pkt_crypto_prepare - rte_ipsec_pkt_process can be safely used in MT environment, as long as the user can guarantee that they obey multiple readers/single writer model for SQN+replay_window operations. To be more specific: for outbound SA there are

[dpdk-dev] [PATCH v6 08/10] ipsec: helper functions to group completed crypto-ops

2019-01-03 Thread Konstantin Ananyev
Introduce helper functions to process completed crypto-ops and group related packets by sessions they belong to. Signed-off-by: Konstantin Ananyev Acked-by: Declan Doherty --- lib/librte_ipsec/Makefile | 1 + lib/librte_ipsec/meson.build | 2 +- lib/librte_ipsec/rte_i

[dpdk-dev] [PATCH v6 04/10] lib: introduce ipsec library

2019-01-03 Thread Konstantin Ananyev
Introduce librte_ipsec library. The library is supposed to utilize existing DPDK crypto-dev and security API to provide application with transparent IPsec processing API. That initial commit provides some base API to manage IPsec Security Association (SA) object. Signed-off-by: Mohammad Abdul Awal

[dpdk-dev] [PATCH v6 05/10] ipsec: add SA data-path API

2019-01-03 Thread Konstantin Ananyev
Introduce Security Association (SA-level) data-path API Operates at SA level, provides functions to: - initialize/teardown SA object - process inbound/outbound ESP/AH packets associated with the given SA (decrypt/encrypt, authenticate, check integrity, add/remove ESP/AH related

[dpdk-dev] [PATCH v6 10/10] doc: add IPsec library guide

2019-01-03 Thread Konstantin Ananyev
Add IPsec library guide and update release notes. Signed-off-by: Bernard Iremonger Signed-off-by: Konstantin Ananyev --- doc/guides/prog_guide/index.rst| 1 + doc/guides/prog_guide/ipsec_lib.rst| 168 + doc/guides/rel_notes/release_19_02.rst | 11 ++ 3 fil

[dpdk-dev] [PATCH v6 09/10] test/ipsec: introduce functional test

2019-01-03 Thread Konstantin Ananyev
Create functional test for librte_ipsec. Note that the test requires null crypto pmd to pass successfully. Signed-off-by: Mohammad Abdul Awal Signed-off-by: Bernard Iremonger Acked-by: Declan Doherty Signed-off-by: Konstantin Ananyev --- test/test/Makefile |3 + test/test/meson.build

[dpdk-dev] [PATCH v6 00/10] examples/ipsec-secgw: make app to use ipsec library

2019-01-03 Thread Konstantin Ananyev
This patch series depends on the patch series: ipsec: new library for IPsec data-path processing http://patches.dpdk.org/patch/49410/ http://patches.dpdk.org/patch/49411/ http://patches.dpdk.org/patch/49412/ http://patches.dpdk.org/patch/49413/ http://patches.dpdk.org/patch/49414/ http://patches.d

[dpdk-dev] [PATCH v6 01/10] examples/ipsec-secgw: allow user to disable some RX/TX offloads

2019-01-03 Thread Konstantin Ananyev
Right now ipsec-secgw always enables TX offloads (DEV_TX_OFFLOAD_MULTI_SEGS, DEV_TX_OFFLOAD_SECURITY), even when they are not requested by the config. That causes many PMD to choose full-featured TX function, which in many cases is much slower then one without offloads. That patch adds ability for

[dpdk-dev] [PATCH v6 02/10] examples/ipsec-secgw: allow to specify neighbour mac address

2019-01-03 Thread Konstantin Ananyev
In some cases it is useful to allow user to specify destination ether address for outgoing packets. This patch adds such ability by introducing new 'neigh' config file option. Signed-off-by: Konstantin Ananyev Acked-by: Radu Nicolau --- doc/guides/sample_app_ug/ipsec_secgw.rst | 42 ++-

[dpdk-dev] [PATCH v6 03/10] examples/ipsec-secgw: fix crypto-op might never get dequeued

2019-01-03 Thread Konstantin Ananyev
In some cases crypto-ops could never be dequeued from the crypto-device. The easiest way to reproduce: start ipsec-secgw with crypto-dev and send to it less then 32 packets. none packets will be forwarded. Reason for that is that the application does dequeue() from crypto-queues only when new packe

[dpdk-dev] [PATCH v6 06/10] examples/ipsec-secgw: fix inbound SA checking

2019-01-03 Thread Konstantin Ananyev
In the inbound_sa_check() make sure that sa pointer stored inside mbuf private area is not NULL. Fixes: d299106e8e31 ("examples/ipsec-secgw: add IPsec sample application") Cc: sta...@dpdk.org Signed-off-by: Bernard Iremonger Acked-by: Radu Nicolau Signed-off-by: Konstantin Ananyev --- example

[dpdk-dev] [PATCH v6 08/10] examples/ipsec-secgw: make data-path to use ipsec library

2019-01-03 Thread Konstantin Ananyev
Changes to make ipsec-secgw data-path code to utilize librte_ipsec library. Note that right now by default current (non-librte_ipsec) code-path will be used. User has to run application with new command-line option ('-l') to enable new codepath. Signed-off-by: Mohammad Abdul Awal Signed-off-by: B

[dpdk-dev] [PATCH v6 04/10] examples/ipsec-secgw: fix outbound codepath for single SA

2019-01-03 Thread Konstantin Ananyev
Looking at process_pkts_outbound_nosp() there seems few issues: - accessing mbuf after it was freed - invoking ipsec_outbound() for ipv4 packets only - copying number of packets, but not the mbuf pointers itself that patch provides fixes for that issues. Fixes: 906257e965b7 ("examples/ipsec-secgw

[dpdk-dev] [PATCH v6 05/10] examples/ipsec-secgw: make local variables static

2019-01-03 Thread Konstantin Ananyev
in sp4.c and sp6.c there are few globals that used only locally. Define them as static ones. Cc: sta...@dpdk.org Signed-off-by: Konstantin Ananyev Acked-by: Radu Nicolau --- examples/ipsec-secgw/sp4.c | 10 +- examples/ipsec-secgw/sp6.c | 10 +- 2 files changed, 10 insertions(+

[dpdk-dev] [PATCH v6 07/10] examples/ipsec-secgw: make app to use ipsec library

2019-01-03 Thread Konstantin Ananyev
Changes to make ipsec-secgw to utilize librte_ipsec library. That patch provides: - changes in the related data structures. - changes in the initialization code. - new command-line parameters to enable librte_ipsec codepath and related features. Note that right now by default current (non-li

[dpdk-dev] [PATCH v6 09/10] examples/ipsec-secgw: add scripts for functional test

2019-01-03 Thread Konstantin Ananyev
The purpose of these scripts is to automate ipsec-secgw functional testing. The scripts require two machines (SUT and DUT) connected through at least 2 NICs and running linux (so far tested only on Ubuntu 18.04). Introduced test-cases for the following scenarios: - Transport/Tunnel modes - AES-CBC

[dpdk-dev] [PATCH v6 10/10] doc: update ipsec-secgw guide and relelase notes

2019-01-03 Thread Konstantin Ananyev
Update ipsec-secgw guide and relelase notes to reflect latest changes. Signed-off-by: Bernard Iremonger Signed-off-by: Konstantin Ananyev --- doc/guides/rel_notes/release_19_02.rst | 14 +++ doc/guides/sample_app_ug/ipsec_secgw.rst | 105 ++- 2 files changed, 117 insertio

Re: [dpdk-dev] [EXT] [PATCH v3 5/6] spinlock: reimplement with atomic one-way barrier builtins

2019-01-03 Thread Honnappa Nagarahalli
> > > > On Thu, 2018-12-27 at 12:13 +0800, Gavin Hu wrote: > > --- > > > --- > > > The __sync builtin based implementation generates full memory > > > barriers ('dmb ish') on Arm platforms. Using C11 atomic builtins to > > > generate o

Re: [dpdk-dev] [PATCH v5 03/10] examples/ipsec-secgw: fix crypto-op might never get dequeued

2019-01-03 Thread Ananyev, Konstantin
Hi Akhil, > >>> In some cases crypto-ops could never be dequeued from the crypto-device. > >>> The easiest way to reproduce: > >>> start ipsec-secgw with crypto-dev and send to it less then 32 packets. > >>> none packets will be forwarded. > >>> Reason for that is that the application does dequeue

Re: [dpdk-dev] [PATCH v3] mk: fix scope of disabling AVX512F support

2019-01-03 Thread Yongseok Koh
> On Jan 3, 2019, at 8:23 AM, Ferruh Yigit wrote: > > AVX512 was disabled for GCC because of Bugzilla issue 97 [1], > the GCC defect submitted for the issue [2] highlighted that this is > a known binutils version 2.30 issue. > > Narrowed the scope of no-avx512 to the this specific binutils ver

Re: [dpdk-dev] Compiler for Windows

2019-01-03 Thread Wiles, Keith
> On Jan 3, 2019, at 11:10 AM, Jason Messer wrote: > > +Jeffrey, Manasi > > We will get the most traction from the Windows developer community if we use > msvc. The only thing preventing that last time was GNU extensions used in > DPDK source which were not ISO C standards compliant. We were

Re: [dpdk-dev] [PATCH v6 01/10] cryptodev: add opaque userdata pointer into crypto sym session

2019-01-03 Thread Stephen Hemminger
On Thu, 3 Jan 2019 20:16:17 + Konstantin Ananyev wrote: > Add 'uint64_t opaque_data' inside struct rte_cryptodev_sym_session. > That allows upper layer to easily associate some user defined > data with the session. > > Signed-off-by: Konstantin Ananyev > Acked-by: Fiona Trahe > Acked-by:

[dpdk-dev] [PATCH] gro: fix overflow of TCP Options length calculation

2019-01-03 Thread Jiayu Hu
If we receive a packet with an invalid TCP header, whose TCP header length is less than 20 bytes (the minimal TCP header length), the calculated TCP Options length will overflow and result in incorrect reassembly behaviors. Fixes: 0d2cbe59b719 ("lib/gro: support TCP/IPv4") Fixes: 9e0b9d2ec0f4 ("gr

Re: [dpdk-dev] [PATCH v3] mk: fix scope of disabling AVX512F support

2019-01-03 Thread Varghese, Vipin
Hi Ferruh, Should not be there a documentation update in 'Known Issues and Limitations in Legacy Releases' for the limitation. If it is already added can you please add the patchwork link for the same. Thanks Vipin Varghese > -Original Message- > From: dev On Behalf Of Yongseok Koh >

Re: [dpdk-dev] [PATCH v6 10/10] doc: update ipsec-secgw guide and relelase notes

2019-01-03 Thread Varghese, Vipin
Hi Konstantin, Sharing information with respect to documentation and code update with respect to rel 19.02-rc1 onwards 'it is now required to combine both code and documentation into a single patch'. Thanks Vipin Varghese > -Original Message- > From: dev On Behalf Of Konstantin Ananye

[dpdk-dev] [Bug 177] binding i40e with uio_pci_generic fails for DPDK 19.02.0-rc1

2019-01-03 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=177 Bug ID: 177 Summary: binding i40e with uio_pci_generic fails for DPDK 19.02.0-rc1 Product: DPDK Version: 18.11 Hardware: All OS: All Status: CONFIRMED

[dpdk-dev] [PATCH 0/6] Some fixes for vhost

2019-01-03 Thread Tiwei Bie
Tiwei Bie (6): vhost: fix desc access in relay helpers vhost: fix possible out of bound access in relay helpers vhost: fix possible dead loop in relay helpers vhost: fix possible out of bound access in vector filling vhost: fix possible dead loop in vector filling vhost: ensure event id

[dpdk-dev] [PATCH 2/6] vhost: fix possible out of bound access in relay helpers

2019-01-03 Thread Tiwei Bie
Fixes: b13ad2decc83 ("vhost: provide helpers for virtio ring relay") Signed-off-by: Tiwei Bie --- lib/librte_vhost/vdpa.c | 27 ++- 1 file changed, 22 insertions(+), 5 deletions(-) diff --git a/lib/librte_vhost/vdpa.c b/lib/librte_vhost/vdpa.c index 77d92f9ad..407d1c363

[dpdk-dev] [PATCH 3/6] vhost: fix possible dead loop in relay helpers

2019-01-03 Thread Tiwei Bie
Fix a possible dead loop which may happen, e.g. when driver created a loop in the desc list. Fixes: b13ad2decc83 ("vhost: provide helpers for virtio ring relay") Signed-off-by: Tiwei Bie --- lib/librte_vhost/vdpa.c | 16 1 file changed, 16 insertions(+) diff --git a/lib/librte

[dpdk-dev] [PATCH 5/6] vhost: fix possible dead loop in vector filling

2019-01-03 Thread Tiwei Bie
Fix a possible dead loop which may happen, e.g. when driver created a loop in the desc list and lens in descs are zero. Fixes: fd68b4739d2c ("vhost: use buffer vectors in dequeue path") Fixes: 2f3225a7d69b ("vhost: add vector filling support for packed ring") Cc: sta...@dpdk.org Signed-off-by: Ti

[dpdk-dev] [PATCH 1/6] vhost: fix desc access in relay helpers

2019-01-03 Thread Tiwei Bie
Descs in desc table should be indexed using the desc idx instead of the idx of avail ring and used ring. Fixes: b13ad2decc83 ("vhost: provide helpers for virtio ring relay") Signed-off-by: Tiwei Bie --- lib/librte_vhost/vdpa.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-)

[dpdk-dev] [PATCH 6/6] vhost: ensure event idx is mapped when negotiated

2019-01-03 Thread Tiwei Bie
Fixes: 30920b1e2b15 ("vhost: ensure all range is mapped when translating QVAs") Cc: sta...@dpdk.org Signed-off-by: Tiwei Bie --- lib/librte_vhost/vhost_user.c | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/lib/librte_vhost/vhost_user.c b/lib/librte_vhost/vhos

[dpdk-dev] [PATCH 4/6] vhost: fix possible out of bound access in vector filling

2019-01-03 Thread Tiwei Bie
Fixes: 7f74b95c444f ("vhost: pre update used ring for Tx and Rx") Cc: sta...@dpdk.org Signed-off-by: Tiwei Bie --- lib/librte_vhost/virtio_net.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lib/librte_vhost/virtio_net.c b/lib/librte_vhost/virtio_net.c index 474acf64d..d64c355b9 100644

[dpdk-dev] [Bug 178] l2fwd application does not work with option '-q'

2019-01-03 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=178 Bug ID: 178 Summary: l2fwd application does not work with option '-q' Product: DPDK Version: 18.11 Hardware: All OS: All Status: CONFIRMED Severity: normal

Re: [dpdk-dev] [PATCH v3 2/2] doc: add guide for debug and troubleshoot

2019-01-03 Thread Shreyansh Jain
Hello Vipin, Some comments and lots of nitpicks inlined. (I know this comes months late - apologies, just didn't stumble on this earlier). On Monday 26 November 2018 12:38 PM, Vipin Varghese wrote: > Add user guide on debug and troubleshoot for common issues and bottleneck > found in various app

Re: [dpdk-dev] [PATCH v3 2/2] doc: add guide for debug and troubleshoot

2019-01-03 Thread Varghese, Vipin
Hi Shreyansh jain, Thanks for the comment, please give me time to look into other comments. snipped > > +- Are only specific MAC are received? rte_eth_promiscuous_get() > ^^^ >can be removed > > What about checking vlan-filters

Re: [dpdk-dev] [EXT] [PATCH v3 6/6] spinlock: ticket based to improve fairness

2019-01-03 Thread Honnappa Nagarahalli
> > On Thu, 3 Jan 2019 18:35:31 + > Honnappa Nagarahalli wrote: > > > > > > > > > > > > > > > On Thu, 2018-12-27 at 12:13 +0800, Gavin Hu wrote: > > > > > > > > -- > > > > > > > > - > > > > > > > > > > > > > > > > > > > > > >

[dpdk-dev] [PATCH v3] doc: add GRO API limitations in prog_guide

2019-01-03 Thread Jiayu Hu
This patch adds GRO API limitations in the programmer guide. Fixes: 2c900d09055e ("doc: add GRO guide") Fixes: 9e0b9d2ec0f4 ("gro: support VxLAN GRO") Cc: sta...@dpdk.org Signed-off-by: Jiayu Hu --- changes in v3: - add fix versions - add more limitations - add MBUF limitation doc/guides/prog_