Re: [dpdk-dev] [EXT] [PATCH v3 6/6] spinlock: ticket based to improve fairness

> -Original Message- > From: Jerin Jacob Kollanukkaran > Sent: Friday, December 28, 2018 12:39 PM > To: step...@networkplumber.org > Cc: david.march...@redhat.com; chao...@linux.vnet.ibm.com; nd > ; bruce.richard...@intel.com; tho...@monjalon.net; > dev@dpdk.org; Joyce Kong (Arm Technolo

[dpdk-dev] [PATCH] libs/power: fix the resource leaking issue

Fixes: e6c6dc0f96c8 ("power: add p-state driver compatibility") Coverity issue: 328528 Also add the missing functionality of enable/disable turbo Signed-off-by: Liang Ma --- lib/librte_power/power_pstate_cpufreq.c | 34 - 1 file changed, 33 insertions(+), 1 delet

[dpdk-dev] [PATCH v5 00/10] ipsec: new library for IPsec data-path processing

v4 -> v5 - Fix issue with SQN overflows - Address Akhil comments: documentation update spell checks spacing etc. fix input crypto_xform check/prepcess test cases for lookaside and inline proto v3 -> v4 - Changes to adress Declan comments - Update docs v2 -> v3 - Several f

[dpdk-dev] [PATCH v5 02/10] security: add opaque userdata pointer into security session

Add 'uint64_t opaque_data' inside struct rte_security_session. That allows upper layer to easily associate some user defined data with the session. Signed-off-by: Konstantin Ananyev Acked-by: Mohammad Abdul Awal Acked-by: Declan Doherty Acked-by: Akhil Goyal --- lib/librte_security/rte_securi

[dpdk-dev] [PATCH v5 04/10] lib: introduce ipsec library

Introduce librte_ipsec library. The library is supposed to utilize existing DPDK crypto-dev and security API to provide application with transparent IPsec processing API. That initial commit provides some base API to manage IPsec Security Association (SA) object. Signed-off-by: Mohammad Abdul Awal

[dpdk-dev] [PATCH v5 01/10] cryptodev: add opaque userdata pointer into crypto sym session

Add 'uint64_t opaque_data' inside struct rte_cryptodev_sym_session. That allows upper layer to easily associate some user defined data with the session. Signed-off-by: Konstantin Ananyev Acked-by: Fiona Trahe Acked-by: Mohammad Abdul Awal Acked-by: Declan Doherty Acked-by: Akhil Goyal --- li

[dpdk-dev] [PATCH v5 03/10] net: add ESP trailer structure definition

Signed-off-by: Konstantin Ananyev Acked-by: Mohammad Abdul Awal Acked-by: Declan Doherty Acked-by: Akhil Goyal --- lib/librte_net/rte_esp.h | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/lib/librte_net/rte_esp.h b/lib/librte_net/rte_esp.h index f77ec2eb2..8e1b3d2

[dpdk-dev] [PATCH v5 05/10] ipsec: add SA data-path API

Introduce Security Association (SA-level) data-path API Operates at SA level, provides functions to: - initialize/teardown SA object - process inbound/outbound ESP/AH packets associated with the given SA (decrypt/encrypt, authenticate, check integrity, add/remove ESP/AH related

[dpdk-dev] [PATCH v5 06/10] ipsec: implement SA data-path API

Provide implementation for rte_ipsec_pkt_crypto_prepare() and rte_ipsec_pkt_process(). Current implementation: - supports ESP protocol tunnel mode. - supports ESP protocol transport mode. - supports ESN and replay window. - supports algorithms: AES-CBC, AES-GCM, HMAC-SHA1, NULL. - covers all c

[dpdk-dev] [PATCH v5 08/10] ipsec: helper functions to group completed crypto-ops

Introduce helper functions to process completed crypto-ops and group related packets by sessions they belong to. Signed-off-by: Konstantin Ananyev Acked-by: Declan Doherty --- lib/librte_ipsec/Makefile | 1 + lib/librte_ipsec/meson.build | 2 +- lib/librte_ipsec/rte_i

[dpdk-dev] [PATCH v5 10/10] doc: add IPsec library guide

Add IPsec library guide and update release notes. Signed-off-by: Bernard Iremonger Signed-off-by: Konstantin Ananyev --- doc/guides/prog_guide/index.rst| 1 + doc/guides/prog_guide/ipsec_lib.rst| 168 + doc/guides/rel_notes/release_19_02.rst | 11 ++ 3 fil

[dpdk-dev] [PATCH v5 09/10] test/ipsec: introduce functional test

Create functional test for librte_ipsec. Note that the test requires null crypto pmd to pass successfully. Signed-off-by: Mohammad Abdul Awal Signed-off-by: Bernard Iremonger Acked-by: Declan Doherty Signed-off-by: Konstantin Ananyev --- test/test/Makefile |3 + test/test/meson.build

[dpdk-dev] [PATCH v5 07/10] ipsec: rework SA replay window/SQN for MT environment

With these changes functions: - rte_ipsec_pkt_crypto_prepare - rte_ipsec_pkt_process can be safely used in MT environment, as long as the user can guarantee that they obey multiple readers/single writer model for SQN+replay_window operations. To be more specific: for outbound SA there are

[dpdk-dev] [PATCH v5 00/10] examples/ipsec-secgw: make app to use ipsec library

This patch series depends on the patch series: ipsec: new library for IPsec data-path processing http://patches.dpdk.org/patch/49332/ http://patches.dpdk.org/patch/49333/ http://patches.dpdk.org/patch/49334/ http://patches.dpdk.org/patch/49335/ http://patches.dpdk.org/patch/49336/ http://patches.d

[dpdk-dev] [PATCH v5 01/10] examples/ipsec-secgw: allow user to disable some RX/TX offloads

Right now ipsec-secgw always enables TX offloads (DEV_TX_OFFLOAD_MULTI_SEGS, DEV_TX_OFFLOAD_SECURITY), even when they are not requested by the config. That causes many PMD to choose full-featured TX function, which in many cases is much slower then one without offloads. That patch adds ability for

[dpdk-dev] [PATCH v5 02/10] examples/ipsec-secgw: allow to specify neighbour mac address

In some cases it is useful to allow user to specify destination ether address for outgoing packets. This patch adds such ability by introducing new 'neigh' config file option. Signed-off-by: Konstantin Ananyev Acked-by: Radu Nicolau --- doc/guides/sample_app_ug/ipsec_secgw.rst | 42 ++-

[dpdk-dev] [PATCH v5 03/10] examples/ipsec-secgw: fix crypto-op might never get dequeued

In some cases crypto-ops could never be dequeued from the crypto-device. The easiest way to reproduce: start ipsec-secgw with crypto-dev and send to it less then 32 packets. none packets will be forwarded. Reason for that is that the application does dequeue() from crypto-queues only when new packe

[dpdk-dev] [PATCH v5 04/10] examples/ipsec-secgw: fix outbound codepath for single SA

Looking at process_pkts_outbound_nosp() there seems few issues: - accessing mbuf after it was freed - invoking ipsec_outbound() for ipv4 packets only - copying number of packets, but not the mbuf pointers itself that patch provides fixes for that issues. Fixes: 906257e965b7 ("examples/ipsec-secgw

[dpdk-dev] [PATCH v5 05/10] examples/ipsec-secgw: make local variables static

in sp4.c and sp6.c there are few globals that used only locally. Define them as static ones. Cc: sta...@dpdk.org Signed-off-by: Konstantin Ananyev Acked-by: Radu Nicolau --- examples/ipsec-secgw/sp4.c | 10 +- examples/ipsec-secgw/sp6.c | 10 +- 2 files changed, 10 insertions(+

[dpdk-dev] [PATCH v5 06/10] examples/ipsec-secgw: fix inbound SA checking

In the inbound_sa_check() make sure that sa pointer stored inside mbuf private area is not NULL. Fixes: d299106e8e31 ("examples/ipsec-secgw: add IPsec sample application") Cc: sta...@dpdk.org Signed-off-by: Bernard Iremonger Acked-by: Radu Nicolau Signed-off-by: Konstantin Ananyev --- example

[dpdk-dev] [PATCH v5 08/10] examples/ipsec-secgw: make data-path to use ipsec library

Changes to make ipsec-secgw data-path code to utilize librte_ipsec library. Note that right now by default current (non-librte_ipsec) code-path will be used. User has to run application with new command-line option ('-l') to enable new codepath. Signed-off-by: Mohammad Abdul Awal Signed-off-by: B

[dpdk-dev] [PATCH v5 10/10] doc: update ipsec-secgw guide and relelase notes

Update ipsec-secgw guide and relelase notes to reflect latest changes. Signed-off-by: Bernard Iremonger Signed-off-by: Konstantin Ananyev --- doc/guides/rel_notes/release_19_02.rst | 14 +++ doc/guides/sample_app_ug/ipsec_secgw.rst | 105 ++- 2 files changed, 117 insertio

[dpdk-dev] [PATCH v5 07/10] examples/ipsec-secgw: make app to use ipsec library

Changes to make ipsec-secgw to utilize librte_ipsec library. That patch provides: - changes in the related data structures. - changes in the initialization code. - new command-line parameters to enable librte_ipsec codepath and related features. Note that right now by default current (non-li

[dpdk-dev] [PATCH v5 09/10] examples/ipsec-secgw: add scripts for functional test

The purpose of these scripts is to automate ipsec-secgw functional testing. The scripts require two machines (SUT and DUT) connected through at least 2 NICs and running linux (so far tested only on Ubuntu 18.04). Introduced test-cases for the following scenarios: - Transport/Tunnel modes - AES-CBC

[dpdk-dev] unimplemented API heads-up notice

Hi everyone, As you probably know, all un-implemented API inside DPDK planned to be deprecated in 19.05 and removed in 19.08. For more details, please refer to: https://mails.dpdk.org/archives/dev/2018-November/118697.html Below is the list (probably incomplete) of currently un-implemented API.

[dpdk-dev] [PATCH v3] net/i40e: fix get RSS conf issue

rte_eth_dev_rss_hash_conf_get API doesn't force 'rss_conf.rss_key' to be not NULL, so rss_key = NULL should be allowed in i40e driver. Fixes: 16321de09396 ("ethdev: allow to get RSS hash functions and key") Cc: sta...@dpdk.org Change-Id: I992847995cac44172694ea15ab30c4d1e7e48957 Signed-off-by: Qi

Re: [dpdk-dev] [PATCH 1/3] eal: add --dev-hotplug option

hi, david On 12/17/2018 6:15 PM, David Marchand wrote: On Fri, Dec 14, 2018 at 8:41 AM Jeff Guo > wrote: This command-line option will enable hotplug event detecting and enable hotplug handling for device hotplug. Signed-off-by: Jeff Guo mailto:jia..