Re: [dpdk-dev] [PATCH v5 1/3] crypto/openssl: add rsa and mod asym op

2018-11-15 Thread Verma, Shally
>-Original Message- >From: Mcnamara, John >Sent: 14 November 2018 20:35 >To: Sahu, Sunila >Cc: dev@dpdk.org; Athreya, Narayana Prasad >; Murthy, Nidadavolu >; Gupta, Ashish ; De >Lara Guarch, Pablo >; Verma, Shally >Subject: RE: [dpdk-dev] [PATCH v5 1/3] crypto/openssl: add rsa and

Re: [dpdk-dev] [PATCH v3 3/5] common: add missing implementations

2018-11-15 Thread Jerin Jacob
-Original Message- > Date: Wed, 14 Nov 2018 16:47:08 + > From: Anatoly Burakov > To: dev@dpdk.org > CC: cristian.dumitre...@intel.com, tho...@monjalon.net, > bruce.richard...@intel.com, ferruh.yi...@intel.com, > jasvinder.si...@intel.com > Subject: [dpdk-dev] [PATCH v3 3/5] common: a

Re: [dpdk-dev] [PATCH 1/2] net/mlx4: fix initialization of struct members

2018-11-15 Thread Shahaf Shuler
Tuesday, November 13, 2018 9:11 PM, Ali Alnubani: > Subject: [PATCH 1/2] net/mlx4: fix initialization of struct members > > This patch fixes compilation errors with meson and the clang compiler caused > by some of the struct members not being initialized. > > ``` > ../drivers/net/mlx4/mlx4_mr.c:3

Re: [dpdk-dev] [PATCH] net/mlx5: fix flow query routine in Direct Verbs

2018-11-15 Thread Shahaf Shuler
Wednesday, November 14, 2018 3:47 PM, Slava Ovsiienko: > Subject: [PATCH] net/mlx5: fix flow query routine in Direct Verbs > > From: Viacheslav Ovsiienko viachesl...@mellanox.com> > > The flow_dv_query() just returns -ENOTSUP value and does not set provided > error parameter structure, that cras

Re: [dpdk-dev] [PATCH] net/mlx5: fix flow destruction

2018-11-15 Thread Shahaf Shuler
Thursday, November 15, 2018 7:24 AM, Yongseok Koh: > > Subject: [PATCH] net/mlx5: fix flow destruction > > As flow_drv_destroy() frees dev_flow, flow_rxq_flags_trim() must be called > ahead. > > Fixes: 84c406e74524 ("net/mlx5: add flow translate function") > Cc: or...@mellanox.com > > Signed-of

[dpdk-dev] [PATCH V2 0/3] fix vfio hot-unplug issue

2018-11-15 Thread Jeff Guo
This patch set aim to fix some dead lock issue when device be hotplug-in after device be hot-unplugged for vfio. v2->v1: refine some document and show the limitation. Jeff Guo (3): eal: fix lock issue for hot-unplug vfio: fix to add handler lock for hot-unplug app/testpmd: fix callback iss

[dpdk-dev] [PATCH V2 2/3] vfio: fix to add handler lock for hot-unplug

2018-11-15 Thread Jeff Guo
When the sigbus handler be enabled for hot-unplug, whatever hot-unplug sigbus or origin sigbus occur, the sigbus handler will be invoked and it will access the bus and device. While in the control path, the vfio req handler also will process the bus and device, so a protection of the resources in v

[dpdk-dev] [PATCH V2 0/3] fix vfio hot-unplug issue

2018-11-15 Thread Jeff Guo
This patch set aim to fix some dead lock issue when device be hotplug-in after device be hot-unplugged for vfio. v2->v1: refine some document and show the limitation. Jeff Guo (3): eal: fix lock issue for hot-unplug vfio: fix to add handler lock for hot-unplug app/testpmd: fix callback iss

[dpdk-dev] [PATCH V2 3/3] app/testpmd: fix callback issue for hot-unplug

2018-11-15 Thread Jeff Guo
Because the user's callback is invoked in eal interrupt callback, the interrupt callback need to be finished before it can be unregistered when detaching device. So finish callback soon and use a deferred removal to detach device is need. It is a workaround, once the device detaching be moved into

[dpdk-dev] [PATCH V2 1/3] eal: fix lock issue for hot-unplug

2018-11-15 Thread Jeff Guo
When device be hot-unplugged, the hot-unplug handler will be invoked by uio remove event and the device will be detached, then kernel will sent another pci remove event. So if there is any unlock miss, it will cause a dead lock issue. This patch will add this missing unlock for hot-unplug handler.

[dpdk-dev] [PATCH] net/i40e: fix RSS key pointer initialization error

2018-11-15 Thread Wei Zhao
The assignment should be done after initialization, or it will be zero. Fixes: 264b23e3d2c1 ("net/i40e: add parameter check for RSS flow init") Signed-off-by: Wei Zhao --- drivers/net/i40e/i40e_ethdev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/i40e/i40

Re: [dpdk-dev] [PATCH 1/1] eal: Don't fail secondary if primary is missing tailqs

2018-11-15 Thread Luca Boccassi
On Wed, 2018-11-14 at 18:24 +, Burdick, Cliff wrote: > > -Original Message- > From: Luca Boccassi [mailto:bl...@debian.org]  > Sent: Wednesday, November 14, 2018 10:15 AM > To: Burdick, Cliff; Bruce Richardson > Cc: Thomas Monjalon; Burakov, Anatoly; dev@dpdk.org > Subject: Re: [dpdk-d

Re: [dpdk-dev] [RFC] ethdev: introduce DMA memory mapping for external memory

2018-11-15 Thread Shahaf Shuler
Wednesday, November 14, 2018 7:06 PM, Burakov, Anatoly: > Subject: Re: [RFC] ethdev: introduce DMA memory mapping for external > memory > > On 14-Nov-18 2:53 PM, Shahaf Shuler wrote: > > Hi Anatoly, > > > > Wednesday, November 14, 2018 1:19 PM, Burakov, Anatoly: > >> Subject: Re: [RFC] ethdev: int

Re: [dpdk-dev] [PATCH] net/i40e: fix RSS key pointer initialization error

2018-11-15 Thread Zhao1, Wei
Send on behalf of Peng, Yuan tested-by: Peng, Yuan - Tested Branch: master - Tested Commit: 3e42b6ce06a1901b1ab631df4484ec8f548091c6 - OS: 4.5.5-300.fc24.x86_64 - GCC: gcc (GCC) 5.3.1 20151207 (Red Hat 5.3.1-2) - CPU: Intel(R) Xeon(R) CPU E5-2699 v4 @ 2.20GHz - NIC: Intel Corporation 82599ES 10

Re: [dpdk-dev] Where is the padding code in DPDK?

2018-11-15 Thread Burakov, Anatoly
On 15-Nov-18 2:07 AM, Sam wrote: So, to be brief, rte_eth_rx_burst and rte_eth_tx_burst, just send mbuf, will not do anything. Is that right? You're trying to arrive at certainty where there is none. The *API* will not do anything. The NIC itself might, depending on specifics of the hardwar

Re: [dpdk-dev] [PATCH v3 3/5] common: add missing implementations

2018-11-15 Thread Burakov, Anatoly
On 15-Nov-18 8:40 AM, Jerin Jacob wrote: -Original Message- Date: Wed, 14 Nov 2018 16:47:08 + From: Anatoly Burakov To: dev@dpdk.org CC: cristian.dumitre...@intel.com, tho...@monjalon.net, bruce.richard...@intel.com, ferruh.yi...@intel.com, jasvinder.si...@intel.com Subject: [dp

Re: [dpdk-dev] [PATCH v2 1/5] bitmap: remove useless code

2018-11-15 Thread Burakov, Anatoly
On 14-Nov-18 4:30 PM, Anatoly Burakov wrote: RTE_BITMAP_OPTIMIZATIONS was never set to 0 and makes no sense anyway, so remove all code related to it. Also, drop the "likely" for bsf64 code, because it's a generic function and we cannot make any assumptions about likely values of incoming argument

Re: [dpdk-dev] Where is the padding code in DPDK?

2018-11-15 Thread Morten Brørup
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Wiles, Keith > > On Nov 14, 2018, at 4:51 AM, Morten Brørup > wrote: > > > > Anatoly, > > > > This differs from the Linux kernel's behavior, where padding belongs > in the NIC driver layer, not in the protocol layer. If you pass a runt > frame

[dpdk-dev] [PATCH 1/4] net/mlx4: optimize Tx external memory registration

2018-11-15 Thread Yongseok Koh
There's some performance drop due to extra condition checks on the datapath. Checking for external memory registration should be consolidated to the existing bottom-half. Fixes: 31912d992403 ("net/mlx4: support externally allocated static memory") Signed-off-by: Yongseok Koh --- drivers/net/mlx

[dpdk-dev] [PATCH 2/4] net/mlx5: optimize Tx external memory registration

2018-11-15 Thread Yongseok Koh
There's some performance drop due to extra condition checks on the datapath. Checking for external memory registration should be consolidated to the existing bottom-half. Fixes: 7e43a32ee060 ("net/mlx5: support externally allocated static memory") Signed-off-by: Yongseok Koh --- drivers/net/mlx

[dpdk-dev] [PATCH 4/4] net/mlx5: optimize Rx buffer replenishment threshold

2018-11-15 Thread Yongseok Koh
Due to redundant calculation per every burst, performance drops a little. Fixes: e10245a13b2e ("net/mlx5: fix Rx buffer replenishment threshold") Cc: sta...@dpdk.org Signed-off-by: Yongseok Koh --- drivers/net/mlx5/mlx5_rxq.c | 2 ++ drivers/net/mlx5/mlx5_rxtx.h | 1 + driver

[dpdk-dev] [PATCH 3/4] net/mlx5: optimize Tx doorbell write

2018-11-15 Thread Yongseok Koh
Unnecessary volatile attribute keeps compiler from further optimizing the code and this results in a little performance drop (~2%). Because of memory barriers, it is safe to remove. Fixes: 6bf10ab69be0 ("net/mlx5: support 32-bit systems") Cc: sta...@dpdk.org Signed-off-by: Yongseok Koh --- driv

Re: [dpdk-dev] [PATCH] mem: Fix anonymous mapping on Power9.

2018-11-15 Thread Burakov, Anatoly
On 14-Nov-18 8:40 PM, David Wilder wrote: Removed the use of MAP_HUGETLB for anonymous mapping on ppc64. The MAP_HUGETLB had previously been added to workaround issues on IBM Power8 systems when mapping /dev/zero (see: commit 284ae3e9ff9a92575c28c858efd2c85c8de6d440). In the current code the MA

Re: [dpdk-dev] [RFC] ethdev: introduce DMA memory mapping for external memory

2018-11-15 Thread Burakov, Anatoly
On 15-Nov-18 9:46 AM, Shahaf Shuler wrote: Wednesday, November 14, 2018 7:06 PM, Burakov, Anatoly: Subject: Re: [RFC] ethdev: introduce DMA memory mapping for external memory On 14-Nov-18 2:53 PM, Shahaf Shuler wrote: Hi Anatoly, Wednesday, November 14, 2018 1:19 PM, Burakov, Anatoly: Subjec

[dpdk-dev] [PATCH] test: fix eal flags autotest hugepage file handling

2018-11-15 Thread Anatoly Burakov
Before 18.05, DPDK could not release memory back to the system neither at runtime nor before shutting down. Over the course of 18.05 up to 18.11, code was introduced to release memory at runtime, as well as an rte_eal_cleanup() function that is supposed to release all EAL-allocated memory before sh

[dpdk-dev] [PATCH] doc: announce deprecation of rawdev exposed array

2018-11-15 Thread Shreyansh Jain
rte_rawdevs is expected to be deprecated in future releases. This is not expected to be directly used, without API access that is, by any external application or driver. Signed-off-by: Shreyansh Jain --- This is in sync with discussion in [1] [1] http://mails.dpdk.org/archives/dev/2018-October

[dpdk-dev] [Bug 107] Cannot set rte_flow QUEUE action for VF representor

2018-11-15 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=107 Bug ID: 107 Summary: Cannot set rte_flow QUEUE action for VF representor Product: DPDK Version: 18.11 Hardware: x86 OS: Linux Status: CONFIRMED Severity: normal

Re: [dpdk-dev] [PATCH 1/4] net/mlx4: optimize Tx external memory registration

2018-11-15 Thread Shahaf Shuler
Thursday, November 15, 2018 12:29 PM, Yongseok Koh: > Subject: [PATCH 1/4] net/mlx4: optimize Tx external memory registration > > There's some performance drop due to extra condition checks on the > datapath. Checking for external memory registration should be consolidated > to the existing bottom

Re: [dpdk-dev] [PATCH 17.11] mem: fix memory initialization time

2018-11-15 Thread Burakov, Anatoly
On 12-Nov-18 11:18 AM, Alejandro Lucero wrote: When using large amount of hugepage based memory, doing all the hugepages mapping can take quite significant time. The problem is hugepages being initially mmaped to virtual addresses which will be tried later for the final hugepage mmaping. This ca

Re: [dpdk-dev] [PATCH] devbind: don't display non-existent device categories

2018-11-15 Thread Hunt, David
Hi Anatoly, On 13/11/2018 4:42 PM, Anatoly Burakov wrote: If there aren't any devices of a particular category on user's system, we still display them, which is bad for usability. Fix devbind to not print out a category unless there are devices in it. Signed-off-by: Anatoly Burakov --- usert

[dpdk-dev] [PATCH] doc: announce deprecation of dpaa2 exposed mem structure

2018-11-15 Thread Shreyansh Jain
rte_dpaa2_memsegs is no more required once the dpaax (pa-va) translation library has been introduced. This can be made internal (for fallback operations) in subsequent release. Signed-off-by: Shreyansh Jain --- This diff was generated over a previous patch on same file (a para before) [1] - so,

Re: [dpdk-dev] Where is the padding code in DPDK?

2018-11-15 Thread Wiles, Keith
> On Nov 15, 2018, at 4:27 AM, Morten Brørup wrote: > >> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Wiles, Keith >>> On Nov 14, 2018, at 4:51 AM, Morten Brørup >> wrote: >>> >>> Anatoly, >>> >>> This differs from the Linux kernel's behavior, where padding belongs >> in the NIC driv

Re: [dpdk-dev] [PATCH] devbind: don't display non-existent device categories

2018-11-15 Thread Wiles, Keith
> On Nov 15, 2018, at 7:27 AM, Hunt, David wrote: > > Hi Anatoly, > > On 13/11/2018 4:42 PM, Anatoly Burakov wrote: >> If there aren't any devices of a particular category on user's >> system, we still display them, which is bad for usability. Fix >> devbind to not print out a category unless

Re: [dpdk-dev] [PATCH] net/mvpp2: fix possible uninitialized variable access

2018-11-15 Thread Tomasz Duszynski
On Mon, Nov 05, 2018 at 03:25:22PM +, Ferruh Yigit wrote: > Fixes: cdb53f8da628 ("net/mvpp2: support metering") > > Signed-off-by: Ferruh Yigit > --- > drivers/net/mvpp2/mrvl_mtr.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/mvpp2/mrvl_mtr.c b/drivers/

Re: [dpdk-dev] [PATCH] mem: Fix anonymous mapping on Power9.

2018-11-15 Thread Burakov, Anatoly
On 14-Nov-18 8:40 PM, David Wilder wrote: Please include this patch in 18.11 as well, this patch is not suitable for 17.11. Small note: while this patch is not suitable for 17.11 as is, it can be made suitable if you drop the memalloc part. I copied this flag from old memory allocation code,

[dpdk-dev] [PATCH v3 0/3] net/mlx5: update MPLS item support

2018-11-15 Thread Dekel Peled
This series updates support of MPLS item, in verbs flow engine and in Direct Verbs flow engine. Patch 1/3 adds support of MPLS item in DV flow engine. Patch 2/3 updates the MPLS item validation in both flow engines. Patch 3/3 fixes tunnel ptype of MPLS in UDP. --- v3: - Add patch 3/3 to series. -

[dpdk-dev] [PATCH v3 1/3] net/mlx5: add MPLS to Direct Verbs flow engine

2018-11-15 Thread Dekel Peled
From: Shahaf Shuler The support in MPLS on this flow engine was overlooked. It's absence is critical because there are required actions for MPLS which can be done only with the DV engine. To set correctly the MPLS filter, we need to reason about the flow item before the MPLS (UDP, GRE or other).

[dpdk-dev] [PATCH v3 2/3] net/mlx5: fix MPLS item validation

2018-11-15 Thread Dekel Peled
Update the mlx5_flow_validate_item_mpls() function to allow MPLS over IP, UDP, and GRE. Modify the flow_dv_validate() function with the new logic introduced in previous patch of this series: set new variable last_item after each validation, update item_flags after each item iteration. The new varia

[dpdk-dev] [PATCH v3 3/3] net/mlx5: fix tunnel ptype of MPLS in UDP

2018-11-15 Thread Dekel Peled
Change the relevant value in tunnels_info[] to match tunnel type. Fixes: a4a5cd21d20a ("net/mlx5: add flow MPLS item") Cc: nelio.laranje...@6wind.com Signed-off-by: Dekel Peled --- drivers/net/mlx5/mlx5_flow.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/mlx5/

[dpdk-dev] [RFC v2 3/9] usertools/cpu_layout: rewrite to use DPDKConfigLib

2018-11-15 Thread Anatoly Burakov
Rewrite cpu layout script to use data provided by DPDKConfigLib script. This demonstrates an example of how external tools can get the same information from DPDKConfigLib. Signed-off-by: Anatoly Burakov --- usertools/cpu_layout.py | 53 ++--- 1 file changed, 1

[dpdk-dev] [RFC v2 4/9] usertools/lib: support FreeBSD for platform info

2018-11-15 Thread Anatoly Burakov
This enables FreeBSD support for PlatformInfo part of the DPDKConfigLib script, thereby enabling FreeBSD support for the cpu_layout script. Signed-off-by: Anatoly Burakov --- usertools/DPDKConfigLib/PlatformInfo.py | 81 - 1 file changed, 78 insertions(+), 3 deletions(-)

[dpdk-dev] [RFC v2 0/9] Modularize and enhance DPDK Python scripts

2018-11-15 Thread Anatoly Burakov
This patchset attempts to create a library out of Python scripts that come with DPDK, with a goal of enabling external tools to get the same information about the system DPDK has, and perhaps configure DPDK. Potential applications include: * Better setup.sh script (it's long overdue, and you know

[dpdk-dev] [RFC v2 8/9] usertools: add hugepage info script

2018-11-15 Thread Anatoly Burakov
Add a simple hugepage info script for demonstration purposes. It lists the following information: - Currently configured persistent hugetlbfs mountpoints (fstab) - Currently mounted hugetlbfs mountpoints - Total number of hugepages for each size - Per-NUMA node number of hugepages for each size S

[dpdk-dev] [RFC v2 2/9] usertools/lib: add platform info library

2018-11-15 Thread Anatoly Burakov
Add a library that will parse system information: * NUMA nodes * Cores and threads * Mapping from NUMA node and core to thread id's * Hyperthreading support status * RAM size * Default hugepage size as reported by kernel This can be used by scripts. Signed-off-by: Anatoly Burakov --- usertools

[dpdk-dev] [RFC v2 7/9] usertools/lib: add hugepage information library

2018-11-15 Thread Anatoly Burakov
Add a library for getting hugepage information on Linux system. Supported functionality: - List active hugetlbfs mountpoints - Change hugetlbfs mountpoints - Supports both transient and persistent (fstab) mountpoints - Display/change number of allocated hugepages - Supports both total and per

[dpdk-dev] [RFC v2 5/9] usertools/lib: add device information library

2018-11-15 Thread Anatoly Burakov
This library is mostly copy-paste of devbind script, but with few additional bells and whistles, such as the ability to enumerate and create/destroy VF devices. Signed-off-by: Anatoly Burakov --- usertools/DPDKConfigLib/DevInfo.py | 424 + usertools/DPDKConfigLib/DevU

[dpdk-dev] [RFC v2 9/9] usertools/lib: add GRUB utility library for hugepage config

2018-11-15 Thread Anatoly Burakov
This library is highly experimental and can kill kittens, but its main purpose is to automatically set up GRUB command-line to allocate a given number of hugepages at boot time. It works in a similar way HugeUtil library does, but instead of committing changes to fstab or runtime configuration, it

[dpdk-dev] [RFC v2 1/9] usertools: add DPDK config lib python library

2018-11-15 Thread Anatoly Burakov
This is a placeholder for Python library abstracting away many of mundane details DPDK configuration scripts have to deal with. We need __init__.py file to make the subdirectory a package so that Python scripts in usertools/ can find their dependencies. Signed-off-by: Anatoly Burakov --- usertoo

[dpdk-dev] [RFC v2 6/9] usertools/devbind: switch to using DPDKConfigLib

2018-11-15 Thread Anatoly Burakov
Make devbind use DPDKConfigLib library instead of having its own logic for binding/unbinding/enumerating devices and getting device information. All semantics and output are kept the same, only the internals changed. Signed-off-by: Anatoly Burakov --- usertools/dpdk-devbind.py | 533 ++-

Re: [dpdk-dev] [PATCH 1/1] eal: Don't fail secondary if primary is missing tailqs

2018-11-15 Thread Burdick, Cliff
-Original Message- From: Luca Boccassi [mailto:bl...@debian.org] Sent: Thursday, November 15, 2018 1:33 AM To: Burdick, Cliff; Bruce Richardson Cc: Thomas Monjalon; Burakov, Anatoly; dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH 1/1] eal: Don't fail secondary if primary is missing tailqs

Re: [dpdk-dev] [PATCH 1/1] eal: Don't fail secondary if primary is missing tailqs

2018-11-15 Thread Bruce Richardson
On Thu, Nov 15, 2018 at 04:15:36PM +, Burdick, Cliff wrote: > > > -Original Message- > From: Luca Boccassi [mailto:bl...@debian.org] > Sent: Thursday, November 15, 2018 1:33 AM > To: Burdick, Cliff; Bruce Richardson > Cc: Thomas Monjalon; Burakov, Anatoly; dev@dpdk.org > Subject: Re:

[dpdk-dev] [PATCH] build: set -mfpu=neon flag for armv7a builds

2018-11-15 Thread Luca Boccassi
Building on armv7a with meson currenctly fails: /usr/lib/gcc/arm-linux-gnueabihf/8/include/arm_neon.h:10369:1: error: inlining failed in call to always_inline ‘vld1q_s32’: target specific option mismatch Set -mfpu=neon on that architecture like the legacy makefiles do to fix the issue. F

Re: [dpdk-dev] [PATCH 1/1] eal: Don't fail secondary if primary is missing tailqs

2018-11-15 Thread Burdick, Cliff
-Original Message- From: Bruce Richardson [mailto:bruce.richard...@intel.com] Sent: Thursday, November 15, 2018 8:41 AM To: Burdick, Cliff Cc: Luca Boccassi; Thomas Monjalon; Burakov, Anatoly; dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH 1/1] eal: Don't fail secondary if primary is miss

Re: [dpdk-dev] [PATCH 1/1] eal: Don't fail secondary if primary is missing tailqs

2018-11-15 Thread Richardson, Bruce
> -Original Message- > From: Burdick, Cliff [mailto:cliff.burd...@viasat.com] > Sent: Thursday, November 15, 2018 4:55 PM > To: Richardson, Bruce > Cc: Luca Boccassi ; Thomas Monjalon > ; Burakov, Anatoly ; > dev@dpdk.org > Subject: RE: [dpdk-dev] [PATCH 1/1] eal: Don't fail secondary i

[dpdk-dev] mlx5 under FreeBSD

2018-11-15 Thread Mit Matelske
Is anyone working to include support for the mlx5 PMD under FreeBSD? I've started down this road by building Linux compatibility layers for the required Netlink and Ethtool calls in the driver, but would gladly accept help and advice from those much more knowledgeable then myself! Though not

Re: [dpdk-dev] [PATCH 1/1] eal: Don't fail secondary if primary is missing tailqs

2018-11-15 Thread Luca Boccassi
On Thu, 2018-11-15 at 17:01 +, Richardson, Bruce wrote: > > -Original Message- > > From: Burdick, Cliff [mailto:cliff.burd...@viasat.com] > > Sent: Thursday, November 15, 2018 4:55 PM > > To: Richardson, Bruce > > Cc: Luca Boccassi ; Thomas Monjalon > > ; Burakov, Anatoly > > ; > > de

Re: [dpdk-dev] [PATCH 1/1] eal: Don't fail secondary if primary is missing tailqs

2018-11-15 Thread Bruce Richardson
On Thu, Nov 15, 2018 at 05:05:16PM +, Luca Boccassi wrote: > On Thu, 2018-11-15 at 17:01 +, Richardson, Bruce wrote: > > > -Original Message- > > > From: Burdick, Cliff [mailto:cliff.burd...@viasat.com] > > > Sent: Thursday, November 15, 2018 4:55 PM > > > To: Richardson, Bruce > >

[dpdk-dev] [PATCH] examples/fips_validate: add power on self test

2018-11-15 Thread Fan Zhang
This patch adds a sample power on self-test to fips_validate sample application. Signed-off-by: Fan Zhang --- This patch targets 19.02 release. examples/fips_validation/Makefile |1 + examples/fips_validation/fips_dev_self_test.c | 1681 + examples/fips_va

[dpdk-dev] [PATCH] crypto/aesni_mb: add gmac support

2018-11-15 Thread Fan Zhang
This patch adds AES-GMAC authentication only support to AESNI-MB PMD. The unit test is updated accordingly. Signed-off-by: Fan Zhang --- This patch targets 19.02 release. drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c | 127 +++-- drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops

[dpdk-dev] [PATCH 0/2] lib/cryptodev: change qp conf and sym session

2018-11-15 Thread Fan Zhang
This patchset changes the queue pair configure structure and sym session structure for cryptodev. An RFC patch http://patchwork.dpdk.org/patch/43883/ has been sent to state the change. This patchset targets 19.02 release. Fan Zhang (2): cryptodev: change queue pair configure structure cryptod

[dpdk-dev] [PATCH 1/2] cryptodev: change queue pair configure structure

2018-11-15 Thread Fan Zhang
This patch changes the cryptodev queue pair configure structure to enable two mempool passed into cryptodev PMD simutaneously. Signed-off-by: Fan Zhang --- app/test-crypto-perf/main.c| 6 ++-- config/common_base | 24 +++--- driver

[dpdk-dev] [PATCH 2/2] cryptodev: change symmetric session structure

2018-11-15 Thread Fan Zhang
This patch changes the symmetric session structure of cryptodev. The symmetric session now contains extra information for secure access purposes. The patch also includes the updates to the PMDs, test applications, and examples to fit the change. Signed-off-by: Fan Zhang --- app/test-crypto-perf/

[dpdk-dev] [PATCH] crypto/aesni_mb: add SHA support

2018-11-15 Thread Fan Zhang
This patch adds SHA1, SHA224, SHA256, SHA384, SHA512 capability updates to AESNI-MB PMD. Signed-off-by: Fan Zhang --- This patch does not contain actual functionality implementation. This patch targets 19.02 release. drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c | 135 +

Re: [dpdk-dev] [PATCH 1/1] eal: Don't fail secondary if primary is missing tailqs

2018-11-15 Thread Burdick, Cliff
-Original Message- From: Bruce Richardson [mailto:bruce.richard...@intel.com] Sent: Thursday, November 15, 2018 9:17 AM To: Luca Boccassi Cc: Burdick, Cliff; Thomas Monjalon; Burakov, Anatoly; dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH 1/1] eal: Don't fail secondary if primary is miss

Re: [dpdk-dev] [PATCH] net/i40e: fix RSS key pointer initialization error

2018-11-15 Thread Zhang, Qi Z
> -Original Message- > From: Zhao1, Wei > Sent: Thursday, November 15, 2018 1:55 AM > To: dev@dpdk.org > Cc: Zhang, Qi Z ; Peng, Yuan > Subject: RE: [PATCH] net/i40e: fix RSS key pointer initialization error > > Send on behalf of Peng, Yuan > > tested-by: Peng, Yuan Acked-by: Qi Zh

Re: [dpdk-dev] [PATCH] net/ixgbe: update the maximum wait time in comment

2018-11-15 Thread Zhang, Qi Z
> -Original Message- > From: Ye, Xiaolong > Sent: Wednesday, November 14, 2018 11:20 PM > To: Zhang, Qi Z ; Xing, Beilei > Cc: dev@dpdk.org; sta...@dpdk.org; Ye, Xiaolong ; > mgsm...@netgate.com > Subject: [PATCH] net/ixgbe: update the maximum wait time in comment > > As the code has c

Re: [dpdk-dev] [PATCH v2] net/i40e: fix X710 Rx issue after reading some registers

2018-11-15 Thread Zhang, Qi Z
> -Original Message- > From: Xing, Beilei > Sent: Wednesday, November 14, 2018 7:17 PM > To: Zhang, Qi Z ; Wu, Jingjing > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: [PATCH v2] net/i40e: fix X710 Rx issue after reading some registers > > There's an issue that X710 can't receive any pa

Re: [dpdk-dev] [PATCH] mem: Fix anonymous mapping on Power9.

2018-11-15 Thread Thomas Monjalon
Hi, 14/11/2018 21:40, David Wilder: > Removed the use of MAP_HUGETLB for anonymous mapping on ppc64. The > MAP_HUGETLB had previously been added to workaround issues on IBM Power8 > systems when mapping /dev/zero (see: commit > 284ae3e9ff9a92575c28c858efd2c85c8de6d440). In the current code the >

Re: [dpdk-dev] [PATCH 1/1] eal: Don't fail secondary if primary is missing tailqs

2018-11-15 Thread Luca Boccassi
On Thu, 2018-11-15 at 17:17 +, Bruce Richardson wrote: > On Thu, Nov 15, 2018 at 05:05:16PM +, Luca Boccassi wrote: > > On Thu, 2018-11-15 at 17:01 +, Richardson, Bruce wrote: > > > > -Original Message- > > > > From: Burdick, Cliff [mailto:cliff.burd...@viasat.com] > > > > Sent:

[dpdk-dev] [PATCH] build: document that Meson < 0.45 will fail to list private deps

2018-11-15 Thread Luca Boccassi
Meson can generate the list of private dependencies of libraries automatically for the pkgconfig file only since version 0.45.0. Signed-off-by: Luca Boccassi --- doc/build-sdk-meson.txt | 6 ++ 1 file changed, 6 insertions(+) diff --git a/doc/build-sdk-meson.txt b/doc/build-sdk-meson.txt in

[dpdk-dev] DPDK techboard minutes of November 07

2018-11-15 Thread Ananyev, Konstantin
Meeting notes for the DPDK technical board meeting held on 2018-11-07 Attendees: - Bruce Richardson - Ferruh Yigit - Konstantin Ananyev - Maxime Coquelin - Olivier Matz - Thomas Monjalon 0) Informal discussion about current PPC support status As b

[dpdk-dev] DPDK Release Status Meeting 15/11/2018

2018-11-15 Thread Ferruh Yigit
Minutes 15 November 2018 Agenda: * Dates * RC3 status * Subtrees * Bugzilla * OvS * Conferences Participants: * 6Wind * Intel * Mellanox * NXP * RedHat Release Dates - * RC1 was out on Monday, 29 October. * RC2 was out on Tuesday, 6 November. * RC3 was out

[dpdk-dev] af_packet dev default "framesz" of 2048B

2018-11-15 Thread Lam, Tiago
Hi guys, OvS-DPDK has recently had small a change that changed the data room available in an mbuf (commit dfaf00e in OvS). This seems to have had the consequence of breaking the initialisation of eth_af_packets interfaces, when using default values ("options:dpdk- devargs=eth_af_packet0,iface=enp6

Re: [dpdk-dev] [PATCH] build: set -mfpu=neon flag for armv7a builds

2018-11-15 Thread Christian Ehrhardt
On Thu, Nov 15, 2018 at 5:54 PM Luca Boccassi wrote: > > Building on armv7a with meson currenctly fails: > > /usr/lib/gcc/arm-linux-gnueabihf/8/include/arm_neon.h:10369:1: error: > inlining failed in call to always_inline ‘vld1q_s32’: target > specific option mismatch > > Set -mfpu=neon on

Re: [dpdk-dev] [PATCH v3 0/3] net/mlx5: update MPLS item support

2018-11-15 Thread Shahaf Shuler
Thursday, November 15, 2018 5:17 PM, Dekel Peled: > Subject: [dpdk-dev] [PATCH v3 0/3] net/mlx5: update MPLS item support > > This series updates support of MPLS item, in verbs flow engine and in Direct > Verbs flow engine. > Patch 1/3 adds support of MPLS item in DV flow engine. > Patch 2/3 updat

[dpdk-dev] [PATCH 1/9] cryptodev: add opaque userdata pointer into crypto sym session

2018-11-15 Thread Konstantin Ananyev
Add 'uint64_t opaque_data' inside struct rte_cryptodev_sym_session. That allows upper layer to easily associate some user defined data with the session. Signed-off-by: Konstantin Ananyev --- lib/librte_cryptodev/rte_cryptodev.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/librte_cry

[dpdk-dev] [PATCH 2/9] security: add opaque userdata pointer into security session

2018-11-15 Thread Konstantin Ananyev
Add 'uint64_t opaque_data' inside struct rte_security_session. That allows upper layer to easily associate some user defined data with the session. Signed-off-by: Konstantin Ananyev --- lib/librte_security/rte_security.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/librte_security/r

[dpdk-dev] [PATCH 0/9] ipsec: new library for IPsec data-path processing

2018-11-15 Thread Konstantin Ananyev
This patch series targets 19.02 release. This patch series depends on the patch: http://patches.dpdk.org/patch/48044/ to be applied first. RFCv2 -> v1 - Changes per Jerin comments - Implement transport mode - Several bug fixes - UT largely reworked and extended This patch introduces a new li

[dpdk-dev] [PATCH 4/9] lib: introduce ipsec library

2018-11-15 Thread Konstantin Ananyev
Introduce librte_ipsec library. The library is supposed to utilize existing DPDK crypto-dev and security API to provide application with transparent IPsec processing API. That initial commit provides some base API to manage IPsec Security Association (SA) object. Signed-off-by: Mohammad Abdul Awal

[dpdk-dev] [PATCH 3/9] net: add ESP trailer structure definition

2018-11-15 Thread Konstantin Ananyev
Signed-off-by: Konstantin Ananyev --- lib/librte_net/rte_esp.h | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/lib/librte_net/rte_esp.h b/lib/librte_net/rte_esp.h index f77ec2eb2..8e1b3d2dd 100644 --- a/lib/librte_net/rte_esp.h +++ b/lib/librte_net/rte_esp.h @@ -11,7

[dpdk-dev] [PATCH 5/9] ipsec: add SA data-path API

2018-11-15 Thread Konstantin Ananyev
Introduce Security Association (SA-level) data-path API Operates at SA level, provides functions to: - initialize/teardown SA object - process inbound/outbound ESP/AH packets associated with the given SA (decrypt/encrypt, authenticate, check integrity, add/remove ESP/AH related

[dpdk-dev] [PATCH 7/9] ipsec: rework SA replay window/SQN for MT environment

2018-11-15 Thread Konstantin Ananyev
With these changes functions: - rte_ipsec_pkt_crypto_prepare - rte_ipsec_pkt_process can be safely used in MT environment, as long as the user can guarantee that they obey multiple readers/single writer model for SQN+replay_window operations. To be more specific: for outbound SA there are

[dpdk-dev] [PATCH 8/9] ipsec: helper functions to group completed crypto-ops

2018-11-15 Thread Konstantin Ananyev
Introduce helper functions to process completed crypto-ops and group related packets by sessions they belong to. Signed-off-by: Konstantin Ananyev --- lib/librte_ipsec/Makefile | 1 + lib/librte_ipsec/meson.build | 2 +- lib/librte_ipsec/rte_ipsec.h | 2 +

[dpdk-dev] [PATCH 6/9] ipsec: implement SA data-path API

2018-11-15 Thread Konstantin Ananyev
Provide implementation for rte_ipsec_pkt_crypto_prepare() and rte_ipsec_pkt_process(). Current implementation: - supports ESP protocol tunnel mode. - supports ESP protocol transport mode. - supports ESN and replay window. - supports algorithms: AES-CBC, AES-GCM, HMAC-SHA1, NULL. - covers all c

[dpdk-dev] [PATCH 9/9] test/ipsec: introduce functional test

2018-11-15 Thread Konstantin Ananyev
Create functional test for librte_ipsec. Signed-off-by: Mohammad Abdul Awal Signed-off-by: Bernard Iremonger Signed-off-by: Konstantin Ananyev --- test/test/Makefile |3 + test/test/meson.build |3 + test/test/test_ipsec.c | 2209 3 files c

Re: [dpdk-dev] [RFC v2 1/9] usertools: add DPDK config lib python library

2018-11-15 Thread Stephen Hemminger
On Thu, 15 Nov 2018 15:47:13 + Anatoly Burakov wrote: > This is a placeholder for Python library abstracting away many of > mundane details DPDK configuration scripts have to deal with. We > need __init__.py file to make the subdirectory a package so that > Python scripts in usertools/ can fi

Re: [dpdk-dev] [PATCH 2/2] cryptodev: change symmetric session structure

2018-11-15 Thread Ananyev, Konstantin
Hi Fan, > - > /** Cryptodev symmetric crypto session > * Each session is derived from a fixed xform chain. Therefore each session > * has a fixed algo, key, op-type, digest_len etc. > */ > struct rte_cryptodev_sym_session { > - __extension__ void *sess_private_data[0]; > - /**< Pri

[dpdk-dev] [PATCH v1] Tx offload mask is updated in following commit: commit 1037ed842c37 ("mbuf: fix Tx offload mask"). Currently, the new added offload flags are not supported in PMD and application

2018-11-15 Thread Zhirun Yan
This patch updates AVF_TX_OFFFLOAD_MASK. Fixes: 1037ed842c37 ("mbuf: fix Tx offload mask") Signed-off-by: Zhirun Yan --- drivers/net/avf/avf_rxtx.h | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/net/avf/avf_rxtx.h b/drivers/net/avf/avf_rxtx.h index 898d2f387..eece73b1d 100644

[dpdk-dev] [PATCH v2] net/avf: update Tx offload mask

2018-11-15 Thread Zhirun Yan
Tx offload mask is updated in following commit 1037ed842c37 ("mbuf: fix Tx offload mask"). Currently, the new added offload flags are not supported in PMD and application will fail to call PMD transmit prepare function. This patch updates AVF_TX_OFFFLOAD_MASK. Fixes: 1037ed842c37 ("mbuf: fix Tx o

[dpdk-dev] [PATCH v2] mem: Fix anonymous mapping on Power9.

2018-11-15 Thread David Wilder
Removed the use of MAP_HUGETLB for anonymous mapping on ppc64. The MAP_HUGETLB had previously been added to workaround issues on IBM Power8 systems when mapping /dev/zero (see: commit 284ae3e9ff9a92575c28c858efd2c85c8de6d440). In the current code the MAP_HUGETLB flag will cause the anonymous mapp

Re: [dpdk-dev] [PATCH v2] pci_vfio: Support 64KB kernel page_size with vfio-pci driver

2018-11-15 Thread Tone Zhang (Arm Technology China)
Hi Anatoly, I have some comments. > -Original Message- > From: Tone Zhang (Arm Technology China) > Sent: Thursday, November 15, 2018 8:49 AM > To: Burakov, Anatoly ; dev@dpdk.org > Cc: Gavin Hu (Arm Technology China) ; Honnappa > Nagarahalli ; Steve Capper > ; nd > Subject: RE: [PATCH v2

[dpdk-dev] [PATCH V3] doc: add known PHY link up issue for i40e

2018-11-15 Thread Jeff Guo
Some kernel drivers are not able to handle the link status correctly after DPDK application sets the PHY to link down. Signed-off-by: Jeff Guo --- doc/guides/rel_notes/known_issues.rst | 28 1 file changed, 28 insertions(+) diff --git a/doc/guides/rel_notes/known_is

[dpdk-dev] [PATCH] net/ixgbe: fix TDH register setting issue

2018-11-15 Thread Yanglong Wu
The only time that software should write to the TDH register is after a reset (hardware reset or CTRL.RST) and before enabling the transmit function (TXDCTL.ENABLE). If software were to write to this register while the transmit function was enabled, the on-chip descriptor buffers might be invalidat

[dpdk-dev] [PATCH v3] net/avf: update Tx offload mask

2018-11-15 Thread Zhirun Yan
Tx offload mask is updated in following commit 1037ed842c37 ("mbuf: fix Tx offload mask"). Currently, the new added offload flags are not supported in PMD and application will fail to call PMD transmit prepare function. This patch updates AVF_TX_OFFFLOAD_MASK. Fixes: 1037ed842c37 ("mbuf: fix Tx o