Re: [dpdk-dev] errors from VHOST on shutdown.

2018-10-24 Thread Tiwei Bie
On Tue, Oct 23, 2018 at 08:56:58AM -0700, Stephen Hemminger wrote: > I get errors on shutdown of application using virtio-user. > For example, quitting testpmd: > > Detaching a port... > vhost_kernel_set_backend(): VHOST_NET_SET_BACKEND fails, Operation not > permitted > vhost_kernel_set_backend(

Re: [dpdk-dev] [PATCH] examples/ipv4_multicast: enable multicast promiscuous for all port

2018-10-24 Thread Zhao1, Wei
Add Wang Dong in the mailing list, he has test this patch. > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Zhao1, Wei > Sent: Wednesday, October 17, 2018 4:09 PM > To: dev@dpdk.org > Cc: sta...@dpdk.org; Zhang, Qi Z ; Yigit, Ferruh > > Subject: Re: [dpdk-dev]

[dpdk-dev] [RFC 01/14] net: add rte prefix to arp structures

2018-10-24 Thread Olivier Matz
Add 'rte_' prefix to structures: - rename struct arp_hdr as struct rte_arp_hdr. - rename struct arp_ipv4 as struct rte_arp_ipv4. Also rename arp_hrd, arp_pro, arp_hln, arp_pln and arp_op fields to avoid conflict with the #defines in gnu libc. Signed-off-by: Olivier Matz --- app/test-pmd/icmpech

[dpdk-dev] [RFC 00/14] prefix network structures

2018-10-24 Thread Olivier Matz
This RFC targets 19.02. The rte_net headers conflict with the libc headers, because some definitions are duplicated, sometimes with few differences. This was discussed in [1], and more recently at the techboard. Before sending the deprecation notice (target for this is 18.11), here is a draft tha

[dpdk-dev] [RFC 04/14] net: add rte prefix to ether functions

2018-10-24 Thread Olivier Matz
Add 'rte_' prefix to functions: - rename is_same_ether_addr() as rte_is_same_ether_addr(). - rename is_zero_ether_addr() as rte_is_zero_ether_addr(). - rename is_unicast_ether_addr() as rte_is_unicast_ether_addr(). - rename is_multicast_ether_addr() as rte_is_multicast_ether_addr(). - rename is_bro

[dpdk-dev] [RFC 02/14] net: add rte prefix to arp defines

2018-10-24 Thread Olivier Matz
Add 'RTE_' prefix to defines: - rename ARP_HRD_ETHER as RTE_ARP_HRD_ETHER. - rename ARP_OP_REQUEST as RTE_ARP_OP_REQUEST. - rename ARP_OP_REPLY as RTE_ARP_OP_REPLY. - rename ARP_OP_REVREQUEST as RTE_ARP_OP_REVREQUEST. - rename ARP_OP_REVREPLY as RTE_ARP_OP_REVREPLY. - rename ARP_OP_INVREQUEST as RT

[dpdk-dev] [RFC 06/14] net: add rte prefix to esp structure

2018-10-24 Thread Olivier Matz
Add 'rte_' prefix to structures: - rename struct esp_hdr as struct rte_esp_hdr. Signed-off-by: Olivier Matz --- examples/ipsec-secgw/esp.c | 42 +- examples/ipsec-secgw/sa.c| 6 +++--- lib/librte_ethdev/rte_flow.h | 2 +- lib/librte_net/rte_esp.h

[dpdk-dev] [RFC 11/14] net: add rte prefix to ip defines

2018-10-24 Thread Olivier Matz
Add 'RTE_' prefix to defines: - rename IPv4( as RTE_IPv4(. - rename IPV4_MAX_PKT_LEN as RTE_IPV4_MAX_PKT_LEN. - rename IPV4_HDR_IHL_MASK as RTE_IPV4_HDR_IHL_MASK. - rename IPV4_IHL_MULTIPLIER as RTE_IPV4_IHL_MULTIPLIER. - rename IPV4_HDR_DF_SHIFT as RTE_IPV4_HDR_DF_SHIFT. - rename IPV4_HDR_MF_SHIFT

[dpdk-dev] [RFC 09/14] net: add rte prefix to icmp defines

2018-10-24 Thread Olivier Matz
Add 'RTE_' prefix to defines: - rename IP_ICMP_ECHO_REPLY as RTE_IP_ICMP_ECHO_REPLY. - rename IP_ICMP_ECHO_REQUEST as RTE_IP_ICMP_ECHO_REQUEST. Signed-off-by: Olivier Matz --- app/test-pmd/icmpecho.c | 10 +- lib/librte_net/rte_icmp.h | 4 ++-- 2 files changed, 7 insertions(+), 7 dele

[dpdk-dev] [RFC 07/14] net: add rte prefix to gre structure

2018-10-24 Thread Olivier Matz
Add 'rte_' prefix to structures: - rename struct gre_hdr as struct rte_gre_hdr. Signed-off-by: Olivier Matz --- lib/librte_net/rte_gre.h | 2 +- lib/librte_net/rte_net.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/librte_net/rte_gre.h b/lib/librte_net/rte_gre.h i

[dpdk-dev] [RFC 08/14] net: add rte prefix to icmp structure

2018-10-24 Thread Olivier Matz
Add 'rte_' prefix to structures: - rename struct icmp_hdr as struct rte_icmp_hdr. Signed-off-by: Olivier Matz --- app/test-pmd/icmpecho.c | 4 ++-- lib/librte_ethdev/rte_flow.h | 2 +- lib/librte_net/rte_icmp.h| 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/app/te

[dpdk-dev] [RFC 14/14] net: add rte prefix to udp structure

2018-10-24 Thread Olivier Matz
Add 'rte_' prefix to structures: - rename struct udp_hdr as struct rte_udp_hdr. Signed-off-by: Olivier Matz --- app/test-pmd/csumonly.c| 20 ++-- app/test-pmd/flowgen.c | 4 ++-- app/test-pmd/txonly.c | 8 app/test-pmd/u

[dpdk-dev] [RFC 12/14] net: add rte prefix to sctp structure

2018-10-24 Thread Olivier Matz
Add 'rte_' prefix to structures: - rename struct sctp_hdr as struct rte_sctp_hdr. Signed-off-by: Olivier Matz --- app/test-pmd/csumonly.c| 4 ++-- drivers/net/avf/avf_rxtx.c | 2 +- drivers/net/e1000/igb_rxtx.c | 2 +- drivers/net/enic/enic_clsf.c | 8

[dpdk-dev] [RFC 13/14] net: add rte prefix to tcp structure

2018-10-24 Thread Olivier Matz
Add 'rte_' prefix to structures: - rename struct tcp_hdr as struct rte_tcp_hdr. Signed-off-by: Olivier Matz --- app/test-pmd/csumonly.c| 12 ++-- doc/guides/sample_app_ug/flow_classify.rst | 4 ++-- drivers/net/avf/avf_rxtx.c | 2 +- driv

Re: [dpdk-dev] [PATCH v3 0/4] support more ethdev iterator filters

2018-10-24 Thread Ferruh Yigit
On 10/22/2018 2:15 PM, Thomas Monjalon wrote: > The new ethdev iterator lacks the support of filtering > by representor port id or by MAC address. > > > Changes in v3: > - improve comment for representor_id > > Changes in v2: > - fix list parsing in kvargs > - support mac= parameter > >

Re: [dpdk-dev] [RFC 00/14] prefix network structures

2018-10-24 Thread Olivier Matz
On Wed, Oct 24, 2018 at 10:18:19AM +0200, Olivier Matz wrote: > This RFC targets 19.02. > > The rte_net headers conflict with the libc headers, because > some definitions are duplicated, sometimes with few differences. > This was discussed in [1], and more recently at the techboard. Sorry, the re

[dpdk-dev] [PATCH 1/2] net/mlx5: fix complete queue compression device argument

2018-10-24 Thread Xueming Li
This patch fixs cqe_comp devarg that always enabled according fw. Fixes: 7fe24446e946 ("net/mlx5: add device configuration structure") Cc: shah...@mellanox.com Signed-off-by: Xueming Li --- drivers/net/mlx5/mlx5.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drive

[dpdk-dev] [PATCH 2/2] net/mlx5: fix interrupt on compressed completion queue

2018-10-24 Thread Xueming Li
Rxq.cq_ci field gets changed in zipped cqe mode because the field used to save cq_ci in zip data structure has less bits defined. Fixes: 43e9d9794cde ("net/mlx5: support upstream rdma-core") Cc: Shahaf Shuler Signed-off-by: Xueming Li --- drivers/net/mlx5/mlx5_rxtx.h | 2 +- 1 file changed, 1

Re: [dpdk-dev] [PATCH v7] net/mlx5: support metadata as flow rule criteria

2018-10-24 Thread Ferruh Yigit
On 10/24/2018 7:12 AM, Shahaf Shuler wrote: > Hi Ferruh, > > This patch contains a fix for compilation on top of arm. > I hopped to replace between the existing "support metadata as flow rule > criteria" to this one before you take it, but I was too late. > Can you please replace the old patch w

Re: [dpdk-dev] [PATCH v2] vhost: avoid memory barriers when no descriptors dequeued

2018-10-24 Thread Tiwei Bie
On Tue, Oct 23, 2018 at 12:07:10PM +0200, Maxime Coquelin wrote: > In both split and packed dequeue paths, flush_shadow_used_ring > and vhost_ring_call variants gets called even if not packets > have been dequeued, and so no descriptors updates happened. > > It has an impact on CPU pipeline, as me

[dpdk-dev] [PATCH v4 0/5] create different meson test targets

2018-10-24 Thread Hari kumar Vemula
From: Hari Kumar Vemula 1/5: remove existing test cases to reorganize further 2/5: add test-fast suite to meson targets 3/5: add test-perf suite to meson targets 4/5: add test-driver suite to meson targets 5/5: add test-dump suite to meson targets -- v4: Removed test from file prefix v3: Updated

[dpdk-dev] [PATCH v4 3/5] test: add performance tests under test-perf suite

2018-10-24 Thread Hari kumar Vemula
From: Hari Kumar Vemula Grouped performace test cases under test-perf category Signed-off-by: Hari Kumar Vemula --- test/test/meson.build | 34 ++ 1 file changed, 34 insertions(+) diff --git a/test/test/meson.build b/test/test/meson.build index a10908fb3..9e4d7

Re: [dpdk-dev] [PATCH] pci_vfio: Support 64KB kernel page_size with vfio-pci driver

2018-10-24 Thread Burakov, Anatoly
On 24-Oct-18 3:20 AM, tone.zhang wrote: With a larger PAGE_SIZE it is possible for the MSI table to very close to the end of the BAR s.t. when we align the MSI table to the PAGE_SIZE, the end offset of the MSI table is out the PCI BAR boundary. This patch addresses the issue by comparing both th

[dpdk-dev] [PATCH v4 4/5] test: add library dependent tests under test-driver suite

2018-10-24 Thread Hari kumar Vemula
From: Hari Kumar Vemula Added test cases that depend on library as cryptodev Signed-off-by: Hari Kumar Vemula --- test/test/meson.build | 27 +++ 1 file changed, 27 insertions(+) diff --git a/test/test/meson.build b/test/test/meson.build index 9e4d7621d..da1dbfac4 1006

[dpdk-dev] [PATCH v4 5/5] test: add dump test cases under test-dump suite

2018-10-24 Thread Hari kumar Vemula
From: Hari Kumar Vemula Grouped logging or dump related test cases to test-dump category Signed-off-by: Hari Kumar Vemula --- test/test/meson.build | 21 + 1 file changed, 21 insertions(+) diff --git a/test/test/meson.build b/test/test/meson.build index da1dbfac4..266e1bfa

[dpdk-dev] [PATCH v4 2/5] test: add quick run tests under test-fast suite

2018-10-24 Thread Hari kumar Vemula
From: Hari Kumar Vemula Added test cases that runs quickly under test fast category Signed-off-by: Hari Kumar Vemula --- test/test/meson.build | 99 --- 1 file changed, 94 insertions(+), 5 deletions(-) diff --git a/test/test/meson.build b/test/t

[dpdk-dev] [PATCH v4 1/5] test: remove existing testcases for categorization

2018-10-24 Thread Hari kumar Vemula
From: Hari Kumar Vemula Removed testcase list from meson build to categorize testcases into suites Signed-off-by: Hari Kumar Vemula --- test/test/meson.build | 111 -- 1 file changed, 111 deletions(-) diff --git a/test/test/meson.build b/test/te

Re: [dpdk-dev] [PATCH] examples/ipv4_multicast: enable multicast promiscuous for all port

2018-10-24 Thread Wang, Dong1
Tested it with 82599 PF. Acked-by: Wang Dong -Original Message- From: Zhao1, Wei Sent: Wednesday, October 24, 2018 16:11 To: Zhao1, Wei ; dev@dpdk.org Cc: sta...@dpdk.org; Zhang, Qi Z ; Yigit, Ferruh ; Wang, Dong1 ; Thomas Monjalon Subject: RE: [PATCH] examples/ipv4_multicast: enable

Re: [dpdk-dev] [PATCH] kvargs: fix processing a null list

2018-10-24 Thread Olivier Matz
On Tue, Oct 23, 2018 at 06:24:54PM +0200, Thomas Monjalon wrote: > In the doxygen description of rte_kvargs_process(), it is said: > If *kvlist* is NULL function does nothing. > It has been added by mistake here instead of rte_kvargs_free(). > Anyway, null list should be correctly handled in

[dpdk-dev] [PATCH] vhost: initialize postcopy ufd properly

2018-10-24 Thread Tiwei Bie
Currently, postcopy_ufd is initialized to 0 implicitly, so fd 0 could be closed unexpectedly by vhost_backend_cleanup(). Fix this issue by initializing postcopy_ufd to -1 explicitly. Fixes: 9eefef3b5970 ("vhost: introduce postcopy advise message") Signed-off-by: Tiwei Bie --- lib/librte_vhost/v

[dpdk-dev] [PATCH] kni: fix build for Linux kernel 4.19

2018-10-24 Thread Ferruh Yigit
The build error observed with Linux kernel 4.19 when KNI ethtool support enabled (CONFIG_RTE_KNI_KMOD_ETHTOOL=y) .../build/build/kernel/linux/kni/kni_ethtool.c:193:3: error: ‘struct ethtool_ops’ has no member named ‘get_settings’; .get_settings = kni_get_settings, ^~~~ .../build/

[dpdk-dev] [PATCH v2] kni: fix build for Linux kernel 4.19

2018-10-24 Thread Ferruh Yigit
The build error observed with Linux kernel 4.19 when KNI ethtool support enabled (CONFIG_RTE_KNI_KMOD_ETHTOOL=y) .../build/build/kernel/linux/kni/kni_ethtool.c:193:3: error: ‘struct ethtool_ops’ has no member named ‘get_settings’; .get_settings = kni_get_settings, ^~~~ .../build/

[dpdk-dev] [PATCH] ipc: fix undefined behavior in no-shconf mode

2018-10-24 Thread Darek Stojaczyk
In no-shconf mode the rte_mp_request_sync() wasn't initializing the `reply` parameter, which contained e.g. a number of sent requests. Callers of rte_mp_request_sync() might check that param afterwards and might read potentially unitialized memory. The no-shconf check that makes us return early (w

Re: [dpdk-dev] [PATCH v4 5/5] test: add dump test cases under test-dump suite

2018-10-24 Thread Bruce Richardson
On Wed, Oct 24, 2018 at 10:07:12AM +0100, Hari kumar Vemula wrote: > From: Hari Kumar Vemula > > Grouped logging or dump related test cases to test-dump category > > Signed-off-by: Hari Kumar Vemula > --- > test/test/meson.build | 21 + > 1 file changed, 21 insertions(+) >

Re: [dpdk-dev] [PATCH v4 4/5] test: add library dependent tests under test-driver suite

2018-10-24 Thread Bruce Richardson
On Wed, Oct 24, 2018 at 10:07:11AM +0100, Hari kumar Vemula wrote: > From: Hari Kumar Vemula > > Added test cases that depend on library as cryptodev Commit log could do with a little improvement: It's not that they depend on a library, but rather on specific drivers. > Signed-off-by: Hari Kum

Re: [dpdk-dev] [PATCH] ipc: fix undefined behavior in no-shconf mode

2018-10-24 Thread Burakov, Anatoly
On 24-Oct-18 11:05 AM, Darek Stojaczyk wrote: In no-shconf mode the rte_mp_request_sync() wasn't initializing the `reply` parameter, which contained e.g. a number of sent requests. Callers of rte_mp_request_sync() might check that param afterwards and might read potentially unitialized memory. T

Re: [dpdk-dev] [PATCH] vhost: initialize postcopy ufd properly

2018-10-24 Thread Maxime Coquelin
On 10/24/18 11:39 AM, Tiwei Bie wrote: Currently, postcopy_ufd is initialized to 0 implicitly, so fd 0 could be closed unexpectedly by vhost_backend_cleanup(). Fix this issue by initializing postcopy_ufd to -1 explicitly. Fixes: 9eefef3b5970 ("vhost: introduce postcopy advise message") Signe

[dpdk-dev] [PATCH] pci/vfio: fixup rte_intr_callback_unregister() handling

2018-10-24 Thread Darek Stojaczyk
This function is documented to return the number of unregistered callbacks or negative numbers on error, but pci_vfio checks for ret != 0 to detect failures. Not anymore. Fixes: c115fd000c32 ("vfio: handle hotplug request notifier") Cc: jia@intel.com Cc: sta...@dpdk.org Signed-off-by: Darek S

Re: [dpdk-dev] [PATCH v2 2/2] ethdev: fix metadata documentation

2018-10-24 Thread Ori Kam
> -Original Message- > From: dev On Behalf Of Dekel Peled > Sent: Wednesday, October 24, 2018 9:22 AM > To: wenzhuo...@intel.com; jingjing...@intel.com; > bernard.iremon...@intel.com; olivier.m...@6wind.com; Adrien Mazarguil > ; Thomas Monjalon ; > ferruh.yi...@intel.com; arybche...@sol

Re: [dpdk-dev] [PATCH v4 0/5] create different meson test targets

2018-10-24 Thread Bruce Richardson
On Wed, Oct 24, 2018 at 10:07:07AM +0100, Hari kumar Vemula wrote: > From: Hari Kumar Vemula > > 1/5: remove existing test cases to reorganize further > 2/5: add test-fast suite to meson targets > 3/5: add test-perf suite to meson targets > 4/5: add test-driver suite to meson targets > 5/5: add t

Re: [dpdk-dev] [PATCH v2 1/2] app/testpmd: fix metadata API and Tx insertion

2018-10-24 Thread Ori Kam
> -Original Message- > From: dev On Behalf Of Dekel Peled > Sent: Wednesday, October 24, 2018 9:22 AM > To: wenzhuo...@intel.com; jingjing...@intel.com; > bernard.iremon...@intel.com; olivier.m...@6wind.com; Adrien Mazarguil > ; Thomas Monjalon ; > ferruh.yi...@intel.com; arybche...@sol

Re: [dpdk-dev] [PATCH] vhost: initialize postcopy ufd properly

2018-10-24 Thread Maxime Coquelin
On 10/24/18 11:39 AM, Tiwei Bie wrote: Currently, postcopy_ufd is initialized to 0 implicitly, so fd 0 could be closed unexpectedly by vhost_backend_cleanup(). Fix this issue by initializing postcopy_ufd to -1 explicitly. Fixes: 9eefef3b5970 ("vhost: introduce postcopy advise message") Signe

Re: [dpdk-dev] [PATCH v2] vhost: avoid memory barriers when no descriptors dequeued

2018-10-24 Thread Maxime Coquelin
On 10/23/18 12:07 PM, Maxime Coquelin wrote: In both split and packed dequeue paths, flush_shadow_used_ring and vhost_ring_call variants gets called even if not packets have been dequeued, and so no descriptors updates happened. It has an impact on CPU pipeline, as memory barriers are used in

Re: [dpdk-dev] [PATCH v4 0/8] net/mlx5: flow counters support for Linux-rdma v19

2018-10-24 Thread Shahaf Shuler
Tuesday, October 23, 2018 1:13 PM, Slava Ovsiienko: > Subject: [PATCH v4 0/8] net/mlx5: flow counters support for Linux-rdma v19 > > Mellanox mlx5 PMD supports Flow counters via Verbs library. > The current implementation is based on the Mellanox proprietary Verbs > library included in MLNX OFED p

[dpdk-dev] [PATCH 1/2] net/mlx5: add VXLAN encap decap to Direct Verbs

2018-10-24 Thread Dekel Peled
This patch adds support for VXLAN encap and decap operations, in Direct Verbs flow. Signed-off-by: Dekel Peled --- drivers/net/mlx5/mlx5_flow.h| 4 + drivers/net/mlx5/mlx5_flow_dv.c | 409 +++- 2 files changed, 408 insertions(+), 5 deletions(-) diff --g

[dpdk-dev] [PATCH 0/2] net/mlx5: add L2 encap and decap to Direct Verbs

2018-10-24 Thread Dekel Peled
This series implements the VXLAN and NVGRE encap and decap actions, in Direct Verbs flow. Dekel Peled (2): net/mlx5: add VXLAN encap decap to Direct Verbs net/mlx5: add NVGRE encap decap to Direct Verbs drivers/net/mlx5/mlx5_flow.h| 6 + drivers/net/mlx5/mlx5_flow_dv.c | 439 ++

[dpdk-dev] [PATCH 2/2] net/mlx5: add NVGRE encap decap to Direct Verbs

2018-10-24 Thread Dekel Peled
This patch adds support for NVGRE encap and decap operations, in Direct Verbs flow. Signed-off-by: Dekel Peled --- drivers/net/mlx5/mlx5_flow.h| 2 + drivers/net/mlx5/mlx5_flow_dv.c | 144 2 files changed, 89 insertions(+), 57 deletions(-) diff --g

Re: [dpdk-dev] [PATCH] eal: don't double space init alert messages

2018-10-24 Thread Shreyansh Jain
On Tuesday 23 October 2018 09:59 PM, Stephen Hemminger wrote: > rte_init_alert already adds a newline, don't do it twice. > > Signed-off-by: Stephen Hemminger > --- > lib/librte_eal/bsdapp/eal/eal.c | 24 > lib/librte_eal/linuxapp/eal/eal.c | 28 ++---

[dpdk-dev] [Bug 98] wrongly assignment of digest_len

2018-10-24 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=98 Bug ID: 98 Summary: wrongly assignment of digest_len Product: DPDK Version: 18.08 Hardware: All OS: All Status: CONFIRMED Severity: normal Priority: Norma

Re: [dpdk-dev] [PATCH v5 0/8] FIPS validation capability

2018-10-24 Thread Akhil Goyal
Hi Marko, On 10/17/2018 6:19 PM, Marko Kovacevic wrote: > This sample application is made for the purpose so that users of DPDK > who wish to get FIPS certification for their platforms, this sample app > enables > users to parse test vectors that is gotten from NIST and be able to get > a generat

Re: [dpdk-dev] [RFC v2 5/9] ipsec: add SA data-path API

2018-10-24 Thread Jerin Jacob
-Original Message- > Date: Sun, 21 Oct 2018 22:01:48 + > From: "Ananyev, Konstantin" > To: Jerin Jacob > CC: "dev@dpdk.org" , "Awal, Mohammad Abdul" > , "Joseph, Anoob" > , "Athreya, Narayana Prasad" > > Subject: RE: [dpdk-dev] [RFC v2 5/9] ipsec: add SA data-path API > > > Hi J

Re: [dpdk-dev] [PATCH v5 1/8] examples/cryptodev_fips_validate: add fips validation into examples

2018-10-24 Thread Akhil Goyal
On 10/17/2018 6:19 PM, Marko Kovacevic wrote: > Added FIPS application into the examples to allow > users to use a simple sample app to validate > their systems and be able to get FIPS certification. > > Signed-off-by: Marko Kovacevic > Signed-off-by: Fan Zhang > Acked-by: Arek Kusztal > --- >

[dpdk-dev] [Bug 99] axgbe driver does not support 1G Copper 1000BASE-T SFPs (Unsupported AN_CL37)

2018-10-24 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=99 Bug ID: 99 Summary: axgbe driver does not support 1G Copper 1000BASE-T SFPs (Unsupported AN_CL37) Product: DPDK Version: 18.02 Hardware: All OS: All Statu

Re: [dpdk-dev] [PATCH] test: reduce duration for timer autotest

2018-10-24 Thread Pattan, Reshma
> -Original Message- > From: Parthasarathy, JananeeX M > Sent: Monday, October 22, 2018 8:43 AM > To: Pattan, Reshma ; dev@dpdk.org > Cc: rsanf...@akamai.com > Subject: RE: [PATCH] test: reduce duration for timer autotest > > > NB_STRESS2_TIMERS is used for all iterations in the test a

Re: [dpdk-dev] [PATCH v2 0/5] net/mlx5: fixes for Direct Verbs flow

2018-10-24 Thread Shahaf Shuler
Tuesday, October 23, 2018 7:52 PM, Yongseok Koh: > Subject: [PATCH v2 0/5] net/mlx5: fixes for Direct Verbs flow > > v2: > * rebase on top of the new branch tip > > > Yongseok Koh (5): > net/mlx5: add warning message for Direct Verbs flow > net/mlx5: fix UDP hash field flag in Direct Verbs >

Re: [dpdk-dev] [PATCH v5 4/8] examples/cryptodev_fips_validate: add TDES parser and enablement for test types

2018-10-24 Thread Akhil Goyal
better to be uniform with the name TDES or 3DES On 10/17/2018 6:19 PM, Marko Kovacevic wrote: > Added enablement for TDES parser, to allow the > application to parser the TDES request files and to validate all > test types supported. > > Signed-off-by: Marko Kovacevic > Signed-off-by: Fan Zhang

[dpdk-dev] Change ether_addr to avoid conflict

2018-10-24 Thread Lewis Donzis
Please consider changing "struct ether_addr" in rte_ether.h to "struct rte_ether_addr", in order to avoid conflicts with the same structure name /usr/include/net/ethernet.h. Sometimes, there is need to include /usr/include/net/ethernet.h, but it conflicts with the same structure name in rte_eth

[dpdk-dev] [PATCH 0/3] fix flow tunnel handling

2018-10-24 Thread Shahaf Shuler
This patchset fix multiple issues with tunnel rule handling in the PMD's flow engine. Yongseok Koh (3): net/mlx5: rename static functions net/mlx5: fix flow tunnel handling net/mlx5: fix bit width of item and action flags drivers/net/mlx5/mlx5_flow.c | 129 +--

Re: [dpdk-dev] [PATCH v5 2/8] examples/cryptodev_fips_validate: add aes parser and enablement for test types

2018-10-24 Thread Akhil Goyal
On 10/17/2018 6:19 PM, Marko Kovacevic wrote: > diff --git a/examples/cryptodev_fips_validate/cryptodev_fips_validate.h > b/examples/cryptodev_fips_validate/cryptodev_fips_validate.h > index beb6bed..5ac858d 100644 > --- a/examples/cryptodev_fips_validate/cryptodev_fips_validate.h > +++ b/exampl

[dpdk-dev] [PATCH 1/3] net/mlx5: rename static functions

2018-10-24 Thread Shahaf Shuler
From: Yongseok Koh In mlx5_flow*.c, static functions have names starting from 'flow_' while shared ones start from "mlx5_flow_'. Signed-off-by: Yongseok Koh --- drivers/net/mlx5/mlx5_flow.c | 62 +++ 1 file changed, 30 insertions(+), 32 deletions(-) diff --

[dpdk-dev] [PATCH 2/3] net/mlx5: fix flow tunnel handling

2018-10-24 Thread Shahaf Shuler
From: Yongseok Koh Both rte_flow and mlx5_flow redundantly have item flags. And it is not properly set in the code. This causes wrong tunnel flag handling. A rte_flow can have multiple expanded device flows if the flow has an RSS action. Therefore, mlx5_flow should have the layers field. Fixes:

[dpdk-dev] [PATCH 3/3] net/mlx5: fix bit width of item and action flags

2018-10-24 Thread Shahaf Shuler
From: Yongseok Koh Most of the code uses uint64_t for MLX5_FLOW_LAYER_* and MLX5_FLOW_ACTION_*, but there're some code using uint32_t. Fixes: 2ed2fe5f0a9c ("net/mlx5: rewrite IP address UDP/TCP port by E-Switch") Fixes: 57123c00c1b8 ("net/mlx5: add Linux TC flower driver for E-Switch flow") Fixe

[dpdk-dev] [PATCH 0/5] net/softnic: add symmetric crypto support

2018-10-24 Thread Fan Zhang
This patchset enables the symmetric crypto workload processing support to softnic PMD. Fan Zhang (5): net/softnic: add cryptodev net/softnic: configure crypto port net/softnic: add symmetric crypto action net/softnic: update cli parsing doc: update release note doc/guides/rel_notes/rel

[dpdk-dev] [PATCH 2/5] net/softnic: configure crypto port

2018-10-24 Thread Fan Zhang
This patch enables the crypt port configuration in softnic. Signed-off-by: Fan Zhang --- drivers/net/softnic/rte_eth_softnic_pipeline.c | 55 ++ 1 file changed, 55 insertions(+) diff --git a/drivers/net/softnic/rte_eth_softnic_pipeline.c b/drivers/net/softnic/rte_eth_so

[dpdk-dev] [PATCH 1/5] net/softnic: add cryptodev

2018-10-24 Thread Fan Zhang
This patch adds cryptodev abstraction to softnic. The DPDK Cryptodevs are abstracted as crypto ports in the softnic. Signed-off-by: Fan Zhang --- drivers/net/softnic/Makefile| 2 + drivers/net/softnic/meson.build | 3 +- drivers/net/softnic/rte_eth_softnic

[dpdk-dev] [PATCH 4/5] net/softnic: update cli parsing

2018-10-24 Thread Fan Zhang
This patch updates the cli parsing of softnic with extra symmetric cryptodev, port, session, and action support. Signed-off-by: Fan Zhang --- drivers/net/softnic/rte_eth_softnic_cli.c | 513 ++ 1 file changed, 513 insertions(+) diff --git a/drivers/net/softnic/rte_et

[dpdk-dev] [PATCH 3/5] net/softnic: add symmetric crypto action

2018-10-24 Thread Fan Zhang
This patch adds symmetric crypto action support to softnic. Signed-off-by: Fan Zhang --- drivers/net/softnic/rte_eth_softnic_action.c| 11 +++ drivers/net/softnic/rte_eth_softnic_internals.h | 2 ++ drivers/net/softnic/rte_eth_softnic_thread.c| 10 ++ 3 files changed, 23

[dpdk-dev] [PATCH 5/5] doc: update release note

2018-10-24 Thread Fan Zhang
This patch updates the release note to annouce the changes made to softnic PMD. Signed-off-by: Fan Zhang --- doc/guides/rel_notes/release_18_11.rst | 6 ++ 1 file changed, 6 insertions(+) diff --git a/doc/guides/rel_notes/release_18_11.rst b/doc/guides/rel_notes/release_18_11.rst index 246

Re: [dpdk-dev] [PATCH v5 8/8] doc/guides/sample_app_ug: add guides for fips validation

2018-10-24 Thread Akhil Goyal
++ John On 10/17/2018 6:19 PM, Marko Kovacevic wrote: > Document explains how to run the fips sample app > and instructions users need to parser all the request > files and generate the response files. > > Signed-off-by: Marko Kovacevic > Signed-off-by: Fan Zhang > Acked-by: Arek Kusztal > ---

Re: [dpdk-dev] [PATCH 0/3] fix flow tunnel handling

2018-10-24 Thread Shahaf Shuler
Wednesday, October 24, 2018 3:36 PM, Shahaf Shuler: > Subject: [dpdk-dev] [PATCH 0/3] fix flow tunnel handling > > This patchset fix multiple issues with tunnel rule handling in the PMD's flow > engine. > Series applied to next-net-mlx, thanks. > Yongseok Koh (3): > net/mlx5: rename static f

Re: [dpdk-dev] [PATCH 1/2] net/mlx5: add VXLAN encap decap to Direct Verbs

2018-10-24 Thread Ori Kam
> -Original Message- > From: Dekel Peled > Sent: Wednesday, October 24, 2018 2:08 PM > To: Yongseok Koh ; Shahaf Shuler > > Cc: dev@dpdk.org; Ori Kam > Subject: [PATCH 1/2] net/mlx5: add VXLAN encap decap to Direct Verbs > > This patch adds support for VXLAN encap and decap operation

Re: [dpdk-dev] [dpdk-stable] [PATCH] kvargs: fix processing a null list

2018-10-24 Thread Thomas Monjalon
24/10/2018 11:34, Olivier Matz: > On Tue, Oct 23, 2018 at 06:24:54PM +0200, Thomas Monjalon wrote: > > In the doxygen description of rte_kvargs_process(), it is said: > > If *kvlist* is NULL function does nothing. > > It has been added by mistake here instead of rte_kvargs_free(). > > Anyway, n

Re: [dpdk-dev] [PATCH v1 2/2] test/crypto: remove data verification at rsa verify operation

2018-10-24 Thread Akhil Goyal
>>> @@ -153,10 +153,13 @@ test_rsa_sign_verify(void) >>>goto error_exit; >>>} >>>status = TEST_SUCCESS; >>> - int ret = 0; >>> - ret = rsa_verify(&rsaplaintext, result_op); >>> - if (ret) >>> + if (result_op->status != RTE_CRYPTO_OP_STATUS_SUCCESS) {

[dpdk-dev] [PATCH] ethdev: filter destroy event before probed

2018-10-24 Thread Thomas Monjalon
If a port is being created and rollbacked because of an error, the event RTE_ETH_EVENT_DESTROY should not be sent. It makes no sense to receive a destroy event for a port which was not yet announced via RTE_ETH_EVENT_NEW. Signed-off-by: Thomas Monjalon --- lib/librte_ethdev/rte_ethdev.c | 4 +++-

[dpdk-dev] [PATCH] ethdev: fix iterator default behaviour for representors

2018-10-24 Thread Thomas Monjalon
The iterator was matching all representors if it was not specified in the devargs string. It was a wrong default behaviour. If there is no representor parameter in the devargs, the iterator should not match any representor port. The implementation of the default behaviour would be simpler if a "n

Re: [dpdk-dev] [PATCH v4 1/3] net/mlx5: allow multiple probing for representor

2018-10-24 Thread Shahaf Shuler
Tuesday, October 23, 2018 9:26 PM, Ophir Munk: > Subject: [PATCH v4 1/3] net/mlx5: allow multiple probing for representor > > Implement probing of a rte device multiple times, see [1]. > Set PCI driver RTE_PCI_DRV_PROBE_AGAIN flag to enable multiple probing > of the PCI device by the PCI common dr

[dpdk-dev] [PATCH] vhost/crypto: fix incorrect copy

2018-10-24 Thread Fan Zhang
This patch fixes the incorrect packet content copy in the chaining operation in the copy mode. Originally the content before cipher offset is overwritten by all zeros. This patch fixes the problem by: 1. Instead of allocating 2 mbufs for each virtio crypto data request in copy and zero-copy modes

Re: [dpdk-dev] [PATCH] ethdev: fix iterator default behaviour for representors

2018-10-24 Thread Thomas Monjalon
24/10/2018 15:13, Thomas Monjalon: > The iterator was matching all representors if it was not specified > in the devargs string. It was a wrong default behaviour. > > If there is no representor parameter in the devargs, the iterator > should not match any representor port. > > The implementation

[dpdk-dev] [PATCH v7 01/13] eal: add option register infrastructure

2018-10-24 Thread Kevin Laatz
This commit adds infrastructure to EAL that allows an application to register it's init function with EAL. This allows libraries to be initialized at the end of EAL init. This infrastructure allows libraries that depend on EAL to be initialized as part of EAL init, removing circular dependency iss

[dpdk-dev] [PATCH v7 02/13] eal: make get runtime dir function public

2018-10-24 Thread Kevin Laatz
This patch makes the eal_get_runtime_dir() API public so it can be used from outside EAL. Signed-off-by: Kevin Laatz Acked-by: Harry van Haaren --- lib/librte_eal/bsdapp/eal/eal.c | 2 +- lib/librte_eal/common/eal_filesystem.h | 15 --- lib/librte_eal/common/include/rte_ea

[dpdk-dev] [PATCH v7 00/13] introduce telemetry library

2018-10-24 Thread Kevin Laatz
This patchset introduces a Telemetry library for DPDK Service Assurance. This library provides an easy way to query DPDK Ethdev metrics. The telemetry library provides a method for a service assurance component to retrieve metrics from a DPDK packet forwarding application. Communicating from the s

[dpdk-dev] [PATCH v7 04/13] telemetry: add initial connection socket

2018-10-24 Thread Kevin Laatz
From: Ciara Power This patch adds the telemetry UNIX socket. It is used to allow connections from external clients. On the initial connection from a client, ethdev stats are registered in the metrics library, to allow for their retrieval at a later stage. Signed-off-by: Ciara Power Signed-off-

[dpdk-dev] [PATCH v7 03/13] telemetry: initial telemetry infrastructure

2018-10-24 Thread Kevin Laatz
From: Ciara Power This patch adds the infrastructure and initial code for the telemetry library. The telemetry init is registered with eal_init(). We can then check to see if --telemetry was passed as an eal option. If --telemetry was parsed, then we call telemetry init at the end of eal init.

[dpdk-dev] [PATCH v7 05/13] telemetry: add client feature and sockets

2018-10-24 Thread Kevin Laatz
From: Ciara Power This patch introduces clients to the telemetry API. When a client makes a connection through the initial telemetry socket, they can send a message through the socket to be parsed. Register messages are expected through this socket, to enable clients to register and have a clien

[dpdk-dev] [PATCH v7 06/13] telemetry: add parser for client socket messages

2018-10-24 Thread Kevin Laatz
From: Ciara Power This patch adds the parser file. This is used to parse any messages that are received on any of the client sockets. Currently, the unregister functionality works using the parser. Functionality relating to getting statistic values for certain ports will be added in a subsequent

[dpdk-dev] [PATCH v7 09/13] telemetry: add tests for telemetry api

2018-10-24 Thread Kevin Laatz
From: Ciara Power This patch adds all tests for the Telemetry API. The tests added include a parser test, selftest, and socket messaging tests. The parser tests pass valid and invalid messages to the parser to ensure the correct return values are received. The selftest tests basic functions in t

[dpdk-dev] [PATCH v7 08/13] telemetry: format json response when sending stats

2018-10-24 Thread Kevin Laatz
From: Ciara Power This patch adds functionality to create a JSON message in order to send it to a client socket. When stats are requested by a client, they are retrieved from the metrics library and encoded in JSON format. Signed-off-by: Ciara Power Signed-off-by: Brian Archbold Signed-off-by

[dpdk-dev] [PATCH v7 10/13] telemetry: add ability to disable selftest

2018-10-24 Thread Kevin Laatz
From: Ciara Power This patch adds functionality to enable/disable the selftest. This functionality will be extended in future to make the enabling/disabling more dynamic and remove this 'hardcoded' approach. We are temporarily using this approach due to the design changes (vdev vs eal) made to t

[dpdk-dev] [PATCH v7 07/13] telemetry: update metrics before sending stats

2018-10-24 Thread Kevin Laatz
From: Ciara Power This patch adds functionality to update the statistics in the metrics library with values from the ethdev stats. Values need to be updated before they are encoded into a JSON message and sent to the client that requested them. The JSON encoding will be added in a subsequent pat

[dpdk-dev] [PATCH v7 12/13] usertools: add client python script for telemetry

2018-10-24 Thread Kevin Laatz
From: Ciara Power This patch adds a python script which can be used as a demo client. The script is interactive and will allow the user to register, request statistics, and unregister. To run the script, an argument for the client file path must be passed in: "python telemetry_client.py ". This

[dpdk-dev] [PATCH v7 11/13] doc: add telemetry documentation

2018-10-24 Thread Kevin Laatz
From: Ciara Power This patch adds all documentation for telemetry. A description on how to use the Telemetry API with a DPDK application is given in this document. It also adds the MAINTAINERS file entry and a release notes update for telemetry. Signed-off-by: Ciara Power Signed-off-by: Brian

[dpdk-dev] [PATCH v7 13/13] build: add dependency on telemetry to apps in meson

2018-10-24 Thread Kevin Laatz
This patch adds telemetry as a dependecy to all applications. Without these changes, the --telemetry flag will not be recognised and applications will fail to run if they want to enable telemetry. Signed-off-by: Bruce Richardson Signed-off-by: Kevin Laatz Acked-by: Harry van Haaren --- app/mes

[dpdk-dev] [PATCH 1/5] app/testpmd: check not detaching device twice

2018-10-24 Thread Thomas Monjalon
The command "port detach" is removing the EAL rte_device of the ethdev port specified as parameter. The function name and some comments are updated to make clear that we are detaching the whole device. After detaching, the pointer, which maps a port to its device, is reset. This way, it is possibl

[dpdk-dev] [PATCH 0/5] app/testpmd: improve attach/detach support

2018-10-24 Thread Thomas Monjalon
While working on EAL probe/remove and ethdev iterator/close, some scenarios appeared to not be managed by testpmd, especially because it was not designed for multi-ports devices: - configure dependent port (detected via event) - configuring twice (if already probed before) - detaching twice

[dpdk-dev] [PATCH 3/5] app/testpmd: check not configuring port twice

2018-10-24 Thread Thomas Monjalon
It is possible to request probing of a device twice, and possibly get new ports for this device. However, the ports which were already probed and setup must not be setup again. That's why it is checked whether the port is already part of fwd_ports_ids array at the beginning of the function setup_at

[dpdk-dev] [PATCH 4/5] app/testpmd: move ethdev events registration

2018-10-24 Thread Thomas Monjalon
The callback for ethdev events was registered on port start, so it was missing some events. It is now registered at the beginning of the main function. Signed-off-by: Thomas Monjalon --- app/test-pmd/testpmd.c | 72 -- 1 file changed, 42 insertions(+), 30

[dpdk-dev] [PATCH 2/5] app/testpmd: merge ports list update functions

2018-10-24 Thread Thomas Monjalon
The arrays ports_ids and fwd_ports_ids require the same kind of update when some ports are removed or added. The functions update_fwd_ports() and remove_unused_fwd_ports() are merged in the new function remove_invalid_ports(). The part for adding new port is moved into setup_attached_port(). Sign

[dpdk-dev] [PATCH 5/5] app/testpmd: setup attached ports on probe event

2018-10-24 Thread Thomas Monjalon
After probing is done, each new port must be setup. The new ports are currently guessed by iterating on ports matching the devargs string used for probing. When probing a port, it is possible that one more port probing get triggered (e.g. PF is automatically probed when probing a VF representor).

Re: [dpdk-dev] [PATCH 2/2] net/mlx5: add NVGRE encap decap to Direct Verbs

2018-10-24 Thread Ori Kam
> -Original Message- > From: dev On Behalf Of Dekel Peled > Sent: Wednesday, October 24, 2018 2:08 PM > To: Yongseok Koh ; Shahaf Shuler > > Cc: dev@dpdk.org; Ori Kam > Subject: [dpdk-dev] [PATCH 2/2] net/mlx5: add NVGRE encap decap to Direct > Verbs > > This patch adds support for N

Re: [dpdk-dev] [PATCH v7 01/13] eal: add option register infrastructure

2018-10-24 Thread Gaëtan Rivet
Hi Kevin, On Wed, Oct 24, 2018 at 02:27:13PM +0100, Kevin Laatz wrote: > This commit adds infrastructure to EAL that allows an application to > register it's init function with EAL. This allows libraries to be > initialized at the end of EAL init. > > This infrastructure allows libraries that dep

  1   2   3   >