Re: [dpdk-dev] [PATCH 2/5] ethdev: add an iterator to match some devargs input

2018-10-08 Thread Andrew Rybchenko
On 10/8/18 1:25 AM, Thomas Monjalon wrote: Signed-off-by: Thomas Monjalon --- lib/librte_eal/common/include/rte_common.h | 6 ++ lib/librte_ethdev/ethdev_private.c | 10 ++- lib/librte_ethdev/ethdev_private.h | 6 ++ lib/librte_ethdev/rte_ethdev.c | 87

Re: [dpdk-dev] [PATCH 3/5] ethdev: allow iterating with only class filter

2018-10-08 Thread Andrew Rybchenko
On 10/8/18 1:25 AM, Thomas Monjalon wrote: If no rte_device is given in the iterator, eth_dev_match() is looking at all ports without any restriction, except the ethdev kvargs filter. It allows to iterate with a devargs filter referencing only some ethdev parameters. The format (from the new dev

Re: [dpdk-dev] [PATCH 4/5] ethdev: remove deprecated attach/detach functions

2018-10-08 Thread Andrew Rybchenko
On 10/8/18 1:25 AM, Thomas Monjalon wrote: The hotplug attach/detach features are implemented in EAL layer. There is a new ethdev iterator to retrieve ports from ethdev layer. As announced earlier, the (buggy) ethdev functions are now removed. Signed-off-by: Thomas Monjalon <...> diff --gi

Re: [dpdk-dev] [PATCH 1/5] bus/vdev: add iteration filter on name

2018-10-08 Thread Thomas Monjalon
08/10/2018 08:46, Andrew Rybchenko: > On 10/8/18 1:25 AM, Thomas Monjalon wrote: > > A virtual device can be matched with following syntax: > > bus=vdev,name=X > > > > Signed-off-by: Thomas Monjalon > > --- > > drivers/bus/vdev/vdev_params.c | 21 ++--- > > 1 file changed, 1

Re: [dpdk-dev] [PATCH 2/5] ethdev: add an iterator to match some devargs input

2018-10-08 Thread Thomas Monjalon
08/10/2018 09:06, Andrew Rybchenko: > On 10/8/18 1:25 AM, Thomas Monjalon wrote: > > --- a/lib/librte_eal/common/include/rte_common.h > > +++ b/lib/librte_eal/common/include/rte_common.h > > @@ -164,6 +164,12 @@ static void __attribute__((destructor(RTE_PRIO(prio)), > > used)) func(void) > >*/

Re: [dpdk-dev] [PATCH v3 1/3] drivers/bus: move driver assignment to end of probing

2018-10-08 Thread Andrew Rybchenko
On 10/8/18 1:09 AM, Thomas Monjalon wrote: The PCI mapping requires to know the PCI driver to use, even before the probing is done. That's why the PCI driver is referenced early inside the PCI device structure. See 1d20a073fa5e ("bus/pci: reference driver structure before mapping") However the r

Re: [dpdk-dev] [PATCH v3 3/3] eal: allow probing a device again

2018-10-08 Thread Andrew Rybchenko
On 10/8/18 1:09 AM, Thomas Monjalon wrote: In the devargs syntax for device representors, it is possible to add several devices at once: -w dbdf,representor=[0-3] It will become a more frequent case when introducing wildcards and ranges in the new devargs syntax. If a devargs string is provided

Re: [dpdk-dev] [PATCH v3 2/3] eal: add function to query device status

2018-10-08 Thread Andrew Rybchenko
On 10/8/18 1:09 AM, Thomas Monjalon wrote: The function rte_dev_is_probed() is added in order to improve semantic and enforce proper check of the probing status of a device. It will answer this rte_device query: Is it already successfully probed or not? Signed-off-by: Thomas Monjalon Reviewe

Re: [dpdk-dev] [PATCH 3/5] ethdev: allow iterating with only class filter

2018-10-08 Thread Thomas Monjalon
08/10/2018 09:20, Andrew Rybchenko: > On 10/8/18 1:25 AM, Thomas Monjalon wrote: > > If no rte_device is given in the iterator, > > eth_dev_match() is looking at all ports without any restriction, > > except the ethdev kvargs filter. > > > > It allows to iterate with a devargs filter referencing on

Re: [dpdk-dev] [PATCH 4/5] ethdev: remove deprecated attach/detach functions

2018-10-08 Thread Thomas Monjalon
08/10/2018 09:28, Andrew Rybchenko: > On 10/8/18 1:25 AM, Thomas Monjalon wrote: > > The hotplug attach/detach features are implemented in EAL layer. > > There is a new ethdev iterator to retrieve ports from ethdev layer. > > > > As announced earlier, the (buggy) ethdev functions are now removed. >

Re: [dpdk-dev] [PATCH v2 1/4] ethdev: add Rx offload outer UDP checksum definition

2018-10-08 Thread Ferruh Yigit
On 10/6/2018 1:18 PM, Ananyev, Konstantin wrote: > > >> -Original Message- >> From: Jerin Jacob [mailto:jerin.ja...@caviumnetworks.com] >> Sent: Saturday, October 6, 2018 9:16 AM >> To: Thomas Monjalon >> Cc: Yigit, Ferruh ; Andrew Rybchenko >> ; Lu, Wenzhuo ; Wu, >> Jingjing ; Iremonge

Re: [dpdk-dev] [PATCH v2 1/4] ethdev: add Rx offload outer UDP checksum definition

2018-10-08 Thread Jerin Jacob
-Original Message- > Date: Mon, 8 Oct 2018 09:12:34 +0100 > From: Ferruh Yigit > To: "Ananyev, Konstantin" , Jerin Jacob > , Thomas Monjalon > CC: Andrew Rybchenko , "Lu, Wenzhuo" > , "Wu, Jingjing" , > "Iremonger, Bernard" , "Mcnamara, John" > , "Kovacevic, Marko" , > Olivier Matz ,

[dpdk-dev] [PATCH 3/3] net/mlx5: always use representor ifindex for ioctl

2018-10-08 Thread Shahaf Shuler
In the current code, on some cases the representor ethdev is using the PF interface to query some link status information or pause parameters. It was done because in previous kernel versions there was no support from the kernel for the representor info. Using the PF i/f for such ioctl is error pr

Re: [dpdk-dev] [PATCH] eal/armv7: add support for rte pause

2018-10-08 Thread Ola Liljedahl
On 08/10/2018, 08:27, "Jerin Jacob" wrote: -Original Message- > Date: Sun, 7 Oct 2018 21:09:25 + > From: Ola Liljedahl > To: Jerin Jacob , Jan Viktorin > , "Gavin Hu (Arm Technology China)" > > CC: "dev@dpdk.org" , "tho...@monjalon.net" > >

[dpdk-dev] [PATCH 0/3] Representor fixes for BlueField device

2018-10-08 Thread Shahaf Shuler
Setting BlueField device with representors introduced some corner cases that were overlooked during the development of representors for x86. This series enables the PMD to run on both x86 and BlueField with representors enabled. Shahaf Shuler (3): net/mlx5: support missing counter in extended

[dpdk-dev] [PATCH 1/3] net/mlx5: support missing counter in extended statistics

2018-10-08 Thread Shahaf Shuler
The current code would fail if one of the counters DPDK counters was not found on the device counters. As representors and PF port has different counters the both cannot work together. Addressing this issue by making the counter init more flexible to contain all the counter found and skipping the

[dpdk-dev] [PATCH 2/3] net/mlx5: add representor specific statistics

2018-10-08 Thread Shahaf Shuler
Representor ports has a different set of extended statistics (as those are logical ports which cannot count all that the PF can). Cc: sta...@dpdk.org Cc: xuemi...@mellanox.com Signed-off-by: Shahaf Shuler --- drivers/net/mlx5/mlx5_stats.c | 17 + 1 file changed, 17 insertions(+)

Re: [dpdk-dev] [PATCH] eal/armv7: add support for rte pause

2018-10-08 Thread Jerin Jacob
-Original Message- > Date: Mon, 8 Oct 2018 08:25:28 + > From: Ola Liljedahl > To: Jerin Jacob > CC: Jan Viktorin , "Gavin Hu (Arm Technology > China)" , "dev@dpdk.org" , > "tho...@monjalon.net" > Subject: Re: [dpdk-dev] [PATCH] eal/armv7: add support for rte pause > user-agent: Mic

Re: [dpdk-dev] [PATCH] net/e1000: do not error out if rx_drop_en is set

2018-10-08 Thread Zhao1, Wei
Hi, Luca Boccassi > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Luca Boccassi > Sent: Saturday, July 28, 2018 1:26 AM > To: dev@dpdk.org > Cc: Lu, Wenzhuo ; Luca Boccassi > ; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH] net/e1000: do not error out if rx_drop

Re: [dpdk-dev] [PATCH v2 4/4] lib: reduce global variable usage

2018-10-08 Thread Shreyansh Jain
On Friday 05 October 2018 09:56 PM, Ferruh Yigit wrote: Some global variables can be eliminated, since they are not part of public interface, it is free to remove them. Signed-off-by: Ferruh Yigit --- lib/librte_compressdev/rte_compressdev.c | 32 -- lib/librte_compressde

Re: [dpdk-dev] [PATCH] malloc: respect SIZE_HINT_ONLY when looking for the biggest free elem

2018-10-08 Thread Burakov, Anatoly
On 07-Oct-18 8:31 PM, Darek Stojaczyk wrote: RTE_MEMZONE_SIZE_HINT_ONLY wasn't checked in any way, causing size hints to be parsed as hard requirements. This resulted in some allocations being failed prematurely. Fixes: 68b6092bd3c7 ("malloc: allow reserving biggest element") Cc: anatoly.bura...

Re: [dpdk-dev] [PATCH v2 1/4] ethdev: add Rx offload outer UDP checksum definition

2018-10-08 Thread Thomas Monjalon
08/10/2018 10:24, Jerin Jacob: > From: Ferruh Yigit > > On 10/6/2018 1:18 PM, Ananyev, Konstantin wrote: > > > From: Jerin Jacob [mailto:jerin.ja...@caviumnetworks.com] > > >> From: Thomas Monjalon > > >>> However, we should re-visit the flag PKT_RX_EIP_CKSUM_BAD. > > >> > > >> Do we need to bloc

[dpdk-dev] [PATCH v3] net/softnic: add flow flush API

2018-10-08 Thread Reshma Pattan
Add rte flow flush api for flushing all the flows of the port. Signed-off-by: Reshma Pattan --- v3: Some style related changes v2: Use TAILQ_FOREACH_SAFE instead of TAILQ_FOREACH for safe removal using TAILQ_REMOVAL. --- drivers/net/softnic/rte_eth_softnic_flow.c | 47 +- 1 f

[dpdk-dev] [PATCH v3 1/4] config: use one single config option for C11 memory model

2018-10-08 Thread Phil Yang
Keep only single config option RTE_USE_C11_MEM_MODEL for C11 memory model, so all modules can leverage C11 atomic extension by enable this option. Signed-off-by: Phil Yang Reviewed-by: Honnappa Nagarahalli Reviewed-by: Gavin Hu Acked-by: Jerin Jacob --- config/arm/meson.build

Re: [dpdk-dev] [PATCH v2 4/4] lib: reduce global variable usage

2018-10-08 Thread Ferruh Yigit
On 10/8/2018 9:45 AM, Shreyansh Jain wrote: > On Friday 05 October 2018 09:56 PM, Ferruh Yigit wrote: >> Some global variables can be eliminated, since they are not part of >> public interface, it is free to remove them. >> >> Signed-off-by: Ferruh Yigit >> --- >> lib/librte_compressdev/rte_comp

[dpdk-dev] [PATCH v3 2/4] kni: fix kni fifo synchronization

2018-10-08 Thread Phil Yang
With existing code in kni_fifo_put, rx_q values are not being updated before updating fifo_write. While reading rx_q in kni_net_rx_normal, This is causing the sync issue on other core. The same situation happens in kni_fifo_get as well. So syncing the values by adding memory barriers to make sure

[dpdk-dev] [PATCH v3 3/4] kni: fix kni kernel fifo synchronization

2018-10-08 Thread Phil Yang
Adding memory barrier to make sure the values being synced before updating fifo_write in kni_fifo_put and fifo_read in kni_fifo_get. Fixes: 3fc5ca2 ("kni: initial import") Signed-off-by: Phil Yang Reviewed-by: Honnappa Nagarahalli Reviewed-by: Gavin Hu --- kernel/linux/kni/kni_fifo.h

[dpdk-dev] [PATCH v3 4/4] kni: introduce c11 atomic into kni fifo synchronization

2018-10-08 Thread Phil Yang
Syncing the values by adding c11 atomic memory barriers to make sure the values being synced before updating fifo_write and fifo_read. Signed-off-by: Phil Yang Reviewed-by: Honnappa Nagarahalli Reviewed-by: Gavin Hu Reviewed-by: Ola Liljedahl --- .../linuxapp/eal/include/exec-env/rte_kni_comm

Re: [dpdk-dev] [PATCH 3/5] ethdev: allow iterating with only class filter

2018-10-08 Thread Andrew Rybchenko
On 10/8/18 11:07 AM, Thomas Monjalon wrote: 08/10/2018 09:20, Andrew Rybchenko: On 10/8/18 1:25 AM, Thomas Monjalon wrote: If no rte_device is given in the iterator, eth_dev_match() is looking at all ports without any restriction, except the ethdev kvargs filter. It allows to iterate with a de

Re: [dpdk-dev] [PATCH v3 1/3] ring: read tail using atomic load

2018-10-08 Thread Ola Liljedahl
On 08/10/2018, 08:06, "Jerin Jacob" wrote: -Original Message- > Date: Sun, 7 Oct 2018 20:44:54 + > From: Ola Liljedahl > To: Jerin Jacob > CC: "dev@dpdk.org" , Honnappa Nagarahalli > , "Ananyev, Konstantin" > , "Gavin Hu (Arm Technology China)" > ,

Re: [dpdk-dev] [PATCH v2 1/3] ethdev: add flow api actions to modify IP addresses

2018-10-08 Thread Andrew Rybchenko
On 10/6/18 6:41 PM, Rahul Lakkireddy wrote: Add actions: - SET_IPV4_SRC - set a new IPv4 source address. - SET_IPV4_DST - set a new IPv4 destination address. - SET_IPV6_SRC - set a new IPv6 source address. - SET_IPV6_DST - set a new IPv6 destination address. Original work by Shagun Agrawal Sign

Re: [dpdk-dev] [PATCH v2 2/3] ethdev: add flow api actions to modify TCP/UDP port numbers

2018-10-08 Thread Andrew Rybchenko
On 10/6/18 6:41 PM, Rahul Lakkireddy wrote: Add actions: - SET_TP_SRC - set a new TCP/UDP source port number. - SET_TP_DST - set a new TCP/UDP destination port number. Original work by Shagun Agrawal Signed-off-by: Rahul Lakkireddy Acked-by: Xiaoyu Min Acked-by: Ori Kam One nit below, othe

Re: [dpdk-dev] [PATCH v2 4/4] lib: reduce global variable usage

2018-10-08 Thread Shreyansh Jain
On Monday 08 October 2018 02:41 PM, Ferruh Yigit wrote: On 10/8/2018 9:45 AM, Shreyansh Jain wrote: On Friday 05 October 2018 09:56 PM, Ferruh Yigit wrote: Some global variables can be eliminated, since they are not part of public interface, it is free to remove them. Signed-off-by: Ferruh Yig

Re: [dpdk-dev] [PATCH 1/3] ethdev: add generic MAC address rewrite actions

2018-10-08 Thread Andrew Rybchenko
On 9/25/18 6:03 PM, Xiaoyu Min wrote: rte_flow actions: - RTE_FLOW_ACTION_TYPE_SET_MAC_SRC - RTE_FLOW_ACTION_TYPE_SET_MAC_DST added in order to offload to NIC The rte_flow_itme_eth must be present in rte_flow pattern Signed-off-by: Xiaoyu Min Acked-by: Andrew Rybchenko

Re: [dpdk-dev] [PATCH v2 1/4] ethdev: add Rx offload outer UDP checksum definition

2018-10-08 Thread Jerin Jacob
-Original Message- > Date: Mon, 08 Oct 2018 11:04:51 +0200 > From: Thomas Monjalon > To: Jerin Jacob , Ferruh Yigit > , "Ananyev, Konstantin" > > Cc: Andrew Rybchenko , "Lu, Wenzhuo" > , "Wu, Jingjing" , > "Iremonger, Bernard" , "Mcnamara, John" > , "Kovacevic, Marko" , > Olivier Ma

Re: [dpdk-dev] [PATCH v2 1/4] add missing static keyword to globals

2018-10-08 Thread Shreyansh Jain
On Friday 05 October 2018 09:56 PM, Ferruh Yigit wrote: Some global variables can indeed be static, add static keyword to them. Signed-off-by: Ferruh Yigit --- Series is based on next-net tree --- [...] drivers/bus/dpaa/base/fman/netcfg_layer.c | 2 +- drivers/bus/dpaa/dpaa_bus

Re: [dpdk-dev] [PATCH] net/ixgbe: put 5tuple check in front to jump over ntuple filter case

2018-10-08 Thread Zhao1, Wei
Hi, > -Original Message- > From: Zhang, Qi Z > Sent: Wednesday, September 26, 2018 7:14 PM > To: mocan ; Zhao1, Wei > Cc: dev@dpdk.org > Subject: RE: Re:RE: [dpdk-dev] [PATCH] net/ixgbe: put 5tuple check in front > to jump over ntuple filter case > > OK, got your point. We should not

Re: [dpdk-dev] [PATCH] net/e1000: do not error out if rx_drop_en is set

2018-10-08 Thread Zhao1, Wei
Add Qi for discussion. > -Original Message- > From: Zhao1, Wei > Sent: Monday, October 8, 2018 4:43 PM > To: 'Luca Boccassi' ; dev@dpdk.org > Cc: Lu, Wenzhuo ; sta...@dpdk.org > Subject: RE: [dpdk-dev] [PATCH] net/e1000: do not error out if rx_drop_en is > set > > Hi, Luca Boccassi > >

Re: [dpdk-dev] [PATCH 1/3] security: support pdcp protocol

2018-10-08 Thread Akhil Goyal
Hi Anoob, @@ -494,6 +553,23 @@ IPsec related configuration parameters are defined in ``rte_security_ipsec_xform    /**< Tunnel parameters, NULL for transport mode */    }; +PDCP related configuration parameters are defined in ``rte_security_pdcp_xform`` + +.. code-block:: c + +   

Re: [dpdk-dev] [PATCH v3 1/3] ring: read tail using atomic load

2018-10-08 Thread Jerin Jacob
-Original Message- > Date: Mon, 8 Oct 2018 09:22:05 + > From: Ola Liljedahl > To: Jerin Jacob > CC: "dev@dpdk.org" , Honnappa Nagarahalli > , "Ananyev, Konstantin" > , "Gavin Hu (Arm Technology China)" > , Steve Capper , nd , > "sta...@dpdk.org" > Subject: Re: [PATCH v3 1/3] ring

Re: [dpdk-dev] [PATCH v3 1/3] ring: read tail using atomic load

2018-10-08 Thread Ola Liljedahl
Or maybe performance gets worse but not because of that one additional instruction/cycle in ring buffer enqueue and dequeue but because function or loop alignment changed for one or more functions. When the benchmarking noise (possibly several % due to changes in code alignment) is bigger than

Re: [dpdk-dev] [PATCH v4 1/3] app/testpmd: move dumping packets to a separate function

2018-10-08 Thread Iremonger, Bernard
> -Original Message- > From: Raslan Darawsheh [mailto:rasl...@mellanox.com] > Sent: Sunday, October 7, 2018 8:38 AM > To: Wu, Jingjing > Cc: Thomas Monjalon ; dev@dpdk.org; Shahaf Shuler > ; Raslan Darawsheh ; > Xueming(Steven) Li ; Ori Kam > ; jerin.ja...@caviumnetworks.com; > david.march

Re: [dpdk-dev] [PATCH v4 2/3] app/testpmd: add packet dump callback functions

2018-10-08 Thread Iremonger, Bernard
> -Original Message- > From: Raslan Darawsheh [mailto:rasl...@mellanox.com] > Sent: Sunday, October 7, 2018 8:38 AM > To: Wu, Jingjing > Cc: Thomas Monjalon ; dev@dpdk.org; Shahaf Shuler > ; Raslan Darawsheh ; > Xueming(Steven) Li ; Ori Kam > ; jerin.ja...@caviumnetworks.com; > david.march

Re: [dpdk-dev] [PATCH v4 3/3] app/testpmd: set packet dump based on verbosity level

2018-10-08 Thread Iremonger, Bernard
> -Original Message- > From: Raslan Darawsheh [mailto:rasl...@mellanox.com] > Sent: Sunday, October 7, 2018 8:38 AM > To: Wu, Jingjing > Cc: Thomas Monjalon ; dev@dpdk.org; Shahaf Shuler > ; Raslan Darawsheh ; > Xueming(Steven) Li ; Ori Kam > ; jerin.ja...@caviumnetworks.com; > david.march

Re: [dpdk-dev] [PATCH v3 1/3] ring: read tail using atomic load

2018-10-08 Thread Ola Liljedahl
On 08/10/2018, 12:00, "Jerin Jacob" wrote: -Original Message- > Date: Mon, 8 Oct 2018 09:22:05 + > From: Ola Liljedahl > To: Jerin Jacob > CC: "dev@dpdk.org" , Honnappa Nagarahalli > , "Ananyev, Konstantin" > , "Gavin Hu (Arm Technology China)" >

Re: [dpdk-dev] [PATCH v3] net/softnic: add flow flush API

2018-10-08 Thread Singh, Jasvinder
> -Original Message- > From: Pattan, Reshma > Sent: Monday, October 8, 2018 10:10 AM > To: dev@dpdk.org; Dumitrescu, Cristian ; > Singh, Jasvinder > Cc: Pattan, Reshma > Subject: [PATCH v3] net/softnic: add flow flush API > > Add rte flow flush api for flushing > all the flows of the

Re: [dpdk-dev] [PATCH v3 1/3] ring: read tail using atomic load

2018-10-08 Thread Gavin Hu (Arm Technology China)
I did benchmarking w/o and w/ the patch, it did not show any noticeable differences in terms of latency. Here is the full log( 3 runs w/o the patch and 2 runs w/ the patch). sudo ./test/test/test -l 16-19,44-47,72-75,100-103 -n 4 --socket-mem=1024 -- -i RTE>>ring_perf_autotest (#1 run of test w

Re: [dpdk-dev] [PATCH v3] net/softnic: add flow flush API

2018-10-08 Thread Dumitrescu, Cristian
> -Original Message- > From: Pattan, Reshma > Sent: Monday, October 8, 2018 10:10 AM > To: dev@dpdk.org; Dumitrescu, Cristian ; > Singh, Jasvinder > Cc: Pattan, Reshma > Subject: [PATCH v3] net/softnic: add flow flush API > > Add rte flow flush api for flushing > all the flows of the

Re: [dpdk-dev] [PATCH v2] testpmd: sfp eeprom display

2018-10-08 Thread Iremonger, Bernard
Hi Gaetan > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Gaetan Rivet > Sent: Friday, October 5, 2018 10:59 PM > To: dev@dpdk.org > Cc: Gaetan Rivet ; Yigit, Ferruh > > Subject: [dpdk-dev] [PATCH v2] testpmd: sfp eeprom display ./devtools/check-git-log.sh Wr

Re: [dpdk-dev] [PATCH v3 1/3] ring: read tail using atomic load

2018-10-08 Thread Ola Liljedahl
On 08/10/2018, 12:33, "Gavin Hu (Arm Technology China)" wrote: I did benchmarking w/o and w/ the patch, it did not show any noticeable differences in terms of latency. Which platform is this? Here is the full log( 3 runs w/o the patch and 2 runs w/ the patch). sudo ./test/tes

Re: [dpdk-dev] [PATCH v3 1/3] ring: read tail using atomic load

2018-10-08 Thread Gavin Hu (Arm Technology China)
This is ThunderX2. > -Original Message- > From: Ola Liljedahl > Sent: Monday, October 8, 2018 6:39 PM > To: Gavin Hu (Arm Technology China) ; Jerin Jacob > > Cc: dev@dpdk.org; Honnappa Nagarahalli > ; Ananyev, Konstantin > ; Steve Capper ; > nd ; sta...@dpdk.org > Subject: Re: [PATCH v3 1

[dpdk-dev] [PATCH 0/8] examples/l2fwd: fix checkpatch reported issues

2018-10-08 Thread Anoob Joseph
This patchset fixes multiple issues reported by checkpatch in l2fwd code base. These issues would be flagged for any new copy of the file and hence, fixing at the source. Anoob Joseph (8): examples/l2fwd: remove quoted white space before newline examples/l2fwd: need space between two args ex

[dpdk-dev] [PATCH 1/8] examples/l2fwd: remove quoted white space before newline

2018-10-08 Thread Anoob Joseph
Remove quoted white space before newline. Signed-off-by: Anoob Joseph --- examples/l2fwd/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/l2fwd/main.c b/examples/l2fwd/main.c index 6c23215..829f981 100644 --- a/examples/l2fwd/main.c +++ b/examples/l2fwd/main.c

[dpdk-dev] [PATCH 4/8] examples/l2fwd: replace bare usage of 'unsigned'

2018-10-08 Thread Anoob Joseph
'unsigned int' is preferred over bare usage of 'unsigned' Signed-off-by: Anoob Joseph --- examples/l2fwd/main.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/examples/l2fwd/main.c b/examples/l2fwd/main.c index d2b7034..cbcd604 100644 --- a/examples/l2

[dpdk-dev] [PATCH 3/8] examples/l2fwd: else should follow close brace

2018-10-08 Thread Anoob Joseph
The 'else' should follow close brace '}' Signed-off-by: Anoob Joseph --- examples/l2fwd/main.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/examples/l2fwd/main.c b/examples/l2fwd/main.c index ae51ac7..d2b7034 100644 --- a/examples/l2fwd/main.c +++ b/examples/l2fwd/main.c

[dpdk-dev] [PATCH 5/8] examples/l2fwd: follow convention for block comments

2018-10-08 Thread Anoob Joseph
Block comments need to use trailing */ on a separate line. Signed-off-by: Anoob Joseph --- examples/l2fwd/main.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/examples/l2fwd/main.c b/examples/l2fwd/main.c index cbcd604..deebef5 100644 --- a/examples/l2fwd/main.c +++ b/exa

[dpdk-dev] [PATCH 2/8] examples/l2fwd: need space between two args

2018-10-08 Thread Anoob Joseph
Space is required after the ',' separating the members. Signed-off-by: Anoob Joseph --- examples/l2fwd/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/l2fwd/main.c b/examples/l2fwd/main.c index 829f981..ae51ac7 100644 --- a/examples/l2fwd/main.c +++ b/examples

[dpdk-dev] [PATCH 7/8] examples/l2fwd: space required between elements

2018-10-08 Thread Anoob Joseph
Space is required after ','. Signed-off-by: Anoob Joseph --- examples/l2fwd/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/l2fwd/main.c b/examples/l2fwd/main.c index c70b839..efb0b59 100644 --- a/examples/l2fwd/main.c +++ b/examples/l2fwd/main.c @@ -114,7 +11

[dpdk-dev] [PATCH 6/8] examples/l2fwd: limit line to 80 char

2018-10-08 Thread Anoob Joseph
Fixing lines exceeding 80 char limit Signed-off-by: Anoob Joseph --- examples/l2fwd/main.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/examples/l2fwd/main.c b/examples/l2fwd/main.c index deebef5..c70b839 100644 --- a/examples/l2fwd/main.c +++ b/examples/l2fw

[dpdk-dev] [PATCH 8/8] examples/l2fwd: remove null initialisation

2018-10-08 Thread Anoob Joseph
Do not initialise statis/globals to NULL. Signed-off-by: Anoob Joseph --- examples/l2fwd/main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/examples/l2fwd/main.c b/examples/l2fwd/main.c index efb0b59..1a1960c 100644 --- a/examples/l2fwd/main.c +++ b/examples/l2fwd/mai

Re: [dpdk-dev] [PATCH v3 1/3] ring: read tail using atomic load

2018-10-08 Thread Jerin Jacob
-Original Message- > Date: Mon, 8 Oct 2018 10:25:45 + > From: Ola Liljedahl > To: Jerin Jacob > CC: "dev@dpdk.org" , Honnappa Nagarahalli > , "Ananyev, Konstantin" > , "Gavin Hu (Arm Technology China)" > , Steve Capper , nd , > "sta...@dpdk.org" > Subject: Re: [PATCH v3 1/3] ring

Re: [dpdk-dev] [PATCH v3 1/3] ring: read tail using atomic load

2018-10-08 Thread Jerin Jacob
-Original Message- > Date: Mon, 8 Oct 2018 10:33:43 + > From: "Gavin Hu (Arm Technology China)" > To: Ola Liljedahl , Jerin Jacob > > CC: "dev@dpdk.org" , Honnappa Nagarahalli > , "Ananyev, Konstantin" > , Steve Capper , nd > , "sta...@dpdk.org" > Subject: RE: [PATCH v3 1/3] ring

Re: [dpdk-dev] [PATCH] eal/armv7: add support for rte pause

2018-10-08 Thread Ola Liljedahl
On 08/10/2018, 10:42, "Jerin Jacob" wrote: -Original Message- > Date: Mon, 8 Oct 2018 08:25:28 + > From: Ola Liljedahl > To: Jerin Jacob > CC: Jan Viktorin , "Gavin Hu (Arm Technology > China)" , "dev@dpdk.org" , > "tho...@monjalon.net" > Subjec

Re: [dpdk-dev] [PATCH v2 1/4] ethdev: add Rx offload outer UDP checksum definition

2018-10-08 Thread Ferruh Yigit
On 10/8/2018 10:37 AM, Jerin Jacob wrote: > -Original Message- >> Date: Mon, 08 Oct 2018 11:04:51 +0200 >> From: Thomas Monjalon >> To: Jerin Jacob , Ferruh Yigit >> , "Ananyev, Konstantin" >> >> Cc: Andrew Rybchenko , "Lu, Wenzhuo" >> , "Wu, Jingjing" , >> "Iremonger, Bernard" , "Mcn

Re: [dpdk-dev] [PATCH 0/8] examples/l2fwd: fix checkpatch reported issues

2018-10-08 Thread Ferruh Yigit
On 10/8/2018 11:41 AM, Anoob Joseph wrote: > This patchset fixes multiple issues reported by checkpatch in l2fwd > code base. These issues would be flagged for any new copy of the file > and hence, fixing at the source. > > Anoob Joseph (8): > examples/l2fwd: remove quoted white space before new

Re: [dpdk-dev] [PATCH] app/testpmd: fix displaying RSS hash functions

2018-10-08 Thread Iremonger, Bernard
> -Original Message- > From: Yigit, Ferruh > Sent: Thursday, October 4, 2018 8:25 PM > To: Lu, Wenzhuo ; Wu, Jingjing > ; Iremonger, Bernard ; > Mcnamara, John ; Kovacevic, Marko > > Cc: dev@dpdk.org; Yigit, Ferruh ; sta...@dpdk.org; > nelio.laranje...@6wind.com > Subject: [PATCH] app/test

[dpdk-dev] [PATCH v4] net/softnic: add flow flush API

2018-10-08 Thread Reshma Pattan
Add rte flow flush api for flushing all the flows of the port. Signed-off-by: Reshma Pattan --- v4: Abort on rule deletion failures only at the end. v3: Some style related changes v2: Use TAILQ_FOREACH_SAFE instead of TAILQ_FOREACH for safe removal using TAILQ_REMOVAL. --- drivers/net/softnic/rt

Re: [dpdk-dev] [PATCH v3 1/3] ring: read tail using atomic load

2018-10-08 Thread Ola Liljedahl
On 08/10/2018, 12:47, "Jerin Jacob" wrote: -Original Message- > Date: Mon, 8 Oct 2018 10:25:45 + > From: Ola Liljedahl > To: Jerin Jacob > CC: "dev@dpdk.org" , Honnappa Nagarahalli > , "Ananyev, Konstantin" > , "Gavin Hu (Arm Technology China)" >

Re: [dpdk-dev] [PATCH] net/mlx5: eswitch-IP address UDP/TCP port rewrite

2018-10-08 Thread Xiaoyu Min
On 18-10-02 04:19:00, Yongseok Koh wrote: > On Sun, Sep 30, 2018 at 03:21:04PM +0800, Xiaoyu Min wrote: > > On 18-09-29 07:03:33, Yongseok Koh wrote: > > > On Tue, Sep 25, 2018 at 07:51:06PM +0800, Xiaoyu Min wrote: > > > > Offload the following rte_flow actions by inserting accordingly > > > > E-S

Re: [dpdk-dev] [PATCH 0/8] examples/l2fwd: fix checkpatch reported issues

2018-10-08 Thread Joseph, Anoob
Hi Ferruh, On 08-10-2018 16:30, Ferruh Yigit wrote: External Email On 10/8/2018 11:41 AM, Anoob Joseph wrote: This patchset fixes multiple issues reported by checkpatch in l2fwd code base. These issues would be flagged for any new copy of the file and hence, fixing at the source. Anoob Joseph

Re: [dpdk-dev] [PATCH v2] app/testpmd: optimize membuf pool allocation

2018-10-08 Thread Ferruh Yigit
On 9/12/2018 2:54 AM, dev-boun...@dpdk.org wrote: > By default, testpmd will create membuf pool for all NUMA nodes and > ignore EAL configuration. > > Count the number of available NUMA according to EAL core mask or core > list configuration. Optimized by only creating membuf pool for those > node

Re: [dpdk-dev] [PATCH v2] app/testpmd: optimize membuf pool allocation

2018-10-08 Thread Burakov, Anatoly
On 08-Oct-18 12:33 PM, Ferruh Yigit wrote: On 9/12/2018 2:54 AM, dev-boun...@dpdk.org wrote: By default, testpmd will create membuf pool for all NUMA nodes and ignore EAL configuration. Count the number of available NUMA according to EAL core mask or core list configuration. Optimized by only c

Re: [dpdk-dev] [PATCH v3 1/3] ring: read tail using atomic load

2018-10-08 Thread Jerin Jacob
-Original Message- > Date: Mon, 8 Oct 2018 11:21:42 + > From: Ola Liljedahl > To: Jerin Jacob > CC: "dev@dpdk.org" , Honnappa Nagarahalli > , "Ananyev, Konstantin" > , "Gavin Hu (Arm Technology China)" > , Steve Capper , nd , > "sta...@dpdk.org" > Subject: Re: [PATCH v3 1/3] ring

Re: [dpdk-dev] [PATCH v2 1/4] ethdev: add Rx offload outer UDP checksum definition

2018-10-08 Thread Jerin Jacob
-Original Message- > Date: Mon, 8 Oct 2018 11:53:01 +0100 > From: Ferruh Yigit > To: Jerin Jacob , Thomas Monjalon > > CC: "Ananyev, Konstantin" , Andrew Rybchenko > , "Lu, Wenzhuo" , "Wu, > Jingjing" , "Iremonger, Bernard" > , "Mcnamara, John" , > "Kovacevic, Marko" , Olivier Matz >

Re: [dpdk-dev] [PATCH v3 1/3] ring: read tail using atomic load

2018-10-08 Thread Ola Liljedahl
On 08/10/2018, 13:50, "Jerin Jacob" wrote: I don't know how that creates more undefined behavior. So replied in the context of your reply that, according to your view even Linux is running with undefined behavior. As I explained, Linux does not use C11 atomics (nor GCC __

Re: [dpdk-dev] [PATCH v3 1/3] ring: read tail using atomic load

2018-10-08 Thread Jerin Jacob
-Original Message- > Date: Mon, 8 Oct 2018 11:59:16 + > From: Ola Liljedahl > To: Jerin Jacob > CC: "dev@dpdk.org" , Honnappa Nagarahalli > , "Ananyev, Konstantin" > , "Gavin Hu (Arm Technology China)" > , Steve Capper , nd , > "sta...@dpdk.org" > Subject: Re: [PATCH v3 1/3] ring

Re: [dpdk-dev] [PATCH v2 1/4] ethdev: add Rx offload outer UDP checksum definition

2018-10-08 Thread Ferruh Yigit
On 10/8/2018 12:55 PM, Jerin Jacob wrote: > -Original Message- >> Date: Mon, 8 Oct 2018 11:53:01 +0100 >> From: Ferruh Yigit >> To: Jerin Jacob , Thomas Monjalon >> >> CC: "Ananyev, Konstantin" , Andrew Rybchenko >> , "Lu, Wenzhuo" , "Wu, >> Jingjing" , "Iremonger, Bernard" >> , "Mcna

[dpdk-dev] [PATCH v14 3/4] test: add unit tests for latencystats library

2018-10-08 Thread Naga Suresh Somarowthu
Unit Test Cases added for latencystats library. Signed-off-by: Naga Suresh Somarowthu Reviewed-by: Reshma Pattan --- MAINTAINERS | 1 + test/test/Makefile| 1 + test/test/autotest_data.py| 6 ++ test/test/meson.build | 3 + test/test/test_latenc

[dpdk-dev] [PATCH v14 0/4] add unit tests for bitrate, latency and pdump libraries

2018-10-08 Thread Naga Suresh Somarowthu
1/4: add helper functions for tests using ring-PMD Rx/Tx 2/4: unit test cases added for bitrate library 3/4: unit test cases added for latencystats library 4/4: unit test cases added for pdump library Patches 2/4, 3/4 and 4/4 depends on 1/4 Signed-off-by: Naga Suresh Somarowthu Reviewed-by: Resh

Re: [dpdk-dev] [PATCH v8] net/pcap: physical interface MAC address support

2018-10-08 Thread Ferruh Yigit
On 10/6/2018 1:49 AM, Ferruh Yigit wrote: > From: Juhamatti Kuusisaari > > At the moment, PCAP interfaces use dummy MAC by default. This change > adds support for selecting PCAP physical interface MAC with phy_mac=1 > devarg. This allows to setup packet flows using the physical interface > MAC. >

[dpdk-dev] [PATCH v14 2/4] test: add unit tests for bitrate library

2018-10-08 Thread Naga Suresh Somarowthu
Unit Test Cases for BitRate library. Signed-off-by: Naga Suresh Somarowthu Reviewed-by: Reshma Pattan Reviewed-by: Remy Horton --- MAINTAINERS | 1 + test/test/Makefile| 1 + test/test/autotest_data.py| 6 ++ test/test/meson.build | 4 + test/t

[dpdk-dev] [PATCH v14 4/4] test: add unit test for pdump library

2018-10-08 Thread Naga Suresh Somarowthu
Unit test cases are added for pdump library. Primary process will act as server, forks a child secondary process. Secondary process acts as client. Server will do pdump init to serve any pdump client requests. Server will create a vdev, send/receive packets continuously in a separate thread. Client

[dpdk-dev] [PATCH v14 1/4] test: add helper functions for tests using ring-PMD Rx/Tx

2018-10-08 Thread Naga Suresh Somarowthu
Added ring pmd based packet rx/tx helper functions for verifying Latency, Bitrate and pdump lib UTs. Signed-off-by: Naga Suresh Somarowthu Reviewed-by: Reshma Pattan Reviewed-by: Anatoly Burakov --- MAINTAINERS | 5 ++ test/test/Makefile| 1 + test/tes

Re: [dpdk-dev] [PATCH v2 2/4] drivers: prefix global variables with module name

2018-10-08 Thread Shreyansh Jain
On Friday 05 October 2018 09:56 PM, Ferruh Yigit wrote: Some global variables are defined with generic names, add component name as prefix to variables to prevent collusion with application variables. Signed-off-by: Ferruh Yigit --- drivers/bus/dpaa/include/fsl_fman_crc64.h | 8 ++-- [.

Re: [dpdk-dev] [PATCH v3 1/3] ring: read tail using atomic load

2018-10-08 Thread Jerin Jacob
-Original Message- > Date: Mon, 8 Oct 2018 17:35:25 +0530 > From: Jerin Jacob > To: Ola Liljedahl > CC: "dev@dpdk.org" , Honnappa Nagarahalli > , "Ananyev, Konstantin" > , "Gavin Hu (Arm Technology China)" > , Steve Capper , nd , > "sta...@dpdk.org" > Subject: Re: [dpdk-dev] [PATCH v

Re: [dpdk-dev] [PATCH v2 1/4] ethdev: add Rx offload outer UDP checksum definition

2018-10-08 Thread Jerin Jacob
-Original Message- > Date: Mon, 8 Oct 2018 13:13:31 +0100 > From: Ferruh Yigit > To: Jerin Jacob > CC: Thomas Monjalon , "Ananyev, Konstantin" > , Andrew Rybchenko > , "Lu, Wenzhuo" , "Wu, > Jingjing" , "Iremonger, Bernard" > , "Mcnamara, John" , > "Kovacevic, Marko" , Olivier Matz >

Re: [dpdk-dev] [PATCH v3 01/32] common/cpt: add common logging support

2018-10-08 Thread Thomas Monjalon
05/10/2018 14:58, Anoob Joseph: > +Cavium OCTEON TX > +M: Anoob Joseph > +F: drivers/common/cpt/ What is the real wording for this device family? Sometimes I read OcteonTX with lowercases and no space, sometimes OCTEONTX without space, sometimes OCTEON TX. Another note: You should differentiate

Re: [dpdk-dev] [PATCH v3 02/32] config: add Cavium OCTEONTX crypto PMD skeleton

2018-10-08 Thread Thomas Monjalon
05/10/2018 14:58, Anoob Joseph: > From: Ankur Dwivedi > > Adding OCTEONTX crypto PMD skeleton. Updating the maintainers files to > claim responsibility. Also enabling driver by default by adding the > component in common_base. The title should be crypto/octeontx: add PMD skeleton

Re: [dpdk-dev] [PATCH v3 1/3] ring: read tail using atomic load

2018-10-08 Thread Ola Liljedahl
On 08/10/2018, 14:21, "Jerin Jacob" wrote: -Original Message- > Date: Mon, 8 Oct 2018 17:35:25 +0530 > From: Jerin Jacob > To: Ola Liljedahl > CC: "dev@dpdk.org" , Honnappa Nagarahalli > , "Ananyev, Konstantin" > , "Gavin Hu (Arm Technology China)" >

Re: [dpdk-dev] [PATCH v3 32/32] doc: adds doc file

2018-10-08 Thread Thomas Monjalon
05/10/2018 14:59, Anoob Joseph: > This patch adds the features file and the document containing > help to compile and use octeontx crypto. Some context is missing in this title. I suggest: doc: add guide for OcteonTX crypto or crypto/octeontx: add documentation

Re: [dpdk-dev] [PATCH v3 00/32] Adding Cavium's OCTEONTX crypto PMD

2018-10-08 Thread Thomas Monjalon
05/10/2018 14:58, Anoob Joseph: > Ankur Dwivedi (5): > common/cpt: add common logging support > config: add Cavium OCTEONTX crypto PMD skeleton > crypto/octeontx: add register addresses > common/cpt: add common code for init routine > test: adds validation test > > Anoob Joseph (5): >

Re: [dpdk-dev] [PATCH v3 31/32] test: adds validation test

2018-10-08 Thread Akhil Goyal
Hi Anoob, On 10/5/2018 6:29 PM, Anoob Joseph wrote: From: Ankur Dwivedi This patch adds validation tests for octeontx crypto device. Signed-off-by: Ankur Dwivedi Signed-off-by: Anoob Joseph Signed-off-by: Murthy NSSR Signed-off-by: Nithin Dabilpuram Signed-off-by: Ragothaman Jayaraman

Re: [dpdk-dev] [PATCH 0/8] examples/l2fwd: fix checkpatch reported issues

2018-10-08 Thread Ferruh Yigit
On 10/8/2018 12:29 PM, Joseph, Anoob wrote: > Hi Ferruh, > > On 08-10-2018 16:30, Ferruh Yigit wrote: >> External Email >> >> On 10/8/2018 11:41 AM, Anoob Joseph wrote: >>> This patchset fixes multiple issues reported by checkpatch in l2fwd >>> code base. These issues would be flagged for any new

Re: [dpdk-dev] [PATCH] net/ifc: fix build with type virtio16

2018-10-08 Thread Ferruh Yigit
On 10/8/2018 5:32 AM, Xiao Wang wrote: > The typedef of "__virtio16" is introduced into Linux kernel in v3.19. > To prevent build error on old kernel, this patch replaces the > "__virtio" usage with "uint16_t". > > Fixes: d7fe5a2861e7 ("net/ifc: support live migration") > > Signed-off-by: Xiao Wa

Re: [dpdk-dev] [PATCH v3 31/32] test: adds validation test

2018-10-08 Thread Akhil Goyal
one more... title should be test/crypto: add octeontx unit tests On 10/8/2018 6:03 PM, Akhil Goyal wrote: Hi Anoob, On 10/5/2018 6:29 PM, Anoob Joseph wrote: From: Ankur Dwivedi This patch adds validation tests for octeontx crypto device. Signed-off-by: Ankur Dwivedi Signed-off-by: Anoob

Re: [dpdk-dev] [PATCH v3 07/19] vhost: add number of fds to vhost-user messages and use it

2018-10-08 Thread Maxime Coquelin
On 10/05/2018 11:56 AM, Ilya Maximets wrote: On 04.10.2018 11:13, Maxime Coquelin wrote: As soons as some anciliarry datai (fds) are received, it is copied without checking its length. This patch adds adds the number of fds received to the message, which is set in read_vhost_message(). This

Re: [dpdk-dev] [PATCH v3 00/32] Adding Cavium's OCTEONTX crypto PMD

2018-10-08 Thread Joseph, Anoob
Hi Thomas, On 08-10-2018 18:03, Thomas Monjalon wrote: External Email 05/10/2018 14:58, Anoob Joseph: Ankur Dwivedi (5): common/cpt: add common logging support config: add Cavium OCTEONTX crypto PMD skeleton crypto/octeontx: add register addresses common/cpt: add common code for in

Re: [dpdk-dev] [PATCH v3 13/19] vhost: register new regions with userfaultfd

2018-10-08 Thread Maxime Coquelin
On 10/05/2018 02:34 PM, Ilya Maximets wrote: On 04.10.2018 11:13, Maxime Coquelin wrote: Signed-off-by: Dr. David Alan Gilbert Signed-off-by: Maxime Coquelin --- lib/librte_vhost/vhost_user.c | 33 - 1 file changed, 32 insertions(+), 1 deletion(-) diff --

Re: [dpdk-dev] [PATCH v2 1/4] ethdev: add Rx offload outer UDP checksum definition

2018-10-08 Thread Thomas Monjalon
08/10/2018 14:25, Jerin Jacob: > From: Ferruh Yigit > > On 10/8/2018 12:55 PM, Jerin Jacob wrote: > > > From: Ferruh Yigit > > >> On 10/8/2018 10:37 AM, Jerin Jacob wrote: > > >>> From: Thomas Monjalon > > 08/10/2018 10:24, Jerin Jacob: > > > From: Ferruh Yigit > > >> On 10/6/2018

[dpdk-dev] [PATCH v5] test: add unit tests for metrics library

2018-10-08 Thread Hari Kumar Vemula
Unit testcases are added for metrics library Added metrics unit test to autotest list Updated meson build file Updated MAINTAINERSHIP for metrics unit test Signed-off-by: Hari Kumar Vemula Reviewed-by: Reshma Pattan Reviewed-by: Remy Horton Acked-by: Remy Horton --- v5: Rebased on new codebase

  1   2   >