Re: [dpdk-dev] [PATCH 0/9] net/sfc: support more features in EF10 Rx

2018-10-04 Thread Ferruh Yigit
On 10/3/2018 10:03 AM, Andrew Rybchenko wrote: > Andrew Rybchenko (8): > net/sfc: receive prepared packets even in Rx exception case > net/sfc: use mbuf raw free instead of mempool put directly > net/sfc: check mbufs allocated using mempool API for Rx > net/sfc: avoid dummy writes to Rx que

[dpdk-dev] [PATCH v3 00/19] vhost: add postcopy live-migration support

2018-10-04 Thread Maxime Coquelin
In this v3: - Clarification about reply-ack in case of mandatory reply already sent. (Ilya) - Fix reply payload for VHOST_USER_SET_LOG_BASE (Ilya). - Fix return value of vhost_user_postcopy_end() so that the reply gets sent. (Ilya) - Declare VHOST_USER_POSTCOPY_END in the right commit. (Ilya)

[dpdk-dev] [PATCH v3 02/19] vhost: fix return code of messages requiring replies

2018-10-04 Thread Maxime Coquelin
VHOST_USER_GET_PROTOCOL_FEATURES, VHOST_USER_GET_VRING_BASE and VHOST_USER_SET_LOG_BASE require replies, so their handlers should return VH_RESULT_REPLY, not VH_RESULT_OK. Fixes: 0bff510b5ea6 ("vhost: unify message handling function signature") Signed-off-by: Maxime Coquelin --- lib/librte_vhos

[dpdk-dev] [PATCH v3 03/19] vhost: clarify reply-ack in case a reply was already sent

2018-10-04 Thread Maxime Coquelin
For messages that require a reply, a second ack should not be sent when reply-ack protocol feature is negotiated, even if the corresponding flag is set in the message. The code is compliant with the spec but it isn't clear it is, so this patch adds a comment to make it explicit. Suggested-by: Ily

[dpdk-dev] [PATCH v3 04/19] vhost: fix payload size of reply

2018-10-04 Thread Maxime Coquelin
QEMU doesn't expect any payload for the reply of VHOST_USER_SET_LOG_BASE request, so don't send any. Note that the Vhost-user specification isn't clear about it and would need to be fixed. Fixes: 54f9e32305d4 ("vhost: handle dirty pages logging request") Cc: sta...@dpdk.org Reported-by: Ilya Maxi

[dpdk-dev] [PATCH v3 01/19] vhost: fix messages error checks

2018-10-04 Thread Maxime Coquelin
Return of message handling has now changed to an enum that can take non-negative value that is not zero in case a reply is needed. But the code checking the variable afterwards has not been updated, leading to success messages handling being treated as errors. Fixes: 2f270595c05d ("vhost: rework m

[dpdk-dev] [PATCH v3 05/19] vhost: fix error handling when mem table gets updated

2018-10-04 Thread Maxime Coquelin
When the memory table gets updated, the rings addresses need to be translated again. If it fails, we need to exit cleanly by unmapping memory regions. Fixes: d5022533c20a ("vhost: retranslate vring addr when memory table changes") Cc: sta...@dpdk.org Signed-off-by: Maxime Coquelin --- lib/librt

[dpdk-dev] [PATCH v3 06/19] vhost: define postcopy protocol flag

2018-10-04 Thread Maxime Coquelin
Signed-off-by: Dr. David Alan Gilbert Signed-off-by: Maxime Coquelin --- lib/librte_vhost/rte_vhost.h | 4 1 file changed, 4 insertions(+) diff --git a/lib/librte_vhost/rte_vhost.h b/lib/librte_vhost/rte_vhost.h index b02673d4a..b3cc6990d 100644 --- a/lib/librte_vhost/rte_vhost.h +++ b/lib

[dpdk-dev] [PATCH v3 07/19] vhost: add number of fds to vhost-user messages and use it

2018-10-04 Thread Maxime Coquelin
As soons as some anciliarry datai (fds) are received, it is copied without checking its length. This patch adds adds the number of fds received to the message, which is set in read_vhost_message(). This is preliminary work to support sending fds to Qemu. Signed-off-by: Dr. David Alan Gilbert Si

[dpdk-dev] [PATCH v3 08/19] vhost: pass socket fd to message handling callbacks

2018-10-04 Thread Maxime Coquelin
This is not used for now, but will be needed for the special handling of VHOST_USER_SET_MEM_TABLE message once postcopy will be supported. Signed-off-by: Maxime Coquelin --- lib/librte_vhost/vhost_user.c | 71 +++ 1 file changed, 47 insertions(+), 24 deletions(-)

[dpdk-dev] [PATCH v3 09/19] vhost: enable fds passing when sending vhost-user messages

2018-10-04 Thread Maxime Coquelin
Passing userfault fds to Qemu will be required for postcopy live-migration feature. Signed-off-by: Dr. David Alan Gilbert Signed-off-by: Maxime Coquelin --- lib/librte_vhost/vhost_user.c | 27 +++ 1 file changed, 15 insertions(+), 12 deletions(-) diff --git a/lib/librte

[dpdk-dev] [PATCH v3 15/19] vhost: send userfault range addresses back to qemu

2018-10-04 Thread Maxime Coquelin
Signed-off-by: Dr. David Alan Gilbert Signed-off-by: Maxime Coquelin --- lib/librte_vhost/vhost_user.c | 49 --- 1 file changed, 46 insertions(+), 3 deletions(-) diff --git a/lib/librte_vhost/vhost_user.c b/lib/librte_vhost/vhost_user.c index 1c6d8d2de..40c9a3df1

[dpdk-dev] [PATCH v3 14/19] vhost: avoid useless VhostUserMemory copy

2018-10-04 Thread Maxime Coquelin
The VHOST_USER_SET_MEM_TABLE payload is copied when handled, whereas it could directly be referenced. This is not very important, but next, we'll need to update the payload and send it back to Qemu. Signed-off-by: Dr. David Alan Gilbert Signed-off-by: Maxime Coquelin --- lib/librte_vhost/vhost

[dpdk-dev] [PATCH v3 10/19] vhost: add config flag for postcopy feature

2018-10-04 Thread Maxime Coquelin
Postcopy live-migration features relies on userfaultfd, which was only introduced in kernel v4.3. This patch introduces a new define to allow building vhost library on kernels not supporting userfaultfd. With legacy build system, user has to explicitly set CONFIG_RTE_LIBRTE_VHOST_POSTCOPY to 'y'.

[dpdk-dev] [PATCH v3 12/19] vhost: add support for postcopy's listen message

2018-10-04 Thread Maxime Coquelin
Signed-off-by: Dr. David Alan Gilbert Signed-off-by: Maxime Coquelin --- lib/librte_vhost/vhost.h | 1 + lib/librte_vhost/vhost_user.c | 19 +++ lib/librte_vhost/vhost_user.h | 3 ++- 3 files changed, 22 insertions(+), 1 deletion(-) diff --git a/lib/librte_vhost/vhost.h b

[dpdk-dev] [PATCH v3 11/19] vhost: introduce postcopy's advise message

2018-10-04 Thread Maxime Coquelin
This patch opens a userfaultfd and sends it back to Qemu's VHOST_USER_POSTCOPY_ADVISE request. Signed-off-by: Dr. David Alan Gilbert Signed-off-by: Maxime Coquelin --- lib/librte_vhost/vhost.h | 2 ++ lib/librte_vhost/vhost_user.c | 44 +++ lib/librte_vhost

[dpdk-dev] [PATCH v3 13/19] vhost: register new regions with userfaultfd

2018-10-04 Thread Maxime Coquelin
Signed-off-by: Dr. David Alan Gilbert Signed-off-by: Maxime Coquelin --- lib/librte_vhost/vhost_user.c | 33 - 1 file changed, 32 insertions(+), 1 deletion(-) diff --git a/lib/librte_vhost/vhost_user.c b/lib/librte_vhost/vhost_user.c index ffb3ea60a..d61be2da6 10

[dpdk-dev] [PATCH v3 18/19] vhost: add flag to enable postcopy live-migration

2018-10-04 Thread Maxime Coquelin
Postcopy live-migration feature require the application to not populate the guest memory. As the vhost library cannot prevent the application to that (e.g. preventing the application to call mlockall()), the feature is disabled by default. The application should only enable the feature if it does

[dpdk-dev] [PATCH v3 17/19] vhost: enable postcopy protocol feature

2018-10-04 Thread Maxime Coquelin
Enable postcopy protocol feature except if dequeue zero-copy is enabled. In this case, guest memory requires to be populated, which is not compatible with userfaultfd. Signed-off-by: Dr. David Alan Gilbert Signed-off-by: Maxime Coquelin --- lib/librte_vhost/vhost_user.c | 7 +++ lib/librte_

[dpdk-dev] [PATCH v3 16/19] vhost: add support to postcopy's end request

2018-10-04 Thread Maxime Coquelin
The master sends this message before stopping handling userfaults, so that the backend closes the userfaultfd. The master waits for the slave to acknowledge the request with an empty 64bits payload for synchronization purpose. Signed-off-by: Dr. David Alan Gilbert Signed-off-by: Maxime Coquelin

[dpdk-dev] [PATCH v3 19/19] net/vhost: add parameter to enable postcopy support

2018-10-04 Thread Maxime Coquelin
Introduce a new postcopy-support parameter to Vhost PMD that passes the RTE_VHOST_USER_POSTCOPY_SUPPORT flag at vhost device register time. Flag should only be set if application does not prefault guest memory using, for example, mlockall() syscall. Default value is 0, meaning that postcopy suppo

Re: [dpdk-dev] [PATCH v4 0/4] Enable hotplug in vfio

2018-10-04 Thread Burakov, Anatoly
On 04-Oct-18 7:44 AM, Jeff Guo wrote: As we may know that the process of hotplug is different between igb_uio and vfio. For igb_uio, it could use uevent notification and memory failure handle mechanism for hot-unplug. But for vfio, when device is be hot-unplugged, the uevent can not be detected i

Re: [dpdk-dev] [PATCH 0/7] Improve core EAL musl compatibility

2018-10-04 Thread Burakov, Anatoly
On 03-Oct-18 11:56 PM, Thomas Monjalon wrote: 28/09/2018 17:25, Bruce Richardson: On Wed, Aug 29, 2018 at 12:56:14PM +0100, Anatoly Burakov wrote: This patchset fixes numerous issues with musl compatibility in the core EAL libraries. It does not fix anything beyond core EAL (so, PCI driver is s

Re: [dpdk-dev] [PATCH v2] mem: store memory mode flags in shared config

2018-10-04 Thread Burakov, Anatoly
On 03-Oct-18 11:05 PM, Thomas Monjalon wrote: 20/09/2018 17:41, Anatoly Burakov: Currently, command-line switches for legacy mem mode or single-file segments mode are only stored in internal config. This leads to a situation where these flags have to always match between primary and secondary, w

Re: [dpdk-dev] [PATCH v2] mem: store memory mode flags in shared config

2018-10-04 Thread Thomas Monjalon
04/10/2018 11:17, Burakov, Anatoly: > On 03-Oct-18 11:05 PM, Thomas Monjalon wrote: > > 20/09/2018 17:41, Anatoly Burakov: > >> Currently, command-line switches for legacy mem mode or single-file > >> segments mode are only stored in internal config. This leads to a > >> situation where these flags

Re: [dpdk-dev] [PATCH v3 0/3] force IOVA to a particular mode

2018-10-04 Thread Burakov, Anatoly
On 03-Oct-18 9:53 PM, eric zhang wrote: This patchset introduces an EAL command line option "--iova-mode" to give the user a facility to force IOVA mode to a special value. Auto detection of the IOVA mode, based on probing the bus and IOMMU configuration, may not report the desired addressing mo

Re: [dpdk-dev] [PATCH v5 1/5] devargs: remove deprecated functions

2018-10-04 Thread Gaëtan Rivet
Hi Thomas, On Thu, Oct 04, 2018 at 01:10:42AM +0200, Thomas Monjalon wrote: > rte_eal_parse_devargs_str() does not support parsing the bus name > at the start of devargs. So it was renamed and deprecated. > > rte_eal_devargs_add(), rte_eal_devargs_type_count() and > rte_eal_devargs_dump() were de

Re: [dpdk-dev] [PATCH v5 2/5] devargs: simplify parameters of removal function

2018-10-04 Thread Gaëtan Rivet
On Thu, Oct 04, 2018 at 01:10:43AM +0200, Thomas Monjalon wrote: > The function rte_devargs_remove(), which is intended to be internal, > can take a devargs structure as argument. > The matching is still using string comparison of bus name and > device name. > It is simpler and may allow a differen

Re: [dpdk-dev] [PATCH v5 3/5] eal: add bus pointer in device structure

2018-10-04 Thread Gaëtan Rivet
On Thu, Oct 04, 2018 at 01:10:44AM +0200, Thomas Monjalon wrote: > When a device is added with a devargs (hotplug or whitelist), > the bus pointer can be retrieved via its devargs. > But there is no such devargs.bus in case of standard scan. > > A pointer to the rte_bus handle is added to rte_devi

Re: [dpdk-dev] [PATCH v5 4/5] eal: remove experimental flag of hotplug functions

2018-10-04 Thread Gaëtan Rivet
On Thu, Oct 04, 2018 at 01:10:45AM +0200, Thomas Monjalon wrote: > These functions are quite old and are the only available replacement > for the deprecated attach/detach functions. > > Note: some new functions may (again) replace these hotplug functions, > in future, with better parameters. > >

Re: [dpdk-dev] Symmetry for TCP packets on X710 Intel

2018-10-04 Thread Matteo Lanzuisi
Hi all, an update: solved the problem, the fact is that i40e wants an hashkey with size 52, while I was using a 40 bytes hashkey. Two questions: - is there a warning on rte_eth_dev_configure function about using a correct hashkey len (maybe in debug mode for i40e)? Because I used it with an

Re: [dpdk-dev] [PATCH v3 00/22] net/atlantic: Aquantia aQtion 10G NIC Family DPDK PMD driver

2018-10-04 Thread Igor Russkikh
Hi Ferruh, Thanks again for the review, we'll investigate and work on your comments! > > +CONFIG_RTE_LIBRTE_ATLANTIC_PMD=y > Just to check, default enable in "common_base" means PMD supports all > architectures (x86_64, i686, arm, ppc) and both Linux and FreeBSD. > If this is not the case, please

Re: [dpdk-dev] [PATCH v2 3/3] eal: allow probing a device again

2018-10-04 Thread Doherty, Declan
On 28/09/2018 5:40 PM, Thomas Monjalon wrote: In the devargs syntax for device representors, it is possible to add several devices at once: -w dbdf,representor=[0-3] It will become a more frequent case when introducing wildcards and ranges in the new devargs syntax. If a devargs string is provid

Re: [dpdk-dev] [PATCH v5 5/5] eal: simplify parameters of hotplug functions

2018-10-04 Thread Gaëtan Rivet
I much prefer this API, I have one remark inline however. On Thu, Oct 04, 2018 at 01:10:46AM +0200, Thomas Monjalon wrote: > All information about a device to probe can be grouped > in a common string, which is what we usually call devargs. > An application should not have to parse this string be

Re: [dpdk-dev] [PATCH v5 3/5] eal: add bus pointer in device structure

2018-10-04 Thread Thomas Monjalon
04/10/2018 11:31, Gaëtan Rivet: > On Thu, Oct 04, 2018 at 01:10:44AM +0200, Thomas Monjalon wrote: > > When a device is added with a devargs (hotplug or whitelist), > > the bus pointer can be retrieved via its devargs. > > But there is no such devargs.bus in case of standard scan. > > > > A pointe

[dpdk-dev] [PATCH v2 1/8] examples: add fips validation into examples

2018-10-04 Thread Fan Zhang
From: Marko Kovacevic Added FIPS application into the examples to allow users to use a simple sample app to validate their systems and be able to get FIPS certification. Signed-off-by: Marko Kovacevic Signed-off-by: Fan Zhang --- examples/cryptodev_fips_validate/Makefile | 69 +++ .

[dpdk-dev] [PATCH v2 6/8] examples: add cmac parser and enablement for test types

2018-10-04 Thread Fan Zhang
From: Marko Kovacevic Added enablement for CMAC parser, to allow the application to parser the cmac request files and to validate all test types supported. Signed-off-by: Marko Kovacevic Signed-off-by: Fan Zhang --- examples/cryptodev_fips_validate/Makefile | 1 + .../cryptodev_fip

[dpdk-dev] [PATCH v2 0/8] FIPS validation capability

2018-10-04 Thread Fan Zhang
This sample application is made for the purpose so that users of DPDK who wish to get FIPS certification for their platforms, this sample app enables users to parse test vectors that is gotten from NIST and be able to get a generated response file which they can then verify and be sure their system

[dpdk-dev] [PATCH v2 2/8] examples: add aes parser and enablement for test types

2018-10-04 Thread Fan Zhang
From: Marko Kovacevic Added enablement for AES-CBC parser, to allow the application to parser the aes request file and to validate all test types supported. Signed-off-by: Marko Kovacevic Signed-off-by: Fan Zhang --- examples/cryptodev_fips_validate/Makefile | 1 + .../cryptodev_fi

[dpdk-dev] [PATCH v2 4/8] examples: add TDES parser and enablement for test types

2018-10-04 Thread Fan Zhang
From: Marko Kovacevic Added enablement for TDES parser, to allow the application to parser the TDES request files and to validate all test types supported. Signed-off-by: Marko Kovacevic Signed-off-by: Fan Zhang --- examples/cryptodev_fips_validate/Makefile | 1 + .../cryptodev_fip

[dpdk-dev] [PATCH v2 3/8] examples: add hmac parser

2018-10-04 Thread Fan Zhang
From: Marko Kovacevic Added enablement for HMAC parser, to allow the application to parser the hmac request files and to validate all tests supported Signed-off-by: Marko Kovacevic Signed-off-by: Fan Zhang --- examples/cryptodev_fips_validate/Makefile | 1 + .../cryptodev_fips_pars

[dpdk-dev] [PATCH v2 7/8] examples: add ccm parser and enablement for test types

2018-10-04 Thread Fan Zhang
From: Marko Kovacevic Added enablement for CCM parser, to allow the application to parser the ccm request files and to validate all test types supported. Signed-off-by: Marko Kovacevic Signed-off-by: Fan Zhang --- examples/cryptodev_fips_validate/Makefile | 1 + .../cryptodev_fips_

[dpdk-dev] [PATCH v2 5/8] examples: add gcm parser

2018-10-04 Thread Fan Zhang
From: Marko Kovacevic Added enablement for GCM parser, to allow the application to parser the GCM request file and to validate all tests supported. Signed-off-by: Marko Kovacevic Signed-off-by: Fan Zhang --- examples/cryptodev_fips_validate/Makefile | 1 + .../cryptodev_fips_parse_

[dpdk-dev] [PATCH v2 8/8] doc: add guides for fips validation

2018-10-04 Thread Fan Zhang
From: Marko Kovacevic Document explains how to run the fips sample app and instructions users need to parser all the request files and generate the response files. Signed-off-by: Marko Kovacevic Signed-off-by: Fan Zhang --- doc/guides/rel_notes/release_18_11.rst | 6 ++ doc/guides/samp

Re: [dpdk-dev] [PATCH 1/9] net/sfc: receive prepared packets even in Rx exception case

2018-10-04 Thread Ivan Malov
On 10/3/2018 12:03 PM, Andrew Rybchenko wrote: Make sure that number of prepared packets, completed and added Rx ring pointers are reset to zeros on queue purge at stop. Fixes: 638bddc99faa ("net/sfc: implement EF10 native Rx datapath") Cc: stable at dpdk.org Signed-off-by: Andrew Rybchenko

[dpdk-dev] [PATCH v3 5/7] mem: improve musl compatibility

2018-10-04 Thread Anatoly Burakov
When built against musl, fcntl.h doesn't silently get included. Fix by including it explicitly. Bugzilla ID: 31 Signed-off-by: Anatoly Burakov Acked-by: Bruce Richardson --- lib/librte_eal/common/eal_common_memory.c | 1 + lib/librte_eal/linuxapp/eal/eal_memory.c | 1 + 2 files changed, 2 ins

[dpdk-dev] [PATCH v3 2/7] pci/vfio: improve musl compatibility

2018-10-04 Thread Anatoly Burakov
Musl already has PAGE_SIZE defined, and our define clashed with it. Rename our define to SYS_PAGE_SIZE. Bugzilla ID: 36 Signed-off-by: Anatoly Burakov Acked-by: Bruce Richardson --- drivers/bus/pci/linux/pci_vfio.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/bus/pci/linux/pci

[dpdk-dev] [PATCH v3 7/7] eal: improve musl compatibility

2018-10-04 Thread Anatoly Burakov
Musl complains about pthread id being of wrong size, because on musl, pthread_t is a struct pointer, not an unsinged int. Fix the printing code by casting pthread id to unsigned pointer type and adjusting the format specifier to be of appropriate size. Signed-off-by: Anatoly Burakov Acked-by: Bru

[dpdk-dev] [PATCH v3 3/7] fbarray: improve musl compatibility

2018-10-04 Thread Anatoly Burakov
When built against musl, fcntl.h doesn't silently get included. Fix by including it explicitly. Bugzilla ID: 34 Signed-off-by: Anatoly Burakov Acked-by: Bruce Richardson --- lib/librte_eal/common/eal_common_fbarray.c | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/librte_eal/common/eal

[dpdk-dev] [PATCH v3 1/7] mk: build with _GNU_SOURCE defined by default

2018-10-04 Thread Anatoly Burakov
We use _GNU_SOURCE all over the place, but often times we miss defining it, resulting in broken builds on musl. Rather than fixing every library's and driver's and application's makefile, fix it by simply defining _GNU_SOURCE by default for all builds. Remove all usages of _GNU_SOURCE in source fi

[dpdk-dev] [PATCH v3 0/7] Improve core EAL musl compatibility

2018-10-04 Thread Anatoly Burakov
This patchset fixes numerous issues with musl compatibility in the core EAL libraries. It does not fix anything beyond core EAL (so, PCI driver is still broken, so are a few other drivers), but it's a good start. Tested on container with Alpine Linux. Alpine dependencies: build-base bsd-compat-he

[dpdk-dev] [PATCH v3 4/7] eal/hugepage_info: improve musl compatibility

2018-10-04 Thread Anatoly Burakov
When built against musl, fcntl.h doesn't silently get included. Fix by including it explicitly. Bugzilla ID: 33 Signed-off-by: Anatoly Burakov Acked-by: Bruce Richardson --- lib/librte_eal/linuxapp/eal/eal_hugepage_info.c | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/librte_eal/linux

[dpdk-dev] [PATCH v3 6/7] string_fns: improve musl compatibility

2018-10-04 Thread Anatoly Burakov
Musl wraps various string functions such as strlcpy in order to harden them. However, the fortify wrappers are included without including the actual string functions being wrapped, which throws missing definition compile errors. Fix by including string.h in string functions header. Signed-off-by:

Re: [dpdk-dev] [PATCH v3 00/22] net/atlantic: Aquantia aQtion 10G NIC Family DPDK PMD driver

2018-10-04 Thread Ferruh Yigit
On 10/4/2018 10:42 AM, Igor Russkikh wrote: > Hi Ferruh, > > Thanks again for the review, we'll investigate and work on your comments! > >>> +CONFIG_RTE_LIBRTE_ATLANTIC_PMD=y >> Just to check, default enable in "common_base" means PMD supports all >> architectures (x86_64, i686, arm, ppc) and bot

Re: [dpdk-dev] [PATCH v13 7/7] app/testpmd: use hotplug failure handler

2018-10-04 Thread Iremonger, Bernard
Hi Jeff, > -Original Message- > From: Guo, Jia > Sent: Thursday, October 4, 2018 7:31 AM > To: step...@networkplumber.org; Richardson, Bruce > ; Yigit, Ferruh ; Ananyev, > Konstantin ; gaetan.ri...@6wind.com; Wu, > Jingjing ; tho...@monjalon.net; > mo...@mellanox.com; ma...@mellanox.com; V

Re: [dpdk-dev] [PATCH v2] mem: store memory mode flags in shared config

2018-10-04 Thread Ferruh Yigit
On 10/4/2018 10:18 AM, Thomas Monjalon wrote: > 04/10/2018 11:17, Burakov, Anatoly: >> On 03-Oct-18 11:05 PM, Thomas Monjalon wrote: >>> 20/09/2018 17:41, Anatoly Burakov: Currently, command-line switches for legacy mem mode or single-file segments mode are only stored in internal config.

[dpdk-dev] [PATCH v2] event/dsw: fix icc build

2018-10-04 Thread Mattias Rönnblom
Make the -Wno-format-nonliteral flag conditional, and only set in clang and gcc builds, since this flag is not supported (nor needed) when building dsw with icc. Fixes: 46a186b1f0c5 ("event/dsw: add device registration and build system") Signed-off-by: Mattias Rönnblom Reviewed-by: Ferruh Yigit

[dpdk-dev] [PATCH v2 0/3] add AES-CMAC support

2018-10-04 Thread Tomasz Cel
This patch add support, update QAT documentation and enable tests for AES-CMAC. v2: * deleted unnecessary white signs from documentation part Tomasz Cel (3): crypto/qat: add support AES-CMAC test/qat: test for AES-CMAC doc/qat: add AES-CMAC to the QAT feature list doc/guides/cryptodevs/f

[dpdk-dev] [PATCH v2 3/3] doc/qat: add AES-CMAC to the QAT feature list

2018-10-04 Thread Tomasz Cel
Update the QAT documentation to show that it supports AES-CMAC. Signed-off-by: Tomasz Cel --- doc/guides/cryptodevs/features/qat.ini | 1 + 1 file changed, 1 insertion(+) diff --git a/doc/guides/cryptodevs/features/qat.ini b/doc/guides/cryptodevs/features/qat.ini index 220291b..4f15ee0 100644

[dpdk-dev] [PATCH v2 1/3] crypto/qat: add support AES-CMAC

2018-10-04 Thread Tomasz Cel
This patch add AES-CMAC support. CMAC is a keyed hash function that is based on a symmetric key block cipher. It is One-Key CBC MAC improvement over XCBC-MAC. RFC 4493. NIST SP 800-38B. Signed-off-by: Tomasz Cel Signed-off-by: Arek Kusztal --- drivers/crypto/qat/qat_sym_session.c | 190

[dpdk-dev] [PATCH v2 2/3] test/qat: test for AES-CMAC

2018-10-04 Thread Tomasz Cel
Enable tests for AES-CMAC authentication algorithm. Signed-off-by: Tomasz Cel --- test/test/test_cryptodev_hash_test_vectors.h | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/test/test/test_cryptodev_hash_test_vectors.h b/test/test/test_cryptodev_hash_test_vecto

Re: [dpdk-dev] [RFC v3] ethdev: claim device reset as async

2018-10-04 Thread Ferruh Yigit
On 9/20/2018 5:56 AM, Qi Zhang wrote: > Device reset should be implemented in an async way since it is > possible to be invoked in interrupt thread and sometimes to reset a > device need to wait for some dependency, for example, a VF expects for > PF ready or a NIC function as part of a SOC wait fo

Re: [dpdk-dev] [PATCH] ethdev: add field for device data per process

2018-10-04 Thread Ferruh Yigit
On 10/3/2018 9:44 PM, Thomas Monjalon wrote: > + Cc more people > > 27/09/2018 13:26, Alejandro Lucero: >> Primary and secondary processes share a per-device private data. With >> current design it is not possible to have data per-device per-process. >> This is required for handling properly the C

Re: [dpdk-dev] [PATCH v2 2/5] mem: use address hint for mapping hugepages

2018-10-04 Thread Alejandro Lucero
On Wed, Oct 3, 2018 at 1:50 PM Burakov, Anatoly wrote: > On 31-Aug-18 1:50 PM, Alejandro Lucero wrote: > > Linux kernel uses a really high address as starting address for > > serving mmaps calls. If there exist addressing limitations and > > IOVA mode is VA, this starting address is likely too hi

Re: [dpdk-dev] [PATCH v5 5/5] eal: simplify parameters of hotplug functions

2018-10-04 Thread Thomas Monjalon
04/10/2018 11:44, Gaëtan Rivet: > On Thu, Oct 04, 2018 at 01:10:46AM +0200, Thomas Monjalon wrote: > > --- a/lib/librte_eal/common/eal_common_dev.c > > +++ b/lib/librte_eal/common/eal_common_dev.c > > @@ -129,46 +129,61 @@ int rte_eal_dev_detach(struct rte_device *dev) > > > > int > > rte_eal_h

Re: [dpdk-dev] [PATCH v2 0/3] add AES-CMAC support

2018-10-04 Thread Trahe, Fiona
> -Original Message- > From: Cel, TomaszX > Sent: Thursday, October 4, 2018 12:22 PM > To: dev@dpdk.org > Cc: sta...@dpdk.org; Trahe, Fiona ; > akhil.go...@nxp.com; Kovacevic, Marko > ; Kusztal, ArkadiuszX > ; Cel, TomaszX > > Subject: [PATCH v2 0/3] add AES-CMAC support > > This pat

Re: [dpdk-dev] [PATCH v5 5/5] eal: simplify parameters of hotplug functions

2018-10-04 Thread Gaëtan Rivet
On Thu, Oct 04, 2018 at 01:46:54PM +0200, Thomas Monjalon wrote: > 04/10/2018 11:44, Gaëtan Rivet: > > On Thu, Oct 04, 2018 at 01:10:46AM +0200, Thomas Monjalon wrote: > > > --- a/lib/librte_eal/common/eal_common_dev.c > > > +++ b/lib/librte_eal/common/eal_common_dev.c > > > @@ -129,46 +129,61 @@ i

Re: [dpdk-dev] [PATCH v7 1/8] net/virtio: vring init for packed queues

2018-10-04 Thread Maxime Coquelin
On 10/03/2018 03:11 PM, Jens Freimann wrote: Add and initialize descriptor data structures. To allow out of order processing a .next field was added to struct vq_desc_extra because there is none in the packed virtqueue descriptor itself. This is used to chain descriptors and process them simi

Re: [dpdk-dev] [PATCH v7 2/8] net/virtio: add packed virtqueue defines

2018-10-04 Thread Maxime Coquelin
On 10/03/2018 03:11 PM, Jens Freimann wrote: Signed-off-by: Jens Freimann --- drivers/net/virtio/virtio_ring.h | 4 1 file changed, 4 insertions(+) diff --git a/drivers/net/virtio/virtio_ring.h b/drivers/net/virtio/virtio_ring.h index 309069fdb..36a65f9b3 100644 --- a/drivers/net/vir

Re: [dpdk-dev] [PATCH v13 0/7] hot-unplug failure handle mechanism

2018-10-04 Thread Ananyev, Konstantin
> -Original Message- > From: Guo, Jia > Sent: Thursday, October 4, 2018 7:31 AM > To: step...@networkplumber.org; Richardson, Bruce > ; Yigit, Ferruh ; Ananyev, > Konstantin ; gaetan.ri...@6wind.com; Wu, > Jingjing ; tho...@monjalon.net; > mo...@mellanox.com; ma...@mellanox.com; Van Haa

Re: [dpdk-dev] [PATCH v2 2/5] mem: use address hint for mapping hugepages

2018-10-04 Thread Burakov, Anatoly
On 04-Oct-18 12:43 PM, Alejandro Lucero wrote: On Wed, Oct 3, 2018 at 1:50 PM Burakov, Anatoly mailto:anatoly.bura...@intel.com>> wrote: On 31-Aug-18 1:50 PM, Alejandro Lucero wrote: > Linux kernel uses a really high address as starting address for > serving mmaps calls. If the

[dpdk-dev] [PATCH] doc: update timestamp validity for latency measurement

2018-10-04 Thread Reshma Pattan
Updated the doc on how packets are marked to identify their timestamp as valid and considered for latency measurement. Suggested-by: Bao-Long Tran Signed-off-by: Reshma Pattan --- This change is relevant to the below patch and must be applied after that. http://patches.dpdk.org/patch/45328/ ---

[dpdk-dev] Fwd: [PATCH v2 1/5] mem: add function for checking memsegs IOVAs addresses

2018-10-04 Thread Alejandro Lucero
I sent this email only to Anatoly. Sending it again to mailing list. On Wed, Oct 3, 2018 at 1:43 PM Burakov, Anatoly wrote: > On 31-Aug-18 1:50 PM, Alejandro Lucero wrote: > > A device can suffer addressing limitations. This functions checks > > memsegs have iovas within the supported range base

Re: [dpdk-dev] [PATCH v2 00/10] introduce telemetry library

2018-10-04 Thread Van Haaren, Harry
> -Original Message- > From: Laatz, Kevin > Sent: Wednesday, October 3, 2018 6:36 PM > To: dev@dpdk.org > Cc: Van Haaren, Harry ; > step...@networkplumber.org; gaetan.ri...@6wind.com; shreyansh.j...@nxp.com; > tho...@monjalon.net; Laatz, Kevin > Subject: [PATCH v2 00/10] introduce telemetr

Re: [dpdk-dev] [PATCH v2 2/5] mem: use address hint for mapping hugepages

2018-10-04 Thread Alejandro Lucero
On Thu, Oct 4, 2018 at 1:08 PM Burakov, Anatoly wrote: > On 04-Oct-18 12:43 PM, Alejandro Lucero wrote: > > > > > > On Wed, Oct 3, 2018 at 1:50 PM Burakov, Anatoly > > mailto:anatoly.bura...@intel.com>> wrote: > > > > On 31-Aug-18 1:50 PM, Alejandro Lucero wrote: > > > Linux kernel uses

[dpdk-dev] [PATCH] net/*/base: allow experimental APIs in base of avf and qede

2018-10-04 Thread Ilya Maximets
This functionality was missed while adding new drivers to the meson build. Fixes: 1d75caf81474 ("net/avf: add meson support") Fixes: 30d3d0168301 ("net/qede: add in meson build") Signed-off-by: Ilya Maximets --- drivers/net/avf/base/meson.build | 3 +++ drivers/net/qede/base/meson.build | 3 ++

Re: [dpdk-dev] [PATCH v7 4/8] net/virtio: dump packed virtqueue data

2018-10-04 Thread Maxime Coquelin
On 10/03/2018 03:11 PM, Jens Freimann wrote: Add support to dump packed virtqueue data to the VIRTQUEUE_DUMP() macro. Signed-off-by: Jens Freimann --- drivers/net/virtio/virtqueue.h | 9 + 1 file changed, 9 insertions(+) Reviewed-by: Maxime Coquelin diff --git a/drivers/net/v

Re: [dpdk-dev] [PATCH v2 00/10] introduce telemetry library

2018-10-04 Thread Van Haaren, Harry
> -Original Message- > From: Van Haaren, Harry > Sent: Thursday, October 4, 2018 2:00 PM > To: Laatz, Kevin ; dev@dpdk.org > Cc: step...@networkplumber.org; gaetan.ri...@6wind.com; > shreyansh.j...@nxp.com; tho...@monjalon.net; Richardson, Bruce > > Subject: RE: [PATCH v2 00/10] introduce

[dpdk-dev] [PATCH v3 0/8] FIPS validation capability

2018-10-04 Thread Fan Zhang
This sample application is made for the purpose so that users of DPDK who wish to get FIPS certification for their platforms, this sample app enables users to parse test vectors that is gotten from NIST and be able to get a generated response file which they can then verify and be sure their system

[dpdk-dev] [PATCH v3 1/8] examples: add fips validation into examples

2018-10-04 Thread Fan Zhang
From: Marko Kovacevic Added FIPS application into the examples to allow users to use a simple sample app to validate their systems and be able to get FIPS certification. Signed-off-by: Marko Kovacevic Signed-off-by: Fan Zhang --- examples/cryptodev_fips_validate/Makefile | 69 +++ .

[dpdk-dev] [PATCH v3 3/8] examples: add hmac parser

2018-10-04 Thread Fan Zhang
From: Marko Kovacevic Added enablement for HMAC parser, to allow the application to parser the hmac request files and to validate all tests supported Signed-off-by: Marko Kovacevic Signed-off-by: Fan Zhang --- examples/cryptodev_fips_validate/Makefile | 1 + .../cryptodev_fips_pars

[dpdk-dev] [PATCH v3 8/8] doc: add guides for fips validation

2018-10-04 Thread Fan Zhang
From: Marko Kovacevic Document explains how to run the fips sample app and instructions users need to parser all the request files and generate the response files. Signed-off-by: Marko Kovacevic Signed-off-by: Fan Zhang --- doc/guides/rel_notes/release_18_11.rst | 6 ++ doc/guides/samp

[dpdk-dev] [PATCH v3 7/8] examples: add ccm parser and enablement for test types

2018-10-04 Thread Fan Zhang
From: Marko Kovacevic Added enablement for CCM parser, to allow the application to parser the ccm request files and to validate all test types supported. Signed-off-by: Marko Kovacevic Signed-off-by: Fan Zhang --- examples/cryptodev_fips_validate/Makefile | 1 + .../cryptodev_fips_

[dpdk-dev] [PATCH v3 5/8] examples: add gcm parser

2018-10-04 Thread Fan Zhang
From: Marko Kovacevic Added enablement for GCM parser, to allow the application to parser the GCM request file and to validate all tests supported. Signed-off-by: Marko Kovacevic Signed-off-by: Fan Zhang --- examples/cryptodev_fips_validate/Makefile | 1 + .../cryptodev_fips_parse_

[dpdk-dev] [PATCH v3 2/8] examples: add aes parser and enablement for test types

2018-10-04 Thread Fan Zhang
From: Marko Kovacevic Added enablement for AES-CBC parser, to allow the application to parser the aes request file and to validate all test types supported. Signed-off-by: Marko Kovacevic Signed-off-by: Fan Zhang --- examples/cryptodev_fips_validate/Makefile | 1 + .../cryptodev_fi

[dpdk-dev] [PATCH v3 6/8] examples: add cmac parser and enablement for test types

2018-10-04 Thread Fan Zhang
From: Marko Kovacevic Added enablement for CMAC parser, to allow the application to parser the cmac request files and to validate all test types supported. Signed-off-by: Marko Kovacevic Signed-off-by: Fan Zhang --- examples/cryptodev_fips_validate/Makefile | 1 + .../cryptodev_fip

[dpdk-dev] [PATCH v3 4/8] examples: add TDES parser and enablement for test types

2018-10-04 Thread Fan Zhang
From: Marko Kovacevic Added enablement for TDES parser, to allow the application to parser the TDES request files and to validate all test types supported. Signed-off-by: Marko Kovacevic Signed-off-by: Fan Zhang --- examples/cryptodev_fips_validate/Makefile | 1 + .../cryptodev_fip

[dpdk-dev] [PATCH v3 3/6] net/avp: disable avp build in FREEBSD

2018-10-04 Thread Agalya Babu RadhaKrishnan
Disabled avp build in FreeBSD because it is not supported. Added changes to enable avp build if it is Linux OS and disable in FreeBSD. Signed-off-by: Agalya Babu RadhaKrishnan --- drivers/net/avp/meson.build | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/avp/meson.build b/dri

[dpdk-dev] [PATCH v3 0/6] fix for meson builds in freebsd

2018-10-04 Thread Agalya Babu RadhaKrishnan
Compilation issues were observed in FreeBSD when built via meson. VFIO flags are enabled/disabled based on linux/freebsd. Changes are done in meson.build files to ensure the build of drivers are enabled/disabled based on platform. 1/6: set/unset of vfio flags based on platforms 2/6: updated net/nf

[dpdk-dev] [PATCH v3 5/6] net/tap: disable tap build in FREEBSD

2018-10-04 Thread Agalya Babu RadhaKrishnan
Disabled tap build in FreeBSD because it is not supported Added changes to enable tap build if it is Linux OS and disable in FreeBSD. Signed-off-by: Agalya Babu RadhaKrishnan --- drivers/net/tap/meson.build | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/tap/meson.build b/driv

[dpdk-dev] [PATCH v3 4/6] net/softnic: disable softnic build in FREEBSD

2018-10-04 Thread Agalya Babu RadhaKrishnan
Disabled softnic build in FreeBSD because it is not supported Added changes to enable softnic build if it is Linux OS and disable in FreeBSD. Signed-off-by: Agalya Babu RadhaKrishnan --- drivers/net/softnic/meson.build | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/softnic/me

[dpdk-dev] [PATCH v3 2/6] net/nfp: disable nfp build in FREEBSD

2018-10-04 Thread Agalya Babu RadhaKrishnan
Disabled nfp build in FreeBSD because it is not supported Added changes to enable NFP build if it is Linux OS and disable in FreeBSD. Signed-off-by: Agalya Babu RadhaKrishnan --- drivers/net/nfp/meson.build | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/nfp/meson.build b/driv

[dpdk-dev] [PATCH v3 1/6] build: fix for FREEBSD build via meson

2018-10-04 Thread Agalya Babu RadhaKrishnan
FreeBSD compilation was failing through meson build. RTE_EAL_VFIO is not supported in FreeBSD. But RTE_EAL_VFIO was enabled for both linux and freebsd. So RTE_EAL_VFIO is removed from config/rte_config.h and based on the platform RTE_EAL_VFIO flag is enabled/disabled appropriately. Fixes: 844514c7

Re: [dpdk-dev] [PATCH v2 3/5] bus/pci: use IOVAs check when setting IOVA mode

2018-10-04 Thread Alejandro Lucero
On Wed, Oct 3, 2018 at 1:56 PM Burakov, Anatoly wrote: > On 31-Aug-18 1:50 PM, Alejandro Lucero wrote: > > Although VT-d emulation currently only supports 39 bits, it could > > be iovas being within that supported range. This patch allows > > IOVA mode in such a case. > > > > Indeed, memory initi

Re: [dpdk-dev] [PATCH] net/*/base: allow experimental APIs in base of avf and qede

2018-10-04 Thread Bruce Richardson
On Thu, Oct 04, 2018 at 04:18:35PM +0300, Ilya Maximets wrote: > This functionality was missed while adding new drivers to > the meson build. > > Fixes: 1d75caf81474 ("net/avf: add meson support") > Fixes: 30d3d0168301 ("net/qede: add in meson build") > > Signed-off-by: Ilya Maximets > --- Acked

[dpdk-dev] [PATCH v3 6/6] net/vdev_netvsc: disable vdev netvsc build in FREEBSD

2018-10-04 Thread Agalya Babu RadhaKrishnan
Disabled vdev_netvsc build in FreeBSD because it is not supported. Added changes to enable vdev_netvsc build if it is Linux OS and disable in FreeBSD. Signed-off-by: Agalya Babu RadhaKrishnan --- drivers/net/vdev_netvsc/meson.build | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/n

Re: [dpdk-dev] [PATCH v3 4/4] app/testpmd: collect bad outer L4 checksum for csum engine

2018-10-04 Thread Iremonger, Bernard
Hi Jerin, > -Original Message- > From: Jerin Jacob [mailto:jerin.ja...@caviumnetworks.com] > Sent: Wednesday, October 3, 2018 7:17 PM > To: Lu, Wenzhuo ; Wu, Jingjing > ; Iremonger, Bernard > > Cc: dev@dpdk.org; shah...@mellanox.com; Jerin Jacob > > Subject: [dpdk-dev] [PATCH v3 4/4] app

Re: [dpdk-dev] [PATCH 2/3] ethdev: add flow api actions to modify TCP/UDP port numbers

2018-10-04 Thread Ori Kam
> -Original Message- > From: dev On Behalf Of Rahul Lakkireddy > Sent: Monday, September 24, 2018 11:28 AM > To: dev@dpdk.org > Cc: indra...@chelsio.com; nirran...@chelsio.com > Subject: [dpdk-dev] [PATCH 2/3] ethdev: add flow api actions to modify > TCP/UDP port numbers > > Add action

Re: [dpdk-dev] [PATCH v13 7/7] app/testpmd: use hotplug failure handler

2018-10-04 Thread Jeff Guo
thanks for your kindly review. On 10/4/2018 6:31 PM, Iremonger, Bernard wrote: Hi Jeff, -Original Message- From: Guo, Jia Sent: Thursday, October 4, 2018 7:31 AM To: step...@networkplumber.org; Richardson, Bruce ; Yigit, Ferruh ; Ananyev, Konstantin ; gaetan.ri...@6wind.com; Wu, Jingji

Re: [dpdk-dev] [PATCH v7 0/8] implement packed virtqueues

2018-10-04 Thread Maxime Coquelin
Hi Jens, On 10/03/2018 03:11 PM, Jens Freimann wrote: To support out-of-order processing I used the vq_desc_extra struct to add a .next field and use it as a list for managing descriptors. This seemed to add less complexity to the code than adding a new data structure to use as a list for packed

  1   2   >