[dpdk-dev] [PATCH v2 3/3] ethdev: remove vxlan and nvgre encapsulation commands

2018-09-26 Thread Ori Kam
This patch removes the VXLAN and NVGRE encapsulation commands. Those commands are subset of the TUNNEL_ENCAP command so there is no need to keep both versions. Signed-off-by: Ori Kam --- doc/guides/prog_guide/rte_flow.rst | 107 - lib/librte_ethdev/rte_flow.h

[dpdk-dev] [PATCH v2 0/3] ethdev: add generic L2/L3 tunnel encapsulation actions

2018-09-26 Thread Ori Kam
This series implement the generic L2/L3 tunnel encapsulation actions and is based on rfc [1] "add generic L2/L3 tunnel encapsulation actions" Currenlty the encap/decap actions only support encapsulation of VXLAN and NVGRE L2 packets (L2 encapsulation is where the inner packet has a valid Ethernet

[dpdk-dev] [PATCH v2 1/4] devargs: remove deprecated functions

2018-09-26 Thread Thomas Monjalon
rte_eal_parse_devargs_str() does not support parsing the bus name at the start of devargs. So it has been renamed and deprecated. rte_eal_devargs_add(), rte_eal_devargs_type_count() and rte_eal_devargs_dump() were declared deprecated and had their implementation body renamed. All these functions

[dpdk-dev] [PATCH v2 0/4] eal: simplify devargs and hotplug functions

2018-09-26 Thread Thomas Monjalon
This is a follow-up of an idea presented at Dublin during the "hotplug talk". Instead of changing the existing hotplug functions, as in the RFC, some new experimental functions are added. The old functions lose their experimental status in order to provide a non-experimental replacement for deprec

[dpdk-dev] [PATCH v2 3/4] eal: remove experimental flag of hotplug functions

2018-09-26 Thread Thomas Monjalon
These functions are quite old and are the only available replacement for the deprecated attach/detach functions. Note: some new functions may (again) replace these hotplug functions, in future, with better parameters. Signed-off-by: Thomas Monjalon --- lib/librte_eal/common/eal_common_dev.c |

[dpdk-dev] [PATCH v2 4/4] eal: simplify parameters of hotplug functions

2018-09-26 Thread Thomas Monjalon
All information about a device to probe can be grouped in a common string, which is what we usually call devargs. An application should not have to parse this string before calling the EAL probe function. And the syntax could evolve to be more complex and support matching multiple devices in one st

[dpdk-dev] [PATCH v2 2/4] devargs: simplify parameters of removal function

2018-09-26 Thread Thomas Monjalon
The function rte_devargs_remove(), which is intended to be internal, can take a devargs structure as argument. The matching is still using string comparison of bus name and device name. It is simpler and may allow a different devargs matching in future. Signed-off-by: Thomas Monjalon --- drivers

[dpdk-dev] [PATCH] kni: implement header_ops parse method

2018-09-26 Thread Igor Ryzhov
Signed-off-by: Igor Ryzhov --- kernel/linux/kni/kni_net.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/kernel/linux/kni/kni_net.c b/kernel/linux/kni/kni_net.c index 7fcfa106c..128a5477c 100644 --- a/kernel/linux/kni/kni_net.c +++ b/kernel/linux/kni/kni_net.c @@ -678,6 +678,

[dpdk-dev] [PATCH v3 0/6] kni: add API to set link status on kernel interface

2018-09-26 Thread Dan Gora
Hi All, Attached is version 3 of a patchset to add a new API function to set the link status on kernel interfaces created with the KNI kernel module. v3 * Use separate function to test rte_kni_update_link() in 'test' app. * Separate changes to 'test' app into separate patch to facilitate

[dpdk-dev] [PATCH v3 1/6] kni: add API to set link status on kernel interface

2018-09-26 Thread Dan Gora
Add a new API function to KNI, rte_kni_update_link() to allow DPDK applications to update the link status for KNI network interfaces in the linux kernel. Signed-off-by: Dan Gora --- lib/librte_kni/rte_kni.c | 57 ++ lib/librte_kni/rte_kni.h | 18 ++

[dpdk-dev] [PATCH v3 3/6] kni: set default carrier state to 'off'

2018-09-26 Thread Dan Gora
Set the carrier state to 'off' when the interface is instantiated or when it is marked 'up' or 'down'. This is necessary to set the interface to a known operational state until the carrier state is changed with rte_kni_update_link(). Signed-off-by: Dan Gora --- kernel/linux/kni/kni_misc.c | 2 +

[dpdk-dev] [PATCH v3 4/6] examples/kni: monitor and update link status continually

2018-09-26 Thread Dan Gora
Update KNI example to continuously monitor the Ethernet link status of the physical link and update the link status of the corresponding interfaces with rte_kni_update_link(). Signed-off-by: Dan Gora --- examples/kni/Makefile | 2 ++ examples/kni/main.c | 73 +-

[dpdk-dev] [PATCH v3 2/6] kni: add link status test

2018-09-26 Thread Dan Gora
Test changing the link, speed, duplex, etc. status of the KNI interface with rte_kni_update_link(). Signed-off-by: Dan Gora --- test/test/test_kni.c | 131 +++ 1 file changed, 131 insertions(+) diff --git a/test/test/test_kni.c b/test/test/test_kni.c inde

[dpdk-dev] [PATCH v3 6/6] examples/kni: improve zeroing statistics

2018-09-26 Thread Dan Gora
The worker threads incrementing the rx/tx_packets race with the signal handler from the main thread zeroing the entire statistics structure. This can cause the statistics to fail to be zeroed, even when there is no traffic on those interfaces. Improve zeroing the statistics by only incrementing rx

[dpdk-dev] [PATCH v3 5/6] examples/kni: add log msgs to show and clear stats

2018-09-26 Thread Dan Gora
Add logging messages showing the commands necessary for the user to have the application display and zero the statistics. Signed-off-by: Dan Gora --- examples/kni/main.c | 16 +--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/examples/kni/main.c b/examples/kni/main.

Re: [dpdk-dev] How to replace rte_eth_dev_attach with rte_eal_hotplug_add

2018-09-26 Thread Hideyuki Yamashita
Dear Thomas, Thanks for your answer. It took me a little time to digest answer. Please see inline. > 21/09/2018 09:19, Hideyuki Yamashita: > > Dear Gaetan and Thomas, > > > > Thanks for your answer. > > Please see inline. > > > > > 20/09/2018 11:09, Ga?an Rivet: > > > > On Thu, Sep 20, 2018 a

[dpdk-dev] [PATCH v2] net/i40e: remove keeping CRC configuration for VF

2018-09-26 Thread Beilei Xing
Remove keeping CRC configuration since it's not supported by i40e VF. Signed-off-by: Beilei Xing --- drivers/net/i40e/i40e_ethdev_vf.c | 16 1 file changed, 16 deletions(-) v2 changes: - Remove the whole branch since offload has been checked in rte_eth_dev_configure. diff --

[dpdk-dev] [PATCH v3 0/3] hash: add extendable bucket and partial key hashing

2018-09-26 Thread Yipeng Wang
This patch set made two major optimizations over the current rte_hash library. First, it adds Extendable Bucket Table feature: a new structure that can accommodate keys that failed to get inserted into the main hash table due to the unlikely event of excessive hash collisions. The hash table bucke

[dpdk-dev] [PATCH v3 3/3] hash: use partial-key hashing

2018-09-26 Thread Yipeng Wang
This commit changes the hashing mechanism to "partial-key hashing" to calculate bucket index and signature of key. This is proposed in Bin Fan, et al's paper "MemC3: Compact and Concurrent MemCache with Dumber Caching and Smarter Hashing". Bascially the idea is to use "xor" to derive alternative

[dpdk-dev] [PATCH v3 2/3] test/hash: implement extendable bucket hash test

2018-09-26 Thread Yipeng Wang
This commit changes the current rte_hash unit test to test the extendable table feature and performance. Signed-off-by: Yipeng Wang --- test/test/test_hash.c | 151 +++-- test/test/test_hash_perf.c | 114 +- 2 files cha

[dpdk-dev] [PATCH v3 1/3] hash: add extendable bucket feature

2018-09-26 Thread Yipeng Wang
In use cases that hash table capacity needs to be guaranteed, the extendable bucket feature can be used to contain extra keys in linked lists when conflict happens. This is similar concept to the extendable bucket hash table in packet framework. This commit adds the extendable bucket feature. User

Re: [dpdk-dev] [PATCH v2 1/7] test/hash: fix bucket size in hash perf test

2018-09-26 Thread Wang, Yipeng1
Hi Bruce, In the test, the bucket size and number of buckets are used to map to the underneath rte_hash structure. They are used to test performance of two scenarios: keys in primary buckets only and keys in both primary and secondary buckets. Although there is no functional issue with bucket siz

Re: [dpdk-dev] [PATCH v2 0/7] hash: add extendable bucket and partial key hashing

2018-09-26 Thread Wang, Yipeng1
Done! Now they are two separate patch sets. Thanks Yipeng >-Original Message- >From: Richardson, Bruce >I'd suggest splitting this set into two. The first 4 patches are easy to >review and should be quickly merged (I hope :-)), allowing us to focus more on >the bigger patches adding the k

Re: [dpdk-dev] [PATCH v2 3/7] test/hash: fix rw test with non-consecutive cores

2018-09-26 Thread Wang, Yipeng1
I added another commit for this. Please test. Thanks! >-Original Message- > >When testing this patch, I see that the read-write autotests are not >currently in the meson.build file for the test binary. I think this >patchset should include this fix too, as a separate patch.

Re: [dpdk-dev] [PATCH v2 1/7] test/hash: fix bucket size in hash perf test

2018-09-26 Thread Honnappa Nagarahalli
> -Original Message- > From: Yipeng Wang > Sent: Friday, September 21, 2018 12:17 PM > To: bruce.richard...@intel.com > Cc: dev@dpdk.org; yipeng1.w...@intel.com; mic...@digirati.com.br; > Honnappa Nagarahalli > Subject: [PATCH v2 1/7] test/hash: fix bucket size in hash perf test > > T

Re: [dpdk-dev] [PATCH v2 0/7] hash: add extendable bucket and partial key hashing

2018-09-26 Thread Honnappa Nagarahalli
> -Original Message- > From: Yipeng Wang > Sent: Friday, September 21, 2018 12:17 PM > To: bruce.richard...@intel.com > Cc: dev@dpdk.org; yipeng1.w...@intel.com; mic...@digirati.com.br; > Honnappa Nagarahalli > Subject: [PATCH v2 0/7] hash: add extendable bucket and partial key hashing

Re: [dpdk-dev] [PATCH v2 5/7] hash: add extendable bucket feature

2018-09-26 Thread Honnappa Nagarahalli
> -Original Message- > From: Yipeng Wang > Sent: Friday, September 21, 2018 12:18 PM > To: bruce.richard...@intel.com > Cc: dev@dpdk.org; yipeng1.w...@intel.com; mic...@digirati.com.br; > Honnappa Nagarahalli > Subject: [PATCH v2 5/7] hash: add extendable bucket feature > > In use case

Re: [dpdk-dev] [PATCH v2 6/7] test/hash: implement extendable bucket hash test

2018-09-26 Thread Honnappa Nagarahalli
> -Original Message- > From: Yipeng Wang > Sent: Friday, September 21, 2018 12:18 PM > To: bruce.richard...@intel.com > Cc: dev@dpdk.org; yipeng1.w...@intel.com; mic...@digirati.com.br; > Honnappa Nagarahalli > Subject: [PATCH v2 6/7] test/hash: implement extendable bucket hash test >

Re: [dpdk-dev] [PATCH v2 7/7] hash: use partial-key hashing

2018-09-26 Thread Honnappa Nagarahalli
> -Original Message- > From: Yipeng Wang > Sent: Friday, September 21, 2018 12:18 PM > To: bruce.richard...@intel.com > Cc: dev@dpdk.org; yipeng1.w...@intel.com; mic...@digirati.com.br; > Honnappa Nagarahalli > Subject: [PATCH v2 7/7] hash: use partial-key hashing > > This commit chang

[dpdk-dev] [PATCH v2 1/2] test: fix event timer compiler warning

2018-09-26 Thread Nikhil Rao
Limit the number of objects passed to rte_mempool_put_bulk() to the size of the object table. This fix eliminates a compiler warning (array-bounds) triggered when the march command line parameter to gcc is set to nehalem. Fixes: d1f3385d0076 ("test: add event timer adapter auto-test") Cc: erik.g.c

[dpdk-dev] [PATCH v2 2/2] test/event: add adapter tests to meson build

2018-09-26 Thread Nikhil Rao
Add tests for event eth Rx, crypto and timer adapters to meson build Cc: Abhinandan Gujjar Cc: Erik G. Carrillo Signed-off-by: Nikhil Rao --- test/test/meson.build | 7 +++ 1 file changed, 7 insertions(+) diff --git a/test/test/meson.build b/test/test/meson.build index b1dd6ec..1b2e8b7 1

[dpdk-dev] [PATCH] test: reduce test time for hash multiwriter ut

2018-09-26 Thread Naga Suresh Somarowthu
Reduced test duration for hash_multiwriter_autotest. Number of entries and total insertions are reduced such that the duration is less than 10 seconds. Signed-off-by: Naga Suresh Somarowthu --- test/test/test_hash_multiwriter.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --gi

[dpdk-dev] [PATCH] test: reduce test time for hash multiwriter ut

2018-09-26 Thread Jananee Parthasarathy
From: Naga Suresh Somarowthu Reduced test duration for hash_multiwriter_autotest. Number of entries and total insertions are reduced such that the duration is less than 10 seconds. Signed-off-by: Naga Suresh Somarowthu --- test/test/test_hash_multiwriter.c | 4 ++-- 1 file changed, 2 insertion

Re: [dpdk-dev] [PATCH] net/i40e: fix 25G AOC and ACC cable detection on XXV710

2018-09-26 Thread Zhang, Qi Z
> -Original Message- > From: Damjan Marion [mailto:damar...@cisco.com] > Sent: Tuesday, September 25, 2018 4:17 PM > To: Xing, Beilei ; Zhang, Qi Z > Cc: dev@dpdk.org; Damjan Marion ; sta...@dpdk.org > Subject: [PATCH] net/i40e: fix 25G AOC and ACC cable detection on XXV710 > > Fixes:

<    1   2   3