-Original Message-
> Date: Tue, 4 Sep 2018 23:40:36 -0400
> From: Eric Zhang
> To: santosh , hemant.agra...@nxp.com,
> Gaëtan Rivet , "Burakov, Anatoly"
>
> CC: bruce.richard...@intel.com, dev@dpdk.org, allain.leg...@windriver.com,
> matt.pet...@windriver.com
> Subject: Re: [dpdk-dev]
Wednesday, September 5, 2018 12:00 PM, Tom Barbette:
>Actually I managed this patch to implement support for
>rte_eth_timesync_read_time.
I am not fully familiar w/ this API, but it looks like the timespec returned
from this call is expected to be in real time values (i.e. seconds and nano
seco
Use RTE_MAX_ETHPORTS instead of rte_eth_dev_count_total()
when allocating eth Rx adapter's per-eth device data structure
to account for hotplugged devices.
Fixes: 9c38b704d280 ("eventdev: add eth Rx adapter implementation")
Cc: sta...@dpdk.org
Signed-off-by: Nikhil Rao
---
lib/librte_eventdev/rt
eth Rx adapter has been updated to support hotplugged
devices, devices created after adapter creation can now be
added to the adapter.
Update the adapter_multi_eth_add_del
test case to create the adapter as part of test setup
instead of creating it after creating vdevs.
Fixes: 2a9c83ae3b2e ("test
It's true that it is a little bit a distortion of the original purpose. Here I
want to query the time from the device (ie, the device's current clock). Maybe
a new function in the API would be more suited? CCing Thomas Mojalon for that
part of the discussion.
I guess there is a case to query
https://bugs.dpdk.org/show_bug.cgi?id=89
Bug ID: 89
Summary: XL710 DPDK i40evf : Ping is not working when RSS
enabled for IP
Product: DPDK
Version: 16.07
Hardware: x86
OS: Linux
Status: CONFIRMED
This patch fixes the issue that representor port shows xstats of PF.
Fixes: 5a4b8e2612c5 ("net/mlx5: probe all port representors")
Signed-off-by: Xueming Li
---
drivers/net/mlx5/mlx5_stats.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/mlx5/mlx5_stats.c
On Thu, 6 Sep 2018 09:29:32 +0300
Andrew Rybchenko wrote:
> On 09/05/2018 07:41 PM, Stephen Hemminger wrote:
> > This addresses the usability issue raised by OVS at DPDK Userspace
> > summit. It adds general min/max mtu into device info. For compatiablity,
> > and to save space, it fits in a hole
There is a new set of TR bits that can be used when replacing
the cloud filters so add them in. Also added a check to make
sure that the replace cloud filters AQ command doesn't get
executed on an X722 since it is not supported there.
Fixes: de2cd512b176 ("net/i40e/base: new AQ commands for cloud
Patch 5355f443 added two definitions of DEV_TX_OFFLOAD_xxx.
If new Tx offload capabilities are defined, they also must be mentioned
in rte_tx_offload_names in rte_ethdev.c file.
This patch adds the required lines in aray rte_tx_offload_names.
Fixes: 5355f4439e2e ("ethdev: introduce generic IP/UDP
Hi Yipeng,
On 09/04/2018 02:55 PM, Wang, Yipeng1 wrote:
Do we need both of the state and istate struct? struct rte_hash_iterator_state
seems not doing much.
How about we only have one "state" struct and just not expose the internals to
the public API, similar to the
rte_hash struct or rte_mem
Hi Gaëtan,
On 08/31/2018 06:53 PM, Gaëtan Rivet wrote:
Hi Qiaobin,
This work seems interesting, but is difficult to follow because
the previous discussion is not referenced.
You can find a how-to there:
http://doc.dpdk.org/guides/contributing/patches.html#sending-patches
--in-reply-to is use
Hi Yipeng,
On 09/04/2018 03:51 PM, Wang, Yipeng1 wrote:
Hmm, I guess my comment is for code readability. If we don’t need the extra
state that would be great.
Notice that applications only see the public, opaque state. And the
private versions are scoped to the C file where they are neede
Hi Yipeng,
On 09/04/2018 04:57 PM, Wang, Yipeng1 wrote:
-Original Message-
From: Michel Machado [mailto:mic...@digirati.com.br]
Exposing the private fields would bind the interface with the
current implementation of the hash table. In the way we are proposing,
one should be able t
Hi Honnappa,
On 09/02/2018 06:05 PM, Honnappa Nagarahalli wrote:
+/* istate stands for internal state. */ struct rte_hash_iterator_istate
+{
+ const struct rte_hash *h;
This can be outside of this structure. This will help keep the API definitions
consistent with existing APIs. Please see
when rte_vhost_driver_unregister delete the connection fd,
the fd lock will prevent the vsocket to be freed. But when
vhost_user_msg_handler
return error, it will delete vsocket conn_list. And then the fd lock will become
invalid. So the vsocket will be freed in rte_vhost_drivere_unregister and th
Thursday, September 6, 2018 12:33 PM, Tom Barbette:
Subject: RE: MLX5 should define the timestamp field in the doc
>
>It's true that it is a little bit a distortion of the original purpose. Here I
>want to query the time from the device (ie, the device's current clock). Maybe
>a new function in t
If checksum offload enabled and hardware reports checksum as good,
update mbuf ol_flags with proper *_CKSUM_GOOD bits.
Fixes: b812daadad0d ("nfp: add Rx and Tx")
Cc: sta...@dpdk.org
Signed-off-by: Alejandro Lucero
---
drivers/net/nfp/nfp_net.c | 15 +++
drivers/net/nfp/nfp_net_p
Support for PCAP physical interface MAC with phy_mac=1 devarg.
Signed-off-by: Juhamatti Kuusisaari
---
doc/guides/rel_notes/release_18_11.rst | 4 +
drivers/net/pcap/rte_eth_pcap.c| 119 +++--
2 files changed, 118 insertions(+), 5 deletions(-)
diff --git a/doc/guid
Support for PCAP physical interface MAC with phy_mac=1 devarg.
Signed-off-by: Juhamatti Kuusisaari
---
doc/guides/rel_notes/release_18_11.rst | 4 +
drivers/net/pcap/rte_eth_pcap.c| 117 +++--
2 files changed, 116 insertions(+), 5 deletions(-)
diff --git a/doc/guid
Add rte_flow infra structure for flow api support.
Signed-off-by: Cristian Dumitrescu
Signed-off-by: Reshma Pattan
---
drivers/net/softnic/rte_eth_softnic_internals.h | 17 +
1 file changed, 17 insertions(+)
diff --git a/drivers/net/softnic/rte_eth_softnic_internals.h
b/driver
Added mapping support from rte flow attributes
to softnic pipeline and table.
So added flow attribute map set and get functions
definition to new file rte_eth_sofnic_flow.c.
Added pmd flow internals with ingress and egress
flow attribute maps.
Signed-off-by: Cristian Dumitrescu
Signed-off-by: R
This patch series adds the flow API support
for the softnic.
This patch set also introduce a new cli command
to provide mapping of flow group and direction
to softnic pipeline and table.
Reshma Pattan (15):
net/softnic: add infrastructure for flow API
net/softnic: rte flow attr mapping to pip
Added new cli by which user can specify to softnic
which rte flow group and direction has to mapped to
which pipeline and table.
Signed-off-by: Cristian Dumitrescu
Signed-off-by: Reshma Pattan
---
drivers/net/softnic/rte_eth_softnic_cli.c | 81 +++
1 file changed, 81
Change dev_name, action_profile_name and key_mask
from char* type to arary type of structures
softnic_port_in_params, softnic_port_out_params
and softnic_table_hash_params.
Signed-off-by: Cristian Dumitrescu
Signed-off-by: Reshma Pattan
---
drivers/net/softnic/rte_eth_softnic_cli.c | 34 +
Added utility function to freeup the
pipeline tables.
Added utility functions to find the pipeline
output port.
Signed-off-by: Cristian Dumitrescu
Signed-off-by: Reshma Pattan
---
drivers/net/softnic/rte_eth_softnic_internals.h | 13 ++
drivers/net/softnic/rte_eth_softnic_pipeline.c | 57
Add utility function to get the rte_eth_dev from
a given softnic.
Signed-off-by: Cristian Dumitrescu
Signed-off-by: Reshma Pattan
---
drivers/net/softnic/rte_eth_softnic_internals.h | 17 +
1 file changed, 17 insertions(+)
diff --git a/drivers/net/softnic/rte_eth_softnic_intern
Added flow protocol parsing for IPV4/IPV6 and
TCP/UDP/SCTP for ACL table rule match.
Added below helper functions for doing the same.
port_mask_to_range()
ipv6_mask_to_depth()
ipv4_mask_to_depth()
mask_to_depth()
Signed-off-by: Cristian Dumitrescu
Signed-off-by: Reshma Pattan
---
drivers/net/s
Start adding flow api operations.
Started with flow validate api support by adding
below basic infrastructure.
flow_pipeline_table_get()
pmd_flow_validate()
Additional flow validate changes will be
added in next patches.
Signed-off-by: Cristian Dumitrescu
Signed-off-by: Reshma Pattan
---
dri
Support for validating and mapping rte flow rule with
ACL table match is added.
As part of this support below utility functions
been added
flow_rule_match_get()
flow_rule_match_acl_get()
flow_item_skip_disabled_protos()
flow_item_proto_preprocess()
flow_item_is_proto()
flow_item_raw_preprocess()
Support for validating and mapping flow rule with HASH
table match is added.
As part of this, below helper functions are added.
flow_rule_match_hash_get()
hash_key_mask_is_same()
Signed-off-by: Cristian Dumitrescu
Signed-off-by: Reshma Pattan
---
drivers/net/softnic/rte_eth_softnic_flow.c | 20
Added validation and mapping of flow rule action
with table action profile.
Added flow_rule_action_get() to do the same.
Signed-off-by: Cristian Dumitrescu
Signed-off-by: Reshma Pattan
---
drivers/net/softnic/rte_eth_softnic_flow.c | 350 +
1 file changed, 350 inser
Added pmd_flow_query() API, for flow query
support.
Signed-off-by: Cristian Dumitrescu
Signed-off-by: Reshma Pattan
---
drivers/net/softnic/rte_eth_softnic_flow.c | 55 ++
1 file changed, 55 insertions(+)
diff --git a/drivers/net/softnic/rte_eth_softnic_flow.c
b/dr
pmd_flow_create API is added to support
rte flow create.
Signed-off-by: Cristian Dumitrescu
Signed-off-by: Reshma Pattan
---
drivers/net/softnic/rte_eth_softnic_flow.c | 174 +
1 file changed, 174 insertions(+)
diff --git a/drivers/net/softnic/rte_eth_softnic_flow.c
Added support for parsing raw flow item.
flow_item_raw_preprocess() is added for the same.
Signed-off-by: Cristian Dumitrescu
Signed-off-by: Reshma Pattan
---
drivers/net/softnic/rte_eth_softnic_flow.c | 108 +
1 file changed, 108 insertions(+)
diff --git a/drivers/
pmd_flow_destroy() API is added to destroy the
created flow.
Signed-off-by: Cristian Dumitrescu
Signed-off-by: Reshma Pattan
---
drivers/net/softnic/rte_eth_softnic_flow.c | 39 ++
1 file changed, 39 insertions(+)
diff --git a/drivers/net/softnic/rte_eth_softnic_flo
Support for PCAP physical interface MAC with phy_mac=1 devarg.
Signed-off-by: Juhamatti Kuusisaari
---
doc/guides/rel_notes/release_18_11.rst | 4 +
drivers/net/pcap/rte_eth_pcap.c| 118 +++--
2 files changed, 117 insertions(+), 5 deletions(-)
diff --git a/doc/guid
Support for PCAP physical interface MAC with phy_mac=1 devarg.
Signed-off-by: Juhamatti Kuusisaari
---
doc/guides/rel_notes/release_18_11.rst | 4 +
drivers/net/pcap/rte_eth_pcap.c| 119 +++--
2 files changed, 118 insertions(+), 5 deletions(-)
diff --git a/doc/guid
Currently, reader-writer concurrency problems in rte_hash are
addressed using reader-writer locks. Use of reader-writer locks
results in following issues:
1) In many of the use cases for the hash table, writer threads
are running on control plane. If the writer is preemp
Correct the key store array element alignment. This is required to
make 'pdata' in 'struct rte_hash_key' align on the correct boundary.
Signed-off-by: Honnappa Nagarahalli
Reviewed-by: Gavin Hu
Reviewed-by: Ola Liljedahl
Reviewed-by: Steve Capper
---
lib/librte_hash/rte_cuckoo_hash.c | 4 +++-
Only race condition that can occur is - using the key store element
before the key write is completed. Hence, while inserting the element
the release memory order is used. Any other race condition is caught
by the key comparison. Memory orderings are added only where needed.
For ex: reads in the w
Add the flag to enable reader-writer concurrency during
run time. The rte_hash_del_xxx APIs do not free the keystore
element when this flag is enabled. Hence a new API,
rte_hash_free_key_with_position, to free the key store element
is added.
Signed-off-by: Honnappa Nagarahalli
Reviewed-by: Gavin
Reader-writer concurrency issue, caused by moving the keys
to their alternative locations during key insert, is solved
by introducing a global counter(tbl_chng_cnt) indicating a
change in table.
Signed-off-by: Honnappa Nagarahalli
Reviewed-by: Gavin Hu
Reviewed-by: Ola Liljedahl
Reviewed-by: St
Hi all,
First, thanks for the vdpa example patches.
Second, I am getting a compilation error under Ubuntu 18.04, with gcc
version 7.3.0 (Ubuntu 7.3.0-16ubuntu3)
...
CC main.o
/work/src/dpdk/examples/vdpa/main.c: In function ‘main’:
/work/src/dpdk/examples/vdpa/main.c:321:5: error: ignoring return
> On Sep 6, 2018, at 7:10 AM, Saber Rezvani wrote:
>
>
>
> On 08/29/2018 11:22 PM, Wiles, Keith wrote:
> >
> >> On Aug 29, 2018, at 12:19 PM, Saber Rezvani wrote:
> >>
> >>
> >>
> >> On 08/29/2018 01:39 AM, Wiles, Keith wrote:
> On Aug 28, 2018, at 2:16 PM, Saber Rezvani wrote:
This is a basic implementation of packed virtqueues as specified in the
Virtio 1.1 draft. A compiled version of the current draft is available
at https://github.com/oasis-tcs/virtio-docs.git (or as .pdf at
https://github.com/oasis-tcs/virtio-docs/blob/master/virtio-v1.1-packed-wd10.pdf
It does not
Signed-off-by: Jens Freimann
---
drivers/net/virtio/virtio_ring.h | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/net/virtio/virtio_ring.h b/drivers/net/virtio/virtio_ring.h
index cea4d441e..e2c597434 100644
--- a/drivers/net/virtio/virtio_ring.h
+++ b/drivers/net/virtio/virtio_ri
Add and initialize descriptor data structures.
Signed-off-by: Jens Freimann
---
drivers/net/virtio/virtio_ethdev.c | 22 ++--
drivers/net/virtio/virtio_pci.h| 8 +
drivers/net/virtio/virtio_ring.h | 55 +++---
drivers/net/virtio/virtqueue.h | 10 +++
Flush used descriptors in packed receive virtqueue. As descriptors
can be chained we need to look at the stored number of used descriptors
to find out the length of the chain.
Signed-off-by: Jens Freimann
---
drivers/net/virtio/virtqueue.c | 17 +
1 file changed, 17 insertions(+)
From: Yuanhan Liu
Add option to enable packed queue support for virtio-user
devices.
Signed-off-by: Yuanhan Liu
---
drivers/net/virtio/virtio_user/virtio_user_dev.c | 10 --
drivers/net/virtio/virtio_user/virtio_user_dev.h | 2 +-
drivers/net/virtio/virtio_user_ethdev.c | 14
Add helper functions to set/clear and check descriptor flags.
Signed-off-by: Jens Freimann
---
drivers/net/virtio/virtio_ring.h | 26 ++
drivers/net/virtio/virtqueue.h | 19 +++
2 files changed, 45 insertions(+)
diff --git a/drivers/net/virtio/virtio_ri
Add support to dump packed virtqueue data to the
VIRTQUEUE_DUMP() macro.
Signed-off-by: Jens Freimann
---
drivers/net/virtio/virtqueue.h | 6 ++
1 file changed, 6 insertions(+)
diff --git a/drivers/net/virtio/virtqueue.h b/drivers/net/virtio/virtqueue.h
index 53fce61b4..531ba8c65 100644
---
This implements the transmit path for devices with
support for packed virtqueues.
Add the feature bit and enable code to
add buffers to vring and mark descriptors as available.
Signed-off-by: Jens Freiman
---
drivers/net/virtio/virtio_ethdev.c | 8 +-
drivers/net/virtio/virtio_ethdev.h | 2
Signed-off-by: Jens Freiman
---
drivers/net/virtio/virtio_ethdev.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/drivers/net/virtio/virtio_ethdev.c
b/drivers/net/virtio/virtio_ethdev.c
index a2bb726ba..b02c65598 100644
--- a/drivers/net/virtio/virtio_ethdev.c
+++ b/drivers/net/vir
Signed-off-by: Jens Freimann
---
drivers/net/virtio/virtio_ethdev.c | 2 +-
drivers/net/virtio/virtio_rxtx.c | 15 +-
drivers/net/virtio/virtqueue.h | 77 --
3 files changed, 89 insertions(+), 5 deletions(-)
diff --git a/drivers/net/virtio/virtio_ethdev.c
Implement support for receiving merged buffers in virtio when packed
virtqueues are enabled.
Signed-off-by: Jens Freimann
---
drivers/net/virtio/virtio_ethdev.c | 4 --
drivers/net/virtio/virtio_rxtx.c | 103 +++--
drivers/net/virtio/virtqueue.h | 1 +
3 files c
Implement the receive part.
Signed-off-by: Jens Freimann
---
drivers/net/virtio/virtio_ethdev.c | 15 +++-
drivers/net/virtio/virtio_ethdev.h | 2 +
drivers/net/virtio/virtio_rxtx.c | 131 +
3 files changed, 145 insertions(+), 3 deletions(-)
diff --git a/drivers
The bucket size was changed from 4 to 8 but the corresponding
perf test was not changed accordingly.
Fixes: 58017c98ed53 ("hash: add vectorized comparison")
Cc: sta...@dpdk.org
Signed-off-by: Yipeng Wang
---
test/test/test_hash_perf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
This patch set made two major improvements over the current rte_hash library.
First, it adds Extendable Bucket Table feature: a new structure that can
accommodate keys that failed to get inserted into the main hash table due to
the unlikely event of excessive hash collisions. The hash table bucket
This commit changes the current rte_hash unit test to
test the extendable table feature and performance.
Signed-off-by: Yipeng Wang
---
test/test/test_hash.c | 145 +++--
test/test/test_hash_perf.c | 114 +--
2 files ch
Edit the printf information when error happens to be more
accurate and informative.
Signed-off-by: Yipeng Wang
---
test/test/test_hash_perf.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/test/test/test_hash_perf.c b/test/test/test_hash_perf.c
index 9ed7125..4d00
This commit changes the hashing mechanism to "partial-key
hashing" to calculate bucket index and signature of key.
This is proposed in Bin Fan, et al's paper
"MemC3: Compact and Concurrent MemCache with Dumber Caching
and Smarter Hashing". Bascially the idea is to use "xor" to
derive alternative
In use cases that hash table capacity needs to be guaranteed,
the extendable bucket feature can be used to contain extra
keys in linked lists when conflict happens. This is similar
concept to the extendable bucket hash table in packet
framework.
This commit adds the extendable bucket feature. User
when rte_vhost_driver_unregister delete the connection fd,
the fd lock will prevent the vsocket to be freed. But when
vhost_user_msg_handler return error, it will delete vsocket
conn_list. And then the fd lock will become invalid. So the
vsocket will be freed in rte_vhost_drivere_unregister and
the
Hi, Rosen.
Thanks a lot for your comments.
On 09/06, Rami Rosen wrote:
>Hi all,
>First, thanks for the vdpa example patches.
>Second, I am getting a compilation error under Ubuntu 18.04, with gcc
>version 7.3.0 (Ubuntu 7.3.0-16ubuntu3)
>...
> CC main.o
>/work/src/dpdk/examples/vdpa/main.c: In fu
Crypto devices, which support lookaside protocol, exposes security
session size in addition to the crypto private symmetric session data
size. For applications using the security capabilities, both these
sizes need to be considered.
Fixes: ec17993a145a ("examples/ipsec-secgw: support security offl
66 matches
Mail list logo
