Re: [dpdk-dev] [PATCH] net/ixgbe: remove hardcoded CRC STRIP config from ixgbe

2018-08-12 Thread Andrew Rybchenko
On 12.08.2018 09:28, Shahaf Shuler wrote: Thursday, August 9, 2018 11:32 AM, Ferruh Yigit: Subject: Re: [PATCH] net/ixgbe: remove hardcoded CRC STRIP config from ixgbe On 7/24/2018 3:36 AM, Wei Zhao wrote: There is CRC related ifdefs for ixgbe: CONFIG_RTE_LIBRTE_IXGBE_PF_DISABLE_STRIP_CRC=n It

Re: [dpdk-dev] [PATCH] net/ixgbe: remove hardcoded CRC STRIP config from ixgbe

2018-08-12 Thread Shahaf Shuler
Sunday, August 12, 2018 10:53 AM, Andrew Rybchenko: > Subject: Re: [PATCH] net/ixgbe: remove hardcoded CRC STRIP config from > ixgbe > > On 12.08.2018 09:28, Shahaf Shuler wrote: > > Thursday, August 9, 2018 11:32 AM, Ferruh Yigit: > >> Subject: Re: [PATCH] net/ixgbe: remove hardcoded CRC STRIP co

Re: [dpdk-dev] [PATCH v14 5/6] drivers/net: enable device detach on secondary

2018-08-12 Thread Andrew Rybchenko
On 10.08.2018 03:42, Qi Zhang wrote: With the enabling for hotplug on multi-process, it is not necessary to prevent detaching a device from a secondary process. Signed-off-by: Qi Zhang From the patch itself including description it is absolutely unclear why detach works and where it actually

Re: [dpdk-dev] [PATCH v14 4/6] drivers/net: enable hotplug on secondary process

2018-08-12 Thread Andrew Rybchenko
On 10.08.2018 03:42, Qi Zhang wrote: Attach port from secondary should ignore devargs since the private device is not necessary to support. Also previously, detach port on a secondary process will mess primary process and cause the same device can't be attached back again. A secondary process sho

Re: [dpdk-dev] [PATCH v14 1/6] ethdev: add function to release port in secondary process

2018-08-12 Thread Andrew Rybchenko
On 10.08.2018 03:42, Qi Zhang wrote: Add driver API rte_eth_release_port_secondary to support the case when an ethdev need to be detached on a secondary process. Local state is set to unused and shared data will not be reset so the primary process can still use it. Signed-off-by: Qi Zhang ---

[dpdk-dev] [PATCH] net/mlx5: fix RSS flow action hash type selection

2018-08-12 Thread Shahaf Shuler
On the code after the below commits, the criteria to select the IPV4 or IPV6 hash functions was the existence of some ETH_RSS_IPV4 RSS types on the flow rule. The check is wrong. For example ETH_RSS_NONFRAG_IPV4_TCP will not select the IPV4 hash which will cause the packet to be spread in a bad wa

Re: [dpdk-dev] [PATCH v2] ethdev: fix device info getting

2018-08-12 Thread Lu, Wenzhuo
Hi Thomas, > -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Wednesday, August 1, 2018 11:37 PM > To: Lu, Wenzhuo ; Andrew Rybchenko > ; Yigit, Ferruh > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2] ethdev: fix device info getting > > 16/07/2018 0