Re: [dpdk-dev] [PATCH V4 8/9] app/testpmd: show example to handle hot unplug

2018-07-04 Thread Matan Azrad
Hi Thomas, Guo From: Thomas Monjalon > 03/07/2018 11:35, Guo, Jia: > > On 7/1/2018 3:46 PM, Matan Azrad wrote: > > > From: Jeff Guo > > >> --- a/app/test-pmd/testpmd.c > > >> +++ b/app/test-pmd/testpmd.c > > >> @@ -2206,9 +2209,12 @@ eth_dev_event_callback(char > *device_name, > > >> enum rte_dev_

Re: [dpdk-dev] [PATCH V4 1/9] bus: introduce hotplug failure handler

2018-07-04 Thread Guo, Jia
On 7/4/2018 6:21 AM, Thomas Monjalon wrote: 29/06/2018 12:30, Jeff Guo: /** + * Implementation a specific hot plug handler, which is responsible + * for handle the failure when hot remove the device, guaranty the system + * would not crash in the case. + * @param dev + * Pointer of the

Re: [dpdk-dev] [PATCH] doc: change tools guide to SPDX license

2018-07-04 Thread Hemant Agrawal
Colin/Christian, Can someone from canonical ack this patch. Regards, Hemant -Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Hemant Agrawal Sent: Tuesday, June 5, 2018 1:20 PM To: dev@dpdk.org Cc: tho...@monjalon.net; john.mcnam...@intel.com; christian.ehrha...@ca

Re: [dpdk-dev] [PATCH v8 04/19] ethdev: introduce device lock

2018-07-04 Thread Thomas Monjalon
04/07/2018 03:47, Zhang, Qi Z: > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > 03/07/2018 17:08, Zhang, Qi Z: > > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > > > 02/07/2018 07:44, Qi Zhang: > > > > > Introduce API rte_eth_dev_lock and rte_eth_dev_unlock to let > > > > > applic

[dpdk-dev] SPDX tag for DPDK project

2018-07-04 Thread Hemant Agrawal
Hi all, DPDK Techboard has a goal to make DPDK as SPDX compliant in Release 18.08. Will you please make sure that your maintained code is having SPDX licensing tag. The following commands may be handy for you to check, if your maintained code is not having SPDX tags. gre

Re: [dpdk-dev] [PATCH v8 03/19] ethdev: enable hotplug on multi-process

2018-07-04 Thread Thomas Monjalon
04/07/2018 04:26, Zhang, Qi Z: > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > 03/07/2018 23:57, Thomas Monjalon: > > > 03/07/2018 17:03, Zhang, Qi Z: > > > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > > > > 03/07/2018 14:59, Zhang, Qi Z: > > > > > > > > +do_eth_dev_attach(cons

[dpdk-dev] [PATCH] security: change to SPDX license tags

2018-07-04 Thread Hemant Agrawal
Signed-off-by: Hemant Agrawal --- lib/librte_security/rte_security.c| 34 +++ lib/librte_security/rte_security.h| 34 +++ lib/librte_security/rte_security_driver.h | 34 +++ 3 files changed, 9 inse

Re: [dpdk-dev] [PATCH V4 1/9] bus: introduce hotplug failure handler

2018-07-04 Thread Thomas Monjalon
04/07/2018 09:16, Guo, Jia: > > On 7/4/2018 6:21 AM, Thomas Monjalon wrote: > > 29/06/2018 12:30, Jeff Guo: > >> /** > >> + * Implementation a specific hot plug handler, which is responsible > >> + * for handle the failure when hot remove the device, guaranty the system > >> + * would not crash

[dpdk-dev] [PATCH] security: remove experimental tag from security APIs

2018-07-04 Thread Hemant Agrawal
Signed-off-by: Hemant Agrawal --- doc/guides/rel_notes/release_18_08.rst | 7 +++ lib/librte_security/rte_security.c | 18 +- lib/librte_security/rte_security.h | 28 +--- lib/librte_security/rte_security_driver.h| 2 --

Re: [dpdk-dev] [PATCH] security: remove experimental tag from security APIs

2018-07-04 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Hemant Agrawal > Sent: Wednesday, July 4, 2018 8:54 AM > To: Nicolau, Radu ; akhil.go...@nxp.com; Doherty, > Declan ; bor...@mellanox.com > Cc: dev@dpdk.org > Subject: [dpdk-dev] [PATCH] security: remove experime

Re: [dpdk-dev] [PATCH v2 12/20] net/mlx5: add mark/flag flow action

2018-07-04 Thread Yongseok Koh
On Wed, Jun 27, 2018 at 05:07:44PM +0200, Nelio Laranjeiro wrote: > Signed-off-by: Nelio Laranjeiro > --- > drivers/net/mlx5/mlx5_flow.c | 209 +++ > 1 file changed, 209 insertions(+) > > diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c > i

[dpdk-dev] [PATCH v2] security: remove experimental tag from security APIs

2018-07-04 Thread Hemant Agrawal
Signed-off-by: Hemant Agrawal --- v2: fix the release version doc/guides/rel_notes/release_18_08.rst | 7 +++ lib/librte_security/rte_security.c | 18 +- lib/librte_security/rte_security.h | 28 +--- lib/librte_security/rte_s

Re: [dpdk-dev] [PATCH v2 04/20] net/mlx5: support flow Ethernet item among with drop action

2018-07-04 Thread Nélio Laranjeiro
On Tue, Jul 03, 2018 at 03:27:18PM -0700, Yongseok Koh wrote: > On Wed, Jun 27, 2018 at 05:07:36PM +0200, Nelio Laranjeiro wrote: > > net/mlx5: support flow Ethernet item among with drop action > > Typo? "among" -> "along"? > > > Signed-off-by: Nelio Laranjeiro > > --- > > drivers/net/mlx5/mlx

Re: [dpdk-dev] [PATCH] crypto/snow3g: add dynamic logging

2018-07-04 Thread Pattan, Reshma
Hi Pablo, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Pablo de Lara > Sent: Tuesday, July 3, 2018 5:37 AM > To: dev@dpdk.org > Cc: De Lara Guarch, Pablo > Subject: [dpdk-dev] [PATCH] crypto/snow3g: add dynamic logging > diff --git a/drivers/crypto/snow3g/rt

Re: [dpdk-dev] [PATCH] test/virtual_pmd: Add DEV_RX_OFFLOAD_CRC_STRIP to virtual driver

2018-07-04 Thread Ferruh Yigit
On 7/4/2018 2:31 AM, dev-boun...@dpdk.org wrote: > Add DEV_RX_OFFLOAD_CRC_STRIP to virtual drivers since they don't > use CRC at all, when an application requires this offload virtual > PMDs should not return error. Agreed. Can you please check following patch [1] that has been applied to next-ne

[dpdk-dev] [PATCH v2 02/16] bus/dpaa: fix svr id fetch location

2018-07-04 Thread Hemant Agrawal
Otherwise the SVR may not be avilable for dpaa init. Fixes: 3b59b73dea08 ("bus/dpaa: update platform SoC value register routines") Cc: sta...@dpdk.org Signed-off-by: Hemant Agrawal --- drivers/bus/dpaa/dpaa_bus.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a

Re: [dpdk-dev] [PATCH] test/virtual_pmd: Add DEV_RX_OFFLOAD_CRC_STRIP to virtual driver

2018-07-04 Thread Ferruh Yigit
On 7/4/2018 10:34 AM, Ferruh Yigit wrote: > On 7/4/2018 2:31 AM, dev-boun...@dpdk.org wrote: >> Add DEV_RX_OFFLOAD_CRC_STRIP to virtual drivers since they don't >> use CRC at all, when an application requires this offload virtual >> PMDs should not return error. > > Agreed. > > Can you please che

[dpdk-dev] [PATCH v2 03/16] bus/dpaa: fix the buffer offset setting in FMAN

2018-07-04 Thread Hemant Agrawal
The buffer offset was incorrectly being set at 64, thus not honoring the packet headroom. Fixes: 6d6b4f49a155 (bus/dpaa: add FMAN hardware operations") Cc: sta...@dpdk.org Signed-off-by: Hemant Agrawal --- drivers/bus/dpaa/base/fman/fman_hw.c | 20 +++- 1 file changed, 11 insert

[dpdk-dev] [PATCH v2 01/16] bus/dpaa: fix phandle support for kernel 4.16

2018-07-04 Thread Hemant Agrawal
From: Alok Makhariya Fixes: 2183c6f69d7e ("bus/dpaa: add OF parser for device scanning") Cc: Shreyansh Jain Cc: sta...@dpdk.org Signed-off-by: Alok Makhariya --- drivers/bus/dpaa/base/fman/of.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/bus/dpaa/base/fman/of.c b/drivers/

[dpdk-dev] [PATCH v2 04/16] net/dpaa: fix the queue err handling and logs

2018-07-04 Thread Hemant Agrawal
Fixes: 5e7455931442 ("net/dpaa: support Rx queue configurations with eventdev") Cc: sta...@dpdk.org Signed-off-by: Hemant Agrawal --- drivers/net/dpaa/dpaa_ethdev.c | 34 ++ 1 file changed, 26 insertions(+), 8 deletions(-) diff --git a/drivers/net/dpaa/dpaa_ethde

[dpdk-dev] [PATCH v2 05/16] net/dpaa2: fix the prefetch Rx to honor nb pkts

2018-07-04 Thread Hemant Agrawal
This patch fix the prefetch rx routine to set the next prefetch request to the size of nb_pkts. This will assume that next request will ideally will be of same size. Fixes: 4bc5ab88dbd6 ("net/dpaa2: fix Tx only mode") Cc: sta...@dpdk.org Signed-off-by: Hemant Agrawal --- drivers/net/dpaa2/dpaa2

[dpdk-dev] [PATCH v2 06/16] bus/dpaa: optimize the fq callback routine

2018-07-04 Thread Hemant Agrawal
Avoid array of fq as packets are dq only from a single q. Signed-off-by: Sunil Kumar Kori Signed-off-by: Hemant Agrawal --- drivers/bus/dpaa/base/qbman/qman.c | 15 +++ drivers/net/dpaa/dpaa_rxtx.c | 2 +- 2 files changed, 8 insertions(+), 9 deletions(-) diff --git a/drivers

[dpdk-dev] [PATCH v2 07/16] bus/dpaa: implement new of API to get MAC address

2018-07-04 Thread Hemant Agrawal
From: Akhil Goyal Signed-off-by: Akhil Goyal --- drivers/bus/dpaa/base/fman/of.c | 39 +++ drivers/bus/dpaa/include/of.h | 2 ++ drivers/bus/dpaa/rte_bus_dpaa_version.map | 8 +++ 3 files changed, 49 insertions(+) diff --git a/drivers/bus

[dpdk-dev] [PATCH v2 09/16] net/dpaa: support default queue mode

2018-07-04 Thread Hemant Agrawal
In case DPAA FMAN configuration tool (FMC) is not available. System can still work with default queue. (1 queue per port). Signed-off-by: Hemant Agrawal --- drivers/net/dpaa/dpaa_ethdev.c | 37 ++--- 1 file changed, 26 insertions(+), 11 deletions(-) diff --git a/

[dpdk-dev] [PATCH v2 10/16] net/dpaa: remove experimental tag from PMD APIs

2018-07-04 Thread Hemant Agrawal
Signed-off-by: Hemant Agrawal --- drivers/net/dpaa/dpaa_ethdev.c| 6 +++--- drivers/net/dpaa/dpaa_ethdev.h| 8 +--- drivers/net/dpaa/rte_pmd_dpaa.h | 5 + drivers/net/dpaa/rte_pmd_dpaa_version.map | 4 ++-- 4 files changed, 11 insertions(+), 12 deletions(

[dpdk-dev] [PATCH v2 08/16] bus/dpaa: make vdqcr configurable

2018-07-04 Thread Hemant Agrawal
From: Nipun Gupta This patch add support for configurable vdqcr exact flag. This boost the performance, however this can give side effects for some extra packet fetch. Which has been taken care in the patch as well. Signed-off-by: Nipun Gupta --- drivers/bus/dpaa/base/qbman/qman.c | 4 ++--

[dpdk-dev] [PATCH v2 12/16] bus/fslmc: cleanup unnecessary global variables

2018-07-04 Thread Hemant Agrawal
Changes originally in the patch "drivers: cleanup unnecessary global variables" by Pavan. Signed-off-by: Pavan Nikhilesh Signed-off-by: Hemant Agrawal --- drivers/bus/fslmc/qbman/qbman_portal.c | 3 +-- drivers/bus/fslmc/qbman/qbman_portal.h | 1 - 2 files changed, 1 insertion(+), 3 deletions(-

[dpdk-dev] [PATCH v2 11/16] bus/dpaa: cleanup unnecessary global variables

2018-07-04 Thread Hemant Agrawal
Changes originally in the patch "drivers: cleanup unnecessary global variables" by Pavan. Signed-off-by: Pavan Nikhilesh Signed-off-by: Hemant Agrawal --- drivers/bus/dpaa/base/fman/netcfg_layer.c | 5 - drivers/bus/dpaa/base/qbman/bman_driver.c | 4 ++-- drivers/bus/dpaa/base/qbman/qman.c

[dpdk-dev] [PATCH v2 13/16] drivers: support function name in logs trace

2018-07-04 Thread Hemant Agrawal
Signed-off-by: Hemant Agrawal --- drivers/bus/fslmc/fslmc_logs.h | 2 +- drivers/crypto/dpaa2_sec/dpaa2_sec_logs.h | 2 +- drivers/crypto/dpaa_sec/dpaa_sec_log.h | 2 +- drivers/event/dpaa2/dpaa2_eventdev_logs.h | 2 +- drivers/net/dpaa2/dpaa2_pmd_logs.h | 2 +- drivers/

[dpdk-dev] [PATCH v2 14/16] net/dpaa: move the push queue set to global init

2018-07-04 Thread Hemant Agrawal
Signed-off-by: Hemant Agrawal --- drivers/net/dpaa/dpaa_ethdev.c | 24 ++-- 1 file changed, 14 insertions(+), 10 deletions(-) diff --git a/drivers/net/dpaa/dpaa_ethdev.c b/drivers/net/dpaa/dpaa_ethdev.c index 00611f8..5c0aafb 100644 --- a/drivers/net/dpaa/dpaa_ethdev.c +++ b/

[dpdk-dev] [PATCH v2 15/16] bus/dpaa: add support for SG config

2018-07-04 Thread Hemant Agrawal
Signed-off-by: Hemant Agrawal --- drivers/bus/dpaa/base/fman/fman_hw.c | 42 +++ drivers/bus/dpaa/include/fsl_fman.h | 6 + drivers/bus/dpaa/rte_bus_dpaa_version.map | 2 ++ 3 files changed, 50 insertions(+) diff --git a/drivers/bus/dpaa/base/fman/fma

[dpdk-dev] [PATCH v2 16/16] net/dpaa: implement scatter offload support

2018-07-04 Thread Hemant Agrawal
Signed-off-by: Hemant Agrawal --- drivers/net/dpaa/dpaa_ethdev.c | 75 +- drivers/net/dpaa/dpaa_ethdev.h | 3 +- drivers/net/dpaa/dpaa_rxtx.c | 4 +-- drivers/net/dpaa/dpaa_rxtx.h | 2 -- 4 files changed, 70 insertions(+), 14 deletions(-) diff --git

[dpdk-dev] [PATCH] test/crypto: fix the devid testcases

2018-07-04 Thread Hemant Agrawal
devid is valid, while ts_params->valid_devs[devid] may result a different value in case multiple devices are present and any of the device is being used. Fixes: 202d375c60bc ("app/test: add cryptodev unit and performance tests") Cc: sta...@dpdk.org Cc: declan.dohe...@intel.com Signed-off-by: Hema

[dpdk-dev] [PATCH] vhost: initializing iotlb memory only when IOMMU feature is enabled DPDK 17.11 introduced the IOMMU feature which caused additional DPDK memory requirement per vhostuser device as p

2018-07-04 Thread Nitin Katiyar
This patch is to do iotlb_init only if IOMMU feature is enabled on device. Signed-off-by: Nitin Katiyar --- lib/librte_vhost/iotlb.c | 7 +++ lib/librte_vhost/vhost_user.c | 7 +++ 2 files changed, 14 insertions(+) diff --git a/lib/librte_vhost/iotlb.c b/lib/librte_vhost/iotlb.c in

Re: [dpdk-dev] [PATCH] net/virtio: fix build with gcc optimization on

2018-07-04 Thread Ferruh Yigit
On 7/4/2018 11:56 AM, Marvin Liu wrote: > build error on gcc version 8.1.1 20180502 (Red Hat 8.1.1-1), > with optimization level >= O2 > > .../drivers/net/virtio/virtio_rxtx.c: >In function ‘virtio_xmit_cleanup_inorder’: > .../drivers/net/virtio/virtio_rxtx.c:195:24: >error: ‘desc_idx’ may

Re: [dpdk-dev] [PATCH] crypto/snow3g: add dynamic logging

2018-07-04 Thread Pattan, Reshma
Hi Pablo, Also need to remove CONFIG_RTE_LIBRTE_PMD_SNOW3G_DEBUG flag. Thanks, Reshma > -Original Message- > From: Pattan, Reshma > Sent: Wednesday, July 4, 2018 10:32 AM > To: 'Pablo de Lara' ; dev@dpdk.org > Cc: De Lara Guarch, Pablo > Subject: RE: [dpdk-dev] [PATCH] crypto/snow3g: a

[dpdk-dev] [PATCH] vhost: initializing iotlb memory only when IOMMU feature is enabled

2018-07-04 Thread Nitin Katiyar
DPDK 17.11 introduced the IOMMU feature which caused additional DPDK memory requirement per vhostuser device as part of iotlb_init(). Today this is done unconditionally (from DPDK 17.11 onwards) i.e. irrespective of IOMMU feature being enabled on the vhostuser device, iotlb is initialized. This

[dpdk-dev] [PATCH v2] mk: change TLS model for DPAA machine

2018-07-04 Thread Hemant Agrawal
From: Sachin Saxena Random corruptions observed on platfoms with using the dpdk library in shared mode with VPP software (plugin). using traditional TLS scheme resolved the issue. Tested with VPP with DPDK as a plugin. Signed-off-by: Sachin Saxena --- v2: remove the armv8 machine changes mk

Re: [dpdk-dev] [PATCH] crypto/snow3g: add dynamic logging

2018-07-04 Thread De Lara Guarch, Pablo
Hi Reshma, > -Original Message- > From: Pattan, Reshma > Sent: Wednesday, July 4, 2018 10:54 AM > To: De Lara Guarch, Pablo ; dev@dpdk.org > Cc: De Lara Guarch, Pablo > Subject: RE: [dpdk-dev] [PATCH] crypto/snow3g: add dynamic logging > > Hi Pablo, > > Also need to remove CONFIG_RTE_L

Re: [dpdk-dev] [PATCH] crypto/snow3g: add dynamic logging

2018-07-04 Thread Pattan, Reshma
> -Original Message- > From: De Lara Guarch, Pablo > Sent: Wednesday, July 4, 2018 11:02 AM > To: Pattan, Reshma ; dev@dpdk.org > Subject: RE: [dpdk-dev] [PATCH] crypto/snow3g: add dynamic logging > > > > > Also need to remove CONFIG_RTE_LIBRTE_PMD_SNOW3G_DEBUG flag. > > I haven't rem

[dpdk-dev] [PATCH] app/test-pmd: Fix buffer leak in tm cmdline

2018-07-04 Thread Nithin Dabilpuram
Free the buffer allocated for shared_shaper_id array in case of configuration without shared shapers. Signed-off-by: Nithin Dabilpuram --- app/test-pmd/cmdline_tm.c | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/app/test-pmd/cmdline_tm.c b/app/test-pmd/cmdl

[dpdk-dev] [PATCH v2] crypto/qat: add support for 8 byte 3DES

2018-07-04 Thread Kovacevic, Marko
Added extra case to support 8 byte key size for 3DES CBC. Also changed capabilities to reflect the change. Signed-off-by: Marko Kovacevic --- V2: Fixed implementation (Fiona) --- drivers/crypto/qat/qat_adf/qat_algs.h| 1 + drivers/crypto/qat/qat_adf/qat_algs_build_desc.c | 15 +

Re: [dpdk-dev] [PATCH 01/20] eventdev: add files for eventmode helper

2018-07-04 Thread Sunil Kumar Kori
Hello Anoob, Comments inline. Regards Sunil Kumar > -Original Message- > From: Joseph, Anoob [mailto:anoob.jos...@caviumnetworks.com] > Sent: Tuesday, July 3, 2018 6:44 PM > To: Sunil Kumar Kori ; Bruce Richardson > ; Jerin Jacob > ; Pablo de Lara > > Cc: Hemant Agrawal ; Narayana Prasa

Re: [dpdk-dev] [PATCH v8 04/19] ethdev: introduce device lock

2018-07-04 Thread Zhang, Qi Z
> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Wednesday, July 4, 2018 3:27 PM > To: Zhang, Qi Z > Cc: dev@dpdk.org; Burakov, Anatoly ; Ananyev, > Konstantin ; Richardson, Bruce > ; Yigit, Ferruh ; Shelton, > Benjamin H ; Vangati, Narender > > Subject

Re: [dpdk-dev] [PATCH v8 03/19] ethdev: enable hotplug on multi-process

2018-07-04 Thread Zhang, Qi Z
> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Wednesday, July 4, 2018 3:34 PM > To: Zhang, Qi Z > Cc: dev@dpdk.org; Burakov, Anatoly ; Ananyev, > Konstantin ; Richardson, Bruce > ; Yigit, Ferruh ; Shelton, > Benjamin H ; Vangati, Narender > ; gaetan.r

Re: [dpdk-dev] [PATCH v2 01/16] bus/dpaa: fix phandle support for kernel 4.16

2018-07-04 Thread Shreyansh Jain
> -Original Message- > From: Hemant Agrawal > Sent: Wednesday, July 4, 2018 3:14 PM > To: dev@dpdk.org > Cc: Alok Makhariya ; Shreyansh Jain > ; sta...@dpdk.org > Subject: [PATCH v2 01/16] bus/dpaa: fix phandle support for kernel 4.16 > > From: Alok Makhariya > > Fixes: 2183c6f69d7e ("bu

Re: [dpdk-dev] [PATCH v2 3/5] ethdev: convert remaining apps to new offload API

2018-07-04 Thread Andrew Rybchenko
On 07/03/2018 12:27 AM, Thomas Monjalon wrote: Some test applications and examples were not converted to the new offload API introduced in 17.11. For reference, see "Hardware Offload" in doc/guides/prog_guide/poll_mode_drv.rst Signed-off-by: Thomas Monjalon --- <...> diff --git a/d

Re: [dpdk-dev] [PATCH v3 10/16] doc: remove unneeded deprecation notice

2018-07-04 Thread Akhil Goyal
Acked-by: Akhil Goyal

Re: [dpdk-dev] [PATCH v3 12/16] cryptodev: remove old get session size functions

2018-07-04 Thread Akhil Goyal
On 6/28/2018 6:23 AM, Pablo de Lara wrote: Removed rte_cryptodev_get_header_session_size and rte_cryptodev_get_private_session_size functions, as they have been substituted with functions specific for symmetric operations, with _sym_ word after "rte_cryptodev_". Signed-off-by: Pablo de Lara

Re: [dpdk-dev] [PATCH v2 5/5] ethdev: remove old offload API

2018-07-04 Thread Andrew Rybchenko
On 07/03/2018 12:27 AM, Thomas Monjalon wrote: From: Ferruh Yigit In DPDK 17.11, the ethdev offloads API has changed: commit cba7f53b717d ("ethdev: introduce Tx queue offloads API") commit ce17eddefc20 ("ethdev: introduce Rx queue offloads API") The new API is documented in the

Re: [dpdk-dev] [PATCH v3 14/16] cryptodev: remove attach/detach session API

2018-07-04 Thread Akhil Goyal
On 6/28/2018 6:23 AM, Pablo de Lara wrote: As announced in the previous release, The API to attach/dettach a session to a queue pair is removed, as it was only used in DPAA, and it is not actually needed. Signed-off-by: Pablo de Lara --- Acked-by: Akhil Goyal

Re: [dpdk-dev] [PATCH v3 15/16] cryptodev: rename PMD symmetric session API

2018-07-04 Thread Akhil Goyal
On 6/28/2018 6:23 AM, Pablo de Lara wrote: The PMD specific API to configure, clear and obtain session private size is renamed, including the word _sym_ to clarify that it is API for symmetric sessions, so there will not be any conflicts for asymmetric and other type of sessions in the future.

Re: [dpdk-dev] [PATCH v2] security: remove experimental tag from security APIs

2018-07-04 Thread Radu Nicolau
On 7/4/2018 10:05 AM, Hemant Agrawal wrote: Signed-off-by: Hemant Agrawal --- v2: fix the release version Acked-by: Radu Nicolau

Re: [dpdk-dev] [PATCH v2 07/20] net/mlx5: add flow VLAN item

2018-07-04 Thread Nélio Laranjeiro
On Tue, Jul 03, 2018 at 04:56:21PM -0700, Yongseok Koh wrote: > On Wed, Jun 27, 2018 at 05:07:39PM +0200, Nelio Laranjeiro wrote: > > Signed-off-by: Nelio Laranjeiro > > --- > > drivers/net/mlx5/mlx5_flow.c | 123 +++ > > 1 file changed, 123 insertions(+) > > > >

Re: [dpdk-dev] [PATCH v3 05/16] examples/l2fwd-crypto: limit number of sessions

2018-07-04 Thread Akhil Goyal
On 6/28/2018 6:22 AM, Pablo de Lara wrote: Calculate the number of sessions required for the application, knowing that there is only one session required per device. Signed-off-by: Pablo de Lara --- examples/l2fwd-crypto/main.c | 19 +-- 1 file changed, 17 insertions(+), 2

Re: [dpdk-dev] [PATCH v3 03/16] app/crypto-perf: limit number of sessions

2018-07-04 Thread Akhil Goyal
On 6/28/2018 6:22 AM, Pablo de Lara wrote: Instead of creating a fixed number of sessions, calculate the necessary number based on number of devices and queue pairs used. Signed-off-by: Pablo de Lara --- Acked-by: Akhil Goyal

Re: [dpdk-dev] [PATCH v3 03/16] app/crypto-perf: limit number of sessions

2018-07-04 Thread Akhil Goyal
On 6/28/2018 6:22 AM, Pablo de Lara wrote: Instead of creating a fixed number of sessions, calculate the necessary number based on number of devices and queue pairs used. Signed-off-by: Pablo de Lara --- app/test-crypto-perf/main.c | 31 --- 1 file changed, 28

Re: [dpdk-dev] [PATCH v9 20/27] ethdev: register ether layer as a class

2018-07-04 Thread Andrew Rybchenko
On 07/04/2018 01:15 AM, Gaetan Rivet wrote: Signed-off-by: Gaetan Rivet --- lib/librte_ethdev/Makefile| 3 +- lib/librte_ethdev/rte_class_eth.c | 79 +++ 2 files changed, 81 insertions(+), 1 deletion(-) create mode 100644 lib/librte_ethdev/rte_c

Re: [dpdk-dev] [PATCH v2] security: remove experimental tag from security APIs

2018-07-04 Thread Boris Pismenny
On 7/4/2018 3:03 PM, Radu Nicolau wrote: On 7/4/2018 10:05 AM, Hemant Agrawal wrote: Signed-off-by: Hemant Agrawal --- v2: fix the release version Acked-by: Radu Nicolau Acked-by: Boris Pismenny

Re: [dpdk-dev] [PATCH v3 04/16] test/crypto: limit number of sessions

2018-07-04 Thread Akhil Goyal
On 6/28/2018 6:22 AM, Pablo de Lara wrote: Instead of using the maximum number of sessions allowed by the PMDs (which will change to unlimited most of the PMDs), limit the number to a small sufficient amount. Signed-off-by: Pablo de Lara --- Acked-by: Akhil Goyal

Re: [dpdk-dev] [PATCH v2 3/5] ethdev: convert remaining apps to new offload API

2018-07-04 Thread Thomas Monjalon
04/07/2018 13:16, Andrew Rybchenko: > On 07/03/2018 12:27 AM, Thomas Monjalon wrote: > > --- a/doc/guides/sample_app_ug/link_status_intr.rst > > +++ b/doc/guides/sample_app_ug/link_status_intr.rst > > @@ -137,10 +137,7 @@ The global configuration is stored in a static > > structure: > > stat

Re: [dpdk-dev] [PATCH v3 16/16] cryptodev: check if symmetric sessions are supported

2018-07-04 Thread Akhil Goyal
On 6/28/2018 6:23 AM, Pablo de Lara wrote: Since asymmetric functionality will be implemented soon, not all PMDs must support symmetric sessions. Therefore, a check is added if a device does not implement the symmetric functions, meaning that the device does not support symmetric operations.

Re: [dpdk-dev] [PATCH v3 06/16] examples/ipsec-secgw: check for max supported sessions

2018-07-04 Thread Akhil Goyal
On 6/28/2018 6:22 AM, Pablo de Lara wrote: Signed-off-by: Pablo de Lara --- examples/ipsec-secgw/ipsec-secgw.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/examples/ipsec-secgw/ipsec-secgw.c b/examples/ipsec-secgw/ipsec-secgw.c index a5da8b280..2582dcb6e 100644 --- a/examples

Re: [dpdk-dev] [PATCH v3 08/16] cryptodev: define value for unlimited sessions

2018-07-04 Thread Akhil Goyal
On 6/28/2018 6:22 AM, Pablo de Lara wrote: Currently, the info structure contains the maximum number of sessions that a device can manage. This field was useful when the session mempool was created inside each device, but now it is created at the application level. Most PMDs do not have a limit

Re: [dpdk-dev] [PATCH v3 09/16] cryptodev: remove max number of sessions parameter

2018-07-04 Thread Akhil Goyal
Hi Pablo, On 6/28/2018 6:22 AM, Pablo de Lara wrote: Most crypto PMDs do not have a limitation of the number of the sessions that can be handled internally. The value that was set before was not actually used at all, since the sessions are created at the application level. Therefore, this value

Re: [dpdk-dev] [PATCH v2 3/5] ethdev: convert remaining apps to new offload API

2018-07-04 Thread Andrew Rybchenko
On 07/04/2018 03:26 PM, Thomas Monjalon wrote: 04/07/2018 13:16, Andrew Rybchenko: On 07/03/2018 12:27 AM, Thomas Monjalon wrote: --- a/doc/guides/sample_app_ug/link_status_intr.rst +++ b/doc/guides/sample_app_ug/link_status_intr.rst @@ -137,10 +137,7 @@ The global configuration is stored in a

[dpdk-dev] [PATCH v3 2/6] ethdev: add function for checking IOVAs by a device

2018-07-04 Thread Alejandro Lucero
A PMD should invoke this function for checking memsegs iovas are within the supported range by the device. Signed-off-by: Alejandro Lucero --- lib/librte_ether/rte_ethdev.h | 13 + lib/librte_ether/rte_ethdev_version.map | 1 + 2 files changed, 14 insertions(+) diff --git

[dpdk-dev] [PATCH v3 1/6] mem: add function for checking memsegs IOVAs addresses

2018-07-04 Thread Alejandro Lucero
A device can suffer addressing limitations. This functions checks memsegs have iovas within the supported range based on dma mask. PMD should use this during initialization if supported devices suffer addressing limitations, returning an error if this function returns memsegs out of range. Anothe

[dpdk-dev] [PATCH v3 0/6] use IOVAs check based on DMA mask

2018-07-04 Thread Alejandro Lucero
This patchset adds, mainly, a check for ensuring IOVAs are within a restricted range due to addressing limitations with some devices. There are two known cases: NFP and IOMMU VT-d emulation. With this check IOVAs out of range are detected and PMDs can abort initialization. For the VT-d case, IOVA

[dpdk-dev] [PATCH v3 4/6] mem: use address hint for mapping hugepages

2018-07-04 Thread Alejandro Lucero
Linux kernel uses a really high address as starting address for serving mmaps calls. If there exists addressing limitations and IOVA mode is VA, this starting address is likely too high for those devices. However, it is possible to use a lower address in the process virtual address space as with 64

[dpdk-dev] [PATCH v3 3/6] bus/pci: use IOVAs check when setting IOVA mode

2018-07-04 Thread Alejandro Lucero
Although VT-d emulation currently only supports 39 bits, it could be iovas being within that supported range. This patch allows IOVA mode in such a case. Indeed, memory initialization code can be modified for using lower virtual addresses than those used by the kernel for 64 bits processes by defa

[dpdk-dev] [PATCH v3 5/6] net/nfp: check hugepages IOVAs based on DMA mask

2018-07-04 Thread Alejandro Lucero
NFP devices can not handle DMA addresses requiring more than 40 bits. This patch uses rte_dev_check_dma_mask with 40 bits and avoids device initialization if memory out of NFP range. Signed-off-by: Alejandro Lucero --- drivers/net/nfp/nfp_net.c | 8 1 file changed, 8 insertions(+) diff

[dpdk-dev] [PATCH v3 6/6] net/nfp: support IOVA VA mode

2018-07-04 Thread Alejandro Lucero
NFP can handle IOVA as VA. It requires to check those IOVAs being in the supported range what is done during initialization. Signed-off-by: Alejandro Lucero --- drivers/net/nfp/nfp_net.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/nfp/nfp_net.c b/drivers

Re: [dpdk-dev] [PATCH v3 13/16] cryptodev: replace mbuf scatter gather flag

2018-07-04 Thread Akhil Goyal
Hi Pablo, On 6/28/2018 6:23 AM, Pablo de Lara wrote: The current mbuf scatter gatter feature flag is too ambiguous, as it is not clear if input and/or output buffers can be scatter gather mbufs or not, plus if in-place and/or out-of-place is supported. Therefore, five new flags will replace th

Re: [dpdk-dev] [PATCH] security: change to SPDX license tags

2018-07-04 Thread Akhil Goyal
Acked-by: Akhil Goyal

Re: [dpdk-dev] [PATCH] app/test-pmd: Fix buffer leak in tm cmdline

2018-07-04 Thread Singh, Jasvinder
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Nithin Dabilpuram > Sent: Wednesday, July 4, 2018 11:18 AM > To: Lu, Wenzhuo ; Wu, Jingjing > ; Iremonger, Bernard > > Cc: dev@dpdk.org; kka...@caviumnetworks.com; Nithin Dabilpuram > > Subject: [dpdk-dev] [PAT

Re: [dpdk-dev] [PATCH v2] net/mlx5: add support for 32bit systems

2018-07-04 Thread Ferruh Yigit
On 7/2/2018 12:11 PM, Moti Haimovsky wrote: > This patch adds support for building and running mlx5 PMD on > 32bit systems such as i686. > > The main issue to tackle was handling the 32bit access to the UAR > as quoted from the mlx5 PRM: > QP and CQ DoorBells require 64-bit writes. For best perfor

[dpdk-dev] [PATCH v1 0/3] add head/tailroom requirement for crypto PMDs

2018-07-04 Thread Anoob Joseph
This series adds the ability, for crypto PMDs, to communicate the minimum head/tailroom requirement it may have, using the existing cryptodev_info framework. The availability and use of head/tailroom is an optimisation if the hardware supports its use for crypto-op info. Devices that do not suppor

[dpdk-dev] [PATCH v1 2/3] app/crypto-perf: honour cryptodev's min headroom/tailroom

2018-07-04 Thread Anoob Joseph
Crypto dev would specify its headroom and tailroom requirement and the application is expected to honour this while creating buffers. Signed-off-by: Anoob Joseph --- v1: * Accomodated the name change of new fields app/test-crypto-perf/cperf_options.h | 2 ++ app/test-crypto-perf/cperf_test

[dpdk-dev] [PATCH v1 1/3] cryptodev: add min headroom and tailroom requirement

2018-07-04 Thread Anoob Joseph
Enabling crypto devs to specify the minimum headroom and tailroom it expects in the mbuf. For net PMDs, standard headroom has to be honoured by applications, which is not strictly followed for crypto devs. This prevents crypto devs from using free space in mbuf (available as head/tailroom) for inte

[dpdk-dev] [PATCH v1 3/3] test/crypto: skip validation of head/tailroom used by PMD

2018-07-04 Thread Anoob Joseph
Crypto PMDs would specify the head/tailroom it would use while processing the crypto requests. This need to be considered while verifying buffers processed by crypto PMDs. Signed-off-by: Anoob Joseph --- v1: * Added patch test/test/test_cryptodev_blockcipher.c | 60 +

[dpdk-dev] [PATCH v4] net/mlx4: support hardware TSO

2018-07-04 Thread Moti Haimovsky
Implement support for hardware TSO. Signed-off-by: Moti Haimovsky --- v4: * Bug fixes in filling TSO data segments. * Modifications according to review inputs from Adrien Mazarguil and Matan Azrad. in reply to 1530190137-17848-1-git-send-email-mo...@mellanox.com v3: * Fixed compilation errors

Re: [dpdk-dev] [PATCH v7 0/2] app/testpmd implement VXLAN/NVGRE Encap/Decap

2018-07-04 Thread Ferruh Yigit
On 7/2/2018 11:40 AM, Mohammad Abdul Awal wrote: > > On 27/06/2018 12:45, Nelio Laranjeiro wrote: >> This series adds an easy and maintainable configuration version support for >> those two actions for 18.08 by using global variables in testpmd to store the >> necessary information for the tunnel

Re: [dpdk-dev] [PATCH v3] docs: add default that all fixes should be backported

2018-07-04 Thread Thomas Monjalon
30/06/2018 01:10, Kevin Traynor: > Set the starting point that all commits on master branch > with Fixes tag should be backported to relevant stable/LTS > branches, and explain that the submitter may indicate it is > not suitable for backport. > > Of course there will be exceptions that will crop

Re: [dpdk-dev] [PATCH v3 13/16] cryptodev: replace mbuf scatter gather flag

2018-07-04 Thread De Lara Guarch, Pablo
Hi Akhil, > -Original Message- > From: Akhil Goyal [mailto:akhil.go...@nxp.com] > Sent: Wednesday, July 4, 2018 1:57 PM > To: De Lara Guarch, Pablo ; Doherty, Declan > ; shally.ve...@caviumnetworks.com; > ravi1.ku...@amd.com; jerin.ja...@caviumnetworks.com; Zhang, Roy Fan > ; Trahe, Fiona

Re: [dpdk-dev] [PATCH v6 14/15] vhost: add notification for packed ring

2018-07-04 Thread Maxime Coquelin
On 07/03/2018 08:06 AM, Jason Wang wrote: On 2018年07月02日 16:16, Maxime Coquelin wrote: Signed-off-by: Maxime Coquelin ---   lib/librte_vhost/vhost.c | 73   lib/librte_vhost/vhost.h | 71 ++   lib

Re: [dpdk-dev] [PATCH v6 01/15] vhost: add virtio packed virtqueue defines

2018-07-04 Thread Maxime Coquelin
On 07/04/2018 07:37 AM, Tiwei Bie wrote: On Mon, Jul 02, 2018 at 10:16:15AM +0200, Maxime Coquelin wrote: From: Jens Freimann Signed-off-by: Jens Freimann --- lib/librte_vhost/vhost.h | 3 +++ lib/librte_vhost/virtio-packed.h | 22 ++ 2 files changed, 25 in

Re: [dpdk-dev] [PATCH v6 02/15] vhost: add helpers for packed virtqueues

2018-07-04 Thread Maxime Coquelin
On 07/04/2018 07:39 AM, Tiwei Bie wrote: On Mon, Jul 02, 2018 at 10:16:16AM +0200, Maxime Coquelin wrote: From: Jens Freimann Add some helper functions to check descriptor flags and check if a vring is of type packed. Signed-off-by: Jens Freimann Signed-off-by: Maxime Coquelin --- lib/

Re: [dpdk-dev] [PATCH v6 13/15] vhost: add Tx support for packed ring

2018-07-04 Thread Maxime Coquelin
On 07/04/2018 07:45 AM, Tiwei Bie wrote: On Mon, Jul 02, 2018 at 10:16:27AM +0200, Maxime Coquelin wrote: Signed-off-by: Maxime Coquelin --- lib/librte_vhost/vhost.h | 1 + lib/librte_vhost/virtio_net.c | 121 +- 2 files changed, 121 inserti

[dpdk-dev] [PATCH] doc: update CRC feature with new offload flag

2018-07-04 Thread Ferruh Yigit
Fixes: 3d12dceed2df ("ethdev: add new offload flag to keep CRC") Signed-off-by: Ferruh Yigit --- doc/guides/nics/features.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/guides/nics/features.rst b/doc/guides/nics/features.rst index ee89d6bfa..6fe6aa559 100644 --- a/do

Re: [dpdk-dev] [PATCH v6 11/15] vhost: add vector filling support for packed ring

2018-07-04 Thread Maxime Coquelin
On 07/04/2018 07:53 AM, Tiwei Bie wrote: On Mon, Jul 02, 2018 at 10:16:25AM +0200, Maxime Coquelin wrote: [...] +static __rte_always_inline int +fill_vec_buf_packed_indirect(struct virtio_net *dev, + struct vhost_virtqueue *vq, + struct vring_desc_p

Re: [dpdk-dev] [PATCH v6 10/15] vhost: create descriptor mapping function

2018-07-04 Thread Maxime Coquelin
On 07/04/2018 07:56 AM, Tiwei Bie wrote: On Mon, Jul 02, 2018 at 10:16:24AM +0200, Maxime Coquelin wrote: Signed-off-by: Maxime Coquelin --- lib/librte_vhost/virtio_net.c | 61 ++- 1 file changed, 37 insertions(+), 24 deletions(-) diff --git a/lib/

[dpdk-dev] [PATCH v4 02/16] cryptodev: remove max number of sessions per queue

2018-07-04 Thread Pablo de Lara
The cryptodev info structure currently contains the maximum number of sessions that can be used in a queue pair. This is only set in DPAA_SEC PMD, and since it is calculated based on the maximum number of sessions (which is not used anymore), this field can be removed. Signed-off-by: Pablo de Lara

[dpdk-dev] [PATCH v4 04/16] test/crypto: limit number of sessions

2018-07-04 Thread Pablo de Lara
Instead of using the maximum number of sessions allowed by the PMDs (which will change to unlimited most of the PMDs), limit the number to a small sufficient amount. Signed-off-by: Pablo de Lara Acked-by: Akhil Goyal --- test/test/test_cryptodev.c | 27 +-- 1 file change

[dpdk-dev] [PATCH v4 03/16] app/crypto-perf: limit number of sessions

2018-07-04 Thread Pablo de Lara
Instead of creating a fixed number of sessions, calculate the necessary number based on number of devices and queue pairs used. Signed-off-by: Pablo de Lara Acked-by: Akhil Goyal --- app/test-crypto-perf/main.c | 34 +++--- 1 file changed, 31 insertions(+), 3 deletio

[dpdk-dev] [PATCH v4 05/16] examples/l2fwd-crypto: limit number of sessions

2018-07-04 Thread Pablo de Lara
Calculate the number of sessions required for the application, knowing that there is only one session required per device. Signed-off-by: Pablo de Lara Acked-by: Akhil Goyal --- examples/l2fwd-crypto/main.c | 22 -- 1 file changed, 20 insertions(+), 2 deletions(-) diff --gi

[dpdk-dev] [PATCH v4 01/16] cryptodev: replace bus specific struct with generic dev

2018-07-04 Thread Pablo de Lara
Structure rte_cryptodev_info has currently PCI device information ("struct rte_pci_device") in it. This information is not generic to all devices, so this gets replaced with the generic "rte_device" structure, compatible with all crypto devices. Signed-off-by: Pablo de Lara Acked-by: Akhil Goyal

[dpdk-dev] [PATCH v4 00/16] Cryptodev API changes

2018-07-04 Thread Pablo de Lara
API changes in the cryptodev library, announced in the previous release, 18.05. Changes in v4: - Fixed MVSAM max number of sessions (Tomasz Duszynksi) - Changed OUT_OF_PLACE to OOP in feature flags (Akhil Goyal) - Added missing feature flags in aesni_gcm and openssl PMDs (Akhil Goyal) - Removed

[dpdk-dev] [PATCH v4 06/16] examples/ipsec-secgw: check for max supported sessions

2018-07-04 Thread Pablo de Lara
Signed-off-by: Pablo de Lara Acked-by: Akhil Goyal --- examples/ipsec-secgw/ipsec-secgw.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/examples/ipsec-secgw/ipsec-secgw.c b/examples/ipsec-secgw/ipsec-secgw.c index a5da8b280..2582dcb6e 100644 --- a/examples/ipsec-secgw/ipsec-secgw.c

[dpdk-dev] [PATCH v4 07/16] crypto/mvsam: parse max number of sessions

2018-07-04 Thread Pablo de Lara
The maximum number of sessions device argument will be removed, as most PMDs do not have a limitation on this number. Therefore, the MVSAM PMD needs to parse this value internally. Signed-off-by: Pablo de Lara --- drivers/crypto/mvsam/rte_mrvl_pmd.c | 132 1

  1   2   >