Re: [dpdk-dev] [PATCH v2 1/2] net/mlx4: fix inadequate default in RSS converter

2018-05-22 Thread Shahaf Shuler
Monday, May 21, 2018 6:50 PM, Adrien Mazarguil: > Subject: [PATCH v2 1/2] net/mlx4: fix inadequate default in RSS converter > > Below commit documents 0 as a value standing for a default set of RSS hash > types, however the mlx4 PMD doesn't interpret it correctly and still uses its > own internal

Re: [dpdk-dev] [PATCH v2 2/2] net/mlx5: remove redundant checks

2018-05-22 Thread Shahaf Shuler
Hi Koh, Please see question below Tuesday, May 22, 2018 9:57 AM, Yongseok Koh: > Subject: [PATCH v2 2/2] net/mlx5: remove redundant checks > > Signed-off-by: Yongseok Koh > Acked-by: Xueming Li > --- > > v2: > * add missing 'Acked-by' tag. > > drivers/net/mlx5/mlx5_rxtx.c | 6 ++ drive

Re: [dpdk-dev] [PATCH v2 2/2] net/mlx5: remove redundant checks

2018-05-22 Thread Yongseok Koh
> On May 22, 2018, at 12:43 AM, Shahaf Shuler wrote: > > Hi Koh, > > Please see question below > > Tuesday, May 22, 2018 9:57 AM, Yongseok Koh: >> Subject: [PATCH v2 2/2] net/mlx5: remove redundant checks >> >> Signed-off-by: Yongseok Koh >> Acked-by: Xueming Li >> --- >> >> v2: >> * add mi

Re: [dpdk-dev] [PATCH v2 1/2] net/failsafe: fix removed sub-device cleanup

2018-05-22 Thread Gaëtan Rivet
Hello Matan, On Mon, May 21, 2018 at 07:48:03PM +, Matan Azrad wrote: > The fail-safe PMD registers to RMV event for each removable sub-device > port in order to cleanup the sub-device resources and switch the Tx > sub-device directly when it is plugged-out. > > During removal time, the fail-

[dpdk-dev] [PATCH v3 1/2] net/mlx5: fix setting offsets for SW parser

2018-05-22 Thread Yongseok Koh
Since ConnectX-5, SW parser just complements HW parser. SW parser starts to engage only if HW parser can't reach a header. For the older devices, HW parser will not kick in if any of SWP offsets is set. Therefore, all of the L3 offsets should be set regardless of HW offload. As IPv6 doesn't have he

Re: [dpdk-dev] [PATCH 1/2] pci: make rte_pci_remove_device static

2018-05-22 Thread Gaëtan Rivet
Hello Stephen, On Mon, May 21, 2018 at 09:41:49AM -0700, Stephen Hemminger wrote: > Only used in one file, and therefore can be made static. > > Signed-off-by: Stephen Hemminger Acked-by: Gaetan Rivet > --- > drivers/bus/pci/pci_common.c | 5 - > drivers/bus/pci/private.h| 10 --

[dpdk-dev] [PATCH v3 2/2] net/mlx5: remove redundant checks

2018-05-22 Thread Yongseok Koh
Signed-off-by: Yongseok Koh Acked-by: Xueming Li --- v3: * restore checking PKT_TX_TCP_SEG drivers/net/mlx5/mlx5_rxtx.c | 6 ++ drivers/net/mlx5/mlx5_rxtx.h | 13 +++-- 2 files changed, 9 insertions(+), 10 deletions(-) diff --git a/drivers/net/mlx5/mlx5_rxtx.c b/drivers/net/mlx5/

Re: [dpdk-dev] [PATCH 2/2] pci: remove unused function prototype

2018-05-22 Thread Gaëtan Rivet
On Mon, May 21, 2018 at 09:41:50AM -0700, Stephen Hemminger wrote: > Prototype for pci_unbind_kernel_driver exists but no code. > > Signed-off-by: Stephen Hemminger Acked-by: Gaetan Rivet > --- > drivers/bus/pci/private.h | 10 -- > 1 file changed, 10 deletions(-) > > diff --git a/driv

Re: [dpdk-dev] [PATCH] bus/vdev: reduce scope of device list lock

2018-05-22 Thread Burakov, Anatoly
On 21-May-18 5:11 PM, Thomas Monjalon wrote: The lock vdev_device_list_lock was taken before calling "remove" function for the device. So it prevents to remove sub-devices (as in failsafe) inside its own "remove" function, because of a deadlock. The lock is now only protecting the device list in

Re: [dpdk-dev] [PATCH v2] app/testpmd: fix log of start command

2018-05-22 Thread Iremonger, Bernard
Hi Ferruh, > -Original Message- > From: Yigit, Ferruh > Sent: Monday, May 21, 2018 3:16 PM > To: Iremonger, Bernard ; dev@dpdk.org > Subject: Re: [PATCH v2] app/testpmd: fix log of start command > > On 5/21/2018 2:28 PM, Bernard Iremonger wrote: > > Call the rte_eth_rxq_info_get() and rte

Re: [dpdk-dev] [PATCH v2] bus/vdev: fix scope of device list lock

2018-05-22 Thread Gaëtan Rivet
On Mon, May 21, 2018 at 05:28:52PM +, Matan Azrad wrote: > > > From: Thomas Monjalon > > The lock vdev_device_list_lock was taken before calling "remove" function > > for > > the device. > > So it prevents to remove sub-devices (as in failsafe) inside its own > > "remove" > > function, beca

Re: [dpdk-dev] [PATCH v7 8/8] rte_ethdev.h: align sign and scope of temp var

2018-05-22 Thread Bruce Richardson
On Tue, May 22, 2018 at 09:24:47AM +0800, Andy Green wrote: > /projects/lagopus/src/dpdk/build/include/rte_ethdev.h: > In function 'rte_eth_rx_burst': > /projects/lagopus/src/dpdk/build/include/rte_ethdev.h: > 3836:18: warning: conversion to 'int16_t' {aka 'short > int'} from 'uint16_t' {aka 'short

Re: [dpdk-dev] [PATCH v7 1/8] lib/librte_eal: change type of tmp

2018-05-22 Thread Bruce Richardson
On Tue, May 22, 2018 at 09:24:12AM +0800, Andy Green wrote: > /projects/lagopus/src/dpdk/build/include/rte_memcpy.h: > 793:2: note: in expansion of macro 'MOVEUNALIGNED_LEFT47' > MOVEUNALIGNED_LEFT47(dst, src, n, srcofs); > ^~~~ > /projects/lagopus/src/dpdk/build/include/rte_mem

Re: [dpdk-dev] [PATCH v7 0/8] Fixes for GCC8 against lagopus

2018-05-22 Thread Bruce Richardson
On Tue, May 22, 2018 at 09:24:07AM +0800, Andy Green wrote: > The following series fixes build problems in dpdk master > headers, found when using it as the dpdk subproject in > lagopus. These errors are coming when you try to use > the dpdk headers, not when you build dpdk itself. > > 6/8 are ac

Re: [dpdk-dev] [PATCH v7 0/8] Fixes for GCC8 against lagopus

2018-05-22 Thread Andy Green
On 05/22/2018 05:13 PM, Bruce Richardson wrote: On Tue, May 22, 2018 at 09:24:07AM +0800, Andy Green wrote: The following series fixes build problems in dpdk master headers, found when using it as the dpdk subproject in lagopus. These errors are coming when you try to use the dpdk headers, no

Re: [dpdk-dev] [PATCH] bus/vdev: reduce scope of device list lock

2018-05-22 Thread Thomas Monjalon
22/05/2018 11:05, Burakov, Anatoly: > On 21-May-18 5:11 PM, Thomas Monjalon wrote: > > The lock vdev_device_list_lock was taken before calling > > "remove" function for the device. > > So it prevents to remove sub-devices (as in failsafe) inside > > its own "remove" function, because of a deadlock.

Re: [dpdk-dev] [PATCH 3/4] crypto/qat: move common qat files to common dir

2018-05-22 Thread Bruce Richardson
On Tue, May 22, 2018 at 08:51:40AM +0200, Tomasz Jozwiak wrote: > - moved common qat files to common/qat dir. > - changed common/qat/Makefile, common/qat/meson.build, > drivers/meson.build, drivers/Makefile, crypto/Makefile > to add possibility of using new files locations > - ad

Re: [dpdk-dev] [PATCH] compressdev: remove unused driver id

2018-05-22 Thread Trahe, Fiona
> -Original Message- > From: De Lara Guarch, Pablo > Sent: Monday, May 21, 2018 11:39 PM > To: Trahe, Fiona ; ashish.gu...@caviumnetworks.com > Cc: dev@dpdk.org; De Lara Guarch, Pablo > Subject: [PATCH] compressdev: remove unused driver id > > Driver id field is not set/used anywhere, >

Re: [dpdk-dev] [PATCH v5 6/6] cryptodev: rename get session size API

2018-05-22 Thread Trahe, Fiona
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Pablo de Lara > Sent: Monday, May 21, 2018 2:09 PM > To: Doherty, Declan ; akhil.go...@nxp.com; > shally.ve...@cavium.com > Cc: dev@dpdk.org; De Lara Guarch, Pablo > Subject: [dpdk-dev] [PATCH v5 6/6] cryptodev:

Re: [dpdk-dev] [PATCH v2 2/2] net/mlx4: refactor RSS conversion functions

2018-05-22 Thread Ferruh Yigit
On 5/21/2018 4:50 PM, Adrien Mazarguil wrote: > Since commit 97b2217ae5bc ("net/mlx4: advertise supported RSS hash > functions"), this PMD includes two similar-looking functions that convert > RSS hash fields between Verbs and DPDK formats. > > This patch refactors them as a single two-way functio

Re: [dpdk-dev] [PATCH] net/i40e: add a specific API to control the LLDP agent

2018-05-22 Thread Laurent Hardy
Hi Qi, On 05/21/2018 03:11 PM, Zhang, Qi Z wrote: Hi Zijie: -Original Message- From: Zijie Pan [mailto:zijie@6wind.com] Sent: Friday, May 18, 2018 6:14 PM To: dev@dpdk.org Cc: Xing, Beilei ; Zhang, Qi Z ; Laurent Hardy Subject: [PATCH] net/i40e: add a specific API to control the

Re: [dpdk-dev] [PATCH] net/tap: fix the vdev data sharing for tun

2018-05-22 Thread Ferruh Yigit
On 5/15/2018 1:56 PM, Varghese, Vipin wrote: > HI Keith, > > Thanks for the input, please find my answer inline to email therad > > > >>> + /* TODO: request info from primary to set up Rx and Tx */ >> >> What is the rule (if we have one) about having TODO, FIXME, … like comments >> i

Re: [dpdk-dev] [PATCH] net/ark: Add missing call to probe_finish for first device

2018-05-22 Thread Ferruh Yigit
On 5/21/2018 10:26 PM, Thomas Monjalon wrote: > 21/05/2018 21:42, john miller: >> >>> On May 21, 2018, at 3:29 PM, Ed Czeck wrote: >>> >>> Fix on commit fbe90cdd776c ("ethdev: add probing finish function") > > Fixes: fbe90cdd776c ("ethdev: add probing finish function") > >>> Signed-off-by: Ed Cz

Re: [dpdk-dev] [PATCH] net/vdev_netvsc: fix automatic probing

2018-05-22 Thread Ferruh Yigit
On 5/21/2018 5:23 PM, Matan Azrad wrote: > The vdev_netvsc driver allows an automatic probe in Hyper-V VM systems > unless it was already specified by the EAL command line. > > The detection of a specified NetVSC device is wrongly done by comparing > the vdev_netvsc driver name to all the vdev dev

Re: [dpdk-dev] [PATCH] crypto/scheduler: fix 64-bit mask of workers cores

2018-05-22 Thread De Lara Guarch, Pablo
> -Original Message- > From: Rybalchenko, Kirill > Sent: Monday, May 21, 2018 11:22 AM > To: dev@dpdk.org > Cc: sta...@dpdk.org; Rybalchenko, Kirill ; > Zhang, > Roy Fan ; Pattan, Reshma > ; De Lara Guarch, Pablo > > Subject: [PATCH] crypto/scheduler: fix 64-bit mask of workers cores >

Re: [dpdk-dev] [PATCH v2 2/2] net/mlx4: refactor RSS conversion functions

2018-05-22 Thread Adrien Mazarguil
On Tue, May 22, 2018 at 10:41:35AM +0100, Ferruh Yigit wrote: > On 5/21/2018 4:50 PM, Adrien Mazarguil wrote: > > Since commit 97b2217ae5bc ("net/mlx4: advertise supported RSS hash > > functions"), this PMD includes two similar-looking functions that convert > > RSS hash fields between Verbs and DP

Re: [dpdk-dev] [dpdk-stable] [PATCH 1/2] net/bonding: export mode 4 slave info routine

2018-05-22 Thread Ferruh Yigit
On 5/18/2018 12:22 AM, Chas Williams wrote: > From: Chas Williams > > rte_eth_bond_8023ad_slave_info() wasn't exported in the original work. > Useful to extract information about the current 802.3ad state. > > Fixes: 46fb43683679 ("bond: add mode 4") > Cc: sta...@dpdk.org > > Signed-off-by: Cha

Re: [dpdk-dev] [PATCH] compressdev: clarify buffer size limitation

2018-05-22 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of De Lara Guarch, Pablo > Sent: Monday, May 21, 2018 11:32 PM > To: Verma, Shally ; Trahe, Fiona > ; dev@dpdk.org > Cc: Gupta, Ashish ; Sahu, Sunila > > Subject: Re: [dpdk-dev] [PATCH] compressdev: clarify buffer s

Re: [dpdk-dev] [dpdk-stable] [PATCH] crypto/scheduler: fix 64-bit mask of workers cores

2018-05-22 Thread De Lara Guarch, Pablo
> -Original Message- > From: stable [mailto:stable-boun...@dpdk.org] On Behalf Of De Lara Guarch, > Pablo > Sent: Tuesday, May 22, 2018 10:58 AM > To: Rybalchenko, Kirill ; dev@dpdk.org > Cc: sta...@dpdk.org; Zhang, Roy Fan ; Pattan, > Reshma > Subject: Re: [dpdk-stable] [PATCH] crypto/s

Re: [dpdk-dev] [PATCH] compressdev: remove unused driver id

2018-05-22 Thread De Lara Guarch, Pablo
> -Original Message- > From: Trahe, Fiona > Sent: Tuesday, May 22, 2018 10:26 AM > To: De Lara Guarch, Pablo ; > ashish.gu...@caviumnetworks.com > Cc: dev@dpdk.org > Subject: RE: [PATCH] compressdev: remove unused driver id > > > > > -Original Message- > > From: De Lara Guarch,

Re: [dpdk-dev] [PATCH v2 1/2] net/failsafe: fix removed sub-device cleanup

2018-05-22 Thread Matan Azrad
Hi Gaetan From: Gaëtan Rivet > Hello Matan, > > On Mon, May 21, 2018 at 07:48:03PM +, Matan Azrad wrote: > > The fail-safe PMD registers to RMV event for each removable sub-device > > port in order to cleanup the sub-device resources and switch the Tx > > sub-device directly when it is plugge

Re: [dpdk-dev] [RFC v2] vhost: new rte_vhost API proposal

2018-05-22 Thread Stojaczyk, DariuszX
Hi Maxime, > -Original Message- > From: Maxime Coquelin [mailto:maxime.coque...@redhat.com] > Sent: Friday, May 18, 2018 9:51 PM > On 05/18/2018 03:01 PM, Dariusz Stojaczyk wrote: > > rte_vhost is not vhost-user spec compliant. Some Vhost drivers have > > been already confirmed not to work

[dpdk-dev] [PATCH v3] app/testpmd: fix log of start command

2018-05-22 Thread Bernard Iremonger
Call the rte_eth_rxq_info_get() and rte_eth_txq_info_get() functions to update the number of rx and tx descriptors. Fixes: d44f8a485f5d ("app/testpmd: enable per queue configure") Signed-off-by: Bernard Iremonger --- app/test-pmd/config.c | 11 +++ 1 file changed, 11 insertions(+) diff

[dpdk-dev] [PATCH v2 0/3] Fix bus/ifpga coverity issue: 279455, 279459 and 279454

2018-05-22 Thread Rosen Xu
This patch set fix bus/ifpga coverity issue: 279455, 279459 and 279454 v2 updates: === - Add more description, devide to 3 patches v1 updates: === - Fix Coverity issue: 279455, 279459 and 279454 Rosen Xu (3): bus/ifpga: fix error control flow issue bus/ifpga: fix resource l

Re: [dpdk-dev] [PATCH] kni: fix build on Centos 7.4 when Ethtool enabled

2018-05-22 Thread Ferruh Yigit
On 5/22/2018 1:18 AM, Dan Gora wrote: > Fix compilation errors on Centos 7.4 when CONFIG_RTE_KNI_KMOD_ETHTOOL > is set to 'y'. > > Centos 7.4 needs HAVE_NDO_BRIDGE_GETLINK_FILTER_MASK_VLAN_FILL: > > igb_main.c: In function ‘igb_ndo_bridge_getlink’: > igb_main.c:2289:2: error: too few arguments to

[dpdk-dev] [PATCH v2 1/3] bus/ifpga: fix error control flow issue

2018-05-22 Thread Rosen Xu
The control variable should be afu_dev not dev. Coverity issue: 279455 Fixes: 05fa3d4a6539 ("bus/ifpga: add Intel FPGA bus library") Cc: sta...@dpdk.org Signed-off-by: Rosen Xu --- drivers/bus/ifpga/ifpga_bus.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/bus/ifpg

[dpdk-dev] [PATCH v2 2/3] bus/ifpga: fix resource leaks issue

2018-05-22 Thread Rosen Xu
There are some resource leaks in ifpga_scan_one. This patch fixes it. Coverity issue: 279459 Fixes: 05fa3d4a6539 ("bus/ifpga: add Intel FPGA bus library") Cc: sta...@dpdk.org Signed-off-by: Rosen Xu --- drivers/bus/ifpga/ifpga_bus.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(

[dpdk-dev] [PATCH v2 3/3] bus/ifpga: fix null pointer dereferences issue

2018-05-22 Thread Rosen Xu
Fix ifpga_scan_one() null pointer dereferences issue. Coverity issue: 279454 Fixes: 05fa3d4a6539 ("bus/ifpga: add Intel FPGA bus library") Cc: sta...@dpdk.org Signed-off-by: Rosen Xu --- drivers/bus/ifpga/ifpga_bus.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/

[dpdk-dev] [PATCH] lib/compress: clarify when it's ok to clear private_xform data

2018-05-22 Thread Fiona Trahe
As the private_xform data can be shared by many operations and across queue_pairs, it would be performance impacting for PMDs to track inflights associated with one. It makes more sense to push the responsibility to the application to keep track of its usage and only delete the private_xform when t

Re: [dpdk-dev] [PATCH v3] app/testpmd: fix log of start command

2018-05-22 Thread Ferruh Yigit
On 5/22/2018 11:22 AM, Bernard Iremonger wrote: > Call the rte_eth_rxq_info_get() and rte_eth_txq_info_get() functions > to update the number of rx and tx descriptors. > > Fixes: d44f8a485f5d ("app/testpmd: enable per queue configure") > Signed-off-by: Bernard Iremonger > --- > app/test-pmd/conf

[dpdk-dev] [PATCH] lib/crypto: clarify when it's ok to clear private session data

2018-05-22 Thread Fiona Trahe
Signed-off-by: Fiona Trahe --- lib/librte_cryptodev/rte_cryptodev.h |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/lib/librte_cryptodev/rte_cryptodev.h b/lib/librte_cryptodev/rte_cryptodev.h index 2fb6563..eb6c66f 100644 --- a/lib/librte_cryptodev/rte_cryptodev.h +++

Re: [dpdk-dev] [dpdk-stable] [PATCH] drivers/raw/ifpga_rawdev: fix coverity issue

2018-05-22 Thread Xu, Rosen
Hi Thomas, > -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Monday, May 21, 2018 22:23 > To: Xu, Rosen > Cc: dev@dpdk.org; Zhang, Roy Fan ; Doherty, > Declan ; Richardson, Bruce > ; shreyansh.j...@nxp.com; Yigit, Ferruh > ; Ananyev, Konstantin > ; Zhang, T

[dpdk-dev] [PATCH v3] net/tap: perform proto field update for tun only

2018-05-22 Thread Vipin Varghese
The TX function is shared between TAP and TUN PMD. Checking TUN-TAP type field will ensure the TAP PMD will always have protocol field as 0. Signed-off-by: Vipin Varghese Suggested-by: Ferruh Yigit --- Changes in V3: - remove type field from rx struct - Ophir Munk - add space for comment in stru

Re: [dpdk-dev] [PATCH v3] app/testpmd: fix log of start command

2018-05-22 Thread Iremonger, Bernard
Hi Ferruh, nb_rx_desc[qid] = rx_qinfo.nb_desc; > > Hi Bernard, > > Isn't this doing same thing with previous patch, in a different location? > > Do you think testpmd config variable should be updated? > Why not just use the value for print but not save it? Ok, I will

[dpdk-dev] [PATCH] compressdev: clarify mbuf offsets

2018-05-22 Thread Pablo de Lara
Add extra clarification about offset in source and destination mbuf used in compressdev, when they are a chain of mbufs. Signed-off-by: Pablo de Lara --- lib/librte_compressdev/rte_comp.h | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/lib/librte_compressdev/rte_comp.h

[dpdk-dev] [PATCH v2] net/tap: fix the vdev data sharing for tun

2018-05-22 Thread Vipin Varghese
Fixes: ee27edbe0c10 ("drivers/net: share vdev data to secondary process") Enables TUN PMD sharing by attaching the port from the shared data. Cc: zhihong.w...@intel.com Cc: ferruh.yi...@intel.com Signed-off-by: Vipin Varghese --- Changes in V2: - removal of To Do comment - Keith Wiles, Ferruh

Re: [dpdk-dev] [PATCH v2] net/tap: perform proto field update for tun only

2018-05-22 Thread Varghese, Vipin
Hi Ophir, Keith and Ferruh, I have shared v3 with all the suggested changes. Thanks Vipin Varghese > -Original Message- > From: Varghese, Vipin > Sent: Tuesday, May 22, 2018 12:04 PM > To: Ophir Munk ; dev@dpdk.org; Wiles, Keith > ; Yigit, Ferruh > Cc: Thomas Monjalon ; Olga Shern > >

Re: [dpdk-dev] [PATCH] lib/crypto: clarify when it's ok to clear private session data

2018-05-22 Thread De Lara Guarch, Pablo
> -Original Message- > From: Trahe, Fiona > Sent: Tuesday, May 22, 2018 11:37 AM > To: dev@dpdk.org > Cc: De Lara Guarch, Pablo ; Trahe, Fiona > ; akhil.go...@nxp.com > Subject: [PATCH] lib/crypto: clarify when it's ok to clear private session > data > > Signed-off-by: Fiona Trahe Ack

Re: [dpdk-dev] [PATCH] lib/compress: clarify when it's ok to clear private_xform data

2018-05-22 Thread De Lara Guarch, Pablo
> -Original Message- > From: Trahe, Fiona > Sent: Tuesday, May 22, 2018 11:34 AM > To: dev@dpdk.org > Cc: De Lara Guarch, Pablo ; Trahe, Fiona > ; shally.ve...@cavium.com; > ahmed.mans...@nxp.com; ashish.gu...@caviumnetworks.com > Subject: [PATCH] lib/compress: clarify when it's ok to cle

[dpdk-dev] [PATCH] net/mlx4: fix undefined behavior of RSS conversion

2018-05-22 Thread Adrien Mazarguil
As reported by ICC, an array initializer that uses values found in the array being initialized, although semantically correct (GCC and clang do not complain and generate correct code), results in undefined behavior since initialization order is itself undefined. This patch restores the static keyw

Re: [dpdk-dev] [PATCH] net/i40e: remove dependency on old rxmode flags

2018-05-22 Thread Ferruh Yigit
On 5/22/2018 3:50 AM, Xing, Beilei wrote: > > >> -Original Message- >> From: Zhang, Qi Z >> Sent: Tuesday, May 22, 2018 9:01 AM >> To: Yigit, Ferruh >> Cc: dev@dpdk.org; Xing, Beilei ; Zhang, Qi Z >> >> Subject: [PATCH] net/i40e: remove dependency on old rxmode flags >> >> Cleanup remai

[dpdk-dev] [PATCH v3] bus/vdev: replace device list lock by a recursive one

2018-05-22 Thread Thomas Monjalon
A device like failsafe can manage sub-devices. When removing such device, it removes its sub-devices and try to take the same vdev_device_list_lock. It was causing a deadlock because the lock was not recursive. Fixes: 35f462839b69 ("bus/vdev: add lock on device list") Suggested-by: Anatoly Burako

[dpdk-dev] [PATCH] net/vhost: convert to new Rx offload API

2018-05-22 Thread Maxime Coquelin
Signed-off-by: Maxime Coquelin --- drivers/net/vhost/rte_eth_vhost.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/vhost/rte_eth_vhost.c b/drivers/net/vhost/rte_eth_vhost.c index f4733..aadb2327c 100644 --- a/drivers/net/vhost/rte_eth_vhost.c +++ b/drive

Re: [dpdk-dev] [PATCH] compressdev: clarify mbuf offsets

2018-05-22 Thread Verma, Shally
>-Original Message- >From: Pablo de Lara [mailto:pablo.de.lara.gua...@intel.com] >Sent: 22 May 2018 16:25 >To: fiona.tr...@intel.com; Gupta, Ashish ; Verma, >Shally >Cc: dev@dpdk.org; Pablo de Lara >Subject: [PATCH] compressdev: clarify mbuf offsets > >Add extra clarification about off

Re: [dpdk-dev] [PATCH] net/vhost: convert to new Rx offload API

2018-05-22 Thread Ferruh Yigit
On 5/22/2018 12:36 PM, Maxime Coquelin wrote: > Signed-off-by: Maxime Coquelin Reviewed-by: Ferruh Yigit

Re: [dpdk-dev] [PATCH] net/vhost: convert to new Rx offload API

2018-05-22 Thread Ferruh Yigit
On 5/22/2018 12:41 PM, Ferruh Yigit wrote: > On 5/22/2018 12:36 PM, Maxime Coquelin wrote: >> Signed-off-by: Maxime Coquelin > > Reviewed-by: Ferruh Yigit Applied to dpdk-next-net/master, thanks.

Re: [dpdk-dev] [PATCH v2 1/2] net/failsafe: fix removed sub-device cleanup

2018-05-22 Thread Gaëtan Rivet
On Tue, May 22, 2018 at 10:19:14AM +, Matan Azrad wrote: > Hi Gaetan > > From: Gaëtan Rivet > > Hello Matan, > > > > On Mon, May 21, 2018 at 07:48:03PM +, Matan Azrad wrote: > > > The fail-safe PMD registers to RMV event for each removable sub-device > > > port in order to cleanup the sub

Re: [dpdk-dev] [PATCH] net/vhost: convert to new Rx offload API

2018-05-22 Thread Tiwei Bie
On Tue, May 22, 2018 at 01:36:39PM +0200, Maxime Coquelin wrote: > Signed-off-by: Maxime Coquelin > --- > drivers/net/vhost/rte_eth_vhost.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/vhost/rte_eth_vhost.c > b/drivers/net/vhost/rte_eth_vhost.c > inde

Re: [dpdk-dev] [PATCH] net/vhost: convert to new Rx offload API

2018-05-22 Thread Tiwei Bie
On Tue, May 22, 2018 at 07:53:57PM +0800, Tiwei Bie wrote: > On Tue, May 22, 2018 at 01:36:39PM +0200, Maxime Coquelin wrote: > > Signed-off-by: Maxime Coquelin > > --- > > drivers/net/vhost/rte_eth_vhost.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/driver

Re: [dpdk-dev] [PATCH v3] bus/vdev: replace device list lock by a recursive one

2018-05-22 Thread Matan Azrad
From: Thomas Monjalon > A device like failsafe can manage sub-devices. > When removing such device, it removes its sub-devices and try to take the > same vdev_device_list_lock. > It was causing a deadlock because the lock was not recursive. > > Fixes: 35f462839b69 ("bus/vdev: add lock on device

Re: [dpdk-dev] [PATCH v2 1/2] net/failsafe: fix removed sub-device cleanup

2018-05-22 Thread Matan Azrad
From: Gaëtan Rivet > On Tue, May 22, 2018 at 10:19:14AM +, Matan Azrad wrote: > > Hi Gaetan > > > > From: Gaëtan Rivet > > > Hello Matan, > > > > > > On Mon, May 21, 2018 at 07:48:03PM +, Matan Azrad wrote: > > > > The fail-safe PMD registers to RMV event for each removable > > > > sub-de

Re: [dpdk-dev] [PATCH] net/vhost: convert to new Rx offload API

2018-05-22 Thread Maxime Coquelin
On 05/22/2018 02:09 PM, Tiwei Bie wrote: On Tue, May 22, 2018 at 07:53:57PM +0800, Tiwei Bie wrote: On Tue, May 22, 2018 at 01:36:39PM +0200, Maxime Coquelin wrote: Signed-off-by: Maxime Coquelin --- drivers/net/vhost/rte_eth_vhost.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(

Re: [dpdk-dev] [PATCH] net/vhost: convert to new Rx offload API

2018-05-22 Thread Tiwei Bie
On Tue, May 22, 2018 at 02:12:36PM +0200, Maxime Coquelin wrote: > On 05/22/2018 02:09 PM, Tiwei Bie wrote: > > On Tue, May 22, 2018 at 07:53:57PM +0800, Tiwei Bie wrote: > > > On Tue, May 22, 2018 at 01:36:39PM +0200, Maxime Coquelin wrote: > > > > Signed-off-by: Maxime Coquelin > > > > --- > > >

[dpdk-dev] [PATCH v2] net/vhost: convert to new Rx/Tx offload API

2018-05-22 Thread Maxime Coquelin
Signed-off-by: Maxime Coquelin --- Changes since v2: - Announce supported Rx & Tx offload features (Tiwei) drivers/net/vhost/rte_eth_vhost.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/net/vhost/rte_eth_vhost.c b/drivers/net/vhost/rte_eth_vhost.c index f4

Re: [dpdk-dev] [PATCH v2] net/vhost: convert to new Rx/Tx offload API

2018-05-22 Thread Tiwei Bie
On Tue, May 22, 2018 at 02:22:11PM +0200, Maxime Coquelin wrote: > Signed-off-by: Maxime Coquelin > --- > Changes since v2: > - Announce supported Rx & Tx offload features (Tiwei) > > drivers/net/vhost/rte_eth_vhost.c | 8 ++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --gi

Re: [dpdk-dev] [PATCH] net/vhost: convert to new Rx offload API

2018-05-22 Thread Ferruh Yigit
On 5/22/2018 12:49 PM, Ferruh Yigit wrote: > On 5/22/2018 12:41 PM, Ferruh Yigit wrote: >> On 5/22/2018 12:36 PM, Maxime Coquelin wrote: >>> Signed-off-by: Maxime Coquelin >> >> Reviewed-by: Ferruh Yigit > > Applied to dpdk-next-net/master, thanks. Dropped back from tree in favor of v2 of patch

Re: [dpdk-dev] [PATCH v2] net/vhost: convert to new Rx/Tx offload API

2018-05-22 Thread Maxime Coquelin
On 05/22/2018 02:34 PM, Tiwei Bie wrote: On Tue, May 22, 2018 at 02:22:11PM +0200, Maxime Coquelin wrote: Signed-off-by: Maxime Coquelin --- Changes since v2: - Announce supported Rx & Tx offload features (Tiwei) drivers/net/vhost/rte_eth_vhost.c | 8 ++-- 1 file changed, 6 insertions

Re: [dpdk-dev] [PATCH v2] net/vhost: convert to new Rx/Tx offload API

2018-05-22 Thread Ferruh Yigit
On 5/22/2018 1:34 PM, Tiwei Bie wrote: > On Tue, May 22, 2018 at 02:22:11PM +0200, Maxime Coquelin wrote: >> Signed-off-by: Maxime Coquelin >> --- >> Changes since v2: >> - Announce supported Rx & Tx offload features (Tiwei) >> >> drivers/net/vhost/rte_eth_vhost.c | 8 ++-- >> 1 file changed,

[dpdk-dev] [PATCH v3 1/2] net/failsafe: fix removed sub-device cleanup

2018-05-22 Thread Matan Azrad
The fail-safe PMD registers to RMV event for each removable sub-device port in order to cleanup the sub-device resources and switch the Tx sub-device directly when it is plugged-out. During removal time, the fail-safe PMD stops and closes the sub-device but it doesn't unregister the LSC and RMV ca

[dpdk-dev] [PATCH v3 2/2] net/failsafe: fix duplicate event registration

2018-05-22 Thread Matan Azrad
When the fail-safe device is reconfigured, it attempts to register again for the sub-devices LSC and RMV events. Prevent an event registration if it is already done. Fixes: 598fb8aec6f6 ("net/failsafe: support device removal") Cc: sta...@dpdk.org Signed-off-by: Matan Azrad --- drivers/net/fail

[dpdk-dev] [PATCH 1/3] doc/crypto: update KASUMI installation section

2018-05-22 Thread Pablo de Lara
Intel's libsso_kasumi library has been moved to a new location, under "Intel Resource & Design Center". The installation section of this PMD has been updated to include the new instructions. Signed-off-by: Pablo de Lara --- doc/guides/cryptodevs/kasumi.rst | 10 +- 1 file changed, 5 inse

[dpdk-dev] [PATCH 3/3] doc/crypto: update ZUC installation section

2018-05-22 Thread Pablo de Lara
Intel's libsso_zuc library has been moved to a new location, under "Intel Resource & Design Center". The installation section of this PMD has been updated to include the new instructions. Signed-off-by: Pablo de Lara --- doc/guides/cryptodevs/zuc.rst | 10 +- 1 file changed, 5 insertions

[dpdk-dev] [PATCH 2/3] doc/crypto: update SNOW3G installation section

2018-05-22 Thread Pablo de Lara
Intel's libsso_snow3g library has been moved to a new location, under "Intel Resource & Design Center". The installation section of this PMD has been updated to include the new instructions. Signed-off-by: Pablo de Lara --- doc/guides/cryptodevs/snow3g.rst | 10 +- 1 file changed, 5 inse

Re: [dpdk-dev] [PATCH] lib/compress: clarify when it's ok to clear private_xform data

2018-05-22 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of De Lara Guarch, Pablo > Sent: Tuesday, May 22, 2018 12:08 PM > To: Trahe, Fiona ; dev@dpdk.org > Cc: shally.ve...@cavium.com; ahmed.mans...@nxp.com; > ashish.gu...@caviumnetworks.com > Subject: Re: [dpdk-dev] [PAT

Re: [dpdk-dev] [PATCH] lib/crypto: clarify when it's ok to clear private session data

2018-05-22 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of De Lara Guarch, Pablo > Sent: Tuesday, May 22, 2018 12:08 PM > To: Trahe, Fiona ; dev@dpdk.org > Cc: akhil.go...@nxp.com > Subject: Re: [dpdk-dev] [PATCH] lib/crypto: clarify when it's ok to clear > private > ses

Re: [dpdk-dev] [PATCH] compressdev: clarify mbuf offsets

2018-05-22 Thread De Lara Guarch, Pablo
> -Original Message- > From: Verma, Shally [mailto:shally.ve...@cavium.com] > Sent: Tuesday, May 22, 2018 12:41 PM > To: De Lara Guarch, Pablo ; Trahe, Fiona > ; Gupta, Ashish > Cc: dev@dpdk.org > Subject: RE: [PATCH] compressdev: clarify mbuf offsets > > > > >-Original Message---

[dpdk-dev] [PATCH] net/ixgbe: remove unnecessary macro

2018-05-22 Thread Qi Zhang
Since we move to new offload APIs, IXGBE_SIMPLE_FLAGS is not used. Fixes: 51215925a32f ("net/ixgbe: convert to new Tx offloads API") Signed-off-by: Qi Zhang --- drivers/net/ixgbe/ixgbe_rxtx.h | 14 -- 1 file changed, 14 deletions(-) diff --git a/drivers/net/ixgbe/ixgbe_rxtx.h b/dri

Re: [dpdk-dev] [PATCH v2] net/vhost: convert to new Rx/Tx offload API

2018-05-22 Thread Maxime Coquelin
On 05/22/2018 02:38 PM, Ferruh Yigit wrote: On 5/22/2018 1:34 PM, Tiwei Bie wrote: On Tue, May 22, 2018 at 02:22:11PM +0200, Maxime Coquelin wrote: Signed-off-by: Maxime Coquelin --- Changes since v2: - Announce supported Rx & Tx offload features (Tiwei) drivers/net/vhost/rte_eth_vhost.c

[dpdk-dev] [PATCH v3] net/vhost: convert to new Rx/Tx offload API

2018-05-22 Thread Maxime Coquelin
Signed-off-by: Maxime Coquelin --- Changes since v2: - Remove check for unsupported offload feature (Tiwei) drivers/net/vhost/rte_eth_vhost.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/net/vhost/rte_eth_vhost.c b/drivers/net/vhost/rte_eth_vhost.c ind

Re: [dpdk-dev] [PATCH v3] net/vhost: convert to new Rx/Tx offload API

2018-05-22 Thread Tiwei Bie
On Tue, May 22, 2018 at 02:50:19PM +0200, Maxime Coquelin wrote: > Signed-off-by: Maxime Coquelin Reviewed-by: Tiwei Bie Thanks for the work! Best regards, Tiwei Bie

Re: [dpdk-dev] [PATCH] compressdev: clarify mbuf offsets

2018-05-22 Thread Trahe, Fiona
> -Original Message- > From: De Lara Guarch, Pablo > Sent: Tuesday, May 22, 2018 11:55 AM > To: Trahe, Fiona ; ashish.gu...@caviumnetworks.com; > shally.ve...@cavium.com > Cc: dev@dpdk.org; De Lara Guarch, Pablo > Subject: [PATCH] compressdev: clarify mbuf offsets > > Add extra clarific

Re: [dpdk-dev] [PATCH] net/i40e: add a specific API to control the LLDP agent

2018-05-22 Thread Zhang, Qi Z
> -Original Message- > From: Zijie Pan [mailto:zijie@6wind.com] > Sent: Friday, May 18, 2018 6:14 PM > To: dev@dpdk.org > Cc: Xing, Beilei ; Zhang, Qi Z ; > Laurent Hardy > Subject: [PATCH] net/i40e: add a specific API to control the LLDP agent > > Add a new API rte_pmd_i40e_set_lldp_

Re: [dpdk-dev] [PATCH] net/mlx4: fix undefined behavior of RSS conversion

2018-05-22 Thread Ferruh Yigit
On 5/22/2018 12:26 PM, Adrien Mazarguil wrote: > As reported by ICC, an array initializer that uses values found in the > array being initialized, although semantically correct (GCC and clang do > not complain and generate correct code), results in undefined behavior > since initialization order is

Re: [dpdk-dev] [PATCH 1/3] doc/crypto: update KASUMI installation section

2018-05-22 Thread Kovacevic, Marko
> Signed-off-by: Pablo de Lara > --- > doc/guides/cryptodevs/kasumi.rst | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/doc/guides/cryptodevs/kasumi.rst > b/doc/guides/cryptodevs/kasumi.rst > index f56b54758..c766a0eda 100644 > --- a/doc/guides/cryptodevs/kasu

Re: [dpdk-dev] [PATCH 2/3] doc/crypto: update SNOW3G installation section

2018-05-22 Thread Kovacevic, Marko
> Signed-off-by: Pablo de Lara > --- > doc/guides/cryptodevs/snow3g.rst | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/doc/guides/cryptodevs/snow3g.rst > b/doc/guides/cryptodevs/snow3g.rst > index 24b4f661c..c5fcefd34 100644 > --- a/doc/guides/cryptodevs/snow

Re: [dpdk-dev] [PATCH 3/3] doc/crypto: update ZUC installation section

2018-05-22 Thread Kovacevic, Marko
> Signed-off-by: Pablo de Lara > --- > doc/guides/cryptodevs/zuc.rst | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/doc/guides/cryptodevs/zuc.rst b/doc/guides/cryptodevs/zuc.rst > index e226ef9d0..7865954f2 100644 > --- a/doc/guides/cryptodevs/zuc.rst > +++ b

Re: [dpdk-dev] [PATCH v2] app/testpmd: fix pmd_test_exit function for vdevs

2018-05-22 Thread Thomas Monjalon
Any update to improve this workaround? 21/05/2018 18:38, Thomas Monjalon: > 21/05/2018 18:32, Ferruh Yigit: > > On 5/21/2018 11:54 AM, Thomas Monjalon wrote: > > > 19/05/2018 16:19, Thomas Monjalon: > > >> 18/05/2018 18:29, Ferruh Yigit: > > >>> On 5/18/2018 4:55 PM, Matan Azrad wrote: > > Hi

Re: [dpdk-dev] [PATCH v3 1/2] net/failsafe: fix removed sub-device cleanup

2018-05-22 Thread Gaëtan Rivet
On Tue, May 22, 2018 at 12:38:46PM +, Matan Azrad wrote: > The fail-safe PMD registers to RMV event for each removable sub-device > port in order to cleanup the sub-device resources and switch the Tx > sub-device directly when it is plugged-out. > > During removal time, the fail-safe PMD stops

Re: [dpdk-dev] [PATCH v3 2/2] net/failsafe: fix duplicate event registration

2018-05-22 Thread Gaëtan Rivet
On Tue, May 22, 2018 at 12:38:47PM +, Matan Azrad wrote: > When the fail-safe device is reconfigured, it attempts to register > again for the sub-devices LSC and RMV events. > > Prevent an event registration if it is already done. > > Fixes: 598fb8aec6f6 ("net/failsafe: support device removal

Re: [dpdk-dev] [PATCH v3] net/vhost: convert to new Rx/Tx offload API

2018-05-22 Thread Ferruh Yigit
On 5/22/2018 1:54 PM, Tiwei Bie wrote: > On Tue, May 22, 2018 at 02:50:19PM +0200, Maxime Coquelin wrote: >> Signed-off-by: Maxime Coquelin > > Reviewed-by: Tiwei Bie Applied to dpdk-next-net/master, thanks.

Re: [dpdk-dev] [PATCH] net/mlx4: fix undefined behavior of RSS conversion

2018-05-22 Thread Adrien Mazarguil
On Tue, May 22, 2018 at 02:01:38PM +0100, Ferruh Yigit wrote: > On 5/22/2018 12:26 PM, Adrien Mazarguil wrote: > > As reported by ICC, an array initializer that uses values found in the > > array being initialized, although semantically correct (GCC and clang do > > not complain and generate correc

Re: [dpdk-dev] [PATCH v3] bus/vdev: replace device list lock by a recursive one

2018-05-22 Thread Burakov, Anatoly
On 22-May-18 12:37 PM, Thomas Monjalon wrote: A device like failsafe can manage sub-devices. When removing such device, it removes its sub-devices and try to take the same vdev_device_list_lock. It was causing a deadlock because the lock was not recursive. Fixes: 35f462839b69 ("bus/vdev: add loc

Re: [dpdk-dev] [PATCH] net/ixgbe: remove unnecessary macro

2018-05-22 Thread Ferruh Yigit
On 5/22/2018 1:47 PM, Qi Zhang wrote: > Since we move to new offload APIs, IXGBE_SIMPLE_FLAGS is not used. Documentation also mentions from this flag, can you update there too? > > Fixes: 51215925a32f ("net/ixgbe: convert to new Tx offloads API") > > Signed-off-by: Qi Zhang <...>

Re: [dpdk-dev] [PATCH v2] net/tap: fix the vdev data sharing for tun

2018-05-22 Thread Wiles, Keith
> On May 22, 2018, at 6:01 AM, Varghese, Vipin wrote: > > Fixes: ee27edbe0c10 ("drivers/net: share vdev data to secondary process") > > Enables TUN PMD sharing by attaching the port from the shared data. > > Cc: zhihong.w...@intel.com > Cc: ferruh.yi...@intel.com > > Signed-off-by: Vipin Var

Re: [dpdk-dev] [PATCH] net/liquidio:Fix Unable to update lio_dev->linfo.link var

2018-05-22 Thread Shijith Thotton
On Mon, May 21, 2018 at 08:58:15PM +0800, yaochuhong wrote: > When I was using VPP +dpdk-18.02+liqudio CN23xx, I encountered such a bug. \n > When VPP called dpdk_device_start to initialize DPDK liqudio drive, I found > that initialization failed. \n > The reason for the failure is that VF MTU > P

Re: [dpdk-dev] [PATCH v3] net/tap: perform proto field update for tun only

2018-05-22 Thread Wiles, Keith
> On May 22, 2018, at 5:47 AM, Varghese, Vipin wrote: > > The TX function is shared between TAP and TUN PMD. Checking TUN-TAP > type field will ensure the TAP PMD will always have protocol field > as 0. > > Signed-off-by: Vipin Varghese > Suggested-by: Ferruh Yigit > --- > Changes in V3: > -

Re: [dpdk-dev] [PATCH v2] net/tap: perform proto field update for tun only

2018-05-22 Thread Wiles, Keith
> On May 22, 2018, at 6:05 AM, Varghese, Vipin wrote: > > Hi Ophir, Keith and Ferruh, > > I have shared v3 with all the suggested changes. I just sent another change, sorry I did not catch if before, which I obviously was not paying attention. > > Thanks > Vipin Varghese > >> -Origin

Re: [dpdk-dev] [dpdk-stable] [PATCH v3 1/2] net/failsafe: fix removed sub-device cleanup

2018-05-22 Thread Ferruh Yigit
On 5/22/2018 2:14 PM, Gaëtan Rivet wrote: > On Tue, May 22, 2018 at 12:38:46PM +, Matan Azrad wrote: >> The fail-safe PMD registers to RMV event for each removable sub-device >> port in order to cleanup the sub-device resources and switch the Tx >> sub-device directly when it is plugged-out. >>

Re: [dpdk-dev] [PATCH] eventdev: fix resetting software timer

2018-05-22 Thread Carrillo, Erik G
> -Original Message- > From: Dan Gora [mailto:dan.g...@gmail.com] On Behalf Of Dan Gora > Sent: Monday, May 21, 2018 7:14 PM > To: Carrillo, Erik G ; Jerin Jacob > > Cc: dev@dpdk.org; Dan Gora > Subject: [PATCH] eventdev: fix resetting software timer > > Fix the call to rte_timer_reset_s

[dpdk-dev] [PATCH v2] net/ixgbe: remove unnecessary macro

2018-05-22 Thread Qi Zhang
Since we move to new offload APIs, IXGBE_SIMPLE_FLAGS is not used. Fixes: 51215925a32f ("net/ixgbe: convert to new Tx offloads API") Signed-off-by: Qi Zhang --- v2: - update document also. doc/guides/nics/ixgbe.rst | 15 ++- drivers/net/ixgbe/ixgbe_rxtx.h | 14 --

  1   2   3   >