[dpdk-dev] [PATCH] bus/fpga: use strlcpy instead of strncpy

2018-05-12 Thread Pablo de Lara
Gcc 8 reports a build error: drivers/bus/ifpga/ifpga_bus.c:161:2: error: ‘strncpy’ specified bound 256 equals destination size [-Werror=stringop-truncation] strncpy(afu_pr_conf.bs_path, path, sizeof(afu_pr_conf.bs_path)); ^~~ Fixes:

[dpdk-dev] [PATCH] net/cxgbe: free resources in dev_uninit function

2018-05-12 Thread Rahul Lakkireddy
Move freeing up resources from dev_close() to dev_uninit(). This fixes NULL pointer de-reference when accessing adapter context needed by other ports under same PF, but had been freed up by the first port. This can happen if only the first port is started up and the check to free up all resources i

Re: [dpdk-dev] [PATCH v6 0/4] Hyper-V netvsc PMD and VMBus support

2018-05-12 Thread Thomas Monjalon
11/05/2018 18:50, Ferruh Yigit: > On 5/9/2018 1:26 AM, Stephen Hemminger wrote: > > Stephen Hemminger (4): > > bus/vmbus: add hyper-v virtual bus support > > net/netvsc: add hyper-v netvsc network device > > net/netvsc: add documentation > > bus/vmbus and net/netvsc: add meson build support

[dpdk-dev] [PATCH] rte_eal_version_map: export rte-strlcpy

2018-05-12 Thread Andy Green
Building dpdk as a shared library on systems without their own native strlcpy (eg, glibc) fails, because we do not allow the explicit export of the helper rte_strlcpy(). It used to be an inline, but it's now a function. Building static, there's no problem but configured to build shared, the users

[dpdk-dev] [PATCH] bus/ifpga: fix strncpy with wrong length with strlcpy

2018-05-12 Thread Andy Green
In function ‘ifpga_scan_one’, inlined from ‘ifpga_scan’ at /home/agreen/projects/ lagopus/src/dpdk/drivers/bus/ifpga/ifpga_bus.c:229:13: /home/agreen/projects/lagopus/src/dpdk/drivers/bus/ifpga/ ifpga_bus.c:161:2: error: ‘strncpy’ specified bound 256 equals destination size [-Werror=stringop-tr

Re: [dpdk-dev] [PATCH] bus/ifpga: fix strncpy with wrong length with strlcpy

2018-05-12 Thread Andy Green
On 05/13/2018 11:24 AM, Andy Green wrote: In function ‘ifpga_scan_one’, inlined from ‘ifpga_scan’ at /home/agreen/projects/ lagopus/src/dpdk/drivers/bus/ifpga/ifpga_bus.c:229:13: /home/agreen/projects/lagopus/src/dpdk/drivers/bus/ifpga/ ifpga_bus.c:161:2: error: ‘strncpy’ specified bound 2

Re: [dpdk-dev] [PATCH 3/4] net/mlx5: solve var may be used uninitialized

2018-05-12 Thread Shahaf Shuler
Hi Andy The patch logic is OK but: 1. since it is a fix patch the title should start with "fix ..." 2. add Fixes tag of the relevant commit and Cc stable if needed 3. add signed-of-by tag 4. explicitly include the PMD maintainers (Cc'ed now). Friday, May 11, 2018 4:51 AM, Andy Green > Subject:

Re: [dpdk-dev] [PATCH 3/4] net/mlx5: solve var may be used uninitialized

2018-05-12 Thread Andy Green
On 05/13/2018 12:45 PM, Shahaf Shuler wrote: Hi Andy The patch logic is OK but: 1. since it is a fix patch the title should start with "fix ..." 2. add Fixes tag of the relevant commit and Cc stable if needed 3. add signed-of-by tag 4. explicitly include the PMD maintainers (Cc'ed now). For

Re: [dpdk-dev] Rx/Tx offloads checks behaviour in 18.05

2018-05-12 Thread Shahaf Shuler
Friday, May 11, 2018 7:09 PM, Andrew Rybchenko: On 05/11/2018 05:22 PM, Ferruh Yigit wrote: I think we have the following options: A. Rollback corresponding changes which remove checks from PMDs (at least some PMDs will be not affected). B. Fail configure if unsupported offload is requ

Re: [dpdk-dev] [PATCH 2/3] ethdev: fail if Tx queue offload is not supported at all

2018-05-12 Thread Shahaf Shuler
--Shahaf > -Original Message- > From: Andrew Rybchenko > Sent: Friday, May 11, 2018 7:26 PM > To: dev@dpdk.org > Cc: Ferruh Yigit ; Thomas Monjalon > ; Shahaf Shuler ; Wei Dai > > Subject: [PATCH 2/3] ethdev: fail if Tx queue offload is not supported at all > > Do not allow to reques

Re: [dpdk-dev] [PATCH v3 1/2] net/mlx4: advertise supported RSS hash functions

2018-05-12 Thread Shahaf Shuler
Thursday, May 10, 2018 5:22 PM, Ophir Munk: @mellanox.com>; Shahaf > Shuler > Subject: [PATCH v3 1/2] net/mlx4: advertise supported RSS hash functions > > Advertise mlx4 supported RSS functions as part of dev_infos_get callback. > Previous to this commit RSS support was reported as none. Since th

Re: [dpdk-dev] [PATCH v3 2/2] net/mlx4: avoid constant recreations in functions

2018-05-12 Thread Shahaf Shuler
Thursday, May 10, 2018 5:22 PM, Ophir Munk: > Subject: [PATCH v3 2/2] net/mlx4: avoid constant recreations in functions > > Functions mlx4_ibv_to_rss_types() and mlx4_conv_rss_types() contain > constant arrays variables which are recreated with every call to the > functions. > By changing the arr

Re: [dpdk-dev] [PATCH v2] net/mlx5: fix inlining segmented TSO packet

2018-05-12 Thread Shahaf Shuler
Friday, May 11, 2018 8:39 PM, Yongseok Koh: > Subject: [PATCH v2] net/mlx5: fix inlining segmented TSO packet > > When a multi-segmented packet is inlined, data can be further inlined even > after the first segment. In case of TSO packet, extra inline data after TSO > header should be carried by a

Re: [dpdk-dev] [PATCH 1/4] net/mlx5: fix offset calculation of Multi-Packet Rx

2018-05-12 Thread Shahaf Shuler
Saturday, May 12, 2018 4:36 AM, Yongseok Koh: > Cc: dev@dpdk.org; Yongseok Koh > Subject: [PATCH 1/4] net/mlx5: fix offset calculation of Multi-Packet Rx > > Offset in a MPRQ buffer must be calculated before updating the stride index. > > Fixes: f0d61f8f8953 ("net/mlx5: add Multi-Packet Rx suppo