[dpdk-dev] [PATCH v2] crypto/mrvl: rename PMD to mvsam

Picking a company stock ticker for a PMD name might not be a best approach in a long run since name is too generic. This patch addresses that and renames mrvl to mvsam. Signed-off-by: Natalie Samsonov Signed-off-by: Tomasz Duszynski --- v2: * fix test-build script * use proper define in test_

Re: [dpdk-dev] [PATCH v7 1/2] mbuf: support attaching external buffer to mbuf

On 04/27/2018 03:01 AM, Yongseok Koh wrote: This patch introduces a new way of attaching an external buffer to a mbuf. Attaching an external buffer is quite similar to mbuf indirection in replacing buffer addresses and length of a mbuf, but a few differences: - When an indirect mbuf is attach

Re: [dpdk-dev] [PATCH v3] net/i40e:fix missing jumbo frame offload capability

> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Yanglong Wu > Sent: Thursday, April 19, 2018 10:19 AM > To: dev@dpdk.org > Cc: Zhang, Qi Z; Dai, Wei; Yao, Lei A; Wu, Yanglong > Subject: [dpdk-dev] [PATCH v3] net/i40e:fix missing jumbo frame offload > capability

[dpdk-dev] [PATCH] net/sfc: add missing case to FW variant mapping on get

Fixes: 7e2dc79b4be7 ("net/sfc: support DPDK firmware variant") Signed-off-by: Andrew Rybchenko Reviewed-by: Ivan Malov --- drivers/net/sfc/sfc.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/net/sfc/sfc.c b/drivers/net/sfc/sfc.c index d1abf62a2..6690053f2 100644 --- a/drivers/

Re: [dpdk-dev] [PATCH v3 4/4] ethdev: Add metadata flow and action items support

Hi Declan, Is there a mapping between maetadata and mbuf field(s), or the lifecycle of metadata supposed to be in middle of flows? There might be another use case that set metadata to a constant, is this covered? Thanks, Xueming > -Original Message- > From: dev On Behalf Of Declan D

Re: [dpdk-dev] [PATCH v7 2/2] app/testpmd: conserve offload flags of mbuf

On 04/27/2018 03:01 AM, Yongseok Koh wrote: This patch is to accommodate an experimental feature of mbuf - external buffer attachment. If mbuf is attached to an external buffer, its ol_flags will have EXT_ATTACHED_MBUF set. Without enabling/using the feature, everything remains same. If PMD deli

[dpdk-dev] [PATCH v2] net/i40e: fix checking offloading fail for Tx

Missing "return -ENOTSUP" will alays leads to illegal offload passing through offload checking. Fixes: 7497d3e2f777 ("net/i40e: convert to new Tx offloads API") Signed-off-by: Yanglong Wu --- v2: rework fix line --- drivers/net/i40e/i40e_rxtx.c | 4 +++- 1 file changed, 3 insertions(+), 1 delet

[dpdk-dev] [PATCH v2] net/i40e: fix missing some offload capabilities

MULTI_SEGS and JUMBO_FRAME offload capability should be exposed both VF and PF since i40e does support it. Fixes: c3ac7c5b0b8a ("net/i40e: convert to new Rx offloads API") Fixes: 7497d3e2f777 ("net/i40e: convert to new Tx offloads API") Signed-off-by: Yanglong Wu --- v2: rework fix line --- driv

Re: [dpdk-dev] [PATCH] net/sfc: add missing case to FW variant mapping on get

On 4/27/2018 8:31 AM, Andrew Rybchenko wrote: > Fixes: 7e2dc79b4be7 ("net/sfc: support DPDK firmware variant") > > Signed-off-by: Andrew Rybchenko > Reviewed-by: Ivan Malov Squashed into relevant commit in next-net, thanks.

Re: [dpdk-dev] [PATCH v4 0/4] lib/rib: Add Routing Information Base library

Hi Stephen, 2018-04-27 1:24 GMT+03:00 Stephen Hemminger : > On Fri, 27 Apr 2018 01:03:30 +0300 > Medvedkin Vladimir wrote: > > > This patch series introduces new library librte_rib which potentially > could > > replace librte_lpm. > > > > RIB is an alternative to current LPM library. > > It sol

Re: [dpdk-dev] [PATCH 0/4] support for write combining

Hello Bruce, As from my last post passed ten days I would kindly ask if there are any more comments? Best regards, Rafal Kozik

Re: [dpdk-dev] [PATCH v2] net/i40e: fix checking offloading fail for Tx

> -Original Message- > From: Wu, Yanglong > Sent: Friday, April 27, 2018 4:14 PM > To: dev@dpdk.org > Cc: Zhang, Helin; Zhang, Qi Z; Dai, Wei; Wu, Yanglong > Subject: [PATCH v2] net/i40e: fix checking offloading fail for Tx > > Missing "return -ENOTSUP" will alays leads to illegal offloa

Re: [dpdk-dev] [PATCH 1/2] crypto/scheduler: set null pointer after freeing

Hi Pablo, On 4/26/2018 8:39 PM, Pablo de Lara wrote: When freeing memory, pointers should be set to NULL, to avoid memory corruption/segmentation faults. Shouldn't this be handled in the rte_free itself. A lot of other driver are also not setting null after rte_free. This would require change

[dpdk-dev] [PATCH 1/1] doc: update doc and release notes for szedata2 driver

New version of the packages with dependencies for the szedata2 driver is needed due to the new API of the libsze2 library which is used in the driver. The documentation and the release notes are updated to contain the information about the required versions. Signed-off-by: Matej Vido Acked-by: Ja

[dpdk-dev] [PATCH] net: fix meson build

librte_net started to use experimental APIs, this explicity allowed by make build system, but not for meson. Fixes: b0aae17c3e4a ("net: export IPv6 header extensions skip function") Cc: didier.pall...@6wind.com Signed-off-by: Ferruh Yigit --- lib/librte_net/meson.build | 1 + 1 file changed, 1

[dpdk-dev] [PATCH] ethdev: fix meson build

kvargs dependency added to ehtdev which is not updated in meson build Fixes: 9d5c2725ed8c ("ethdev: add common devargs parser") Cc: remy.hor...@intel.com Signed-off-by: Ferruh Yigit --- lib/librte_ethdev/meson.build | 2 +- lib/meson.build | 3 +-- 2 files changed, 2 insertions(+)

Re: [dpdk-dev] [PATCH 0/2] fix compilation on FreeBSD

On 04/27/2018 04:43 AM, Thomas Monjalon wrote: The compilation was broken on FreeBSD due to the commit for auxv, implemented only for Linux in the common files. Thomas Monjalon (2): eal: fix build with glibc < 2.16 eal: fix build on FreeBSD lib/librte_eal/bsdapp/eal/Makefile

[dpdk-dev] [PATCH] vhost/crypto: fix build issue with GCC 4.7.2

Build error has been reported by Intel build system: SUSE12SP3_64 / Linux 3.7.10-1 / GCC 4.7.2 lib/librte_vhost/vhost_crypto.c: In function ‘rte_vhost_crypto_set_zero_copy’: lib/librte_vhost/vhost_crypto.c:1192:2: error: comparison of unsigned expression < 0 is always false [-Werror=type-limits]

Re: [dpdk-dev] [PATCH] ethdev: fix meson build

27/04/2018 11:01, Ferruh Yigit: > kvargs dependency added to ehtdev which is not updated in meson build > > Fixes: 9d5c2725ed8c ("ethdev: add common devargs parser") > Cc: remy.hor...@intel.com > > Signed-off-by: Ferruh Yigit Ack I guess you want to squash it in next-net?

Re: [dpdk-dev] [PATCH 0/2] fix compilation on FreeBSD

27/04/2018 11:03, Maxime Coquelin: > > On 04/27/2018 04:43 AM, Thomas Monjalon wrote: > > The compilation was broken on FreeBSD due to the commit > > for auxv, implemented only for Linux in the common files. > > > > Thomas Monjalon (2): > >eal: fix build with glibc < 2.16 > >eal: fix buil

[dpdk-dev] [PATCH] ehdev: fix redundancy in meson file

Meson "name" variable required for the case library name is not same as the library folder, this was the case for ehtdev. After ethdev library folder name updated this field no more required. Fixes: b3238506199f ("ethdev: rename folder to library name") Cc: ferruh.yi...@intel.com Signed-off-by: F

Re: [dpdk-dev] [PATCH] doc: update eal option usage for FreeBSD

On 26-Apr-18 4:48 PM, Reshma Pattan wrote: EAL option -m is supported in FreeBSD, so move it under supported heading from non supported heading. Signed-off-by: Reshma Pattan --- doc/guides/freebsd_gsg/build_sample_apps.rst | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff -

Re: [dpdk-dev] [PATCH] ethdev: fix meson build

On 4/27/2018 10:10 AM, Thomas Monjalon wrote: > 27/04/2018 11:01, Ferruh Yigit: >> kvargs dependency added to ehtdev which is not updated in meson build >> >> Fixes: 9d5c2725ed8c ("ethdev: add common devargs parser") >> Cc: remy.hor...@intel.com >> >> Signed-off-by: Ferruh Yigit > > Ack > I guess

Re: [dpdk-dev] [PATCH] doc: update eal option usage for FreeBSD

> -Original Message- > From: Burakov, Anatoly > Sent: Friday, April 27, 2018 10:21 AM > To: Pattan, Reshma ; Mcnamara, John > ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] doc: update eal option usage for FreeBSD > > On 26-Apr-18 4:48 PM, Reshma Pattan wrote: > > EAL option -m is supp

Re: [dpdk-dev] [PATCH] net: fix meson build

On 4/27/2018 10:01 AM, Ferruh Yigit wrote: > librte_net started to use experimental APIs, this explicity allowed by > make build system, but not for meson. > > Fixes: b0aae17c3e4a ("net: export IPv6 header extensions skip function") > Cc: didier.pall...@6wind.com > > Signed-off-by: Ferruh Yigit

Re: [dpdk-dev] [PATCH] vhost/crypto: fix build issue with GCC 4.7.2

27/04/2018 11:04, Maxime Coquelin: > Build error has been reported by Intel build system: > SUSE12SP3_64 / Linux 3.7.10-1 / GCC 4.7.2 > lib/librte_vhost/vhost_crypto.c: In function ‘rte_vhost_crypto_set_zero_copy’: > lib/librte_vhost/vhost_crypto.c:1192:2: error: comparison of unsigned > expressio

Re: [dpdk-dev] [PATCH] ehdev: fix redundancy in meson file

On 4/27/2018 10:19 AM, Ferruh Yigit wrote: > Meson "name" variable required for the case library name is not same as > the library folder, this was the case for ehtdev. > After ethdev library folder name updated this field no more required. > > Fixes: b3238506199f ("ethdev: rename folder to librar

Re: [dpdk-dev] [PATCH] net/virtio-user: fix hugepage files enumeration

On 26-Apr-18 4:34 PM, Jianfeng Tan wrote: After the commit 2a04139f66b4 ("eal: add single file segments option"), one hugepage file could contain multiple hugepages which are further mapped to different memory regions. Original enumeration implementation cannot handle this situation. This patch

Re: [dpdk-dev] [PATCH v9 09/10] eal: replace rte_panic instances in init sequence

On 04/26/2018 11:08 PM, Arnon Warshavsky wrote: > Hi Kevin > > > + if (rte_config_init() != 0) > > + return -1; > > + > > I'm confused, is this deliberate? there is now two rte_config_init() > calls. > > > Please note that there are 2 eal.c files. One under

Re: [dpdk-dev] [PATCH v9 10/10] devtools: prevent new instances of rte_panic and rte_exit

On 04/26/2018 10:57 PM, Arnon Warshavsky wrote: > > > On Thu, Apr 26, 2018 at 7:08 PM, Kevin Traynor > wrote: > > I think the first line of the commit msg ^^^ should change as it no > longer prevents but just warns > > Actually the return value did not chang

Re: [dpdk-dev] [PATCH v7 01/11] crypto/dpaa: replace rte_panic instances in crypto/dpaa driver

On 04/26/2018 10:28 PM, Arnon Warshavsky wrote: > > > - if (cryptodev->data->dev_private == NULL) > > - rte_panic("Cannot allocate memzone for private " > > - "device data"); > > + if (cryptodev->data->dev_pr

Re: [dpdk-dev] [PATCH 0/4] support for write combining

On Fri, Apr 27, 2018 at 10:27:02AM +0200, Rafał Kozik wrote: > Hello Bruce, > > As from my last post passed ten days I would kindly ask if there are > any more comments? > > Best regards, > Rafal Kozik Hi Rafal, sorry for not responding before. The set makes a lot more sense to me now. However,

Re: [dpdk-dev] [PATCH 1/2] crypto/scheduler: set null pointer after freeing

Hi Akhil, > -Original Message- > From: Akhil Goyal [mailto:akhil.go...@nxp.com] > Sent: Friday, April 27, 2018 9:47 AM > To: De Lara Guarch, Pablo ; Zhang, Roy Fan > > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 1/2] crypto/scheduler: set null pointer after > freein

Re: [dpdk-dev] [PATCH 1/2] crypto/scheduler: set null pointer after freeing

Hi Pablo, On 4/27/2018 5:06 PM, De Lara Guarch, Pablo wrote: Hi Akhil, -Original Message- From: Akhil Goyal [mailto:akhil.go...@nxp.com] Sent: Friday, April 27, 2018 9:47 AM To: De Lara Guarch, Pablo ; Zhang, Roy Fan Cc: dev@dpdk.org; sta...@dpdk.org Subject: Re: [dpdk-dev] [PATCH 1/2

Re: [dpdk-dev] [PATCH v7 3/4] ethdev: add mark flow item to rte_flow_item_types

On 4/26/2018 7:52 PM, Thomas Monjalon wrote: > 26/04/2018 19:29, Declan Doherty: >> Introduces a new action type RTE_FLOW_ITEM_TYPE_MARK which enables >> flow patterns to specify arbitrary integer values to match aginst >> set by the RTE_FLOW_ACTION_TYPE_MARK action in previously matched >> flows.

Re: [dpdk-dev] [PATCH v7 4/4] ethdev: add shared counter support to rte_flow

On 4/26/2018 7:55 PM, Thomas Monjalon wrote: > 26/04/2018 19:29, Declan Doherty: >> Add rte_flow_action_count action data structure to enable shared >> counters across multiple flows on a single port or across multiple >> flows on multiple ports within the same switch domain. Also this enables >> m

Re: [dpdk-dev] [PATCH v7 2/4] ethdev: Add group JUMP action

On 4/26/2018 7:54 PM, Thomas Monjalon wrote: > About title, we use uppercase only for acronyms. > So it should be: > ethdev: add group jump action Updated on next-net.

Re: [dpdk-dev] [PATCH 1/2] crypto/scheduler: set null pointer after freeing

> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Akhil Goyal > Sent: Friday, April 27, 2018 12:59 PM > To: De Lara Guarch, Pablo ; Akhil Goyal > ; Zhang, Roy Fan > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 1/2] crypto/scheduler: set null pointer after > freeing > >

[dpdk-dev] [PATCH v2] doc: update eal option usage for FreeBSD

EAL option -m is supported in FreeBSD, so move it under supported heading from non supported heading. Signed-off-by: Reshma Pattan --- v2: remove recommendation of socket-mem option. --- doc/guides/freebsd_gsg/build_sample_apps.rst | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) di

Re: [dpdk-dev] [PATCH 1/2] crypto/scheduler: set null pointer after freeing

On Fri, Apr 27, 2018 at 12:37:08PM +, Van Haaren, Harry wrote: > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Akhil Goyal > > Sent: Friday, April 27, 2018 12:59 PM > > To: De Lara Guarch, Pablo ; Akhil Goyal > > ; Zhang, Roy Fan > > Cc: dev@dpdk.org; sta...@dpdk.org > > Subject: Re:

Re: [dpdk-dev] [PATCH 1/1] doc: update doc and release notes for szedata2 driver

On 4/27/2018 9:57 AM, Matej Vido wrote: > New version of the packages with dependencies for the szedata2 > driver is needed due to the new API of the libsze2 library which > is used in the driver. > The documentation and the release notes are updated to contain > the information about the required

Re: [dpdk-dev] [PATCH v2] doc: update eal option usage for FreeBSD

On 27-Apr-18 1:59 PM, Reshma Pattan wrote: EAL option -m is supported in FreeBSD, so move it under supported heading from non supported heading. Signed-off-by: Reshma Pattan --- v2: remove recommendation of socket-mem option. --- Reviewed-by: Anatoly Burakov -- Thanks, Anatoly

[dpdk-dev] [PATCH] app/test: enhance sanity script

1. Sanity Script is enhanced with additional test cases being added to autotest_data.py 2. Fixed in autotest_test_funcs.py to handle test cases which returns "Skipped" as result. The issue was skipped test cases got timed out, causing delay in sanity script execution. 3. Enhanced support for Free

[dpdk-dev] [PATCH v6 00/14] Implement compression API

With the vast amounts of data being transported around networks and stored in storage systems, reducing data size is becoming ever more important. There are both software libraries and hardware devices available that provide compression, but no common API. Such an API is proposed in this patchset,

[dpdk-dev] [PATCH] devtools: add git log checks for vDPA MSS and UDP

Signed-off-by: Ferruh Yigit --- devtools/check-git-log.sh | 3 +++ 1 file changed, 3 insertions(+) diff --git a/devtools/check-git-log.sh b/devtools/check-git-log.sh index c601f6ae9..2dfa3a1cd 100755 --- a/devtools/check-git-log.sh +++ b/devtools/check-git-log.sh @@ -129,6 +129,7 @@ bad=$(echo "

[dpdk-dev] [PATCH v6 02/14] compressdev: add queue pair management

From: Fiona Trahe Add functions to manage device queue pairs. Signed-off-by: Fiona Trahe Signed-off-by: Pablo de Lara Signed-off-by: Shally Verma Signed-off-by: Ashish Gupta --- lib/librte_compressdev/rte_compressdev.c | 178 - lib/librte_compressdev/rte_compre

[dpdk-dev] [PATCH v6 01/14] compressdev: add basic device management

From: Fiona Trahe Add basic functions to manage compress devices, including driver and device allocation, and the basic interface with compressdev PMDs. Signed-off-by: Fiona Trahe Signed-off-by: Pablo de Lara Signed-off-by: Shally Verma Signed-off-by: Ashish Gupta --- MAINTAINERS

[dpdk-dev] [PATCH v6 04/14] compressdev: add enqueue/dequeue functions

From: Fiona Trahe Signed-off-by: Fiona Trahe Signed-off-by: Pablo de Lara Signed-off-by: Shally Verma Signed-off-by: Ashish Gupta --- lib/librte_compressdev/rte_compressdev.c | 22 + lib/librte_compressdev/rte_compressdev.h | 107 + lib/librte_com

[dpdk-dev] [PATCH v6 03/14] compressdev: add compression specific data

From: Fiona Trahe Added structures and enums specific to compression, including the compression operation structure and the different supported algorithms, checksums and compression levels. Signed-off-by: Fiona Trahe Signed-off-by: Pablo de Lara Signed-off-by: Shally Verma Signed-off-by: Ashi

[dpdk-dev] [PATCH v6 05/14] compressdev: add operation management

From: Fiona Trahe Added functions to allocate and free compression operations. Signed-off-by: Fiona Trahe Signed-off-by: Pablo de Lara Signed-off-by: Shally Verma Signed-off-by: Ashish Gupta --- lib/librte_compressdev/Makefile| 2 +- lib/librte_compressdev/meson.build

[dpdk-dev] [PATCH v6 06/14] compressdev: support stateless operations

From: Fiona Trahe Added private transform data (priv_xform) in compression operation, which will contain the private data from each PMD to support stateless operations. Also, added functions to create/free this data. Signed-off-by: Fiona Trahe Signed-off-by: Pablo de Lara Signed-off-by: Shally

[dpdk-dev] [PATCH v6 07/14] compressdev: support stateful operations

From: Fiona Trahe Added stream data (stream) in compression operation, which will contain the private data from each PMD to support stateful operations. Also, added functions to create/free this data. Signed-off-by: Fiona Trahe Signed-off-by: Pablo de Lara Signed-off-by: Shally Verma Signed-o

[dpdk-dev] [PATCH v6 08/14] compressdev: support hash operations

From: Shally Verma - Added hash algo enumeration and params in xform and rte_comp_op - Updated compress/decompress xform to input hash algorithm - Updated struct rte_comp_op to input hash buffer User in capability query will know about support hashes via device info comp_feature_flag. If support

[dpdk-dev] [PATCH v6 09/14] compressdev: add device feature flags

From: Fiona Trahe Signed-off-by: Fiona Trahe Signed-off-by: Pablo de Lara Signed-off-by: Shally Verma Signed-off-by: Ashish Gupta --- lib/librte_compressdev/rte_compressdev.c | 21 ++ lib/librte_compressdev/rte_compressdev.h | 33 ++ lib/li

[dpdk-dev] [PATCH v6 10/14] compressdev: add compression service feature flags

From: Fiona Trahe Signed-off-by: Fiona Trahe Signed-off-by: Pablo de Lara Signed-off-by: Shally Verma Signed-off-by: Ashish Gupta --- lib/librte_compressdev/rte_comp.c | 31 +++ lib/librte_compressdev/rte_comp.h | 46 ++ lib/l

[dpdk-dev] [PATCH v6 11/14] compressdev: add device stats

From: Fiona Trahe Signed-off-by: Fiona Trahe Signed-off-by: Pablo de Lara Signed-off-by: Shally Verma Signed-off-by: Ashish Gupta --- lib/librte_compressdev/rte_compressdev.c | 40 ++ lib/librte_compressdev/rte_compressdev.h | 39 +

[dpdk-dev] [PATCH v6 12/14] compressdev: add device capabilities

From: Fiona Trahe Added structure which each PMD will fill out, providing the capabilities of each driver (containing mainly which compression services it supports). Signed-off-by: Fiona Trahe Signed-off-by: Pablo de Lara Signed-off-by: Shally Verma Signed-off-by: Ashish Gupta --- lib/librt

[dpdk-dev] [PATCH v6 13/14] compressdev: get device id from name

From: Fiona Trahe Added API to retrieve the device id provided the device name. Signed-off-by: Fiona Trahe Signed-off-by: Pablo de Lara Signed-off-by: Shally Verma Signed-off-by: Ashish Gupta --- lib/librte_compressdev/rte_compressdev.c | 18 ++ lib/librte_compress

[dpdk-dev] [PATCH v6 14/14] doc: add compressdev library guide

From: Ashish Gupta Add section in programmer’s guide for Compressdev library. Signed-off-by: Shally Verma Signed-off-by: Sunila Sahu Signed-off-by: Ashish Gupta --- MAINTAINERS | 1 + doc/guides/prog_guide/compressdev_lib.rst | 623

Re: [dpdk-dev] [PATCH] app/test: enhance sanity script

On 27-Apr-18 2:20 PM, Reshma Pattan wrote: 1. Sanity Script is enhanced with additional test cases being added to autotest_data.py 2. Fixed in autotest_test_funcs.py to handle test cases which returns "Skipped" as result. The issue was skipped test cases got timed out, causing delay in sanity

[dpdk-dev] [PATCH v2] devtools: add git log checks for acronyms

checks added for vDPA, MSS, UDP, EEPROM Signed-off-by: Ferruh Yigit --- v2: * Add more checks: eeprom --- devtools/check-git-log.sh | 4 1 file changed, 4 insertions(+) diff --git a/devtools/check-git-log.sh b/devtools/check-git-log.sh index c601f6ae9..c8c149685 100755 --- a/devtools/check

[dpdk-dev] [PATCH v2 1/3] build: fix kernel compile on cross-build

When cross-compiling, if no kernel_dir was specified, then the kernel modules were still being compiled for the build machine. Fix this by only building modules on cross-compile when we have a kernel_dir value set. Print out a message indicating why we are skipping kernel compilation, and in case t

[dpdk-dev] [PATCH v2 0/3] small improvements to meson build

A few small improvements and fixes for the meson build system, including improved behaviour for building kmods - especially on cross-compile, a fix for our libbsd detect on CentOS 7, and a small change to ensure compatibility with future meson versions. Bruce Richardson (3): build: fix kernel co

[dpdk-dev] [PATCH v2 3/3] build: ensure compatibility with future meson versions

Meson 0.46 fixed a bug where "extract_all_objects" would not recursively extract objects not compiled from source for a target. To keep backward compatibility, a "recursive" keyword-arg was added to make this optional. The value is "false" by default for now, but will change to "true" in future, so

[dpdk-dev] [PATCH v2 2/3] build: fix check for libbsd in meson

When we check for libbsd we were just checking for the library itself. However, on some distros, e.g. CentOS, libbsd will be found even though it's not usable by DPDK as it's missing the string header. Therefore we should check for both the library and the header file. Fixes: 5364de644a4b ("eal: s

Re: [dpdk-dev] [PATCH v2 2/3] build: fix check for libbsd in meson

On Fri, Apr 27, 2018 at 02:49:27PM +0100, Bruce Richardson wrote: > When we check for libbsd we were just checking for the library itself. > However, on some distros, e.g. CentOS, libbsd will be found even though > it's not usable by DPDK as it's missing the string header. Therefore we > should che

Re: [dpdk-dev] [PATCH] app/test: enhance sanity script

On 27-Apr-18 2:20 PM, Reshma Pattan wrote: 1. Sanity Script is enhanced with additional test cases being added to autotest_data.py 2. Fixed in autotest_test_funcs.py to handle test cases which returns "Skipped" as result. The issue was skipped test cases got timed out, causing delay in sanity

[dpdk-dev] [PATCH] vhost/crypto: fix missing head correction

Fixes: 473387aaae4a ("vhost/crypto: move to safe GPA translation API") This patch fixes the missing head descriptor correction for indirect descriptors. Signed-off-by: Fan Zhang --- lib/librte_vhost/vhost_crypto.c | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/librte_vhost/vhost_crypto

[dpdk-dev] [PATCH] vhost/crypto: fix condition check

Fixes: 3bb595ecd682 ("vhost/crypto: add request handler") This patch fix final condition check while moving virtqueue descriptors. Signed-off-by: Fan Zhang --- lib/librte_vhost/vhost_crypto.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/librte_vhost/vhost_crypto.c

[dpdk-dev] [PATCH v3 0/5] Initial compressdev unit tests

Added initial tests for Compressdev library. The tests are performed compressing a test buffer (or multiple test buffers) with compressdev or Zlib, and decompressing it/them with the other library (if compression is done with compressdev, decompression is done with Zlib, and viceversa). Tests adde

[dpdk-dev] [PATCH v3 1/5] test/compress: add initial unit tests

This commit introduces the initial tests for compressdev, performing basic compression and decompression operations of sample test buffers, using the Zlib library in one direction and compressdev in another direction, to make sure that the library is compatible with Zlib. Due to the use of Zlib AP

[dpdk-dev] [PATCH v3 2/5] test/compress: add multi op test

Add test that checks if multiple operations with different buffers can be handled on a single enqueue call. Signed-off-by: Pablo de Lara --- test/test/test_compressdev.c | 476 +-- 1 file changed, 319 insertions(+), 157 deletions(-) diff --git a/test/test

[dpdk-dev] [PATCH v3 4/5] test/compress: add multi xform test

Add test that checks if multiple xforms can be handled on a single enqueue call. Signed-off-by: Pablo de Lara --- test/test/test_compressdev.c | 257 --- 1 file changed, 191 insertions(+), 66 deletions(-) diff --git a/test/test/test_compressdev.c b/test/t

[dpdk-dev] [PATCH v3 5/5] test/compress: add invalid configuration tests

Add tests that check if device configuration is not successful when providing invalid parameters. Signed-off-by: Pablo de Lara --- test/test/test_compressdev.c | 49 +++- 1 file changed, 48 insertions(+), 1 deletion(-) diff --git a/test/test/test_compress

[dpdk-dev] [PATCH v3 3/5] test/compress: add multi level test

Add test that checks if all compression levels are supported and compress a buffer correctly. Signed-off-by: Pablo de Lara --- test/test/test_compressdev.c | 33 + 1 file changed, 33 insertions(+) diff --git a/test/test/test_compressdev.c b/test/test/test_compres

[dpdk-dev] [PATCH v2 1/2] bus/pci: fix find device implementation

If start is set, and a device before it matches the data passed for comparison, then this first device is returned. This induces potentially infinite loops. Fixes: c7fe1eea8a74 ("bus: simplify finding starting point") Cc: sta...@dpdk.org Signed-off-by: Gaetan Rivet --- drivers/bus/pci/pci_comm

[dpdk-dev] [PATCH v2 2/2] bus/vdev: fix find device implementation

If start is set and a device before it matches the data, this device is returned. This induces potentially infinite loops. Fixes: c7fe1eea8a74 ("bus: simplify finding starting point") Cc: sta...@dpdk.org Signed-off-by: Gaetan Rivet --- drivers/bus/vdev/rte_bus_vdev.h | 3 +++ drivers/bus/vdev

[dpdk-dev] [PATCH v2 0/2] Bus find_device fixes

These patches are extracted from the device querying series [1] for earlier integration. [1]: https://dpdk.org/ml/archives/dev/2018-March/092891.html v2: * Rebase on master Gaetan Rivet (2): bus/pci: fix find device implementation bus/vdev: fix find device implementation drivers/bus/pci

Re: [dpdk-dev] [PATCH] vhost/crypto: fix missing head correction

Hi Fan, On 04/27/2018 03:52 PM, Fan Zhang wrote: Fixes: 473387aaae4a ("vhost/crypto: move to safe GPA translation API") This patch fixes the missing head descriptor correction for indirect descriptors. Signed-off-by: Fan Zhang --- lib/librte_vhost/vhost_crypto.c | 1 + 1 file changed, 1 in

[dpdk-dev] [PATCH] net/vhost: Initialise vid to -1

rte_eth_vhost_get_vid_from_port_id returns a value of 0 if called before the first call to the new_device callback. A vid value >=0 suggests the device is active which is not the case in this instance. Initialise vid to a negative value to prevent this. Signed-off-by: Ciara Loftus --- drivers/ne

Re: [dpdk-dev] [PATCH] vhost/crypto: fix condition check

On 04/27/2018 04:06 PM, Fan Zhang wrote: Fixes: 3bb595ecd682 ("vhost/crypto: add request handler") This patch fix final condition check while moving virtqueue descriptors. Signed-off-by: Fan Zhang --- lib/librte_vhost/vhost_crypto.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-

Re: [dpdk-dev] [PATCH] vhost/crypto: fix missing head correction

Hi Maxime, No problem. I will work on it. Regards, Fan > -Original Message- > From: Maxime Coquelin [mailto:maxime.coque...@redhat.com] > Sent: Friday, April 27, 2018 3:19 PM > To: Zhang, Roy Fan ; dev@dpdk.org > Cc: Yigit, Ferruh > Subject: Re: [PATCH] vhost/crypto: fix missing head co

Re: [dpdk-dev] [PATCH v9 00/10] eal: replace calls to rte_panic and refrain from new instances

26/04/2018 08:20, Arnon Warshavsky: > The purpose of this patch series is to cleanup the library code > from paths that end up aborting the process, > and move to checking error values, in order to allow the running process > perform an orderly teardown or other mitigation of the event. > > This p

Re: [dpdk-dev] [PATCH v9 00/10] eal: replace calls to rte_panic and refrain from new instances

26/04/2018 08:20, Arnon Warshavsky: > v8: > - Seperate the 2 drivers salad back to distinct bond and dpaa patches > - Add missing file descriptor closing when returnning an error > - Remove half baked thread patch to be handled in the next version > - Remove duplicate function call after rebase Yo

Re: [dpdk-dev] [PATCH] Revert "vhost: avoid concurrency when logging dirty pages"

On 4/20/2018 9:39 AM, Maxime Coquelin wrote: > This reverts commit 394313fff39d0f994325c47f7eab39daf5dc9e11. > > While the patch did solve concurrency issue, it induces more > pages copies as some clean pages are marked as dirty for > performance reasons. Moreover, as there is no more contention >

Re: [dpdk-dev] [PATCH v2 0/2] Bus find_device fixes

> Gaetan Rivet (2): > bus/pci: fix find device implementation > bus/vdev: fix find device implementation Applied, thanks

Re: [dpdk-dev] [PATCH] net/vhost: Initialise vid to -1

On 04/27/2018 04:19 PM, Ciara Loftus wrote: rte_eth_vhost_get_vid_from_port_id returns a value of 0 if called before the first call to the new_device callback. A vid value >=0 suggests the device is active which is not the case in this instance. Initialise vid to a negative value to prevent thi

Re: [dpdk-dev] [PATCH v2 0/3] small improvements to meson build

On Fri, 2018-04-27 at 14:49 +0100, Bruce Richardson wrote: > A few small improvements and fixes for the meson build system, > including > improved behaviour for building kmods - especially on cross-compile, > a fix > for our libbsd detect on CentOS 7, and a small change to ensure > compatibility >

Re: [dpdk-dev] [PATCH v7 4/4] ethdev: add shared counter support to rte_flow

On 4/27/2018 1:25 PM, Ferruh Yigit wrote: > On 4/26/2018 7:55 PM, Thomas Monjalon wrote: >> 26/04/2018 19:29, Declan Doherty: >>> Add rte_flow_action_count action data structure to enable shared >>> counters across multiple flows on a single port or across multiple >>> flows on multiple ports withi

Re: [dpdk-dev] [PATCH] vhost: fix vDPA set features

On 4/26/2018 9:07 AM, Maxime Coquelin wrote: > > > On 04/25/2018 04:18 AM, Xiao Wang wrote: >> We should call set_features callback after setting features in virtio_net >> structure, otherwise vDPA driver cannot get the right features. >> >> Fixes: 07718b4f87aa ("vhost: adapt library for selectiv

Re: [dpdk-dev] [PATCH v3 1/9] mem: use strlcpy instead of snprintf

On Wed, Apr 25, 2018 at 10:56:39AM +0100, Anatoly Burakov wrote: > Signed-off-by: Anatoly Burakov > --- > Acked-by: Bruce Richardson

Re: [dpdk-dev] [PATCH v3 2/9] mem: fix resource leak

On Wed, Apr 25, 2018 at 10:56:40AM +0100, Anatoly Burakov wrote: > Coverity issue: 272601 > > Fixes: 66cc45e293ed ("mem: replace memseg with memseg lists") > Cc: anatoly.bura...@intel.com > > Signed-off-by: Anatoly Burakov > --- Acked-by: Bruce Richardson

Re: [dpdk-dev] [PATCH v3 3/9] mem: fix potential double close

On Wed, Apr 25, 2018 at 10:56:41AM +0100, Anatoly Burakov wrote: > We were closing descriptor before checking if mapping has > failed, but if it did, we did a second close afterwards. Fix > it by moving closing descriptor to after we check if mmap has > succeeded. > > Coverity issue: 272560 > > F

[dpdk-dev] [PATCH] lib: clear experimental version tag in linker scripts

Remove version tag from experimental block in linker version scripts (.map files). That label is not used by linker and information only. It is useful for version blocks but not useful for experimental block but confusing. Removing those labels. Signed-off-by: Ferruh Yigit --- Cc: Neil Horman C

Re: [dpdk-dev] [PATCH v3 4/9] mem: fix potential resource leak

On Wed, Apr 25, 2018 at 10:56:42AM +0100, Anatoly Burakov wrote: > We close fd if we managed to find it in the list of allocated > segment lists (which should always be the case under normal > conditions), but if we didn't, the fd was leaking. Close it if > we couldn't find it in the segment list.

[dpdk-dev] [PATCH 3/3] vhost: fix typo in fdset_event_dispatch comment

From: Tonghao Zhang Signed-off-by: Tonghao Zhang --- lib/librte_vhost/fd_man.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_vhost/fd_man.c b/lib/librte_vhost/fd_man.c index b24c27d..38347ab 100644 --- a/lib/librte_vhost/fd_man.c +++ b/lib/librte_vhost/fd_man.c

[dpdk-dev] [PATCH 1/3] vhost: fix deadlock due to vhostuser socket and fdset

From: Tonghao Zhang When qemu close the unix socket fd of the vhostuser as a server, and then immediately delete the vhostuser port on openvswitch. There will be a deadlock. A thread (fdset event thread): B thread: 1. fdset_event_dispatch rte_vhost_driver_unregister 2. set the

[dpdk-dev] [PATCH 2/3] vhost: fix crash and fd leak due to vhostuser destroyed

From: Tonghao Zhang when rte_vhost_driver_unregister detstroy the vsocket, we should set it to NULL after freeing it, because in client mode, the conn may be added to reconnect thread while vsocket is destroyed. In one case, if qemu create vhostuser port as a server with the same unix path, the r

Re: [dpdk-dev] [PATCH v3 5/9] mem: fix potential resource leak

On Wed, Apr 25, 2018 at 10:56:43AM +0100, Anatoly Burakov wrote: > Normally, tailq entry should have a valid fd by the time we attempt > to map the segment. However, in case it doesn't, we're leaking fd, > so fix it. > > Coverity issue: 272570 > > Fixes: 2a04139f66b4 ("eal: add single file segmen

Re: [dpdk-dev] [PATCH v3 6/9] mem: fix comparing pointer to value

On Wed, Apr 25, 2018 at 10:56:44AM +0100, Anatoly Burakov wrote: > Previous code had an old rebase leftover from the time when > oldpolicy was an actual int, instead of a pointer. Fix it to > do comparison with dereferencing the pointer. > > Coverity issue: 272589 > > Fixes: 582bed1e1d1d ("mem: s

  1   2   3   >