Re: [dpdk-dev] [PATCH 5/8] bus/dpaa: fix resource leak

2018-04-09 Thread Shreyansh Jain
On Thursday 05 April 2018 02:24 PM, Hemant Agrawal wrote: Fixes: 1459585888b5 ("bus/dpaa: fix memory allocation during scan") Coverity issue: 268337 Cc: sta...@dpdk.org Signed-off-by: Hemant Agrawal --- Acked-By: Shreyansh Jain

Re: [dpdk-dev] [PATCH 4/8] net/dpaa: fix the oob access

2018-04-09 Thread Shreyansh Jain
On Thursday 05 April 2018 02:24 PM, Hemant Agrawal wrote: Fixes: b21ed3e2a16d ("net/dpaa: support extended statistics") Coverity issue: 268318 Cc: sta...@dpdk.org Signed-off-by: Hemant Agrawal --- drivers/net/dpaa/dpaa_ethdev.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff

Re: [dpdk-dev] [PATCH] net/i40e: fix flow RSS queue index check error

2018-04-09 Thread Zhang, Qi Z
> -Original Message- > From: Zhao1, Wei > Sent: Sunday, April 8, 2018 1:37 PM > To: dev@dpdk.org; sta...@dpdk.org > Cc: Zhang, Qi Z ; Zhao1, Wei > Subject: [PATCH] net/i40e: fix flow RSS queue index check error > > Ther is a error in queue index check for RSS queue region configuration.

Re: [dpdk-dev] [PATCH v2 0/4] NFP PF support based on new CPP interface

2018-04-09 Thread Alejandro Lucero
On Fri, Apr 6, 2018 at 4:47 PM, Ferruh Yigit wrote: > On 4/6/2018 3:44 PM, Ferruh Yigit wrote: > > On 4/5/2018 3:42 PM, Alejandro Lucero wrote: > >> NFP PMD PF support requires to access the NFP chip for initialization. > >> Current NFP PMD PF support was added based on the NSPU interface. This >

Re: [dpdk-dev] [PATCH v4 10/20] eal/dev: implement device iteration

2018-04-09 Thread Matan Azrad
HI Gaetan From: Gaetan Rivet, Friday, March 30, 2018 12:24 AM > +/* '\0' forbidden in sym */ > +static const char * > +strfirstof(const char *str, > +const char *sym) > +{ > + const char *s; > + > + for (s = str; s[0] != '\0'; s++) { > + const char *c; > + > +

Re: [dpdk-dev] [PATCH] bus/fslmc: support for hotplugging of memory

2018-04-09 Thread Shreyansh Jain
Hello Anatoly, On Sunday 08 April 2018 10:44 PM, Burakov, Anatoly wrote: On 05-Apr-18 3:14 PM, Shreyansh Jain wrote: Restructure VFIO DMA code for handling hotplug memory events (callbacks) and --legacy case. Signed-off-by: Shreyansh Jain --- ### This is based on the 16fbfef04a3 github repos

Re: [dpdk-dev] [PATCH] net/i40e: add comment for flow RSS parse function

2018-04-09 Thread Zhang, Qi Z
No need separate patch, please merge this with another patch for queue index check since they are related. And please Cc sta...@dpdk.org in commit for a fix for previous release. Regards Qi > -Original Message- > From: Zhao1, Wei > Sent: Monday, April 9, 2018 2:19 PM > To: dev@dpdk.org

Re: [dpdk-dev] [PATCH v4 18/20] ethdev: register ether layer as a class

2018-04-09 Thread Matan Azrad
Hi Gaetan From: Gaetan Rivet, Friday, March 30, 2018 12:24 AM > Signed-off-by: Gaetan Rivet > --- > lib/Makefile | 2 +- > lib/librte_ether/Makefile| 3 +- > lib/librte_ether/rte_class_eth.c | 73 > > 3 files changed, 76 inse

Re: [dpdk-dev] [PATCH v4 18/20] ethdev: register ether layer as a class

2018-04-09 Thread Gaëtan Rivet
Hi Matan, On Mon, Apr 09, 2018 at 07:41:58AM +, Matan Azrad wrote: > Hi Gaetan > > From: Gaetan Rivet, Friday, March 30, 2018 12:24 AM > > Signed-off-by: Gaetan Rivet > > --- > > lib/Makefile | 2 +- > > lib/librte_ether/Makefile| 3 +- > > lib/librte_ether/rte

Re: [dpdk-dev] [PATCH v4 18/20] ethdev: register ether layer as a class

2018-04-09 Thread Matan Azrad
Hi Gaetan From: Gaëtan Rivet, Monday, April 9, 2018 10:47 AM > Hi Matan, > > On Mon, Apr 09, 2018 at 07:41:58AM +, Matan Azrad wrote: > > Hi Gaetan > > > > From: Gaetan Rivet, Friday, March 30, 2018 12:24 AM > > > Signed-off-by: Gaetan Rivet > > > --- > > > lib/Makefile

Re: [dpdk-dev] [PATCH v4 18/20] ethdev: register ether layer as a class

2018-04-09 Thread Gaëtan Rivet
On Mon, Apr 09, 2018 at 07:58:08AM +, Matan Azrad wrote: > Hi Gaetan > > From: Gaëtan Rivet, Monday, April 9, 2018 10:47 AM > > Hi Matan, > > > > On Mon, Apr 09, 2018 at 07:41:58AM +, Matan Azrad wrote: > > > Hi Gaetan > > > > > > From: Gaetan Rivet, Friday, March 30, 2018 12:24 AM > > >

Re: [dpdk-dev] [PATCH v4 10/20] eal/dev: implement device iteration

2018-04-09 Thread Gaëtan Rivet
On Mon, Apr 09, 2018 at 07:28:00AM +, Matan Azrad wrote: > HI Gaetan > > From: Gaetan Rivet, Friday, March 30, 2018 12:24 AM > > +/* '\0' forbidden in sym */ > > +static const char * > > +strfirstof(const char *str, > > + const char *sym) > > +{ > > + const char *s; > > + > > + for (s

Re: [dpdk-dev] [PATCH] net/mlx5: fix link status initialization

2018-04-09 Thread Nélio Laranjeiro
On Sun, Apr 08, 2018 at 01:09:27PM +, Shahaf Shuler wrote: > Thursday, April 5, 2018 9:51 AM, Nélio Laranjeiro: > > Subject: Re: [PATCH] net/mlx5: fix link status initialization > > > > On Thu, Apr 05, 2018 at 05:35:57AM +, Shahaf Shuler wrote: > > > Wednesday, April 4, 2018 3:11 PM, Nélio

Re: [dpdk-dev] [PATCH] doc: fix a typo

2018-04-09 Thread Kovacevic, Marko
> Signed-off-by: Jerin Jacob > --- > doc/guides/prog_guide/rawdev.rst | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Acked-by: Marko Kovacevic

[dpdk-dev] [PATCH v2] net/i40e: fix flow RSS queue index check error

2018-04-09 Thread Wei Zhao
There is an error in queue index check for RSS queue region configuration.If the queue index is not continuous sequence for RSS, but queue region index is continuous sequence, in this case we can not use the old method for queue index check. This patch also add comment for flow rss parse function i

Re: [dpdk-dev] [PATCH] ethdev: return diagnostic when setting MAC address

2018-04-09 Thread Nélio Laranjeiro
On Fri, Apr 06, 2018 at 05:21:48PM +0200, Olivier Matz wrote: > Change the prototype and the behavior of dev_ops->eth_mac_addr_set(): a > return code is added to notify the caller (librte_ether) if an error > occurred in the PMD. > > The new default MAC address is now copied in dev->data->mac_addr

[dpdk-dev] [PATCH] net/vmxnet3: change the SPDX tag style

2018-04-09 Thread Hemant Agrawal
Cc: skh...@vmware.com Signed-off-by: Hemant Agrawal --- drivers/net/vmxnet3/base/upt1_defs.h| 7 ++- drivers/net/vmxnet3/base/vmxnet3_defs.h | 7 ++- 2 files changed, 4 insertions(+), 10 deletions(-) diff --git a/drivers/net/vmxnet3/base/upt1_defs.h b/drivers/net/vmxnet3/base/upt1_

[dpdk-dev] [PATCH] test/crypto-perf: add missing SPDX identifier

2018-04-09 Thread Hemant Agrawal
Cc: pablo.de.lara.gua...@intel.com Signed-off-by: Hemant Agrawal --- app/test-crypto-perf/cperf_options.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/app/test-crypto-perf/cperf_options.h b/app/test-crypto-perf/cperf_options.h index 54a3ad5..350ad7e 100644 --- a/app/test-crypto-perf/c

[dpdk-dev] [PATCH] eal: add missing SPDX identifiers

2018-04-09 Thread Hemant Agrawal
Cc: roman.dement...@intel.com Cc: vikto...@rehivetech.com Signed-off-by: Hemant Agrawal --- lib/librte_eal/common/include/arch/arm/rte_rwlock.h| 2 ++ lib/librte_eal/common/include/arch/ppc_64/rte_rwlock.h | 2 ++ 2 files changed, 4 insertions(+) diff --git a/lib/librte_eal/common/include/a

[dpdk-dev] [PATCH] usertools: add missing SPDX identifier

2018-04-09 Thread Hemant Agrawal
CC: nhor...@tuxdriver.com Signed-off-by: Hemant Agrawal --- usertools/dpdk-pmdinfo.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/usertools/dpdk-pmdinfo.py b/usertools/dpdk-pmdinfo.py index 46c1be0..03623d5 100755 --- a/usertools/dpdk-pmdinfo.py +++ b/usertools/dpdk-pmdinfo.py @@ -1,4 +

[dpdk-dev] [PATCH] usertools: change to SPDX license identifier

2018-04-09 Thread Hemant Agrawal
Cc: jerin.ja...@caviumnetworks.com Signed-off-by: Hemant Agrawal --- usertools/cpu_layout.py | 36 +++- 1 file changed, 3 insertions(+), 33 deletions(-) diff --git a/usertools/cpu_layout.py b/usertools/cpu_layout.py index d3c8eba..6f129b1 100755 --- a/usertools/c

[dpdk-dev] [PATCH] pkg: change to SPDX license identifier

2018-04-09 Thread Hemant Agrawal
Cc: olivier.m...@6wind.com Cc: tho...@monjalon.net Signed-off-by: Hemant Agrawal --- pkg/dpdk.spec | 30 +- 1 file changed, 1 insertion(+), 29 deletions(-) diff --git a/pkg/dpdk.spec b/pkg/dpdk.spec index 4d3b574..23dec98 100644 --- a/pkg/dpdk.spec +++ b/pkg/dpdk.spe

[dpdk-dev] [PATCH] kernel: add missing SPDX license identifier

2018-04-09 Thread Hemant Agrawal
Cc: jm...@redhat.com Cc: step...@networkplumber.org Signed-off-by: Hemant Agrawal --- kernel/linux/igb_uio/compat.h | 1 + kernel/linux/kni/compat.h | 1 + 2 files changed, 2 insertions(+) diff --git a/kernel/linux/igb_uio/compat.h b/kernel/linux/igb_uio/compat.h index ce456d4..f9adc7d 1006

Re: [dpdk-dev] [PATCH] usertools: change to SPDX license identifier

2018-04-09 Thread Jerin Jacob
-Original Message- > Date: Mon, 9 Apr 2018 14:28:37 +0530 > From: Hemant Agrawal > To: dev@dpdk.org > CC: jerin.ja...@caviumnetworks.com, Hemant Agrawal > Subject: [PATCH] usertools: change to SPDX license identifier > X-Mailer: git-send-email 2.7.4 > > Cc: jerin.ja...@caviumnetworks.co

Re: [dpdk-dev] [PATCH v4 66/70] bus/fslmc: enable support for mem event callbacks for vfio

2018-04-09 Thread Shreyansh Jain
Hi Anatoly, On Monday 09 April 2018 01:48 AM, Anatoly Burakov wrote: VFIO needs to map and unmap segments for DMA whenever they become available or unavailable, so register a callback for memory events, and provide map/unmap functions. Signed-off-by: Shreyansh Jain Signed-off-by: Anatoly Burak

[dpdk-dev] [dpdk-announce] 2018 DPDK PRC Summit --- Beijing Jun 28th----Call for proposal

2018-04-09 Thread Xu, Qian Q
2018 DPDK PRC Summit will take place in the China National Convention Center, Beijing on June 28th. The agenda will cover the latest developments to the DPDK and other related projects such as FD.io, Lagopus, OVS, DPVS, Tungsten Fabric and SPDK, including plans for future releases, and will prov

[dpdk-dev] [dpdk-announce] Date for DPDK Summit Userspace

2018-04-09 Thread O'Driscoll, Tim
This year's Userspace event will take place on September 5th and 6th. The venue will be the same as for the last 2 years - The Clayton Hotel, Ballsbridge, Dublin (https://www.claytonhotelballsbridge.com/). Details on registration and CFP will be provided closer to the time. For now, I just want

Re: [dpdk-dev] [PATCH] usertools: add missing SPDX identifier

2018-04-09 Thread Neil Horman
On Mon, Apr 09, 2018 at 02:28:36PM +0530, Hemant Agrawal wrote: > CC: nhor...@tuxdriver.com > Signed-off-by: Hemant Agrawal > --- > usertools/dpdk-pmdinfo.py | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/usertools/dpdk-pmdinfo.py b/usertools/dpdk-pmdinfo.py > index 46c1be0..03623d5

[dpdk-dev] [PATCH v2 3/8] net/dpaa: fix the array overrun

2018-04-09 Thread Hemant Agrawal
Fixes: 62f53995caaf ("net/dpaa: add frame count based tail drop with CGR") Coverity issue: 268342 Cc: sta...@dpdk.org Signed-off-by: Hemant Agrawal Acked-By: Shreyansh Jain --- drivers/net/dpaa/dpaa_ethdev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/dpa

[dpdk-dev] [PATCH v2 2/8] bus/dpaa: fix the unchecked return value

2018-04-09 Thread Hemant Agrawal
From: Sunil Kumar Kori Fixes: 5d944582d028 ("bus/dpaa: check portal presence in the caller function") Coverity issue: 268323 Cc: sta...@dpdk.org Signed-off-by: Sunil Kumar Kori Acked-by: Hemant Agrawal --- drivers/bus/dpaa/dpaa_bus.c | 10 -- 1 file changed, 8 insertions(+), 2 deletio

[dpdk-dev] [PATCH v2 1/8] bus/dpaa: fix the resource leak issue

2018-04-09 Thread Hemant Agrawal
From: Sunil Kumar Kori Fixes: 9d32ef0f5d61 ("bus/dpaa: support creating dynamic HW portal") Coverity issue: 268332 Cc: sta...@dpdk.org Signed-off-by: Sunil Kumar Kori Acked-by: Hemant Agrawal --- drivers/bus/dpaa/base/qbman/qman_driver.c | 5 + 1 file changed, 5 insertions(+) diff --git

[dpdk-dev] [PATCH v2 5/8] bus/dpaa: fix resource leak

2018-04-09 Thread Hemant Agrawal
Fixes: 1459585888b5 ("bus/dpaa: fix memory allocation during scan") Coverity issue: 268337 Cc: sta...@dpdk.org Signed-off-by: Hemant Agrawal Acked-By: Shreyansh Jain --- drivers/bus/dpaa/base/fman/fman.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/bus/dpaa/base/fman/fman.c b/

[dpdk-dev] [PATCH v2 7/8] net/dpaa2: fix the implementation of xstats

2018-04-09 Thread Hemant Agrawal
Fixes: 1d6329b2fc1f ("net/dpaa2: support extra stats") Cc: sta...@dpdk.org Signed-off-by: Hemant Agrawal --- drivers/net/dpaa2/dpaa2_ethdev.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/net/dpaa2/dpaa2_ethdev.c b/drivers/net/dpaa2/dpaa2_ethdev.c index

[dpdk-dev] [PATCH v2 4/8] net/dpaa: fix the oob access

2018-04-09 Thread Hemant Agrawal
Fixes: b21ed3e2a16d ("net/dpaa: support extended statistics") Coverity issue: 268318 Cc: sta...@dpdk.org Signed-off-by: Hemant Agrawal Acked-By: Shreyansh Jain --- drivers/net/dpaa/dpaa_ethdev.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/net/dpaa/dpaa_eth

[dpdk-dev] [PATCH v2 6/8] net/dpaa: update checksum for external pool obj

2018-04-09 Thread Hemant Agrawal
From: Akhil Goyal Signed-off-by: Akhil Goyal --- drivers/net/dpaa/dpaa_rxtx.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/dpaa/dpaa_rxtx.c b/drivers/net/dpaa/dpaa_rxtx.c index bdb7f66..1316d2a 100644 --- a/drivers/net/dpaa/dpaa_rxtx.c +++ b/drivers/net/dpaa/dpaa_rxtx.c @@

[dpdk-dev] [PATCH v2 8/8] bus/fslmc: configure separate portal for Ethernet Rx

2018-04-09 Thread Hemant Agrawal
From: Nipun Gupta In case of Receive from Ethernet we add a new pull request (prefetch) but do not fetch the results from that pull request until next dequeue operation. This keeps the portal in busy mode. This patch updates the portals bifurcation to have separate portals to receive packets for

Re: [dpdk-dev] [PATCH v4 44/70] net/mlx5: use virt2memseg instead of iteration

2018-04-09 Thread gowrishankar muthukrishnan
On Monday 09 April 2018 01:48 AM, Anatoly Burakov wrote: Reduce dependency on internal details of EAL memory subsystem, and simplify code. Signed-off-by: Anatoly Burakov --- drivers/net/mlx5/mlx5_mr.c | 18 -- 1 file changed, 8 insertions(+), 10 deletions(-) diff --git a/dri

Re: [dpdk-dev] [PATCH v4 66/70] bus/fslmc: enable support for mem event callbacks for vfio

2018-04-09 Thread Burakov, Anatoly
On 09-Apr-18 11:01 AM, Shreyansh Jain wrote: Hi Anatoly, On Monday 09 April 2018 01:48 AM, Anatoly Burakov wrote: VFIO needs to map and unmap segments for DMA whenever they become available or unavailable, so register a callback for memory events, and provide map/unmap functions. Signed-off-by

Re: [dpdk-dev] [PATCH v3 00/10] add framework to load and execute BPF code

2018-04-09 Thread Ananyev, Konstantin
Hi Jerin, > > > > BPF is used quite intensively inside Linux (and BSD) kernels > > for various different purposes and proved to be extremely useful. > > > > BPF inside DPDK might also be used in a lot of places > > for a lot of similar things. > > As an example to: > > - packet filtering/tracing

[dpdk-dev] [PATCH 1/2] net/dpaa: Changes to support ethdev offload APIs

2018-04-09 Thread Sunil Kumar Kori
Signed-off-by: Sunil Kumar Kori --- drivers/net/dpaa/dpaa_ethdev.c | 46 ++ 1 file changed, 42 insertions(+), 4 deletions(-) diff --git a/drivers/net/dpaa/dpaa_ethdev.c b/drivers/net/dpaa/dpaa_ethdev.c index db49364..22eb070 100644 --- a/drivers/net/dpaa/d

[dpdk-dev] [PATCH 0/2] Support for new Ethdev offload APIs

2018-04-09 Thread Sunil Kumar Kori
Patchset contains changes to support ethdev offload APIs for DPAA and DPAA2 drivers. Offloading support is categoriesed in following logical parts: 1. If requested offloading features is not supported then returned error. 2. If requested offloading feature is supoorted but cannot be disabled then

[dpdk-dev] [PATCH 2/2] net/dpaa2: Changes to support ethdev offload APIs

2018-04-09 Thread Sunil Kumar Kori
Signed-off-by: Sunil Kumar Kori --- drivers/net/dpaa2/dpaa2_ethdev.c | 63 +--- drivers/net/dpaa2/dpaa2_rxtx.c | 32 +++- 2 files changed, 63 insertions(+), 32 deletions(-) diff --git a/drivers/net/dpaa2/dpaa2_ethdev.c b/drivers/net/dpaa2/dpa

Re: [dpdk-dev] [PATCH v4 66/70] bus/fslmc: enable support for mem event callbacks for vfio

2018-04-09 Thread Shreyansh Jain
On Monday 09 April 2018 04:25 PM, Burakov, Anatoly wrote: On 09-Apr-18 11:01 AM, Shreyansh Jain wrote: Hi Anatoly, On Monday 09 April 2018 01:48 AM, Anatoly Burakov wrote: VFIO needs to map and unmap segments for DMA whenever they become available or unavailable, so register a callback for mem

[dpdk-dev] [PATCH v2 0/3] net/sfc: support loopback mode configuration

2018-04-09 Thread Andrew Rybchenko
v1 -> v2: - add patch to fix clang build error Andrew Rybchenko (3): net/sfc/base: fix comparison always true warning net/sfc: support loopback mode configuration app/testpmd: add commands to set loopback mode app/test-pmd/cmdline.c | 121

[dpdk-dev] [PATCH v2 1/3] net/sfc/base: fix comparison always true warning

2018-04-09 Thread Andrew Rybchenko
Loopback type used as bit index has efx_loopback_type_t type which is enum. clang complains that it is always true when it is compared with qword (64 bit) bits number boundary. Fixes: 9ee64bd404fc ("net/sfc/base: import loopback control") Cc: sta...@dpdk.org Signed-off-by: Andrew Rybchenko ---

[dpdk-dev] [PATCH v2 3/3] app/testpmd: add commands to set loopback mode

2018-04-09 Thread Andrew Rybchenko
Signed-off-by: Andrew Rybchenko Reviewed-by: Roman Zhukov Reviewed-by: Ivan Malov Reviewed-by: Ferruh Yigit --- app/test-pmd/cmdline.c | 121 + 1 file changed, 121 insertions(+) diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index

[dpdk-dev] [PATCH v2 2/3] net/sfc: support loopback mode configuration

2018-04-09 Thread Andrew Rybchenko
All loopback modes are listed in efx_loopback_type_t. Available loopback modes are listed per link speed in the enc_loopback_types member of the efx_nic_cfg_t. Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton Reviewed-by: Ivan Malov --- doc/guides/nics/sfc_efx.rst | 4 ++-- drivers/n

Re: [dpdk-dev] [PATCH 1/2] net/sfc: support loopback mode configuration

2018-04-09 Thread Andrew Rybchenko
On 04/06/2018 03:09 PM, Ferruh Yigit wrote: On 4/4/2018 12:10 PM, Andrew Rybchenko wrote: All loopback modes are listed in efx_loopback_type_t. Available loopback modes are listed per link speed in the enc_loopback_types member of the efx_nic_cfg_t. Signed-off-by: Andrew Rybchenko Reviewed-by:

[dpdk-dev] [PATCH] examples/ip_pipeline: fix freebsd build error

2018-04-09 Thread Jasvinder Singh
IP_Pipeline app is not supported in FreeBSD environment. Therefore, skip it while building the sample apps on FreeBSD. Fixes: 4bbf8e30aa5e ("examples/ip_pipeline: add CLI interface") Fixes: 2f74ae28e23f ("examples/ip_pipeline: add tap object") Signed-off-by: Jasvinder Singh --- examples/ip_pipe

[dpdk-dev] [PATCH v6] ethdev: replace bus specific struct with generic dev

2018-04-09 Thread Ferruh Yigit
Public struct rte_eth_dev_info has a "struct rte_pci_device" field in it although it is common for all ethdev in all buses. Replacing pci specific struct with generic device struct and updating places that are using pci device in a way to get this information from generic device. Signed-off-by: F

Re: [dpdk-dev] [PATCH] net/mlx5: fix link status initialization

2018-04-09 Thread Shahaf Shuler
Monday, April 9, 2018 11:28 AM, Nélio Laranjeiro: > Subject: Re: [PATCH] net/mlx5: fix link status initialization > > On Sun, Apr 08, 2018 at 01:09:27PM +, Shahaf Shuler wrote: > > Thursday, April 5, 2018 9:51 AM, Nélio Laranjeiro: > > > Subject: Re: [PATCH] net/mlx5: fix link status initializ

Re: [dpdk-dev] [PATCH v5 08/18] net/axgbe: add transmit and receive queue setup apis

2018-04-09 Thread Ferruh Yigit
On 4/9/2018 5:49 AM, Rosen, Rami wrote: > +static void > +axgbe_dev_info_get(struct rte_eth_dev *dev, > +struct rte_eth_dev_info *dev_info) { > + struct axgbe_port *pdata = dev->data->dev_private; > + > + dev_info->pci_dev = RTE_ETH_DEV_TO_PCI(dev); > > > [Rami Rosen] Shou

[dpdk-dev] [PATCH v1 2/2] app/testpmd: config all supported RSS functions

2018-04-09 Thread Xueming Li
Only configure RSS hash functions supported by the device. Signed-off-by: Xueming Li --- app/test-pmd/cmdline.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index 40b31ad7e..c41dd71ce 100644 --- a/app/test-pmd/cmdline.c +++ b/app/test-

[dpdk-dev] [PATCH v1 1/2] ethdev: add supported hash function check

2018-04-09 Thread Xueming Li
Add supported RSS hash function check in device configuration to have better error verbosity for application developers. Signed-off-by: Xueming Li --- lib/librte_ether/rte_ethdev.c | 21 + 1 file changed, 21 insertions(+) diff --git a/lib/librte_ether/rte_ethdev.c b/lib/libr

Re: [dpdk-dev] [PATCH v4 66/70] bus/fslmc: enable support for mem event callbacks for vfio

2018-04-09 Thread Burakov, Anatoly
On 09-Apr-18 1:09 PM, Shreyansh Jain wrote: On Monday 09 April 2018 04:25 PM, Burakov, Anatoly wrote: On 09-Apr-18 11:01 AM, Shreyansh Jain wrote: Hi Anatoly, On Monday 09 April 2018 01:48 AM, Anatoly Burakov wrote: VFIO needs to map and unmap segments for DMA whenever they become available o

Re: [dpdk-dev] [PATCH v3] net/vhost: fix segfault when creating vdev dynamically

2018-04-09 Thread Jens Freimann
Hi, On Fri, Mar 30, 2018 at 02:58:31PM +0800, Junjie Chen wrote: When creating vdev dynamically, vhost pmd driver starts directly without checking TX/RX queues are ready or not, and thus causes segmentation fault when vhost library accesses queues. This patch adds a flag to check whether queues

Re: [dpdk-dev] [PATCH v5 4/4] testpmd: make use of per-PMD TxRx parameters

2018-04-09 Thread Shreyansh Jain
On Friday 06 April 2018 08:20 PM, Remy Horton wrote: The optimal values of several transmission & reception related parameters, such as burst sizes, descriptor ring sizes, and number of queues, varies between different network interface devices. This patch allows testpmd to make use of per-PMD tu

[dpdk-dev] [PATCH] table: fix build error with gcc 8

2018-04-09 Thread Jasvinder Singh
Fix build error with gcc 8.0 due to cast between function types. Fixes: 5a80bf0ae613 ("table: add cuckoo hash") Signed-off-by: Jasvinder Singh --- lib/librte_table/rte_table_hash_cuckoo.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lib/librte_table/rte_table_hash_cuck

Re: [dpdk-dev] [PATCH] net/enic: enable overlay offload for VXLAN and GENEVE

2018-04-09 Thread Ferruh Yigit
On 4/7/2018 3:40 AM, Hyong Youb Kim wrote: > On Fri, Apr 06, 2018 at 05:15:40PM +0100, Ferruh Yigit wrote: >> On 4/5/2018 12:54 AM, John Daley wrote: >>> From: Hyong Youb Kim >>> >>> Recent NIC models support overlay offload. The overlay offload >>> feature enables the following on the NIC. >>> -

Re: [dpdk-dev] [PATCH] table: fix build error with gcc 8

2018-04-09 Thread Dumitrescu, Cristian
> -Original Message- > From: Singh, Jasvinder > Sent: Monday, April 9, 2018 1:50 PM > To: dev@dpdk.org > Cc: Dumitrescu, Cristian > Subject: [PATCH] table: fix build error with gcc 8 > > Fix build error with gcc 8.0 due to cast between function types. > Fixes: 5a80bf0ae613 ("table: add

Re: [dpdk-dev] [PATCH] examples/ip_pipeline: fix freebsd build error

2018-04-09 Thread Dumitrescu, Cristian
> -Original Message- > From: Singh, Jasvinder > Sent: Monday, April 9, 2018 1:07 PM > To: dev@dpdk.org > Cc: Dumitrescu, Cristian > Subject: [PATCH] examples/ip_pipeline: fix freebsd build error > > IP_Pipeline app is not supported in FreeBSD environment. Therefore, > skip it while buil

Re: [dpdk-dev] [PATCH] table: fix build error with gcc 8

2018-04-09 Thread Bruce Richardson
On Mon, Apr 09, 2018 at 01:49:48PM +0100, Jasvinder Singh wrote: > Fix build error with gcc 8.0 due to cast between function types. > Fixes: 5a80bf0ae613 ("table: add cuckoo hash") > > Signed-off-by: Jasvinder Singh What's the actual error message? Why do the types not match? /Bruce

[dpdk-dev] [PATCH v1] doc: add SPDX Licence to doc files

2018-04-09 Thread Marko Kovacevic
Added SPDX headers to doc files to have them aligned with the other doc files. Signed-off-by: Marko Kovacevic --- doc/guides/contributing/cheatsheet.rst | 3 +++ doc/guides/contributing/coding_style.rst | 3 +++ doc/guides/contributing/design.rst | 3 +++ doc/guid

[dpdk-dev] [PATCH dpdk-next-net] net/axgbe: fix an assignment error in axgbe_dev_info_get()

2018-04-09 Thread Rami Rosen
This patch fixes a tirvial error in assigning max Rx/Tx queues in axgbe_dev_info_get() of the axgbe PMD driver. Signed-off-by: Rami Rosen --- drivers/net/axgbe/axgbe_ethdev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/axgbe/axgbe_ethdev.c b/drivers/net/

Re: [dpdk-dev] [PATCH] net/mlx5: fix link status initialization

2018-04-09 Thread Nélio Laranjeiro
On Mon, Apr 09, 2018 at 12:28:04PM +, Shahaf Shuler wrote: > Monday, April 9, 2018 11:28 AM, Nélio Laranjeiro: > > Subject: Re: [PATCH] net/mlx5: fix link status initialization > > > > On Sun, Apr 08, 2018 at 01:09:27PM +, Shahaf Shuler wrote: > > > Thursday, April 5, 2018 9:51 AM, Nélio L

Re: [dpdk-dev] OPDL and 18.02 Release Notes

2018-04-09 Thread Liang, Ma
On 05 Mar 17:58, Ferruh Yigit wrote: > On 2/9/2018 12:08 AM, Rosen, Rami wrote: > > Hi all, > > Following the recent announcement of DPDK 18.02-RC4, I went over > > 18.02 release notes and I have this minor query which I am not sure about: > > In the release notes: > > http://dpdk.org/doc/guides/re

Re: [dpdk-dev] [PATCH 0/6] enable easier app compilation testing with meson

2018-04-09 Thread Bruce Richardson
On Fri, Apr 06, 2018 at 01:10:54PM +0100, Van Haaren, Harry wrote: > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Bruce Richardson > > Sent: Thursday, March 29, 2018 2:55 PM > > To: dev@dpdk.org > > Cc: hemant.agra...@nxp.com; shreyansh.j...@nxp.com; Richardson, Bruce > > > > Subject: [d

Re: [dpdk-dev] [PATCH v1] doc: add SPDX Licence to doc files

2018-04-09 Thread Ferruh Yigit
On 4/9/2018 2:11 PM, Marko Kovacevic wrote: > Added SPDX headers to doc files to have them aligned with > the other doc files. > > Signed-off-by: Marko Kovacevic <...> > doc/guides/rel_notes/release_16_04.rst | 3 +++ > doc/guides/rel_notes/release_16_07.rst | 3 +++ > doc/

Re: [dpdk-dev] [PATCH dpdk-next-net] net/axgbe: fix an assignment error in axgbe_dev_info_get()

2018-04-09 Thread Kumar, Ravi1
>This patch fixes a tirvial error in assigning max Rx/Tx queues in >axgbe_dev_info_get() of the axgbe PMD driver. > >Signed-off-by: Rami Rosen >--- > drivers/net/axgbe/axgbe_ethdev.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/drivers/net/axgbe/axgbe_ethdev.c >b/d

Re: [dpdk-dev] [PATCH v2] net/i40e: fix flow RSS queue index check error

2018-04-09 Thread Zhang, Qi Z
> -Original Message- > From: Zhao1, Wei > Sent: Monday, April 9, 2018 4:38 PM > To: dev@dpdk.org > Cc: sta...@dpdk.org; Zhang, Qi Z ; Zhao1, Wei > > Subject: [PATCH v2] net/i40e: fix flow RSS queue index check error > > There is an error in queue index check for RSS queue region configu

Re: [dpdk-dev] [PATCH dpdk-next-net] net/axgbe: fix an assignment error in axgbe_dev_info_get()

2018-04-09 Thread Ferruh Yigit
On 4/9/2018 2:56 PM, Kumar, Ravi1 wrote: >> This patch fixes a tirvial error in assigning max Rx/Tx queues in >> axgbe_dev_info_get() of the axgbe PMD driver. >> >> Signed-off-by: Rami Rosen >> --- >> drivers/net/axgbe/axgbe_ethdev.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >>

Re: [dpdk-dev] [PATCH] net/mlx5: fix link status initialization

2018-04-09 Thread Nélio Laranjeiro
On Mon, Apr 09, 2018 at 03:26:41PM +0200, Nélio Laranjeiro wrote: > On Mon, Apr 09, 2018 at 12:28:04PM +, Shahaf Shuler wrote: > > Monday, April 9, 2018 11:28 AM, Nélio Laranjeiro: > > > Subject: Re: [PATCH] net/mlx5: fix link status initialization > > > > > > On Sun, Apr 08, 2018 at 01:09:27P

Re: [dpdk-dev] OPDL and 18.02 Release Notes

2018-04-09 Thread Ferruh Yigit
On 4/9/2018 2:43 PM, Liang, Ma wrote: > On 05 Mar 17:58, Ferruh Yigit wrote: >> On 2/9/2018 12:08 AM, Rosen, Rami wrote: >>> Hi all, >>> Following the recent announcement of DPDK 18.02-RC4, I went over >>> 18.02 release notes and I have this minor query which I am not sure about: >>> In the release

Re: [dpdk-dev] OPDL and 18.02 Release Notes

2018-04-09 Thread Rosen, Rami
Hi Liang, > Team agree stay with "Ordered Packet Distribution Library" name so far. > the roadmap information might need update Actually, now there is no need to update the roadmap, as OPDL does not appear there at all. (Back when I originally sent the first mail in this thread, it referred t

Re: [dpdk-dev] [PATCH] rawdev: add to meson build

2018-04-09 Thread Shreyansh Jain
On Wednesday 04 April 2018 03:42 PM, Bruce Richardson wrote: Add librte_rawdev to the meson build of DPDK. Signed-off-by: Bruce Richardson --- config/rte_config.h | 3 +++ lib/librte_rawdev/meson.build | 6 ++ lib/meson.build | 2 +- 3 files changed, 10 insertio

Re: [dpdk-dev] [PATCH v3 1/4] ethdev: add group counter support to rte_flow

2018-04-09 Thread Mohammad Abdul Awal
Hi Adrien, On 06/04/2018 21:26, Adrien Mazarguil wrote: On Fri, Apr 06, 2018 at 01:24:00PM +0100, Declan Doherty wrote: Add new RTE_FLOW_ACTION_TYPE_GROUP_COUNT action type to enable shared counters across multiple flows on a single port or across multiple flows on multiple ports within the sa

[dpdk-dev] [PATCH 2/2] net/dpaa2: Changes to support ethdev offload APIs

2018-04-09 Thread Sunil Kumar Kori
Signed-off-by: Sunil Kumar Kori --- drivers/net/dpaa2/dpaa2_ethdev.c | 63 +--- drivers/net/dpaa2/dpaa2_rxtx.c | 32 +++- 2 files changed, 63 insertions(+), 32 deletions(-) diff --git a/drivers/net/dpaa2/dpaa2_ethdev.c b/drivers/net/dpaa2/dpa

[dpdk-dev] [PATCH 1/2] net/dpaa: Changes to support ethdev offload APIs

2018-04-09 Thread Sunil Kumar Kori
Signed-off-by: Sunil Kumar Kori --- drivers/net/dpaa/dpaa_ethdev.c | 46 ++ 1 file changed, 42 insertions(+), 4 deletions(-) diff --git a/drivers/net/dpaa/dpaa_ethdev.c b/drivers/net/dpaa/dpaa_ethdev.c index db49364..efef62c 100644 --- a/drivers/net/dpaa/d

Re: [dpdk-dev] [PATCH v5 4/4] testpmd: make use of per-PMD TxRx parameters

2018-04-09 Thread Remy Horton
On 09/04/2018 13:55, Shreyansh Jain wrote: [..] Documentation for burst mode changes to testpmd would need an update. I guess, only when the user explicitly sets 'set burst 0' would the driver defaults be picked up - isn't it? Yes. Maybe something like this: --->8--- --- a/doc/guides/testp

[dpdk-dev] [PATCH] build: fix default arm64 build instruction level support

2018-04-09 Thread Jerin Jacob
The make based build system has crc+crypto instruction support for the default arm64 build. http://dpdk.org/browse/dpdk/tree/mk/machine/armv8a/rte.vars.mk#n31 This patch fixes the disparity with meson build flags for armv8. As a bonus, This patch fixes the following errors with ip_pipeline example

Re: [dpdk-dev] [PATCH v2 08/15] ethdev: add hash function to RSS flow API action

2018-04-09 Thread Adrien Mazarguil
On Fri, Apr 06, 2018 at 06:41:35PM +0300, Andrew Rybchenko wrote: > On 04/06/2018 04:25 PM, Adrien Mazarguil wrote: > > By definition, RSS involves some kind of hash algorithm, usually Toeplitz. > > > > Until now it could not be modified on a flow rule basis and PMDs had to > > always assume RTE_E

Re: [dpdk-dev] [PATCH v2 10/15] ethdev: refine TPID handling in flow API

2018-04-09 Thread Adrien Mazarguil
On Fri, Apr 06, 2018 at 08:11:38PM +0300, Andrew Rybchenko wrote: > On 04/06/2018 04:25 PM, Adrien Mazarguil wrote: > > TPID handling in rte_flow VLAN and E_TAG pattern item definitions is not > > consistent with the normal stacking order of pattern items, which is > > confusing to applications. >

Re: [dpdk-dev] [PATCH v2 07/15] ethdev: flatten RSS configuration in flow API

2018-04-09 Thread Adrien Mazarguil
On Sat, Apr 07, 2018 at 12:05:51PM +0300, Andrew Rybchenko wrote: > On 04/06/2018 04:25 PM, Adrien Mazarguil wrote: > > Since its inception, the rte_flow RSS action has been relying in part on > > external struct rte_eth_rss_conf for compatibility with the legacy RSS API. > > This structure lacks p

Re: [dpdk-dev] [PATCH v2 12/15] ethdev: update behavior of VF/PF in flow API

2018-04-09 Thread Adrien Mazarguil
On Sat, Apr 07, 2018 at 12:41:17PM +0300, Andrew Rybchenko wrote: > On 04/06/2018 04:25 PM, Adrien Mazarguil wrote: > > Contrary to all other pattern items, these are inconsistently documented as > > affecting traffic instead of simply matching its origin, without provision > > for the latter. > >

Re: [dpdk-dev] [PATCH] table: fix build error with gcc 8

2018-04-09 Thread Singh, Jasvinder
> -Original Message- > From: Richardson, Bruce > Sent: Monday, April 9, 2018 2:09 PM > To: Singh, Jasvinder > Cc: dev@dpdk.org; Dumitrescu, Cristian > Subject: Re: [dpdk-dev] [PATCH] table: fix build error with gcc 8 > > On Mon, Apr 09, 2018 at 01:49:48PM +0100, Jasvinder Singh wrote: >

Re: [dpdk-dev] [PATCH v2 14/15] ethdev: add physical port action to flow API

2018-04-09 Thread Adrien Mazarguil
On Sat, Apr 07, 2018 at 12:51:40PM +0300, Andrew Rybchenko wrote: > On 04/06/2018 04:25 PM, Adrien Mazarguil wrote: > > This patch adds the missing action counterpart to the PHY_PORT pattern > > item, that is, the ability to directly inject matching traffic into a > > physical port of the underlyin

Re: [dpdk-dev] Question on documentation / Mellanox ConnectX-3

2018-04-09 Thread Adrien Mazarguil
On Sun, Apr 08, 2018 at 06:27:50PM -0300, Marcelo Ricardo Leitner wrote: > On Thu, Apr 05, 2018 at 11:26:21AM +0200, Adrien Mazarguil wrote: > > On Tue, Apr 03, 2018 at 02:59:38PM -0300, Marcelo Ricardo Leitner wrote: > > > Hi, > > > > > > http://docs.openvswitch.org/en/latest/howto/dpdk/ says: > >

Re: [dpdk-dev] [PATCH] table: fix build error with gcc 8

2018-04-09 Thread Stephen Hemminger
On Mon, 9 Apr 2018 13:49:48 +0100 Jasvinder Singh wrote: > Fix build error with gcc 8.0 due to cast between function types. > Fixes: 5a80bf0ae613 ("table: add cuckoo hash") > > Signed-off-by: Jasvinder Singh > --- > lib/librte_table/rte_table_hash_cuckoo.c | 4 +++- > 1 file changed, 3 inser

Re: [dpdk-dev] [PATCH v3 1/4] ethdev: add group counter support to rte_flow

2018-04-09 Thread Adrien Mazarguil
Hi Mohammad, On Mon, Apr 09, 2018 at 03:22:45PM +0100, Mohammad Abdul Awal wrote: > Hi Adrien, > > > On 06/04/2018 21:26, Adrien Mazarguil wrote: > > On Fri, Apr 06, 2018 at 01:24:00PM +0100, Declan Doherty wrote: > > > Add new RTE_FLOW_ACTION_TYPE_GROUP_COUNT action type to enable shared > > >

Re: [dpdk-dev] [PATCH] table: fix build error with gcc 8

2018-04-09 Thread Bruce Richardson
On Mon, Apr 09, 2018 at 03:51:10PM +0100, Singh, Jasvinder wrote: > > > -Original Message- > > From: Richardson, Bruce > > Sent: Monday, April 9, 2018 2:09 PM > > To: Singh, Jasvinder > > Cc: dev@dpdk.org; Dumitrescu, Cristian > > Subject: Re: [dpdk-dev] [PATCH] table: fix build error wi

[dpdk-dev] [PATCH] lib/librte_vhost: fix bugs

2018-04-09 Thread Fan Zhang
Fixes: 256b132f41b2 ("vhost/crypto: add session message handler") Fixes: 7b5ad7beee17 ("vhost/crypto: update makefile") Fixes: 2ce5bd8c442d ("examples/vhost_crypto: add vhost crypto sample application") This patch fixes the bugs introduced in the above patches. Signed-off-by: Fan Zhang --- exa

[dpdk-dev] [PATCH] lib/librte_vhost: remove packet dump

2018-04-09 Thread Fan Zhang
This patch removes unnecessary packet dump for debugging. Signed-off-by: Fan Zhang --- lib/librte_vhost/vhost_crypto.c | 36 1 file changed, 36 deletions(-) diff --git a/lib/librte_vhost/vhost_crypto.c b/lib/librte_vhost/vhost_crypto.c index d84513e7f..d86af

Re: [dpdk-dev] [PATCH] build: fix default arm64 build instruction level support

2018-04-09 Thread Bruce Richardson
On Mon, Apr 09, 2018 at 08:09:46PM +0530, Jerin Jacob wrote: > The make based build system has crc+crypto instruction > support for the default arm64 build. > http://dpdk.org/browse/dpdk/tree/mk/machine/armv8a/rte.vars.mk#n31 > > This patch fixes the disparity with meson build flags for armv8. > A

Re: [dpdk-dev] [PATCH] lib/librte_vhost: fix bugs

2018-04-09 Thread Maxime Coquelin
Hi Fan, On 04/09/2018 05:34 PM, Fan Zhang wrote: Fixes: 256b132f41b2 ("vhost/crypto: add session message handler") Fixes: 7b5ad7beee17 ("vhost/crypto: update makefile") Fixes: 2ce5bd8c442d ("examples/vhost_crypto: add vhost crypto sample application") This patch fixes the bugs introduced in th

Re: [dpdk-dev] [PATCH] bus/fslmc: support for hotplugging of memory

2018-04-09 Thread Burakov, Anatoly
On 09-Apr-18 8:49 AM, Shreyansh Jain wrote: Hello Anatoly, On Sunday 08 April 2018 10:44 PM, Burakov, Anatoly wrote: On 05-Apr-18 3:14 PM, Shreyansh Jain wrote: Restructure VFIO DMA code for handling hotplug memory events (callbacks) and --legacy case. Signed-off-by: Shreyansh Jain --- ###

Re: [dpdk-dev] [PATCH] lib/librte_vhost: fix meson build

2018-04-09 Thread Maxime Coquelin
On 04/06/2018 02:43 PM, Fan Zhang wrote: Fixes: 7834b5c82bf3 ("lib/librte_vhost: update makefile") This patch fixes some meson build bugs. Signed-off-by: Fan Zhang --- lib/librte_vhost/meson.build | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/librte_vhost/mes

Re: [dpdk-dev] [PATCH] lib/librte_vhost: fix bugs

2018-04-09 Thread Maxime Coquelin
Overall, please rename the commit title prefix to vhost/crypto. Thanks, Maxime On 04/09/2018 05:34 PM, Fan Zhang wrote: Fixes: 256b132f41b2 ("vhost/crypto: add session message handler") Fixes: 7b5ad7beee17 ("vhost/crypto: update makefile") Fixes: 2ce5bd8c442d ("examples/vhost_crypto: add vhost

Re: [dpdk-dev] [PATCH] table: fix build error with gcc 8

2018-04-09 Thread Dumitrescu, Cristian
> -Original Message- > From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Monday, April 9, 2018 4:10 PM > To: Singh, Jasvinder > Cc: dev@dpdk.org; Dumitrescu, Cristian > Subject: Re: [dpdk-dev] [PATCH] table: fix build error with gcc 8 > > On Mon, 9 Apr 2018 13:49:48

Re: [dpdk-dev] [PATCH v2 1/6] mbuf: add buffer offset field for flexible indirection

2018-04-09 Thread Olivier Matz
Hi Yongseok, On Tue, Apr 03, 2018 at 05:12:06PM -0700, Yongseok Koh wrote: > On Tue, Apr 03, 2018 at 10:26:15AM +0200, Olivier Matz wrote: > > Hi, > > > > On Mon, Apr 02, 2018 at 11:50:03AM -0700, Yongseok Koh wrote: > > > When attaching a mbuf, indirect mbuf has to point to start of buffer of >

Re: [dpdk-dev] [PATCH] bus/fslmc: support for hotplugging of memory

2018-04-09 Thread Shreyansh Jain
> -Original Message- > From: Burakov, Anatoly [mailto:anatoly.bura...@intel.com] > Sent: Monday, April 9, 2018 9:20 PM > To: Shreyansh Jain > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] bus/fslmc: support for hotplugging of > memory > > On 09-Apr-18 8:49 AM, Shreyansh Jain wrote: >

  1   2   3   >