[dpdk-dev] Bug in "rte_eth_dev_attach" while using mlx5 pmd driver?

2018-03-29 Thread Sam
Hi all, I'm using OVS-2.8.0 + DPDK-17.05-rc1, with 2 pf and 1 vf port under mlx5 pmd driver, like this: $ sudo /usr/local/share/openvswitch/scripts/dpdk_nic_bind --status > Network devices using DPDK-compatible driver > > > Network devices using kerne

Re: [dpdk-dev] Under Ovs-2.8.0 + DPDK-17.05-rc1, can't add port which using mlx5 driver onto bridge br0

2018-03-29 Thread Sam
Hi all, this is fixed by adding "LDFLAGS=-libverbs" while making. 2018-03-29 10:29 GMT+08:00 Sam : > KNI also works > > 2018-03-29 10:03 GMT+08:00 Sam : > >> But testpmd at the same version of DPDK is OK, like this: >> >> [gangyewei@yf-mos-test-net07 dpdk]$ sudo >> /usr/local/share/openvswitch/

Re: [dpdk-dev] [PATCH] vhost: fix segfault as handle set_mem_table message

2018-03-29 Thread Tan, Jianfeng
Hi Maxime and Victor, > -Original Message- > From: Maxime Coquelin [mailto:maxime.coque...@redhat.com] > Sent: Tuesday, December 5, 2017 10:28 PM > To: Yuanhan Liu; Tan, Jianfeng; Victor Kaplansky > Cc: dev@dpdk.org; sta...@dpdk.org; Yang, Yi Y > Subject: Re: [PATCH] vhost: fix segfault as

Re: [dpdk-dev] [PATCH 2/2] vhost: add pipe event for optimizing negotiating

2018-03-29 Thread Tan, Jianfeng
Hi Xiangxia, > -Original Message- > From: xiangxia.m@gmail.com [mailto:xiangxia.m@gmail.com] > Sent: Wednesday, March 28, 2018 1:49 PM > To: Tan, Jianfeng > Cc: dev@dpdk.org; Tonghao Zhang > Subject: [PATCH 2/2] vhost: add pipe event for optimizing negotiating > > From: Tonghao Zh

Re: [dpdk-dev] [PATCH v6 4/8] ethdev: Add port representor device flag

2018-03-29 Thread Thomas Monjalon
29/03/2018 08:13, Shahaf Shuler: > And device attributes like : RTE_ETH_DEV_BONDED_SLAVE and > RTE_ETH_DEV_REPRESENTOR. > I don't think they belong together under the genetic name of dev_flags. > > Moreover, I am not sure the fact device is bonded slave should be exposed to > the application. I

Re: [dpdk-dev] [PATCH] vhost: fix segfault as handle set_mem_table message

2018-03-29 Thread Maxime Coquelin
On 03/29/2018 09:01 AM, Tan, Jianfeng wrote: Hi Maxime and Victor, -Original Message- From: Maxime Coquelin [mailto:maxime.coque...@redhat.com] Sent: Tuesday, December 5, 2017 10:28 PM To: Yuanhan Liu; Tan, Jianfeng; Victor Kaplansky Cc: dev@dpdk.org; sta...@dpdk.org; Yang, Yi Y Subje

Re: [dpdk-dev] [PATCH v2 2/2] ethdev: add new offload flag to keep CRC

2018-03-29 Thread Thomas Monjalon
29/03/2018 07:38, Shahaf Shuler: > Wednesday, March 21, 2018 9:48 PM, Ferruh Yigit: > > DEV_RX_OFFLOAD_KEEP_CRC offload flag added. > > > > DEV_RX_OFFLOAD_CRC_STRIP flag will remain one more release but default > > behavior in PMDs is to strip the CRC independent from this flag. > > > > Until DEV

Re: [dpdk-dev] [PATCH v2 2/2] ethdev: add new offload flag to keep CRC

2018-03-29 Thread Shahaf Shuler
Thursday, March 29, 2018 10:43 AM, Thomas Monjalon: > 29/03/2018 07:38, Shahaf Shuler: > > Wednesday, March 21, 2018 9:48 PM, Ferruh Yigit: > > > DEV_RX_OFFLOAD_KEEP_CRC offload flag added. > > > > > > DEV_RX_OFFLOAD_CRC_STRIP flag will remain one more release but > > > default behavior in PMDs is

Re: [dpdk-dev] [PATCH] ethdev: replace bus specific struct with generic dev

2018-03-29 Thread Legacy, Allain
> -Original Message- > From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] > Sent: Tuesday, March 27, 2018 1:41 PM <...> > Subject: [PATCH] ethdev: replace bus specific struct with generic dev > > Public struct rte_eth_dev_info has a "struct rte_pci_device" field in it > although it is comm

Re: [dpdk-dev] [PATCH] ethdev: replace bus specific struct with generic dev

2018-03-29 Thread Tomasz Duszynski
On Tue, Mar 27, 2018 at 06:40:52PM +0100, Ferruh Yigit wrote: > Public struct rte_eth_dev_info has a "struct rte_pci_device" field in it > although it is common for all ethdev in all buses. > > Replacing pci specific struct with generic device struct and updating > places that are using pci device

Re: [dpdk-dev] [PATCH] ethdev: replace bus specific struct with generic dev

2018-03-29 Thread santosh
On Tuesday 27 March 2018 11:10 PM, Ferruh Yigit wrote: > Public struct rte_eth_dev_info has a "struct rte_pci_device" field in it > although it is common for all ethdev in all buses. > > Replacing pci specific struct with generic device struct and updating > places that are using pci device in a w

Re: [dpdk-dev] [PATCH 4/4] eal: set affinity for control threads

2018-03-29 Thread Burakov, Anatoly
On 27-Feb-18 2:46 PM, Olivier Matz wrote: The management threads must not bother the dataplane or service cores. Set the affinity of these threads accordingly. Signed-off-by: Olivier Matz --- <...> + set_affinity = 0; + CPU_ZERO(&cpuset); + for (lcore_id = 0; lcore_id < RTE_M

Re: [dpdk-dev] [PATCH v6 2/8] ethdev: add switch identifier parameter to port

2018-03-29 Thread Doherty, Declan
On 29/03/2018 7:13 AM, Shahaf Shuler wrote: Hi Declan, Thanks for the series! See some comments below Wednesday, March 28, 2018 4:54 PM, Declan Doherty: Subject: [dpdk-dev][PATCH v6 2/8] ethdev: add switch identifier parameter to port Introduces a new port attribute to ethdev port's which den

[dpdk-dev] [PATCH v3 1/2] net/i40e: convert to new Rx offloads API

2018-03-29 Thread Yanglong Wu
Ethdev Rx offloads API has changed since: commit cba7f53b717d ("ethdev: introduce Rx queue offloads API") This commit support the new Rx offloads API. Signed-off-by: Yanglong Wu --- v2: Adding offload requests checking and reworking patch according to review comments --- v3: fix error --- driver

Re: [dpdk-dev] [PATCH] ethdev: replace bus specific struct with generic dev

2018-03-29 Thread Ferruh Yigit
On 3/29/2018 7:17 AM, Tomasz Duszynski wrote: > On Tue, Mar 27, 2018 at 06:40:52PM +0100, Ferruh Yigit wrote: >> Public struct rte_eth_dev_info has a "struct rte_pci_device" field in it >> although it is common for all ethdev in all buses. >> >> Replacing pci specific struct with generic device str

[dpdk-dev] [PATCH v3 2/2] net/i40e: convert to new Tx offloads API

2018-03-29 Thread Yanglong Wu
Ethdev Tx offloads API has changed since: commit cba7f53b717d ("ethdev: introduce Tx queue offloads API") This commit support the new Tx offloads API. Signed-off-by: Yanglong Wu --- v2: Adding offload requests checking and reworking patch according to review comments --- v3: fix error --- driver

Re: [dpdk-dev] [PATCH v6 3/8] ethdev: add generic create/destroy ethdev APIs

2018-03-29 Thread Doherty, Declan
On 29/03/2018 7:13 AM, Shahaf Shuler wrote: Wednesday, March 28, 2018 4:54 PM, Declan Doherty: Subject: [dpdk-dev][PATCH v6 3/8] ethdev: add generic create/destroy ethdev APIs Add new bus generic ethdev create/destroy APIs which are bus independent and provide hooks for bus specific initialisat

Re: [dpdk-dev] [PATCH v2 1/2] net/fm10k: convert to new Rx offloads API

2018-03-29 Thread Ananyev, Konstantin
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Zhang, Qi Z > Sent: Thursday, March 29, 2018 7:09 AM > To: Dai, Wei ; Wang, Xiao W > Cc: 'dev@dpdk.org' > Subject: Re: [dpdk-dev] [PATCH v2 1/2] net/fm10k: convert to new Rx offloads > API > > > > > -Ori

[dpdk-dev] [PATCH v2] net/vhost: fix segfault when creating vdev dynamically

2018-03-29 Thread Junjie Chen
when creating vdev dynamically, vhost pmd driver start directly without checking TX/RX queues ready or not, and thus cause segmentation fault when vhost library accessing queues. This patch add flag to check whether queues setup or not, and add driver start call into dev_start to allow user start i

Re: [dpdk-dev] [PATCH v2 1/2] net/fm10k: convert to new Rx offloads API

2018-03-29 Thread Zhang, Qi Z
Hi Konstantin: > -Original Message- > From: Ananyev, Konstantin > Sent: Thursday, March 29, 2018 5:29 PM > To: Zhang, Qi Z ; Dai, Wei ; Wang, > Xiao W > Cc: 'dev@dpdk.org' > Subject: RE: [dpdk-dev] [PATCH v2 1/2] net/fm10k: convert to new Rx > offloads API > > > > > -Original Mess

Re: [dpdk-dev] [PATCH] examples/ipsec-secgw: remove redundant string compare

2018-03-29 Thread Radu Nicolau
On 3/28/2018 3:28 PM, Anoob Joseph wrote: Hi Akhil, Radu, Did you get time to review the patch? Thanks, Anoob On 23/03/18 11:20, Anoob Joseph wrote: Removing redundant strncmp in parsing long arguments. The getopt library provides means to identify long options using the "val" field of struc

Re: [dpdk-dev] [PATCH v6 2/8] ethdev: add switch identifier parameter to port

2018-03-29 Thread Shahaf Shuler
Thursday, March 29, 2018 12:14 PM, Doherty, Declan: > On 29/03/2018 7:13 AM, Shahaf Shuler wrote: > > Hi Declan, > > > > Thanks for the series! See some comments below > > > > Wednesday, March 28, 2018 4:54 PM, Declan Doherty: > >> Subject: [dpdk-dev][PATCH v6 2/8] ethdev: add switch identifier > >

Re: [dpdk-dev] [PATCH v2 1/2] net/fm10k: convert to new Rx offloads API

2018-03-29 Thread Ananyev, Konstantin
Hi Qi, > -Original Message- > From: Zhang, Qi Z > Sent: Thursday, March 29, 2018 10:51 AM > To: Ananyev, Konstantin ; Dai, Wei > ; Wang, Xiao W > Cc: 'dev@dpdk.org' > Subject: RE: [dpdk-dev] [PATCH v2 1/2] net/fm10k: convert to new Rx offloads > API > > Hi Konstantin: > > > -Orig

Re: [dpdk-dev] [PATCH v2 1/2] Add RIB library

2018-03-29 Thread Bruce Richardson
On Wed, Feb 21, 2018 at 09:44:54PM +, Medvedkin Vladimir wrote: > RIB is an alternative to current LPM library. > It solves the following problems > - Increases the speed of control plane operations against lpm such as >adding/deleting routes > - Adds abstraction from dataplane algorithms

Re: [dpdk-dev] [PATCH v2 1/2] net/fm10k: convert to new Rx offloads API

2018-03-29 Thread Zhang, Qi Z
> -Original Message- > From: Ananyev, Konstantin > Sent: Thursday, March 29, 2018 6:21 PM > To: Zhang, Qi Z ; Dai, Wei ; Wang, > Xiao W > Cc: 'dev@dpdk.org' > Subject: RE: [dpdk-dev] [PATCH v2 1/2] net/fm10k: convert to new Rx > offloads API > > Hi Qi, > > > -Original Message-

Re: [dpdk-dev] [PATCH] net/avf: convert to new RX/TX offload API

2018-03-29 Thread Xing, Beilei
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Wenzhuo Lu > Sent: Thursday, March 1, 2018 2:42 PM > To: dev@dpdk.org > Cc: Lu, Wenzhuo > Subject: [dpdk-dev] [PATCH] net/avf: convert to new RX/TX offload API > > Signed-off-by: Wenzhuo Lu > --- > drivers/net/a

[dpdk-dev] [PATCH] devtools: do not create kernel dir

2018-03-29 Thread Pablo de Lara
get-maintainer script requires the creation of some folders, including "kernel". Since now this folder exists in DPDK folder, it is not required to create it. Signed-off-by: Pablo de Lara --- devtools/get-maintainer.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/devtools/

Re: [dpdk-dev] [PATCH 1/4] ether: add flow action to redirect packet in a switch domain

2018-03-29 Thread Pattan, Reshma
Hi > Add action RTE_FLOW_ACTION_TYPE_SWITCH_PORT, it can be used to > redirect a packet to a network interface that connect to the same switch > domain, rte_ethdev's port_id is used as an identification of the destination. > A typical use case is: with a smart NIC for vSwitch acceleration, flow i

Re: [dpdk-dev] [PATCH v2 00/41] Memory Hotplug for DPDK

2018-03-29 Thread Shreyansh Jain
Hello Anatoly, > -Original Message- > From: Burakov, Anatoly [mailto:anatoly.bura...@intel.com] > Sent: Tuesday, March 20, 2018 3:38 PM > To: Shreyansh Jain > Cc: dev@dpdk.org; Thomas Monjalon > Subject: Re: [dpdk-dev] [PATCH v2 00/41] Memory Hotplug for DPDK > > On 19-Mar-18 8:58 AM, S

Re: [dpdk-dev] [PATCH v4 1/2] eventdev: add device stop flush callback

2018-03-29 Thread Van Haaren, Harry
(+Liang Ma for OPDL maintainer) Ping to maintainers, is the below suggestion acceptable for your PMDs? Summary of suggestion: - After event_dev_stop() dequeue() is no longer allowed on any thread - All events in the system (queues, ports, intermediary buffers) will be passed to a user-supplied c

Re: [dpdk-dev] [PATCH 1/4] ether: add flow action to redirect packet in a switch domain

2018-03-29 Thread Pattan, Reshma
Also patch heading is missing "port" " ether: add flow action to redirect packet in a switch domain".

Re: [dpdk-dev] [PATCH 2/2] vhost: add pipe event for optimizing negotiating

2018-03-29 Thread Tonghao Zhang
On Thu, Mar 29, 2018 at 3:32 PM, Tan, Jianfeng wrote: > Hi Xiangxia, > >> -Original Message- >> From: xiangxia.m@gmail.com [mailto:xiangxia.m@gmail.com] >> Sent: Wednesday, March 28, 2018 1:49 PM >> To: Tan, Jianfeng >> Cc: dev@dpdk.org; Tonghao Zhang >> Subject: [PATCH 2/2] vhost:

[dpdk-dev] [PATCH] net/mlx5: add ptype table idx for TCP ACK packets

2018-03-29 Thread Bin Huang
From: Bin Huang According to CQE format: - l4_hdr_type: 0 - None 1 - TCP header was present in the packet 2 - UDP header was present in the packet 3 - TCP header was present in the packet with Empty TCP ACK indication. (TCP packet flag is set, and packet car

Re: [dpdk-dev] [PATCH] net/virtio-user: specify the MAC of the tap

2018-03-29 Thread Maxime Coquelin
On 12/29/2017 04:38 AM, Ning Li wrote: When using virtio-user with vhost-kernel to exchange packet with kernel networking stack, application can set the MAC of the tap interface via parameter. Signed-off-by: Ning Li --- drivers/net/virtio/virtio_user/vhost_kernel.c | 3 ++- drivers/ne

[dpdk-dev] bus/fslmc: add QBMAN driver to bus patch problem

2018-03-29 Thread Rybalchenko, Kirill
Hello Hemant, I found that a number of patches submitted for 18.05 release fail in compilation: Failed Build #1: OS: CentOS7_64 Target: x86_64-native-linuxapp-clang In file included from /home/patchWorkOrg/compilation/drivers/bus/fslmc/qbman/qbman_portal.c:7: In file included from /home/patchWo

Re: [dpdk-dev] [PATCH v3 2/4] net/virtio: add checking for cvq

2018-03-29 Thread Maxime Coquelin
On 03/21/2018 04:03 AM, zhiyong.y...@intel.com wrote: Add checking for cvq to judge if virtio_ack_link_announce should be called. The existing code doesn't cause issue, and add the checking just to look more reasonable. Signed-off-by: Zhiyong Yang --- drivers/net/virtio/virtio_ethdev.c | 3

Re: [dpdk-dev] [PATCH v3 1/4] net/virtio: fix add pointer checking

2018-03-29 Thread Maxime Coquelin
On 03/21/2018 04:03 AM, zhiyong.y...@intel.com wrote: It is necessary to add pointer checking because in some case the code will cause crash. For example, the code goes here before memory allocation of rxvq is finished. Fixes: 7365504f77e3("net/virtio: support guest announce") Cc: sta...@dpdk.

Re: [dpdk-dev] [PATCH v3 1/4] net/virtio: fix add pointer checking

2018-03-29 Thread Maxime Coquelin
On 03/21/2018 04:03 AM, zhiyong.y...@intel.com wrote: It is necessary to add pointer checking because in some case the code will cause crash. For example, the code goes here before memory allocation of rxvq is finished. Fixes: 7365504f77e3("net/virtio: support guest announce") Cc: sta...@dpdk.

Re: [dpdk-dev] [PATCH v3 2/4] net/virtio: add checking for cvq

2018-03-29 Thread Maxime Coquelin
On 03/21/2018 04:03 AM, zhiyong.y...@intel.com wrote: Add checking for cvq to judge if virtio_ack_link_announce should be called. The existing code doesn't cause issue, and add the checking just to look more reasonable. Signed-off-by: Zhiyong Yang --- drivers/net/virtio/virtio_ethdev.c | 3

Re: [dpdk-dev] Bug in "rte_eth_dev_attach" while using mlx5 pmd driver?

2018-03-29 Thread Sam
I use a temporary patch to fix this bug: diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c index 4e1e6dc..8026a05 100644 --- a/lib/librte_ether/rte_ethdev.c +++ b/lib/librte_ether/rte_ethdev.c @@ -479,7 +479,7 @@ struct rte_eth_dev * rte_eth_dev_attach(const char *devargs

Re: [dpdk-dev] [PATCH v6 6/8] ethdev: add common devargs parser

2018-03-29 Thread Gaëtan Rivet
Hi, On Wed, Mar 28, 2018 at 02:54:31PM +0100, Declan Doherty wrote: > From: Remy Horton > > Introduces a new structure, rte_eth_devargs, to support generic > ethdev arguments common across NET PMDs, with a new API > rte_eth_devargs_parse API to support PMD parsing these arguments. > Here is th

Re: [dpdk-dev] [PATCH v4] doc: add driver limitation for vhost dequeue zero copy

2018-03-29 Thread Maxime Coquelin
On 03/14/2018 05:24 PM, Junjie Chen wrote: In vhost-switch example, when binding nic to vfio-pci with iommu enabled, dequeue zero copy cannot work in VM2NIC mode due to no iommu dma mapping is setup for guest memory currently. Signed-off-by: Junjie Chen Reviewed-by: Maxime Coquelin John,

Re: [dpdk-dev] [PATCH v3 0/5] vhost: support selective datapath

2018-03-29 Thread Wodkowski, PawelX
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Zhihong Wang > Sent: Tuesday, February 27, 2018 11:14 AM > To: dev@dpdk.org > Cc: Tan, Jianfeng ; Bie, Tiwei ; > maxime.coque...@redhat.com; y...@fridaylinux.org; Liang, Cunming > ; Wang, Xiao W ; Daly, > Dan ; Wang

Re: [dpdk-dev] [PATCH 1/3] vhost: do not generate signal when sendmsg fails

2018-03-29 Thread Maxime Coquelin
Hi Tiwei, On 03/06/2018 11:43 AM, Tiwei Bie wrote: Signed-off-by: Tiwei Bie Could you please elaborate a bit more why this is needed? Is it fixing a real issue or just an improvement? Thanks! Maxime --- lib/librte_vhost/socket.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

Re: [dpdk-dev] [PATCH 2/3] vhost: support sending fds via send_vhost_message()

2018-03-29 Thread Maxime Coquelin
On 03/06/2018 11:43 AM, Tiwei Bie wrote: This function will be used to send fds to QEMU via slave channel. Signed-off-by: Tiwei Bie Reviewed-by: Maxime Coquelin Thanks, Maxime --- lib/librte_vhost/vhost_user.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a

Re: [dpdk-dev] [PATCH 2/3] vhost: support sending fds via send_vhost_message()

2018-03-29 Thread Maxime Coquelin
On 03/06/2018 11:43 AM, Tiwei Bie wrote: This function will be used to send fds to QEMU via slave channel. Signed-off-by: Tiwei Bie --- lib/librte_vhost/vhost_user.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) Applied to dpdk-next-virtio/master, so this is one less patc

Re: [dpdk-dev] [PATCH] net/vhost: fix segfault when creating vdev dynamically

2018-03-29 Thread Maxime Coquelin
On 03/27/2018 04:01 PM, Tan, Jianfeng wrote: On 3/27/2018 7:28 PM, Maxime Coquelin wrote: On 03/27/2018 11:42 AM, Tan, Jianfeng wrote: On 3/27/2018 5:24 PM, Chen, Junjie J wrote: On 3/28/2018 12:05 AM, Junjie Chen wrote: when creating vdev dynamically, vhost pmd driver start directly

Re: [dpdk-dev] [PATCH] eventdev: fix incorrect MP/MC tail updates in rte_event_ring

2018-03-29 Thread Van Haaren, Harry
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Mattias Rönnblom > Sent: Wednesday, March 28, 2018 10:17 AM > To: dev@dpdk.org > Cc: Mattias Rönnblom > Subject: [dpdk-dev] [PATCH] eventdev: fix incorrect MP/MC tail updates in > rte_event_ring > > rte_event_ring enqueue and dequeue tail upd

[dpdk-dev] [PATCH v4 0/8] vhost: intdroduce vhost user crypto backend

2018-03-29 Thread Fan Zhang
This patchset adds crypto backend suppport to vhost library including a proof-of-concept sample application. The implementation follows the virtio-crypto specification and have been tested with qemu 2.11.50 (with several patches applied, detailed later) with Fedora 24 running in the frontend. The

[dpdk-dev] [PATCH v4 1/8] lib/librte_vhost: add external backend support

2018-03-29 Thread Fan Zhang
This patch adds external backend support to vhost library. The patch provides new APIs for the external backend to register pre and post vhost-user message handlers. Signed-off-by: Fan Zhang --- lib/librte_vhost/rte_vhost.h | 64 +- lib/librte_vhost/rte_

[dpdk-dev] [PATCH v4 2/8] lib/librte_vhost: add virtio-crypto user message structure

2018-03-29 Thread Fan Zhang
This patch adds virtio-crypto spec user message structure to vhost_user. Signed-off-by: Fan Zhang --- lib/librte_vhost/vhost_user.h | 36 1 file changed, 32 insertions(+), 4 deletions(-) diff --git a/lib/librte_vhost/vhost_user.h b/lib/librte_vhost/vhost_use

[dpdk-dev] [PATCH v4 3/8] lib/librte_vhost: add session message handler

2018-03-29 Thread Fan Zhang
This patch adds session message handler to vhost crypto. Signed-off-by: Fan Zhang --- lib/librte_vhost/vhost_crypto.c | 428 1 file changed, 428 insertions(+) create mode 100644 lib/librte_vhost/vhost_crypto.c diff --git a/lib/librte_vhost/vhost_crypto.

[dpdk-dev] [PATCH v4 4/8] lib/librte_vhost: add request handler

2018-03-29 Thread Fan Zhang
This patch adds the implementation that parses virtio crypto request to dpdk crypto operation. Signed-off-by: Fan Zhang --- lib/librte_vhost/vhost_crypto.c | 609 1 file changed, 609 insertions(+) diff --git a/lib/librte_vhost/vhost_crypto.c b/lib/librte

[dpdk-dev] [PATCH v4 6/8] lib/librte_vhost: update makefile

2018-03-29 Thread Fan Zhang
This patch updates the Makefile of vhost library to enable vhost crypto compiling. Signed-off-by: Fan Zhang --- lib/librte_vhost/Makefile| 6 -- lib/librte_vhost/meson.build | 8 2 files changed, 8 insertions(+), 6 deletions(-) diff --git a/lib/librte_vhost/Makefile b/lib/librt

[dpdk-dev] [PATCH v4 5/8] lib/librte_vhost: add public function implementation

2018-03-29 Thread Fan Zhang
This patch adds public API implementation to vhost crypto. Signed-off-by: Fan Zhang --- lib/librte_vhost/rte_vhost_crypto.h| 125 + lib/librte_vhost/rte_vhost_version.map | 5 + lib/librte_vhost/vhost_crypto.c| 248 + 3 files changed,

[dpdk-dev] [PATCH v4 7/8] examples/vhost_crypto: add vhost crypto sample application

2018-03-29 Thread Fan Zhang
This patch adds vhost_crypto sample application to DPDK. Signed-off-by: Fan Zhang --- examples/vhost_crypto/Makefile| 32 +++ examples/vhost_crypto/main.c | 541 ++ examples/vhost_crypto/meson.build | 14 + 3 files changed, 587 insertions(+) create

[dpdk-dev] [PATCH v4 8/8] doc: update for vhost crypto support

2018-03-29 Thread Fan Zhang
Signed-off-by: Fan Zhang --- doc/guides/prog_guide/vhost_lib.rst | 21 doc/guides/rel_notes/release_18_05.rst| 10 doc/guides/sample_app_ug/index.rst| 1 + doc/guides/sample_app_ug/vhost_crypto.rst | 84 +++ 4 files changed, 116 inserti

Re: [dpdk-dev] [PATCH] vhost: fix segfault as handle set_mem_table message

2018-03-29 Thread Wodkowski, PawelX
> > DPDK vhost-user handles this message rudely by unmap all existing > > regions and map new ones. This might lead to segfault if there > > is pmd thread just trying to touch those unmapped memory regions. > > > > But for most cases, except VM memory hotplug, > >> > >> FYI, Vic

Re: [dpdk-dev] [PATCH] vhost: fix segfault as handle set_mem_table message

2018-03-29 Thread Tan, Jianfeng
On 3/29/2018 3:35 PM, Maxime Coquelin wrote: On 03/29/2018 09:01 AM, Tan, Jianfeng wrote: Hi Maxime and Victor, -Original Message- From: Maxime Coquelin [mailto:maxime.coque...@redhat.com] Sent: Tuesday, December 5, 2017 10:28 PM To: Yuanhan Liu; Tan, Jianfeng; Victor Kaplansky Cc:

Re: [dpdk-dev] [PATCH] devtools: do not create kernel dir

2018-03-29 Thread Ferruh Yigit
On 3/29/2018 11:36 AM, Pablo de Lara wrote: > get-maintainer script requires the creation of > some folders, including "kernel". Since now this folder > exists in DPDK folder, it is not required to create it. > > Signed-off-by: Pablo de Lara Acked-by: Ferruh Yigit

Re: [dpdk-dev] [PATCH v2] net/vhost: fix segfault when creating vdev dynamically

2018-03-29 Thread Maxime Coquelin
Hi Junjie, Thanks for the patch, it looks like the right thing to do. Please find my comments below: On 03/29/2018 05:35 PM, Junjie Chen wrote: when creating vdev dynamically, vhost pmd driver start directly without s/when/When/ s/start/starts/ checking TX/RX queues ready or not, and thus ca

Re: [dpdk-dev] [PATCH v3 4/4] net/vhost: add NULL pointer checking

2018-03-29 Thread Maxime Coquelin
Hi, On 03/21/2018 04:03 AM, zhiyong.y...@intel.com wrote: When vhost user PMD works in client mode to connect/reconnect virtio-user with server mode, new thread sometimes may run to new_device before queue_setup has been done, So have to wait until memory allocation is done. Release note is upd

Re: [dpdk-dev] [PATCH] vhost: fix segfault as handle set_mem_table message

2018-03-29 Thread Tan, Jianfeng
On 3/29/2018 8:57 PM, Wodkowski, PawelX wrote: DPDK vhost-user handles this message rudely by unmap all existing regions and map new ones. This might lead to segfault if there is pmd thread just trying to touch those unmapped memory regions. But for most cases, except VM memory hotplug, FYI,

Re: [dpdk-dev] [PATCH 1/3] vhost: do not generate signal when sendmsg fails

2018-03-29 Thread Tiwei Bie
On Thu, Mar 29, 2018 at 02:19:35PM +0200, Maxime Coquelin wrote: > Hi Tiwei, > > On 03/06/2018 11:43 AM, Tiwei Bie wrote: > > Signed-off-by: Tiwei Bie > > Could you please elaborate a bit more why this is needed? > Is it fixing a real issue or just an improvement? My bad, I really should write

Re: [dpdk-dev] [PATCH v2 2/2] ethdev: add new offload flag to keep CRC

2018-03-29 Thread Ferruh Yigit
On 3/29/2018 8:56 AM, Shahaf Shuler wrote: > Thursday, March 29, 2018 10:43 AM, Thomas Monjalon: >> 29/03/2018 07:38, Shahaf Shuler: >>> Wednesday, March 21, 2018 9:48 PM, Ferruh Yigit: DEV_RX_OFFLOAD_KEEP_CRC offload flag added. DEV_RX_OFFLOAD_CRC_STRIP flag will remain one more rel

Re: [dpdk-dev] [PATCH V16 3/4] eal/linux: uevent parse and process

2018-03-29 Thread Van Haaren, Harry
Two additional input along with Jianfeng's existing comments; > -Original Message- > From: Tan, Jianfeng > Sent: Wednesday, March 28, 2018 5:16 PM > To: Guo, Jia ; step...@networkplumber.org; Richardson, > Bruce ; Yigit, Ferruh ; > Ananyev, Konstantin ; gaetan.ri...@6wind.com; > Wu, Jingji

[dpdk-dev] [PATCH] mlx: fix warnings for unused compiler arguments

2018-03-29 Thread Bruce Richardson
When linking the mlx glue code libraries using CC, the linker arguments in LDFLAGS are not prefixed with -Wl. [The EXTRA_LDFLAGS are though.] This leads to warning messages on build: clang-5.0: warning: argument unused during compilation: '-e xport-dynamic' Fix this by checking for $LINK_USING_CC

Re: [dpdk-dev] [PATCH 1/3] vhost: do not generate signal when sendmsg fails

2018-03-29 Thread Maxime Coquelin
On 03/29/2018 03:25 PM, Tiwei Bie wrote: On Thu, Mar 29, 2018 at 02:19:35PM +0200, Maxime Coquelin wrote: Hi Tiwei, On 03/06/2018 11:43 AM, Tiwei Bie wrote: Signed-off-by: Tiwei Bie Could you please elaborate a bit more why this is needed? Is it fixing a real issue or just an improvement?

Re: [dpdk-dev] [PATCH 1/3] vhost: do not generate signal when sendmsg fails

2018-03-29 Thread Maxime Coquelin
On 03/06/2018 11:43 AM, Tiwei Bie wrote: Signed-off-by: Tiwei Bie --- lib/librte_vhost/socket.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_vhost/socket.c b/lib/librte_vhost/socket.c index 0354740fa..d703d2114 100644 --- a/lib/librte_vhost/socket.c +++ b/l

Re: [dpdk-dev] [PATCH v4 1/8] lib/librte_vhost: add external backend support

2018-03-29 Thread Wodkowski, PawelX
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Fan Zhang > Sent: Thursday, March 29, 2018 2:53 PM > To: dev@dpdk.org > Cc: maxime.coque...@redhat.com; jianjay.z...@huawei.com; Tan, Jianfeng > > Subject: [dpdk-dev] [PATCH v4 1/8] lib/librte_vhost: add external b

Re: [dpdk-dev] [PATCH 1/3] vhost: do not generate signal when sendmsg fails

2018-03-29 Thread Tiwei Bie
On Thu, Mar 29, 2018 at 03:41:23PM +0200, Maxime Coquelin wrote: > On 03/29/2018 03:25 PM, Tiwei Bie wrote: > > On Thu, Mar 29, 2018 at 02:19:35PM +0200, Maxime Coquelin wrote: > > > Hi Tiwei, > > > > > > On 03/06/2018 11:43 AM, Tiwei Bie wrote: > > > > Signed-off-by: Tiwei Bie > > > > > > Could

[dpdk-dev] [PATCH] build: remove checks for non-optional libraries

2018-03-29 Thread Bruce Richardson
Unless a library cannot be built for a specific platform (generally BSD), it will always be available. Therefore remove checks for IP fragmentation and ACL libraries, since these are built for all platforms. Signed-off-by: Bruce Richardson --- lib/librte_port/meson.build | 12 +--- lib/

[dpdk-dev] [PATCH 1/6] examples: add empty meson files for unsupported examples

2018-03-29 Thread Bruce Richardson
Signed-off-by: Bruce Richardson --- examples/ethtool/meson.build| 10 ++ examples/multi_process/meson.build | 10 ++ examples/netmap_compat/meson.build | 10 ++ examples/performance-thread/meson.build | 10 ++ examples/quota_watermark/meson.bu

[dpdk-dev] [PATCH 0/6] enable easier app compilation testing with meson

2018-03-29 Thread Bruce Richardson
Summary: With this set you can test building all applicable examples by calling meson with "-Dexamples=all" When building DPDK with meson, it's possible to specify a list of sample apps to have built along with the main code. However, specifying a full list of all apps can be unwie

[dpdk-dev] [PATCH 2/6] examples/l2fwd-cat: make build dependent on pqos library

2018-03-29 Thread Bruce Richardson
The l2fwd-cat example uses the pqos library to work, so make the meson build dependent on the presence of that library Signed-off-by: Bruce Richardson --- examples/l2fwd-cat/meson.build | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/examples/l2fwd-cat/meson.build b/exampl

[dpdk-dev] [PATCH 3/6] examples: disable unsupported examples on BSD

2018-03-29 Thread Bruce Richardson
Signed-off-by: Bruce Richardson --- examples/kni/meson.build | 3 +++ examples/l3fwd-power/meson.build | 3 +++ examples/tep_termination/meson.build | 3 +++ examples/vhost/meson.build | 3 +++ examples/vhost_scsi/meson.build | 3 +++ 5 files changed, 15 insertions(

[dpdk-dev] [PATCH 4/6] examples: allow building all examples as part of meson build

2018-03-29 Thread Bruce Richardson
To test building all relevant example applications as part of a build, we add support for the "all" keyword to be passed to the "examples" build option. Since not all examples can actually be built on all systems, we also add support for the "build" option inside the sub-dirs. However, in case wher

[dpdk-dev] [PATCH 5/6] examples: improve error report for missing meson deps

2018-03-29 Thread Bruce Richardson
When a required library is missing on a platform, rather than having meson report an error about the missing variable, catch the problem earlier and provide a more readable message. Signed-off-by: Bruce Richardson --- examples/meson.build | 7 +-- 1 file changed, 5 insertions(+), 2 deletions

[dpdk-dev] [PATCH 6/6] drivers/dpaa*: reduce meson dependency lists

2018-03-29 Thread Bruce Richardson
Meson build currently tracks the dependencies between libraries, which can often make things easier, but has the side-effect of slowing down the initial meson run if too many duplicated dependencies are provided. Therefore, we remove dependencies from the dpaa items where other dependencies already

[dpdk-dev] [PATCH 1/2] examples/ethtool: add to meson build

2018-03-29 Thread Bruce Richardson
Add the ethtool example to the meson build. This example is more complicated than the previously added ones as it has files in two subdirectories. An ethtool "wrapper lib" in one, used by the actual example "ethtool app" in the other. Rather than using recursive operation, like is done with the ma

[dpdk-dev] [PATCH 0/2] support building ethtool example using meson

2018-03-29 Thread Bruce Richardson
Add support for building the ethtool example as part of a meson build, or separately using the pkgconfig file produced by meson. Bruce Richardson (2): examples/ethtool: add to meson build examples/ethtool: enable build using pkg-config vars examples/ethtool/Makefile| 50 +

[dpdk-dev] [PATCH 2/2] examples/ethtool: enable build using pkg-config vars

2018-03-29 Thread Bruce Richardson
When provided as an example in a DPDK package, the build of the example app should use the pkg-config-supplied values from the package. As with other examples, set up makefile to allow compilation either using pkg-config or old $RTE_SDK/$RTE_TARGET values. Signed-off-by: Bruce Richardson --- exa

Re: [dpdk-dev] [PATCH 3/4] ether: add more protocol support in flow API

2018-03-29 Thread Pattan, Reshma
Hi, > + > + /** > + * Matches ARP IPv4 header. > + * > + * See struct rte_flow_item_arp. > + */ > + TE_FLOW_ITEM_TYPE_ARP, > + R is missing in name RTE_, similary in other places. + /** +* Match ICMPv6 Source Link-Layer Address. +* +* See

Re: [dpdk-dev] [PATCH v2] event/opdl: fix atomic queue race condition issue

2018-03-29 Thread Van Haaren, Harry
> From: Ma, Liang J > Sent: Tuesday, March 27, 2018 3:18 PM > To: jerin.ja...@caviumnetworks.com > Cc: dev@dpdk.org; Van Haaren, Harry ; Jain, > Deepak K ; Geary, John ; > Mccarthy, Peter > Subject: [PATCH v2] event/opdl: fix atomic queue race condition issue > > If application link one atomic qu

[dpdk-dev] [PATCH v2] ethdev: replace bus specific struct with generic dev

2018-03-29 Thread Ferruh Yigit
Public struct rte_eth_dev_info has a "struct rte_pci_device" field in it although it is common for all ethdev in all buses. Replacing pci specific struct with generic device struct and updating places that are using pci device in a way to get this information from generic device. Signed-off-by: F

Re: [dpdk-dev] [PATCH v6 4/8] ethdev: Add port representor device flag

2018-03-29 Thread Doherty, Declan
On 29/03/2018 7:13 AM, Shahaf Shuler wrote: Wednesday, March 28, 2018 4:54 PM, Declan Doherty: Subject: [dpdk-dev][PATCH v6 4/8] ethdev: Add port representor device flag Add new device flag to specify that ethdev port is a port representor. Extend rte_eth_dev_info structure to expose device fla

Re: [dpdk-dev] Bug in "rte_eth_dev_attach" while using mlx5 pmd driver?

2018-03-29 Thread Thomas Monjalon
Hi, 29/03/2018 09:00, Sam: > Hi all, > > I'm using OVS-2.8.0 + DPDK-17.05-rc1, with 2 pf and 1 vf port under mlx5 > pmd driver, like this: I did not really look at your issue because you are using a DPDK release candidate. When looking at http://docs.openvswitch.org/en/latest/faq/releases/ we c

Re: [dpdk-dev] [PATCH v4 3/8] lib/librte_vhost: add session message handler

2018-03-29 Thread Tan, Jianfeng
For the title prefix, "vhost" is just fine. On 3/29/2018 8:52 PM, Fan Zhang wrote: This patch adds session message handler to vhost crypto. Signed-off-by: Fan Zhang --- lib/librte_vhost/vhost_crypto.c | 428 1 file changed, 428 insertions(+) creat

Re: [dpdk-dev] [PATCH V16 3/4] eal/linux: uevent parse and process

2018-03-29 Thread Guo, Jia
hi, harry thanks for your review. On 3/29/2018 9:32 PM, Van Haaren, Harry wrote: Two additional input along with Jianfeng's existing comments; -Original Message- From: Tan, Jianfeng Sent: Wednesday, March 28, 2018 5:16 PM To: Guo, Jia ; step...@networkplumber.org; Richardson, Bruce ; Y

Re: [dpdk-dev] [PATCH V16 3/4] eal/linux: uevent parse and process

2018-03-29 Thread Guo, Jia
jianfeng On 3/29/2018 12:15 AM, Tan, Jianfeng wrote: BTW, adding new .c file needs to update meson.build now. thanks for your info . On 3/26/2018 7:20 PM, Jeff Guo wrote: In order to handle the uevent which have been detected from the kernel side, add uevent parse and process function to tr

Re: [dpdk-dev] [PATCH v6 2/8] ethdev: add switch identifier parameter to port

2018-03-29 Thread Doherty, Declan
On 29/03/2018 11:12 AM, Shahaf Shuler wrote: Thursday, March 29, 2018 12:14 PM, Doherty, Declan: On 29/03/2018 7:13 AM, Shahaf Shuler wrote: Hi Declan, Thanks for the series! See some comments below Wednesday, March 28, 2018 4:54 PM, Declan Doherty: Subject: [dpdk-dev][PATCH v6 2/8] ethdev:

Re: [dpdk-dev] [PATCH 4/4] ether: add packet modification aciton in flow API

2018-03-29 Thread Pattan, Reshma
Hi, > Subject: [dpdk-dev] [PATCH 4/4] ether: add packet modification aciton in flow Typo in the commit message header "action" > +/** RTE_FLOW_ACTION_TYPE_FIELD_INCREMENT > + * > + * Increment 1 on specific field of the packet. > + * > + * Typical usage: increase TTL > + */ > +struct rte_flow_ac

Re: [dpdk-dev] [PATCH v3 3/7] net/dpaa2: change into dynamic logging

2018-03-29 Thread Thomas Monjalon
23/03/2018 13:04, Shreyansh Jain: > --- a/config/common_base > +++ b/config/common_base > @@ -189,11 +189,6 @@ CONFIG_RTE_LIBRTE_DPAA2_USE_PHYS_IOVA=y > # Compile burst-oriented NXP DPAA2 PMD driver > # > CONFIG_RTE_LIBRTE_DPAA2_PMD=n > -CONFIG_RTE_LIBRTE_DPAA2_DEBUG_INIT=n > -CONFIG_RTE_LIBRTE_

[dpdk-dev] [PATCH] mk: fix kernel modules build dependency

2018-03-29 Thread Thomas Monjalon
Some kernel modules may need some header files to be "installed" in the build directory. When running multiple threads of make, kernel modules can try to be compiled before the lib headers are ready: make -j3 kernel/linux/kni/kni_misc.c:19:37: fatal error: exec-env/

Re: [dpdk-dev] [PATCH] mk: fix kernel modules build dependency

2018-03-29 Thread Ferruh Yigit
On 3/29/2018 4:39 PM, Thomas Monjalon wrote: > Some kernel modules may need some header files to be "installed" > in the build directory. > > When running multiple threads of make, kernel modules can try to > be compiled before the lib headers are ready: > make -j3 > kernel/linux/kni/k

[dpdk-dev] [PATCH 0/3] ZUC PMD fixes

2018-03-29 Thread Pablo de Lara
ZUC library provides an API to encrypt buffers in parallel with different keys. However, the PMD was developed assuming that all needed to share the same session (therefore, the same key). This patchset fixes this behaviour by allowing multiple buffers with different keys to be processed in parall

[dpdk-dev] [PATCH 1/3] crypto/zuc: do not set default op status

2018-03-29 Thread Pablo de Lara
When crypto operations are allocated from the operation pool, their status get reset to NOT_PROCESSED. Therefore, there is no need to set this status again. Fixes: cf7685d68f00 ("crypto/zuc: add driver for ZUC library") Cc: sta...@dpdk.org Signed-off-by: Pablo de Lara --- drivers/crypto/zuc/rte

[dpdk-dev] [PATCH 2/3] crypto/zuc: remove unnecessary check

2018-03-29 Thread Pablo de Lara
When processing operations, the operation type was being checked to avoid if it was set to NOT SUPPORTED. In data path, doing so is not required since that is already checked when creating the crypto session, so that case will not ever happen. Fixes: cf7685d68f00 ("crypto/zuc: add driver for ZUC l

[dpdk-dev] [PATCH 3/3] crypto/zuc: batch ops with same transform

2018-03-29 Thread Pablo de Lara
The ZUC API to encrypt packets does not require the operations to share the same key. Currently, the operations were being batched only when they shared the same key, but this is not needed. Instead, now operations will be batched based on the transform (cipher only, auth only...). Fixes: cf7685d

[dpdk-dev] [PATCH V17 0/4] add device event monitor framework

2018-03-29 Thread Jeff Guo
About hot plug in dpdk, We already have proactive way to add/remove devices through APIs (rte_eal_hotplug_add/remove), and also have fail-safe driver to offload the fail-safe work from the app user. But there are still lack of a general mechanism to monitor hotplug event for all driver, now the hot

  1   2   3   >