Re: [dpdk-dev] [PATCH v2 13/41] eal: replace memseg with memseg lists

2018-03-24 Thread Burakov, Anatoly
On 24-Mar-18 6:01 AM, santosh wrote: Hi Anatoly, Thanks for good work!. Few observations: # Noticed performance regression for thunderx platform for l3fwd application, drops by 3%. git bisect shows this changeset is offending commit. I'm still investigating reason for perf-dip.. Would like to kn

Re: [dpdk-dev] [PATCH] ethdev: fix queue start

2018-03-24 Thread Ananyev, Konstantin
> > Device must be started before start any queue. > > Fixes: 0748be2cf9a2 ("ethdev: queue start and stop") > Cc: sta...@dpdk.org > > Signed-off-by: Qi Zhang > --- > lib/librte_ether/rte_ethdev.c | 12 > 1 file changed, 12 insertions(+) > > diff --git a/lib/librte_ether/rte_eth

Re: [dpdk-dev] [PATCH v2 13/41] eal: replace memseg with memseg lists

2018-03-24 Thread santosh
On Saturday 24 March 2018 04:38 PM, Burakov, Anatoly wrote: > On 24-Mar-18 6:01 AM, santosh wrote: >> Hi Anatoly, >> >> Thanks for good work!. >> Few observations: >> # Noticed performance regression for thunderx platform for l3fwd application, >> drops by 3%. git bisect shows this changeset is o

Re: [dpdk-dev] [PATCH v2 13/41] eal: replace memseg with memseg lists

2018-03-24 Thread Burakov, Anatoly
On 24-Mar-18 12:23 PM, santosh wrote: On Saturday 24 March 2018 04:38 PM, Burakov, Anatoly wrote: On 24-Mar-18 6:01 AM, santosh wrote: Hi Anatoly, Thanks for good work!. Few observations: # Noticed performance regression for thunderx platform for l3fwd application, drops by 3%. git bisect sh

[dpdk-dev] [PATCH v5 2/2] eal: add asynchronous request API to DPDK IPC

2018-03-24 Thread Anatoly Burakov
This API is similar to the blocking API that is already present, but reply will be received in a separate callback by the caller (callback specified at the time of request, rather than registering for it in advance). Under the hood, we create a separate thread to deal with replies to asynchronous

[dpdk-dev] [PATCH v5 1/2] eal: rename IPC sync request to pending request

2018-03-24 Thread Anatoly Burakov
Signed-off-by: Anatoly Burakov Suggested-by: Jianfeng Tan --- lib/librte_eal/common/eal_common_proc.c | 38 - 1 file changed, 19 insertions(+), 19 deletions(-) diff --git a/lib/librte_eal/common/eal_common_proc.c b/lib/librte_eal/common/eal_common_proc.c index 4

Re: [dpdk-dev] [PATCH v4] eal: add asynchronous request API to DPDK IPC

2018-03-24 Thread Burakov, Anatoly
A few of my yesterday's replies made no sense... Lesson learned: don't reply to code review comments on a late friday evening :) On 23-Mar-18 6:21 PM, Burakov, Anatoly wrote: On 23-Mar-18 3:38 PM, Tan, Jianfeng wrote: We do. However, we have to wait for *something* if there aren't any asynchr

Re: [dpdk-dev] [PATCH v2] net/i40e: fix issue during customized info update

2018-03-24 Thread Zhang, Helin
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Wu, Jingjing > Sent: Wednesday, February 7, 2018 5:50 PM > To: Xing, Beilei; Zhang, Qi Z > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2] net/i40e: fix issue during customized info > update