Re: [dpdk-dev] [PATCH v2 00/10] Introduce generic 'rawdevice' support

2018-01-30 Thread Shreyansh Jain
On Tuesday 30 January 2018 05:19 AM, Thomas Monjalon wrote: 25/01/2018 23:21, Thomas Monjalon: 23/01/2018 14:59, Shreyansh Jain: Defining a very generic super-set of device type and its device operations that can be exposed such that any new/upcoming/experimental device can be layered over it.

Re: [dpdk-dev] [PATCH] app/testpmd: move variables definition in source

2018-01-30 Thread Georgios Katsikas
Hi, This is a kind reminder to review this short patch. There seems to be 1 build failure out of 15, but the error looks irrelevant to the patch according to: http://dpdk.org/dev/patchwork/patch/34403/ Please let me know if there is something I could fix. Best regards, Georgios On Wed, Jan 24, 2

Re: [dpdk-dev] [PATCH] app/eventdev: fix port dequeue depth configuration

2018-01-30 Thread Jerin Jacob
-Original Message- > Date: Wed, 24 Jan 2018 15:00:33 +0530 > From: Pavan Nikhilesh > To: jerin.ja...@caviumnetworks.com, harry.van.haa...@intel.com > Cc: dev@dpdk.org, Pavan Nikhilesh > Subject: [dpdk-dev] [PATCH] app/eventdev: fix port dequeue depth > configuration > X-Mailer: git-send-

Re: [dpdk-dev] [PATCH 5/5] config: enable dpaaX drivers compilation for ARMv8

2018-01-30 Thread Hemant Agrawal
Hi Jerin, On 1/25/2018 4:51 PM, Jerin Jacob wrote: -Original Message- Date: Thu, 25 Jan 2018 15:23:31 +0530 From: Hemant Agrawal To: dev@dpdk.org CC: jerin.ja...@caviumnetworks.com Subject: [PATCH 5/5] config: enable dpaaX drivers compilation for ARMv8 X-Mailer: git-send-email 2.7.4 T

[dpdk-dev] [PATCH v3] app/testpmd: do not enable Rx offloads by default

2018-01-30 Thread Moti Haimovsky
Removed the hardcoded preconfigured Rx offload configuration from testpmd and changed the Rx offload command line parameters from disable to enable. Testers who wish to use these offloads will now have to explicitly write them in the command-line when running testpmd. Motivation: Some PMDs such at

[dpdk-dev] [PATCH] ring: fix compilation error with a broken else clause

2018-01-30 Thread Gowrishankar
From: Gowrishankar Muthukrishnan Calling rte_smp_wmb macro expands into a compound block, which would break compiling a else clause following it, if that calling place has been terminated already with ";", as in below code. This patch adds { } around this macro to allow compiling else too. Fixes

Re: [dpdk-dev] [PATCH] net/tap: define __NR_bpf for powerpc

2018-01-30 Thread Pascal Mazon
Acked-by: Pascal Mazon On 30/01/2018 08:05, Gowrishankar wrote: > From: Gowrishankar Muthukrishnan > > This patch defines __NR_bpf for powerpc architecture and hence, > fixes compiling tap driver for this architecture. > > Fixes: b02d85e1 ("net/tap: add eBPF API") > > Signed-off-by: Gowrishankar

Re: [dpdk-dev] [PATCH] ring: fix compilation error with a broken else clause

2018-01-30 Thread Jerin Jacob
-Original Message- > Date: Tue, 30 Jan 2018 14:18:46 +0530 > From: Gowrishankar > To: dev@dpdk.org > CC: Olivier Matz , tho...@monjalon.net, > Gowrishankar Muthukrishnan > Subject: [dpdk-dev] [PATCH] ring: fix compilation error with a broken else > clause > X-Mailer: git-send-email 1.9.

[dpdk-dev] [PATCH] eal/ppc64: revert implement arch-specific TSC freq query

2018-01-30 Thread Gowrishankar
From: Gowrishankar Muthukrishnan This reverts commit 15692396fd68932b6a81f00f12d4b0da12baa7d3 (eal/ppc64: implement arch-specific TSC freq query). We intended to derive pkt/sec estimation with cpu clock frequency. As timebase register serves the timer purpose, we need to stick with it for calcula

[dpdk-dev] [PATCH v4] app/testpmd: do not enable Rx offloads by default

2018-01-30 Thread Moti Haimovsky
Removed the hardcoded preconfigured Rx offload configuration from testpmd and changed the Rx offload command line parameters from disable to enable. Testers who wish to use these offloads will now have to explicitly write them in the command-line when running testpmd. Motivation: Some PMDs such at

Re: [dpdk-dev] [PATCH] ring: fix compilation error with a broken else clause

2018-01-30 Thread gowrishankar muthukrishnan
On Tuesday 30 January 2018 02:26 PM, Jerin Jacob wrote: -Original Message- Date: Tue, 30 Jan 2018 14:18:46 +0530 From: Gowrishankar To: dev@dpdk.org CC: Olivier Matz , tho...@monjalon.net, Gowrishankar Muthukrishnan Subject: [dpdk-dev] [PATCH] ring: fix compilation error with a broke

Re: [dpdk-dev] [PATCH] ring: fix compilation error with a broken else clause

2018-01-30 Thread Thomas Monjalon
30/01/2018 10:09, gowrishankar muthukrishnan: > On Tuesday 30 January 2018 02:26 PM, Jerin Jacob wrote: > > -Original Message- > >> Date: Tue, 30 Jan 2018 14:18:46 +0530 > >> From: Gowrishankar > >> To: dev@dpdk.org > >> CC: Olivier Matz , tho...@monjalon.net, > >> Gowrishankar Muthukris

[dpdk-dev] [PATCH] net/avf: fix unchecked return value issue

2018-01-30 Thread Jingjing Wu
This patch fixes the coverity CHECKED_RETURN issue. Coverity issue: 257045 Fixes: 48de41ca11f0 ("net/avf: enable link status update") Reported-by: John McNamara Signed-off-by: Jingjing Wu --- drivers/net/avf/avf_ethdev.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git

Re: [dpdk-dev] [PATCH 11/17] net/mlx5: use SPDX tags on 6WIND copyrighted files

2018-01-30 Thread Nélio Laranjeiro
On Mon, Jan 29, 2018 at 02:11:30PM +0100, Olivier Matz wrote: > Cc: Adrien Mazarguil > Cc: Nelio Laranjeiro > Cc: Yongseok Koh > > Signed-off-by: Olivier Matz Acked-by: Nelio Laranjeiro -- Nélio Laranjeiro 6WIND

[dpdk-dev] Some flow rules not supported by igb_uio

2018-01-30 Thread george . dit
Hi, I am testing rte flow API across different DPDK-based NICs using some rules. I noticed that flow rules that match L2 information, such as rule: flow create 0 ingress pattern eth type is 0x800 / end actions queue index 6 / end does not work on an Intel 82599ES (igb_uio driver), while a Mellan

Re: [dpdk-dev] [dpdk-stable] [PATCH v3] net/mlx4: fix dev rmv not detected after port stop

2018-01-30 Thread Thomas Monjalon
29/01/2018 11:54, Shahaf Shuler: > Mordechay Haimovsky, Monday, January 29, 2018 10:35 AM: > > In failsafe device start can be called for ports/devices that had been > > plugged > > out. > > The mlx4 PMD detects device removal by listening to the device RMV events, > > when the mlx4 port is being

Re: [dpdk-dev] [PATCH v2] doc: update flow filting document

2018-01-30 Thread Ori Kam
Hi Wei, You have a typo in the patch subject and comment, It should be filtering Ori > -Original Message- > From: Wei Zhao [mailto:wei.zh...@intel.com] > Sent: Tuesday, January 30, 2018 9:45 AM > To: dev@dpdk.org > Cc: Ori Kam ; sta...@dpdk.org; > john.mcnam...@intel.com; Wei Zhao > Su

Re: [dpdk-dev] [PATCH v5 1/5] lib: add Port Representor library

2018-01-30 Thread Andrew Rybchenko
On 01/10/2018 06:54 PM, Remy Horton wrote: Port Representors provide a logical presentation in DPDK of VF (virtual function) ports for the purposes of control and monitoring. Each port representor device represents a single VF and is associated with it's parent physical function (PF) PMD which pr

[dpdk-dev] [PATCH] crypto/dpaa2_sec: fix build with GCC 6 or prior

2018-01-30 Thread Hemant Agrawal
This patch fixes the compilation with compiler GCC < 7 dpaa2_sec/hw/rta/operation_cmd.h:12:32: error: unknown option after ‘#pragma GCC diagnostic’ kind [-Werror=pragmas] #pragma GCC diagnostic ignored "-Wimplicit-fallthrough" Fixes: 2ab9a9483196 ("crypto/dpaa2_sec: fix build with GCC 7") Sign

Re: [dpdk-dev] [PATCH 5/5] config: enable dpaaX drivers compilation for ARMv8

2018-01-30 Thread Hemant Agrawal
On 1/30/2018 2:12 PM, Hemant Agrawal wrote: Hi Jerin, On 1/25/2018 4:51 PM, Jerin Jacob wrote: -Original Message- Date: Thu, 25 Jan 2018 15:23:31 +0530 From: Hemant Agrawal To: dev@dpdk.org CC: jerin.ja...@caviumnetworks.com Subject: [PATCH 5/5] config: enable dpaaX drivers compilatio

Re: [dpdk-dev] [PATCH v3] net/mlx4: fix dev rmv not detected after port stop

2018-01-30 Thread Adrien Mazarguil
Hi, On Mon, Jan 29, 2018 at 10:54:16AM +, Shahaf Shuler wrote: > Mordechay Haimovsky, Monday, January 29, 2018 10:35 AM: > > In failsafe device start can be called for ports/devices that had been > > plugged > > out. > > The mlx4 PMD detects device removal by listening to the device RMV event

Re: [dpdk-dev] [PATCH] app/testpmd: add missing args to TM show cap cmd

2018-01-30 Thread Singh, Jasvinder
> -Original Message- > From: Tomasz Duszynski [mailto:t...@semihalf.com] > Sent: Sunday, January 28, 2018 3:08 PM > To: dev@dpdk.org > Cc: Lu, Wenzhuo ; Wu, Jingjing > ; Mcnamara, John ; > Kovacevic, Marko ; Tomasz Duszynski > ; Singh, Jasvinder > Subject: [PATCH] app/testpmd: add missin

[dpdk-dev] [PATCH] igb_uio: fix uevent montior issue

2018-01-30 Thread Jeff Guo
udev could not detect remove and add event of device when hotplug in and out devices, that related with the fix about using pointer of rte_uio_pci_dev as dev_id instead of uio_device for irq device handler, that would result igb uio irq failure to deliver the uevent to udev when kernel version afte

Re: [dpdk-dev] [PATCH] app/testpmd: add meter to the actions table

2018-01-30 Thread Adrien Mazarguil
On Sun, Jan 28, 2018 at 12:58:39PM +0100, Tomasz Duszynski wrote: > Since METER action is supported by the testpmd application > suitable entry should exist in flow actions information table. > > Without that testpmd will return error on adding a new flow to > the list of flows attached to a given

[dpdk-dev] [PATCH] igb_uio: fix uevent montior issue

2018-01-30 Thread Jeff Guo
udev could not detect remove and add event of device when hotplug in and out devices, that related with the fix about using pointer of rte_uio_pci_dev as dev_id instead of uio_device for irq device handler, that would result igb uio irq failure when kernel version after than 3.17. so this patch cor

Re: [dpdk-dev] [PATCH 14/14] vhost: enable packed virtqueues

2018-01-30 Thread Jens Freimann
> diff --git a/lib/librte_vhost/vhost.h b/lib/librte_vhost/vhost.h > index a3d4214b6..fbde54f9a 100644 > --- a/lib/librte_vhost/vhost.h > +++ b/lib/librte_vhost/vhost.h > @@ -181,6 +181,7 @@ struct vhost_msg { > (1ULL << VIRTIO_NET_F_GUEST_ANNOUNCE) | \ >

[dpdk-dev] [PATCH v2] eal/ppc: fix compilation error with a broken else clause

2018-01-30 Thread Gowrishankar
From: Gowrishankar Muthukrishnan Calling rte_smp_{w/r}mb macro expands into a compound block, which would break compiling a else clause following it, if that calling place has been terminated already with ";", as in below code. This patch adds { } around this macro to allow compiling else too. F

[dpdk-dev] [PATCH v2] app/eventdev: fix port dequeue depth configuration

2018-01-30 Thread Pavan Nikhilesh
The port dequeue depth value has to be compared against the maximum allowed dequeue depth reported by the event drivers. Fixes: 3617aae53f92 ("app/eventdev: add event Rx adapter setup") Signed-off-by: Pavan Nikhilesh Acked-by: Jerin Jacob --- v2 Changes: - Pass port_conf as pointer. app/te

Re: [dpdk-dev] [PATCH] doc: announce ABI change for crypto info struct

2018-01-30 Thread De Lara Guarch, Pablo
Hi Shally/Ahkil, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Verma, Shally > Sent: Tuesday, January 30, 2018 7:56 AM > To: Akhil Goyal ; De Lara Guarch, Pablo > ; Trahe, Fiona ; > hemant.agra...@nxp.com; Doherty, Declan ; > Griffin, John ; Jain, Deepak K > ;

Re: [dpdk-dev] [PATCH] doc: announce ABI change for crypto info struct

2018-01-30 Thread Akhil Goyal
On 1/26/2018 2:33 PM, Pablo de Lara wrote: Since the API changes made in 17.08, the session mempool is not created anymore in each crypto device. Therefore, there is no need to have, in the cryptodev info structure, the maximum number of sessions supported per device and per queue pair. Signed-o

Re: [dpdk-dev] [PATCH] doc: announce ABI change for crypto info struct

2018-01-30 Thread Verma, Shally
>-Original Message- >From: De Lara Guarch, Pablo [mailto:pablo.de.lara.gua...@intel.com] >Sent: 30 January 2018 16:51 >To: Verma, Shally ; Akhil Goyal >; Trahe, Fiona ; >hemant.agra...@nxp.com; Doherty, Declan ; Griffin, >John ; Jain, Deepak K >; j...@semihalf.com; t...@semihalf.com; >

[dpdk-dev] [PATCH v2 0/3] Cryptodev API/ABI deprecation notices

2018-01-30 Thread Pablo de Lara
v2: - Added an extra deprecation announcement - Bonded the other two deprecation notices with the new one in a patchset Pablo de Lara (3): doc: announce ABI change for crypto info struct doc: announce deprecation for attach/detach crypto session doc: announce deprecation in crypto queue pa

[dpdk-dev] [PATCH v2 2/3] doc: announce deprecation for attach/detach crypto session

2018-01-30 Thread Pablo de Lara
Functions rte_cryptodev_queue_pair_attach_sym_session and rte_cryptodev_queue_pair_detach_sym_sessions are not really used in any of the crypto drivers (only one driver implements it and it just return 0). Therefore, this API can be deprecated from 18.02 and removed in 18.05. Signed-off-by: Pablo

[dpdk-dev] [PATCH v2 1/3] doc: announce ABI change for crypto info struct

2018-01-30 Thread Pablo de Lara
Since the API changes made in 17.08, the session mempool is not created anymore in each crypto device. Therefore, there is no need to have, in the cryptodev info structure, the maximum number of sessions supported per device and per queue pair. Signed-off-by: Pablo de Lara Acked-by: Fiona Trahe

[dpdk-dev] [PATCH v2 3/3] doc: announce deprecation in crypto queue pair start/stop

2018-01-30 Thread Pablo de Lara
Functions rte_cryptodev_queue_pair_start/stop are not really used in any of the crypto drivers (they all just return 0 or -ENOTSUP). Therefore, this API can be deprecated from 18.02 and removed in 18.05. Signed-off-by: Pablo de Lara Acked-by: Akhil Goyal --- doc/guides/rel_notes/deprecation.rst

[dpdk-dev] [PATCH] doc: update procinfo for shared library

2018-01-30 Thread Vipin Varghese
added note category to procinfo guide, to intimate users in shared library mode. Procinfo requires same NIC libraries to probe the NIC devices as Primary Application. Signed-off-by: Vipin Varghese --- doc/guides/tools/proc_info.rst | 6 ++ 1 file changed, 6 insertions(+) diff --git a/doc/gu

Re: [dpdk-dev] [PATCH v2] crypto/scheduler: fix strncpy

2018-01-30 Thread Zhang, Roy Fan
> -Original Message- > From: De Lara Guarch, Pablo > Sent: Monday, January 29, 2018 9:22 AM > To: Zhang, Roy Fan > Cc: dev@dpdk.org; Richardson, Bruce ; De > Lara Guarch, Pablo ; sta...@dpdk.org > Subject: [PATCH v2] crypto/scheduler: fix strncpy > > The coverity issue was not completel

Re: [dpdk-dev] [PATCH V13 1/3] eal: add uevent monitor api and callback func

2018-01-30 Thread Guo, Jia
On 1/30/2018 8:14 AM, Thomas Monjalon wrote: 27/01/2018 04:48, Guo, Jia: On 1/27/2018 12:53 AM, Bruce Richardson wrote: On Fri, Jan 26, 2018 at 11:49:35AM +0800, Jeff Guo wrote: + ret = rte_service_lcore_add(slcore); + if (ret) { + RTE_LOG(ERR, EAL, "dev event monit

[dpdk-dev] [PATCH V14 1/3] eal: add uevent monitor api and callback func

2018-01-30 Thread Jeff Guo
This patch aim to add a general uevent mechanism in eal device layer, to enable all linux kernel object uevent monitoring, user could use these APIs to monitor and read out the device status info that sent from the kernel side, then corresponding to handle it, such as when detect hotplug uevent typ

[dpdk-dev] [PATCH V14 3/3] app/testpmd: use uevent to monitor hotplug

2018-01-30 Thread Jeff Guo
use testpmd for example, to show app how to request and use uevent monitoring to handle the hot removal event and the hot insertion event. Signed-off-by: Jeff Guo --- v14->v13: no change --- app/test-pmd/testpmd.c | 169 + app/test-pmd/testpmd.h |

[dpdk-dev] [PATCH V14 2/3] eal: add uevent pass and process function

2018-01-30 Thread Jeff Guo
In order to handle the uevent which have been detected from the kernel side, add uevent process function, let hot plug event to be example to show uevent mechanism how to pass the uevent and process the uevent. About uevent passing and processing, add below functions in linux eal dev layer. FreeBS

Re: [dpdk-dev] [PATCH] net/ixgbe: fix reconfiguration of rx queues

2018-01-30 Thread Ananyev, Konstantin
> > > > > > From: "Charles (Chas) Williams" > > > > > > .dev_configure() may be called again after RX queues have been setup. > > > This has the effect of clearing whatever setting the RX queues made for > > > rx_bulk_alloc_allowed or rx_vec_allowed.  Only reset this configuration > > > is there

Re: [dpdk-dev] [PATCH v2 1/5] ethdev: introduce Tx generic tunnel offloads

2018-01-30 Thread Ananyev, Konstantin
Hi Xueming, > > > This patch introduce new TX offloads flag for devices that support > > > tunnel agnostic checksum and TSO offloads. > > > > > > The support from the device is for inner and outer checksums on > > > IPV4/TCP/UDP and TSO for *any packet with the following format*: > > > > > > < so

Re: [dpdk-dev] [PATCH] net/tap: define __NR_bpf for powerpc

2018-01-30 Thread Thomas Monjalon
30/01/2018 09:51, Pascal Mazon: > Acked-by: Pascal Mazon > > On 30/01/2018 08:05, Gowrishankar wrote: > > From: Gowrishankar Muthukrishnan > > > > This patch defines __NR_bpf for powerpc architecture and hence, > > fixes compiling tap driver for this architecture. > > > > Fixes: b02d85e1 ("net/t

[dpdk-dev] [PATCH] net/mlx5: fix port stop by verify flows are still present

2018-01-30 Thread Nelio Laranjeiro
priv_flow_stop() may be called several times, in such situation flows are already removed from the NIC and thus all associated objects are no present in the flow object (ibv_flow, indirections tables, ). Fixes: 71ee11c83bc4 ("net/mlx5: fix flow stop when flows are already stopped") Fixes: 8086

Re: [dpdk-dev] [PATCH] doc: update procinfo for shared library

2018-01-30 Thread Kovacevic, Marko
> added note category to procinfo guide, to intimate users in shared library > mode. > Procinfo requires same NIC libraries to probe the NIC devices as Primary > Application. > > Signed-off-by: Vipin Varghese > > doc/guides/tools/proc_info.rst | 6 ++ Acked-by: Marko Kovacevic

Re: [dpdk-dev] [PATCH v2] eal/ppc: fix compilation error with a broken else clause

2018-01-30 Thread Thomas Monjalon
30/01/2018 11:53, Gowrishankar: > From: Gowrishankar Muthukrishnan > > Calling rte_smp_{w/r}mb macro expands into a compound block, which > would break compiling a else clause following it, if that calling > place has been terminated already with ";", as in below code. > This patch adds { } aroun

Re: [dpdk-dev] [PATCH v2 0/3] Increase default RX/TX ring sizes

2018-01-30 Thread Adrien Mazarguil
On Mon, Jan 29, 2018 at 04:25:00PM +, Bruce Richardson wrote: > On Tue, Jan 16, 2018 at 02:13:19PM +0100, Adrien Mazarguil wrote: > > Hi Kevin, > > > > On Fri, Jan 12, 2018 at 10:48:43AM +, Kevin Laatz wrote: > > > Increasing the RX/TX default ring size to 1024/1024 to accommodate for > >

Re: [dpdk-dev] [PATCH] crypto/dpaa2_sec: fix build with GCC 6 or prior

2018-01-30 Thread Thomas Monjalon
30/01/2018 10:23, Hemant Agrawal: > This patch fixes the compilation with compiler GCC < 7 > > dpaa2_sec/hw/rta/operation_cmd.h:12:32: error: unknown option after > ‘#pragma GCC diagnostic’ kind [-Werror=pragmas] > #pragma GCC diagnostic ignored "-Wimplicit-fallthrough" > > Fixes: 2ab9a9483196

Re: [dpdk-dev] [PATCH 00/17] use SPDX tags on 6WIND copyrighted files

2018-01-30 Thread Hemant Agrawal
On 1/29/2018 6:41 PM, Olivier Matz wrote: This patchset updates the license on files that contain a 6WIND copyright to use a SPDX tag. It applies on master + https://dpdk.org/dev/patchwork/patch/34604/ For components I am maintaining (mempool, mbuf, cmdline, kvargs, net), I update all the *.[ch]

[dpdk-dev] [PATCH 2/2] app/testpmd: fix invalid port detach

2018-01-30 Thread Matan Azrad
Using registration to all ports includes also the ports which should not be used by the application. It is nice to print each port event by testpmd but in case of RMV event, testpmd tries to detach the port and this case is problematic when the port should not be used by the application. Check th

[dpdk-dev] [PATCH 1/2] app/testpmd: fix port validation

2018-01-30 Thread Matan Azrad
rte_eth_dev_is_valid_port() API validates each valid port from ethdev point of view and may validate ports which should not be used by the application. Testpmd should use only the ports available through the RTE_ETH_FOREACH_DEV iterator. Replace rte_eth_dev_is_valid_port() usage by RTE_ETH_FOREAC

[dpdk-dev] [PATCH] test/test: add new tests in 18.02-rc2 to meson build

2018-01-30 Thread Bruce Richardson
Signed-off-by: Bruce Richardson --- test/test/meson.build | 6 ++ 1 file changed, 6 insertions(+) diff --git a/test/test/meson.build b/test/test/meson.build index b8bae5afa..d5b768b9d 100644 --- a/test/test/meson.build +++ b/test/test/meson.build @@ -7,6 +7,7 @@ test_sources = files('command

Re: [dpdk-dev] [PATCH 5/5] config: enable dpaaX drivers compilation for ARMv8

2018-01-30 Thread Hemant Agrawal
On 1/30/2018 3:03 PM, Hemant Agrawal wrote: On 1/30/2018 2:12 PM, Hemant Agrawal wrote: Hi Jerin, On 1/25/2018 4:51 PM, Jerin Jacob wrote: -Original Message- Date: Thu, 25 Jan 2018 15:23:31 +0530 From: Hemant Agrawal To: dev@dpdk.org CC: jerin.ja...@caviumnetworks.com Subject: [PATCH

Re: [dpdk-dev] [PATCH v7 0/2] generic channel for multi-process communication

2018-01-30 Thread Thomas Monjalon
30/01/2018 07:58, Jianfeng Tan: > This patchset adds a generic channel for multi-process (primary/secondary) > communication. Applied, thanks

Re: [dpdk-dev] [PATCH RFC 1/2] vhost: make capabilities configurable

2018-01-30 Thread Maxime Coquelin
Hi Zhihong On 12/23/2017 04:36 AM, Zhihong Wang wrote: This patch makes vhost device capabilities configurable to adopt various engines. Such capabilities include supported features, protocol features, queue number. APIs are introduced to let app configure these capabilities. Why does the vDPA

Re: [dpdk-dev] [PATCH] drivers: improve pmdinfo generation when using meson

2018-01-30 Thread Bruce Richardson
On Thu, Jan 25, 2018 at 11:14:43AM +, Bruce Richardson wrote: > Since meson 0.44, changing any file inside a PMD directory (quite > correctly) triggers a full re-run of meson on build, rather than an > incremental build as with earlier versions. This rerun is needed because > we use "grep" in m

Re: [dpdk-dev] [PATCH 00/17] use SPDX tags on 6WIND copyrighted files

2018-01-30 Thread Bruce Richardson
On Tue, Jan 30, 2018 at 07:36:30PM +0530, Hemant Agrawal wrote: > On 1/29/2018 6:41 PM, Olivier Matz wrote: > > This patchset updates the license on files that contain a 6WIND copyright > > to use a SPDX tag. > > It applies on master + https://dpdk.org/dev/patchwork/patch/34604/ > > > > For compon

[dpdk-dev] [PATCH v2] config: enable dpaaX drivers compilation for ARMv8

2018-01-30 Thread Hemant Agrawal
This patch enables the NXP DPAA & DPAA2 drivers for ARMV8 targets. They can be used with standard armv8 config with command line mempool argument or newly introduced platform mempool internal registration mechanism. Note that the dpaa(x) specific config files are still preserved to continue custom

[dpdk-dev] [PATCH] net/dpaa2: fix the err with testpmd in Tx only mode

2018-01-30 Thread Hemant Agrawal
Fixes: 043b36f621dd ("net/dpaa2: support more than 16 burst size in Rx") Signed-off-by: Hemant Agrawal --- *This patch is applicable on top of next-net* drivers/net/dpaa2/dpaa2_rxtx.c | 126 +++-- 1 file changed, 33 insertions(+), 93 deletions(-) diff --git

Re: [dpdk-dev] [PATCH] test/test: add new tests in 18.02-rc2 to meson build

2018-01-30 Thread Luca Boccassi
On Tue, 2018-01-30 at 14:41 +, Bruce Richardson wrote: > Signed-off-by: Bruce Richardson > --- >  test/test/meson.build | 6 ++ >  1 file changed, 6 insertions(+) Reviewed-by: Luca Boccassi LGTM! -- Kind regards, Luca Boccassi

[dpdk-dev] [PATCH v3 10/11] maintainers: claim ownership of rawdev

2018-01-30 Thread Shreyansh Jain
Signed-off-by: Shreyansh Jain --- MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 5afa9cc6e..e422c871c 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -306,6 +306,12 @@ F: lib/librte_eventdev/*eth_rx_adapter* F: test/test/test_event_eth_rx_adap

[dpdk-dev] [PATCH v3 06/11] rawdev: add self test support

2018-01-30 Thread Shreyansh Jain
Signed-off-by: Shreyansh Jain --- lib/librte_rawdev/rte_rawdev.c | 10 ++ lib/librte_rawdev/rte_rawdev.h | 13 + lib/librte_rawdev/rte_rawdev_pmd.h | 11 +++ lib/librte_rawdev/rte_rawdev_version.map | 1 + 4 files changed, 35 insertions(+) d

[dpdk-dev] [PATCH 3/3] bus/fslmc: fix incorrect string compare length

2018-01-30 Thread Shreyansh Jain
Fixes: 828d51d8fc3e ("bus/fslmc: refactor scan and probe functions") Cc: shreyansh.j...@nxp.com Incorrect string length was being compared while scanning DPCI object. Signed-off-by: Shreyansh Jain --- drivers/bus/fslmc/fslmc_bus.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --gi

[dpdk-dev] [PATCH v3 11/11] doc: add rawdev library page

2018-01-30 Thread Shreyansh Jain
Signed-off-by: Shreyansh Jain --- doc/guides/prog_guide/index.rst | 1 + doc/guides/prog_guide/rawdev_lib.rst | 83 2 files changed, 84 insertions(+) create mode 100644 doc/guides/prog_guide/rawdev_lib.rst diff --git a/doc/guides/prog_guide/index.rst b

[dpdk-dev] [PATCH 1/3] config: change dpaa2 mbuf headroom size to 128

2018-01-30 Thread Shreyansh Jain
From: Hemant Agrawal Signed-off-by: Hemant Agrawal --- config/defconfig_arm64-dpaa2-linuxapp-gcc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/config/defconfig_arm64-dpaa2-linuxapp-gcc b/config/defconfig_arm64-dpaa2-linuxapp-gcc index 5d4437ca5..aa135caab 100644 --- a/con

[dpdk-dev] [PATCH v3 05/11] rawdev: support for firmware management

2018-01-30 Thread Shreyansh Jain
Some generic operations for firmware management can loading, unloading, starting, stopping and querying firmware of a device. This patch adds support for such generic operations. Signed-off-by: Shreyansh Jain --- lib/librte_rawdev/rte_rawdev.c | 43 lib/librte_raw

[dpdk-dev] [PATCH 2/3] net/dpaa2: fix the bpid offset

2018-01-30 Thread Shreyansh Jain
From: Hemant Agrawal Fixes: 774e9ea91992 ("net/dpaa2: add support for multi seg buffers") Cc: hemant.agra...@nxp.com Fixes: d2ef05d5c13e ("net/dpaa2: optimize Rx/Tx path") Cc: hemant.agra...@nxp.com Signed-off-by: Hemant Agrawal --- drivers/net/dpaa2/dpaa2_rxtx.c | 3 +-- 1 file changed, 1 ins

[dpdk-dev] [PATCH v3 02/11] rawdev: add attribute get and set support

2018-01-30 Thread Shreyansh Jain
A rawdevice can have various attributes. This patch introduce support for transparently setting attribute value or getting current attribute state. This is done by allowing an opaque set of key and value to be passed through rawdev library. Signed-off-by: Shreyansh Jain --- lib/librte_rawdev/rte

[dpdk-dev] [PATCH v3 09/11] test: enable rawdev skeleton test

2018-01-30 Thread Shreyansh Jain
Skeleton rawdevice test cases are part of driver layer. This patch allows test cases to be executed using 'rawdev_autotest' command in test framework. Signed-off-by: Shreyansh Jain --- test/test/Makefile | 4 test/test/test_rawdev.c | 27 +++ 2 files changed, 3

[dpdk-dev] [PATCH v3 00/11] Introduce generic 'rawdevice' support

2018-01-30 Thread Shreyansh Jain
Change History ~~ v3: - rebased over master (367bc2a9fd) - added __rte_experimental flag - added initial documentation v2: - restructure comments to prefix model - split patches pivoted on APIs introduced in library - moved test into drivers/rawdev/skeleton from test/test - rem

[dpdk-dev] [PATCH v3 04/11] rawdev: support for extended stats

2018-01-30 Thread Shreyansh Jain
Generic rawdev library cannot define a pre-defined set of stats for devices which are yet to be defined. This patch introduces the xstats support for rawdev so that any implementation can create its own statistics. Signed-off-by: Shreyansh Jain --- lib/librte_rawdev/rte_rawdev.c | 75

[dpdk-dev] [PATCH v3 07/11] drivers/raw: introduce skeleton rawdev driver

2018-01-30 Thread Shreyansh Jain
Skeleton rawdevice driver, on the lines of eventdev skeleton, is for showcasing the rawdev library. This driver implements some of the operations of the library based on which a test module can be developed. Design of skeleton involves a virtual device which is plugged into VDEV bus on initializat

[dpdk-dev] [PATCH v3 01/11] rawdev: introduce raw device library support

2018-01-30 Thread Shreyansh Jain
Each device in DPDK has a type associated with it - ethernet, crypto, event etc. This patch introduces 'rawdevice' which is a generic type of device, not currently handled out-of-the-box by DPDK. A device which can be scanned on an installed bus (pci, fslmc, ...) or instantiated through devargs, c

[dpdk-dev] [PATCH v3 03/11] rawdev: add buffer stream IO support

2018-01-30 Thread Shreyansh Jain
Introduce handlers for raw buffer enqueue and dequeue. A raw buffer is essentially a void object which is transparently passed via the library onto the driver. Using a context field as argument, any arbitrary meta information can be passed by application to the driver/implementation. This can be a

[dpdk-dev] [PATCH v3 08/11] drivers/raw: support for rawdev testcases

2018-01-30 Thread Shreyansh Jain
Patch introduces rawdev unit testcase for validation against the Skeleton rawdev dummy PMD implementation. Test cases are added along with the skeleton driver implementation. It can be enabled by using vdev argument to any DPDK binary: --vdev="rawdev_skeleton,self_test=1" In case 'self_test=1'

[dpdk-dev] [PATCH v2] net/dpaa2: fix the err with testpmd in Tx only mode

2018-01-30 Thread Hemant Agrawal
Fixes: 043b36f621dd ("net/dpaa2: support more than 16 burst size in Rx") Signed-off-by: Hemant Agrawal --- v2: fix checkpatch warning * This patch is applicable over net-next tree* drivers/net/dpaa2/dpaa2_rxtx.c | 126 +++-- 1 file changed, 33 insertions(+),

Re: [dpdk-dev] [PATCH v2 1/5] ethdev: introduce Tx generic tunnel offloads

2018-01-30 Thread Xueming(Steven) Li
Hi Ananyev, > -Original Message- > From: Ananyev, Konstantin [mailto:konstantin.anan...@intel.com] > Sent: Tuesday, January 30, 2018 9:28 PM > To: Xueming(Steven) Li ; Olivier MATZ > > Cc: dev@dpdk.org; Wu, Jingjing ; Shahaf Shuler > ; Yongseok Koh ; Thomas Monjalon > ; Yigit, Ferruh > S

Re: [dpdk-dev] [PATCH v2 1/5] ethdev: introduce Tx generic tunnel offloads

2018-01-30 Thread Ananyev, Konstantin
> -Original Message- > From: Xueming(Steven) Li [mailto:xuemi...@mellanox.com] > Sent: Tuesday, January 30, 2018 3:27 PM > To: Ananyev, Konstantin ; Olivier MATZ > > Cc: dev@dpdk.org; Wu, Jingjing ; Shahaf Shuler > ; Yongseok Koh > ; Thomas Monjalon ; Yigit, Ferruh > > Subject: RE: [

[dpdk-dev] [PATCH v4 1/4] net/mlx4: move rdma-core calls to separate file

2018-01-30 Thread Adrien Mazarguil
This lays the groundwork for externalizing rdma-core as an optional run-time dependency instead of a mandatory one. No functional change. Signed-off-by: Adrien Mazarguil Acked-by: Nelio Laranjeiro --- drivers/net/mlx4/Makefile | 1 + drivers/net/mlx4/mlx4.c| 35 ++--- drivers/n

[dpdk-dev] [PATCH v4 0/4] net/mlx: make rdma-core optional at run-time

2018-01-30 Thread Adrien Mazarguil
A problem encountered with Mellanox PMDs and frequently reported by DPDK application developers and Linux distribution package maintainers is their dependency on rdma-core components, namely libibverbs, libmlx4, and libmlx5. For best performance in applications, DPDK is normally built as a collect

[dpdk-dev] [PATCH v4 4/4] net/mlx5: spawn rdma-core dependency plug-in

2018-01-30 Thread Adrien Mazarguil
When mlx5 is not compiled directly as an independent shared object (e.g. CONFIG_RTE_BUILD_SHARED_LIB not enabled for performance reasons), DPDK applications inherit its dependencies on libibverbs and libmlx5 through rte.app.mk. This is an issue both when DPDK is delivered as a binary package (Linu

[dpdk-dev] [PATCH v4 3/4] net/mlx5: move rdma-core calls to separate file

2018-01-30 Thread Adrien Mazarguil
From: Nelio Laranjeiro This lays the groundwork for externalizing rdma-core as an optional run-time dependency instead of a mandatory one. No functional change. Signed-off-by: Nelio Laranjeiro Signed-off-by: Adrien Mazarguil --- drivers/net/mlx5/Makefile | 1 + drivers/net/mlx5/mlx5.c

[dpdk-dev] [PATCH v4 2/4] net/mlx4: spawn rdma-core dependency plug-in

2018-01-30 Thread Adrien Mazarguil
When mlx4 is not compiled directly as an independent shared object (e.g. CONFIG_RTE_BUILD_SHARED_LIB not enabled for performance reasons), DPDK applications inherit its dependencies on libibverbs and libmlx4 through rte.app.mk. This is an issue both when DPDK is delivered as a binary package (Linu

Re: [dpdk-dev] [PATCH v2 1/5] ethdev: introduce Tx generic tunnel offloads

2018-01-30 Thread Xueming(Steven) Li
> -Original Message- > From: Ananyev, Konstantin [mailto:konstantin.anan...@intel.com] > Sent: Tuesday, January 30, 2018 11:34 PM > To: Xueming(Steven) Li ; Olivier MATZ > > Cc: dev@dpdk.org; Wu, Jingjing ; Shahaf Shuler > ; Yongseok Koh ; Thomas Monjalon > ; Yigit, Ferruh > Subject: RE

Re: [dpdk-dev] [PATCH] test/test: add new tests in 18.02-rc2 to meson build

2018-01-30 Thread Bruce Richardson
On Tue, Jan 30, 2018 at 03:20:35PM +, Luca Boccassi wrote: > On Tue, 2018-01-30 at 14:41 +, Bruce Richardson wrote: > > Signed-off-by: Bruce Richardson > > --- > >  test/test/meson.build | 6 ++ > >  1 file changed, 6 insertions(+) > > Reviewed-by: Luca Boccassi > > LGTM! > Applied

[dpdk-dev] [PATCH] net/mlx4: fix drop flow resources not freed

2018-01-30 Thread Moti Haimovsky
This patch fixes the drop-flow resources not being freed when the device is closed. Issue can be observed when running testpmd and adding the following rule more than once: "flow create 0 ingress pattern eth / end actions drop / end" then either exiting testpmd using the "quit" command or by runnin

Re: [dpdk-dev] [PATCH 0/5] dpdk: enhance EXPERIMENTAL api tagging

2018-01-30 Thread Neil Horman
On Mon, Jan 29, 2018 at 10:46:27PM +0100, Thomas Monjalon wrote: > 22/01/2018 02:48, Neil Horman: > > v5 Changes > > * Clean ups suggested by Thomas > > There were a lot of new functions to tag when rebasing this v5. > Rebased and applied, thanks. > Sorry, not clear what you mean by this. Are y

[dpdk-dev] [PATCH] eal: fix default mempool ops returning NULL

2018-01-30 Thread Pavan Nikhilesh
If '--mbuf-pool-ops' is not passed to EAL as command line argument then rte_eal_mbuf_default_mempool_ops will return NULL. Instead check if internal_config.user_mbuf_pool_ops_name is NULL and return compile time RTE_MBUF_DEFAULT_MEMPOOL_OPS. Fixes: 8b0f7f43413 ("mbuf: maintain user and compile ti

[dpdk-dev] [PATCH v2 0/2] fix eBPF TAP RSS leakage and map key handling

2018-01-30 Thread Ophir Munk
v2: fix eBPF RSS map key handling v1: fix eBPF file descriptors leakage Ophir Munk (2): net/tap: fix eBPF file descriptors leakage net/tap: fix eBPF RSS map key handling drivers/net/tap/tap_flow.c | 104 +++-- 1 file changed, 73 insertions(+), 31 dele

[dpdk-dev] [PATCH v2 1/2] net/tap: fix eBPF file descriptors leakage

2018-01-30 Thread Ophir Munk
When a user creates an RSS rule, the tap PMD dynamically allocates a 'flow' data structure, and uploads BPF programs (represented by file descriptors) to the kernel. The kernel might reject the rule (due to filters overlap, for example) in which case, flow memory should be freed and BPF file descri

[dpdk-dev] [PATCH v2 2/2] net/tap: fix eBPF RSS map key handling

2018-01-30 Thread Ophir Munk
This commit addresses a case of RSS and non RSS flows mixture. In the corrupted code, if a non-RSS flow is destroyed, it has an eBPF map index 0 (initialized upon flow creation). This might unintentionally remove RSS entry 0 from eBPF map. To fix this issue, add an offset to the real index during a

Re: [dpdk-dev] [PATCH 0/5] ARMv8: enable DPAA-X driver compilation

2018-01-30 Thread Thomas Monjalon
25/01/2018 10:53, Hemant Agrawal: > This patchset enables DPAA drivers compilation for ARM targets. > This also includes patches to fix the DPAA compilation for clang > compiler. > > Note that the dpaa(x) specific config files are still preserved > to continue customer support. They also contain s

Re: [dpdk-dev] [PATCH v2 1/5] ethdev: introduce Tx generic tunnel offloads

2018-01-30 Thread Ananyev, Konstantin
> > > > > > > > > > > This patch introduce new TX offloads flag for devices that > > > > > > > support tunnel agnostic checksum and TSO offloads. > > > > > > > > > > > > > > The support from the device is for inner and outer checksums > > > > > > > on IPV4/TCP/UDP and TSO for *any packet with the

Re: [dpdk-dev] [PATCH v2 1/5] ethdev: introduce Tx generic tunnel offloads

2018-01-30 Thread Xueming(Steven) Li
> -Original Message- > From: Ananyev, Konstantin [mailto:konstantin.anan...@intel.com] > Sent: Wednesday, January 31, 2018 12:03 AM > To: Xueming(Steven) Li ; Olivier MATZ > > Cc: dev@dpdk.org; Wu, Jingjing ; Shahaf Shuler > ; Yongseok Koh ; Thomas Monjalon > ; Yigit, Ferruh > Subject:

Re: [dpdk-dev] [PATCH v2 0/2] fix eBPF TAP RSS leakage and map key handling

2018-01-30 Thread Pascal Mazon
The patches look good to me. Good catch. Acked-by: Pascal Mazon for the series. On 30/01/2018 17:00, Ophir Munk wrote: > v2: > fix eBPF RSS map key handling > > v1: > fix eBPF file descriptors leakage > > Ophir Munk (2): > net/tap: fix eBPF file descriptors leakage > net/tap: fix eBPF RSS ma

Re: [dpdk-dev] [PATCH 0/5] dpdk: enhance EXPERIMENTAL api tagging

2018-01-30 Thread Thomas Monjalon
30/01/2018 16:54, Neil Horman: > On Mon, Jan 29, 2018 at 10:46:27PM +0100, Thomas Monjalon wrote: > > 22/01/2018 02:48, Neil Horman: > > > v5 Changes > > > * Clean ups suggested by Thomas > > > > There were a lot of new functions to tag when rebasing this v5. > > Rebased and applied, thanks. > >

Re: [dpdk-dev] [PATCH] net/ixgbe: fix reconfiguration of rx queues

2018-01-30 Thread Chas Williams
On Tue, Jan 30, 2018 at 8:14 AM, Ananyev, Konstantin < konstantin.anan...@intel.com> wrote: > > > > > > > > > > From: "Charles (Chas) Williams" > > > > > > > > .dev_configure() may be called again after RX queues have been setup. > > > > This has the effect of clearing whatever setting the RX que

Re: [dpdk-dev] [PATCH] net/mlx4: fix drop flow resources not freed

2018-01-30 Thread Adrien Mazarguil
Hi Moti, On Tue, Jan 30, 2018 at 05:54:00PM +0200, Moti Haimovsky wrote: > This patch fixes the drop-flow resources not being freed when the device > is closed. > Issue can be observed when running testpmd and adding the following rule > more than once: > "flow create 0 ingress pattern eth / end a

Re: [dpdk-dev] [PATCH v3 07/11] drivers/raw: introduce skeleton rawdev driver

2018-01-30 Thread Thomas Monjalon
There is a compilation error with clang-5.0: 30/01/2018 15:57, Shreyansh Jain: > +struct queue_buffers { > + void *bufs[SKELETON_QUEUE_MAX_DEPTH]; > +}; > + > +static struct queue_buffers queue_buf[SKELETON_MAX_QUEUES] = {0}; drivers/raw/skeleton_rawdev/skeleton_rawdev.c:46:63: fatal error: s

  1   2   >