[dpdk-dev] [PATCH 1/3] net/mlx5: fix flow director conversion

2018-01-23 Thread Nelio Laranjeiro
Flow director must provide the same spec and mask to be sure to be validated. Fixes: 4c3e9bcdd52e ("net/mlx5: support flow director") Cc: sta...@dpdk.org Signed-off-by: Nelio Laranjeiro Acked-by: Yongseok Koh --- drivers/net/mlx5/mlx5_flow.c | 10 ++ 1 file changed, 10 insertions(+) d

[dpdk-dev] [PATCH 2/3] net/mlx5: fix flow item validation

2018-01-23 Thread Nelio Laranjeiro
Two masks were compared instead of verifying the spec was included in the supported mask. Fixes: 2097d0d1e2cc ("net/mlx5: support basic flow items and actions") Cc: sta...@dpdk.org Signed-off-by: Nelio Laranjeiro Acked-by: Yongseok Koh --- drivers/net/mlx5/mlx5_flow.c | 2 +- 1 file changed, 1

[dpdk-dev] [PATCH 3/3] net/mlx5: support IPv4 time-to-live filter

2018-01-23 Thread Nelio Laranjeiro
Signed-off-by: Nelio Laranjeiro Acked-by: Yongseok Koh --- drivers/net/mlx5/mlx5_flow.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c index 01e290484..516f60939 100644 --- a/drivers/net/mlx5/mlx5_flow.c +++ b/drivers/net/mlx5/mlx5

[dpdk-dev] [PATCH] app/testpmd: do not enable Rx offloads by default

2018-01-23 Thread Moti Haimovsky
Removed the hardcoded preconfigured Rx offload configuration from testpmd. Testers who wish to use these offloads will now have to explicitly write them in the command-line when running testpmd. Motivation: Some PMDs such at the mlx4 may not implement all the offloads. After the offload API rework

Re: [dpdk-dev] [PATCH 1/2] net/mrvl: switch to the new Rx offload API

2018-01-23 Thread Tomasz Duszynski
Hi Ferruh, On Mon, Jan 22, 2018 at 05:53:45PM +, Ferruh Yigit wrote: > On 1/22/2018 12:04 PM, Tomasz Duszynski wrote: > > Since the old Rx offload API is now depracated > > update the driver to use the latest one. > > > > Signed-off-by: Tomasz Duszynski > > <...> > > > @@ -1308,6 +1313,42 @@

Re: [dpdk-dev] [PATCH] net/mlx5: use PCI BDF as the port name

2018-01-23 Thread Nélio Laranjeiro
Hi Yuanhan, On Mon, Jan 22, 2018 at 05:30:06PM +0800, Yuanhan Liu wrote: > It is suggested to use PCI BDF to identify a port for port addition > in OVS-DPDK. While mlx5 has its own naming style: name it by ib dev > name. This breaks the typical OVS DPDK use case and brings more puzzle > to the end

[dpdk-dev] [PATCH v2 1/2] net/mrvl: switch to the new Rx offload API

2018-01-23 Thread Tomasz Duszynski
Since the old Rx offload API is now depracated update the driver to use the latest one. Signed-off-by: Tomasz Duszynski --- drivers/net/mrvl/mrvl_ethdev.c | 73 ++ 1 file changed, 59 insertions(+), 14 deletions(-) diff --git a/drivers/net/mrvl/mrvl_ethdev

[dpdk-dev] [PATCH v2 0/2] net/mrvl: switch to the new Rx/Tx offloads API

2018-01-23 Thread Tomasz Duszynski
This patch series replaces the old Rx/Tx offload API with the new API. v2: * Follow the same logic for calculating both unsupported and missing flags. Tomasz Duszynski (2): net/mrvl: switch to the new Rx offload API net/mrvl: switch to the new Tx offload API drivers/net/mrvl/mrvl_ethdev.c

[dpdk-dev] [PATCH v2 2/2] net/mrvl: switch to the new Tx offload API

2018-01-23 Thread Tomasz Duszynski
Since the old Tx offload API was depracated update the driver to use the latest one. Signed-off-by: Tomasz Duszynski --- drivers/net/mrvl/mrvl_ethdev.c | 52 ++ 1 file changed, 47 insertions(+), 5 deletions(-) diff --git a/drivers/net/mrvl/mrvl_ethdev.c b

[dpdk-dev] [RFC v2, 1/2] cryptodev: add support to set session private data

2018-01-23 Thread Abhinandan Gujjar
Update rte_crypto_op to indicate private data offset. The application may want to store private data along with the rte_cryptodev that is transparent to the rte_cryptodev layer. For e.g., If an eventdev based application is submitting a rte_cryptodev_sym_session operation and wants to indicate eve

Re: [dpdk-dev] [PATCH v3 7/7] app/testpmd: adjust ethdev port ownership

2018-01-23 Thread Matan Azrad
Hi Konstantin From: Ananyev, Konstantin, Monday, January 22, 2018 10:49 PM > Hi Matan, > > > -Original Message- > > From: Matan Azrad [mailto:ma...@mellanox.com] > > Sent: Monday, January 22, 2018 1:23 PM > > To: Ananyev, Konstantin ; Gaëtan Rivet > > > > Cc: Thomas Monjalon ; Wu, Jingji

[dpdk-dev] [RFC v2, 2/2] security: add support to set session private data

2018-01-23 Thread Abhinandan Gujjar
The application may want to store private data along with the rte_security that is transparent to the rte_security layer. For e.g., If an eventdev based application is submitting a rte_security_session operation and wants to indicate event information required to construct a new event that will be

Re: [dpdk-dev] [PATCH] build: make compat a universal dependency

2018-01-23 Thread Bruce Richardson
On Mon, Jan 22, 2018 at 05:43:06PM +, Luca Boccassi wrote: > On Mon, 2018-01-22 at 15:42 +, Bruce Richardson wrote: > > By making "compat" lib (which consists of a header only) a dependency > > of > > the EAL, we make the header file available to all other libs, drivers > > and > > apps, an

[dpdk-dev] [PATCH] net/virtio-user: fix segfault as features change

2018-01-23 Thread Jianfeng Tan
Since commit 59fe5e17d93 ("vhost: propagate set features handling error"), vhost does not allow to set different features without reset. The virito-user driver fails to reset the device in below commit. To fix, we send the reset message as stopping the device. Fixes: c12a26ee209e ("net/virtio-us

Re: [dpdk-dev] [PATCH] net/virtio-user: fix segfault as features change

2018-01-23 Thread Tan, Jianfeng
Correct yuanhan's email :-) > -Original Message- > From: Tan, Jianfeng > Sent: Tuesday, January 23, 2018 5:47 PM > To: dev@dpdk.org > Cc: yuanhan@linux.intel.com; maxime.coque...@redhat.com; Tan, > Jianfeng > Subject: [PATCH] net/virtio-user: fix segfault as features change > > Since

[dpdk-dev] [PATCH] lib: fix wrong cast

2018-01-23 Thread Zhiyong Yang
The wrong casts don't cause actual error, but they should conform to C standard. Fixes: c261d1431bd8 ("security: introduce security API and framework") Fixes: b3bbd9e5f265 ("cryptodev: support device independent sessions") Cc: sta...@dpdk.org Cc: declan.dohe...@intel.com Cc: akhil.go...@nxp.com S

Re: [dpdk-dev] [PATCH] net/mlx5: remmap UAR address for multiple process

2018-01-23 Thread Xueming(Steven) Li
Hi Nelio, > -Original Message- > From: Nélio Laranjeiro [mailto:nelio.laranje...@6wind.com] > Sent: Monday, January 22, 2018 10:53 PM > To: Xueming(Steven) Li > Cc: Shahaf Shuler ; dev@dpdk.org > Subject: Re: [PATCH] net/mlx5: remmap UAR address for multiple process > > Hi Xueming, > >

[dpdk-dev] [PATCH v2] net/virtio-user: fix segfault as features change

2018-01-23 Thread Jianfeng Tan
Since commit 59fe5e17d930 ("vhost: propagate set features handling error"), vhost does not allow to set different features without reset. The virito-user driver fails to reset the device in below commit. To fix, we send the reset message as stopping the device. Fixes: c12a26ee209e ("net/virtio-u

[dpdk-dev] [RFC v1 0/1] lib/cryptodev: add support of asymmetric crypto

2018-01-23 Thread Shally Verma
This an RFC API specification to add support for asymmetric crypto in DPDK cryptodev library. It is derivative of earlier submitted RFC v2 patch series by Umesh Kartha (umesh.kar...@caviumnetworks.com): http://dpdk.org/dev/patchwork/patch/24245/ http://dpdk.org/dev/patchwork/patch/24246/ http://

Re: [dpdk-dev] [PATCH] build: make compat a universal dependency

2018-01-23 Thread Bruce Richardson
O Mon, Jan 22, 2018 at 05:43:06PM +, Luca Boccassi wrote: > On Mon, 2018-01-22 at 15:42 +, Bruce Richardson wrote: > > By making "compat" lib (which consists of a header only) a dependency > > of > > the EAL, we make the header file available to all other libs, drivers > > and > > apps, and

[dpdk-dev] [RFC v1 1/1] lib/cryptodev: add support of asymmetric crypto

2018-01-23 Thread Shally Verma
From: Shally Verma Add support for asymmetric crypto operations in DPDK lib cryptodev Key feature include: - Only session based asymmetric crypto operations - new get and set APIs for symmetric and asymmetric session private data and other informations - APIs to create, configure and attch que

Re: [dpdk-dev] [PATCH] keepalive: fix keepalive state alignment

2018-01-23 Thread Remy Horton
On 22/01/2018 18:20, Andriy Berestovskyy wrote: [..] On Fri, Jan 19, 2018 at 6:31 PM, Van Haaren, Harry wrote: These changes do reduce false-sharing however is there actually a performance benefit? A lot of cache space will be taken up if each core requires its own cache line, which will reduc

Re: [dpdk-dev] [PATCH] doc: add i40e update

2018-01-23 Thread Mcnamara, John
> -Original Message- > From: Xing, Beilei > Sent: Thursday, January 18, 2018 2:24 AM > To: Mcnamara, John > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: [PATCH] doc: add i40e update > > Update release note to declare MPLSoUDP/MPLSoGRE/ GTP-U/GTP- > C/PPPoE/PPPoL2TP steering support in i

[dpdk-dev] [PATCH] net/i40e: add device args to disable global configuration

2018-01-23 Thread Beilei Xing
DPDK i40e PMD will modify some global registers during initialization and post initialization, there'll be impact during use of 700 series Ethernet Adapter with both Linux kernel and DPDK PMD. This patch is to add device parameters to disable global configuration. Signed-off-by: Beilei Xing ---

Re: [dpdk-dev] [PATCH v5] doc: add queue region feature info to release notes

2018-01-23 Thread Mcnamara, John
> -Original Message- > From: Zhao1, Wei > Sent: Monday, January 22, 2018 5:19 AM > To: dev@dpdk.org > Cc: Mcnamara, John ; tho...@monjalon.net; > sta...@dpdk.org; Zhao1, Wei > Subject: [PATCH v5] doc: add queue region feature info to release notes > > This patch add inforation about i40

Re: [dpdk-dev] [PATCH] lib: fix wrong cast

2018-01-23 Thread Akhil Goyal
Acked-by: Akhil Goyal

[dpdk-dev] OVS+DPDK: deadlock and race condtion, which leads OVS deadlock or crash

2018-01-23 Thread 王志克
Hi Yuanha and all, Thanks for review. I change the title and let more people involved. The issues can be reproduced easily with OVS. The steps are below: 1) virsh start vm 2) ovs-vsctl add port 3) delete the port via ovs-vsctl del-port. 4) shutdown VM via vrish destroy. I run a script to repeat

Re: [dpdk-dev] [PATCH] keepalive: fix keepalive state alignment

2018-01-23 Thread Van Haaren, Harry
> From: Horton, Remy > Sent: Tuesday, January 23, 2018 10:17 AM > To: Andriy Berestovskyy ; Van Haaren, Harry > > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] keepalive: fix keepalive state alignment > > > On 22/01/2018 18:20, Andriy Berestovskyy wrote: > [..] > > On Fri, Jan 19, 2018 at 6

Re: [dpdk-dev] [PATCH] doc: add release note entry for meson build

2018-01-23 Thread Mcnamara, John
> -Original Message- > From: Richardson, Bruce > Sent: Monday, January 22, 2018 3:14 PM > To: Mcnamara, John ; Kovacevic, Marko > > Cc: bl...@debian.org; dev@dpdk.org; tho...@monjalon.net; Richardson, Bruce > > Subject: [PATCH] doc: add release note entry for meson build > Acked-by:

Re: [dpdk-dev] [[PATCH v5] 5/5] doc: Add ABI __experimental tag documentation

2018-01-23 Thread Mcnamara, John
> -Original Message- > From: Neil Horman [mailto:nhor...@tuxdriver.com] > Sent: Monday, January 22, 2018 1:48 AM > To: dev@dpdk.org > Cc: Neil Horman ; Thomas Monjalon > ; Mcnamara, John ; > Richardson, Bruce > Subject: [[PATCH v5] 5/5] doc: Add ABI __experimental tag documentation > >

Re: [dpdk-dev] [PATCH v2] doc: add deprecation notice for memory hotplug changes

2018-01-23 Thread Mcnamara, John
> -Original Message- > From: Burakov, Anatoly > Sent: Thursday, January 18, 2018 10:32 AM > To: dev@dpdk.org > Cc: Neil Horman ; Mcnamara, John > ; Kovacevic, Marko > Subject: [PATCH v2] doc: add deprecation notice for memory hotplug changes > > Due to coming changes outlined in memory

Re: [dpdk-dev] [PATCH] doc: add ABI change notice for numa_node_count in eal

2018-01-23 Thread Mcnamara, John
> -Original Message- > From: Burakov, Anatoly > Sent: Tuesday, January 16, 2018 5:54 PM > To: dev@dpdk.org > Cc: Neil Horman ; Mcnamara, John > ; Kovacevic, Marko > Subject: [PATCH] doc: add ABI change notice for numa_node_count in eal > > There will be a new function added in v18.05 th

Re: [dpdk-dev] About : Enable optional dequeue zero copy for vHost User

2018-01-23 Thread Loftus, Ciara
Hi, For the meantime this feature is proposed as ‘experimental’ for OVS DPDK. Unless you are transmitting to a NIC, you don’t need to set the n_txq_desc. My testing has been only with a DPDK driver in the guest. Have you tried that option? Thanks, Ciara From: liyang07 [mailto:liyan...@corp.nete

Re: [dpdk-dev] [PATCH] doc: add release note entry for meson build

2018-01-23 Thread Bruce Richardson
On Tue, Jan 23, 2018 at 10:28:42AM +, Mcnamara, John wrote: > > > > -Original Message- > > From: Richardson, Bruce > > Sent: Monday, January 22, 2018 3:14 PM > > To: Mcnamara, John ; Kovacevic, Marko > > > > Cc: bl...@debian.org; dev@dpdk.org; tho...@monjalon.net; Richardson, Bruce >

Re: [dpdk-dev] About : Enable optional dequeue zero copy for vHost User

2018-01-23 Thread Chen, Junjie J
Hi Which version of dpdk you are using? I have some fixes for dequeue zero copy and now in 18.02-rc1, you can try 18.02-r1. Cheers JJ > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Loftus, Ciara > Sent: Tuesday, January 23, 2018 6:46 PM > To: liyang07 > Cc:

Re: [dpdk-dev] [PATCH v2 0/3] Fixes for QAT PMD

2018-01-23 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Tomasz Jozwiak > Sent: Monday, January 22, 2018 4:28 PM > To: Trahe, Fiona ; Jain, Deepak K > ; Griffin, John > Cc: dev@dpdk.org; Jozwiak, TomaszX > Subject: [dpdk-dev] [PATCH v2 0/3] Fixes for QAT PMD > > v2:

Re: [dpdk-dev] [RFC v3 1/1] lib: add compressdev API

2018-01-23 Thread Verma, Shally
Hi Fiona > -Original Message- > From: Trahe, Fiona [mailto:fiona.tr...@intel.com] > Sent: 19 January 2018 17:30 > To: Verma, Shally ; dev@dpdk.org; > akhil.go...@nxp.com > Cc: Challa, Mahipal ; Athreya, Narayana > Prasad ; De Lara Guarch, Pablo > ; Gupta, Ashish > ; Sahu, Sunila ; > Jain,

[dpdk-dev] [PATCH] app/test-crypto-perf: fix index

2018-01-23 Thread Fan Zhang
Fixes: 27c2e7471961 ("app/crypto-perf: support IMIX") A bug caused index out-of-range error. This simple patch is to fix this. Signed-off-by: Fan Zhang --- app/test-crypto-perf/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/test-crypto-perf/main.c b/app/test-cryp

Re: [dpdk-dev] [PATCH v3 3/3] crypto/qat: add null point check and fix mem leak

2018-01-23 Thread Trahe, Fiona
Hi Yong, > -Original Message- > From: Yong Wang [mailto:wang.yon...@zte.com.cn] > Sent: Tuesday, January 23, 2018 2:45 AM > To: Xing, Beilei ; Lu, Wenzhuo ; > Trahe, Fiona > > Cc: dev@dpdk.org; Yong Wang > Subject: [PATCH v3 3/3] crypto/qat: add null point check and fix mem leak > > Th

Re: [dpdk-dev] [PATCH v7 08/15] net/ixgbe: use rte_eth_linkstatus functions

2018-01-23 Thread Neil Horman
On Mon, Jan 22, 2018 at 03:54:51PM -0800, Stephen Hemminger wrote: > Use the new helper functions from eth_dev for > handling atomic link_info update. > > Signed-off-by: Stephen Hemminger > Signed-off-by: Ferruh Yigit > > --- > drivers/net/ixgbe/ixgbe_ethdev.c | 96 > +++--

[dpdk-dev] [PATCH v3 2/3] doc: convert license headers to SPDX tags

2018-01-23 Thread Ferruh Yigit
Signed-off-by: Ferruh Yigit --- v3: Intel ones sharing copyright --- doc/guides/linux_gsg/linux_drivers.rst | 28 +--- 1 file changed, 1 insertion(+), 27 deletions(-) diff --git a/doc/guides/linux_gsg/linux_drivers.rst b/doc/guides/linux_gsg/linux_drivers.rst index 08f7c

[dpdk-dev] [PATCH v3 3/3] doc: convert license headers to SPDX tags

2018-01-23 Thread Ferruh Yigit
Signed-off-by: Ferruh Yigit --- v3: Non-Intel updates, I am sharing these since I already made the patch, please feel free to ignore if has legal implications --- doc/guides/cryptodevs/mrvl.rst | 28 +--- doc/guides/howto/pvp_reference_benchmark.rst | 29 +---

[dpdk-dev] [PATCH] examples/ipsec_secgw: fix security session

2018-01-23 Thread Fan Zhang
Fixes: 3da37f682173 ("examples/ipsec_secgw: create session mempools for ethdevs") Some NICs do not have the rte_security context, this patch fixes the segment fault caused by this. Signed-off-by: Fan Zhang --- examples/ipsec-secgw/ipsec-secgw.c | 10 -- 1 file changed, 8 insertions(+)

Re: [dpdk-dev] [PATCH] doc: document the new devargs syntax

2018-01-23 Thread Yuanhan Liu
On Thu, Jan 18, 2018 at 10:46:23AM +0100, Gaëtan Rivet wrote: > On Thu, Jan 18, 2018 at 09:46:29AM +0100, Thomas Monjalon wrote: > > 18/01/2018 08:35, Yuanhan Liu: > > > On Wed, Jan 17, 2018 at 12:34:08PM +, Ferruh Yigit wrote: > > > > So does it make sense to separate them logically? Perhaps a

Re: [dpdk-dev] [PATCH v3 7/7] app/testpmd: adjust ethdev port ownership

2018-01-23 Thread Gaëtan Rivet
Hi all, On Tue, Jan 23, 2018 at 08:54:27AM +, Matan Azrad wrote: > > > > > > > > > > Subject: [PATCH v3 7/7] app/testpmd: adjust ethdev port > > > > > > > > > > ownership > > > > > > > > > > > > > > > > > > > > Testpmd should not use ethdev ports which are managed by > > > > > > > > > > oth

Re: [dpdk-dev] [PATCH v3 1/3] doc: convert license headers to SPDX tags

2018-01-23 Thread Bruce Richardson
On Tue, Jan 23, 2018 at 12:29:16PM +, Ferruh Yigit wrote: > Signed-off-by: Ferruh Yigit > --- > v3: update files only has Intel copyright > --- Acked-by: Bruce Richardson

Re: [dpdk-dev] [PATCH v3 2/3] doc: convert license headers to SPDX tags

2018-01-23 Thread Bruce Richardson
On Tue, Jan 23, 2018 at 12:29:17PM +, Ferruh Yigit wrote: > Signed-off-by: Ferruh Yigit > --- > v3: Intel ones sharing copyright > --- > doc/guides/linux_gsg/linux_drivers.rst | 28 +--- > 1 file changed, 1 insertion(+), 27 deletions(-) > >From Intel side: Acked-by: B

[dpdk-dev] [PATCH 2/7 v2] bus/dpaa: allocate qman portals in thread safe manner

2018-01-23 Thread Nipun Gupta
Fixes: 9d32ef0f5d61 ("bus/dpaa: support creating dynamic HW portal") Cc: sta...@dpdk.org Signed-off-by: Nipun Gupta --- drivers/bus/dpaa/base/qbman/qman.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/bus/dpaa/base/qbman/qman.c b/drivers/bus/dpaa/base/qbman

[dpdk-dev] [PATCH 1/7 v2] bus/dpaa: check flag in qman multi enqueue

2018-01-23 Thread Nipun Gupta
A caller may/may not pass the flags in qman enqueue multi API. This patch adds a check on that flag and only accesses it if passed by the caller. Fixes: 43797e7b4774 ("bus/dpaa: support event dequeue and consumption") Cc: sta...@dpdk.org Signed-off-by: Nipun Gupta --- drivers/bus/dpaa/base/qbma

[dpdk-dev] [PATCH 0/7 v2] dpaa: fixes and performance improvement changes

2018-01-23 Thread Nipun Gupta
Patch 1-4 - Fixes some of the issues in the DPAA bus Patch 5-7 - Performance enhancement changes on DPAA platform Hemant Agrawal (2): mempool/dpaa: fix the phy to virt optimization net/dpaa: use phy to virt optimizations Nipun Gupta (4): bus/dpaa: check flag in qman multi enqueue bus/dpaa

[dpdk-dev] [PATCH 6/7 v2] bus/dpaa: check portal presence in the caller API

2018-01-23 Thread Nipun Gupta
In the I/O path we were calling rte_dpaa_portal_init which internally checks if a portal is affined to the core. But this lead to calling of that non-static API in every call. Instead check the portal affinity in the caller itself for performance reasons Signed-off-by: Nipun Gupta --- drivers/b

[dpdk-dev] [PATCH 4/7 v2] bus/dpaa: fix port order shuffling

2018-01-23 Thread Nipun Gupta
From: Shreyansh Jain While scanning for devices, the order in which devices appear is different as compared to MAC sequence. This can cause confusion for users and automated scripts. This patch create a sorted list of devices. Fixes: 919eeaccb2ba ("bus/dpaa: introduce NXP DPAA bus driver skeleto

[dpdk-dev] [PATCH 5/7 v2] net/dpaa: use phy to virt optimizations

2018-01-23 Thread Nipun Gupta
From: Hemant Agrawal Use the optimized routine for phy to virt conversion, when the mempool is allocated from physical contiguous memory. Signed-off-by: Hemant Agrawal --- drivers/net/dpaa/dpaa_rxtx.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/drivers/ne

[dpdk-dev] [PATCH 7/7 v2] net/dpaa: further push mode optimizations

2018-01-23 Thread Nipun Gupta
This patch supports batch processing of multiple packets in the Rx side Signed-off-by: Nipun Gupta Signed-off-by: Hemant Agrawal --- drivers/bus/dpaa/base/qbman/qman.c | 89 ++--- drivers/bus/dpaa/include/fsl_qman.h | 10 + drivers/net/dpaa/dpaa_ethdev.c

[dpdk-dev] [PATCH 3/7 v2] mempool/dpaa: fix the phy to virt optimization

2018-01-23 Thread Nipun Gupta
From: Hemant Agrawal Fixes: 83a4f267f2e3 ("mempool/dpaa: optimize phy to virt conversion") Cc: sta...@dpdk.org Signed-off-by: Hemant Agrawal --- drivers/mempool/dpaa/dpaa_mempool.c | 9 - drivers/mempool/dpaa/dpaa_mempool.h | 4 ++-- 2 files changed, 6 insertions(+), 7 deletions(-) di

Re: [dpdk-dev] [PATCH v3 3/3] doc: convert license headers to SPDX tags

2018-01-23 Thread Hemant Agrawal
This patch will be good if you only add SPDX to it and NOT remove the original license text. i.e. only do following: > -.. BSD LICENSE > +.. SPDX-License-Identifier: BSD-3-Clause Around RC2 timeframe, I intend to do that. All the remaining but valid license files, we will add SPDX and NOT re

[dpdk-dev] [PATCH] event/sw: fix memory leak if self test fails

2018-01-23 Thread Harry van Haaren
If the self test is run and a test fails, the allocated memory would was not freed. The passing case already freed this memory correctly. Fixes: 5e6eb5ccd788 ("event/sw: make test standalone") Coverity ID: 257044 Cc: pbhagavat...@caviumnetworks.com Signed-off-by: Harry van Haaren --- --- drive

[dpdk-dev] [RFC v2 02/17] mempool: add op to calculate memory size to be allocated

2018-01-23 Thread Andrew Rybchenko
Size of memory chunk required to populate mempool objects depends on how objects are stored in the memory. Different mempool drivers may have different requirements and a new operation allows to calculate memory size in accordance with driver requirements and advertise requirements on minimum memor

[dpdk-dev] [RFC v2 10/17] mempool: remove callback to register memory area

2018-01-23 Thread Andrew Rybchenko
The callback is not required any more since there is a new callback to populate objects using provided memory area which provides the same information. Signed-off-by: Andrew Rybchenko --- lib/librte_mempool/rte_mempool.c | 5 - lib/librte_mempool/rte_mempool.h | 31 -

[dpdk-dev] [RFC v2 11/17] mempool: ensure the mempool is initialized before populating

2018-01-23 Thread Andrew Rybchenko
From: "Artem V. Andreev" Callback to calculate required memory area size may require mempool driver data to be already allocated and initialized. Signed-off-by: Artem V. Andreev Signed-off-by: Andrew Rybchenko --- lib/librte_mempool/rte_mempool.c | 29 ++--- 1 file cha

[dpdk-dev] [RFC v2 01/17] mempool: fix phys contig check if populate default skipped

2018-01-23 Thread Andrew Rybchenko
There is not specified dependency between rte_mempool_populate_default() and rte_mempool_populate_iova(). So, the second should not rely on the fact that the first adds capability flags to the mempool flags. Fixes: 65cf769f5e6a ("mempool: detect physical contiguous objects") Cc: sta...@dpdk.org S

[dpdk-dev] [RFC v2 04/17] mempool: add op to populate objects using provided memory

2018-01-23 Thread Andrew Rybchenko
The callback allows to customize how objects are stored in the memory chunk. Default implementation of the callback which simply puts objects one by one is available. Suggested-by: Olivier Matz Signed-off-by: Andrew Rybchenko --- lib/librte_mempool/rte_mempool.c | 44 +++-

[dpdk-dev] [RFC v2 07/17] mempool: deprecate xmem functions

2018-01-23 Thread Andrew Rybchenko
Suggested-by: Olivier Matz Signed-off-by: Andrew Rybchenko --- lib/librte_mempool/rte_mempool.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lib/librte_mempool/rte_mempool.h b/lib/librte_mempool/rte_mempool.h index 697d618..e95b1a7 100644 --- a/lib/librte_mempool/rte_mempool.h +++ b/li

[dpdk-dev] [RFC v2 05/17] mempool/octeontx: implement callback to populate objects

2018-01-23 Thread Andrew Rybchenko
Custom callback is required to fullfil requirement to align object virtual address to total object size. Signed-off-by: Andrew Rybchenko --- drivers/mempool/octeontx/rte_mempool_octeontx.c | 28 + 1 file changed, 28 insertions(+) diff --git a/drivers/mempool/octeontx/rte

[dpdk-dev] [RFC v2 03/17] mempool/octeontx: add callback to calculate memory size

2018-01-23 Thread Andrew Rybchenko
The driver requires one and only one physically contiguous memory chunk for all objects. Signed-off-by: Andrew Rybchenko --- drivers/mempool/octeontx/rte_mempool_octeontx.c | 25 + 1 file changed, 25 insertions(+) diff --git a/drivers/mempool/octeontx/rte_mempool_octeont

[dpdk-dev] [RFC v2 09/17] mempool/dpaa: convert to use populate driver op

2018-01-23 Thread Andrew Rybchenko
Populate mempool driver callback is executed a bit later than register memory area, provides the same information and will substitute the later since it gives more flexibility and in addition to notification about memory area allows to customize how mempool objects are stored in memory. Signed-off

[dpdk-dev] [RFC v2 00/17] mempool: add bucket mempool driver

2018-01-23 Thread Andrew Rybchenko
The patch series starts from generic enhancements suggested by Olivier. Basically it adds driver callbacks to calculate required memory size and to populate objects using provided memory area. It allows to remove so-called capability flags used before to tell generic code how to allocate and slice

[dpdk-dev] [RFC v2 06/17] mempool: remove callback to get capabilities

2018-01-23 Thread Andrew Rybchenko
The callback was introduced to let generic code to know octeontx mempool driver requirements to use single physically contiguous memory chunk to store all objects and align object address to total object size. Now these requirements are met using a new callbacks to calculate required memory chunk s

[dpdk-dev] [RFC v2 13/17] mempool: support flushing the default cache of the mempool

2018-01-23 Thread Andrew Rybchenko
From: "Artem V. Andreev" Mempool get/put API cares about cache itself, but sometimes it is required to flush the cache explicitly. The function is moved in the file since it now requires rte_mempool_default_cache(). Signed-off-by: Artem V. Andreev Signed-off-by: Andrew Rybchenko --- lib/libr

[dpdk-dev] [RFC v2 14/17] mempool: implement abstract mempool info API

2018-01-23 Thread Andrew Rybchenko
From: "Artem V. Andreev" Primarily, it is intended as a way for the mempool driver to provide additional information on how it lays up objects inside the mempool. Signed-off-by: Artem V. Andreev Signed-off-by: Andrew Rybchenko --- lib/librte_mempool/rte_mempool.h | 31

[dpdk-dev] [RFC v2 08/17] mempool/octeontx: prepare to remove register memory area op

2018-01-23 Thread Andrew Rybchenko
Callback to populate pool objects has all required information and executed a bit later than register memory area callback. Signed-off-by: Andrew Rybchenko --- drivers/mempool/octeontx/rte_mempool_octeontx.c | 25 ++--- 1 file changed, 10 insertions(+), 15 deletions(-) diff

[dpdk-dev] [RFC v2 17/17] mempool/bucket: do not allow one lcore to grab all buckets

2018-01-23 Thread Andrew Rybchenko
From: "Artem V. Andreev" Signed-off-by: Artem V. Andreev Signed-off-by: Andrew Rybchenko --- drivers/mempool/bucket/rte_mempool_bucket.c | 13 + 1 file changed, 13 insertions(+) diff --git a/drivers/mempool/bucket/rte_mempool_bucket.c b/drivers/mempool/bucket/rte_mempool_bucket.c

[dpdk-dev] [RFC v2 15/17] mempool: support block dequeue operation

2018-01-23 Thread Andrew Rybchenko
From: "Artem V. Andreev" If mempool manager supports object blocks (physically and virtual contiguous set of objects), it is sufficient to get the first object only and the function allows to avoid filling in of information about each block member. Signed-off-by: Artem V. Andreev Signed-off-by:

[dpdk-dev] [RFC v2 12/17] mempool/bucket: implement bucket mempool manager

2018-01-23 Thread Andrew Rybchenko
From: "Artem V. Andreev" The manager provides a way to allocate physically and virtually contiguous set of objects. Signed-off-by: Artem V. Andreev Signed-off-by: Andrew Rybchenko --- MAINTAINERS| 9 + config/common_base

[dpdk-dev] [RFC v2 16/17] mempool/bucket: implement block dequeue operation

2018-01-23 Thread Andrew Rybchenko
From: "Artem V. Andreev" Signed-off-by: Artem V. Andreev Signed-off-by: Andrew Rybchenko --- drivers/mempool/bucket/rte_mempool_bucket.c | 52 + 1 file changed, 52 insertions(+) diff --git a/drivers/mempool/bucket/rte_mempool_bucket.c b/drivers/mempool/bucket/rte_

[dpdk-dev] [PATCH] doc: announce API/ABI changes for mempool

2018-01-23 Thread Andrew Rybchenko
An API/ABI changes are planned for 18.05 [1]: * Allow to customize how mempool objects are stored in memory. * Deprecate mempool XMEM API. * Add mempool driver ops to get information from mempool driver and dequeue contiguous blocks of objects if driver supports it. [1] http://dpdk.org/ml/a

Re: [dpdk-dev] [PATCH] net/mlx5: remmap UAR address for multiple process

2018-01-23 Thread Nélio Laranjeiro
Hi Xueming, My lonely comments are more related to the commit log which should be re-written to be more accurate to the issue you try to address, even if this patch does not solves it. Please see below, On Tue, Jan 23, 2018 at 09:50:42AM +, Xueming(Steven) Li wrote: > Hi Nelio, > > > -O

[dpdk-dev] [PATCH] doc: replace license text with SPDX tags on SVG images

2018-01-23 Thread Bruce Richardson
Signed-off-by: Bruce Richardson --- doc/guides/howto/img/vf_daemon_overview.svg| 36 ++--- .../prog_guide/img/architecture-overview.svg | 35 ++-- doc/guides/prog_guide/img/bond-mode-0.svg | 36 ++--- doc/guides/prog_guide/img

Re: [dpdk-dev] [PATCH v3 7/7] app/testpmd: adjust ethdev port ownership

2018-01-23 Thread Ananyev, Konstantin
Hi Matan, > > > Hi Konstantin > From: Ananyev, Konstantin, Monday, January 22, 2018 10:49 PM > > Hi Matan, > > > > > -Original Message- > > > From: Matan Azrad [mailto:ma...@mellanox.com] > > > Sent: Monday, January 22, 2018 1:23 PM > > > To: Ananyev, Konstantin ; Gaëtan Rivet > > > > >

[dpdk-dev] questions about new offload ethdev api

2018-01-23 Thread Olivier Matz
Hi, I'm currently porting an application to the new ethdev offload api, and I have two questions about it. 1/ inconsistent offload capa for PMDs using the old API? It is stated in struct rte_eth_txmode: /** * Per-port Tx offloads to be set using DEV_TX_OFFLOAD_* flags. * Only offload

[dpdk-dev] [PATCH] event/opdl: fix license header and SPDX tags

2018-01-23 Thread Bruce Richardson
This patch ensures that the OPDL files all contain correct SPDX tags. The following changes were made to achieve this: * replace license text with SPDX tag * correct occurances where SPDX tag was not on first line of file * ensure license years were correct Fixes: 4236ce9bf5bf ("event/opdl: add OP

Re: [dpdk-dev] [PATCH v2 2/2] net/ixgbe : backplane port MDIO support

2018-01-23 Thread Shweta Choudaha
Hi Helin, Thanks for the review. Yes , the backplane interfaces(x550em) does not have a phy connected but it still MDIO lines for control. The requirement for us is to be able to access phy registers over backplane MDIO . I 've an updated patchset which is cleaner. I 'll send that for review.

Re: [dpdk-dev] [PATCH] net/mlx5: remmap UAR address for multiple process

2018-01-23 Thread Xueming(Steven) Li
> -Original Message- > From: Nélio Laranjeiro [mailto:nelio.laranje...@6wind.com] > Sent: Tuesday, January 23, 2018 9:31 PM > To: Xueming(Steven) Li > Cc: Shahaf Shuler ; dev@dpdk.org > Subject: Re: [PATCH] net/mlx5: remmap UAR address for multiple process > > Hi Xueming, > > My lonely

Re: [dpdk-dev] [PATCH] event/opdl: fix license header and SPDX tags

2018-01-23 Thread Liang, Ma
On 23 Jan 14:11, Bruce Richardson wrote: > This patch ensures that the OPDL files all contain correct SPDX tags. > The following changes were made to achieve this: > * replace license text with SPDX tag > * correct occurances where SPDX tag was not on first line of file > * ensure license years wer

Re: [dpdk-dev] [PATCH] drivers/event: fix resource leak in selftest

2018-01-23 Thread Van Haaren, Harry
> From: Pavan Nikhilesh [mailto:pbhagavat...@caviumnetworks.com] > Sent: Monday, January 22, 2018 5:46 PM > To: jerin.ja...@caviumnetworks.com; Van Haaren, Harry > > Cc: dev@dpdk.org; Pavan Nikhilesh > Subject: [dpdk-dev] [PATCH] drivers/event: fix resource leak in selftest > > Free resources le

Re: [dpdk-dev] [PATCH v3 7/7] app/testpmd: adjust ethdev port ownership

2018-01-23 Thread Thomas Monjalon
23/01/2018 14:34, Ananyev, Konstantin: > If that' s the use case, then I think you need to set device ownership at > creation time - > inside dev_allocate(). > Again that would avoid such racing conditions inside testpmd. The devices must be allocated at a low level layer. When a new device appea

[dpdk-dev] [PATCH] examples/vm_power_manager: fix set VF MAC address

2018-01-23 Thread David Coyle
Current code only sets mac address of first VF. Fix code so that it continues through the loop and sets the mac address of each VF. Fixes: c9a4779135c9 ("examples/vm_power_mgr: set MAC address of VF") Signed-off-by: David Coyle --- examples/vm_power_manager/main.c | 5 ++--- 1 file changed, 2 i

[dpdk-dev] [PATCH] config: replace Intel license headers with SPDX tags

2018-01-23 Thread Bruce Richardson
Signed-off-by: Bruce Richardson --- config/common_base| 33 ++- config/common_bsdapp | 33 ++- config/common_linuxapp| 33 ++- config/defconfig_i686

[dpdk-dev] [PATCH v2 10/10] maintainers: claim ownership of rawdev

2018-01-23 Thread Shreyansh Jain
Signed-off-by: Shreyansh Jain --- MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 5788ea004..c3a8769a2 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -302,6 +302,12 @@ F: lib/librte_eventdev/*eth_rx_adapter* F: test/test/test_event_eth_rx_adap

[dpdk-dev] [PATCH v2 00/10] Introduce generic 'rawdevice' support

2018-01-23 Thread Shreyansh Jain
Change History ~~ v2: - restructure comments to prefix model - split patches pivoted on APIs introduced in library - moved test into drivers/rawdev/skeleton from test/test - removed unused RTE_MAX_RAWDEVPORTS and RTE_MAX_RAWDEVS - merge patch configurations - checkpatch fixes Raw

[dpdk-dev] [PATCH v2 05/10] rawdev: support for firmware management

2018-01-23 Thread Shreyansh Jain
Some generic operations for firmware management can loading, unloading, starting, stopping and querying firmware of a device. This patch adds support for such generic operations. Signed-off-by: Shreyansh Jain --- lib/librte_rawdev/rte_rawdev.c | 43 lib/librte_raw

[dpdk-dev] [PATCH v2 02/10] rawdev: add attribute get and set support

2018-01-23 Thread Shreyansh Jain
A rawdevice can have various attributes. This patch introduce support for transparently setting attribute value or getting current attribute state. This is done by allowing an opaque set of key and value to be passed through rawdev library. Signed-off-by: Shreyansh Jain --- lib/librte_rawdev/rte

[dpdk-dev] [PATCH v2 04/10] rawdev: support for extended stats

2018-01-23 Thread Shreyansh Jain
Generic rawdev library cannot define a pre-defined set of stats for devices which are yet to be defined. This patch introduces the xstats support for rawdev so that any implementation can create its own statistics. Signed-off-by: Shreyansh Jain --- lib/librte_rawdev/rte_rawdev.c | 75

[dpdk-dev] [PATCH v2 03/10] rawdev: add buffer stream IO support

2018-01-23 Thread Shreyansh Jain
Introduce handlers for raw buffer enqueue and dequeue. A raw buffer is essentially a void object which is transparently passed via the library onto the driver. Using a context field as argument, any arbitrary meta information can be passed by application to the driver/implementation. This can be a

[dpdk-dev] [PATCH v2 06/10] rawdev: add self test support

2018-01-23 Thread Shreyansh Jain
Signed-off-by: Shreyansh Jain --- lib/librte_rawdev/rte_rawdev.c | 9 + lib/librte_rawdev/rte_rawdev.h | 12 lib/librte_rawdev/rte_rawdev_pmd.h | 11 +++ lib/librte_rawdev/rte_rawdev_version.map | 1 + 4 files changed, 33 insertions(+) dif

[dpdk-dev] [PATCH v2 01/10] rawdev: introduce raw device library support

2018-01-23 Thread Shreyansh Jain
Each device in DPDK has a type associated with it - ethernet, crypto, event etc. This patch introduces 'rawdevice' which is a generic type of device, not currently handled out-of-the-box by DPDK. A device which can be scanned on an installed bus (pci, fslmc, ...) or instantiated through devargs, c

[dpdk-dev] [PATCH v2 08/10] drivers/raw: support for rawdev testcases

2018-01-23 Thread Shreyansh Jain
Patch introduces rawdev unit testcase for validation against the Skeleton rawdev dummy PMD implementation. Test cases are added along with the skeleton driver implementation. It can be enabled by using vdev argument to any DPDK binary: --vdev="rawdev_skeleton,self_test=1" In case 'self_test=1'

[dpdk-dev] [PATCH v2 07/10] drivers/raw: introduce skeleton rawdev driver

2018-01-23 Thread Shreyansh Jain
Skeleton rawdevice driver, on the lines of eventdev skeleton, is for showcasing the rawdev library. This driver implements some of the operations of the library based on which a test module can be developed. Design of skeleton involves a virtual device which is plugged into VDEV bus on initializat

[dpdk-dev] [PATCH v2 09/10] test: enable rawdev skeleton test

2018-01-23 Thread Shreyansh Jain
Skeleton rawdevice test cases are part of driver layer. This patch allows test cases to be executed using 'rawdev_autotest' command in test framework. Signed-off-by: Shreyansh Jain --- test/test/Makefile | 4 test/test/test_rawdev.c | 27 +++ 2 files changed, 3

[dpdk-dev] [PATCH v2] app/test-crypto-perf: fix index

2018-01-23 Thread Fan Zhang
Fixes: 27c2e7471961 ("app/crypto-perf: support IMIX") A bug caused index out-of-range error. This simple patch is to fix this. Signed-off-by: Fan Zhang --- v2: Removed unnecessary cdev_id assignment line. app/test-crypto-perf/main.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) dif

  1   2   >