Advertise mempool/octeontx as the only supported mempool ops when the
application checks using `rte_eth_dev_pool_ops_supported`.
Signed-off-by: Pavan Nikhilesh
---
drivers/net/octeontx/octeontx_ethdev.c | 12
1 file changed, 12 insertions(+)
diff --git a/drivers/net/octeontx/octeon
On Sun, Dec 10, 2017 at 12:08:22AM +0300, Ilya V. Matveychikov wrote:
> There is no reason to have local variable m2.
>
> Fixes: af75078fece3 ("first public release")
> Signed-off-by: Ilya V. Matveychikov
Acked-by: Olivier Matz
On Sun, Dec 10, 2017 at 12:39:18AM +0300, Ilya V. Matveychikov wrote:
> Update rte_mbuf_sanity_check() to check sanity of data_len and pkt_len
> fields. For segmented packets it is supposed that head's pkt_len field
> should be the sum of all segments data_len values.
>
> Signed-off-by: Ilya V. Ma
> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Radu Nicolau
> Sent: Tuesday, December 12, 2017 11:27 AM
> To: Anoob Joseph ; Akhil Goyal
> ; Doherty, Declan ;
> Gonzalez Monroy, Sergio
> Cc: Narayana Prasad ;
> Jerin Jacob ; dev@dpdk.org
> Subject: Re: [dpdk-
The patch frees memory allocated by add rxtx callbacks
Signed-off-by: Abhinandan Gujjar
---
lib/librte_ether/rte_ethdev.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c
index 318af28..2ab6e05 100644
--- a/lib/librte_ether/rte_e
> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Abhinandan Gujjar
> Sent: Thursday, December 14, 2017 3:32 AM
> To: tho...@monjalon.net
> Cc: dev@dpdk.org; Gujjar, Abhinandan S
> Subject: [dpdk-dev] [PATCH] ethdev: fix memory leaks in remove rxtx callbacks
>
Hi Chunmei,
On Wed, Dec 13, 2017 at 03:44:55PM -0800, chunmei Liu wrote:
> From: chunmei
>
> ceph async messenger has some run time error with this dpdk library,
> 1) need set rxm->next= null at end of packet since not init it to null
> when allocate a buffer other wise rte_mbuf_sanity_check wil
On Wed, Dec 13, 2017 at 03:54:08PM +, Pablo de Lara wrote:
> Two macros were defined in cryptodev, to serve the same
> purpose: RTE_CRYPTODEV_NAME_LEN (in the config file) and
> RTE_CRYPTODEV_NAME_MAX_LEN (in the rte_cryptodev.h file).
> Since the second one is part of the external API,
> the f
On Thu, Dec 14, 2017 at 09:48:29AM +0100, Olivier MATZ wrote:
> On Sun, Dec 10, 2017 at 12:08:22AM +0300, Ilya V. Matveychikov wrote:
> > There is no reason to have local variable m2.
> >
> > Fixes: af75078fece3 ("first public release")
> > Signed-off-by: Ilya V. Matveychikov
>
> Acked-by: Olivi
On Thu, Dec 14, 2017 at 09:50:25AM +0100, Olivier MATZ wrote:
> On Sun, Dec 10, 2017 at 12:39:18AM +0300, Ilya V. Matveychikov wrote:
> > Update rte_mbuf_sanity_check() to check sanity of data_len and pkt_len
> > fields. For segmented packets it is supposed that head's pkt_len field
> > should be t
> -Original Message-
> From: Ananyev, Konstantin
> Sent: Thursday, December 14, 2017 2:47 PM
> To: Gujjar, Abhinandan S ;
> tho...@monjalon.net
> Cc: dev@dpdk.org; Gujjar, Abhinandan S
> Subject: RE: [dpdk-dev] [PATCH] ethdev: fix memory leaks in remove rxtx
> callbacks
>
>
>
> > -
Fix typo in email address.
Fixes: 8a61c83af2fa ("crypto/mrvl: add mrvl crypto driver")
Cc: jianbo@arm.com
Signed-off-by: Tomasz Duszynski
---
MAINTAINERS | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index f0baeb4..f8da564 100644
--- a/MAINTAI
Hello,
I would like to apply this patch in order to review it.
Trying to apply it on 17.11 (and latest) fails due to missing
lib/librte_eal/common/eal_common_vdev.c
Trying to apply it on 17.08.1 fails on missing drivers/bus/pci/bsd/pci.c file
So, on what DPDK version should I apply
Hello Moti,
On Thu, Dec 14, 2017 at 09:48:23AM +, Mordechay Haimovsky wrote:
> Hello,
> I would like to apply this patch in order to review it.
>
In absence of answer from Jeff,
Those two paths were modified during the 17.08 release: both pci and
vdev buses have been moved to drivers/bus.
Hi Gaetan
> -Original Message-
> From: Gaëtan Rivet [mailto:gaetan.ri...@6wind.com]
> Sent: Wednesday, December 13, 2017 11:56 PM
> To: Matan Azrad
> Cc: Adrien Mazarguil ; Thomas Monjalon
> ; dev@dpdk.org; sta...@dpdk.org
> Subject: Re: [PATCH v2 4/4] net/failsafe: fix removed device han
> -Original Message-
> From: Thomas Monjalon [mailto:tho...@monjalon.net]
> Sent: Wednesday, December 13, 2017 7:09 PM
> To: Gaëtan Rivet ; Matan Azrad
>
> Cc: Adrien Mazarguil ; dev@dpdk.org;
> sta...@dpdk.org
> Subject: Re: [PATCH v2 4/4] net/failsafe: fix removed device handling
>
>
On Thu, Dec 14, 2017 at 10:40:22AM +, Matan Azrad wrote:
> Hi Gaetan
>
> > >
> > > If you add this check in the iterator itself, you would skip removed
> > > devices before attempting operating upon them, right?
> > >
> > > Then it should probably help with your issue, unless you tested it
On 12/13/2017 10:43 AM, Hemant Agrawal wrote:
On 12/12/2017 10:27 PM, Olivier MATZ wrote:
On Mon, Dec 11, 2017 at 09:56:40AM -0800, Ferruh Yigit wrote:
On 12/10/2017 9:27 PM, Hemant Agrawal wrote:
Hi all,
Most templates are showing copyright first and SPDX later i.e. the
typical way for wr
When performing live migration or memory hot-plugging,
the changes to the device and vrings made by message handler
done independently from vring usage by PMD threads.
This causes for example segfaults during live-migration
with MQ enable, but in general virtually any request
sent by qemu changing
When use virtio_user as exception path, we need to specify a MAC
address for the tap port.
Signed-off-by: Ning Li
---
drivers/net/virtio/virtio_user/vhost_kernel.c | 3 ++-
drivers/net/virtio/virtio_user/vhost_kernel_tap.c | 8
drivers/net/virtio/virtio_user/vhost_kernel_tap.h | 1
Hi Chunmei,
> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of chunmei Liu
> Sent: Wednesday, December 13, 2017 11:45 PM
> To: dev@dpdk.org
> Cc: Liu, Chunmei
> Subject: [dpdk-dev] [PATCH] fix ceph async messenger runtime bug based on
> spdk/dpdk
>
> From: chunm
Hi Victor,
On 12/14/2017 12:35 PM, Victor Kaplansky wrote:
When performing live migration or memory hot-plugging,
the changes to the device and vrings made by message handler
done independently from vring usage by PMD threads.
This causes for example segfaults during live-migration
with MQ enab
14/12/2017 12:33, Hemant Agrawal:
> Thomas,
> Before I rework,
> What is your opinion w.r.t tooling in DPDK w.r.t SPDX.
>
> I saw a patch for checkpatch in Linux, which will also check for SPDX
> presence for any new file, however this patch only checked first two
> line for SPDX pre
Hi Gaetan
> -Original Message-
> From: Gaëtan Rivet [mailto:gaetan.ri...@6wind.com]
> Sent: Thursday, December 14, 2017 12:49 PM
> To: Matan Azrad
> Cc: Adrien Mazarguil ; Thomas Monjalon
> ; dev@dpdk.org; sta...@dpdk.org
> Subject: Re: [PATCH v2 4/4] net/failsafe: fix removed device hand
On Thu, Dec 14, 2017 at 01:07:31PM +, Matan Azrad wrote:
> Hi Gaetan
>
> > -Original Message-
> > From: Gaëtan Rivet [mailto:gaetan.ri...@6wind.com]
> > Sent: Thursday, December 14, 2017 12:49 PM
> > To: Matan Azrad
> > Cc: Adrien Mazarguil ; Thomas Monjalon
> > ; dev@dpdk.org; sta...
Hi Andrew,
Please find some comments about this patchset below.
I'll also send some comments as replies to the specific patch.
On Fri, Nov 24, 2017 at 04:06:25PM +, Andrew Rybchenko wrote:
> The patch series adds bucket mempool driver which allows to allocate
> (both physically and virtually)
On Fri, Nov 24, 2017 at 04:06:26PM +, Andrew Rybchenko wrote:
> From: "Artem V. Andreev"
>
> Primarily, it is intended as a way for the mempool driver to provide
> additional information on how it lays up objects inside the mempool.
>
> Signed-off-by: Artem V. Andreev
> Signed-off-by: Andre
On Fri, Nov 24, 2017 at 04:06:27PM +, Andrew Rybchenko wrote:
> From: "Artem V. Andreev"
>
> Clustered allocation is required to simplify packaging objects into
> buckets and search of the bucket control structure by an object.
>
> Signed-off-by: Artem V. Andreev
> Signed-off-by: Andrew Ryb
On Fri, Nov 24, 2017 at 04:06:29PM +, Andrew Rybchenko wrote:
> From: "Artem V. Andreev"
>
> Mempool get/put API cares about cache itself, but sometimes it is
> required to flush the cache explicitly.
I don't disagree, but do you have some use-case in mind?
> Also dedicated API allows to d
On Fri, Nov 24, 2017 at 04:06:28PM +, Andrew Rybchenko wrote:
> From: "Artem V. Andreev"
>
> The manager provides a way to allocate physically and virtually
> contiguous set of objects.
>
> Note: due to the way objects are organized in the bucket manager,
> the get_avail_count may return les
On Fri, Nov 24, 2017 at 04:06:30PM +, Andrew Rybchenko wrote:
> From: "Artem V. Andreev"
>
> If mempool manager supports object blocks (physically and virtual
> contiguous set of objects), it is sufficient to get the first
> object only and the function allows to avoid filling in of
> informa
Hi Jerin,
>
> Hi Konstantin,
>
> > The series introduces 2 main changes:
> >
> > 1.Introduce a separate data structure (rte_eth_queue_local)
> > to store local to given process (i.e. no-shareable) information
> > for each configured rx/tx queue.
> > Memory for that structure is allocated/freed d
- Original Message -
> From: "Maxime Coquelin"
> To: "Victor Kaplansky" , dev@dpdk.org
> Cc: sta...@dpdk.org, "Jens Freimann" , "Yuanhan Liu"
> , "Tiwei Bie"
> , "Jianfeng Tan"
> Sent: Thursday, December 14, 2017 2:16:23 PM
> Subject: Re: [PATCH v3] vhost_user: protect active rings fro
When the DPDK_GETMAINTAINER_PATH variable was not set, the error
message from get-maintainer.sh was quite cheap:
$ devtools/get-maintainer.sh --help
usage: get-maintainer.sh
Cannot execute DPDK_GETMAINTAINER_PATH
Add a more detailed explanation about this variable in the
imissed counter has been set as deprecated in commit 49f386542af4
("ethdev: remove driver specific stats") and removed from the
rte_eth_xstats_name_off structure.
The imissed counter has been restored few commits later but has not been
restored in the rte_eth_stats structure. Add it back.
Fixes:
From: Samuel Gauthier
The 'install-sdk' target creates an invalid symlink in the install
directory:
# make install-sdk DESTDIR=/tmp/toto V=1
[...]
ln -snf $(/root/dpdk.org/buildtools/relpath.sh /tmp/toto/usr/local/lib \
/tmp/toto/usr/local/share/dpdk/x86_64-native-linuxapp-gcc/
The functions rte_mbuf_data_dma_addr*() are deprecated.
Replace them with their iova version. Also rename the 'data' variable
to 'mbuf' for more readability.
Signed-off-by: Olivier Matz
---
drivers/net/bnxt/bnxt_ring.h | 3 ---
drivers/net/bnxt/bnxt_rxr.c | 22 +++---
drivers/n
When allocating a new mbuf for Rx, the value of m->data_off should not
be reset to its default value (RTE_PKTMBUF_HEADROOM), instead of reusing
the previous undefined value, which could cause the packet to have a too
small or too high headroom.
Fixes: 2eb53b134aae ("net/bnxt: add initial Rx code")
From: Samuel Gauthier
On arm32, we were always selecting the simple handler, but it is only
available if neon is present.
This is due to a typo in the name of the config option.
CONFIG_RTE_ARCH_ARM is for Makefiles. One should use RTE_ARCH_ARM.
Fixes: 2d7c37194ee4 ("net/virtio: add NEON based R
Display some more useful information from dev_info when
calling "show port info ".
Signed-off-by: Olivier Matz
---
app/test-pmd/config.c | 11 +++
1 file changed, 11 insertions(+)
diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c
index cd2ac1164..b2dbd5647 100644
--- a/app/test
From: Didier Pallard
The rx_queues and tx_queues fields of the data structure points to a struct
virtnet_rx or virtnet_tx. Casting it to a virtqueue is an error.
It does not trigger any bug because pointer is not dereferenced inside the
function, but it can become a bug if this code is copy/past
Hi Jasvinder,
> -Original Message-
> From: Singh, Jasvinder
> Sent: Monday, December 11, 2017 4:27 PM
> To: dev@dpdk.org
> Cc: Iremonger, Bernard ; Mcnamara, John
>
> Subject: [PATCH v2 3/4] examples/flow_classify: update sample application
>
> Update the flow_classify sample app to adap
Hi
> -Original Message-
> From: Gaëtan Rivet [mailto:gaetan.ri...@6wind.com]
> Sent: Thursday, December 14, 2017 3:27 PM
> To: Matan Azrad
> Cc: Adrien Mazarguil ; Thomas Monjalon
> ; dev@dpdk.org; sta...@dpdk.org
> Subject: Re: [PATCH v2 4/4] net/failsafe: fix removed device handling
>
Hi Olivier,
On 12/14/2017 03:32 PM, Olivier Matz wrote:
From: Samuel Gauthier
On arm32, we were always selecting the simple handler, but it is only
available if neon is present.
This is due to a typo in the name of the config option.
CONFIG_RTE_ARCH_ARM is for Makefiles. One should use RTE_ARC
On 12/14/2017 03:33 PM, Olivier Matz wrote:
From: Didier Pallard
The rx_queues and tx_queues fields of the data structure points to a struct
virtnet_rx or virtnet_tx. Casting it to a virtqueue is an error.
It does not trigger any bug because pointer is not dereferenced inside the
function, b
Hi Jasvinder,
> -Original Message-
> From: Singh, Jasvinder
> Sent: Monday, December 11, 2017 4:27 PM
> To: dev@dpdk.org
> Cc: Iremonger, Bernard ; Mcnamara, John
>
> Subject: [PATCH v2 4/4] doc: update documentation for flow classify lib
>
> Updates the documentation for flow classifica
This patchset aims to remove pmd specific unit test clutter from the common
tests directory by moving them into the respective pmd folder.
- Patch [1/11] moves basic asserts into eal area so that they can be reused
by other devices.
- Patch [2/11] introduces new API that an application can use
Adding common test assertion macros for unit testing.
Taken from test/test.h.
Signed-off-by: Pavan Nikhilesh
---
lib/librte_eal/common/Makefile | 2 +-
lib/librte_eal/common/include/rte_test.h | 97
2 files changed, 98 insertions(+), 1 deletion(-)
cre
Move octeontx eventdev specific test (test_eventdev_octeontx.c) to
driver/event/octeontx.
Signed-off-by: Pavan Nikhilesh
---
.../event/octeontx/octeontx_evdev_selftest.c | 0
test/test/Makefile | 1 -
2 files chang
Add API to perform self test on the underlying event device driver.
Signed-off-by: Pavan Nikhilesh
---
lib/librte_eventdev/rte_eventdev.c | 10 ++
lib/librte_eventdev/rte_eventdev.h | 12
lib/librte_eventdev/rte_eventdev_pmd.h | 11 +++
lib/
Modify test_eventdev_octeontx to be standalone selftest independent of
test framework.
Signed-off-by: Pavan Nikhilesh
---
drivers/event/octeontx/octeontx_evdev_selftest.c | 427 +--
1 file changed, 234 insertions(+), 193 deletions(-)
diff --git a/drivers/event/octeontx/octeo
Update octeontx eventdev ops to invoke selftest when application
invokes `rte_event_dev_selftest`.
Signed-off-by: Pavan Nikhilesh
---
drivers/event/octeontx/Makefile | 3 ++-
drivers/event/octeontx/ssovf_evdev.c | 2 ++
drivers/event/octeontx/ssovf_evdev.h | 4
3 files changed, 8 inser
Add selftest as a device argument that can be enabled by suppling
'self_test=1' as a vdev parameter
--vdev="event_octeontx,self_test=1"
The selftest is run after vdev creation is successfully
complete.
Signed-off-by: Pavan Nikhilesh
---
drivers/event/octeontx/Makefile | 2 +-
dri
Move software eventdev specific test (test_eventdev_sw) to
driver/event/sw/.
Signed-off-by: Pavan Nikhilesh
Acked-by: Harry van Haaren
---
test/test/test_eventdev_sw.c => drivers/event/sw/sw_evdev_selftest.c | 0
test/test/Makefile | 1 -
2 file
Modify test_eventdev_sw to be standalone selftest independent of test
framework.
Signed-off-by: Pavan Nikhilesh
---
drivers/event/sw/sw_evdev_selftest.c | 70 ++--
1 file changed, 36 insertions(+), 34 deletions(-)
diff --git a/drivers/event/sw/sw_evdev_selftest.c
Update software eventdev ops to invoke selftest when application invokes
`rte_event_dev_selftest`.
Signed-off-by: Pavan Nikhilesh
---
drivers/event/sw/Makefile | 2 ++
drivers/event/sw/sw_evdev.c | 2 ++
drivers/event/sw/sw_evdev.h | 1 +
3 files changed, 5 insertions(+)
diff --git a/drivers/
Update octeontx eventdev documentation to include new selftest feature.
Signed-off-by: Pavan Nikhilesh
Acked-by: Marko Kovacevic
---
doc/guides/eventdevs/octeontx.rst | 13 +
1 file changed, 13 insertions(+)
diff --git a/doc/guides/eventdevs/octeontx.rst
b/doc/guides/eventdevs/oct
Signed-off-by: Pavan Nikhilesh
---
test/test/test_eventdev.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/test/test/test_eventdev.c b/test/test/test_eventdev.c
index 1ed2a1ddd..b86efab01 100644
--- a/test/test/test_eventdev.c
+++ b/test/test/test_eventdev.c
@@ -1009,4 +1009,11 @@ te
Add Egress flow create for devices supporting
RTE_SECURITY_TX_HW_TRAILER_OFFLOAD.
Signed-off-by: Nelio Laranjeiro
---
examples/ipsec-secgw/ipsec.c | 8
1 file changed, 8 insertions(+)
diff --git a/examples/ipsec-secgw/ipsec.c b/examples/ipsec-secgw/ipsec.c
index 8e8dc6df7..d49970ad8 10
Generic flow API have both direction bits, ingress and egress for rules
which may work on both sides.
Fixes: ec17993a145a ("examples/ipsec-secgw: support security offload")
Cc: akhil.go...@nxp.com
Signed-off-by: Nelio Laranjeiro
Acked-by: Radu Nicolau
Acked-by: Anoob Joseph
---
examples/ipsec
Mellanox INNOVA NIC needs to have final target queue actions to perform
inline crypto.
Signed-off-by: Nelio Laranjeiro
---
Changes in v4:
* remove Egress code.
Changes in v3:
* removed PASSTHRU test for ingress.
* removed check on configured queues for the queue action.
Changes in v2:
Hi Xueming,
On Sat, Dec 09, 2017 at 11:39:23PM +0800, Xueming Li wrote:
> Initialize result memory every time before parsing. Also save
> successfully parsed result before further ambiguous command detection to
> avoid result being tainted by later parsing.
>
> Signed-off-by: Xueming Li
I'm ok
From: Laurent Hardy
When a new mac address is set, it is saved in dev->data->mac_addrs
before the ethdev handler is called.
First, it is inconsistent with the other ethdev functions
rte_eth_dev_mac_addr_remove() and rte_eth_dev_mac_addr_add().
Moreover, it prevents the drivers from wrongly comp
On 12/14/2017 03:21 PM, Victor Kaplansky wrote:
- Original Message -
From: "Maxime Coquelin"
To: "Victor Kaplansky" , dev@dpdk.org
Cc: sta...@dpdk.org, "Jens Freimann" , "Yuanhan Liu"
, "Tiwei Bie"
, "Jianfeng Tan"
Sent: Thursday, December 14, 2017 2:16:23 PM
Subject: Re: [PATCH v
On 12/14/2017 6:21 AM, Olivier Matz wrote:
> When the DPDK_GETMAINTAINER_PATH variable was not set, the error
> message from get-maintainer.sh was quite cheap:
>
> $ devtools/get-maintainer.sh --help
> usage: get-maintainer.sh
> Cannot execute DPDK_GETMAINTAINER_PATH
>
> Add a
On 12/14/2017 6:23 AM, Olivier Matz wrote:
> imissed counter has been set as deprecated in commit 49f386542af4
> ("ethdev: remove driver specific stats") and removed from the
> rte_eth_xstats_name_off structure.
>
> The imissed counter has been restored few commits later but has not been
> restore
On Thu, Dec 14, 2017 at 6:28 AM, Olivier Matz
wrote:
> When allocating a new mbuf for Rx, the value of m->data_off should not
> be reset to its default value (RTE_PKTMBUF_HEADROOM), instead of reusing
> the previous undefined value, which could cause the packet to have a too
> small or too high h
On Thu, Dec 14, 2017 at 6:28 AM, Olivier Matz
wrote:
> The functions rte_mbuf_data_dma_addr*() are deprecated.
> Replace them with their iova version. Also rename the 'data' variable
> to 'mbuf' for more readability.
>
> Signed-off-by: Olivier Matz
>
Acked-by: Ajit Khaparde
Remove Stephen Hurd and add Somnath Kotur to maintain bnxt PMD.
Signed-off-by: Ajit Khaparde
---
MAINTAINERS | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index f0baeb423..5a63b40c2 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -356,8 +356,8 @@ F:
Fix a printf warning which made the compilation fail when compiling
with GCC 7.2 and -Werror:
error: format ‘%llu’ expects argument of type ‘long long unsigned int’,
but argument 8 has type ‘u64 {aka long unsigned int}’ [-Werror=format=]
Signed-off-by: Matteo Croce
---
drivers/net/i40e/base
On 12/14/2017 6:33 AM, Olivier Matz wrote:
> Display some more useful information from dev_info when
> calling "show port info ".
>
> Signed-off-by: Olivier Matz
Reviewed-by: Ferruh Yigit
> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Pavan Nikhilesh
> Sent: Thursday, December 14, 2017 3:01 PM
> To: jerin.ja...@caviumnetworks.com; santosh.shu...@caviumnetworks.com;
> Richardson, Bruce ; Van
> Haaren, Harry ; Eads, Gage ;
> hemant.agra...@nxp.
> -Original Message-
> From: Jerin Jacob [mailto:jerin.ja...@caviumnetworks.com]
> Sent: Wednesday, December 13, 2017 8:49 PM
> To: Eads, Gage
> Cc: Gujjar, Abhinandan S ; dev@dpdk.org;
> Vangati, Narender ; Rao, Nikhil
> ; hemant.agra...@nxp.com; Doherty, Declan
> ; nidadavolu.mur...@ca
> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Matteo Croce
> Sent: Thursday, December 14, 2017 1:23 PM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH] i40e: remove warning
>
> Fix a printf warning which made the compilation fail when compiling with GCC
> 7.
On Thu, Dec 14, 2017 at 9:15 PM, Kyle Larose wrote:
>
>
>> -Original Message-
>> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Matteo Croce
>> Sent: Thursday, December 14, 2017 1:23 PM
>> To: dev@dpdk.org
>> Subject: [dpdk-dev] [PATCH] i40e: remove warning
>>
>> Fix a printf warning
Fix a printf warning which made the compilation fail when compiling
with GCC 7.2 and -Werror:
error: format %llu expects argument of type long long unsigned int,
but argument 8 has type u64 {aka long unsigned int} [-Werror=format=]
Signed-off-by: Matteo Croce
---
v2:
- used PRI*64 macros to
On Thu, Dec 14, 2017 at 9:40 PM, Matteo Croce wrote:
> Fix a printf warning which made the compilation fail when compiling
> with GCC 7.2 and -Werror:
>
> error: format %llu expects argument of type long long unsigned int,
> but argument 8 has type u64 {aka long unsigned int} [-Werror=format=]
From: Stephen Hemminger
Don't need parens on simple if expression
Signed-off-by: Stephen Hemminger
---
lib/librte_eal/linuxapp/kni/ethtool/igb/igb_main.c | 4 ++--
lib/librte_eal/linuxapp/kni/ethtool/ixgbe/ixgbe_common.c | 6 +++---
2 files changed, 5 insertions(+), 5 deletions(-)
diff
Obvious extra parenthesis do not help readability
Signed-off-by: Stephen Hemminger
---
lib/librte_ether/rte_ethdev.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c
index 318af2869743..c53b28bf80fd 100644
--- a
From: Stephen Hemminger
No need for extra parentheis around simple if expresssion
Signed-off-by: Stephen Hemminger
---
drivers/net/bnx2x/bnx2x.c| 2 +-
drivers/net/bnx2x/ecore_sp.c | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/bnx2x/bnx2x.c b/drivers/
Noticed in ethdev an obvious case of extra parenthesis so
went hunting for others as well. There seems to be some weird
coding standard that loves extra parenthesis (or developers
don't understand basic C precedence rules).
Stephen Hemminger (5):
bnx2x: remove (redundant) parenthesis
kni: remo
Signed-off-by: Stephen Hemminger
---
lib/librte_distributor/rte_distributor.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/librte_distributor/rte_distributor.c
b/lib/librte_distributor/rte_distributor.c
index 6ad230131502..b71f254c3cbc 100644
--- a/lib/librte_distribut
Signed-off-by: Stephen Hemminger
---
examples/load_balancer/config.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/examples/load_balancer/config.c b/examples/load_balancer/config.c
index 755a86e48878..f3402eae2c85 100644
--- a/examples/load_balancer/config.c
+++ b/examples/l
Althought granularity of chunks in a mempool is a cacheline, addresses are
extended to align to page boundary for performance reason in device when
registering a MR (Memory Region). This could make some regions overlap,
then can cause Tx completion error due to incorrect LKEY search. If the
error o
If there're more MR(Memroy Region)'s than the size of per-queue cache, the
cache can be overflowed and corrupt the following data structure in
mlx5_txq_data.
Fixes: 6e78005a9b30 ("net/mlx5: add reference counter on DPDK Tx queues")
Cc: sta...@dpdk.org
Signed-off-by: Yongseok Koh
Acked-by: Nelio
Hi all,
I have an urgent question:
1) when an app runs, how to get the really memory it used in real time? for
example, it use -m param to specify 1G memory, but it only used 500 MB, how to
get this info
2) When several apps runs with shared memory: shm 0, is there any method to get
the memo
-Original Message-
> Date: Tue, 5 Dec 2017 14:02:03 +0800
> From: Herbert Guan
> To: dev@dpdk.org
> CC: jerin.ja...@caviumnetworks.com, pbhagavat...@caviumnetworks.com,
> jianbo@arm.com, Herbert Guan
> Subject: [PATCH v2] arch/arm: optimization for memcpy on AArch64
> X-Mailer: git-s
-Original Message-
> Date: Sun, 3 Dec 2017 12:37:30 +
> From: Herbert Guan
> To: Jerin Jacob
> CC: Jianbo Liu , "dev@dpdk.org"
> Subject: RE: [PATCH] arch/arm: optimization for memcpy on AArch64
>
> Jerin,
Hi Herbert,
>
> Thanks a lot for your review and comments. Please find my
88 matches
Mail list logo
