Re: [dpdk-dev] [PATCH 2/5] ethdev: add port ownership

2017-12-03 Thread Matan Azrad
Hi > -Original Message- > From: Neil Horman [mailto:nhor...@tuxdriver.com] > Sent: Friday, December 1, 2017 2:10 PM > To: Gaëtan Rivet > Cc: Matan Azrad ; Thomas Monjalon > ; Jingjing Wu ; > dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 2/5] ethdev: add port ownership > > On Thu, Nov 30,

Re: [dpdk-dev] [PATCH] app/testpmd: app/testpmd: add device removal command

2017-12-03 Thread Raslan Darawsheh
Hi Ferruh, Yes I believe this patch is no more required. Kindest regards, Raslan Darawsheh -Original Message- From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] Sent: Wednesday, November 29, 2017 12:02 AM To: Wu, Jingjing ; Gaëtan Rivet Cc: Raslan Darawsheh ; Thomas Monjalon ; dev@dpd

Re: [dpdk-dev] [PATCH 2/5] ethdev: add port ownership

2017-12-03 Thread Ananyev, Konstantin
Hi Matan, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Matan Azrad > Sent: Sunday, December 3, 2017 8:05 AM > To: Neil Horman ; Gaëtan Rivet > Cc: Thomas Monjalon ; Wu, Jingjing > ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 2/5] ethdev: add port owner

Re: [dpdk-dev] [PATCH V6 1/3] eal/arm64: remove the braces {} for dmb() and dsb()

2017-12-03 Thread Jerin Jacob
-Original Message- > Date: Sun, 26 Nov 2017 18:00:22 -0800 > From: Jia He > To: jerin.ja...@caviumnetworks.com, dev@dpdk.org, > bruce.richard...@intel.com, konstantin.anan...@intel.com > Cc: olivier.m...@6wind.com, jianbo@arm.com, hemant.agra...@nxp.com, Jia > He , sta...@dpdk.org, J

Re: [dpdk-dev] [PATCH v6] net/i40e: determine number of queues per VF during run time

2017-12-03 Thread Ananyev, Konstantin
Hi Wei, > -Original Message- > From: Dai, Wei > Sent: Monday, November 27, 2017 8:09 AM > To: Wu, Jingjing ; Xing, Beilei > ; Ananyev, Konstantin > Cc: dev@dpdk.org; Dai, Wei > Subject: [PATCH v6] net/i40e: determine number of queues per VF during run > time > > Without this patch, th

Re: [dpdk-dev] [PATCH V6 2/3] ring: introduce new header file to include common functions

2017-12-03 Thread Jerin Jacob
-Original Message- > Date: Sun, 26 Nov 2017 18:00:23 -0800 > From: Jia He > To: jerin.ja...@caviumnetworks.com, dev@dpdk.org, > bruce.richard...@intel.com, konstantin.anan...@intel.com > Cc: olivier.m...@6wind.com, jianbo@arm.com, hemant.agra...@nxp.com, Jia > He , Jia He > Subject:

Re: [dpdk-dev] [PATCH V6 3/3] ring: introduce new header file to support C11 memory model

2017-12-03 Thread Jerin Jacob
-Original Message- > Date: Sun, 26 Nov 2017 18:00:24 -0800 > From: Jia He > To: jerin.ja...@caviumnetworks.com, dev@dpdk.org, > bruce.richard...@intel.com, konstantin.anan...@intel.com > Cc: olivier.m...@6wind.com, jianbo@arm.com, hemant.agra...@nxp.com, Jia > He , Jia He > Subject:

Re: [dpdk-dev] [PATCH] arch/arm: optimization for memcpy on AArch64

2017-12-03 Thread Herbert Guan
Jerin, Thanks a lot for your review and comments. Please find my comments below inline. Best regards, Herbert > -Original Message- > From: Jerin Jacob [mailto:jerin.ja...@caviumnetworks.com] > Sent: Wednesday, November 29, 2017 20:32 > To: Herbert Guan > Cc: Jianbo Liu ; dev@dpdk.org

[dpdk-dev] [PATCH] config/thunderx: disable c11 mem model ring implementation

2017-12-03 Thread Jerin Jacob
On thunderx and octeontx, ring_perf_autotest and ring_pmd_perf_autotest test shows better performance when disabling CONFIG_RTE_RING_USE_C11_MEM_MODEL. On the other hand, Enabling CONFIG_RTE_RING_USE_C11_MEM_MODEL shows better performance on thunderx2. Since thunderx2 is using the default armv8 con

Re: [dpdk-dev] [PATCH] arch/arm: optimization for memcpy on AArch64

2017-12-03 Thread Herbert Guan
Pavan, Thanks for review and comments. Please find my comments inline below. Best regards, Herbert > -Original Message- > From: Pavan Nikhilesh Bhagavatula > [mailto:pbhagavat...@caviumnetworks.com] > Sent: Saturday, December 2, 2017 15:33 > To: Herbert Guan ; Jianbo Liu > > Cc: dev@dp

Re: [dpdk-dev] [PATCH 2/5] ethdev: add port ownership

2017-12-03 Thread Matan Azrad
Hi Konstantine > -Original Message- > From: Ananyev, Konstantin [mailto:konstantin.anan...@intel.com] > Sent: Sunday, December 3, 2017 1:10 PM > To: Matan Azrad ; Neil Horman > ; Gaëtan Rivet > Cc: Thomas Monjalon ; Wu, Jingjing > ; dev@dpdk.org > Subject: RE: [dpdk-dev] [PATCH 2/5] ethde

Re: [dpdk-dev] [PATCH] arch/arm: optimization for memcpy on AArch64

2017-12-03 Thread Pavan Nikhilesh Bhagavatula
On Sun, Dec 03, 2017 at 12:38:35PM +, Herbert Guan wrote: > Pavan, > > Thanks for review and comments. Please find my comments inline below. > > Best regards, > Herbert > > > There is an existing flag for arm32 to enable neon based memcpy > > RTE_ARCH_ARM_NEON_MEMCPY we could reuse that here

[dpdk-dev] [PATCH V7 1/3] eal/arm64: remove the braces {} for dmb() and dsb()

2017-12-03 Thread Jia He
for the code as follows: if (condition) rte_smp_rmb(); else rte_smp_wmb(); Without this patch, compiler will report this error: error: 'else' without a previous 'if' Fixes: 84733fd0d75e ("eal/arm64: fix memory barrier definition") Cc: sta...@dpdk.org Signed-off-by: Jia He Acked-by

[dpdk-dev] [PATCH V7 0/3] support c11 memory model barrier in librte_ring

2017-12-03 Thread Jia He
To support C11 memory model barrier, 2 options are suggested by Jerin: 1. use rte_smp_rmb 2. use load_acquire/store_release CONFIG_RTE_RING_USE_C11_MEM_MODEL is provided, and by default it is "y" only on arm64 so far. The reason why providing 2 options is due to the performance benchmark differenc

[dpdk-dev] [PATCH V7 3/3] ring: introduce new header file to support C11 memory model

2017-12-03 Thread Jia He
To support C11 memory model barrier, 2 options are suggested by Jerin: 1. use rte_smp_rmb 2. use load_acquire/store_release(refer to [1]). CONFIG_RTE_RING_USE_C11_MEM_MODEL is provided, and by default it is "y" only on arm64 so far. The reason why providing 2 options is due to the performance benc

[dpdk-dev] [PATCH V7 2/3] ring: introduce new header file to include common functions

2017-12-03 Thread Jia He
move the common part of rte_ring.h into rte_ring_generic.h. move the memory barrier part into update_tail(). no functional changes here. Signed-off-by: Jia He Suggested-by: Jerin Jacob Suggested-by: Ananyev Konstantin Acked-by: Jerin Jacob --- lib/librte_eventdev/rte_event_ring.h | 6 +- l

Re: [dpdk-dev] [PATCH 0/7] Sync with MUSDK-17.10

2017-12-03 Thread Jianbo Liu
The 12/01/2017 16:19, Tomasz Duszynski wrote: > This patchset brings following changes: > > o Sync with MUSDK-17.10. Latest version of the library comes with many > improvements and fixes thus switching to it is beneficial. > > o A few code and documentation updates. > > Changes since v1: > o Add

Re: [dpdk-dev] [PATCH 0/2] Sync compilation with MUSDK-17.10

2017-12-03 Thread Jianbo Liu
The 11/30/2017 14:32, Tomasz Duszynski wrote: > This patchset comes with the following changes: > > o MUSDK-17.10 is the latest version of the library. Since it brings > improvements and fixes switch is necessary. > > o Some minor updates to the documentation. > > Tomasz Duszynski (2): > crypto

Re: [dpdk-dev] [PATCH] eventdev: set rte errno in port link/unlink functions

2017-12-03 Thread Jerin Jacob
-Original Message- > Date: Tue, 14 Nov 2017 16:44:10 -0600 > From: Gage Eads > To: dev@dpdk.org > CC: jerin.ja...@caviumnetworks.com, harry.van.haa...@intel.com, > bruce.richard...@intel.com, hemant.agra...@nxp.com, nipun.gu...@nxp.com, > santosh.shu...@caviumnetworks.com, pbhagavat...@c

Re: [dpdk-dev] [PATCH] eventdev: set rte errno in port link/unlink functions

2017-12-03 Thread Jerin Jacob
-Original Message- > Date: Mon, 4 Dec 2017 08:36:20 +0530 > From: Jerin Jacob > To: Gage Eads > CC: dev@dpdk.org, harry.van.haa...@intel.com, bruce.richard...@intel.com, > hemant.agra...@nxp.com, nipun.gu...@nxp.com, > santosh.shu...@caviumnetworks.com, pbhagavat...@caviumnetworks.com >

[dpdk-dev] [PATCH v2 1/2] net/virtio: make control queue thread-safe

2017-12-03 Thread Xiao Wang
The virtio_send_command function may be called from app's configuration routine, but also from an interrupt handler called when live migration is done on the backup side. So this patch makes control queue thread-safe first. Signed-off-by: Xiao Wang --- v2: - Use spaces instead of tabs between the

[dpdk-dev] [PATCH v2 0/2] net/virtio: support GUEST ANNOUNCE

2017-12-03 Thread Xiao Wang
When live migration is finished, the backup VM needs to proactively announce its new location. DPDK vhost has implemented VHOST_USER_PROTOCOL_F_RARP to generate a RARP packet to switch in dequeue path. Another method is to let the guest proactively send out RARP packet using VIRTIO_NET_F_GUEST_ANNO

[dpdk-dev] [PATCH v2 2/2] net/virtio: support GUEST ANNOUNCE

2017-12-03 Thread Xiao Wang
When live migration is done, for the backup VM, either the virtio frontend or the vhost backend needs to send out gratuitous RARP packet to announce its new network location. This patch enables VIRTIO_NET_F_GUEST_ANNOUNCE feature to support live migration scenario where the vhost backend doesn't h

[dpdk-dev] [PATCH] maintainers: update for i40e

2017-12-03 Thread Jingjing Wu
Signed-off-by: Jingjing Wu --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index f0baeb4..426764e 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -414,8 +414,8 @@ F: doc/guides/nics/intel_vf.rst F: doc/guides/nics/features/ixgbe*.ini

[dpdk-dev] [PATCH] maintainers: update for testpmd

2017-12-03 Thread Jingjing Wu
Signed-off-by: Jingjing Wu --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index f0baeb4..460fa0f 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -924,6 +924,7 @@ F: test/test/virtual_pmd.c F: test/test/virtual_pmd.h Driver testing tool +M: Wenzhuo

Re: [dpdk-dev] [PATCH] maintainers: update for testpmd

2017-12-03 Thread Zhang, Helin
> -Original Message- > From: Wu, Jingjing > Sent: Monday, December 4, 2017 2:18 PM > To: dev@dpdk.org > Cc: Lu, Wenzhuo; Zhang, Helin; Wu, Jingjing > Subject: [PATCH] maintainers: update for testpmd > > Signed-off-by: Jingjing Wu Acked-by: Helin Zhang > --- > MAINTAINERS | 1 + > 1 f

Re: [dpdk-dev] [PATCH] maintainers: update for i40e

2017-12-03 Thread Zhang, Helin
> -Original Message- > From: Wu, Jingjing > Sent: Monday, December 4, 2017 2:16 PM > To: dev@dpdk.org > Cc: Zhang, Qi Z; Zhang, Helin; Wu, Jingjing > Subject: [PATCH] maintainers: update for i40e > > Signed-off-by: Jingjing Wu Acked-by: Helin Zhang > --- > MAINTAINERS | 2 +- > 1 file

[dpdk-dev] [PATCH] net/fm10k: remove RSS restriction with num of queues

2017-12-03 Thread zhouyangchao
FM10K HW does not have such restrictions. Enabling RSS with single queue is not used to distribute flow but to compute a RSS hash value. It can reduce cpu cycles of computing a hash value with five tuples. In addition, there is an explicit method to disable RSS instead of an obscure way. Signed-o

Re: [dpdk-dev] [PATCH] arch/arm: optimization for memcpy on AArch64

2017-12-03 Thread Herbert Guan
> -Original Message- > From: Pavan Nikhilesh Bhagavatula > [mailto:pbhagavat...@caviumnetworks.com] > Sent: Sunday, December 3, 2017 22:21 > To: Herbert Guan ; Jianbo Liu > > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] arch/arm: optimization for memcpy on > AArch64 > > On Sun, Dec

Re: [dpdk-dev] [PATCH v2] net/virtio: fix an incorrect behavior of device stop/start

2017-12-03 Thread Tiwei Bie
On Sat, Dec 02, 2017 at 12:30:33PM +0800, Tiwei Bie wrote: > Hi Antonio, > > On Sat, Dec 02, 2017 at 01:17:58AM +0800, Fischetti, Antonio wrote: > > Hi All, > > I've got an update on this. > > I could replicate the same issue by using testpmd + a VM (= Virtual > > Machine). > > > > The test topo

Re: [dpdk-dev] [PATCH] mmap(2) returns MAP_FAILED, not NULL, on failure

2017-12-03 Thread Matej Vido
On 02.12.2017 01:54, Ferruh Yigit wrote: On 11/30/2017 10:51 PM, Michael McConville wrote: Signed-off-by: Michael McConville --- lib/librte_eal/bsdapp/eal/eal_memory.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_eal/bsdapp/eal/eal_memory.c b/lib/librte_eal/bsd

Re: [dpdk-dev] [PATCH v3] examples/ipsec-secgw: fix usage of incorrect port

2017-12-03 Thread Akhil Goyal
Hi Anoob, On 11/29/2017 9:51 AM, Anoob Joseph wrote: Hi Akhil, On 24-11-2017 16:19, Akhil Goyal wrote: Hi Anoob, On 11/24/2017 3:28 PM, Anoob wrote:   static inline void   route4_pkts(struct rt_ctx *rt_ctx, struct rte_mbuf *pkts[], uint8_t nb_pkts)   {   uint32_t hop[MAX_PKT_BURST * 2]