Hi,
While I agree that taking full fledged lock by rte_rwlock_read_lock() solves
the race condition,
I'm afraid that it would be too expensive in case when logging is off, since it
introduces
acquiring and releasing lock into the main flow of ring updates.
It is OK for now, as it fixes the bug,
Hi Victor,
On 11/27/2017 09:16 AM, Victor Kaplansky wrote:
Hi,
While I agree that taking full fledged lock by rte_rwlock_read_lock() solves
the race condition,
I'm afraid that it would be too expensive in case when logging is off, since it
introduces
acquiring and releasing lock into the main
Without this patch, the number of queues per i40e VF is defined as 4
by CONFIG_RTE_LIBRTE_I40E_QUEUE_NUM_PER_VF=4 in config/common_base.
It is fixed value determined in building time and can't be changed
during run time.
With this patch, the number of queues per i40e VF can be determinated
during
- Original Message -
> From: "Maxime Coquelin"
> To: "Victor Kaplansky"
> Cc: dev@dpdk.org, y...@fridaylinux.org, "tiwei bie" ,
> "jianfeng tan" ,
> sta...@dpdk.org, jfrei...@redhat.com
> Sent: Monday, November 27, 2017 10:27:22 AM
> Subject: Re: [PATCH v2 2/3] vhost: protect dirty log
On 11/27/2017 09:42 AM, Victor Kaplansky wrote:
- Original Message -
From: "Maxime Coquelin"
To: "Victor Kaplansky"
Cc: dev@dpdk.org, y...@fridaylinux.org, "tiwei bie" , "jianfeng
tan" ,
sta...@dpdk.org, jfrei...@redhat.com
Sent: Monday, November 27, 2017 10:27:22 AM
Subject: Re:
Fix the mismatch of two table's title and content
Signed-off-by: Gong Deli
---
doc/guides/prog_guide/qos_framework.rst | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/doc/guides/prog_guide/qos_framework.rst
b/doc/guides/prog_guide/qos_framework.rst
index f3f60b8..31030a2
Hi William:
> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Chas Williams
> Sent: Saturday, November 25, 2017 7:57 AM
> To: dev@dpdk.org
> Cc: skh...@vmware.com; Chas Williams <3ch...@gmail.com>; Chas
> Williams
> Subject: [dpdk-dev] [PATCH] vfio: try physical
Hi all,
I'm working in ovs 2.4 version, and I use "dpdkb" type netdev. Then I
call `ovs-ofctl mod br dpdkbond DOWN` to down this device, at last, my
code call "rte_eth_dev_stop(dev->port_id);".
But counter shows the port is still rx/tx, why?
The "dev->port_id" is bond port id, should I use slave port id instead ?
2017-11-27 18:07 GMT+08:00 Sam :
> Hi all,
>
> I'm working in ovs 2.4 version, and I use "dpdkb" type netdev. Then I
> call `ovs-ofctl mod br dpdkbond DOWN` to down this device, at last, my
> code call "rte_eth_dev_stop(dev
> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Billy O'Mahony
> Sent: Saturday, November 25, 2017 10:11 PM
> To: Doherty, Declan ; dev@dpdk.org
> Cc: O Mahony, Billy
> Subject: [dpdk-dev] [PATCH] cryptodev: Fix typo in qat.rst
>
> Signed-off-by: Billy O'Maho
Hi Fiona
Thanks for spec. It looks good to move ahead for API proof-concepting however
still need to address few key open points from rfc doc and others minor
comments (please see inline):
A. new enum for operation types:
1. Add rte_comp_op_type
enum
> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Bruce Richardson
> Sent: Friday, November 24, 2017 12:53 AM
> To: Wu, Jingjing ; Xing, Beilei
> Cc: dev@dpdk.org; Richardson, Bruce
> Subject: [dpdk-dev] [PATCH 0/2] AVX2 Vectorized Rx/Tx functions for i40e
>
>
Nacked-by: Billy O'Mahony
There are some assumptions about the internals of crypto lib in this comment.
I'll remove those and submit again.
> -Original Message-
> From: O Mahony, Billy
> Sent: Saturday, November 25, 2017 10:11 PM
> To: Doherty, Declan ; dev@dpdk.org
> Cc: O Mahony, Bill
Signed-off-by: Billy O'Mahony
---
doc/guides/cryptodevs/qat.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/doc/guides/cryptodevs/qat.rst b/doc/guides/cryptodevs/qat.rst
index cb17b6b..c8ef378 100644
--- a/doc/guides/cryptodevs/qat.rst
+++ b/doc/guides/cryptodevs/qat.rst
@
> -Original Message-
> From: O Mahony, Billy
> Sent: Monday, November 27, 2017 11:14 AM
> To: De Lara Guarch, Pablo ;
> dev@dpdk.org
> Cc: O Mahony, Billy
> Subject: [PATCH] cryptodev: Fix typo in qat.rst
>
> Signed-off-by: Billy O'Mahony
> ---
> doc/guides/cryptodevs/qat.rst | 2 +-
>
Signed-off-by: Billy O'Mahony
---
lib/librte_cryptodev/rte_cryptodev.h | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/lib/librte_cryptodev/rte_cryptodev.h
b/lib/librte_cryptodev/rte_cryptodev.h
index dade554..879bd71 100644
--- a/lib/librte_cryptodev/rte_cryptodev.h
+++
> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Billy O'Mahony
> Sent: Monday, November 27, 2017 11:40 AM
> To: De Lara Guarch, Pablo ; dev@dpdk.org
> Cc: O Mahony, Billy
> Subject: [dpdk-dev] [PATCH] cryptodev: Add useful comment to _sym_session
>
> Signed-o
On Mon, Nov 27, 2017 at 01:16:04PM +0530, Hemant Agrawal wrote:
> Signed-off-by: Hemant Agrawal
> ---
> GNUmakefile | 27 +--
> Makefile| 27 +--
> 2 files changed, 2 insertions(+), 52 deletions(-)
>
> diff --git a/GNUmakefile b/GNUmakefile
> i
Hi all,
Here is a list of patches targeted for stable release 17.08.1. Please
help review and test. The planned date for the final release is 7th,
Dec. Before that, please shout if anyone has objections with these
patches being applied.
These patches are located at branch 17.08 of dpdk-stable rep
Increase the internal limit for flow types from 32 to 64
to support future flow type extensions.
Change type of variables from uint32_t[] to uint64_t[]:
rte_eth_fdir_info.flow_types_mask
rte_eth_hash_global_conf.sym_hash_enable_mask
rte_eth_hash_global_conf.valid_bit_mask
This modification a
On Fri, Nov 24, 2017 at 03:04:00AM -0800, Xiao Wang wrote:
> When live migration is done, for the backup VM, either the virtio
> frontend or the vhost backend needs to send out gratuitous RARP packet
> to announce its new network location.
>
> This patch enables VIRTIO_NET_F_GUEST_ANNOUNCE feature
On Mon, Nov 27, 2017 at 4:30 AM, Zhang, Qi Z wrote:
> Hi William:
>
> > -Original Message-
> > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Chas Williams
> > Sent: Saturday, November 25, 2017 7:57 AM
> > To: dev@dpdk.org
> > Cc: skh...@vmware.com; Chas Williams <3ch...@gmail.com>;
On Wed, Nov 22, 2017 at 07:43:13PM +0530, Anoob wrote:
> Hi,
>
> Please see inline.
>
>
> On 11/22/2017 06:57 PM, Neil Horman wrote:
> > On Wed, Nov 22, 2017 at 06:55:15AM +, Anoob Joseph wrote:
> > > In case of inline protocol processed ingress traffic, the packet may not
> > > have enough
On Fri, Nov 24, 2017 at 05:59:09PM +0800, Chen Hailin wrote:
> Hi Aaron Conole && Jianfeng,
>
> The stp could not work in ovs-dpdk vhostuser.
> Because the attached vhost device doesn't have MAC address.
>
> Now we have two ways to solve this problem.
> 1. The vhost learns MAC address from packet
Hi Pavan,
Sure, will do.
Thanks,
Gabriel
> -Original Message-
> From: Pavan Nikhilesh Bhagavatula
> [mailto:pbhagavat...@caviumnetworks.com]
> Sent: Wednesday, November 22, 2017 10:37 PM
> To: Carrillo, Erik G
> Cc: jerin.ja...@caviumnetworks.com; nipun.gu...@nxp.com;
> hemant.agra...@n
Thanks, Pablo. Will remember for future ref.
Cheers,
Billy
> -Original Message-
> From: De Lara Guarch, Pablo
> Sent: Monday, November 27, 2017 11:20 AM
> To: O Mahony, Billy ; dev@dpdk.org
> Subject: RE: [PATCH] cryptodev: Fix typo in qat.rst
>
>
>
> > -Original Message-
> > F
On 11/27/2017 10:27 PM, Yuanhan Liu wrote:
On Fri, Nov 24, 2017 at 05:59:09PM +0800, Chen Hailin wrote:
Hi Aaron Conole && Jianfeng,
The stp could not work in ovs-dpdk vhostuser.
Because the attached vhost device doesn't have MAC address.
Now we have two ways to solve this problem.
1. The vh
Yuanhan Liu writes:
> On Fri, Nov 24, 2017 at 05:59:09PM +0800, Chen Hailin wrote:
>> Hi Aaron Conole && Jianfeng,
>>
>> The stp could not work in ovs-dpdk vhostuser.
>> Because the attached vhost device doesn't have MAC address.
>>
>> Now we have two ways to solve this problem.
>> 1. The vhost
On 11/28/2017 12:14 AM, Aaron Conole wrote:
Yuanhan Liu writes:
On Fri, Nov 24, 2017 at 05:59:09PM +0800, Chen Hailin wrote:
Hi Aaron Conole && Jianfeng,
The stp could not work in ovs-dpdk vhostuser.
Because the attached vhost device doesn't have MAC address.
Now we have two ways to solve
Hi Jay,
Thanks for contributing to DPDK.
The code has been tested and works fine.
A few comments:
1. Could you split the patch into a patchset, as suggested in contribution
guide in http://dpdk.org/doc/guides/contributing/patches.html, section 5.4?
2. Please update doc/guides/cryptodevs for d
"Tan, Jianfeng" writes:
> On 11/27/2017 10:27 PM, Yuanhan Liu wrote:
>> On Fri, Nov 24, 2017 at 05:59:09PM +0800, Chen Hailin wrote:
>>> Hi Aaron Conole && Jianfeng,
>>>
>>> The stp could not work in ovs-dpdk vhostuser.
>>> Because the attached vhost device doesn't have MAC address.
>>>
>>> Now w
On Sun, 2017-11-05 at 01:17 +0100, Thomas Monjalon wrote:
> Hi, restarting an old topic,
>
> 05/01/2017 16:52, Tan, Jianfeng:
> > On 1/5/2017 5:34 AM, Walker, Benjamin wrote:
> > > > > Note that this
> > > > > probably means that using uio on recent kernels is subtly
> > > > > broken and cannot be
On 11/26/2017 11:19 PM, Shahaf Shuler wrote:
> Thursday, November 23, 2017 11:30 AM, Nelio Laranjeiro:
>> This drop queue can be handled efficiently by using the drop flag in the
>> context.
>>
>> Signed-off-by: Nelio Laranjeiro
>> Acked-by: Yongseok Koh
>
> Applied to next-net-mlx, thanks.
Hi
Hi Shally,
> -Original Message-
> From: Verma, Shally [mailto:shally.ve...@cavium.com]
> Sent: Tuesday, October 31, 2017 11:39 AM
> To: dev@dpdk.org; Trahe, Fiona ; Athreya, Narayana
> Prasad
> ; Challa, Mahipal
>
> Subject: [RFC v1] doc compression API for DPDK
>
> HI Fiona
>
> This
Monday, November 27, 2017 9:34 AM, Jerin Jacob:
> >
> > Monday, November 27, 2017 8:35 AM, Andrew Rybchenko:
> >
> > I agree about the Fast free offload. However IMO such optimization can be
> introduced on other series which further more optimize the performance of
> such applications, what do you
Monday, November 13, 2017 11:26 AM, Adrien Mazarguil:
>
> On Sun, Nov 12, 2017 at 04:36:22PM +0200, Raslan Darawsheh wrote:
> > Add RSS hash result from CQE to mbuf,
> > Also, set PKT_RX_RSS_HASH in the ol_flags.
> >
> > Signed-off-by: Raslan Darawsheh
>
> Acked-by: Adrien Mazarguil
Applied to
On 11/16/2017 12:03 AM, Andrew Rybchenko wrote:
> From: Andrew Jackson
>
> Signed-off-by: Andrew Jackson
> Signed-off-by: Andrew Rybchenko
> ---
> drivers/net/sfc/base/siena_flash.h | 12 +---
> 1 file changed, 9 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/sfc/base/sien
On 11/16/2017 12:04 AM, Andrew Rybchenko wrote:
> From: Mark Spender
>
> For encapsulated packets, the firmware gives info about the inner frame
> fields by default. When not using encapsulation offload, ask for info
> about the outer frame instead.
>
> Unless bug69842 is fixed, a driver reload
On 11/16/2017 12:04 AM, Andrew Rybchenko wrote:
> From: Mark Spender
>
What has been fixed here?
If you can provide more details I can amend the commit later.
> Fixes: 05fce2ce8451 ("net/sfc/base: import libefx licensing")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Mark Spender
> Signed-off-by:
On 11/16/2017 12:04 AM, Andrew Rybchenko wrote:
> From: Andy Moreton
We don't know what mkconfig.py is and most probably not interested in :) This
looks like your internal detail, more interesting is the effect of this change,
like "add new sensors".
btw, just out of curiosity, what sensors are
On 11/16/2017 12:03 AM, Andrew Rybchenko wrote:
> From: Andrew Jackson
>
> Signed-off-by: Andrew Jackson
> Signed-off-by: Andrew Rybchenko
Welcome Andrew Jackson!
On 11/16/2017 12:04 AM, Andrew Rybchenko wrote:
> From: Andy Moreton
>
PREfast seems a static analysis tool. Can you please give more detail about
fixed issue itself. "fix PREfast issue" is not informative about what has been
fixed.
If you can send the details I can amend the commit.
Thanks,
f
On 11/16/2017 12:04 AM, Andrew Rybchenko wrote:
> From: Vijay Srivastava
>
> Fixed build issue with the EFSYS_OPT_PHY_LED_CONTROL for Huntigton and
> Medford.
>
> Fixes: b1d06c75e32c ("net/sfc/base: import PHY LEDs control")
> Fixes: 0a7864349106 ("net/sfc/base: import PHY statistics")
> Cc: sta
On 11/16/2017 12:04 AM, Andrew Rybchenko wrote:
> From: Andrew Rybchenko
Since sign-off by is from @solarflare.com, I have updated author to:
"Andrew Rybchenko " for all patches that author and
sign-off is different, assuming both are you.
> Make it clear from the name that it pushes doorbell.
>
On 11/16/2017 12:03 AM, Andrew Rybchenko wrote:
> The series updates sfc base driver.
>
> There are a number of check patch warnings and errors because of
> coding style differencies.
>
> Andrew Jackson (2):
> net/sfc/base: copy new header from firmwaresrc
> net/sfc/base: add support for new
This patch adds a private data pointer to virtio_net structure, to
allow more virtio device driver information.
Signed-off-by: Fan Zhang
---
lib/librte_vhost/vhost.h | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/lib/librte_vhost/vhost.h b/lib/librte_vhost/vhost.h
index 1
This patchset adds crypto backend suppport to vhost_user library,
including a proof-of-concept sample application. The implementation
follows the virtio-crypto specification and have been tested
with qemu 2.9.50 (with several patches applied, detailed later)
with Fedora 24 running in the frontend.
This patch adds session message handler to vhost crypto
Signed-off-by: Fan Zhang
---
lib/librte_vhost/vhost_crypto.c | 447
1 file changed, 447 insertions(+)
create mode 100644 lib/librte_vhost/vhost_crypto.c
diff --git a/lib/librte_vhost/vhost_crypto.c
This patch adds the implementation that parses virtio crypto request
to dpdk crypto operation
Signed-off-by: Fan Zhang
---
lib/librte_vhost/vhost_crypto.c | 688
1 file changed, 688 insertions(+)
diff --git a/lib/librte_vhost/vhost_crypto.c b/lib/librte_
This patch adds virtio-crypto spec user message structure to
vhost_user.
Signed-off-by: Fan Zhang
---
lib/librte_vhost/vhost_user.h | 25 +
1 file changed, 25 insertions(+)
diff --git a/lib/librte_vhost/vhost_user.h b/lib/librte_vhost/vhost_user.h
index 990b40a..793cdc2
This patch adds a vhost_user_dev_priv structure and a vhost_user
message handler function prototype to vhost_user. This allows
different types of devices to add private information and their
device-specific vhost-user message function handlers to
virtio_net structure. The change to vhost_user_msg_h
This patch adds public head file API for vhost crypto
Signed-off-by: Fan Zhang
---
lib/librte_vhost/rte_vhost_crypto.h | 150
1 file changed, 150 insertions(+)
create mode 100644 lib/librte_vhost/rte_vhost_crypto.h
diff --git a/lib/librte_vhost/rte_vhost_cr
This patch adds public API implementation to vhost crypto
Signed-off-by: Fan Zhang
---
lib/librte_vhost/vhost_crypto.c | 179
1 file changed, 179 insertions(+)
diff --git a/lib/librte_vhost/vhost_crypto.c b/lib/librte_vhost/vhost_crypto.c
index d12a449..
Signed-off-by: Fan Zhang
---
lib/librte_vhost/rte_vhost_version.map | 11 +++
1 file changed, 11 insertions(+)
diff --git a/lib/librte_vhost/rte_vhost_version.map
b/lib/librte_vhost/rte_vhost_version.map
index 1e70495..75d67cb 100644
--- a/lib/librte_vhost/rte_vhost_version.map
+++ b/li
This patch adds vhost_crypto sample application to DPDK.
Signed-off-by: Fan Zhang
---
examples/vhost_crypto/Makefile | 59 +
examples/vhost_crypto/main.c | 588 +
2 files changed, 647 insertions(+)
create mode 100644 examples/vhost_crypto/Makefile
Signed-off-by: Fan Zhang
---
doc/guides/prog_guide/vhost_lib.rst | 16 ++
doc/guides/rel_notes/release_18_02.rst| 7 +++
doc/guides/sample_app_ug/index.rst| 1 +
doc/guides/sample_app_ug/vhost_crypto.rst | 95 +++
4 files changed, 119 insertions
This patch updates the Makefile of vhost library to enable vhost crypto
compiling
Signed-off-by: Fan Zhang
---
lib/librte_vhost/Makefile | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/lib/librte_vhost/Makefile b/lib/librte_vhost/Makefile
index be18279..060c528 100644
-
Signed-off-by: Fan Zhang
---
config/common_base | 1 +
1 file changed, 1 insertion(+)
diff --git a/config/common_base b/config/common_base
index e74febe..10933d8 100644
--- a/config/common_base
+++ b/config/common_base
@@ -789,6 +789,7 @@ CONFIG_RTE_LIBRTE_PDUMP=y
# Compile vhost user library
Hi Fan,
On 2017/11/28 0:47, Zhang, Roy Fan wrote:
Hi Jay,
Thanks for contributing to DPDK.
The code has been tested and works fine.
A few comments:
1. Could you split the patch into a patchset, as suggested in contribution
guide in http://dpdk.org/doc/guides/contributing/patches.html, secti
From: Junjie Chen
The driver can suppress interrupt when VIRTIO_F_EVENT_IDX feature bit is
negotiated. The driver set vring flags to 0, and MAY use used_event in
available ring to advise device interrupt util reach an index specified
by used_event. The device ignore the lower bit of vring flags,
From: Junjie Chen
This patch add a restriction to multi-process support: secondary
processes should only run alongside primary process with same DPDK
version, so that secondary processes can use the same hugepage mmap
layout as primary process.
Signed-off-by: Junjie Chen
---
doc/guides/prog_g
Dear All,
I am studying the source code of the l3fwd example. I am confused about a
possible race condition in the l3fwd_lpm_simple_forward().
In this function it calls send_single_packet(), which executes the following
code,
len = qconf->tx_mbufs[port].len;
qconf->tx_mbufs[port].m_t
Hi,
On Tue, Nov 28, 2017 at 04:48:26AM -0500, junjie.j.c...@intel.com wrote:
[...]
> @@ -195,6 +197,10 @@ struct vhost_msg {
>
> #define VHOST_USER_F_PROTOCOL_FEATURES 30
>
> +#ifndef VIRTIO_F_EVENT_IDX
> + #define VIRTIO_F_EVENT_IDX 29
> +#endif
> +
> /* Features supported by this bui
From: Junjie Chen
The driver can suppress interrupt when VIRTIO_F_EVENT_IDX feature bit is
negotiated. The driver set vring flags to 0, and MAY use used_event in
available ring to advise device interrupt util reach an index specified
by used_event. The device ignore the lower bit of vring flags,
From: Junjie Chen
The driver can suppress interrupt when VIRTIO_F_EVENT_IDX feature bit is
negotiated. The driver set vring flags to 0, and MAY use used_event in
available ring to advise device interrupt util reach an index specified
by used_event. The device ignore the lower bit of vring flags,
From: Junjie Chen
This patch add a restriction to multi-process support: secondary
processes should only run alongside primary process with same DPDK
version, so that secondary processes can use the same hugepage mmap
layout as primary process.
Signed-off-by: Junjie Chen
---
doc/guides/prog_gu
On Tue, 28 Nov 2017 02:22:57 +
"Wu, Xiaoban" wrote:
> Dear All,
>
>
> I am studying the source code of the l3fwd example. I am confused about a
> possible race condition in the l3fwd_lpm_simple_forward().
>
>
> In this function it calls send_single_packet(), which executes the following
Dear Stephen,
Yes, you are right. Thanks very much for your help, very appreciated. It is
much more clear to me now.
extern struct lcore_conf lcore_conf[RTE_MAX_LCORE];
Best wishes,
Xiaoban
From: Stephen Hemminger
Sent: Monday, November 27, 2017 11:06:13 P
In virtio, Generic Segmentation Offload (GSO) is the feature for the
backend, which means the backend can receive packets with any GSO
type.
Virtio-net enables the GSO feature by default, and vhost-net supports it.
To make live migration from vhost-net to vhost-user possible, this patch
enables GS
69 matches
Mail list logo
