+1 with Thomas, see below,
Le 12/10/2017 à 08:51, Tomasz Duszynski a écrit :
What is MUSDK_DMA_MEMSIZE?
If the value cannot change, it must be a constant in the code.
If it can change, it should be a run-time driver option.
It's up to the user what MUSDK_DMA_MEMSIZE is going to be. Currently it
12/10/2017 08:28, Tomasz Duszynski:
> On Thu, Oct 12, 2017 at 04:37:45AM +0200, Thomas Monjalon wrote:
> > Show how to compile MUSDK and enable compilation of the mrvl PMD.
> >
> > The build test tool is also updated to support this new PMD.
> >
> > Signed-off-by: Thomas Monjalon
> > ---
> > devt
> -Original Message-
> From: stable [mailto:stable-boun...@dpdk.org] On Behalf Of Tomasz
> Duszynski
> Sent: Wednesday, October 11, 2017 12:05 PM
> To: dev@dpdk.org
> Cc: Tomasz Duszynski ; sta...@dpdk.org
> Subject: [dpdk-stable] [PATCH v2] crypto: use snprintf return value correctly
>
Hi all,
Here is a new version of the PCI bus move out of the EAL.
The EAL PCI implementation is divided in two parts:
- librte_pci: library offering helpers to handle PCI objects
- librte_bus_pci: bus driver for PCI devices
This allows other libraries / tools to use PCI elements (location,
This header is included through rte_pci.h, which will be removed once
the PCI bus is moved out of the EAL.
Signed-off-by: Gaetan Rivet
---
lib/librte_eal/common/eal_common_bus.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/lib/librte_eal/common/eal_common_bus.c
b/lib/librte_eal/common/ea
Signed-off-by: Gaetan Rivet
---
lib/librte_ether/rte_ethdev.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c
index 9460161..bb08204 100644
--- a/lib/librte_ether/rte_ethdev.c
+++ b/lib/librte_ether/rte_ethdev.c
@@ -47,7 +47,6 @@
#
Devices and drivers are now defined within the bus-specific PCI header.
Update the libraries, as structuraly unsound as it may be.
Signed-off-by: Gaetan Rivet
---
lib/librte_ether/rte_ethdev_pci.h | 1 +
lib/librte_eventdev/rte_eventdev_pmd_pci.h | 1 +
2 files changed, 2 insertions(+)
Devices and drivers are now defined within the bus-specific PCI header.
Update drivers.
Signed-off-by: Gaetan Rivet
---
drivers/bus/pci/bsd/pci.c | 1 +
drivers/bus/pci/linux/pci.c| 1 +
drivers/bus/pci/linux/pci_uio.c| 1 +
drivers/bus/pci/linux/pci_
Devices and drivers are now defined within the bus-specific PCI header.
Update test applications.
Signed-off-by: Gaetan Rivet
---
test/test/test_kni.c| 1 +
test/test/virtual_pmd.c | 1 +
2 files changed, 2 insertions(+)
diff --git a/test/test/test_kni.c b/test/test/test_kni.c
index 2450c9f
Parsing operations should not happen in performance critical sections.
Headers should not propose implementations unless duly required.
Signed-off-by: Gaetan Rivet
---
lib/librte_pci/include/rte_pci.h | 69 --
lib/librte_pci/rte_pci.c | 65
Signed-off-by: Gaetan Rivet
---
drivers/net/bonding/rte_eth_bond_args.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/bonding/rte_eth_bond_args.c
b/drivers/net/bonding/rte_eth_bond_args.c
index dea0265..e816da3 100644
--- a/drivers/net/bonding/rte_eth_bond_a
Devices and drivers are now defined within the bus-specific PCI header.
Update applications.
Signed-off-by: Gaetan Rivet
---
app/test-pmd/testpmd.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/app/test-pmd/testpmd.h b/app/test-pmd/testpmd.h
index 0b8e624..b05c8a0 100644
--- a/app/test-pmd
Those helpers rely on the PCI bus driver implementation.
Other similar libraries relied on the bus-specifics being handled in
inlined functions, to be compiled on demand by drivers, once the proper
PCI dependency has been settled. This seems unsafe.
Move the PCI-specific helpers out of the lib dir
Rename misnamed functions and describe the change in a deprecation
notice.
Signed-off-by: Gaetan Rivet
---
doc/guides/rel_notes/deprecation.rst | 10 ++
lib/librte_pci/include/rte_pci.h | 63
lib/librte_pci/rte_pci.c | 26 +++
A new single function that is able to parse all currently supported
format:
* Domain-Bus-Device-Function
*Bus-Device-Function
Signed-off-by: Gaetan Rivet
---
lib/librte_pci/include/rte_pci.h | 15 +++
lib/librte_pci/rte_pci.c | 10 ++
lib/librte_pci
Do not expose the minute implementations of PCI parsing.
This leaves only the all-purpose pci_addr_parse, which is simpler to
use.
Signed-off-by: Gaetan Rivet
---
lib/librte_pci/include/rte_pci.h | 29 -
lib/librte_pci/rte_pci.c | 28 ++
Signed-off-by: Gaetan Rivet
---
drivers/bus/pci/pci_common.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/bus/pci/pci_common.c b/drivers/bus/pci/pci_common.c
index cd95d1a..d7a1c05 100644
--- a/drivers/bus/pci/pci_common.c
+++ b/drivers/bus/pci/pci_common.c
@@ -43
Using a macro helps writing the code to the detriment of the reader in
this case. This is backward. Write once, read many.
The few LOCs gained is not worth the opacity of the implementation.
Signed-off-by: Gaetan Rivet
---
lib/librte_pci/rte_pci.c | 65 ++
Probing policy was introduced in the previous release as a configuration item.
It was thus added to the generic bus structure, breaking its ABI.
In this release, the IOVA mode can be read from a bus to configure the
EAL. This new configuration element also broke the bus ABI when it was
added.
As
Add a section related to EAL API changes to 17.11 release notes.
Signed-off-by: Gaetan Rivet
Acked-by: John McNamara
---
doc/guides/rel_notes/release_17_11.rst | 28
1 file changed, 28 insertions(+)
diff --git a/doc/guides/rel_notes/release_17_11.rst
b/doc/guides/
New configuration elements are added to the buses. They make the ABI
unstable and will continue to do so.
This new control scheme allows to add new bus operators without
breaking the ABI and by only expanding the API.
This helps having more stability in core EAL subsystems, while allowing
flexibi
This bus configuration item is misnamed, as it actually refers to the
probing process.
Signed-off-by: Gaetan Rivet
---
drivers/bus/pci/pci_common.c | 2 +-
lib/librte_eal/common/eal_common_devargs.c | 6 +++---
lib/librte_eal/common/include/rte_bus.h| 12 ++--
3 files
This configuration item will be implemented within the new flexible
framework.
Signed-off-by: Gaetan Rivet
---
drivers/bus/pci/pci_common.c | 5 +
lib/librte_eal/common/eal_common_devargs.c | 8
lib/librte_eal/common/include/rte_bus.h| 8
3 files changed,
Introduce new rte_bus operation to configure the probe policy.
Implementation is required from buses interested in supporting
this configuration element.
Signed-off-by: Gaetan Rivet
---
lib/librte_eal/common/eal_common_bus.c | 24
lib/librte_eal/common/eal_common_op
Add the PCI bus control operator.
This operator gives access to the probe policy setting, allowing to
read and write this configuration item. The previous existing
functionality is thus restored to the same level.
Probe policy is blacklist mode by default for the PCI bus. Configuration
is allowed
Leverage the new bus control framework for the IOVA mode
configuration item.
The previous version is left for the transition in drivers
implementation and will be removed afterward.
Signed-off-by: Gaetan Rivet
---
lib/librte_eal/bsdapp/eal/rte_eal_version.map | 1 -
lib/librte_eal/common/eal
Implement the ctrl operator for the IOVA mode configuration item.
The previous functionality is kept identical, only the new control
framework is used.
All operators are made private as there is no reason to expose them.
Signed-off-by: Gaetan Rivet
---
drivers/bus/pci/bsd/pci.c | 9
Legacy device options (-b, -w, --vdev) need to prepend their bus name to
user parameters for backward compatibility.
Signed-off-by: Gaetan Rivet
---
lib/librte_eal/common/eal_common_options.c | 17 -
1 file changed, 12 insertions(+), 5 deletions(-)
diff --git a/lib/librte_eal/co
This configuration element is now accessible through the bus control
framework and can be removed from the generic bus structure.
Signed-off-by: Gaetan Rivet
---
lib/librte_eal/common/include/rte_bus.h | 33 +
1 file changed, 9 insertions(+), 24 deletions(-)
diff
The use of rte_devargs is inconsistent in the light of new functionalities
such as device hotplug.
Most of its API is still experimental and needs stabilization.
Older functions were deprecated and need to be rewritten or removed.
The rte_devtype is meant to disappear.
v2:
Big rework.
* Ena
The devtype is now entirely defined by the device bus. As such, it is
already characterized by the bus identifier within an rte_devargs.
The rte_devtype enum can disappear, along with crutches added during
this transition.
rte_eal_devargs_type_count becomes useless and is removed.
Signed-off-by:
In preparation to making devargs_list private.
Bus drivers generally need to access rte_devargs pertaining to their
operations. This match is a common operation for bus drivers.
Add a new accessor for the rte_devargs list.
Signed-off-by: Gaetan Rivet
---
lib/librte_eal/bsdapp/eal/rte_eal_versi
This list should not be operated upon by drivers.
Use the public API to achieve the same functionalities.
Signed-off-by: Gaetan Rivet
---
lib/librte_eal/common/eal_common_vdev.c | 11 +++
1 file changed, 3 insertions(+), 8 deletions(-)
diff --git a/lib/librte_eal/common/eal_common_vdev.
Introduce new rte_devargs accessor allowing to iterate over all
rte_devargs pertaining to a bus.
Signed-off-by: Gaetan Rivet
---
lib/librte_eal/common/include/rte_devargs.h | 8
1 file changed, 8 insertions(+)
diff --git a/lib/librte_eal/common/include/rte_devargs.h
b/lib/librte_eal/c
The current test will not be compatible anymore with a private
devargs list.
Moreover, the new functions should have new tests, while the existing
API will be removed.
The current unit tests are thus obsolete and hereby removed.
Signed-off-by: Gaetan Rivet
---
MAINTAINERS | 1 -
This list should not be used by drivers.
Use the public API instead.
Signed-off-by: Gaetan Rivet
---
drivers/bus/pci/pci_common.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/bus/pci/pci_common.c b/drivers/bus/pci/pci_common.c
index 5fbcf11..0b64d20 100644
---
rte_eal_devargs_parse can be used by EAL subsystems, drivers,
applications alike.
Device parameters may be presented with different structure each time;
as a single declaration string or several strings each describing
different parts of the declaration.
To simplify the use of this parsing facili
Initially, rte_devargs was meant to be populated once and sometimes
accessed, then never emptied.
With the new hotplug functionality having better standing, new usage
appeared with repeated addition of devices and their subsequent removal.
Exposing devargs_list pushed bus drivers and libraries to
The EAL now requires the bus to be prepended to the device declaration
string.
Signed-off-by: Gaetan Rivet
---
lib/librte_eal/common/eal_common_devargs.c | 28 +---
1 file changed, 9 insertions(+), 19 deletions(-)
diff --git a/lib/librte_eal/common/eal_common_devargs.c
Re-use existing code, remove incorrect comments.
Signed-off-by: Gaetan Rivet
---
lib/librte_eal/common/eal_common_devargs.c | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/lib/librte_eal/common/eal_common_devargs.c
b/lib/librte_eal/common/eal_common_devargs.c
index 4
As other EAL facilities now requires the bus to be explicitly mentioned,
the function rte_bus_find_by_device_name can be used by third parties to
ease the transition to a more formal device definition scheme.
Signed-off-by: Gaetan Rivet
---
lib/librte_eal/bsdapp/eal/rte_eal_version.map | 1 +
Add a new generic device declaration parameter:
--dev=
That allows to declare device from any bus. The format is as follows:
device_declaration := [,arg_list]
bus := bus name
c:= arbitrary character separator
device := device name (PCI location, virtual PMD name, ...)
arg_list
Allow users to use the same sub-device declaration format.
The rte_devargs library now requires the bus name to be prepended to
device declarations. While it is possible to use this new format, the
transition to the new one can be made smoother.
Signed-off-by: Gaetan Rivet
---
drivers/net/fails
rte_eal_devargs is redundant.
Make it concise.
Signed-off-by: Gaetan Rivet
---
app/test-pmd/cmdline.c | 2 +-
drivers/net/failsafe/failsafe_args.c| 4 ++--
examples/bond/main.c| 2 +-
lib/librte_eal/bsdapp/eal/rte_eal_version.ma
This functionality is already covered by rte_eal_devargs_parse.
Signed-off-by: Gaetan Rivet
---
lib/librte_eal/bsdapp/eal/rte_eal_version.map | 1 -
lib/librte_eal/common/eal_common_devargs.c | 30 -
lib/librte_eal/common/include/rte_devargs.h | 28 ---
The previous one is being deprecated.
Signed-off-by: Gaetan Rivet
---
lib/librte_ether/rte_ethdev.c | 11 +++
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c
index bb08204..618f576 100644
--- a/lib/librte_ether/r
> -Original Message-
> From: Thomas Monjalon [mailto:tho...@monjalon.net]
> Sent: Thursday, October 12, 2017 12:18 AM
> To: Singh, Jasvinder ; Dumitrescu, Cristian
>
> Cc: dev@dpdk.org; Yigit, Ferruh ; Lu, Wenzhuo
>
> Subject: Re: [dpdk-dev] [PATCH v8 1/5] net/softnic: add softnic PMD
>
These actions have been enacted.
Signed-off-by: Gaetan Rivet
---
doc/guides/rel_notes/deprecation.rst | 13 -
1 file changed, 13 deletions(-)
diff --git a/doc/guides/rel_notes/deprecation.rst
b/doc/guides/rel_notes/deprecation.rst
index ef2264f..23faa19 100644
--- a/doc/guides/rel_
On Tue, Sep 12, 2017 at 08:36:04PM +0530, Pavan Nikhilesh wrote:
> The reorder drain test fails due to mempool corruption caused by freeing
> packet buffer twice.
>
> Fixes: d0c9b58d7156 ("app/test: new reorder unit test")
>
> Signed-off-by: Pavan Nikhilesh
> ---
> test/test/test_reorder.c | 33
On Tue, Sep 12, 2017 at 08:36:03PM +0530, Pavan Nikhilesh wrote:
> The ready buffers should be set to NULL when drained else it might
> result in double free (mempool put) when rte_reorder_free is called.
>
> Fixes: b70b56032bff ("reorder: new library")
>
> Signed-off-by: Pavan Nikhilesh ---
> l
v6:
- Don't introduce the static log type for bug, instead we use dynamic
log type for vdev, suggested by Shreyansh Jain.
v4 & v5:
- Fix issues of compiling shared library.
- Remove extra symbols in drivers/bus/vdev/rte_bus_vdev_version.map.
- Address checkpatch warnings.
This patch s
Remove rte_cryptodev_create_vdev() for duplication.
Signed-off-by: Jianfeng Tan
Acked-by: Pablo de Lara
---
doc/guides/rel_notes/deprecation.rst | 5 -
lib/librte_cryptodev/rte_cryptodev.c | 6 --
lib/librte_cryptodev/rte_cryptodev.h | 17
Move the vdev bus from lib/librte_eal to drivers/bus.
As the crypto vdev helper function refers to data structure
in rte_vdev.h, so we move those helper function into drivers/bus
too.
Signed-off-by: Jianfeng Tan
---
config/common_base| 5 +
drivers/bus/Makefile
Use specialized dynamic log type for vdev bus logging.
Suggested-by: Gaetan Rivet
Suggested-by: Shreyansh Jain
Signed-off-by: Jianfeng Tan
---
drivers/bus/vdev/vdev.c | 20
drivers/bus/vdev/vdev_logs.h | 45
2 files changed
We can call bus->plug() to avoid calling rte_vdev_init() explicitly.
Signed-off-by: Jianfeng Tan
---
lib/librte_eal/common/eal_common_dev.c | 22 ++
1 file changed, 6 insertions(+), 16 deletions(-)
diff --git a/lib/librte_eal/common/eal_common_dev.c
b/lib/librte_eal/common/
On Wed, Oct 11, 2017 at 09:25:58PM +0200, Thomas Monjalon wrote:
> 11/10/2017 20:57, Jerin Jacob:
> > From: Thomas Monjalon
> > > 22/09/2017 10:25, Gowrishankar:
> > > > From: Jerin Jacob
> > > >
> > > > When calibrating the tsc frequency, first, probe the architecture
> > > > specific
> > > >
Remove unused MRVL_DEBUG configuration option and update driver
documentation accordingly.
Signed-off-by: Tomasz Duszynski
---
config/common_base | 1 -
doc/guides/nics/mrvl.rst | 4
2 files changed, 5 deletions(-)
diff --git a/config/common_base b/config/common_base
index dc4da9a..d
Now ethdev port_id has been increased to uint16_t from uint8_t in the below
patch
http://www.dpdk.org/dev/patchwork/patch/29418/
but
1. Some features which are applied were still developed based on older version
uint8_t port_id.
2. Some places using port id such as testpmd are omitted in previous
Some features applied were still developed based on older version uint8_t
port_id, but port_id has been increased range to uint16_t. The patch fixes
the issue.
Fixes: f8244c6399d9 ("ethdev: increase port id range")
Signed-off-by: Zhiyong Yang
---
lib/librte_ether/ethdev_profile.c | 6 +++---
li
Fixes: f8244c6399d9 ("ethdev: increase port id range")
Signed-off-by: Zhiyong Yang
---
drivers/net/bnxt/bnxt_hwrm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c
index c9b04e248..0e96d3c4d 100644
--- a/drivers/net/
port_id in struct lio_device should be increased range to uint16_t since
port id in rte_eth_dev_data has already been defined as uint16_t.
Fixes: f8244c6399d9 ("ethdev: increase port id range")
Signed-off-by: Zhiyong Yang
---
drivers/net/liquidio/lio_struct.h | 2 +-
1 file changed, 1 insertion
Fixes: f8244c6399d9 ("ethdev: increase port id range")
Signed-off-by: Zhiyong Yang
---
app/proc_info/main.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/app/proc_info/main.c b/app/proc_info/main.c
index 12566e27d..64fbbd0f8 100644
--- a/app/proc_info/main.c
Increase port id range to 16 bits and remove the unnecessary cast.
Fixes: f8244c6399d9 ("ethdev: increase port id range")
Signed-off-by: Zhiyong Yang
---
app/pdump/main.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/app/pdump/main.c b/app/pdump/main.c
index 090a50cfc.
Fixes: f8244c6399d9 ("ethdev: increase port id range")
Signed-off-by: Zhiyong Yang
---
app/test-pmd/cmdline.c | 427 +
app/test-pmd/config.c | 14 +-
app/test-pmd/testpmd.c | 13 +-
app/test-pmd/testpmd.h | 16 +-
4 files changed, 236 insertion
12/10/2017 10:46, Jianfeng Tan:
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> -* cryptodev: the following function is deprecated starting from 17.08 and
> will
> - be removed in 17.11:
> -
> - - ``rte_cryptodev_create_vdev``
You need to add a note i
12/10/2017 10:48, Bruce Richardson:
> On Wed, Oct 11, 2017 at 09:25:58PM +0200, Thomas Monjalon wrote:
> > 11/10/2017 20:57, Jerin Jacob:
> > > From: Thomas Monjalon
> > > > 22/09/2017 10:25, Gowrishankar:
> > > > > From: Jerin Jacob
> > > > >
> > > > > When calibrating the tsc frequency, first,
> -Original Message-
> From: Chilikin, Andrey
> Sent: Saturday, October 7, 2017 2:11 AM
> To: dev@dpdk.org
> Cc: Xing, Beilei ; Wu, Jingjing
> ; Chilikin, Andrey
> Subject: [PATCH] net/i40e: fix flexible payload configuration
>
> Removed legacy writes to ORT/PIT registers from i40e_GLQF_
-Original Message-
> Date: Wed, 11 Oct 2017 21:25:58 +0200
> From: Thomas Monjalon
> To: Jerin Jacob
> Cc: Gowrishankar , dev@dpdk.org, Chao
> Zhu , Bruce Richardson
> , Konstantin Ananyev
> , vikto...@rehivetech.com,
> jianbo@linaro.org
> Subject: Re: [dpdk-dev] [PATCH v2 5/5] ea
On Thu, Oct 12, 2017 at 12:12:48PM +0200, Thomas Monjalon wrote:
> 12/10/2017 10:48, Bruce Richardson:
> > On Wed, Oct 11, 2017 at 09:25:58PM +0200, Thomas Monjalon wrote:
> > > 11/10/2017 20:57, Jerin Jacob:
> > > > From: Thomas Monjalon
> > > > > 22/09/2017 10:25, Gowrishankar:
> > > > > > From:
> -Original Message-
> From: Hemant Agrawal [mailto:hemant.agra...@nxp.com]
> Sent: Wednesday, September 6, 2017 10:34 AM
> To: dev@dpdk.org
> Cc: Ananyev, Konstantin ; ashish.j...@nxp.com
> Subject: [PATCH] examples/ip_reassembly: use pktmbuf to create pool
>
> From: Ashish Jain
>
> U
Hi all,
Here is a new version of the PCI bus move out of the EAL.
The EAL PCI implementation is divided in two parts:
- librte_pci: library offering helpers to handle PCI objects
- librte_bus_pci: bus driver for PCI devices
This allows other libraries / tools to use PCI elements (location,
Signed-off-by: Gaetan Rivet
---
lib/librte_ether/rte_ethdev.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c
index 9460161..bb08204 100644
--- a/lib/librte_ether/rte_ethdev.c
+++ b/lib/librte_ether/rte_ethdev.c
@@ -47,7 +47,6 @@
#
Devices and drivers are now defined within the bus-specific PCI header.
Update drivers.
Signed-off-by: Gaetan Rivet
---
drivers/bus/pci/bsd/pci.c | 1 +
drivers/bus/pci/linux/pci.c| 1 +
drivers/bus/pci/linux/pci_uio.c| 1 +
drivers/bus/pci/linux/pci_
This header is included through rte_pci.h, which will be removed once
the PCI bus is moved out of the EAL.
Signed-off-by: Gaetan Rivet
---
lib/librte_eal/common/eal_common_bus.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/lib/librte_eal/common/eal_common_bus.c
b/lib/librte_eal/common/ea
Devices and drivers are now defined within the bus-specific PCI header.
Update the libraries, as structuraly unsound as it may be.
Signed-off-by: Gaetan Rivet
---
lib/librte_ether/rte_ethdev_pci.h | 1 +
lib/librte_eventdev/rte_eventdev_pmd_pci.h | 1 +
2 files changed, 2 insertions(+)
Signed-off-by: Gaetan Rivet
---
drivers/net/bonding/rte_eth_bond_args.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/bonding/rte_eth_bond_args.c
b/drivers/net/bonding/rte_eth_bond_args.c
index dea0265..e816da3 100644
--- a/drivers/net/bonding/rte_eth_bond_a
Devices and drivers are now defined within the bus-specific PCI header.
Update test applications.
Signed-off-by: Gaetan Rivet
---
test/test/test_kni.c| 1 +
test/test/virtual_pmd.c | 1 +
2 files changed, 2 insertions(+)
diff --git a/test/test/test_kni.c b/test/test/test_kni.c
index 2450c9f
Devices and drivers are now defined within the bus-specific PCI header.
Update applications.
Signed-off-by: Gaetan Rivet
---
app/test-pmd/testpmd.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/app/test-pmd/testpmd.h b/app/test-pmd/testpmd.h
index 0b8e624..b05c8a0 100644
--- a/app/test-pmd
Those helpers rely on the PCI bus driver implementation.
Other similar libraries relied on the bus-specifics being handled in
inlined functions, to be compiled on demand by drivers, once the proper
PCI dependency has been settled. This seems unsafe.
Move the PCI-specific helpers out of the lib dir
Parsing operations should not happen in performance critical sections.
Headers should not propose implementations unless duly required.
Signed-off-by: Gaetan Rivet
---
lib/librte_pci/include/rte_pci.h | 69 --
lib/librte_pci/rte_pci.c | 65
Signed-off-by: Gaetan Rivet
---
drivers/bus/pci/pci_common.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/bus/pci/pci_common.c b/drivers/bus/pci/pci_common.c
index cd95d1a..d7a1c05 100644
--- a/drivers/bus/pci/pci_common.c
+++ b/drivers/bus/pci/pci_common.c
@@ -43
Using a macro helps writing the code to the detriment of the reader in
this case. This is backward. Write once, read many.
The few LOCs gained is not worth the opacity of the implementation.
Signed-off-by: Gaetan Rivet
---
lib/librte_pci/rte_pci.c | 65 ++
Do not expose the minute implementations of PCI parsing.
This leaves only the all-purpose pci_addr_parse, which is simpler to
use.
Signed-off-by: Gaetan Rivet
---
lib/librte_pci/include/rte_pci.h | 29 -
lib/librte_pci/rte_pci.c | 28 ++
A new single function that is able to parse all currently supported
format:
* Domain-Bus-Device-Function
*Bus-Device-Function
Signed-off-by: Gaetan Rivet
---
lib/librte_pci/include/rte_pci.h | 15 +++
lib/librte_pci/rte_pci.c | 10 ++
lib/librte_pci
Rename misnamed functions and describe the change in a deprecation
notice.
Signed-off-by: Gaetan Rivet
---
doc/guides/rel_notes/deprecation.rst | 10 ++
lib/librte_pci/include/rte_pci.h | 63
lib/librte_pci/rte_pci.c | 26 +++
Add a section related to EAL API changes to 17.11 release notes.
Signed-off-by: Gaetan Rivet
Acked-by: John McNamara
---
doc/guides/rel_notes/release_17_11.rst | 28
1 file changed, 28 insertions(+)
diff --git a/doc/guides/rel_notes/release_17_11.rst
b/doc/guides/
Signed-off-by: Gaetan Rivet
---
drivers/bus/pci/private.h | 10 ++
lib/librte_eal/bsdapp/eal/rte_eal_version.map | 1 -
lib/librte_eal/linuxapp/eal/rte_eal_version.map | 1 -
3 files changed, 10 insertions(+), 2 deletions(-)
diff --git a/drivers/bus/pci/private.
This bus configuration item is misnamed, as it actually refers to the
probing process.
Signed-off-by: Gaetan Rivet
---
drivers/bus/pci/pci_common.c | 2 +-
lib/librte_eal/common/eal_common_devargs.c | 6 +++---
lib/librte_eal/common/include/rte_bus.h| 12 ++--
3 files
This function is private to the PCI bus.
Signed-off-by: Gaetan Rivet
---
drivers/bus/pci/include/rte_bus_pci.h | 16
drivers/bus/pci/private.h | 15 +++
lib/librte_eal/bsdapp/eal/rte_eal_version.map | 1 -
lib/librte_eal/linuxapp/ea
make the functions
+ rte_pci_detach
+ rte_pci_probe
+ rte_pci_probe_one
+ rte_pci_scan
private as there is no point in using them outside of the rte_bus
framework.
Signed-off-by: Gaetan Rivet
---
drivers/bus/pci/include/rte_bus_pci.h | 49 -
driver
On 10/6/2017 8:15 PM, Cristian Dumitrescu wrote:
Overall the patch looks ok. Few small comments.
diff --git a/lib/librte_ether/rte_mtr.h b/lib/librte_ether/rte_mtr.h
new file mode 100644
index 000..f0f897f
--- /dev/null
+++ b/lib/librte_ether/rte_mtr.h
@@ -0,0 +1,723 @@
+/*-
+ * BSD LICEN
Hi,
This commit renders igb_uio unusable on Fedora 20, kernel version
3.19.8-100.fc20.x86_64.
During the build (make -j 20), a warning is issued for igb_uio regarding a
missing symbol (pci_msi_unmask):
WARNING: "pci_msi_unmask_irq"
[/home//x86_64-native-linuxapp-gcc/build/lib/librte_ea
On 10/12/2017 4:18 PM, Hemant Agrawal wrote:
On 10/6/2017 8:15 PM, Cristian Dumitrescu wrote:
Overall the patch looks ok. Few small comments.
diff --git a/lib/librte_ether/rte_mtr.h b/lib/librte_ether/rte_mtr.h
new file mode 100644
index 000..f0f897f
--- /dev/null
+++ b/lib/librte_ether/rt
On Thu, Oct 12, 2017 at 12:45:45PM +0200, Gaetan Rivet wrote:
> Signed-off-by: Gaetan Rivet
> ---
> drivers/bus/pci/private.h | 10 ++
> lib/librte_eal/bsdapp/eal/rte_eal_version.map | 1 -
> lib/librte_eal/linuxapp/eal/rte_eal_version.map | 1 -
> 3 files change
This patch is not part of this series, sorry.
I can send a v6 if necessary, but here simply ignore this patch.
On Thu, Oct 12, 2017 at 12:45:47PM +0200, Gaetan Rivet wrote:
> This bus configuration item is misnamed, as it actually refers to the
> probing process.
>
> Signed-off-by: Gaetan Rivet
> -Original Message-
> From: Kovacevic, Marko
> Sent: Wednesday, October 11, 2017 4:51 PM
> To: Mcnamara, John
> Cc: dev@dpdk.org; Kovacevic, Marko ; Herakliusz
> Lipiec
> Subject: [PATCH v6 1/2] doc: add generic compilation doc for all sample
> apps
>
> From: Herakliusz Lipiec
>
> M
> -Original Message-
> From: Kovacevic, Marko
> Sent: Wednesday, October 11, 2017 4:51 PM
> To: Mcnamara, John
> Cc: dev@dpdk.org; Kovacevic, Marko
> Subject: [PATCH v6 2/2] doc: add new introduction to sample app guides
>
> Add new Introduction Section into the sample app guides.
>
>
On 10/6/2017 8:15 PM, Cristian Dumitrescu wrote:
Following similar approach as rte_flow and rte_tm for modularity reasons,
the ops for the new rte_mtr API are retrieved through a new eth_dev_ops
function.
Signed-off-by: Cristian Dumitrescu
---
Changes in v3:
- None
Changes in v2:
-None
Change
On 10/12/2017 4:08 PM, Ananyev, Konstantin wrote:
-Original Message-
From: Hemant Agrawal [mailto:hemant.agra...@nxp.com]
Sent: Wednesday, September 6, 2017 10:34 AM
To: dev@dpdk.org
Cc: Ananyev, Konstantin ; ashish.j...@nxp.com
Subject: [PATCH] examples/ip_reassembly: use pktmbuf to c
For event dequeues for ethernet queues, a dpaa2_queue structure is
required to get the configuration for that ethernet queue. Based on
this configuration the rte_event is to be filled at the ingress side.
Signed-off-by: Nipun Gupta
---
drivers/bus/fslmc/portal/dpaa2_hw_pvt.h | 4
drivers/ev
1 - 100 of 285 matches
Mail list logo
