Re: [dpdk-dev] [PATCH v3] ixgbe: eliminate duplicate filterlist symbols

2017-09-18 Thread Ferruh Yigit
On 9/18/2017 2:13 PM, Radu Nicolau wrote: > > On 9/14/2017 2:38 PM, Ferruh Yigit wrote: >> On 9/14/2017 1:50 PM, David C Harton wrote: >>> From: David Harton >>> >>> Some compilers generate warnings for duplicate symbols for the >>> set of filter lists current defined in ixgbe_ethdev.h. >>> This

Re: [dpdk-dev] [PATCH] test: fix wrong assignment operation

2017-09-18 Thread Ferruh Yigit
On 9/15/2017 3:35 AM, Zhiyong Yang wrote: > It should be an comparation operation rather than an assignment > operation. > > Fixes: 5e41ab250dfa("app/test: unit tests for bonding mode 4") > > Signed-off-by: Zhiyong Yang Reviewed-by: Ferruh Yigit

Re: [dpdk-dev] [PATCH] test: fix wrong assignment operation

2017-09-18 Thread Ferruh Yigit
On 9/18/2017 8:25 PM, Ferruh Yigit wrote: > On 9/15/2017 3:35 AM, Zhiyong Yang wrote: >> It should be an comparation operation rather than an assignment >> operation. >> >> Fixes: 5e41ab250dfa("app/test: unit tests for bonding mode 4") >> >> Signed-off-by: Zhiyong Yang > > Reviewed-by: Ferruh Yig

Re: [dpdk-dev] vf init issue with patch igb_uio: issue FLR during open and release of device file

2017-09-18 Thread Ferruh Yigit
On 9/18/2017 7:49 AM, Shijith Thotton wrote: > On Mon, Sep 18, 2017 at 03:50:30AM +, Yang, Qiming wrote: >> Sorry, Gregory and Shijith >> >> I misunderstand your advice. >> If we only remove PCI reset at igbuio_pci_open, not include >> igbuio_pci_release, I think it is a good solution. >> It r

Re: [dpdk-dev] [dpdk-stable] [PATCH v3] net/tap: fix flow and port commands

2017-09-18 Thread Ferruh Yigit
On 9/18/2017 8:46 AM, Pascal Mazon wrote: > > On 17/09/2017 00:32, Ophir Munk wrote: >> This commit fixes two bugs related to tap devices. The first bug occurs >> when executing in testpmd the following flow rule assuming tap device has >> 4 rx and tx pair queues >> "flow create 0 ingress pattern

[dpdk-dev] [PATCH] hash: document rte_jhash() boundary behavior

2017-09-18 Thread Chas Williams
From: Chas Williams Due to the uint32_t accesses in the hash computation, keys that aren't aligned to a uint32_t boundary or multiples of uint32_t in length, may see accesses beyond the end of the key. This may cross a page boundary. Signed-off-by: Chas Williams --- lib/librte_hash/rte_jhash.

Re: [dpdk-dev] [PATCH v3 03/27] bus/fslmc: add qbman API to do enqueue with multiple frames

2017-09-18 Thread Ferruh Yigit
On 9/16/2017 11:52 AM, Hemant Agrawal wrote: > From: Haiying Wang > > Clean it up and update the prototype. > > Signed-off-by: Haiying Wang > Signed-off-by: Hemant Agrawal > --- > drivers/bus/fslmc/qbman/include/fsl_qbman_portal.h | 32 ++-- > drivers/bus/fslmc/qbman/qbman_portal.c

Re: [dpdk-dev] [PATCH v3 06/27] bus/fslmc: qbman remove unused funcs and align names

2017-09-18 Thread Ferruh Yigit
On 9/16/2017 11:52 AM, Hemant Agrawal wrote: > name alignment for check command and result functions > putting them as separate functions instead of changing the original > functions. > > Signed-off-by: Hemant Agrawal > --- > drivers/bus/fslmc/qbman/include/fsl_qbman_portal.h | 146 ++-- > drive

Re: [dpdk-dev] [PATCH v3 00/27] NXP DPAA2 PMD updates

2017-09-18 Thread Ferruh Yigit
On 9/16/2017 11:52 AM, Hemant Agrawal wrote: > This patchset includes the hw driver upgrades and additional > nic feature implementations. > > patches 1..8 - upgrades the qbman hw driver > patches 9..10 - adds the support for LX2160 platform > patches 11..27 - adds various features and cleanups in

Re: [dpdk-dev] [PATCH v2] SDK: Add scripts to initialize DPDK runtime

2017-09-18 Thread Ferruh Yigit
On 12/13/2016 4:47 PM, lboccass at brocade.com (Luca Boccassi) wrote: > From: Christian Ehrhardt > > A tools/init directory is added with dpdk-init, a script that can be > used to initialize a DPDK runtime environment. 2 config files with > default options, dpdk.conf and interfaces, are provided

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/mlx5: fix TSO segment size verification

2017-09-18 Thread Ferruh Yigit
On 9/18/2017 12:41 PM, Nélio Laranjeiro wrote: > On Sun, Sep 17, 2017 at 11:12:49AM +0300, Shahaf Shuler wrote: >> TSO segment size must be larger then 0. >> >> Fixes: 3f13f8c23a7c ("net/mlx5: support hardware TSO") >> Cc: sta...@dpdk.org >> >> Signed-off-by: Shahaf Shuler >> Acked-by: Yongseok Ko

Re: [dpdk-dev] [PATCH 4/4] ethdev: add helpers to move to the new offloads API

2017-09-18 Thread Thomas Monjalon
18/09/2017 20:18, Shahaf Shuler: > Monday, September 18, 2017 5:45 PM, Bruce Richardson: > > > > On Mon, Sep 18, 2017 at 02:27:25PM +, Shahaf Shuler wrote: > > > Monday, September 18, 2017 2:38 PM, Bruce Richardson > > > > On Mon, Sep 18, 2017 at 01:32:29PM +0200, Thomas Monjalon wrote: > > >

Re: [dpdk-dev] [PATCH] net/enic: fix multi-process operation

2017-09-18 Thread Ferruh Yigit
On 9/11/2017 7:58 PM, John Daley wrote: > - Use rte_malloc() instead of malloc() for the per device 'vdev' structure > so that it can be shared across processes. > - Only initialize the device if the process type is RTE_PROC_PRIMARY > - Only allow the primary process to do queue setup, start/stop

Re: [dpdk-dev] [PATCH v2] sched: make RED scaling configurable

2017-09-18 Thread Kantecki, Tomasz
> -Original Message- > From: alangordonde...@gmail.com [mailto:alangordonde...@gmail.com] > Sent: Wednesday, September 13, 2017 11:16 AM > To: Kantecki, Tomasz > Cc: dev@dpdk.org; Alan Dewar > Subject: [PATCH v2] sched: make RED scaling configurable > > From: Alan Dewar > > The RED code

Re: [dpdk-dev] [PATCH] net/enic: fix multi-process operation

2017-09-18 Thread Thomas Monjalon
18/09/2017 23:27, Ferruh Yigit: > On 9/11/2017 7:58 PM, John Daley wrote: > > - Use rte_malloc() instead of malloc() for the per device 'vdev' structure > > so that it can be shared across processes. > > - Only initialize the device if the process type is RTE_PROC_PRIMARY > > - Only allow the pri

Re: [dpdk-dev] vf init issue with patch igb_uio: issue FLR during open and release of device file

2017-09-18 Thread Patil, Harish
-Original Message- From: "Thotton, Shijith" Date: Sunday, September 17, 2017 at 11:49 PM To: "Yang, Qiming" , Harish Patil Cc: "Zhang, Helin" , Gregory Etelson , "tho...@monjalon.net" , "dev@dpdk.org" , "Tan, Jianfeng" , "Thotton, Shijith" , "Hu, Xuekun" , "Yigit, Ferruh" , "Li, Xiaoyun"

[dpdk-dev] [PATCH] net/i40e/base: fix bool definition

2017-09-18 Thread Jingjing Wu
use stdbool.h instead of defining the bool type, to make sure the virtchnnl msg format definition is the same between PF and VF. Cc: sta...@dpdk.org Fixes: 4861cde46116 ("i40e: new poll mode driver") Signed-off-by: Jingjing Wu --- drivers/net/i40e/base/i40e_osdep.h | 2 +- 1 file changed, 1 ins

[dpdk-dev] [PATCH 00/53] net/qede/base: update PMD to 2.6.0.1

2017-09-18 Thread Rasesh Mody
Hi, This patch set adds support for new firmware 8.30.12.0, includes enahncements, code cleanup and bug fixes. This patch set updates PMD version to 2.6.0.1. Thanks! Rasesh Rasesh Mody (53): net/qede/base: add NVM config options net/qede/base: update management FW supported features net/qe

[dpdk-dev] [PATCH 02/53] net/qede/base: update management FW supported features

2017-09-18 Thread Rasesh Mody
- Add transceivers temperature monitoring/reporting feature - Add new mbox command DRV_MSG_CODE_FEATURE_SUPPORT to exchange info between drivers and management FW regarding features supported - Add EEE to Link Flap Avoidance check, etc. Signed-off-by: Rasesh Mody --- drivers/net/qede/base/

[dpdk-dev] [PATCH 01/53] net/qede/base: add NVM config options

2017-09-18 Thread Rasesh Mody
Add new NVM configuration options like - enabling Preboot Debug Mode, - 20G ethernet backplane support, - add RDMA to NPAR protocol list, - PHY module temperature thresholds, etc. Signed-off-by: Rasesh Mody --- drivers/net/qede/base/nvm_cfg.h | 63 --- 1

[dpdk-dev] [PATCH 03/53] net/qede/base: use crc32 OSAL macro

2017-09-18 Thread Rasesh Mody
Move ecore_crc32() macro to within base driver to qede_crc32() and use OSAL_CRC32() where required. Signed-off-by: Rasesh Mody --- drivers/net/qede/base/bcm_osal.c| 12 drivers/net/qede/base/bcm_osal.h|4 +++- drivers/net/qede/base/ecore_sriov.c | 17 ++--

[dpdk-dev] [PATCH 04/53] net/qede/base: allocate VF queues before PF

2017-09-18 Thread Rasesh Mody
Change the order by which we allocate the resources to align with management FW by first allocating the VF l2 queues and only afterwards use what's left for the PF. Signed-off-by: Rasesh Mody --- drivers/net/qede/base/ecore_dev.c | 32 ++-- 1 file changed, 18 insert

[dpdk-dev] [PATCH 05/53] net/qede/base: convert device type to enum

2017-09-18 Thread Rasesh Mody
Add a new enum for device type and device type details to device info. Signed-off-by: Rasesh Mody --- drivers/net/qede/base/ecore.h | 14 -- drivers/net/qede/base/ecore_dev.c | 16 +--- drivers/net/qede/qede_if.h|2 ++ drivers/net/qede/qede_main.c

[dpdk-dev] [PATCH 08/53] net/qede/base: add API to configure coalescing for VF queues

2017-09-18 Thread Rasesh Mody
Add API for PF to configure coalescing for VF queues. Signed-off-by: Rasesh Mody --- drivers/net/qede/base/ecore_iov_api.h | 21 drivers/net/qede/base/ecore_sriov.c | 89 + drivers/net/qede/base/ecore_sriov.h |3 ++ 3 files changed, 113 insert

[dpdk-dev] [PATCH 07/53] net/qede/base: interchangeably use SB between PF and VF

2017-09-18 Thread Rasesh Mody
Status Block reallocation - allow a PF and its child VF to change SB between them using new base driver APIs. The changes that are inside base driver flows are: New APIs ecore_int_igu_reset_cam() and ecore_int_igu_reset_cam_default() added to reset IGU CAM. a. During hw_prepare(), driver would r

[dpdk-dev] [PATCH 06/53] net/qede/base: changes for VF queue zone

2017-09-18 Thread Rasesh Mody
Allow opening Multiple Tx queues on a single qzone for VFs. This is supported by Rx/Tx TLVs now having an additional extended TLV that passes the `qid_usage_idx', a unique number per each queue-cid that was opened for a given queue-zone. Fix to overcome TX timeout issue due to more than 16 CIDs by

[dpdk-dev] [PATCH 09/53] net/qede/base: restrict cache line size register padding

2017-09-18 Thread Rasesh Mody
Add a restriction on the pad to cache line size register. Signed-off-by: Rasesh Mody --- drivers/net/qede/base/bcm_osal.h |1 + drivers/net/qede/base/ecore_dev.c | 60 + drivers/net/qede/base/reg_addr.h |3 ++ 3 files changed, 64 insertions(+) dif

[dpdk-dev] [PATCH 11/53] net/qede/base: add a sanity check

2017-09-18 Thread Rasesh Mody
Add a sanity check that the offset being used to access the runtime array is not greater/equal than/to RUNTIME_ARRAY_SIZE Signed-off-by: Rasesh Mody --- drivers/net/qede/base/ecore_init_ops.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/drivers/net/qede/base/ecore_init_

[dpdk-dev] [PATCH 12/53] net/qede/base: add SmartAN support

2017-09-18 Thread Rasesh Mody
Add SmartAN feature that automatically detects peer switch capabilities which relieves users from fumbling with adapter and switch configuration Add new cmd DRV_MSG_CODE_GET_MFW_FEATURE_SUPPORT. Add new SmartLinQ config method using NVM cfg options 239. Signed-off-by: Rasesh Mody --- drivers/net

[dpdk-dev] [PATCH 10/53] net/qede/base: fix to use a passed ptt handle

2017-09-18 Thread Rasesh Mody
Fix ecore_configure_vp_wfq_on_link_change() to use a provided ptt[PF translation table] handle instead of directly using p_dpc_ptt Fixes: ec94dbc57362 ("qede: add base driver") Cc: sta...@dpdk.org Signed-off-by: Rasesh Mody --- drivers/net/qede/base/ecore.h |1 + drivers/net/qede/base/e

[dpdk-dev] [PATCH 14/53] net/qede/base: add mdump sub-commands

2017-09-18 Thread Rasesh Mody
- Add support to retain/clear data for crash dump by introducing the mdump GET_RETAIN/CLR_RETAIN sub commands, new APIs ecore_mcp_mdump_get_retain() and ecore_mcp_mdump_clr_retain() - Avoid checking for mdump logs and data in case of an emulator - Fix "deadbeaf" returned value in case of p

[dpdk-dev] [PATCH 13/53] net/qede/base: alter driver's force load behavior

2017-09-18 Thread Rasesh Mody
- Add an option to override the default force load behavior. - PMD will set the override force load parameter to ECORE_OVERRIDE_FORCE_LOAD_ALWAYS. - Modify the printout when a force load is required to include the loaded value - No need for 'default' when switching over enums and covering

[dpdk-dev] [PATCH 16/53] net/qede/base: use passed ptt handler

2017-09-18 Thread Rasesh Mody
Use the ptt[PF translation table] handler that is passed rather than using main ptt from the HW function. In ecore_hw_get_resc()'s error flow, release the MFW generic resource lock only if needed. Change the verbosity level of GRC timeout from DP_INFO() to DP_NOTICE(). Reduce verbosity of print in

[dpdk-dev] [PATCH 15/53] net/qede/base: add EEE support

2017-09-18 Thread Rasesh Mody
- Base driver EEE (Energy efficient ethernet) support. - Provide supported-speed mask to driver though shared memory. - Read/use eee-supported capabilities value from the shared memory. - Update qed_fill_link() to advertise the EEE capabilities. Signed-off-by: Rasesh Mody --- drivers/net/qed

[dpdk-dev] [PATCH 17/53] net/qede/base: prevent re-assertions of parity errors

2017-09-18 Thread Rasesh Mody
Prevent parity errors from being re-asserted. Mask any parity error, even if it is not associated with a HW block. Signed-off-by: Rasesh Mody --- drivers/net/qede/base/ecore_int.c | 72 - 1 file changed, 39 insertions(+), 33 deletions(-) diff --git a/driver

[dpdk-dev] [PATCH 18/53] net/qede/base: avoid possible race condition

2017-09-18 Thread Rasesh Mody
There's a possible race in multiple VF scenarios for base driver users that use the optional APIs ecore_iov_pf_get_and_clear_pending_events, ecore_iov_pf_add_pending_events. If the client doesn't synchronize the two calls, it's possible for the PF to clear a VF pending message indication without ev

[dpdk-dev] [PATCH 19/53] net/qede/base: revise management FW mbox access scheme

2017-09-18 Thread Rasesh Mody
Revise the manamgement FW mbox access locking scheme for the access to the MFW mailbox: - add a new linked list called cmd_list to ecore_mcp_info that tracks all the mailbox commands sent to management FW and ones waiting for response. - add a mutex lock called cmd_lock to ecore_mcp_info, a

[dpdk-dev] [PATCH 21/53] net/qede/base: initialize resc lock/unlock params

2017-09-18 Thread Rasesh Mody
Add a function that provides default initialization to resc lock/unlock parameters. Change acquire flow that use resources into using this function. Signed-off-by: Rasesh Mody --- drivers/net/qede/base/ecore_dev.c | 13 +++-- drivers/net/qede/base/ecore_mcp.c | 32 +++

[dpdk-dev] [PATCH 22/53] net/qede/base: rename MFW get/set field defines

2017-09-18 Thread Rasesh Mody
Changes for management FW, change of _SHIFT defines to _OFFSET. Accordingly, rename and fix the ECORE_MFW_GET_FIELD() and ECORE_MFW_SET_FIELD() macros and update wherever used. Signed-off-by: Rasesh Mody --- drivers/net/qede/base/ecore.h | 12 +- drivers/net/qede/base/ecore_dcbx.c | 125

[dpdk-dev] [PATCH 20/53] net/qede/base: remove helper functions/structures

2017-09-18 Thread Rasesh Mody
- Remove an additional wrapper function ecore_mcp_nvm_command and instead use ecore_mcp_nvm_wr_cmd, ecore_mcp_nvm_rd_cmd or ecore_mcp_cmd APIs directly as appropriate. - Remove struct ecore_mcp_nvm_params - Add new NVM command ECORE_EXT_PHY_FW_UPGRADE and fix the expected management

[dpdk-dev] [PATCH 23/53] net/qede/base: allow clients to override VF MSI-X table size

2017-09-18 Thread Rasesh Mody
For chip variant CHIP_NUM_AH_xxx, MSI-x configuration for VFs is controlled per-PF [for all of its child VFs] instead of on a per-VF basis. A flag called "dont_override_vf_msix" is added that allows the caller/client to specify the mode they want to operate. If dont_override_vf_msix is false as in

[dpdk-dev] [PATCH 27/53] net/qede/base: prevent stop vport assert by malicious VF

2017-09-18 Thread Rasesh Mody
PF checks upon stop-vport from VF whether it's legal, but if it's not it would STILL send the request to FW, which might cause it to assert. Signed-off-by: Rasesh Mody --- drivers/net/qede/base/ecore_sriov.c |3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/qede/base/ecore_sr

[dpdk-dev] [PATCH 26/53] net/qede/base: block mbox command to unresponsive MFW

2017-09-18 Thread Rasesh Mody
Block sending of mailbox command to the management FW if it is not responsive. Use MCP_REG_CPU_STATE_SOFT_HALTED register to verify the MCP is actually halted after sending the halt command and before proceeding further. Signed-off-by: Rasesh Mody --- drivers/net/qede/base/ecore_mcp.c | 74 +++

[dpdk-dev] [PATCH 29/53] net/qede/base: fix macros to check chip revision/metal

2017-09-18 Thread Rasesh Mody
Fix the ECORE_IS_[AB]0() macros to check both the chip revision and the chip metal. Realign defines in the struct ecore_dev. Fixes: ec94dbc57362 ("qede: add base driver") Cc: sta...@dpdk.org Signed-off-by: Rasesh Mody --- drivers/net/qede/base/ecore.h | 78 ++--

[dpdk-dev] [PATCH 28/53] net/qede/base: remove unused parameters

2017-09-18 Thread Rasesh Mody
This is an attempt to clean up many unused API parameters across the base code. Most of the changes are related to removing unused p_hwfn or p_ptt handlers. The warnings are generated using 'unused-parameter' cflags. Signed-off-by: Rasesh Mody --- drivers/net/qede/base/bcm_osal.h|

[dpdk-dev] [PATCH 25/53] net/qede/base: add support for doorbell overflow recovery

2017-09-18 Thread Rasesh Mody
Add support for doorbell overflow recovery mechanism: The doorbell recovery mechanism consists of a list of entries which represent doorbelling entities (l2 queues, roce sq/rq/cqs, the slowpath spq, etc). Each entity needs to register with the mechanism and provide the parameters describing it's do

[dpdk-dev] [PATCH 24/53] net/qede/base: add API to send STAG config update to FW

2017-09-18 Thread Rasesh Mody
Send updated STAG configuration to the Firmware. Signed-off-by: Rasesh Mody --- drivers/net/qede/base/ecore_dcbx.c|2 +- drivers/net/qede/base/ecore_mcp.c |1 + drivers/net/qede/base/ecore_sp_commands.c | 27 ++- drivers/net/qede/base/ecore_sp_co

Re: [dpdk-dev] [PATCH v3 0/4] increase port_id range

2017-09-18 Thread Yang, Zhiyong
Hi kevin, > -Original Message- > From: Laatz, Kevin > Sent: Monday, September 18, 2017 10:54 PM > To: Yang, Zhiyong ; Matej Vido ; > Yigit, Ferruh ; dev@dpdk.org > Subject: RE: [dpdk-dev] [PATCH v3 0/4] increase port_id range > > > > > > -Original Message- > > > From: Matej Vido

[dpdk-dev] [PATCH 30/53] net/qede/base: read per queue coalescing from HW

2017-09-18 Thread Rasesh Mody
Add base driver API to read per queue coalescing from hardware. Move ecore_set_rxq|txq_coalesce() declarations to ecore_l2.h. Signed-off-by: Rasesh Mody --- drivers/net/qede/base/ecore_dev_api.h | 14 drivers/net/qede/base/ecore_l2.c | 118 +++-- drivers/

[dpdk-dev] [PATCH 31/53] net/qede/base: refactor device's number of ports logic

2017-09-18 Thread Rasesh Mody
- Avoid having num_of_ports as 0 [to prevent a division by 0 via MFW_PORT()]. Also fix the MFW_PORT() macro for CMT. - Read the device's number of ports from shmem. - Rename num_ports_in_engines to num_ports_in_engine. Signed-off-by: Rasesh Mody --- drivers/net/qede/base/ecore.h |3

[dpdk-dev] [PATCH 34/53] net/qede/base: use function pointers for spq async callback

2017-09-18 Thread Rasesh Mody
Change spq async callback to use function pointers instead of switch case on protocolid. Signed-off-by: Rasesh Mody --- drivers/net/qede/base/ecore_spq.c | 38 +-- drivers/net/qede/base/ecore_spq.h | 17 drivers/net/qede/base/ecore_sriov.c

[dpdk-dev] [PATCH 33/53] net/qede/base: use available macro

2017-09-18 Thread Rasesh Mody
- Use OSAL_PAGE_SIZE instead of assuming it to be 4096. - While at it make sure the minimum number of doorbells that can be issued is 4. Signed-off-by: Rasesh Mody --- drivers/net/qede/base/ecore.h |1 + drivers/net/qede/base/ecore_dev.c | 16 2 files changed, 9 i

[dpdk-dev] [PATCH 36/53] net/qede/base: semantic changes

2017-09-18 Thread Rasesh Mody
- Make ecore_dcbx_set_local_params(), ecore_cm_init_pf() as static - Remove src_proto() - remove reference to PROTOCOLID_TOE when determining whether a a protocol requires SRC ILT memory - Add auxiliary variables in various places - All other changes are simple semantic corrections Signed-off-b

[dpdk-dev] [PATCH 32/53] net/qede/base: use proper units for rate limiting

2017-09-18 Thread Rasesh Mody
Change module parameter semantics to standard units (Rate limiting is used for DCQCN feature). Signed-off-by: Rasesh Mody --- drivers/net/qede/base/ecore_sp_commands.c | 43 + drivers/net/qede/base/ecore_sp_commands.h |8 +++--- 2 files changed, 41 insertions(+)

[dpdk-dev] [PATCH 35/53] net/qede/base: fix API return types

2017-09-18 Thread Rasesh Mody
- Turn ecore_ptt_get_hw_addr() into static - Convert ecore_dcbx_get_operational_params() to void since we don't care about the return value Fixes: 26ae839d06e9 ("qede: add DCBX support") Cc: sta...@dpdk.org Signed-off-by: Rasesh Mody --- drivers/net/qede/base/ecore_dcbx.c |6 ++ drive

[dpdk-dev] [PATCH 37/53] net/qede/base: handle the error condition properly

2017-09-18 Thread Rasesh Mody
If for some reason the send message from VF to PF times out, don't bail out right away without taking proper cleanup action. The goto statement calls ecore_vf_pf_req_end() which will unlock the mutex previously held. Signed-off-by: Rasesh Mody --- drivers/net/qede/base/ecore_vf.c |6 ++

[dpdk-dev] [PATCH 38/53] net/qede/base: add new macro for CMT mode

2017-09-18 Thread Rasesh Mody
- Add ECORE_IS_CMT macro (CMT: couple mode teaming) and use that in all the places where there are checks for number of HW functions per device > 1. Signed-off-by: Rasesh Mody --- drivers/net/qede/base/ecore.h |5 +++-- drivers/net/qede/base/ecore_dev.c | 25 ---

[dpdk-dev] [PATCH 39/53] net/qede/base: change verbosity

2017-09-18 Thread Rasesh Mody
Change verbosity of events related to malicious VFs to DP_NOTICE from DP_INFO. They are not just informational events. Signed-off-by: Rasesh Mody --- drivers/net/qede/base/common_hsi.h |4 ++-- drivers/net/qede/base/ecore_sriov.c | 16 +++- 2 files changed, 13 insertions(+), 7

[dpdk-dev] [PATCH 42/53] net/qede/base: add UFP support

2017-09-18 Thread Rasesh Mody
Add support for UFP (Unified Fabric Port) multi-function mode. It includes new APIs for reading UFP configuration, handling UFP events, retriving UFP status and UFP ramrod update etc. Signed-off-by: Rasesh Mody --- drivers/net/qede/base/ecore.h | 45 - drivers/net/q

[dpdk-dev] [PATCH 40/53] net/qede/base: fix number of app table entries

2017-09-18 Thread Rasesh Mody
Configure only the available/requested number of app entries rather than max entries (DCBX_MAX_APP_PROTOCOL) in ecore_dcbx_get_app_data(). Also, fixed a minor issue where incorrect size value is being passed for memcpy(). Fixes: 26ae839d06e9 ("qede: add DCBX support") Cc: sta...@dpdk.org Signed-o

[dpdk-dev] [PATCH 45/53] net/qede/base: move define to header file

2017-09-18 Thread Rasesh Mody
Move FW_MB_PARAM_LOAD_DONE_DID_EFUSE_ERROR to header file Signed-off-by: Rasesh Mody --- drivers/net/qede/base/ecore_mcp.c |2 -- drivers/net/qede/base/mcp_public.h |2 ++ 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/qede/base/ecore_mcp.c b/drivers/net/qed

[dpdk-dev] [PATCH 43/53] net/qede/base: add support for mapped doorbell Bars for VFs

2017-09-18 Thread Rasesh Mody
Determines whether VF utilizes doorbells via limited register bar or via the doorbell bar and return the size of the HW doorbell bar via acquire response. By doing that limit the VF CIDs to an amount that would make sure doorbells for all CIDs fall within the bar. Signed-off-by: Rasesh Mody ---

[dpdk-dev] [PATCH 44/53] net/qede/base: add support for driver attribute repository

2017-09-18 Thread Rasesh Mody
Add support for driver attributes repository in MFW and base driver. Signed-off-by: Rasesh Mody --- drivers/net/qede/base/ecore_mcp.c | 73 drivers/net/qede/base/ecore_mcp.h | 35 + drivers/net/qede/base/mcp_public.h | 28 +

[dpdk-dev] [PATCH 46/53] net/qede/base: dcbx dscp related extensions

2017-09-18 Thread Rasesh Mody
- Add an internal API ecore_dcbx_get_dscp_value() for getting the dscp value for a given priority. - Initialize dscp parameters in the dcbx-config cache to be used by the clients for configuring dcbx parameters. - Reset NIG_REG_DSCP_TO_TC_MAP_ENABLE register when user disables the dscp. - Fix to

[dpdk-dev] [PATCH 47/53] net/qede/base: add feature support for per-PF virtual link

2017-09-18 Thread Rasesh Mody
Add per-PF virtual link support. This feature adds a logical layer over the physical link to reflect the control of OEM management protocols either thru' sideband or a switch. For example, a switch could send a link-down tlv for a PF and this will put down logical link and virtual link in shared me

[dpdk-dev] [PATCH 49/53] net/qede/base: retain dcbx config till actually applied

2017-09-18 Thread Rasesh Mody
Retain user dcbx configurations till the config is applied to the adapter i.e. till the negotiation completes. If base driver receives a config update before negotiation completes, then base driver merges the new config with the cached config and sends it to management FW. Signed-off-by: Rasesh Mo

[dpdk-dev] [PATCH 50/53] net/qede/base: disable aRFS for NPAR and 100G

2017-09-18 Thread Rasesh Mody
Disable accelerated RFS for NPAR and 100G using ECORE_MF_DISABLE_ARFS multi function mode bit. Signed-off-by: Rasesh Mody --- drivers/net/qede/base/ecore.h |2 ++ drivers/net/qede/base/ecore_cxt.c | 10 +- drivers/net/qede/base/ecore_dev.c |6 +- drivers/net/qede/base/e

[dpdk-dev] [PATCH 48/53] net/qede/base: catch an init command write failure

2017-09-18 Thread Rasesh Mody
In case ecore_init_rt() fails for some reason, catch the failure and fail the initialization. Signed-off-by: Rasesh Mody --- drivers/net/qede/base/ecore_init_ops.c |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/qede/base/ecore_init_ops.c b/drivers/net

[dpdk-dev] [PATCH 51/53] net/qede/base: add support for WoL writes

2017-09-18 Thread Rasesh Mody
Add support programing of WoL Bitmap paterns via management FW mailbox. Signed-off-by: Rasesh Mody --- drivers/net/qede/base/ecore_dev.c | 26 +- drivers/net/qede/base/ecore_mcp.c | 26 ++ drivers/net/qede/base/ecore_mcp.h |3 +++ driver

[dpdk-dev] [PATCH 53/53] net/qede/base: update PMD version to 2.6.0.1

2017-09-18 Thread Rasesh Mody
Update QEDE PMD version to 2.6.0.1 Signed-off-by: Rasesh Mody --- drivers/net/qede/qede_ethdev.h |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/qede/qede_ethdev.h b/drivers/net/qede/qede_ethdev.h index a3254b1..4543533 100644 --- a/drivers/net/qede/qede_et

[dpdk-dev] [PATCH 52/53] net/qede/base: remove unused input parameter

2017-09-18 Thread Rasesh Mody
Remove unused input parameter from ecore_dcbx_info_free(). Signed-off-by: Rasesh Mody --- drivers/net/qede/base/ecore_dcbx.c |3 +-- drivers/net/qede/base/ecore_dcbx.h |2 +- drivers/net/qede/base/ecore_dev.c |2 +- 3 files changed, 3 insertions(+), 4 deletions(-) diff --git a/driv

[dpdk-dev] [PATCH v2] net/i40e: fix incorrect var assignment

2017-09-18 Thread Jingjing Wu
rx/tx_queue_setup functions are shared between PF and VF drivers. So the var 'pf' should not be assigned at the beginning. This patch fixes the issue, and also corrects the return err code. Cc: sta...@dpdk.org Fixes: b6583ee40265 ("i40e: full VMDQ pools support") Signed-off-by: Jingjing Wu --- v

Re: [dpdk-dev] [PATCH] test: support to check AVX512F

2017-09-18 Thread Yang, Zhiyong
Hi Bruce, > -Original Message- > From: Richardson, Bruce > Sent: Monday, September 18, 2017 11:08 PM > To: Yang, Zhiyong > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] test: support to check AVX512F > > suggest title as: test: add check for AVX512F > > On Fri, Sep 08, 2017 at 03:4

Re: [dpdk-dev] [PATCH v2] net/i40e: fix mirror rule reset when port is stopped

2017-09-18 Thread Wu, Jingjing
> -Original Message- > From: Xing, Beilei > Sent: Monday, September 11, 2017 10:46 AM > To: Dai, Wei ; Wu, Jingjing > Cc: dev@dpdk.org; Dai, Wei ; sta...@dpdk.org > Subject: RE: [dpdk-dev] [PATCH v2] net/i40e: fix mirror rule reset when port > is > stopped > > > > -Original Messag

[dpdk-dev] [PATCH v2] test: add check for AVX512F

2017-09-18 Thread Zhiyong Yang
The CPUs which support AVX512 have been released. Add support for checking AVX512F instruction set. Signed-off-by: Zhiyong Yang Acked-by: Bruce Richardson --- Changes in V2: reword the title and commit message according to Bruce's comments. test/test/test_cpuflags.c | 3 +++ 1 file changed, 3

Re: [dpdk-dev] [PATCH v3 1/3] net/i40e: fix clear xstats bug in vf port

2017-09-18 Thread Wu, Jingjing
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Wei Zhao > Sent: Monday, September 18, 2017 2:18 PM > To: dev@dpdk.org > Cc: Zhao1, Wei > Subject: [dpdk-dev] [PATCH v3 1/3] net/i40e: fix clear xstats bug in vf port > > There is a bug in vf clear xstats comman

Re: [dpdk-dev] [PATCH v3 1/3] net/i40e: fix clear xstats bug in vf port

2017-09-18 Thread Zhao1, Wei
Hi, jinging > -Original Message- > From: Wu, Jingjing > Sent: Tuesday, September 19, 2017 10:59 AM > To: Zhao1, Wei ; dev@dpdk.org > Cc: Zhao1, Wei > Subject: RE: [dpdk-dev] [PATCH v3 1/3] net/i40e: fix clear xstats bug in vf > port > > > > > -Original Message- > > From: dev [

[dpdk-dev] [PATCH] net/ixgbe: fix uninitialized variable

2017-09-18 Thread Yong Wang
In func ixgbe_dev_link_update(), "link.link_autoneg" is used in func call rte_ixgbe_dev_atomic_write_link_status(), but is uninitialized. Signed-off-by: Yong Wang --- drivers/net/ixgbe/ixgbe_ethdev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/n

[dpdk-dev] MTU in i40e driver

2017-09-18 Thread Nitin Katiyar
Hi, We are using OVS-DPDK (2.6 version) with Fortville NIC (configured in 25G mode) being used as dpdk port. The setup involves 2 VMs running on 2 different computes (destination VM in compute with 10G NIC while originating VM is in compute with Fortville NIC). All the interfaces in the path ar

Re: [dpdk-dev] [PATCH] net/bonding: strengthen the judgment of lacp packets

2017-09-18 Thread zengganghui
Local LACP packets do not have VLANs, and ethertype must be ETHER_TYPE_SLOW. But when the PMD supports VLAN strip, you cannot directly determine the ethertype from the packet, but depends on whether the VLAN is stripped. If a VLAN is stripped, then this is not a local LACP packet, but it may be

Re: [dpdk-dev] [PATCH 12/12] examples/helloworld: do not exit automatically

2017-09-18 Thread Tan, Jianfeng
Hi Pablo, > -Original Message- > From: De Lara Guarch, Pablo > Sent: Monday, September 18, 2017 7:44 PM > To: Tan, Jianfeng; dev@dpdk.org > Cc: Richardson, Bruce; Ananyev, Konstantin; tho...@monjalon.net; > y...@fridaylinux.org; maxime.coque...@redhat.com; mtetsu...@gmail.com; > Yigit, Fer

[dpdk-dev] [PATCH] ethdev: fix the comment for rte_eth_conf.

2017-09-18 Thread Tonghao Zhang
We have change the type of rx_adv_conf, so change the comment for it. Signed-off-by: Tonghao Zhang --- lib/librte_ether/rte_ethdev.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h index 99cdd54..e079daa 100644 ---

Re: [dpdk-dev] [PATCH] net/enic: fix multi-process operation

2017-09-18 Thread John Daley (johndale)
> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Monday, September 18, 2017 3:25 PM > To: John Daley (johndale) > Cc: Ferruh Yigit ; dev@dpdk.org; Sergio Gonzalez > Monroy > Subject: Re: [PATCH] net/enic: fix multi-process operation > > 18/09/2017 23:27,

Re: [dpdk-dev] [PATCH v2] SDK: Add scripts to initialize DPDK runtime

2017-09-18 Thread Christian Ehrhardt
On Mon, Sep 18, 2017 at 10:44 PM, Ferruh Yigit wrote: > On 12/13/2016 4:47 PM, lboccass at brocade.com (Luca Boccassi) wrote: > > From: Christian Ehrhardt > > > > A tools/init directory is added with dpdk-init, a script that can be > > used to initialize a DPDK runtime environment. 2 config file

Re: [dpdk-dev] [PATCH 04/12] vdev: move to drivers/bus

2017-09-18 Thread Tan, Jianfeng
Hi Pablo > -Original Message- > From: De Lara Guarch, Pablo > Sent: Monday, September 18, 2017 7:48 PM > To: Tan, Jianfeng; Gaëtan Rivet > Cc: dev@dpdk.org; Richardson, Bruce; Ananyev, Konstantin; > tho...@monjalon.net; y...@fridaylinux.org; maxime.coque...@redhat.com; > mtetsu...@gmail.co

Re: [dpdk-dev] [PATCH v3 1/4] ethdev: increase port_id range

2017-09-18 Thread Yang, Zhiyong
> -Original Message- > From: Yigit, Ferruh > Sent: Wednesday, September 13, 2017 9:33 PM > To: Thomas Monjalon > Cc: Yang, Zhiyong ; dev@dpdk.org; Doherty, Declan > ; Lu, Wenzhuo ; > hemant.agra...@nxp.com; Hunt, David ; Richardson, > Bruce ; Ananyev, Konstantin > > Subject: Re: [PATCH

Re: [dpdk-dev] [PATCH v4 1/2] net/mlx5: replace network to host macros

2017-09-18 Thread Nélio Laranjeiro
For the series Acked-by: Nelio Laranjeiro -- Nélio Laranjeiro 6WIND

Re: [dpdk-dev] [PATCH v2] net/liquidio: fix uninitialized variable

2017-09-18 Thread Shijith Thotton
On Fri, Sep 15, 2017 at 07:48:28AM -0400, Yong Wang wrote: > In func lio_dev_link_update(), "link.link_autoneg" is used in func call > lio_dev_atomic_write_link_status(), but is uninitialized. > > v2: > * Modify the initial value of 'link.link_autoneg' from 'ETH_LINK_FIXED' > to 'ETH_LINK_AUTONE

<    1   2   3