Re: [dpdk-dev] [PATCH] crypto/dpaa2_sec: reduce init log prints

2017-07-27 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Hemant Agrawal > Sent: Monday, July 24, 2017 8:32 AM > To: dev@dpdk.org > Cc: Shreyansh Jain > Subject: [dpdk-dev] [PATCH] crypto/dpaa2_sec: reduce init log prints > > From: Shreyansh Jain > > Signed-off-by: S

Re: [dpdk-dev] [PATCH] crypto/openssl: fix typo

2017-07-27 Thread De Lara Guarch, Pablo
> -Original Message- > From: De Lara Guarch, Pablo > Sent: Tuesday, July 25, 2017 10:07 AM > To: dev@dpdk.org > Cc: De Lara Guarch, Pablo > Subject: [PATCH] crypto/openssl: fix typo > > Fixes: b79e4c00af0e ("cryptodev: use AES-GCM/CCM as AEAD algorithms") > > Signed-off-by: Pablo de La

Re: [dpdk-dev] [PATCH] doc: support new ZUC library version

2017-07-27 Thread De Lara Guarch, Pablo
> -Original Message- > From: De Lara Guarch, Pablo > Sent: Tuesday, July 25, 2017 8:17 AM > To: dev@dpdk.org > Cc: De Lara Guarch, Pablo > Subject: [PATCH] doc: support new ZUC library version > > A new version of the LibSSO ZUC library has been released. > This version includes shared

[dpdk-dev] [PATCH] net/i40e: fix dereferencing null pointer

2017-07-27 Thread Kuba Kozak
Add check if o_vlan_mask and i_vlan_mask are not a NULL pointer. Coverity issue: 143448 Coverity issue: 143449 Fixes: d37705068ee8 ("net/i40e: parse QinQ pattern") Cc: sta...@dpdk.org Signed-off-by: Kuba Kozak --- drivers/net/i40e/i40e_flow.c | 6 -- 1 file changed, 4 insertions(+), 2 delet

Re: [dpdk-dev] [PATCH] crypto/dpaa2_sec: add check for gcc toolchain

2017-07-27 Thread De Lara Guarch, Pablo
HI Akhil, > -Original Message- > From: Akhil Goyal [mailto:akhil.go...@nxp.com] > Sent: Wednesday, July 26, 2017 12:28 PM > To: dev@dpdk.org > Cc: De Lara Guarch, Pablo ; > hemant.agra...@nxp.com; Akhil Goyal > Subject: [PATCH] crypto/dpaa2_sec: add check for gcc toolchain > > Signed-off

Re: [dpdk-dev] [PATCH] cryptodev: fix crypto op bulk alloc Doxygen

2017-07-27 Thread Trahe, Fiona
Hi Pablo, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Pablo de Lara > Sent: Wednesday, July 26, 2017 5:27 AM > To: Doherty, Declan > Cc: dev@dpdk.org; De Lara Guarch, Pablo ; > sta...@dpdk.org > Subject: [dpdk-dev] [PATCH] cryptodev: fix crypto op bulk all

[dpdk-dev] [PATCH] doc: fix missing section underline

2017-07-27 Thread Pablo de Lara
Fixes: b59502a5e3d0 ("cryptodev: add AEAD parameters in crypto operation") Signed-off-by: Pablo de Lara --- doc/guides/prog_guide/cryptodev_lib.rst | 1 + 1 file changed, 1 insertion(+) diff --git a/doc/guides/prog_guide/cryptodev_lib.rst b/doc/guides/prog_guide/cryptodev_lib.rst index 568b539

Re: [dpdk-dev] [PATCH] crypto/qat: fix SHA384-HMAC block size

2017-07-27 Thread Trahe, Fiona
> -Original Message- > From: De Lara Guarch, Pablo > Sent: Tuesday, July 25, 2017 7:34 AM > To: Trahe, Fiona ; Jain, Deepak K > ; Griffin, John > > Cc: dev@dpdk.org; De Lara Guarch, Pablo ; > sta...@dpdk.org > Subject: [PATCH] crypto/qat: fix SHA384-HMAC block size > > Block size of S

Re: [dpdk-dev] [PATCH 3/3] crypto/qat: fix HMAC supported key sizes

2017-07-27 Thread Trahe, Fiona
> -Original Message- > From: De Lara Guarch, Pablo > Sent: Tuesday, July 25, 2017 6:25 AM > To: zbigniew.bo...@caviumnetworks.com; jerin.ja...@caviumnetworks.com; > akhil.go...@nxp.com; > hemant.agra...@nxp.com; Trahe, Fiona ; Jain, Deepak K > ; Griffin, John ; Doherty, > Declan > > Cc:

Re: [dpdk-dev] [PATCH v2] cryptodev: fix session init return value

2017-07-27 Thread Trahe, Fiona
> -Original Message- > From: De Lara Guarch, Pablo > Sent: Tuesday, July 25, 2017 7:17 AM > To: zbigniew.bo...@caviumnetworks.com; jerin.ja...@caviumnetworks.com; > akhil.go...@nxp.com; > hemant.agra...@nxp.com; Trahe, Fiona ; Jain, Deepak K > ; Griffin, John ; Doherty, > Declan > > Cc

Re: [dpdk-dev] [dpdk-users] SR-IOV problem with dpdk drivers

2017-07-27 Thread SAKTHIVEL ANAND S
+dev-dpdk can help here.. I have removed SR-IOV and made those interfaces as PIC-passthrough and that is working without any issues. So, Yes! this could be problem with virtual function driver(i40evf). Thanks On Thu, Jul 27, 2017 at 8:30 AM, Raju-dev grishma wrote: > Linux driver works, DPDK

Re: [dpdk-dev] [PATCH 2/3] crypto/openssl: fix HMAC supported key sizes

2017-07-27 Thread Declan Doherty
On 25/07/2017 6:24 AM, Pablo de Lara wrote: For HMAC algorithms (MD5-HMAC, SHAx-HMAC), the supported key sizes are not a fixed value, but a range between 1 and the block size. Fixes: d61f70b4c918 ("crypto/libcrypto: add driver for OpenSSL library") Cc: sta...@dpdk.org Signed-off-by: Pablo de La

Re: [dpdk-dev] [PATCH 1/3] crypto/aesni_mb: fix HMAC supported key sizes

2017-07-27 Thread Declan Doherty
On 25/07/2017 6:24 AM, Pablo de Lara wrote: For HMAC algorithms (MD5-HMAC, SHAx-HMAC), the supported key sizes are not a fixed value, but a range between 1 and the block size. Fixes: 26c2e4ad5ad4 ("cryptodev: add capabilities discovery") Cc: sta...@dpdk.org Signed-off-by: Pablo de Lara --- ..

Re: [dpdk-dev] [PATCH] cryptodev: deprecate rte_cryptodev_create_vdev()

2017-07-27 Thread Declan Doherty
On 12/07/2017 9:15 PM, Jan Blunck wrote: This function is an alias for rte_vdev_init() which is scheduled to move out of the rte_eal library. Lets deprecate this function to be able to remove it from the cryptodev library in 17.11. Signed-off-by: Jan Blunck --- ... Acked-by: Declan Doherty

[dpdk-dev] [PATCH v2] net/mlx4: fix flow creation before start

2017-07-27 Thread Matan Azrad
The corrupted code causes segmentation fault when user creates flow with drop action before device starting. For example, failsafe PMD recreates all the flows before calling dev_start in plug-in sequence and mlx4 allocated its flow drop queue in dev_start. Hence, when failsafe created flow with dr

Re: [dpdk-dev] Question on mlx5 PMD txq memory registration

2017-07-27 Thread Sagi Grimberg
Well, this is a fair argument, but without a *complete* solution for all of dpdk peripherals, it has very little merit (if at all). A badly written code can just as easily crash a server by passing a mbuf to a crypto device or another network device that co-exists with mlx5. So, while I underst

Re: [dpdk-dev] [PATCH 1/2] eventdev: add event adapter for ethernet Rx queues

2017-07-27 Thread Rao, Nikhil
Hi Jerin and all, There are a few inconsistencies/complexities that I ran into with the implementation of the SW Rx event adapter, I have first summarized this email thread bringing together details scattered across various exchanges then I want to check if there are changes possible that wou

Re: [dpdk-dev] [PATCH] net/mlx5: poll completion queue once per a call

2017-07-27 Thread Sagi Grimberg
Yes I realize that, but can't the device still complete in a burst (of unsuppressed completions)? I mean its not guaranteed that for every txq_complete a signaled completion is pending right? What happens if the device has inconsistent completion pacing? Can't the sw grow a batch of completions

Re: [dpdk-dev] [PATCH] crypto/dpaa2_sec: add check for gcc toolchain

2017-07-27 Thread Akhil Goyal
On 7/27/2017 2:22 PM, De Lara Guarch, Pablo wrote: HI Akhil, -Original Message- From: Akhil Goyal [mailto:akhil.go...@nxp.com] Sent: Wednesday, July 26, 2017 12:28 PM To: dev@dpdk.org Cc: De Lara Guarch, Pablo ; hemant.agra...@nxp.com; Akhil Goyal Subject: [PATCH] crypto/dpaa2_sec: add

[dpdk-dev] [PATCH] crypto/dpaa2_sec: fix HMAC supported key sizes

2017-07-27 Thread Akhil Goyal
For HMAC algorithms (MD5-HMAC, SHAx-HMAC), the supported key sizes are not a fixed value, but a range between 1 and the block size. Fixes: 623326dded3a ("crypto/dpaa2_sec: introduce poll mode driver") Cc: sta...@dpdk.org Signed-off-by: Akhil Goyal --- drivers/crypto/dpaa2_sec/dpaa2_sec_priv.h |

[dpdk-dev] [PATCH] bonding: fix wrong slaves capacity check

2017-07-27 Thread Tomasz Kulasek
For fortville NIC bond_ethdev_8023ad_flow_verify fails when action queue index indicates unavailable queue before slaves configuration. This fix verifies flow settings for queue 0, which is always available, and checks if slaves max queue number capacity meets requirements. Fixes: 112891cd27e5 ("

Re: [dpdk-dev] [PATCH] crypto/dpaa2_sec: add check for gcc toolchain

2017-07-27 Thread De Lara Guarch, Pablo
Hi, > -Original Message- > From: Akhil Goyal [mailto:akhil.go...@nxp.com] > Sent: Thursday, July 27, 2017 12:43 PM > To: De Lara Guarch, Pablo ; > dev@dpdk.org > Cc: hemant.agra...@nxp.com > Subject: Re: [PATCH] crypto/dpaa2_sec: add check for gcc toolchain > > On 7/27/2017 2:22 PM, De La

Re: [dpdk-dev] [PATCH] crypto/dpaa2_sec: fix HMAC supported key sizes

2017-07-27 Thread Hemant Agrawal
On 7/27/2017 5:24 PM, Akhil Goyal wrote: For HMAC algorithms (MD5-HMAC, SHAx-HMAC), the supported key sizes are not a fixed value, but a range between 1 and the block size. Fixes: 623326dded3a ("crypto/dpaa2_sec: introduce poll mode driver") Cc: sta...@dpdk.org Signed-off-by: Akhil Goyal ---

Re: [dpdk-dev] [PATCH] crypto/dpaa2_sec: fix HMAC supported key sizes

2017-07-27 Thread De Lara Guarch, Pablo
> -Original Message- > From: Hemant Agrawal [mailto:hemant.agra...@nxp.com] > Sent: Thursday, July 27, 2017 2:58 PM > To: Akhil Goyal ; dev@dpdk.org > Cc: De Lara Guarch, Pablo ; > sta...@dpdk.org > Subject: Re: [PATCH] crypto/dpaa2_sec: fix HMAC supported key sizes > > On 7/27/2017 5:24

Re: [dpdk-dev] [PATCH] crypto/dpaa2_sec: add check for gcc toolchain

2017-07-27 Thread De Lara Guarch, Pablo
> -Original Message- > From: Akhil Goyal [mailto:akhil.go...@nxp.com] > Sent: Thursday, July 27, 2017 12:43 PM > To: De Lara Guarch, Pablo ; > dev@dpdk.org > Cc: hemant.agra...@nxp.com > Subject: Re: [PATCH] crypto/dpaa2_sec: add check for gcc toolchain > > On 7/27/2017 2:22 PM, De Lara

Re: [dpdk-dev] [PATCH 0/3] HMAC supported key size fixes

2017-07-27 Thread De Lara Guarch, Pablo
> -Original Message- > From: De Lara Guarch, Pablo > Sent: Tuesday, July 25, 2017 6:25 AM > To: zbigniew.bo...@caviumnetworks.com; > jerin.ja...@caviumnetworks.com; akhil.go...@nxp.com; > hemant.agra...@nxp.com; Trahe, Fiona ; Jain, > Deepak K ; Griffin, John > ; Doherty, Declan > Cc: de

Re: [dpdk-dev] [PATCH] crypto/qat: fix SHA384-HMAC block size

2017-07-27 Thread De Lara Guarch, Pablo
> -Original Message- > From: Trahe, Fiona > Sent: Thursday, July 27, 2017 10:42 AM > To: De Lara Guarch, Pablo ; Jain, Deepak K > ; Griffin, John > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: RE: [PATCH] crypto/qat: fix SHA384-HMAC block size > > > > > -Original Message- > >

Re: [dpdk-dev] [PATCH v2] cryptodev: fix session init return value

2017-07-27 Thread De Lara Guarch, Pablo
> -Original Message- > From: Trahe, Fiona > Sent: Thursday, July 27, 2017 11:12 AM > To: De Lara Guarch, Pablo ; > zbigniew.bo...@caviumnetworks.com; jerin.ja...@caviumnetworks.com; > akhil.go...@nxp.com; hemant.agra...@nxp.com; Jain, Deepak K > ; Griffin, John ; Doherty, > Declan > Cc:

Re: [dpdk-dev] [PATCH] doc: fix missing section underline

2017-07-27 Thread De Lara Guarch, Pablo
> -Original Message- > From: De Lara Guarch, Pablo > Sent: Thursday, July 27, 2017 2:25 AM > To: Mcnamara, John > Cc: dev@dpdk.org; De Lara Guarch, Pablo > > Subject: [PATCH] doc: fix missing section underline > > Fixes: b59502a5e3d0 ("cryptodev: add AEAD parameters in crypto > operati

Re: [dpdk-dev] [PATCH] doc: fix l2fwd-crypto sample code

2017-07-27 Thread De Lara Guarch, Pablo
> -Original Message- > From: De Lara Guarch, Pablo > Sent: Wednesday, July 26, 2017 12:33 AM > To: Mcnamara, John ; Doherty, Declan > > Cc: dev@dpdk.org; De Lara Guarch, Pablo > > Subject: [PATCH] doc: fix l2fwd-crypto sample code > > L2fwd-crypto app was modified with various changes

Re: [dpdk-dev] [PATCH] cryptodev: fix crypto op bulk alloc Doxygen

2017-07-27 Thread De Lara Guarch, Pablo
> -Original Message- > From: Trahe, Fiona > Sent: Thursday, July 27, 2017 10:03 AM > To: De Lara Guarch, Pablo ; Doherty, > Declan > Cc: dev@dpdk.org; De Lara Guarch, Pablo > ; sta...@dpdk.org; Trahe, Fiona > > Subject: RE: [dpdk-dev] [PATCH] cryptodev: fix crypto op bulk alloc Doxygen

[dpdk-dev] [PATCH v2] cryptodev: fix crypto op bulk alloc Doxygen

2017-07-27 Thread Pablo de Lara
When calling rte_crypto_op_bulk_alloc, the function may return either a 0, if not enough objects are available in the mempool or the number of operations requested, it there are enough available. However, the Doxygen comments were not matching these two cases. Fixes: c0f87eb5252b ("cryptodev: chan

Re: [dpdk-dev] [PATCH v2] cryptodev: fix crypto op bulk alloc Doxygen

2017-07-27 Thread Trahe, Fiona
> -Original Message- > From: De Lara Guarch, Pablo > Sent: Thursday, July 27, 2017 5:06 PM > To: Trahe, Fiona ; Doherty, Declan > > Cc: dev@dpdk.org; De Lara Guarch, Pablo ; > sta...@dpdk.org > Subject: [PATCH v2] cryptodev: fix crypto op bulk alloc Doxygen > > When calling rte_crypto

Re: [dpdk-dev] [PATCH v2] cryptodev: fix crypto op bulk alloc Doxygen

2017-07-27 Thread De Lara Guarch, Pablo
> -Original Message- > From: Trahe, Fiona > Sent: Thursday, July 27, 2017 5:17 PM > To: De Lara Guarch, Pablo ; Doherty, > Declan > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: RE: [PATCH v2] cryptodev: fix crypto op bulk alloc Doxygen > > > > > -Original Message- > > From: De

Re: [dpdk-dev] [PATCH v2 0/4] cryptodev vdev changes for -rc2

2017-07-27 Thread Jan Blunck
On Wed, Jul 19, 2017 at 9:31 AM, De Lara Guarch, Pablo wrote: > > > > > -Original Message- > > From: Jan Blunck [mailto:jblu...@gmail.com] On Behalf Of Jan Blunck > > Sent: Wednesday, July 12, 2017 8:59 PM > > To: dev@dpdk.org > > Cc: Doherty, Declan ; De Lara Guarch, Pablo > > > > Subjec

[dpdk-dev] [PATCH] Fix bash path in shebangs

2017-07-27 Thread asomers
From: Alan Somers "/bin/bash" is a Linuxism. "/usr/bin/env bash" is portable. Signed-off-by Alan Somers --- examples/performance-thread/l3fwd-thread/test.sh | 2 +- usertools/dpdk-setup.sh | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/examples

[dpdk-dev] [PATCH] Fix bash path in shebangs

2017-07-27 Thread asomers
From: Alan Somers "/bin/bash" is a Linuxism. "/usr/bin/env bash" is portable. Signed-off-by: Alan Somers --- examples/performance-thread/l3fwd-thread/test.sh | 2 +- usertools/dpdk-setup.sh | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/example

Re: [dpdk-dev] [PATCH] net/mlx5: poll completion queue once per a call

2017-07-27 Thread Yongseok Koh
> On Jul 27, 2017, at 4:12 AM, Sagi Grimberg wrote: > > >>> Yes I realize that, but can't the device still complete in a burst (of >>> unsuppressed completions)? I mean its not guaranteed that for every >>> txq_complete a signaled completion is pending right? What happens if >>> the device has

Re: [dpdk-dev] [PATCH] doc: add testpmd bonding mode 4 aggregators mode

2017-07-27 Thread Wu, Jingjing
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Daniel Mrzyglod > Sent: Thursday, July 27, 2017 2:41 PM > To: Mcnamara, John ; Doherty, Declan > > Cc: dev@dpdk.org; Mrzyglod, DanielX T > Subject: [dpdk-dev] [PATCH] doc: add testpmd bonding mode 4 aggregators

Re: [dpdk-dev] [PATCH] net/i40e: fix dereferencing null pointer

2017-07-27 Thread Wu, Jingjing
> -Original Message- > From: Kozak, KubaX > Sent: Thursday, July 27, 2017 3:28 PM > To: Wu, Jingjing > Cc: dev@dpdk.org; Jain, Deepak K ; Jastrzebski, > MichalX K > ; Kozak, KubaX ; > sta...@dpdk.org > Subject: [PATCH] net/i40e: fix dereferencing null pointer > > Add check if o_vlan_ma

[dpdk-dev] [PATCH v2] net/i40e: fix PF notify issue when VF not up

2017-07-27 Thread Xiaoyun Li
This patch modifies PF notify error to warning when not starting up VF and modifies VF state to active when VF reset is completed. Fixes: 4861cde46116 ("i40e: new poll mode driver") Cc: sta...@dpdk.org Signed-off-by: Xiaoyun Li --- v2 changes: * add VF state modification when VF reset is done. -

Re: [dpdk-dev] [PATCH v2] net/i40e: fix PF notify issue when VF not up

2017-07-27 Thread Wu, Jingjing
> -Original Message- > From: Li, Xiaoyun > Sent: Friday, July 28, 2017 7:40 PM > To: Wu, Jingjing > Cc: dev@dpdk.org; Li, Xiaoyun ; sta...@dpdk.org > Subject: [PATCH v2] net/i40e: fix PF notify issue when VF not up > > This patch modifies PF notify error to warning when not starting > u