[dpdk-dev] [PATCH v2] crypto/dpaa2_sec: fix the return of supported API

2017-07-18 Thread Akhil Goyal
call to dpaa2_sec_dev_configure() is made mandatory, but dpaa2_sec_pmd returns a ENOTSUP which results in device not getting configured. dpaa2_sec PMD does not need any further configuration to be done in dpaa2_sec_dev_configure, hence returning 0 Fixes: e5cbdfc53765 ("crypto/dpaa2_sec: add basic

Re: [dpdk-dev] [PATCH] net/tap: add missing newlines in logs

2017-07-18 Thread Ferruh Yigit
On 7/10/2017 8:07 AM, Pascal Mazon wrote: > > On 07/06/2017 05:28 PM, Thomas Monjalon wrote: >> Some logs are missing the newline character \n. >> >> The logs using only line can be checked with this command: >> git grep 'RTE_LOG(.*".*[^n]"' drivers/net/tap/ This shows that some other drive

Re: [dpdk-dev] [PATCH] net/ring: add missing newlines in logs

2017-07-18 Thread Ferruh Yigit
On 7/6/2017 4:47 PM, Thomas Monjalon wrote: > Some logs are missing the newline character \n. > > The logs using only line can be checked with this command: > git grep 'RTE_LOG(.*".*[^n]"' drivers/net/tap/ > > Fixes: 61934c0956d4 ("ring: convert to use of PMD_REGISTER_DRIVER and fix > link

Re: [dpdk-dev] [PATCH 2/3] cryptodev: rename field name

2017-07-18 Thread Trahe, Fiona
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Pablo de Lara > Sent: Monday, July 17, 2017 9:30 AM > To: Doherty, Declan > Cc: dev@dpdk.org; De Lara Guarch, Pablo > Subject: [dpdk-dev] [PATCH 2/3] cryptodev: rename field name > > Additional Authenticated Da

Re: [dpdk-dev] [PATCH 1/3] cryptodev: modify some field sizes

2017-07-18 Thread Trahe, Fiona
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Pablo de Lara > Sent: Monday, July 17, 2017 9:30 AM > To: Doherty, Declan > Cc: dev@dpdk.org; De Lara Guarch, Pablo > Subject: [dpdk-dev] [PATCH 1/3] cryptodev: modify some field sizes > > Crypto keys and diges

Re: [dpdk-dev] [PATCH 3/3] cryptodev: reorder auth transform

2017-07-18 Thread Trahe, Fiona
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Pablo de Lara > Sent: Monday, July 17, 2017 9:30 AM > To: Doherty, Declan > Cc: dev@dpdk.org; De Lara Guarch, Pablo > Subject: [dpdk-dev] [PATCH 3/3] cryptodev: reorder auth transform > > IV was positioned diff

Re: [dpdk-dev] [PATCH] crypto/qat: fix handle device-agnostic session

2017-07-18 Thread Trahe, Fiona
> -Original Message- > From: Kusztal, ArkadiuszX > Sent: Monday, July 17, 2017 5:57 PM > To: dev@dpdk.org > Cc: Trahe, Fiona ; De Lara Guarch, Pablo > ; > Griffin, John ; Jain, Deepak K > ; Kusztal, ArkadiuszX > > Subject: [PATCH] crypto/qat: fix handle device-agnostic session > > Old

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/sfc: request MAC stats upload immediately on port start

2017-07-18 Thread Ferruh Yigit
On 7/8/2017 4:16 PM, Andrew Rybchenko wrote: > From: Ivan Malov > > If MAC stats refresh is arranged to be done by periodic DMA, > the first DMA transaction is unlikely to occur right on the > port start; if the user tries to get stats right after port > start and before the transaction occurs, b

Re: [dpdk-dev] [PATCH] net/sfc: add support for xstats retrieval by ID

2017-07-18 Thread Ferruh Yigit
On 7/12/2017 3:18 PM, Remy Horton wrote: > > On 08/07/2017 16:45, Andrew Rybchenko wrote: >> From: Ivan Malov >> >> Signed-off-by: Ivan Malov >> Signed-off-by: Andrew Rybchenko > [..] > > Reviewed-by: Remy Horton Applied to dpdk-next-net/master, thanks.

Re: [dpdk-dev] [PATCH] net/failsafe: do not probe device if plugged out

2017-07-18 Thread Ferruh Yigit
On 7/13/2017 10:17 AM, Thomas Monjalon wrote: > 13/07/2017 10:14, Gaëtan Rivet: >> On Thu, Jul 13, 2017 at 08:52:33AM +0200, Thomas Monjalon wrote: >>> 12/07/2017 22:39, Gaëtan Rivet: Hi Thomas, Nice idea. A few remarks below: On Wed, Jul 12, 2017 at 08:28:12PM +0200, Thoma

Re: [dpdk-dev] [PATCH] doc: update supported architectures for QEDE PMD

2017-07-18 Thread Ferruh Yigit
On 7/8/2017 7:31 PM, Rasesh Mody wrote: > Add support for x86-32 and armv8 architectures. > > Signed-off-by: Rasesh Mody Applied to dpdk-next-net/master, thanks.

Re: [dpdk-dev] Occasional instability in RSS Hashes/Queues from X540 NIC

2017-07-18 Thread Yang, Qiming
Hi Matt, We can reproduce this RSS issue on 16.04 but can't on 17.02, so this issue was fixed on 17.02. We suggest using the new version. Qiming > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Matt Laswell > Sent: Friday, May 5, 2017 9:05 PM > To: dev@dpdk.org

[dpdk-dev] [PATCH v3] doc: add known issue for i40e VF performance

2017-07-18 Thread Qi Zhang
VF performance is limited by the kernel PCI extended tag setting. Update the document to explain the known issue and the workaround. Signed-off-by: Qi Zhang --- v3: - fix typos errors. v2: - follow number list format. - improve the comments. doc/guides/nics/i40e.rst | 27 +

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] net/i40e: fix VF Tx bytes

2017-07-18 Thread Ferruh Yigit
On 7/9/2017 8:54 PM, Qi Zhang wrote: > Tx CRC size is not counted by vsi's stats register, so it is not necessary > excluded by driver. > > Fixes: 98abce237ba7 ("net/i40e: fix VF statistics") > > Signed-off-by: Qi Zhang Acked-by: Beilei Xing Applied to dpdk-next-net/master, thanks. (Kept ac

Re: [dpdk-dev] [PATCH] net/thunderx: update sq config register field

2017-07-18 Thread Ferruh Yigit
On 7/11/2017 2:54 PM, Jerin Jacob wrote: > cq_limit field is added in cn88xx-pass2 and subsequent > versions. Reflect the change in the sq_config structure. > This change is backward compatible as the old pass versions > ignore this field. > > Signed-off-by: Jerin Jacob Applied to dpdk-next-net/

[dpdk-dev] [PATCH] crypto/scheduler: fix buffer not null terminated

2017-07-18 Thread Pablo de Lara
Coverity issue: 143431 Fixes: 31439ee72b2c ("crypto/scheduler: add API implementations") Cc: sta...@dpdk.org Signed-off-by: Pablo de Lara --- drivers/crypto/scheduler/rte_cryptodev_scheduler.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/drivers/crypto/scheduler/rte_crypto

[dpdk-dev] [PATCH v1] metrics: fix missing NULL termination

2017-07-18 Thread Remy Horton
The public API (struct rte_metric_name) includes the NULL terminator byte in RTE_METRICS_MAX_NAME_LENGTH but the library itself internally excludes it. This makes it possible for an application to receive an unterminated name string. Fix be enforcing the NULL termination of all name strings to the

Re: [dpdk-dev] [PATCH] net/mlx5: change start pointer of compressed completion

2017-07-18 Thread Ferruh Yigit
On 7/13/2017 8:04 AM, Nélio Laranjeiro wrote: > On Wed, Jul 12, 2017 at 03:09:54PM -0700, Yongseok Koh wrote: >> On a host having 128B cacheline size, some devices insert 64B padding in >> each completion entry to avoid partial cacheline write by HW. But, as the >> padding is ahead of completion da

Re: [dpdk-dev] [dpdk-stable] [PATCH 1/3] net/ixgbe: fix lsc interrupt

2017-07-18 Thread Ferruh Yigit
<...> > If LSC flag is changed to off last device start, the enable flag is not > cleared in HW. > This patch fixes it. > > Fixes: 0eb609239efd ("ixgbe: enable Rx queue interrupts for PF and VF") > Cc: sta...@dpdk.org > > Signed-off-by: Jingjing Wu > Acked-by: Wenzhuo Lu Series applied to dpd

Re: [dpdk-dev] [PATCH] crypto/qat: fix handle device-agnostic session

2017-07-18 Thread De Lara Guarch, Pablo
> -Original Message- > From: Trahe, Fiona > Sent: Tuesday, July 18, 2017 9:22 AM > To: Kusztal, ArkadiuszX ; dev@dpdk.org > Cc: De Lara Guarch, Pablo ; Griffin, John > ; Jain, Deepak K > Subject: RE: [PATCH] crypto/qat: fix handle device-agnostic session > > > > > -Original Messag

Re: [dpdk-dev] [PATCH v10 03/11] net/failsafe: add fail-safe PMD

2017-07-18 Thread Ferruh Yigit
On 7/18/2017 12:17 AM, Gaëtan Rivet wrote: <...> > > I fixed all other remarks. I will wait a little for any possible > additional changes you might want to point before sending the new > version. OK, there were some patches from Thomas addition to failsafe patchset, are they all clarified, merg

Re: [dpdk-dev] [RFC 11/14] liquidio: use _rte_eth_link_update

2017-07-18 Thread Shijith Thotton
On Fri, Jul 14, 2017 at 11:30:24AM -0700, Stephen Hemminger wrote: > Use the new link update API, and cleanup the logic in the the > link update routine. > > Signed-off-by: Stephen Hemminger > --- > drivers/net/liquidio/lio_ethdev.c | 76 > ++- > 1 file chang

Re: [dpdk-dev] [PATCH v2] net/i40e: add checking invalid VF queue id for FDIR

2017-07-18 Thread Ferruh Yigit
On 7/14/2017 7:51 AM, Beilei Xing wrote: > There's only invalid queue id checking for PF when creating FDIR > rules, this patch adds checking invalid queue id for VF. > > Signed-off-by: Beilei Xing Applied to dpdk-next-net/master, thanks.

Re: [dpdk-dev] [PATCH v2] crypto/dpaa2_sec: fix the return of supported API

2017-07-18 Thread De Lara Guarch, Pablo
Hi Akhil, > -Original Message- > From: Akhil Goyal [mailto:akhil.go...@nxp.com] > Sent: Tuesday, July 18, 2017 8:34 AM > To: dev@dpdk.org; sta...@dpdk.org > Cc: hemant.agra...@nxp.com; De Lara Guarch, Pablo > ; y...@fridaylinux.org; Akhil Goyal > > Subject: [PATCH v2] crypto/dpaa2_sec: fi

[dpdk-dev] [PATCH v1] crypto/scheduler: fix multicore scheduler reordering

2017-07-18 Thread Kirill Rybalchenko
Operations can be dequeued from the reordering ring only after they were dequeued from the crypto pmd with rte_cryptodev_dequeue_burst() function. It is not correct to dequeue them when status just changed from RTE_CRYPTO_OP_STATUS_NOT_PROCESSED to any other value, as the operations still can be pr

Re: [dpdk-dev] [PATCH] net/ixgbe: add queue index check in filter

2017-07-18 Thread Ferruh Yigit
On 7/17/2017 7:13 AM, Wei Zhao wrote: > Add queue index check when create filter rule, or > filter with invalid queue id can be created successfully. > > Signed-off-by: Wei Zhao <...> > @@ -1177,6 +1178,9 @@ ixgbe_parse_l2_tn_filter(struct rte_eth_dev *dev, > return -rte_errno; >

Re: [dpdk-dev] [PATCH v4 05/12] linuxapp/eal_pci: get iommu class

2017-07-18 Thread Hemant Agrawal
On 7/18/2017 11:29 AM, Santosh Shukla wrote: Get iommu class of PCI device on the bus and returns preferred iova mapping mode for that bus. Algorithm for iova scheme selection for PCI bus: 0. If no device bound then return with RTE_IOVA_DC mapping mode, else goto 1). 1. Look for device attached

Re: [dpdk-dev] [PATCH v10 03/11] net/failsafe: add fail-safe PMD

2017-07-18 Thread Gaëtan Rivet
On Tue, Jul 18, 2017 at 11:13:34AM +0100, Ferruh Yigit wrote: > On 7/18/2017 12:17 AM, Gaëtan Rivet wrote: > <...> > > > > > I fixed all other remarks. I will wait a little for any possible > > additional changes you might want to point before sending the new > > version. > > OK, there were some

Re: [dpdk-dev] [PATCH] net/virtio: fix coding style

2017-07-18 Thread Ferruh Yigit
On 7/17/2017 7:35 AM, Tiwei Bie wrote: > Make the code more readable. No functional change. > > Signed-off-by: Tiwei Bie Applied to dpdk-next-net/master, thanks.

Re: [dpdk-dev] [PATCH] net/ixgbe: remove an unnecessary goto

2017-07-18 Thread Ferruh Yigit
On 7/17/2017 7:29 AM, Tiwei Bie wrote: > Signed-off-by: Tiwei Bie Applied to dpdk-next-net/master, thanks.

Re: [dpdk-dev] [PATCH] net/i40e: remove an unnecessary goto

2017-07-18 Thread Ferruh Yigit
On 7/18/2017 4:18 AM, Xing, Beilei wrote: >> -Original Message- >> From: Bie, Tiwei >> Sent: Monday, July 17, 2017 2:27 PM >> To: Wu, Jingjing ; Xing, Beilei >> ; dev@dpdk.org >> Cc: Bie, Tiwei >> Subject: [PATCH] net/i40e: remove an unnecessary goto >> >> Signed-off-by: Tiwei Bie > Acke

Re: [dpdk-dev] [PATCH v4 06/12] bus: get iommu class

2017-07-18 Thread Hemant Agrawal
On 7/18/2017 11:29 AM, Santosh Shukla wrote: API(rte_bus_get_iommu_class) helps to automatically detect and select appropriate iova mapping scheme for iommu capable device on that bus. Algorithm for iova scheme selection for bus: 0. Iterate through bus_list. 1. Collect each bus iova mode value a

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/i40e: fix virtchnl message response timeout

2017-07-18 Thread Ferruh Yigit
On 7/17/2017 8:33 AM, Beilei Xing wrote: > PF driver and VF driver communicated with each other by virtual > channel message. When VF sends message to PF to enable some > offload capability, PF should response if it is successful or not. > VIRTCHNL_OP_ENABLE_VLAN_STRIPPING is a new added message an

Re: [dpdk-dev] [PATCH v4 06/12] bus: get iommu class

2017-07-18 Thread santosh
Hi Hemant, On Tuesday 18 July 2017 04:35 PM, Hemant Agrawal wrote: > On 7/18/2017 11:29 AM, Santosh Shukla wrote: >> API(rte_bus_get_iommu_class) helps to automatically detect and select >> appropriate iova mapping scheme for iommu capable device on that bus. >> >> Algorithm for iova scheme selec

[dpdk-dev] [PATCH] crypto/scheduler: update documenation for multicore scheduler

2017-07-18 Thread Kirill Rybalchenko
Done more clear explanation of usage of corelist parameter. Signed-off-by: Kirill Rybalchenko --- doc/guides/cryptodevs/scheduler.rst | 2 ++ 1 file changed, 2 insertions(+) diff --git a/doc/guides/cryptodevs/scheduler.rst b/doc/guides/cryptodevs/scheduler.rst index f3ee88a..3ba0188 100644 ---

Re: [dpdk-dev] [PATCH v4 08/12] linuxapp/eal: auto detect iova mode

2017-07-18 Thread Hemant Agrawal
On 7/18/2017 11:29 AM, Santosh Shukla wrote: - Moving late bus scanning to up..just after eal_parsing. - Auto detect iova mapping mode, based on the result of rte_bus_scan_iommu_class. Signed-off-by: Santosh Shukla Signed-off-by: Jerin Jacob --- lib/librte_eal/linuxapp/eal/eal.c | 15 ++

Re: [dpdk-dev] [PATCH] net/dpaa2: add support for secondary process attach

2017-07-18 Thread Ferruh Yigit
On 7/17/2017 9:48 AM, Hemant Agrawal wrote: > Signed-off-by: Hemant Agrawal Applied to dpdk-next-net/master, thanks.

Re: [dpdk-dev] [PATCH] net/ixgbe: fix drop action for signature match

2017-07-18 Thread Ferruh Yigit
On 7/17/2017 12:46 PM, Qi Zhang wrote: > Drop action is not supported by signature match, should return > error when try to create a signature match flow with drop action. > > Fixes: a948d33bc05a ("net/ixgbe: enable signature match for consistent API") > > Signed-off-by: Qi Zhang Applied to dpd

Re: [dpdk-dev] [PATCH] net/e1000: always enable receive and transmit

2017-07-18 Thread Ferruh Yigit
On 7/17/2017 8:18 PM, Charles (Chas) Williams wrote: > The transmit and receive controller state machines are only enabled after > receiving an interrupt and the link status is now valid. If an adapter > is being used in conjuction with NC-SI, network controller sideband > interface, the adapter m

Re: [dpdk-dev] [PATCH 0/2] Some small changes to net/virtio

2017-07-18 Thread Ferruh Yigit
On 7/18/2017 12:05 AM, Charles (Chas) Williams wrote: > Just a couple small changes to net/virtio that make it a little more > well behaved. Same question here, is this patchset targets the 17.08-rc2? Can this be postponed? > > Brian Russell (1): > net/virtio: register/unregister intr handler

Re: [dpdk-dev] [PATCH 0/2] Some small changes to net/virtio

2017-07-18 Thread Charles (Chas) Williams
On 07/18/2017 07:50 AM, Ferruh Yigit wrote: On 7/18/2017 12:05 AM, Charles (Chas) Williams wrote: Just a couple small changes to net/virtio that make it a little more well behaved. Same question here, is this patchset targets the 17.08-rc2? Can this be postponed? Yes, these can all be post

Re: [dpdk-dev] [PATCH v3] net/tap: remove Linux version check

2017-07-18 Thread Pascal Mazon
Ok for me. Cheers, Pascal Acked-by: Pascal Mazon On 07/17/2017 11:00 AM, Raslan Darawsheh wrote: Remove checks of Linux kernel version in order to support kernel with backported features. the expected behavior with a kernel that doesn't support flower and other bits is the following:

Re: [dpdk-dev] [PATCH v4 08/12] linuxapp/eal: auto detect iova mode

2017-07-18 Thread santosh
On Tuesday 18 July 2017 05:04 PM, Hemant Agrawal wrote: > On 7/18/2017 11:29 AM, Santosh Shukla wrote: >> - Moving late bus scanning to up..just after eal_parsing. >> - Auto detect iova mapping mode, based on the result of >> rte_bus_scan_iommu_class. >> >> Signed-off-by: Santosh Shukla >> Sign

[dpdk-dev] [PATCH] doc/metrics: fix variable undefined error

2017-07-18 Thread Yong Wang
Signed-off-by: Yong Wang --- doc/guides/prog_guide/metrics_lib.rst | 1 + 1 file changed, 1 insertion(+) diff --git a/doc/guides/prog_guide/metrics_lib.rst b/doc/guides/prog_guide/metrics_lib.rst index 702c29d..d52204f 100644 --- a/doc/guides/prog_guide/metrics_lib.rst +++ b/doc/guides/prog_gui

[dpdk-dev] librte_net/rte_ip.h checksum functions question

2017-07-18 Thread Ido Barnea (ibarnea)
Hi, Is it intentional that rte_ipv4_phdr_cksum and others in this file assume that ipv4 header is sizeof(struct ipv4_hdr), actually assuming that there are no IPv4 options? If not, I would like to submit a patch changing that. Something in the line of: sizeof(struct ipv4_hdr) changes to ipv4_hdr-

Re: [dpdk-dev] [PATCH] net/virtio: fix coding style

2017-07-18 Thread Ferruh Yigit
On 7/18/2017 12:04 PM, Ferruh Yigit wrote: > On 7/17/2017 7:35 AM, Tiwei Bie wrote: >> Make the code more readable. No functional change. >> >> Signed-off-by: Tiwei Bie > > Applied to dpdk-next-net/master, thanks. And indeed this should go in via next-virtio, I confused it. Yuanhan, Please let

Re: [dpdk-dev] [PATCH v3] net/tap: remove Linux version check

2017-07-18 Thread Ferruh Yigit
<...> > On 07/17/2017 11:00 AM, Raslan Darawsheh wrote: >> Remove checks of Linux kernel version >> in order to support kernel with backported features. >> >> the expected behavior with a kernel that doesn't support flower >> and other bits is the following: >> -flow validate can return su

Re: [dpdk-dev] [PATCH] net/virtio: fix coding style

2017-07-18 Thread Yuanhan Liu
On Tue, Jul 18, 2017 at 01:29:48PM +0100, Ferruh Yigit wrote: > On 7/18/2017 12:04 PM, Ferruh Yigit wrote: > > On 7/17/2017 7:35 AM, Tiwei Bie wrote: > >> Make the code more readable. No functional change. > >> > >> Signed-off-by: Tiwei Bie > > > > Applied to dpdk-next-net/master, thanks. > > An

[dpdk-dev] [PATCH v11 01/11] ethdev: add deferred intermediate device state

2017-07-18 Thread Gaetan Rivet
This device state means that the device is managed externally, by whichever party has set this state (PMD or application). Note: this new device state is only an information. The related device structure and operators are still valid and can be used normally. It is however made private by device

[dpdk-dev] [PATCH v11 00/11] introduce fail-safe PMD

2017-07-18 Thread Gaetan Rivet
This PMD intercepts and manages Ethernet device removal events issued by slave PMDs and re-initializes them transparently when brought back so that existing applications do not need to be modified to benefit from true hot-plugging support. The stacked PMD approach shares many similarities with the

[dpdk-dev] [PATCH v11 02/11] ethdev: count devices consistently

2017-07-18 Thread Gaetan Rivet
Make the rte_eth_dev_count() return the number of available devices even after some are detached by the hotplug API or put in a deferred state. Signed-off-by: Gaetan Rivet --- lib/librte_ether/rte_ethdev.c | 16 +--- lib/librte_ether/rte_ethdev.h | 13 ++--- 2 files changed,

[dpdk-dev] [PATCH v11 03/11] net/failsafe: add fail-safe PMD

2017-07-18 Thread Gaetan Rivet
Introduce the fail-safe poll mode driver initialization and enable its build infrastructure. This PMD allows for applications to benefit from true hot-plugging support without having to implement it. It intercepts and manages Ethernet device removal events issued by slave PMDs and re-initializes

[dpdk-dev] [PATCH v11 05/11] net/failsafe: add flexible device definition

2017-07-18 Thread Gaetan Rivet
Add the "exec" device type. The parameters given to this type of device will be executed in a shell. The output of this command is then used as a definition for a device. That command can be re-interpreted if the related device is not plugged-in. It allows for a device definition to react to syste

[dpdk-dev] [PATCH v11 04/11] net/failsafe: add plug-in support

2017-07-18 Thread Gaetan Rivet
Periodically check for the existence of a device. If a device has not been initialized and exists on the system, then it is probed and configured. The configuration process strives to synchronize the states between the plugged-in sub-device and the fail-safe device. Signed-off-by: Gaetan Rivet A

[dpdk-dev] [PATCH v11 07/11] net/failsafe: support Rx offload capabilities

2017-07-18 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet Acked-by: Olga Shern --- drivers/net/failsafe/failsafe_ops.c | 131 +++- 1 file changed, 129 insertions(+), 2 deletions(-) diff --git a/drivers/net/failsafe/failsafe_ops.c b/drivers/net/failsafe/failsafe_ops.c index 223f26a..ac3257e 1

[dpdk-dev] [PATCH v11 06/11] net/failsafe: support flow API

2017-07-18 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet Acked-by: Olga Shern --- doc/guides/nics/features/failsafe.ini | 1 + drivers/net/failsafe/Makefile | 1 + drivers/net/failsafe/failsafe.c | 1 + drivers/net/failsafe/failsafe_eal.c | 1 + drivers/net/failsafe/failsafe_ether.c | 70 +

[dpdk-dev] [PATCH v11 08/11] net/failsafe: add fast burst functions

2017-07-18 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet Acked-by: Olga Shern --- drivers/net/failsafe/failsafe_private.h | 8 +++ drivers/net/failsafe/failsafe_rxtx.c| 123 ++-- 2 files changed, 111 insertions(+), 20 deletions(-) diff --git a/drivers/net/failsafe/failsafe_private.h b/dri

[dpdk-dev] [PATCH v11 09/11] net/failsafe: support device removal

2017-07-18 Thread Gaetan Rivet
Listen to INTR_RMV events issued by slaves. Add atomic flags on slave queues to detect use of slave bursts function. If a removal is detected, set the recollection flag on this slave. During a slave upkeep round, if its recollection flag is set and its burst functions are not in use by any thread,

[dpdk-dev] [PATCH v11 10/11] net/failsafe: support link status change event

2017-07-18 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet --- doc/guides/nics/features/failsafe.ini | 1 + drivers/net/failsafe/failsafe.c | 1 + drivers/net/failsafe/failsafe_ether.c | 18 ++ drivers/net/failsafe/failsafe_ops.c | 23 +++ drivers/net/failsafe/failsafe_priv

[dpdk-dev] [PATCH v11 11/11] net/failsafe: support flow API isolation mode

2017-07-18 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet --- drivers/net/failsafe/failsafe_ether.c | 34 +++-- drivers/net/failsafe/failsafe_flow.c| 29 drivers/net/failsafe/failsafe_private.h | 4 3 files changed, 65 insertions(+), 2 deletions(-) diff --g

Re: [dpdk-dev] [PATCH] doc/metrics: fix variable undefined error

2017-07-18 Thread Remy Horton
On 18/07/2017 13:03, Yong Wang wrote: Signed-off-by: Yong Wang --- doc/guides/prog_guide/metrics_lib.rst | 1 + 1 file changed, 1 insertion(+) Acked-by: Remy Horton

Re: [dpdk-dev] Occasional instability in RSS Hashes/Queues from X540 NIC

2017-07-18 Thread Matt Laswell
Hi Qiming, That's fantastic news. Thank you very much for taking the time to figure the issue out. Would it be possible to backport the fix to the 16.11 LTS release? This kind of problem seems tailor-made for LTS. -- Matt Laswell lasw...@infinite.io On Tue, Jul 18, 2017 at 3:58 AM, Yang, Qi

Re: [dpdk-dev] [PATCH v3 ] ethdev: introduce lock-free txq capability flag

2017-07-18 Thread Thomas Monjalon
13/07/2017 15:02, Hemant Agrawal: > On 7/10/2017 10:29 PM, Jerin Jacob wrote: > > Introducing the DEV_TX_OFFLOAD_MT_LOCKFREE TX capability flag. > > if a PMD advertises DEV_TX_OFFLOAD_MT_LOCKFREE capable, multiple threads > > can invoke rte_eth_tx_burst() concurrently on the same tx queue without >

Re: [dpdk-dev] [PATCH] crypto/scheduler: update documenation for multicore scheduler

2017-07-18 Thread De Lara Guarch, Pablo
Hi Kirill, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Kirill Rybalchenko > Sent: Tuesday, July 18, 2017 12:32 PM > To: Zhang, Roy Fan ; Doherty, Declan > > Cc: dev@dpdk.org; Rybalchenko, Kirill > Subject: [dpdk-dev] [PATCH] crypto/scheduler: update docume

Re: [dpdk-dev] [PATCH 1/3] cryptodev: modify some field sizes

2017-07-18 Thread De Lara Guarch, Pablo
> -Original Message- > From: Trahe, Fiona > Sent: Tuesday, July 18, 2017 9:18 AM > To: De Lara Guarch, Pablo ; Doherty, > Declan > Cc: dev@dpdk.org; De Lara Guarch, Pablo > > Subject: RE: [dpdk-dev] [PATCH 1/3] cryptodev: modify some field sizes > > > > > -Original Message- >

Re: [dpdk-dev] [PATCH 3/3] cryptodev: reorder auth transform

2017-07-18 Thread De Lara Guarch, Pablo
> -Original Message- > From: Trahe, Fiona > Sent: Tuesday, July 18, 2017 9:20 AM > To: De Lara Guarch, Pablo ; Doherty, > Declan > Cc: dev@dpdk.org; De Lara Guarch, Pablo > > Subject: RE: [dpdk-dev] [PATCH 3/3] cryptodev: reorder auth transform > > > > > -Original Message- >

Re: [dpdk-dev] [PATCH 2/3] cryptodev: rename field name

2017-07-18 Thread De Lara Guarch, Pablo
> -Original Message- > From: Trahe, Fiona > Sent: Tuesday, July 18, 2017 9:17 AM > To: De Lara Guarch, Pablo ; Doherty, > Declan > Cc: dev@dpdk.org; De Lara Guarch, Pablo > > Subject: RE: [dpdk-dev] [PATCH 2/3] cryptodev: rename field name > > > > > -Original Message- > > Fro

Re: [dpdk-dev] Occasional instability in RSS Hashes/Queues from X540 NIC

2017-07-18 Thread Yuanhan Liu
On Tue, Jul 18, 2017 at 08:43:42AM -0500, Matt Laswell wrote: > Hi Qiming, > > That's fantastic news. Thank you very much for taking the time to figure > the issue out. > > Would it be possible to backport the fix to the 16.11 LTS release? This > kind of problem seems tailor-made for LTS. Agr

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/i40e: fix ethertype filter issue for new FW

2017-07-18 Thread Ferruh Yigit
On 7/18/2017 4:07 AM, Beilei Xing wrote: > SW workaround for GL_SWR_PRI_JOIN_MAP is added for X710 > performance before. As new FW version 6.0 supports ADQ, > value for GL_SWR_PRI_JOIN_MAP should be changed, otherwise > ehtertype filter will be impacted. > > Fixes: 973273c7a4b7 ("i40e: workaround

Re: [dpdk-dev] [PATCH] crypto/scheduler: fix buffer not null terminated

2017-07-18 Thread De Lara Guarch, Pablo
> -Original Message- > From: De Lara Guarch, Pablo > Sent: Tuesday, July 18, 2017 2:41 AM > To: Zhang, Roy Fan ; Doherty, Declan > > Cc: dev@dpdk.org; De Lara Guarch, Pablo > ; sta...@dpdk.org > Subject: [PATCH] crypto/scheduler: fix buffer not null terminated > > Coverity issue: 143431

Re: [dpdk-dev] [PATCH] crypto/scheduler: update documenation for multicore scheduler

2017-07-18 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Kirill Rybalchenko > Sent: Tuesday, July 18, 2017 12:32 PM > To: Zhang, Roy Fan ; Doherty, Declan > > Cc: dev@dpdk.org; Rybalchenko, Kirill > Subject: [dpdk-dev] [PATCH] crypto/scheduler: update documenation for

Re: [dpdk-dev] [PATCH v4] examples/vhost: introduce a new vhost-user-scsi sample application

2017-07-18 Thread Thomas Monjalon
Hi, 15/07/2017 11:20, Changpeng Liu: > --- /dev/null > +++ b/examples/vhost_scsi/scsi_spec.h > @@ -0,0 +1,488 @@ > +/*- > + * BSD LICENSE > + * > + * Copyright (c) Intel Corporation. > + * All rights reserved. > + * > + * Redistribution and use in source and binary forms, with or without >

Re: [dpdk-dev] [PATCH] net/ixgbe: add support 82599ES SCTP packet drop action

2017-07-18 Thread Ferruh Yigit
On 7/18/2017 7:10 AM, Wei Zhao wrote: > 82599ES can support SCTP packet drop action, but the > configration is different from TCP or UDP packet, so > it need to rework some code FDIR related code to adapt > drop action rule of SCTP packet. > > Signed-off-by: Wei Zhao Applied to dpdk-next-net/mas

Re: [dpdk-dev] [PATCH] mempool/dpaa2: alloc pool data dynamically

2017-07-18 Thread Shreyansh Jain
On Thursday 13 July 2017 07:48 PM, Hemant Agrawal wrote: In order to support multiprocess applications, pool data is to be allocated on dynamic memory instead of existing usages of global variable. Signed-off-by: Nipun Gupta --- Acked-by: Shreyansh Jain

Re: [dpdk-dev] [PATCH v2 2/2] mempool/dpaa2: fix the incorrect free usages for bplist

2017-07-18 Thread Shreyansh Jain
On Thursday 22 June 2017 06:18 PM, Hemant Agrawal wrote: The dpaa2_bp_list is being allocated using "rte_malloc", but the free is done using "free". Fixing it to use "rte_free". Fixes: 5dc43d22b5ad ("mempool/dpaa2: add hardware offloaded mempool") CC: sta...@dpdk.org Signed-off-by: Hemant Agraw

Re: [dpdk-dev] [PATCH v2 1/2] mempool/dpaa2: fix the return value for alloc fail

2017-07-18 Thread Shreyansh Jain
On Thursday 22 June 2017 06:18 PM, Hemant Agrawal wrote: In case the alloc api is not able to allocate the required number of buffer, it can return '0', which will not indicate the failure to the calling function. This patch fix the return value to indicate the failure. Fixes: 5dc43d22b5ad ("mem

Re: [dpdk-dev] [PATCH v2] crypto/dpaa2_sec: fix the return of supported API

2017-07-18 Thread Yuanhan Liu
On Tue, Jul 18, 2017 at 10:26:39AM +, De Lara Guarch, Pablo wrote: > Hi Akhil, > > > -Original Message- > > From: Akhil Goyal [mailto:akhil.go...@nxp.com] > > Sent: Tuesday, July 18, 2017 8:34 AM > > To: dev@dpdk.org; sta...@dpdk.org > > Cc: hemant.agra...@nxp.com; De Lara Guarch, Pabl

[dpdk-dev] [RFC v3] ethdev: add IF-MIB attributes implementation

2017-07-18 Thread Reshma Pattan
The RFC shows implementation of IF-MIB attributes in ethdev layer. These attributes are implemented from the information available from rte_eth_dev_data struct. The new APIs are added, to allow applications to trigger IF-MIB attribute initialization and the implementation based on the port id. IF-

Re: [dpdk-dev] [PATCH v2] eal/armv8: fix poly64/128 compile issue in old GCC(<4.9.0)

2017-07-18 Thread Thomas Monjalon
13/07/2017 05:16, Herbert Guan: > --- a/lib/librte_eal/common/include/arch/arm/rte_vect.h > +++ b/lib/librte_eal/common/include/arch/arm/rte_vect.h > +#if (GCC_VERSION < 40900) > +typedef uint64_t poly64_t; > +typedef uint64x2_t poly64x2_t; > +typedef uint8_t poly128_t __attribute__((vector_size(16

Re: [dpdk-dev] [PATCH] net/ixgbe: fix ipv6 flow create limitation for x550

2017-07-18 Thread Ferruh Yigit
On 7/18/2017 12:37 PM, Qi Zhang wrote: > The x550 family does not support ipv6-other flow as well as > ipv4-other flow, so add this limitation. > > Fixes: 7d629cacedee ("net/ixgbe: enable IPv6 for consistent API") > > Signed-off-by: Qi Zhang Applied to dpdk-next-net/master, thanks.

Re: [dpdk-dev] [PATCH] net/ixgbe: support detection of hot swapped SFP/SFP+

2017-07-18 Thread Dai, Wei
HI, Srini Sorry for late response. As I have pointed out that Ixgbe_reset_hw_82599( ) calls hw->phy.ops.init(hw) unconditionally, I think it is no need to call hw->phy.ops.init(hw) after ixgbe_pf_reset_hw(hw) at least for 82599. I also think that only moving "hw->phy.type = ixgbe_phy_unknown" j

Re: [dpdk-dev] [PATCH v3] doc: add known issue for i40e VF performance

2017-07-18 Thread Ferruh Yigit
On 7/18/2017 10:52 AM, Qi Zhang wrote: > VF performance is limited by the kernel PCI extended tag setting. > Update the document to explain the known issue and the workaround. > > Signed-off-by: Qi Zhang Applied to dpdk-next-net/master, thanks.

[dpdk-dev] [RFC 0/6] virtio1.1 prototype updates

2017-07-18 Thread Tiwei Bie
This patchset depends on below patchset: http://dpdk.org/ml/archives/dev/2017-June/068315.html I'll also collect these public patches into my github repo: https://github.com/btw616/dpdk-virtio1.1 Best regards, Tiwei Bie Tiwei Bie (6): net/virtio: optimize the rx path vhost: optimize enqueu

[dpdk-dev] [RFC 2/6] vhost: optimize enqueue path

2017-07-18 Thread Tiwei Bie
Signed-off-by: Tiwei Bie --- lib/librte_vhost/virtio_net.c | 185 -- 1 file changed, 88 insertions(+), 97 deletions(-) diff --git a/lib/librte_vhost/virtio_net.c b/lib/librte_vhost/virtio_net.c index c0b4dde..0888d2b 100644 --- a/lib/librte_vhost/virtio_ne

[dpdk-dev] [RFC 1/6] net/virtio: optimize the rx path

2017-07-18 Thread Tiwei Bie
Signed-off-by: Tiwei Bie --- drivers/net/virtio/virtio_ethdev.c | 5 +- drivers/net/virtio/virtio_ethdev.h | 2 + drivers/net/virtio/virtio_rxtx.c | 255 - 3 files changed, 142 insertions(+), 120 deletions(-) diff --git a/drivers/net/virtio/virtio_ethdev

[dpdk-dev] [RFC 4/6] net/virtio: revert the changes in 18dc1b1ac

2017-07-18 Thread Tiwei Bie
Revert the changes in 18dc1b1ac, because we want to test the performance similar to the real world case. Signed-off-by: Tiwei Bie --- drivers/net/virtio/virtio_rxtx.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/net/virtio/virtio_rxtx.c b/drivers/net/virti

[dpdk-dev] [RFC 3/6] net/virtio: optimize the tx path

2017-07-18 Thread Tiwei Bie
Signed-off-by: Tiwei Bie --- drivers/net/virtio/virtio_rxtx_1.1.c | 65 1 file changed, 28 insertions(+), 37 deletions(-) diff --git a/drivers/net/virtio/virtio_rxtx_1.1.c b/drivers/net/virtio/virtio_rxtx_1.1.c index 4602e6d..883a027 100644 --- a/drivers/net

[dpdk-dev] [RFC 5/6] vhost: minor refinement

2017-07-18 Thread Tiwei Bie
Manually prefetch the first desc in dequeue path. Signed-off-by: Tiwei Bie --- lib/librte_vhost/virtio_net.c | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/librte_vhost/virtio_net.c b/lib/librte_vhost/virtio_net.c index 0888d2b..08d53d9 100644 --- a/lib/librte_vhost/virtio_net.c +++ b/l

[dpdk-dev] [RFC 6/6] virtio1.1: introduce the DESC_WB flag

2017-07-18 Thread Tiwei Bie
This patch introduces the DESC_WB flag, and adopts it in the virtio Tx path. This flag can help to reduce the memory write operations on the descriptor ring from the backend. So it could help to reduce the PCIe transactions in a hardware backend case. Normally the DESC_WB like mechanism is used in

[dpdk-dev] [PATCH 0/3] L2fwd-crypto fixes

2017-07-18 Thread Pablo de Lara
After the changes added to include AEAD algorithm specific parameters, there were some parameters that were being set wrong or not even set. Pablo de Lara (3): examples/l2fwd-crypto: fix digest length examples/l2fwd-crypto: fix AEAD IV setting examples/l2fwd-crypto: fix AEAD key setting ex

[dpdk-dev] [PATCH 1/3] examples/l2fwd-crypto: fix digest length

2017-07-18 Thread Pablo de Lara
Digest length was not being set when using authentication algorithms. Fixes: 2661f4fbe93d ("examples/l2fwd-crypto: add AEAD parameters") Signed-off-by: Pablo de Lara --- examples/l2fwd-crypto/main.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/examples/l2fwd-crypto/main.c b/examples/l2

[dpdk-dev] [PATCH 2/3] examples/l2fwd-crypto: fix AEAD IV setting

2017-07-18 Thread Pablo de Lara
IV was not being set for AEAD algorithms. Fixes: 2661f4fbe93d ("examples/l2fwd-crypto: add AEAD parameters") Signed-off-by: Pablo de Lara --- examples/l2fwd-crypto/main.c | 5 + 1 file changed, 5 insertions(+) diff --git a/examples/l2fwd-crypto/main.c b/examples/l2fwd-crypto/main.c index 6

[dpdk-dev] [PATCH 3/3] examples/l2fwd-crypto: fix AEAD key setting

2017-07-18 Thread Pablo de Lara
AEAD key was being set using the cipher key parameters, instead of the AEAD key parameters. Fixes: 2661f4fbe93d ("examples/l2fwd-crypto: add AEAD parameters") Signed-off-by: Pablo de Lara --- examples/l2fwd-crypto/main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ex

Re: [dpdk-dev] [PATCH v11 01/11] ethdev: add deferred intermediate device state

2017-07-18 Thread Thomas Monjalon
18/07/2017 15:48, Gaetan Rivet: > This device state means that the device is managed externally, by > whichever party has set this state (PMD or application). > > Note: this new device state is only an information. The related device > structure and operators are still valid and can be used normal

Re: [dpdk-dev] [PATCH v11 02/11] ethdev: count devices consistently

2017-07-18 Thread Thomas Monjalon
18/07/2017 15:48, Gaetan Rivet: > Make the rte_eth_dev_count() return the number of available devices even > after some are detached by the hotplug API or put in a deferred state. > > Signed-off-by: Gaetan Rivet Acked-by: Thomas Monjalon Ferruh, it can be taken in next-net as part of failsafe

Re: [dpdk-dev] [PATCH v11 00/11] introduce fail-safe PMD

2017-07-18 Thread Ferruh Yigit
On 7/18/2017 1:48 PM, Gaetan Rivet wrote: > This PMD intercepts and manages Ethernet device removal events issued by > slave PMDs and re-initializes them transparently when brought back so that > existing applications do not need to be modified to benefit from true > hot-plugging support. > > The

Re: [dpdk-dev] [PATCH v2] test: Fix memory corruption issues which fails the link_bonding test.

2017-07-18 Thread Ferruh Yigit
On 7/10/2017 12:13 PM, Herbert Guan wrote: > Patch V2: fix build warnings by deleting unused variables. > > There were double-free problems in some test cases, which will cause > a duplicated mbuf will be added into mempool. After double-free, > some new allocated mbuf will hold a same address

Re: [dpdk-dev] [PATCH v2] crypto/dpaa2_sec: fix the return of supported API

2017-07-18 Thread De Lara Guarch, Pablo
HI Yuanhan, > -Original Message- > From: Yuanhan Liu [mailto:y...@fridaylinux.org] > Sent: Tuesday, July 18, 2017 3:39 PM > To: De Lara Guarch, Pablo > Cc: Akhil Goyal ; dev@dpdk.org; sta...@dpdk.org; > hemant.agra...@nxp.com > Subject: Re: [PATCH v2] crypto/dpaa2_sec: fix the return of s

Re: [dpdk-dev] [PATCH v2] crypto/dpaa2_sec: fix the return of supported API

2017-07-18 Thread Hemant Agrawal
HI Yuanhan, > > > > -Original Message- > > > > From: Akhil Goyal [mailto:akhil.go...@nxp.com] > > > > Sent: Tuesday, July 18, 2017 8:34 AM > > > > To: dev@dpdk.org; sta...@dpdk.org > > > > Cc: hemant.agra...@nxp.com; De Lara Guarch, Pablo > > > > ; y...@fridaylinux.org; Akhil > > > > Goyal

Re: [dpdk-dev] [PATCH] net/failsafe: do not probe device if plugged out

2017-07-18 Thread Thomas Monjalon
18/07/2017 11:39, Ferruh Yigit: > On 7/13/2017 10:17 AM, Thomas Monjalon wrote: > > 13/07/2017 10:14, Gaëtan Rivet: > >> On Thu, Jul 13, 2017 at 08:52:33AM +0200, Thomas Monjalon wrote: > >>> 12/07/2017 22:39, Gaëtan Rivet: > Hi Thomas, > > Nice idea. A few remarks below: > > >>

  1   2   >