Re: [dpdk-dev] [PATCH v14 0/3] Support TCP/IPv4 GRO in DPDK

2017-07-10 Thread Thomas Monjalon
10/07/2017 04:21, Hu, Jiayu: > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > I have added an EXPERIMENTAL note in MAINTAINERS file. > > I have added the library in the doxygen doc and in the release notes > > libraries list. > > > > Applied with above changes, thanks > > > > A page in th

Re: [dpdk-dev] [PATCH] net/tap: add missing newlines in logs

2017-07-10 Thread Pascal Mazon
Acked-by: Pascal Mazon On 07/06/2017 05:28 PM, Thomas Monjalon wrote: Some logs are missing the newline character \n. The logs using only line can be checked with this command: git grep 'RTE_LOG(.*".*[^n]"' drivers/net/tap/ Fixes: 02f96a0a82d1 ("net/tap: add TUN/TAP device PMD") Fixes

Re: [dpdk-dev] [PATCH v2] igb_uio: issue FLR during open and release of device file

2017-07-10 Thread Shijith Thotton
On Mon, Jul 10, 2017 at 03:38:34AM +, Tan, Jianfeng wrote: > Hi Thotton, > > > -Original Message- > > From: Shijith Thotton [mailto:shijith.thot...@caviumnetworks.com] > > Sent: Friday, July 7, 2017 7:14 PM > > To: dev@dpdk.org > > Cc: Yigit, Ferruh; Gregory Etelson; Thomas Monjalon; S

Re: [dpdk-dev] [dpdk-announce] release candidate 17.08-rc1

2017-07-10 Thread Morten Brørup
> -Original Message- > From: announce [mailto:announce-boun...@dpdk.org] On Behalf Of Thomas > Monjalon > Sent: Monday, July 10, 2017 1:58 AM > To: annou...@dpdk.org > Subject: [dpdk-announce] release candidate 17.08-rc1 > > > You can read the release notes in progress: > http://dpd

[dpdk-dev] [PATCH] test: Fix memory corruption issues which fails the link_bonding test.

2017-07-10 Thread Herbert Guan
There were double-free problems in some test cases of link_bonding, which will cause a duplicated mbuf will be added into mempool. After double-free, some new allocated mbuf will hold a same address and thus cause the memory corruption. Another minor issue is that in some test cases, allocated m

Re: [dpdk-dev] [dpdk-announce] release candidate 17.08-rc1

2017-07-10 Thread Thomas Monjalon
10/07/2017 09:16, Morten Brørup: > > > > You can read the release notes in progress: > > http://dpdk.org/doc/guides/rel_notes/release_17_08.html > > Some highlights: > > - x86 requires SSE4.2 > > And nobody thought this was worth mentioning in the Release Notes or the > Roadmap? Yes, yo

Re: [dpdk-dev] [PATCH] eal/armv7: emulate vaddvq u16 variant

2017-07-10 Thread Thomas Monjalon
10/07/2017 05:51, Jianbo Liu: > On 9 July 2017 at 01:08, Thomas Monjalon wrote: > > 07/07/2017 18:26, Jerin Jacob: > >> vaddvq_u16() is not available for armv7. > >> Emulate the vaddvq_u16() using armv7 NEON intrinsics. > > > > After implementing this function, another missing function appears: >

Re: [dpdk-dev] [PATCH] eal/armv7: emulate vaddvq u16 variant

2017-07-10 Thread Thomas Monjalon
10/07/2017 09:28, Thomas Monjalon: > 10/07/2017 05:51, Jianbo Liu: > > On 9 July 2017 at 01:08, Thomas Monjalon wrote: > > > 07/07/2017 18:26, Jerin Jacob: > > >> vaddvq_u16() is not available for armv7. > > >> Emulate the vaddvq_u16() using armv7 NEON intrinsics. > > > > > > After implementing th

[dpdk-dev] [RFC 6/7] mbuf: Added next_esp_proto field

2017-07-10 Thread Boris Pismenny
From: Aviad Yehezkel Signed-off-by: Aviad Yehezkel Signed-off-by: Boris Pismenny --- lib/librte_mbuf/rte_mbuf.h | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h index b8ab7ed..234c9de 100644 --- a/lib/librte_mb

[dpdk-dev] [RFC 4/7] cryptodev: add ipsec xform

2017-07-10 Thread Boris Pismenny
This patch add a xform that is used with the crypto flow steering action to offload ipsec crypto inline. Signed-off-by: Boris Pismenny Signed-off-by: Aviad Yehezkel --- lib/librte_cryptodev/rte_crypto_sym.h | 42 ++- 1 file changed, 41 insertions(+), 1 deletion(-

[dpdk-dev] [RFC 3/7] ethdev: add rte flow action for crypto

2017-07-10 Thread Boris Pismenny
The crypto action is specified by an application to request crypto offload for a flow. Signed-off-by: Boris Pismenny Signed-off-by: Aviad Yehezkel --- lib/Makefile| 1 + lib/librte_ether/rte_flow.h | 26 ++ 2 files changed, 27 insertions(+) diff --git a

[dpdk-dev] [RFC 0/7] ipsec inline

2017-07-10 Thread Boris Pismenny
In this RFC we introduce a infrastructure for IPSec inline hardware offloading. This RFC introduces device capabilities, configuration API and data path processing. We also provide a comparison with a previous RFC posted on the list for this feature. 1. Inline crypto processing 1.1. Device Capabi

[dpdk-dev] [RFC 5/7] mbuf: Add IPsec crypto flags

2017-07-10 Thread Boris Pismenny
This patch adds flags to request IPsec crypto offload for transmitted packets, and to indicate crypto result for received packets. Signed-off-by: Boris Pismenny Signed-off-by: Aviad Yehezkel --- lib/librte_mbuf/rte_mbuf.c | 16 lib/librte_mbuf/rte_mbuf.h | 29 ++

[dpdk-dev] [RFC 7/7] example/ipsec_gw: Support SA offload in datapath

2017-07-10 Thread Boris Pismenny
From: Aviad Yehezkel data-path: 1. esp_outbound build ipsec headers, fill esp_next_pror metadata and mark packet for offload. note trailer will be added by hardware. 2. esp_outbound_post doing nothing for offload. 3. esp_inbound doing nothing for offload. 4. esp_inbound_post remove ipsec he

[dpdk-dev] [RFC 2/7] ethdev: Add ESP header to generic flow steering

2017-07-10 Thread Boris Pismenny
The ESP header is required for IPsec crypto actions. Signed-off-by: Boris Pismenny Signed-off-by: Aviad Yehezkel --- lib/librte_ether/rte_flow.h | 24 lib/librte_net/Makefile | 2 +- 2 files changed, 25 insertions(+), 1 deletion(-) diff --git a/lib/librte_ether/rt

[dpdk-dev] [RFC 1/7] ethdev: add device ipsec encrypt/decrypt capability flags

2017-07-10 Thread Boris Pismenny
A PMD that presents these flags supports IPsec crypto offload. Encryption and authentication on SA entries can be offloaded to the PMD. After adding a SA to hardware, crypto can be offloaded on well-formed IPsec packets. Signed-off-by: Boris Pismenny Signed-off-by: Aviad Yehezkel --- lib/librte

Re: [dpdk-dev] [PATCH] eal/armv7: emulate vaddvq u16 variant

2017-07-10 Thread Thomas Monjalon
10/07/2017 05:34, Jianbo Liu: > On 8 July 2017 at 00:26, Jerin Jacob wrote: > > vaddvq_u16() is not available for armv7. > > Emulate the vaddvq_u16() using armv7 NEON intrinsics. > > > > Signed-off-by: Jerin Jacob > > Acked-by: Jianbo Liu Applied, thanks

Re: [dpdk-dev] [pull-request] next-tm 17.08 pre-rc1

2017-07-10 Thread Adrien Mazarguil
Hi Thomas, On Sun, Jul 09, 2017 at 10:01:31PM +0200, Thomas Monjalon wrote: > Hi, > > 04/07/2017 17:38, Cristian Dumitrescu: > > http://dpdk.org/git/next/dpdk-next-tm > > I'm sorry to not have considered this tree as a high priority. > I think it may be integrated in RC2 because it is a total

Re: [dpdk-dev] [pull-request] next-tm 17.08 pre-rc1

2017-07-10 Thread Thomas Monjalon
10/07/2017 09:43, Adrien Mazarguil: > Hi Thomas, > > On Sun, Jul 09, 2017 at 10:01:31PM +0200, Thomas Monjalon wrote: > > 3/ The PMD interface file is referenced in the doxygen index: > > + [rte_tm_driver] (@ref rte_tm_driver.h), > > I see that rte_flow_driver.h is also referenced but it see

Re: [dpdk-dev] [PATCH] test: Fix memory corruption issues which fails the link_bonding test.

2017-07-10 Thread Jianbo Liu
On 10 July 2017 at 15:20, Herbert Guan wrote: > There were double-free problems in some test cases of link_bonding, > which will cause a duplicated mbuf will be added into mempool. After > double-free, some new allocated mbuf will hold a same address and > thus cause the memory corruption. > > An

Re: [dpdk-dev] [PATCH v2 6/8] mbuf: use 2 bytes for port and nb segments

2017-07-10 Thread Olivier Matz
Hi, On Tue, 4 Jul 2017 07:54:23 +, "Wang, Zhihong" wrote: > > -Original Message- > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Olivier MATZ > > Sent: Tuesday, April 18, 2017 9:03 PM > > To: Yuanhan Liu > > Cc: dev@dpdk.org; Ananyev, Konstantin ; > > Richardson, Bruce ; >

Re: [dpdk-dev] [dpdk-announce] release candidate 17.08-rc1

2017-07-10 Thread Morten Brørup
We have quite a few customers using our older hardware appliance model based on the Atom D525, and these appliances will not be firmware upgradable when we launch our DPDK based firmware. Although the Atom D525 is a 64 bit CPU, I don't know if DPDK ever supported it. If it was ever supported by

[dpdk-dev] [PATCH] vhost: fix vhost-user init failed

2017-07-10 Thread Zhiyong Yang
Exception handling is executed in the normal path and it will cause vhost-user init failure. Fixes: d6983a70e259("vhost: check return of pthread calls") Reported-by: Lei Yao Signed-off-by: Zhiyong Yang --- lib/librte_vhost/socket.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --g

Re: [dpdk-dev] [PATCH v2 1/2] mempool/dpaa2: fix the return value for alloc fail

2017-07-10 Thread Olivier Matz
On Thu, 22 Jun 2017 18:18:07 +0530, Hemant Agrawal wrote: > In case the alloc api is not able to allocate the required > number of buffer, it can return '0', which will not indicate > the failure to the calling function. > This patch fix the return value to indicate the failure. > > Fixes: 5dc43

Re: [dpdk-dev] [PATCH v2 2/2] mempool/dpaa2: fix the incorrect free usages for bplist

2017-07-10 Thread Olivier Matz
On Thu, 22 Jun 2017 18:18:08 +0530, Hemant Agrawal wrote: > The dpaa2_bp_list is being allocated using "rte_malloc", > but the free is done using "free". Fixing it to use > "rte_free". > > Fixes: 5dc43d22b5ad ("mempool/dpaa2: add hardware offloaded mempool") > CC: sta...@dpdk.org > > Signed-off

[dpdk-dev] [PATCH] net/tap: remove Linux version check

2017-07-10 Thread Raslan Darawsheh
Remove checks of Linux kernel version in order to support kernel with backported features. The expected behavior with a kernel that doesn't support flower and other bits is the following: -flow validate can return successfully. -flow create using the same rule fails. Using the "r

Re: [dpdk-dev] [PATCH v2 6/8] mbuf: use 2 bytes for port and nb segments

2017-07-10 Thread Morten Brørup
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Olivier Matz > Sent: Monday, July 10, 2017 10:00 AM > Subject: Re: [dpdk-dev] [PATCH v2 6/8] mbuf: use 2 bytes for port and > nb segments > > Hi, > > On Tue, 4 Jul 2017 07:54:23 +, "Wang, Zhihong" > wrote: >

Re: [dpdk-dev] [PATCH v4 0/7] service cores: cover letter

2017-07-10 Thread Van Haaren, Harry
> From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Sunday, July 9, 2017 11:09 PM > To: Van Haaren, Harry > Cc: dev@dpdk.org; jerin.ja...@caviumnetworks.com; Wiles, Keith > ; > Richardson, Bruce > Subject: Re: [dpdk-dev] [PATCH v4 0/7] service cores: cover letter > > 07/07/2017 18:41,

Re: [dpdk-dev] [PATCH v2] igb_uio: issue FLR during open and release of device file

2017-07-10 Thread Tan, Jianfeng
> -Original Message- > From: Shijith Thotton [mailto:shijith.thot...@caviumnetworks.com] > Sent: Monday, July 10, 2017 3:11 PM > To: Tan, Jianfeng > Cc: dev@dpdk.org; Yigit, Ferruh; Gregory Etelson; Thomas Monjalon; > Stephen Hemminger; Lu, Wenzhuo > Subject: Re: [PATCH v2] igb_uio: issue

[dpdk-dev] [PATCH] doc: update NXP copyright headers

2017-07-10 Thread Shreyansh Jain
NXP Copyright has been wrongly worded with '(c)' at various places. This patch removes these extra characters. It also removes "All rights reserved". Only NXP copyright syntax is changed. Freescale copyright is not modified. Signed-off-by: Shreyansh Jain --- config/defconfig_arm64-dpaa2-linuxap

[dpdk-dev] [PATCH v4] doc: release notes 17.08, API change description

2017-07-10 Thread Radu Nicolau
Added API change description - moved bypass functions from the rte_ethdev library to ixgbe PMD Signed-off-by: Radu Nicolau --- v4: changed library name to rte_ethdev and "APIs" to "functions" doc/guides/rel_notes/release_17_08.rst | 25 + 1 file changed, 25 insertions(+

[dpdk-dev] [PATCH v5] doc: release notes 17.08, API change description

2017-07-10 Thread Radu Nicolau
Added API change description - moved bypass functions from the rte_ethdev library to ixgbe PMD Signed-off-by: Radu Nicolau --- v5: changed library name to rte_ethdev and "APIs" to "functions" doc/guides/rel_notes/release_17_08.rst | 25 + 1 file changed, 25 insertions(+

Re: [dpdk-dev] [PATCH] vhost: fix vhost-user init failed

2017-07-10 Thread Maxime Coquelin
On 07/10/2017 10:06 AM, Zhiyong Yang wrote: Exception handling is executed in the normal path and it will cause vhost-user init failure. Fixes: d6983a70e259("vhost: check return of pthread calls") Reported-by: Lei Yao Signed-off-by: Zhiyong Yang --- lib/librte_vhost/socket.c | 2 +- 1 fil

Re: [dpdk-dev] [PATCH] vhost: fix vhost-user init failed

2017-07-10 Thread Jens Freimann
On Mon, Jul 10, 2017 at 04:06:48PM +0800, Zhiyong Yang wrote: Exception handling is executed in the normal path and it will cause vhost-user init failure. Fixes: d6983a70e259("vhost: check return of pthread calls") Reported-by: Lei Yao Signed-off-by: Zhiyong Yang --- lib/librte_vhost/socket.c

[dpdk-dev] [PATCH v6 1/4] ethdev: add support of NIC reset

2017-07-10 Thread Wei Dai
This patch adds a new eth_dev layer API function rte_eth_dev_reset(). A DPDK application can call this function to reset a NIC and keep its port id afterwards. It means that all SW resources allocated in ethdev layer should be kept and SW and HW resources of the NIC in PMD need to be reset in simil

[dpdk-dev] [PATCH v6 2/4] net/ixgbe: add support of reset

2017-07-10 Thread Wei Dai
Reset a NIC by calling dev_uninit and then dev_init. Go through same way in NIC PCI remove without release of ethdev resource and then NIC PCI probe function without ethdev resource allocation. Signed-off-by: Wei Dai --- drivers/net/ixgbe/ixgbe_ethdev.c | 47 +

[dpdk-dev] [PATCH v6 0/4] Support NIC reset and keep same port id

2017-07-10 Thread Wei Dai
This patch set adds a function rte_eth_dev_reset( ) in rte_ethdev layer. Sometimes a port have to be reset passively. For example a PF is reset, all its VFs should also be reset by application itself to align with the PF. A DPDK application also can call this function to trigger an initative port

[dpdk-dev] [PATCH v6 3/4] net/i40e: add support of reset

2017-07-10 Thread Wei Dai
Reset a NIC by calling dev_uninit() and then dev_init(). Go through the same way in NIC PCI remove without release of ethdev resource and then NIC PCI probe function without ethdev resource allocation. Signed-off-by: Wei Dai --- drivers/net/i40e/i40e_ethdev.c| 28

[dpdk-dev] [PATCH v6 4/4] app/testpmd: enhance command to test NIC reset

2017-07-10 Thread Wei Dai
When PF is reset, a message will show it and all its VF need to be reset. User can run the command "port reset port_id" to reset the VF port and to keep same port id without any configuration. Then user can run "port stop port_id" and "port start port_id" to reconfigure its forwarding mode and parm

Re: [dpdk-dev] [RFC 0/4] DPDK multiprocess rework

2017-07-10 Thread Burakov, Anatoly
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Anatoly Burakov > Sent: Friday, May 19, 2017 5:40 PM > To: dev@dpdk.org > Subject: [dpdk-dev] [RFC 0/4] DPDK multiprocess rework > > This is a proof-of-concept proposal for rework of how DPDK secondary > processes work. While the code has some

Re: [dpdk-dev] [PATCH v5 2/4] net/ixgbe: add support of reset

2017-07-10 Thread Dai, Wei
Thanks, Thomas I have just sent out my v6 patch set which includes more details to explain why/what/when. -Original Message- From: Thomas Monjalon [mailto:tho...@monjalon.net] Sent: Friday, July 7, 2017 4:36 PM To: Dai, Wei ; Yigit, Ferruh Cc: dev@dpdk.org; Lu, Wenzhuo ; Ananyev, Konsta

Re: [dpdk-dev] [PATCH] doc: update NXP copyright headers

2017-07-10 Thread Thomas Monjalon
10/07/2017 11:13, Shreyansh Jain: > NXP Copyright has been wrongly worded with '(c)' at various places. > This patch removes these extra characters. It also removes > "All rights reserved". > > Only NXP copyright syntax is changed. Freescale copyright is not > modified. > > Signed-off-by: Shreyan

Re: [dpdk-dev] [PATCH 1/2] eventdev: add event adapter for ethernet Rx queues

2017-07-10 Thread Jerin Jacob
-Original Message- > Date: Mon, 10 Jul 2017 11:44:10 +0530 > From: "Rao, Nikhil" > To: Jerin Jacob > CC: gage.e...@intel.com, dev@dpdk.org, tho...@monjalon.net, > bruce.richard...@intel.com, harry.van.haa...@intel.com, > hemant.agra...@nxp.com, nipun.gu...@nxp.com, narender.vang...@inte

Re: [dpdk-dev] [PATCH v2] igb_uio: issue FLR during open and release of device file

2017-07-10 Thread Shijith Thotton
On Mon, Jul 10, 2017 at 09:00:38AM +, Tan, Jianfeng wrote: > > > > -Original Message- > > From: Shijith Thotton [mailto:shijith.thot...@caviumnetworks.com] > > Sent: Monday, July 10, 2017 3:11 PM > > To: Tan, Jianfeng > > Cc: dev@dpdk.org; Yigit, Ferruh; Gregory Etelson; Thomas Monjal

Re: [dpdk-dev] [pull-request] next-tm 17.08 pre-rc1

2017-07-10 Thread Dumitrescu, Cristian
Hi Thomas, > -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Sunday, July 9, 2017 9:02 PM > To: Dumitrescu, Cristian > Cc: dev@dpdk.org; jerin.ja...@caviumnetworks.com; > hemant.agra...@nxp.com; Singh, Jasvinder ; > Lu, Wenzhuo > Subject: Re: [dpdk-dev] [p

[dpdk-dev] [PATCH] cryptodev: fix icc build

2017-07-10 Thread Pablo de Lara
Removed unnecessary macro RTE_STD_C11, which is used for unnamed structs. Since there is no longer an unnamed structure in rte_cryptodev_sym_session, this is not needed and it is actually breaking compilation on icc: lib/librte_cryptodev/rte_cryptodev.h(887): error: expected a declaration

[dpdk-dev] [PATCH v2] test: Fix memory corruption issues which fails the link_bonding test.

2017-07-10 Thread Herbert Guan
Patch V2: fix build warnings by deleting unused variables. There were double-free problems in some test cases, which will cause a duplicated mbuf will be added into mempool. After double-free, some new allocated mbuf will hold a same address and thus cause the memory corruption. Another minor

Re: [dpdk-dev] [PATCH v3 02/20] net/i40e: support getting TM capability

2017-07-10 Thread Dumitrescu, Cristian
> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Sunday, July 9, 2017 8:31 PM > To: Lu, Wenzhuo > Cc: dev@dpdk.org; Dumitrescu, Cristian ; > Singh, Jasvinder > Subject: Re: [dpdk-dev] [PATCH v3 02/20] net/i40e: support getting TM > capability > > 29/06/

Re: [dpdk-dev] [PATCH v6 1/4] ethdev: add support of NIC reset

2017-07-10 Thread Jerin Jacob
-Original Message- > Date: Mon, 10 Jul 2017 18:05:41 +0800 > From: Wei Dai > To: tho...@monjalon.net, wenzhuo...@intel.com, > konstantin.anan...@intel.com, jingjing...@intel.com, beilei.x...@intel.com > CC: dev@dpdk.org, Wei Dai > Subject: [dpdk-dev] [PATCH v6 1/4] ethdev: add support of

Re: [dpdk-dev] [PATCH v4 0/7] service cores: cover letter

2017-07-10 Thread Jerin Jacob
-Original Message- > Date: Mon, 10 Jul 2017 08:18:33 + > From: "Van Haaren, Harry" > To: Thomas Monjalon > CC: "dev@dpdk.org" , "jerin.ja...@caviumnetworks.com" > , "Wiles, Keith" , > "Richardson, Bruce" > Subject: RE: [dpdk-dev] [PATCH v4 0/7] service cores: cover letter > > > Fr

[dpdk-dev] [PATCH v2 00/12] Infrastructure to detect iova mapping on the bus

2017-07-10 Thread Santosh Shukla
v2: Based on the discussion on the thread [2]. Introducing RTE_PCI_DRV_NEED_IOVA_VA flag for autodetection of iova va mapping. If a PCI driver demand for IOVA as VA scheme then the driver can add it in the PCI driver registration function. Algorithm to select IOVA as VA for PCI bus case: 0. L

[dpdk-dev] [PATCH v2 01/12] eal/pci: introduce PCI driver iova as va flag

2017-07-10 Thread Santosh Shukla
Introducing RTE_PCI_DRV_NEED_IOVA_VA flag. Flag used when driver needs to operate in iova=va mode. Why driver need iova=va mapping? On NPU style co-processors like Octeontx, the buffer recycling has been done in HW, unlike SW model. Here is the data flow: 1) On control path, Fill the HW mempool w

[dpdk-dev] [PATCH v6] doc: release notes 17.08, API change description

2017-07-10 Thread Radu Nicolau
Added API change description - moved bypass functions from the rte_ethdev library to ixgbe PMD Signed-off-by: Radu Nicolau --- v6: changed library name to rte_ethdev and "APIs" to "functions", added newline after section. doc/guides/rel_notes/release_17_08.rst | 26 +++

[dpdk-dev] [PATCH v2 02/12] eal/pci: export match function

2017-07-10 Thread Santosh Shukla
Export rte_pci_match() function as it needed in the followup patch. Signed-off-by: Santosh Shukla --- lib/librte_eal/bsdapp/eal/rte_eal_version.map | 1 + lib/librte_eal/common/eal_common_pci.c | 10 +- lib/librte_eal/common/include/rte_pci.h | 15 +++ lib

[dpdk-dev] [PATCH v2 03/12] bsdapp/eal_pci: get iommu class

2017-07-10 Thread Santosh Shukla
Introducing rte_pci_get_iommu_class API which helps to get iommu class of PCI device on the bus and returns preferred iova mapping mode for PCI bus. Bsdapp case returns default iova mode. Signed-off-by: Santosh Shukla Signed-off-by: Jerin Jacob --- lib/librte_eal/bsdapp/eal/eal_pci.c

[dpdk-dev] [PATCH v2 05/12] bus: get iommu class

2017-07-10 Thread Santosh Shukla
API(rte_bus_get_iommu_class) helps to automatically detect and select appropriate iova mapping scheme for iommu capable device on that bus. Algorithm for iova scheme selection for bus: 0. Iterate throught bus_list. 1. Collect each bus iova mode value and update into 'mode' var. 2. Here value '1' i

[dpdk-dev] [PATCH v2 04/12] linuxapp/eal_pci: get iommu class

2017-07-10 Thread Santosh Shukla
Get iommu class of PCI device on the bus and returns preferred iova mapping mode for that bus. Algorithm for iova scheme selection for PCI bus: 0. Look for device attached to vfio kdrv and has .drv_flag set to RTE_PCI_DRV_NEED_IOVA_VA. 1. Look for any device attached to UIO class of driver. 2. Che

[dpdk-dev] [PATCH v2 06/12] eal: introduce iova mode helper api

2017-07-10 Thread Santosh Shukla
Introducing rte_eal_iova_mode() helper API. This API used by non-eal library for detecting iova mode. Signed-off-by: Santosh Shukla --- lib/librte_eal/bsdapp/eal/eal.c | 6 ++ lib/librte_eal/bsdapp/eal/rte_eal_version.map | 1 + lib/librte_eal/common/include/rte_eal.h

[dpdk-dev] [PATCH v2 07/12] linuxapp/eal: auto detect iova mode

2017-07-10 Thread Santosh Shukla
- Moving late bus scanning to up..just after eal_parsing. - Auto detect iova mapping mode, based on the result of rte_bus_scan_iommu_class. Signed-off-by: Santosh Shukla Signed-off-by: Jerin Jacob --- lib/librte_eal/linuxapp/eal/eal.c | 16 ++-- 1 file changed, 10 insertions(+), 6

[dpdk-dev] [PATCH v2 08/12] bsdapp/eal: auto detect iova mapping mode

2017-07-10 Thread Santosh Shukla
- Moving late bus scanning to up..just after eal_parsing. - Mapping mode would be default for bsdapp. It supports only one pass through mode (RTE_KDRV_NIC_UIO) Signed-off-by: Santosh Shukla Signed-off-by: Jerin Jacob --- lib/librte_eal/bsdapp/eal/eal.c | 16 ++-- 1 file changed, 1

[dpdk-dev] [PATCH v2 11/12] mempool: honor iova mode in virt2phy

2017-07-10 Thread Santosh Shukla
Check iova mode and accordingly return phy addr. Signed-off-by: Santosh Shukla Signed-off-by: Jerin Jacob --- lib/librte_mempool/rte_mempool.h | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/lib/librte_mempool/rte_mempool.h b/lib/librte_mempool/rte_mempool.h index

[dpdk-dev] [PATCH v2 10/12] linuxapp/eal_memory: honor iova mode in virt2phy

2017-07-10 Thread Santosh Shukla
Check iova mode and accordingly return phy addr. Signed-off-by: Santosh Shukla Signed-off-by: Jerin Jacob --- lib/librte_eal/linuxapp/eal/eal_memory.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lib/librte_eal/linuxapp/eal/eal_memory.c b/lib/librte_eal/linuxapp/eal/eal_memory.c inde

[dpdk-dev] [PATCH v2 12/12] eal/rte_malloc: honor iova mode in virt2phy

2017-07-10 Thread Santosh Shukla
Check iova mode and accordingly return phy addr. Signed-off-by: Santosh Shukla Signed-off-by: Jerin Jacob --- lib/librte_eal/common/rte_malloc.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/lib/librte_eal/common/rte_malloc.c b/lib/librte_eal/common/rte_malloc.c i

[dpdk-dev] [PATCH v2 09/12] linuxapp/eal_vfio: honor iova mode before mapping

2017-07-10 Thread Santosh Shukla
Check iova mode and accordingly map iova to pa or va. Signed-off-by: Santosh Shukla Signed-off-by: Jerin Jacob --- lib/librte_eal/linuxapp/eal/eal_vfio.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/lib/librte_eal/linuxapp/eal/eal_vfio.c b/lib/librte_eal/linux

[dpdk-dev] [PATCH v3 0/3] librte_cmdline: fix parsing initialisation

2017-07-10 Thread Adrien Mazarguil
Adding a cover letter to keep the same title for that thread, since I took over the original patch from Bernard, modified it somewhat and made a couple of additional fixes on top of it. Olivier's comment [1] and Bernard's feedback about dynamic tokens made me realize how the interface itself was n

[dpdk-dev] [PATCH v3 1/3] cmdline: fix dynamic tokens initialization

2017-07-10 Thread Adrien Mazarguil
To avoid redundant calls to the token-generating function and provide it with helpful context, a temporary fixed-size array allocated on the stack of cmdline_parse() and cmdline_complete() keeps the address of preceding tokens for the command instance being processed (cmdline_parse_inst_t). Like t

[dpdk-dev] [PATCH v3 3/3] app/testpmd: fix token matching in flow command

2017-07-10 Thread Adrien Mazarguil
While matching user input against a token name or any other fixed string, comparison stops at the end of user input if shorter (e.g. "foo" matches token name "foobar"). Although the unintended consequence of this behavior allows users to abbreviate command names and various parameters yet generate

[dpdk-dev] [PATCH v3 2/3] cmdline: fix dynamic tokens interface

2017-07-10 Thread Adrien Mazarguil
Support for dynamic tokens was added in order to implement the flow command in testpmd, for which static tokens were not versatile enough due to the large number of possible parameter combinations. However, due to its reliance on a temporary array to store dynamic tokens, this interface suffers fr

Re: [dpdk-dev] [PATCH v2 11/12] mempool: honor iova mode in virt2phy

2017-07-10 Thread Olivier Matz
On Mon, 10 Jul 2017 11:42:34 +, Santosh Shukla wrote: > Check iova mode and accordingly return phy addr. > > Signed-off-by: Santosh Shukla > Signed-off-by: Jerin Jacob > --- > lib/librte_mempool/rte_mempool.h | 10 -- > 1 file changed, 8 insertions(+), 2 deletions(-) > > diff --g

Re: [dpdk-dev] [PATCH 1/2] test: add unit test case for rte log2

2017-07-10 Thread Olivier Matz
On Thu, 6 Jul 2017 19:50:24 +0530, Jerin Jacob wrote: > add a unit testcase for rte_log2_u32. > > Signed-off-by: Jerin Jacob Reviewed-by: Olivier Matz

Re: [dpdk-dev] [PATCH 2/2] net/thunderx: remove libm dependency

2017-07-10 Thread Olivier Matz
On Thu, 6 Jul 2017 19:50:25 +0530, Jerin Jacob wrote: > Used rte_log2_u32() to replace integer log2() to > remove libm dependency. > > Signed-off-by: Jerin Jacob Reviewed-by: Olivier Matz

Re: [dpdk-dev] [PATCH v2] ether: add support for vtune task tracing

2017-07-10 Thread Jerin Jacob
-Original Message- > Date: Thu, 6 Jul 2017 19:42:52 +0300 > From: ilia.kura...@intel.com > To: dev@dpdk.org > CC: jerin.ja...@caviumnetworks.com, konstantin.anan...@intel.com, > keith.wi...@intel.com, dmitry.gala...@intel.com, Ilia Kurakin > > Subject: [PATCH v2] ether: add support for v

Re: [dpdk-dev] [PATCH] mbuf: fix comment about vxlan destination port used

2017-07-10 Thread Olivier Matz
On Fri, 7 Jul 2017 15:17:40 +0100, Cian Ferriter wrote: > IANA assigns a destination port of 4789 for the VXLAN in the Service > Name and Transport Protocol Port Number Registry. This is mentioned in > RFC 7348. > > Signed-off-by: Cian Ferriter Fixes: f295a00a2b44 ("mbuf: add definitions of u

Re: [dpdk-dev] [PATCH] app/testpmd: add flow isolate all parameter

2017-07-10 Thread Adrien Mazarguil
On Sun, Jul 09, 2017 at 11:08:05AM +0300, Vasily Philipov wrote: > Providing this parameter requests flow API isolated mode on all ports at > initialization time. It ensures all traffic is received through the > configured flow rules only (see flow command). > > Ports that do not support this mode

[dpdk-dev] [PATCH v4 0/5] Rework cfgfile API to enable apps config file support

2017-07-10 Thread Jacek Piasecki
New API for cfgfile library allows to create a cfgfile at runtime, add new section, add entry in a section, update existing entry and save cfgfile structure to INI file - opens up the possibility to have applications dynamically build up a proper DPDK configuration, rather than having to have a pre

[dpdk-dev] [PATCH v4 1/3] eal: add functions parsing EAL arguments

2017-07-10 Thread Kuba Kozak
added function rte_eal_configure which configure Environment Abstraction Layer (EAL) using configuration structure. Signed-off-by: Kuba Kozak Suggested-by: Bruce Richardson --- lib/Makefile| 3 + lib/librte_eal/bsdapp/eal/Makefile | 4 + lib/

[dpdk-dev] [PATCH v4 0/3] EAL change for using a config file for DPDK

2017-07-10 Thread Kuba Kozak
This patchset introduce a mechanism for running dpdk application with parameters provided by configuration file. A new API for EAL takes a config file data type - either loaded from file, or built up programmatically in the application - and extracts DPDK parameters from it to be used when eal in

[dpdk-dev] [PATCH v4 1/5] cfgfile: remove EAL dependency

2017-07-10 Thread Jacek Piasecki
This patch removes the dependency to EAL in cfgfile library. Signed-off-by: Jacek Piasecki --- lib/Makefile | 3 +-- lib/librte_cfgfile/Makefile | 1 + lib/librte_cfgfile/rte_cfgfile.c | 29 + 3 files changed, 19 insertions(+), 14 deletions(

Re: [dpdk-dev] [pull-request] next-tm 17.08 pre-rc1

2017-07-10 Thread Thomas Monjalon
Hi, 10/07/2017 12:55, Dumitrescu, Cristian: > Hi Thomas, > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > > > Hi, > > > > 04/07/2017 17:38, Cristian Dumitrescu: > > > http://dpdk.org/git/next/dpdk-next-tm > > > > I'm sorry to not have considered this tree as a high priority. > > I

[dpdk-dev] [PATCH v4 2/3] app/testpmd: add parse options from cfg file

2017-07-10 Thread Kuba Kozak
This patch shows how to pass arguments to application using config.ini file. If a --cfgfile-path option is passed into commandline non EAL section, then the file is loaded and used by app. If a config.ini file is present in current working directory, and no --cfgfile-path option is passed in, co

[dpdk-dev] [PATCH v4 2/5] cfgfile: change existing API functions

2017-07-10 Thread Jacek Piasecki
Change to flat arrays in cfgfile struct force slightly diffrent data access for most of cfgfile functions. This patch provides necessary changes in existing API. Signed-off-by: Jacek Piasecki --- lib/librte_cfgfile/rte_cfgfile.c | 120 +++ lib/librte_cfgfile/r

[dpdk-dev] [PATCH v4 3/5] cfgfile: add new functions to API

2017-07-10 Thread Jacek Piasecki
Extend existing cfgfile library with providing new API functions: rte_cfgfile_create() - create new cfgfile object rte_cfgfile_add_section() - add new section to existing cfgfile object rte_cfgfile_add_entry() - add new entry to existing cfgfile object in specified section rte_cfgfile_set_entry()

[dpdk-dev] [PATCH v4 3/3] app/testpmd: add parse options from JSON cfg file

2017-07-10 Thread Kuba Kozak
This patch shows usage of Jansson library to parse application arguments from JSON config file. https://github.com/akheron/jansson If a --cfgfile-path option is passed into commandline non EAL section, then the disired JSON file is loaded and used by app. In case when JSON doesn't exist an INI f

[dpdk-dev] [PATCH v4 4/5] cfgfile: rework of load function

2017-07-10 Thread Jacek Piasecki
New functions added to cfgfile library make it possible to significantly simplify the code of rte_cfgfile_load_with_params() This patch shows the new body of this function. Signed-off-by: Jacek Piasecki --- lib/librte_cfgfile/rte_cfgfile.c | 156 --- 1 file c

[dpdk-dev] [PATCH v4 5/5] test/cfgfile: add new unit test

2017-07-10 Thread Jacek Piasecki
Load huge realloc_sections.ini file to check malloc/realloc ability of cfgfile library. Signed-off-by: Jacek Piasecki --- test/test/test_cfgfile.c | 40 +++ test/test/test_cfgfiles/etc/realloc_sections.ini | 128 +++ 2 files changed, 168 insertion

Re: [dpdk-dev] [PATCH 3/4] mempool: introduce block size align flag

2017-07-10 Thread Olivier Matz
On Wed, 5 Jul 2017 13:05:57 +0530, santosh wrote: > Hi Olivier, > > On Monday 03 July 2017 10:07 PM, Olivier Matz wrote: > > > On Wed, 21 Jun 2017 17:32:47 +, Santosh Shukla > > wrote: > >> Some mempool hw like octeontx/fpa block, demands block size aligned > >> buffer address. > >> >

Re: [dpdk-dev] [pull-request] next-tm 17.08 pre-rc1

2017-07-10 Thread Dumitrescu, Cristian
> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Monday, July 10, 2017 1:57 PM > To: Dumitrescu, Cristian > Cc: dev@dpdk.org; jerin.ja...@caviumnetworks.com; > hemant.agra...@nxp.com; Singh, Jasvinder ; > Lu, Wenzhuo ; O'Driscoll, Tim > ; Glynn, Michael J

Re: [dpdk-dev] [PATCH v2 11/12] mempool: honor iova mode in virt2phy

2017-07-10 Thread santosh
Hi Olivier, On Monday 10 July 2017 05:57 PM, Olivier Matz wrote: > On Mon, 10 Jul 2017 11:42:34 +, Santosh Shukla > wrote: >> Check iova mode and accordingly return phy addr. >> >> Signed-off-by: Santosh Shukla >> Signed-off-by: Jerin Jacob >> --- >> lib/librte_mempool/rte_mempool.h | 10

Re: [dpdk-dev] [PATCH] net/tap: remove Linux version check

2017-07-10 Thread Pascal Mazon
Hi Raslan, Your patch looks ok at first glance. However, I couldn't test it as it does not apply on a fresh next-net branch. Can you send a v2 after rebase? Thank you. Pascal On 07/10/2017 10:13 AM, Raslan Darawsheh wrote: Remove checks of Linux kernel version in order to support kernel wit

Re: [dpdk-dev] [pull-request] next-tm 17.08 pre-rc1

2017-07-10 Thread Thomas Monjalon
10/07/2017 15:21, Dumitrescu, Cristian: > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > 10/07/2017 12:55, Dumitrescu, Cristian: > > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > > > 2/ Some functions are exposed in the API to query the ops. > > > > It seems dangerous and useless

Re: [dpdk-dev] [PATCH v2 11/12] mempool: honor iova mode in virt2phy

2017-07-10 Thread Thomas Monjalon
10/07/2017 15:30, santosh: > Hi Olivier, > > On Monday 10 July 2017 05:57 PM, Olivier Matz wrote: > > I didn't check the patchset in detail, but in my understanding, > > what we call physaddr in dpdk is actually a bus address. Shouldn't > > we start to rename some of these fields and functions to

Re: [dpdk-dev] [PATCH 1/4] mempool: get the external mempool capability

2017-07-10 Thread Olivier Matz
On Wed, 5 Jul 2017 12:11:52 +0530, santosh wrote: > Hi Olivier, > > On Monday 03 July 2017 10:07 PM, Olivier Matz wrote: > > > Hi Santosh, > > > > On Wed, 21 Jun 2017 17:32:45 +, Santosh Shukla > > wrote: > >> Allow external mempool to advertise its capability. > >> A handler been intro

Re: [dpdk-dev] [PATCH v2 11/12] mempool: honor iova mode in virt2phy

2017-07-10 Thread santosh
On Monday 10 July 2017 07:21 PM, Thomas Monjalon wrote: > 10/07/2017 15:30, santosh: >> Hi Olivier, >> >> On Monday 10 July 2017 05:57 PM, Olivier Matz wrote: >>> I didn't check the patchset in detail, but in my understanding, >>> what we call physaddr in dpdk is actually a bus address. Shouldn't

Re: [dpdk-dev] [PATCH v2 11/12] mempool: honor iova mode in virt2phy

2017-07-10 Thread Thomas Monjalon
10/07/2017 15:56, santosh: > On Monday 10 July 2017 07:21 PM, Thomas Monjalon wrote: > > > 10/07/2017 15:30, santosh: > >> Hi Olivier, > >> > >> On Monday 10 July 2017 05:57 PM, Olivier Matz wrote: > >>> I didn't check the patchset in detail, but in my understanding, > >>> what we call physaddr in

Re: [dpdk-dev] [PATCH v2 11/12] mempool: honor iova mode in virt2phy

2017-07-10 Thread santosh
On Monday 10 July 2017 07:39 PM, Thomas Monjalon wrote: > 10/07/2017 15:56, santosh: >> On Monday 10 July 2017 07:21 PM, Thomas Monjalon wrote: >> >>> 10/07/2017 15:30, santosh: Hi Olivier, On Monday 10 July 2017 05:57 PM, Olivier Matz wrote: > I didn't check the patchset in det

Re: [dpdk-dev] [PATCH v2 11/12] mempool: honor iova mode in virt2phy

2017-07-10 Thread Thomas Monjalon
10/07/2017 16:22, santosh: > On Monday 10 July 2017 07:39 PM, Thomas Monjalon wrote: > > > 10/07/2017 15:56, santosh: > >> On Monday 10 July 2017 07:21 PM, Thomas Monjalon wrote: > >> > >>> 10/07/2017 15:30, santosh: > Hi Olivier, > > On Monday 10 July 2017 05:57 PM, Olivier Matz wr

Re: [dpdk-dev] [PATCH 1/2] test: add unit test case for rte log2

2017-07-10 Thread Thomas Monjalon
10/07/2017 14:29, Olivier Matz: > On Thu, 6 Jul 2017 19:50:24 +0530, Jerin Jacob > wrote: > > add a unit testcase for rte_log2_u32. > > > > Signed-off-by: Jerin Jacob > > Reviewed-by: Olivier Matz Series applied, thanks

Re: [dpdk-dev] [PATCH v4 0/5] Rework cfgfile API to enable apps config file support

2017-07-10 Thread Thomas Monjalon
The maintainer of librte_cfgfile is Cristian (+Cc), please set him as recipient for next time. 10/07/2017 14:44, Jacek Piasecki: > New API for cfgfile library allows to create a cfgfile at runtime, add new > section, add entry in a section, update existing entry and save cfgfile > structure to INI

Re: [dpdk-dev] [RFC 3/3] rte_flow: add new action for traffic metering and policing

2017-07-10 Thread Adrien Mazarguil
Hi Cristian, Took me a while to reply and I didn't see any update in the meantime, is this RFC still relevant? More comments below. On Tue, Jun 06, 2017 at 06:37:57PM +, Dumitrescu, Cristian wrote: > Hi Adrien, > > Thanks for reviewing this proposal. > > > -Original Message- > > Fr

Re: [dpdk-dev] [pull-request] next-tm 17.08 pre-rc1

2017-07-10 Thread Dumitrescu, Cristian
> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Monday, July 10, 2017 2:50 PM > To: Dumitrescu, Cristian > Cc: dev@dpdk.org; jerin.ja...@caviumnetworks.com; > hemant.agra...@nxp.com; Singh, Jasvinder ; > Lu, Wenzhuo ; O'Driscoll, Tim > ; Glynn, Michael J

  1   2   >