On 07/07/2017 08:21 PM, Ferruh Yigit wrote:
Document NIC features, add more information about them and add more
implementation related support.
Signed-off-by: Ferruh Yigit
Signed-off-by: John McNamara
Reviewed-by: Andrew Rybchenko
Few minor questions/notes below.
---
Cc: Olivier Matz
v
Replace the incorrect reference to "Cavium Networks", "Cavium Ltd"
company name with correct the "Cavium, Inc" company name in
copyright headers.
Signed-off-by: Jerin Jacob
---
app/test-eventdev/Makefile | 4 ++--
app/test-eventdev/evt_common.h
From: Ivan Malov
If MAC stats refresh is arranged to be done by periodic DMA,
the first DMA transaction is unlikely to occur right on the
port start; if the user tries to get stats right after port
start and before the transaction occurs, bogus figures will
be collected; a one-off stats upload on
08/07/2017 15:57, Jerin Jacob:
> Replace the incorrect reference to "Cavium Networks", "Cavium Ltd"
> company name with correct the "Cavium, Inc" company name in
> copyright headers.
>
> Signed-off-by: Jerin Jacob
Applied, thanks
From: Ivan Malov
Signed-off-by: Ivan Malov
Signed-off-by: Andrew Rybchenko
---
drivers/net/sfc/sfc.h| 1 +
drivers/net/sfc/sfc_ethdev.c | 81
drivers/net/sfc/sfc_port.c | 5 +++
3 files changed, 87 insertions(+)
diff --git a/drivers/net
07/07/2017 02:08, Gaetan Rivet:
> This allows PMDs and applications to save flow rules in their generic
> format for later processing. This is useful when rules cannot be applied
> immediately, such as when the device is not properly initialized.
>
> Signed-off-by: Gaetan Rivet
> Signed-off-by: A
Hi Jerin,
Thanks for the update.
I think we can add this new flag in 17.08.
I prefer waiting John's review, especially for doc wording,
before applying it. I consider it does not hurt to add it post-rc1.
See below for my first comment on the doc.
06/07/2017 08:21, Jerin Jacob:
> Introducing the
06/07/2017 15:48, Adrien Mazarguil:
> On Thu, Jul 06, 2017 at 02:32:19AM -0400, Qi Zhang wrote:
> > Fix document for fuzzy match and GRE
> >
> > Fixes: a3a2e2c8f7de ("ethdev: add fuzzy match in flow API")
> > Fixes: 7cd048321d1d ("ethdev: add MPLS and GRE flow API items")
> >
> > Signed-off-by: Q
Hi,
07/07/2017 11:21, Radu Nicolau:
> Added API change description - moved bypass functions
> from the rte_ether library to ixgbe PMD
>
> Signed-off-by: Radu Nicolau
> ---
>
> v3: fixed indentation issue
>
> doc/guides/rel_notes/release_17_08.rst | 25 +
> 1 file chang
Hi Jiayu,
On 7/7/2017 6:39 PM, Jiayu Hu wrote:
Generic Receive Offload (GRO) is a widely used SW-based offloading
technique to reduce per-packet processing overhead. It gains
performance by reassembling small packets into large ones. This
patchset is to support GRO in DPDK. To support GRO, this
On 7/7/2017 6:39 PM, Jiayu Hu wrote:
In this patch, we introduce five APIs to support TCP/IPv4 GRO.
- gro_tcp4_reassemble: reassemble an inputted TCP/IPv4 packet.
- gro_tcp4_tbl_create: create a TCP/IPv4 reassembly table, which is used
to merge packets.
- gro_tcp4_tbl_destroy: free memory
06/07/2017 01:00, Thomas Monjalon:
> 14/06/2017 12:37, Andrew Rybchenko:
> > On 05/25/2017 08:40 PM, Stephen Hemminger wrote:
> > > On Thu, 25 May 2017 16:57:53 +0100
> > > Andrew Rybchenko wrote:
> > >
> > >> From: Roman Zhukov
> > >>
> > >> Check that numbers of Rx and Tx descriptors satisfy de
07/07/2017 07:54, Pablo de Lara:
> From: mstolarchuk
>
> When adding items to a hash table with multiple threads,
> there is an spinlock used to prevent data corruption
> (unless Transactional Memory is supported).
>
> If there is a failure, the spinlock should be released,
> but there were case
15/05/2017 21:57, Pablo de Lara:
> Since the crypto perf application is flexible enough
> to cover all the crypto performance tests, these are not needed
> anymore, so they will be removed to avoid duplications.
> Besides, the crypto perf application gives the user more options
> to get performance
On Thu, 25 May 2017 16:57:54 +0100
Andrew Rybchenko wrote:
> + retval = rte_eth_dev_adjust_nb_rx_tx_desc(portid, &nb_rxd, &nb_txd);
> + if (retval != 0)
> + rte_exit(EXIT_FAILURE, "port %u:
> rte_eth_dev_adjust_nb_rx_tx_desc "
> + "failed (res=%d)\
07/07/2017 18:26, Jerin Jacob:
> vaddvq_u16() is not available for armv7.
> Emulate the vaddvq_u16() using armv7 NEON intrinsics.
After implementing this function, another missing function appears:
lib/librte_sched/rte_sched.c:1747:7: error:
implicit declaration of function ‘vminv
06/07/2017 17:28, Stephen Hemminger:
> Some minor stuff found while reviewing EAL to support VMBUS.
>
> Stephen Hemminger (3):
> eal: simplify finding starting point
> fslmc: simplfy find_device
> eal: fix spelling in comment
Applied, thanks
Add support for x86-32 and armv8 architectures.
Signed-off-by: Rasesh Mody
---
doc/guides/nics/features/qede.ini|2 ++
doc/guides/nics/features/qede_vf.ini |2 ++
2 files changed, 4 insertions(+)
diff --git a/doc/guides/nics/features/qede.ini
b/doc/guides/nics/features/qede.ini
ind
> From: Ferruh Yigit [mailto:ferruh.yi...@intel.com]
> Sent: Wednesday, July 05, 2017 3:02 AM
>
> On 7/1/2017 8:29 PM, Rasesh Mody wrote:
> > Hi Ferruh,
> >
> > This patch set contains minor enhancements and bug fixes for QEDE PMD.
> > It updates the driver version to 2.5.1.1. The patch set is tes
> Gaetan Rivet (5):
> bus: introduce parsing functionality
> vdev: implement parse bus operation
> pci: implement parse bus operation
> bus: add helper to find a bus from a device name
> devargs: parse bus info
>
> Thomas Monjalon (1):
> bus: fix driver registration
Series applied wit
07/07/2017 10:31, Gaëtan Rivet:
> On Thu, Jul 06, 2017 at 05:45:02PM -0700, Stephen Hemminger wrote:
> > On Fri, 7 Jul 2017 02:03:12 +0200
> > Gaetan Rivet wrote:
> >
> > > +static int
> > > +bus_name_cmp(const struct rte_bus *bus, const void *_name)
> > > +{
> > > + const char *name = _name;
>
08/06/2017 11:06, Olivier Matz:
> Hi,
>
> In the structure reorganization patchset [1], some work was done
> to ensure that the values of the following fields are always initialized
> for mbuf that are inside the mbuf pool (not yet allocated).
>
> In other words, calling rte_mbuf_raw_alloc() or r
This trivial patch removes wrong comments about
the return value of the rte_bus_dump(), as
this method does not return any value
(it's return type is void)
Signed-off-by: Rami Rosen
---
lib/librte_eal/common/include/rte_bus.h | 3 ---
1 file changed, 3 deletions(-)
diff --git a/lib/librte_ea
07/07/2017 02:04, Gaetan Rivet:
> The use of these commands have evolved.
> It is now possible to use whitelist and blacklist on any bus.
>
> Update the source code accordingly.
>
> Signed-off-by: Gaetan Rivet
> Acked-by: John McNamara
> ---
[...]
> --- a/lib/librte_eal/common/eal_options.h
> +
07/07/2017 02:04, Gaetan Rivet:
> In this patchset, the representation of devices in rte_devargs is made generic
> to remove some dependencies of the EAL on specific buses implementations.
> Following the device types being characterized by their bus, the DEVTYPE
> flags are updated not to referenc
In this patch, we introduce five APIs to support TCP/IPv4 GRO.
- gro_tcp4_reassemble: reassemble an inputted TCP/IPv4 packet.
- gro_tcp4_tbl_create: create a TCP/IPv4 reassembly table, which is used
to merge packets.
- gro_tcp4_tbl_destroy: free memory space of a TCP/IPv4 reassembly table.
- gr
Generic Receive Offload (GRO) is a widely used SW-based offloading
technique to reduce per-packet processing overhead. It gains performance
by reassembling small packets into large ones. Therefore, we propose to
support GRO in DPDK.
To enable more flexibility to applications, DPDK GRO is implement
This patch enables TCP/IPv4 GRO library in csum forwarding engine.
By default, GRO is turned off. Users can use command "gro (on|off)
(port_id)" to enable or disable GRO for a given port. If a port is
enabled GRO, all TCP/IPv4 packets received from the port are performed
GRO. Besides, users can set
Generic Receive Offload (GRO) is a widely used SW-based offloading
technique to reduce per-packet processing overhead. It gains
performance by reassembling small packets into large ones. This
patchset is to support GRO in DPDK. To support GRO, this patch
implements a GRO API framework.
To enable m
In order to be able to replicate a configuration onto a second port,
device configuration should be fully described and available.
Other configuration items (i.e. MAC addresses) are stored within
rte_eth_dev_data, but not this one.
Signed-off-by: Gaetan Rivet
---
I'm removing this patch from the
This device handle can be useful for other systems calling hotplug
functions, to retrieve for example any associated ethdev.
This change avoids unecessary calls to rte_bus_find, as the handle is
already known and available.
Signed-off-by: Gaetan Rivet
---
lib/librte_eal/common/eal_common_dev.c
Sending those fixes as separate patches as they stand on their own.
This series improves usability of the hotplug API and fixes a few issues
with existing implementations.
The hotplug API can be tested with the fail-safe PMD[1]. Its
documentation describes how to declare slaves and how to use it.
New device should be represented by an rte_devargs prior to being
plugged.
Device parameters are available to rte_devices via their devargs field.
This field should be set up as soon as possible, as central information
are stored within, such as the device name which is used to search
the newly sc
Use the new rte_eal_devargs_rmv() API to free allocated resources
during device removal or when encountering errors when adding devices.
Signed-off-by: Gaetan Rivet
---
lib/librte_eal/common/eal_common_dev.c | 10 +++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/lib/librt
Hotplug support introduces the possibility of removing devices from the
system. Allocated resources must be freed.
Extend the rte_devargs API to allow freeing allocated resources.
This API is experimental and bound to change. It is currently designed
as a symetrical to rte_eal_devargs_add(), but
The PCI device is referenced by other DPDK systems by the name of its
parameter, not by the system name.
Moreover, this name should be set once and for all, as early as
possible. This means linking the rte_devargs associated with the PCI
device during its scan, making available other metadatas use
The device handle is already known and does not have to be infered from
the PCI address. The relevant helpers are already available within the
PCI bus to avoid searching for a handle already known.
Additionally, rte_memcpy.h was erroneously included.
Fixes: 00e62aae69c0 ("bus/pci: implement plug/
This method must be implemented to allow using a unified, generic API to
hotplug devices, including virtual ones.
VDEV devices actually exist unattached after performing a scan on the
rte_devargs list. As such it makes sense to be able to perform a device
hotplug afterward.
Finally, missing this
The field is set but never resetted on error.
This marks the device as being attached while it is not, and forbid
further attempts to hotplug it.
Fixes: 7917d5f5ea46 ("pci: initialize generic driver pointer")
Cc: sta...@dpdk.org
Signed-off-by: Gaetan Rivet
---
lib/librte_eal/common/eal_common_p
The prior scan should link the relevant rte_devargs to the newly
allocated rte_device. As such, it is useless to pass device arguments to
the plug callback. Those arguments are available within the devargs
field of the rte_device structure.
Fixes: 7c8810f43f6e ("bus: introduce device plug/unplug")
This PMD intercepts and manages Ethernet device removal events issued by
slave PMDs and re-initializes them transparently when brought back so that
existing applications do not need to be modified to benefit from true
hot-plugging support.
The stacked PMD approach shares many similarities with the
Make the rte_eth_dev_count() return the number of available devices even
after some are detached by the hotplug API or put in a deferred state.
Signed-off-by: Gaetan Rivet
---
lib/librte_ether/rte_ethdev.c | 16 +---
lib/librte_ether/rte_ethdev.h | 13 ++---
2 files changed,
This device state means that the device is managed externally, by
whichever party has set this state (PMD or application).
Note: this new device state is only an information. The related device
structure and operators are still valid and can be used normally.
It is however made private by device
Introduce the fail-safe poll mode driver initialization and enable its
build infrastructure.
This PMD allows for applications to benefit from true hot-plugging
support without having to implement it.
It intercepts and manages Ethernet device removal events issued by
slave PMDs and re-initializes
Periodically check for the existence of a device.
If a device has not been initialized and exists on the system, then it
is probed and configured.
The configuration process strives to synchronize the states between the
plugged-in sub-device and the fail-safe device.
Signed-off-by: Gaetan Rivet
A
Signed-off-by: Gaetan Rivet
Acked-by: Olga Shern
---
doc/guides/nics/features/failsafe.ini | 1 +
drivers/net/failsafe/Makefile | 1 +
drivers/net/failsafe/failsafe.c | 1 +
drivers/net/failsafe/failsafe_eal.c | 1 +
drivers/net/failsafe/failsafe_ether.c | 70 +
Signed-off-by: Gaetan Rivet
Acked-by: Olga Shern
---
doc/guides/nics/features/failsafe.ini | 6 ++
drivers/net/failsafe/failsafe_ops.c | 131 +-
2 files changed, 135 insertions(+), 2 deletions(-)
diff --git a/doc/guides/nics/features/failsafe.ini
b/doc/guide
Listen to INTR_RMV events issued by slaves.
Add atomic flags on slave queues to detect use of slave bursts function.
If a removal is detected, set the recollection flag on this slave.
During a slave upkeep round, if its recollection flag is set and its
burst functions are not in use by any thread,
Add the "exec" device type.
The parameters given to this type of device will be executed in a shell.
The output of this command is then used as a definition for a device.
That command can be re-interpreted if the related device is not
plugged-in. It allows for a device definition to react to syste
Signed-off-by: Gaetan Rivet
---
drivers/net/failsafe/failsafe_ether.c | 34 +++--
drivers/net/failsafe/failsafe_flow.c| 29
drivers/net/failsafe/failsafe_private.h | 4
3 files changed, 65 insertions(+), 2 deletions(-)
diff --g
Signed-off-by: Gaetan Rivet
Acked-by: Olga Shern
---
drivers/net/failsafe/failsafe_private.h | 8 +++
drivers/net/failsafe/failsafe_rxtx.c| 124 ++--
2 files changed, 112 insertions(+), 20 deletions(-)
diff --git a/drivers/net/failsafe/failsafe_private.h
b/dri
Signed-off-by: Gaetan Rivet
---
doc/guides/nics/features/failsafe.ini | 1 +
drivers/net/failsafe/failsafe.c | 1 +
drivers/net/failsafe/failsafe_ether.c | 18 ++
drivers/net/failsafe/failsafe_ops.c | 23 +++
drivers/net/failsafe/failsafe_priv
CRC size on Tx path is not necessary to be excluded.
Fixes: 98abce237ba7 ("net/i40e: fix VF statistics")
Cc: sta...@dpdk.org
Signed-off-by: Qi Zhang
---
drivers/net/i40e/i40e_ethdev.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_et
Generic Receive Offload (GRO) is a widely used SW-based offloading
technique to reduce per-packet processing overhead. It gains
performance by reassembling small packets into large ones. This
patchset is to support GRO in DPDK. To support GRO, this patch
implements a GRO API framework.
To enable m
In this patch, we introduce five APIs to support TCP/IPv4 GRO.
- gro_tcp4_reassemble: reassemble an inputted TCP/IPv4 packet.
- gro_tcp4_tbl_create: create a TCP/IPv4 reassembly table, which is used
to merge packets.
- gro_tcp4_tbl_destroy: free memory space of a TCP/IPv4 reassembly table.
- gr
Generic Receive Offload (GRO) is a widely used SW-based offloading
technique to reduce per-packet processing overhead. It gains performance
by reassembling small packets into large ones. Therefore, we propose to
support GRO in DPDK.
To enable more flexibility to applications, DPDK GRO is implement
This patch enables TCP/IPv4 GRO library in csum forwarding engine.
By default, GRO is turned off. Users can use command "gro (on|off)
(port_id)" to enable or disable GRO for a given port. If a port is
enabled GRO, all TCP/IPv4 packets received from the port are performed
GRO. Besides, users can set
57 matches
Mail list logo
