Re: [dpdk-dev] [PATCH] devtools: update headline prefix for drivers

2017-01-29 Thread Thomas Monjalon
2017-01-26 14:07, Ferruh Yigit: > For the patches that touch multiple drivers in same driver group, > script forces headline prefix start with drv group. > > Like for net/a net/b net/c, patch title should be "net: x y z" > > Update rule to let "driver" prefix in headline, > for above sample patch

Re: [dpdk-dev] [PATCH] devtools: add git log checks for nvm, tso, Vlan

2017-01-29 Thread Thomas Monjalon
> Signed-off-by: Ferruh Yigit Applied, thanks

Re: [dpdk-dev] [PATCH] mk: remove default toolchain prefix for ThunderX

2017-01-29 Thread Thomas Monjalon
2017-01-23 15:09, Jerin Jacob: > On Mon, Jan 23, 2017 at 10:15:57AM +0100, Thomas Monjalon wrote: > > The environment variable CROSS must be set when using a cross-toolchain. > > However it is counter intuitive to set a default value, considering > > the toolchain required to build this architectur

Re: [dpdk-dev] [PATCH] mk: parallelize make config

2017-01-29 Thread Thomas Monjalon
2017-01-22 01:50, Ferruh Yigit: > make config dependency resolving was always running serial, > parallelize it for better performance. It could be interesting to explain why it was not parallelized, and how you made it possible. The test script should be updated as below: --- a/devtools/test-bui

Re: [dpdk-dev] [PATCH] buildtools: allow symlinks within a source directory

2017-01-29 Thread Thomas Monjalon
2017-01-23 12:11, Bruce Richardson: > When creating the symlinks for header files to the include folder, the > relpath script dereferenced all symlinks. This made it impossible to > have file A.h renamed to B.h and then symlinked back to its original > name. This is useful to be able to do when ref

Re: [dpdk-dev] [PATCH 2/2] config: disable KNI ethtool by default

2017-01-29 Thread Thomas Monjalon
2017-01-17 19:35, Thomas Monjalon: > 2017-01-17 18:01, Ferruh Yigit: > > KNI ethtool support (KNI control path) is not commonly used, > > and it tends to break the build with new version of the Linux kernel. > > > > KNI ethtool feature is disabled by default. KNI datapath is not effected > > from

Re: [dpdk-dev] [PATCH 10/13] KNI: provided netif name's source is user-space

2017-01-29 Thread Thomas Monjalon
2016-12-14 17:35, Ferruh Yigit: > On 12/14/2016 5:35 PM, Ferruh Yigit wrote: > > On 12/14/2016 5:19 PM, Michał Mirosław wrote: > >> On Wed, Dec 14, 2016 at 05:06:23PM +, Ferruh Yigit wrote: > >>> Hi Michal, > >>> > >>> On 12/13/2016 1:08 AM, Michał Mirosław wrote: > Signed-off-by: Michał M

Re: [dpdk-dev] [PATCH 11/13] KNI: guard against unterminated dev_info.name leading to BUG in alloc_netdev()

2017-01-29 Thread Thomas Monjalon
2016-12-14 17:33, Ferruh Yigit: > On 12/13/2016 1:08 AM, Michał Mirosław wrote: > > Signed-off-by: Michał Mirosław > > --- > > Acked-by: Ferruh Yigit Applied, thanks

Re: [dpdk-dev] [PATCH] eal: fix wrong log at startup

2017-01-29 Thread Thomas Monjalon
2017-01-24 17:21, Olivier Matz: > The log "Debug logs available - lower performance" should > now only be displayed when dataplane debug logs are enabled. > > The issue occurs only if the default log level (CONFIG_RTE_LOG_LEVEL) is > set to DEBUG in the configuration, which is not the case by defa

Re: [dpdk-dev] [PATCH] eal: fail eal when no hugepages were found

2017-01-29 Thread Thomas Monjalon
2017-01-24 21:22, Emmanuel Roullit: > Found with clang static analysis: > lib/librte_eal/linuxapp/eal/eal_memory.c:1004:11: > warning: Call to 'malloc' has an allocation size of 0 bytes > tmp_hp = malloc(nr_hugepages * sizeof(struct hugepage_file)); > ^~

Re: [dpdk-dev] [PATCH] eal: reset driver name pointer on failure

2017-01-29 Thread Thomas Monjalon
2017-01-24 21:26, Emmanuel Roullit: > The pointer set by strdup() needs to be cleared on failure to avoid a > potential double-free from the caller. > > Found with clang static analysis: > lib/librte_eal/common/eal_common_devargs.c:123:2: > warning: Attempt to free released memory > free(b

Re: [dpdk-dev] [PATCH] mempool: fix stack handler dequeue

2017-01-29 Thread Thomas Monjalon
2017-01-23 18:11, Olivier Matz: > The return value of the stack handler is wrong: it should be 0 on > success, not the number of objects dequeued. > > This could lead to memory leaks depending on how the caller checks the > return value (ret < 0 or ret != 0). This was also breaking autotests > wit

[dpdk-dev] rte_port_ring and SP/MP, SC/MC flags

2017-01-29 Thread Yerden Zhumabekov
Hello, I'd like to use rte_port_ring abstract in my application and I'm a little confused about how it treats underlying ring flags. According to DPDK API reference, when creating a ring (via rte_ring_create()/rte_ring_init()), RING_F_SP_ENQ/RING_F_SC_DEQ may be specified. These flags affect