Re: [dpdk-dev] [PATCH v2 01/12] eal: define container_of macro

2016-12-16 Thread Jan Blunck
On Wed, Dec 14, 2016 at 6:12 AM, Shreyansh Jain wrote: > On Wednesday 14 December 2016 03:54 AM, Jan Blunck wrote: >> >> On Tue, Dec 13, 2016 at 2:37 PM, Shreyansh Jain >> wrote: >>> >>> From: Jan Blunck >>> >>> This macro is based on Jan Viktorin's original patch but also checks the >>> type of

Re: [dpdk-dev] [PATCH 00/22] Generic flow API (rte_flow)

2016-12-16 Thread Adrien Mazarguil
On Thu, Dec 15, 2016 at 12:20:36PM +, Ferruh Yigit wrote: > On 12/8/2016 3:19 PM, Adrien Mazarguil wrote: > > Hi Ferruh, > > > > On Fri, Dec 02, 2016 at 04:58:53PM +, Ferruh Yigit wrote: > >> Hi Adrien, > >> > >> On 11/16/2016 4:23 PM, Adrien Mazarguil wrote: > >>> As previously discussed

Re: [dpdk-dev] [PATCH v3] drivers: advertise kmod dependencies in pmdinfo

2016-12-16 Thread Adrien Mazarguil
On Thu, Dec 15, 2016 at 02:46:39PM +0100, Olivier Matz wrote: > Add a new macro RTE_PMD_REGISTER_KMOD_DEP() that allows a driver to > declare the list of kernel modules required to run properly. > > Today, most PCI drivers require uio/vfio. > > Signed-off-by: Olivier Matz > Acked-by: Fiona Trahe

Re: [dpdk-dev] [PATCH 12/22] app/testpmd: add rte_flow item spec handler

2016-12-16 Thread Adrien Mazarguil
Hi Yulong, On Fri, Dec 16, 2016 at 03:01:15AM +, Pei, Yulong wrote: > Hi Adrien, > > I try to setup the following rule, but it seems that after set 'spec' param, > can not set 'mask' param, is it an issue here or am I wrong to use it ? > > testpmd> flow create 0 ingress pattern eth dst sp

Re: [dpdk-dev] [PATCH v3] drivers: advertise kmod dependencies in pmdinfo

2016-12-16 Thread Olivier Matz
Hi, On Thu, 15 Dec 2016 09:22:07 -0800, Stephen Hemminger wrote: > On Thu, 15 Dec 2016 11:09:12 -0500 > Neil Horman wrote: > > > On Thu, Dec 15, 2016 at 02:46:39PM +0100, Olivier Matz wrote: > > > Add a new macro RTE_PMD_REGISTER_KMOD_DEP() that allows a driver > > > to declare the list of ke

Re: [dpdk-dev] [PATCH v2 01/12] eal: define container_of macro

2016-12-16 Thread Adrien Mazarguil
On Fri, Dec 16, 2016 at 09:14:29AM +0100, Jan Blunck wrote: > On Wed, Dec 14, 2016 at 6:12 AM, Shreyansh Jain > wrote: > > On Wednesday 14 December 2016 03:54 AM, Jan Blunck wrote: > >> > >> On Tue, Dec 13, 2016 at 2:37 PM, Shreyansh Jain > >> wrote: > >>> > >>> From: Jan Blunck > >>> > >>> Thi

Re: [dpdk-dev] [PATCH v3] drivers: advertise kmod dependencies in pmdinfo

2016-12-16 Thread Olivier Matz
Hi Ferruh, On Thu, 15 Dec 2016 14:52:02 +, Ferruh Yigit wrote: > Hi Olivier, Thomas, > > On 12/15/2016 1:46 PM, Olivier Matz wrote: > > Add a new macro RTE_PMD_REGISTER_KMOD_DEP() that allows a driver to > > declare the list of kernel modules required to run properly. > > > > Today, most PC

[dpdk-dev] [PATCH 2/2] ethdev: clarify xstats Api documentation

2016-12-16 Thread Olivier Matz
Reword the Api documentation of xstats ethdev. CC: sta...@dpdk.org Signed-off-by: Olivier Matz --- lib/librte_ether/rte_ethdev.h | 45 --- 1 file changed, 25 insertions(+), 20 deletions(-) diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_

[dpdk-dev] [PATCH 1/2] ethdev: fix name index in xstats Api

2016-12-16 Thread Olivier Matz
The function rte_eth_xstats_get() return an array of tuples (id, value). The value is the statistic counter, while the id references a name in the array returned by rte_eth_xstats_get_name(). Today, each 'id' returned by rte_eth_xstats_get() is equal to the index in the returned array, making this

Re: [dpdk-dev] [PATCH v2 00/32] Support more features in Solarflare PMD

2016-12-16 Thread Ferruh Yigit
On 12/15/2016 12:50 PM, Andrew Rybchenko wrote: > The patch series adds a number of features to Solarflare libefx-based > PMD. Basically one patch per feature. > > The patches are grouped into one series since they touch nearby lines > in either PMD feature list, or dev_ops structure, or documenta

Re: [dpdk-dev] [PATCH 07/13] pcap: fix timestamps in output pcap file

2016-12-16 Thread Ferruh Yigit
On 12/14/2016 5:45 PM, Ferruh Yigit wrote: > On 12/13/2016 1:08 AM, Michał Mirosław wrote: >> From: Piotr Bartosiewicz >> >> Signed-off-by: Michał Mirosław >> --- > > Acked-by: Ferruh Yigit > CC: sta...@dpdk.org Applied to dpdk-next-net/master, thanks.

Re: [dpdk-dev] [PATCH 1/4] rte_mbuf: add rte_pktmbuf_coalesce

2016-12-16 Thread Olivier Matz
Hi Tomasz, On Fri, 2 Dec 2016 18:07:43 +0100, Tomasz Kulasek wrote: > This patch adds function rte_pktmbuf_coalesce to let crypto PMD > coalesce chained mbuf before crypto operation and extend their > capabilities to support segmented mbufs when device cannot handle > them natively. > > > Sign

Re: [dpdk-dev] [PATCH 13/28] eal/arm64: override I/O device read/write access for arm64

2016-12-16 Thread Jianbo Liu
On 15 December 2016 at 19:08, Jerin Jacob wrote: > On Thu, Dec 15, 2016 at 06:17:32PM +0800, Jianbo Liu wrote: >> On 15 December 2016 at 18:04, Jerin Jacob >> wrote: >> > On Thu, Dec 15, 2016 at 05:53:05PM +0800, Jianbo Liu wrote: >> >> On 14 December 2016 at 09:55, Jerin Jacob >> >> wrote: >> >

Re: [dpdk-dev] [PATCH 1/4] eal/common: introduce rte_memset on IA platform

2016-12-16 Thread Yang, Zhiyong
Hi, Bruce: > -Original Message- > From: Richardson, Bruce > Sent: Thursday, December 15, 2016 6:13 PM > To: Yang, Zhiyong > Cc: Ananyev, Konstantin ; Thomas > Monjalon ; dev@dpdk.org; > yuanhan@linux.intel.com; De Lara Guarch, Pablo > > Subject: Re: [dpdk-dev] [PATCH 1/4] eal/common:

Re: [dpdk-dev] [PATCH 13/28] eal/arm64: override I/O device read/write access for arm64

2016-12-16 Thread Jerin Jacob
On Fri, Dec 16, 2016 at 06:12:13PM +0800, Jianbo Liu wrote: > On 15 December 2016 at 19:08, Jerin Jacob > wrote: > > On Thu, Dec 15, 2016 at 06:17:32PM +0800, Jianbo Liu wrote: > >> On 15 December 2016 at 18:04, Jerin Jacob > >> wrote: > >> > On Thu, Dec 15, 2016 at 05:53:05PM +0800, Jianbo Liu w

Re: [dpdk-dev] [PATCH] doc: Fix a typo in testpmd application user guide.

2016-12-16 Thread Mcnamara, John
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Rami Rosen > Sent: Thursday, December 15, 2016 9:03 PM > To: dev@dpdk.org > Cc: Rosen, Rami > Subject: [dpdk-dev] [PATCH] doc: Fix a typo in testpmd application user > guide. > > This patch fixes a trivial typo

Re: [dpdk-dev] [PATCH v2 4/4] doc: add ixgbe specific APIs

2016-12-16 Thread Mcnamara, John
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Tiwei Bie > Sent: Friday, December 16, 2016 1:44 AM > To: dev@dpdk.org > Cc: Lu, Wenzhuo ; Dai, Wei ; > Wang, Xiao W ; Ananyev, Konstantin > ; Zhang, Helin > Subject: [dpdk-dev] [PATCH v2 4/4] doc: add ixgbe spec

Re: [dpdk-dev] [PATCH] crypto/openssl: fix extra bytes being written at end of data

2016-12-16 Thread De Lara Guarch, Pablo
> -Original Message- > From: Azarewicz, PiotrX T > Sent: Wednesday, December 07, 2016 10:46 AM > To: De Lara Guarch, Pablo > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: [PATCH] crypto/openssl: fix extra bytes being written at end of > data > > Extra bytes are being written at end of dat

Re: [dpdk-dev] [PATCH v2 09/13] PMD/af_packet: guard against buffer overruns in TX path

2016-12-16 Thread Ferruh Yigit
On 12/13/2016 4:06 PM, John W. Linville wrote: > On Tue, Dec 13, 2016 at 02:28:34AM +0100, Michał Mirosław wrote: >> Signed-off-by: Michał Mirosław > > Acked-by: John W. Linville > Applied to dpdk-next-net/master, thanks.

Re: [dpdk-dev] [PATCH v2 08/13] PMD/af_packet: guard against buffer overruns in RX path

2016-12-16 Thread Ferruh Yigit
On 12/13/2016 4:05 PM, John W. Linville wrote: > On Tue, Dec 13, 2016 at 02:28:34AM +0100, Michał Mirosław wrote: >> >> Signed-off-by: Michał Mirosław > > Acked-by: John W. Linville > Applied to dpdk-next-net/master, thanks.

Re: [dpdk-dev] [PATCH v2 01/12] eal: define container_of macro

2016-12-16 Thread Jan Blunck
On Fri, Dec 16, 2016 at 10:23 AM, Adrien Mazarguil wrote: > On Fri, Dec 16, 2016 at 09:14:29AM +0100, Jan Blunck wrote: >> On Wed, Dec 14, 2016 at 6:12 AM, Shreyansh Jain >> wrote: >> > On Wednesday 14 December 2016 03:54 AM, Jan Blunck wrote: >> >> >> >> On Tue, Dec 13, 2016 at 2:37 PM, Shreyan

Re: [dpdk-dev] [PATCH v2] crypto/qat: fix to avoid buffer overwrite in OOP case

2016-12-16 Thread Griffin, John
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Fiona Trahe > Sent: Friday, December 9, 2016 3:39 PM > To: dev@dpdk.org > Cc: De Lara Guarch, Pablo ; Trahe, Fiona > ; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH v2] crypto/qat: fix to avoid buffer overwrite in

Re: [dpdk-dev] [PATCH v2 01/12] eal: define container_of macro

2016-12-16 Thread Adrien Mazarguil
On Fri, Dec 16, 2016 at 11:47:14AM +0100, Jan Blunck wrote: > On Fri, Dec 16, 2016 at 10:23 AM, Adrien Mazarguil > wrote: > > On Fri, Dec 16, 2016 at 09:14:29AM +0100, Jan Blunck wrote: > >> On Wed, Dec 14, 2016 at 6:12 AM, Shreyansh Jain > >> wrote: > >> > On Wednesday 14 December 2016 03:54 AM

Re: [dpdk-dev] [PATCH 1/4] eal/common: introduce rte_memset on IA platform

2016-12-16 Thread Ananyev, Konstantin
Hi Zhiyong, > > > > > > > > > > > extern void *(*__rte_memset_vector)( (void *s, int c, size_t n); > > > > > > > > > > static inline void* > > > > > rte_memset_huge(void *s, int c, size_t n) { > > > > >return __rte_memset_vector(s, c, n); } > > > > > > > > > > static inline void * > > > > > rt

Re: [dpdk-dev] [PATCH v2 01/12] eal: define container_of macro

2016-12-16 Thread Shreyansh Jain
On Friday 16 December 2016 04:51 PM, Adrien Mazarguil wrote: On Fri, Dec 16, 2016 at 11:47:14AM +0100, Jan Blunck wrote: On Fri, Dec 16, 2016 at 10:23 AM, Adrien Mazarguil wrote: On Fri, Dec 16, 2016 at 09:14:29AM +0100, Jan Blunck wrote: On Wed, Dec 14, 2016 at 6:12 AM, Shreyansh Jain wrote

Re: [dpdk-dev] [PATCH 12/22] app/testpmd: add rte_flow item spec handler

2016-12-16 Thread Xing, Beilei
Thanks Adrien. I have two questions: 1. when I set " / vlan tci fix 10" with testpmd, I find the mask of tci is 0x. Actually tci includes PRI, CFI, and Vlan_id which holds 12 bits, so is it possible to set the mask to 0xFFF? Our driver will check the mask only covers vlan_id

Re: [dpdk-dev] [PATCH v3] drivers: advertise kmod dependencies in pmdinfo

2016-12-16 Thread Neil Horman
On Fri, Dec 16, 2016 at 10:22:08AM +0100, Olivier Matz wrote: > Hi, > > On Thu, 15 Dec 2016 09:22:07 -0800, Stephen Hemminger > wrote: > > On Thu, 15 Dec 2016 11:09:12 -0500 > > Neil Horman wrote: > > > > > On Thu, Dec 15, 2016 at 02:46:39PM +0100, Olivier Matz wrote: > > > > Add a new macro

[dpdk-dev] [PATCH 0/3] New API to free consumed buffers in TX ring

2016-12-16 Thread Billy McFall
Based on a request from Damjan Marion and seconded by Keith Wiles, see dpdk-dev mailling list from 11/21/2016, add a new API to free consumed buffers on TX ring. This addresses two scenarios: 1) Flooding a packet and want to reuse existing mbuf to avoid a packet copy. Increment the reference count

[dpdk-dev] [PATCH 2/3] driver: e1000 igb support to free consumed buffers

2016-12-16 Thread Billy McFall
Add support to the e1000 igb driver for the new API to force free consumed buffers on TX ring. e1000 igb driver does not implement a tx_rs_thresh to free mbufs, it frees a slot in the ring as needed, so a new function needed to be written. Signed-off-by: Billy McFall --- drivers/net/e1000/e1000_

[dpdk-dev] [PATCH 3/3] driver: vHost support to free consumed buffers

2016-12-16 Thread Billy McFall
Add support to the vHostdriver for the new API to force free consumed buffers on TX ring. vHost does not cache the mbufs so there is no work to do. Signed-off-by: Billy McFall --- drivers/net/vhost/rte_eth_vhost.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/net/vhost

[dpdk-dev] [PATCH 1/3] ethdev: New API to free consumed buffers in TX ring

2016-12-16 Thread Billy McFall
Add a new API to force free consumed buffers on TX ring. API will return the number of packets freed (0-n) or error code if feature not supported (-ENOTSUP) or input invalid (-ENODEV). Because rte_eth_tx_buffer() may be used, and mbufs may still be held in local buffer, the API also accepts *buffe

Re: [dpdk-dev] [PATCH v3] drivers: advertise kmod dependencies in pmdinfo

2016-12-16 Thread Bruce Richardson
On Fri, Dec 16, 2016 at 07:37:38AM -0500, Neil Horman wrote: > On Fri, Dec 16, 2016 at 10:22:08AM +0100, Olivier Matz wrote: > > Hi, > > > > On Thu, 15 Dec 2016 09:22:07 -0800, Stephen Hemminger > > wrote: > > > On Thu, 15 Dec 2016 11:09:12 -0500 > > > Neil Horman wrote: > > > > > > > On Thu, D

[dpdk-dev] [PATCH v3 00/12] Introducing EAL Bus-Device-Driver Model

2016-12-16 Thread Shreyansh Jain
Link to v1: [10] Link to v2: [11] :: Introduction :: DPDK has been inherently a PCI inclined framework. Because of this, the design of device tree (or list) within DPDK is also PCI inclined. A non-PCI device doesn't have a way of being expressed without using hooks started from EAL to PMD. (Chec

[dpdk-dev] [PATCH v3 01/12] eal: define container_of macro

2016-12-16 Thread Shreyansh Jain
From: Jan Blunck This macro is based on Jan Viktorin's original patch but also checks the type of the passed pointer against the type of the member. Signed-off-by: Jan Viktorin Signed-off-by: Shreyansh Jain [jblu...@infradead.org: add type checking and __extension__] Signed-off-by: Jan Blunck

[dpdk-dev] [PATCH v3 02/12] eal/bus: introduce bus abstraction

2016-12-16 Thread Shreyansh Jain
This patch introduces the rte_bus abstraction for devices and drivers in EAL framework. The model is: - One or more buses are connected to a CPU (or core) - One or more devices are conneted to a Bus - Drivers are running instances which manage one or more devices - Bus is responsible for identi

[dpdk-dev] [PATCH v3 03/12] test: add basic bus infrastructure tests

2016-12-16 Thread Shreyansh Jain
Verification of bus registration, driver registration on a bus. Signed-off-by: Shreyansh Jain --- app/test/Makefile | 2 +- app/test/test.h | 2 + app/test/test_bus.c | 423 3 files changed, 426 insertions(+), 1 deletion(-) create m

[dpdk-dev] [PATCH v3 04/12] eal/bus: add scan, match and insert support

2016-12-16 Thread Shreyansh Jain
When a PMD is registred, it will associate itself with a bus. A bus is responsible for 'scan' of all the devices attached to it. All the scanned devices are attached to bus specific device_list. During the probe operation, 'match' of the drivers and devices would be done. Also, rather than adding

[dpdk-dev] [PATCH v3 05/12] eal: integrate bus scan and probe with EAL

2016-12-16 Thread Shreyansh Jain
Still a dummy implementation as no real bus driver exists. This adds calls from EAL to bus specific scan, match functions. Once driver->probe is in place, and a bus handler has been installed, the code would become effective. Signed-off-by: Shreyansh Jain --- lib/librte_eal/bsdapp/eal/eal.c

[dpdk-dev] [PATCH v3 06/12] eal: add probe and remove support for rte_driver

2016-12-16 Thread Shreyansh Jain
rte_driver now supports probe and remove. These would be used for generic device type (PCI, etc) probe and remove. Signed-off-by: Shreyansh Jain --- lib/librte_eal/common/include/rte_dev.h | 12 1 file changed, 12 insertions(+) diff --git a/lib/librte_eal/common/include/rte_dev.h

[dpdk-dev] [PATCH v3 07/12] eal: enable probe from bus infrastructure

2016-12-16 Thread Shreyansh Jain
The model is: rte_eal_init `--> calls rte_eal_bus_probe() This iterates over all the drivers and devices and matches them. For matched bus specific device-driver and calls: `-> rte_driver->probe() for all matched device/drivers (rte_bus->match() successful) T

[dpdk-dev] [PATCH v3 09/12] eal/pci: generalize args of PCI scan/match towards RTE device/driver

2016-12-16 Thread Shreyansh Jain
PCI scan and match now work on rte_device/rte_driver rather than PCI specific objects. These functions can now be plugged to the generic bus callbacks for scanning and matching devices/drivers. Signed-off-by: Shreyansh Jain --- app/test/test_pci.c | 2 +- lib/librte_eal/bsda

[dpdk-dev] [PATCH v3 08/12] pci: split match and probe function

2016-12-16 Thread Shreyansh Jain
Matching of PCI device address and driver ID table is being done at two discreet locations duplicating the code. (rte_eal_pci_probe_one_driver and rte_eal_pci_detach_dev). Splitting the matching function into rte_eal_pci_match. Signed-off-by: Shreyansh Jain --- lib/librte_eal/common/eal_common_

[dpdk-dev] [PATCH v3 10/12] pci: Pass rte_pci_addr to functions instead of separate args

2016-12-16 Thread Shreyansh Jain
From: Ben Walker Instead of passing domain, bus, devid, func, just pass an rte_pci_addr. Signed-off-by: Ben Walker [Shreyansh: Checkpatch error fix] Signed-off-by: Shreyansh Jain --- lib/librte_eal/linuxapp/eal/eal_pci.c | 33 ++--- 1 file changed, 14 insertions(+)

[dpdk-dev] [PATCH v3 12/12] drivers: update PMDs to use rte_driver probe and remove

2016-12-16 Thread Shreyansh Jain
These callbacks now act as first layer of PCI interfaces from the Bus. Bus probe would enter the PMDs through the rte_driver->probe/remove callbacks, falling to rte_xxx_driver->probe/remove (Currently, all the drivers are rte_pci_driver). This patch also changes QAT which is the only crypto PMD ba

[dpdk-dev] [PATCH v3 11/12] eal: enable PCI bus and PCI test framework

2016-12-16 Thread Shreyansh Jain
Register a PCI bus with Scan/match and probe callbacks. Necessary changes in EAL layer for enabling bus interfaces. PCI devices and drivers now reside within the Bus object. Now that PCI bus handles the scan/probe methods, independent calls to PCI scan and probe can be removed from the code. PCI d

Re: [dpdk-dev] [PATCH v3 11/12] eal: enable PCI bus and PCI test framework

2016-12-16 Thread Shreyansh Jain
On Friday 16 December 2016 06:40 PM, Shreyansh Jain wrote: Register a PCI bus with Scan/match and probe callbacks. Necessary changes in EAL layer for enabling bus interfaces. PCI devices and drivers now reside within the Bus object. Now that PCI bus handles the scan/probe methods, independent ca

Re: [dpdk-dev] [PATCH v3 04/12] eal/bus: add scan, match and insert support

2016-12-16 Thread Shreyansh Jain
On Friday 16 December 2016 06:40 PM, Shreyansh Jain wrote: When a PMD is registred, it will associate itself with a bus. A bus is responsible for 'scan' of all the devices attached to it. All the scanned devices are attached to bus specific device_list. During the probe operation, 'match' of the

Re: [dpdk-dev] [PATCH v12 0/6] add Tx preparation

2016-12-16 Thread Jan Mędala
​Hello, ​ > Is there any update on that subject? > ​At this point we need to have only pseudo-header checksum for TSO. Maybe there will be new requirements, but that's something I cannot predict at this point. ​ > So it seems that standard pseudo-header checksum calculation should be > enough.

Re: [dpdk-dev] [PATCH v3] drivers: advertise kmod dependencies in pmdinfo

2016-12-16 Thread Ferruh Yigit
On 12/16/2016 12:37 PM, Neil Horman wrote: > On Fri, Dec 16, 2016 at 10:22:08AM +0100, Olivier Matz wrote: >> Hi, >> >> On Thu, 15 Dec 2016 09:22:07 -0800, Stephen Hemminger >> wrote: >>> On Thu, 15 Dec 2016 11:09:12 -0500 >>> Neil Horman wrote: >>> On Thu, Dec 15, 2016 at 02:46:39PM +0100,

Re: [dpdk-dev] [PATCH v3 00/29] Support VFD and DPDK PF + kernel VF on i40e

2016-12-16 Thread Ferruh Yigit
On 12/15/2016 9:04 PM, Qi Zhang wrote: > 1, VF Daemon (VFD) > VFD is an idea to control all the VFs from PF. > As we need to support the scenario kernel PF + DPDK VF, > DPDK follows the interface between kernel PF + kernel VF. > We don't want to introduce too many new messages between PF and VF.

Re: [dpdk-dev] [dpdk-stable] [PATCH 2/2] ethdev: clarify xstats Api documentation

2016-12-16 Thread Mcnamara, John
> -Original Message- > From: stable [mailto:stable-boun...@dpdk.org] On Behalf Of Olivier Matz > Sent: Friday, December 16, 2016 9:44 AM > To: dev@dpdk.org; thomas.monja...@6wind.com > Cc: Horton, Remy ; sta...@dpdk.org > Subject: [dpdk-stable] [PATCH 2/2] ethdev: clarify xstats Api > docum

Re: [dpdk-dev] [dpdk-stable] [PATCH 2/2] ethdev: clarify xstats Api documentation

2016-12-16 Thread Olivier Matz
Hi John, On Fri, 16 Dec 2016 14:28:21 +, "Mcnamara, John" wrote: > > -Original Message- > > From: stable [mailto:stable-boun...@dpdk.org] On Behalf Of Olivier > > Matz Sent: Friday, December 16, 2016 9:44 AM > > To: dev@dpdk.org; thomas.monja...@6wind.com > > Cc: Horton, Remy ; sta...

[dpdk-dev] [PATCH v4 00/29] Support VFD and DPDK PF + kernel VF on i40e

2016-12-16 Thread Ferruh Yigit
1, VF Daemon (VFD) VFD is an idea to control all the VFs from PF. As we need to support the scenario kernel PF + DPDK VF, DPDK follows the interface between kernel PF + kernel VF. We don't want to introduce too many new messages between PF and VF. So this patch set adds some new APIs to control

[dpdk-dev] [PATCH v4 01/29] net/i40e: support link status notification

2016-12-16 Thread Ferruh Yigit
From: Wenzhuo Lu Add an API to expose the ability, that PF can notify VF when link status changes, to APP. So if PF APP doesn't want to enable interruption but check link status by itself, PF APP can let VF know link status changed. Signed-off-by: Wenzhuo Lu --- drivers/net/i40e/Makefile

[dpdk-dev] [PATCH v4 02/29] net/i40e: add callback to user on VF to PF mbox msg

2016-12-16 Thread Ferruh Yigit
From: Wenzhuo Lu The callback asks the user application if it is allowed to perform the mailbox messages. If the return value from user is RTE_PMD_I40E_MB_EVENT_PROCEED then continue. If ACK or NACK, do nothing and send not_supported to VF. Signed-off-by: Wenzhuo Lu --- drivers/net/i40e/i40e_

[dpdk-dev] [PATCH v4 05/29] net/i40e: set Tx loopback from PF

2016-12-16 Thread Ferruh Yigit
From: Wenzhuo Lu Support enabling/disabling TX loopback from PF. User can call the API on PF to enable/disable TX loopback for all the PF and VFs. Signed-off-by: Wenzhuo Lu --- drivers/net/i40e/i40e_ethdev.c| 219 ++ drivers/net/i40e/rte_pmd_i40e.h

[dpdk-dev] [PATCH v4 04/29] net/i40e: set VF VLAN anti-spoofing from PF

2016-12-16 Thread Ferruh Yigit
From: Wenzhuo Lu Support enabling/disabling VF VLAN anti-spoofing from PF. User can call the API on PF to enable/disable a specific VF's VLAN anti-spoofing. Signed-off-by: Wenzhuo Lu --- drivers/net/i40e/i40e_ethdev.c| 116 +- drivers/net/i40e/i40e_ethde

[dpdk-dev] [PATCH v4 03/29] net/i40e: set VF MAC anti-spoofing from PF

2016-12-16 Thread Ferruh Yigit
From: Wenzhuo Lu Support enabling/disabling VF MAC anti-spoofing from PF. User can call the API on PF to enable/disable a specific VF's MAC anti-spoofing. Signed-off-by: Wenzhuo Lu --- drivers/net/i40e/i40e_ethdev.c| 63 +++ drivers/net/i40e/rte_pmd_i40e

[dpdk-dev] [PATCH v4 06/29] net/i40e: set VF unicast promisc mode from PF

2016-12-16 Thread Ferruh Yigit
From: Wenzhuo Lu Support enabling/disabling VF unicast promiscuous mode from PF. User can call the API on PF to enable/disable a specific VF's unicast promiscuous mode. Signed-off-by: Wenzhuo Lu --- drivers/net/i40e/i40e_ethdev.c| 36 +++ drivers/net/i40

[dpdk-dev] [PATCH v4 07/29] net/i40e: set VF multicast promisc mode from PF

2016-12-16 Thread Ferruh Yigit
From: Wenzhuo Lu Support enabling/disabling VF multicast promiscuous mode from PF. User can call the API on PF to enable/disable a specific VF's multicast promiscuous mode. Signed-off-by: Wenzhuo Lu --- drivers/net/i40e/i40e_ethdev.c| 36 +++ drivers/net

[dpdk-dev] [PATCH v4 08/29] net/i40e: enable VF MTU change

2016-12-16 Thread Ferruh Yigit
From: Qi Zhang This patch implement mtu_set ops for i40e VF. Signed-off-by: Qi Zhang --- drivers/net/i40e/i40e_ethdev_vf.c | 33 + 1 file changed, 33 insertions(+) diff --git a/drivers/net/i40e/i40e_ethdev_vf.c b/drivers/net/i40e/i40e_ethdev_vf.c index 12da0ec

[dpdk-dev] [PATCH v4 09/29] net/i40e: fix VF reset flow

2016-12-16 Thread Ferruh Yigit
From: Qi Zhang Add missing step during VF reset: PF should set I40E_VFGEN_RSTAT to ACTIVE at end of the VF reset operation or VF driver may not able to detect that reset is already completed. This patch also remove the unnecessary enum for vfr state. Fixes: 4861cde46116 ("i40e: new poll mode dri

[dpdk-dev] [PATCH v4 11/29] net/i40e: set VF MAC from VF support

2016-12-16 Thread Ferruh Yigit
Support changing VF default MAC address. This function is not supported if PF set the MAC address for the PF. Signed-off-by: Ferruh Yigit --- drivers/net/i40e/i40e_ethdev.h| 4 +++- drivers/net/i40e/i40e_ethdev_vf.c | 49 +-- 2 files changed, 45 insertion

[dpdk-dev] [PATCH v4 12/29] net/i40e: fix VF MAC address assignment

2016-12-16 Thread Ferruh Yigit
If PF sets vf->mac_addr, in VF initialization hw->mac.addr will be set to that same value. It is possible to check if PF set a MAC address or not through the hw->mac.addr variable. hw->mac.addr set by i40e_vf_parse_hw_config(), call stack is: In PF side i40e_pf_host_process_cmd_get_vf_resources()

[dpdk-dev] [PATCH v4 10/29] net/i40e: set VF MAC from PF support

2016-12-16 Thread Ferruh Yigit
Support setting VF MAC address from PF. User can call the API on PF to set a specific VF's MAC address. This will remove all existing MAC filters. Signed-off-by: Ferruh Yigit --- drivers/net/i40e/i40e_ethdev.c| 40 +++ drivers/net/i40e/rte_pmd_i40e.h

[dpdk-dev] [PATCH v4 13/29] net/i40e: add VF VLAN strip func

2016-12-16 Thread Ferruh Yigit
From: "Chen Jing D(Mark)" Add a function to configure vlan strip enable/disable for specific SRIOV VF device. Signed-off-by: Chen Jing D(Mark) --- drivers/net/i40e/i40e_ethdev.c| 26 ++ drivers/net/i40e/rte_pmd_i40e.h | 19 +++ driv

[dpdk-dev] [PATCH v4 15/29] net/i40e: set VF broadcast mode from PF

2016-12-16 Thread Ferruh Yigit
From: Bernard Iremonger Support enabling/disabling VF broadcast mode from PF. User can call the API on PF to enable/disable a specific VF's broadcast mode. Signed-off-by: Bernard Iremonger --- drivers/net/i40e/i40e_ethdev.c| 43 +++ drivers/net/i40e/rte_

[dpdk-dev] [PATCH v4 14/29] net/i40e: add set VF VLAN insert function

2016-12-16 Thread Ferruh Yigit
From: Bernard Iremonger Support inserting VF VLAN id from PF. User can call the API on PF to insert a VLAN id to a specific VF. Signed-off-by: Bernard Iremonger --- drivers/net/i40e/i40e_ethdev.c| 53 +++ drivers/net/i40e/rte_pmd_i40e.h | 19 ++

[dpdk-dev] [PATCH v4 17/29] net/i40e: set VF VLAN filter from PF

2016-12-16 Thread Ferruh Yigit
From: Bernard Iremonger add rte_pmd_i40e_set_vf_vlan_filter API. User can call the API on PF to enable/disable a set of VF's VLAN filters. Signed-off-by: Bernard Iremonger --- drivers/net/i40e/i40e_ethdev.c| 52 +++ drivers/net/i40e/rte_pmd_i40e.h

[dpdk-dev] [PATCH v4 18/29] app/testpmd: use VFD APIs on i40e

2016-12-16 Thread Ferruh Yigit
From: Wenzhuo Lu The new VF Daemon (VFD) APIs is implemented on i40e. Change testpmd code to use them, including VF MAC anti-spoofing, VF VLAN anti-spoofing, TX loopback, VF VLAN strip, VF VLAN insert. Signed-off-by: Wenzhuo Lu Signed-off-by: Chen Jing D(Mark) Signed-off-by: Bernard Iremonger

[dpdk-dev] [PATCH v4 20/29] app/testpmd: use multicast promiscuous mode on i40e

2016-12-16 Thread Ferruh Yigit
From: Wenzhuo Lu Add testpmd CLI to set VF multicast promiscuous mode on i40e. Signed-off-by: Wenzhuo Lu --- app/test-pmd/cmdline.c | 86 + doc/guides/testpmd_app_ug/testpmd_funcs.rst | 9 +++ 2 files changed, 95 insertions(+) diff --git a/app

[dpdk-dev] [PATCH v4 19/29] app/testpmd: use unicast promiscuous mode on i40e

2016-12-16 Thread Ferruh Yigit
From: Wenzhuo Lu Add testpmd CLI to set VF unicast promiscuous mode on i40e. Signed-off-by: Wenzhuo Lu --- app/test-pmd/cmdline.c | 86 + doc/guides/testpmd_app_ug/testpmd_funcs.rst | 9 +++ 2 files changed, 95 insertions(+) diff --git a/app/t

[dpdk-dev] [PATCH v4 21/29] app/testpmd: add command to test VF broadcast mode on i40e

2016-12-16 Thread Ferruh Yigit
From: Bernard Iremonger Add command to call rte_pmd_i40e_set_vf_broadcast. Add set vf broadcast in testpmd_funcs.rst file. Signed-off-by: Bernard Iremonger --- app/test-pmd/cmdline.c | 85 + doc/guides/testpmd_app_ug/testpmd_funcs.rst | 7 +++

[dpdk-dev] [PATCH v4 22/29] app/testpmd: add command to test VF VLAN tag on i40e

2016-12-16 Thread Ferruh Yigit
From: Bernard Iremonger command is: set vf vlan tag port_id vf_id on|off Signed-off-by: Bernard Iremonger --- app/test-pmd/cmdline.c | 91 + doc/guides/testpmd_app_ug/testpmd_funcs.rst | 7 +++ 2 files changed, 98 insertions(+) diff --git a/ap

[dpdk-dev] [PATCH v4 23/29] app/testpmd: handle i40e in VF VLAN filter command

2016-12-16 Thread Ferruh Yigit
From: Bernard Iremonger modify set_vf_rx_vlan function to handle the i40e PMD. Signed-off-by: Bernard Iremonger --- app/test-pmd/config.c | 17 +++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index fc0424a..c5da9b1

[dpdk-dev] [PATCH v4 26/29] net/i40e: parse more VF parameter and configure

2016-12-16 Thread Ferruh Yigit
From: "Chen Jing D(Mark)" When VF requested to configure TX queue, a few parameters are missed to be configured in PF host. This change have more fields parsed and configured for TX context. Signed-off-by: Chen Jing D(Mark) --- drivers/net/i40e/i40e_pf.c | 4 +++- 1 file changed, 3 insertions(

[dpdk-dev] [PATCH v4 25/29] net/i40e: return correct VSI id

2016-12-16 Thread Ferruh Yigit
From: "Chen Jing D(Mark)" PF host didn't return correct VSI id to VF. This change fix it. Signed-off-by: Chen Jing D(Mark) --- drivers/net/i40e/i40e_pf.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/i40e/i40e_pf.c b/drivers/net/i40e/i40e_pf.c index 0f582ed.

[dpdk-dev] [PATCH v4 27/29] net/i40e: support Linux VF to configure IRQ link list

2016-12-16 Thread Ferruh Yigit
From: "Chen Jing D(Mark)" i40e PF host only support to work with DPDK VF driver, Linux VF driver is not supported. This change will enhance in configuring IRQ link list. This Change will identify VF client by number of vector requested. DPDK VF will ask only single one while Linux VF will reques

[dpdk-dev] [PATCH v4 24/29] net/i40e: change version number to support Linux VF

2016-12-16 Thread Ferruh Yigit
From: "Chen Jing D(Mark)" i40e PF host only support to work with DPDK VF driver, Linux VF driver is not supported. This change will enhance in version number returned. Current version info returned won't be able to be recognized by Linux VF driver, change to values that both DPDK VF and Linux dr

[dpdk-dev] [PATCH v4 29/29] net/i40e: set/clear VF stats from PF

2016-12-16 Thread Ferruh Yigit
From: Qi Zhang This patch add support to get/clear VF statistics from PF side. Two APIs are added: rte_pmd_i40e_get_vf_stats. rte_pmd_i40e_reset_vf_stats. Signed-off-by: Qi Zhang --- drivers/net/i40e/i40e_ethdev.c| 76 +++ drivers/net/i40e/rte_pmd_i40e.h

[dpdk-dev] [PATCH v4 28/29] net/i40e: enhance in sanity check of MAC

2016-12-16 Thread Ferruh Yigit
From: "Chen Jing D(Mark)" When VF sends request to add a new MAC address, PF host will check if it's a non-zero or unicast address, or it will return with error. In fact, VF still can set multicast address. This change remove to check if it's a unicast address. Signed-off-by: Chen Jing D(Mark)

Re: [dpdk-dev] [PATCH v4 00/29] Support VFD and DPDK PF + kernel VF on i40e

2016-12-16 Thread Vincent Jardin
I do not see test to validate that the PF userland will look like a Linux PF. I am getting concerned that it is a bad solution since we have two/three PF mailboxes which may not be consistent: Linux, DPDK, VMware. Le 16 décembre 2016 3:39:36 PM Ferruh Yigit a écrit : 1, VF Daemon (VFD) VFD i

Re: [dpdk-dev] ConnectX4 100GbE - Compilation problem

2016-12-16 Thread george . dit
Hi all, I am coming back to you regarding the Mellanox Connectx4 100Gbps DPDK driver. We exchanged some e-mails last summer and I managed to compile the DPDK-based Mellanox driver using DPDK 16.07 on top of Ubuntu server 16.04.01. A few days ago, I installed a fresh Ubuntu server 16.04.1 on my ma

[dpdk-dev] [PATCH v4 16/29] net/i40e: set VF VLAN tag from PF

2016-12-16 Thread Ferruh Yigit
From: Bernard Iremonger Add rte_pmd_i40e_set_vf_vlan_tag API. User can call the API on PF to enable/disable a specific VF's VLAN tag. Signed-off-by: Bernard Iremonger --- drivers/net/i40e/i40e_ethdev.c| 59 +++ drivers/net/i40e/rte_pmd_i40e.h |

[dpdk-dev] [RFC] cryptodev: enable BPI+ for Cablelabs DOCSIS security spec

2016-12-16 Thread Trahe, Fiona
Proposal to extend the DPDK cryptodev API to enable processing of packets according to the Baseline Privacy Interface Plus (BPI+) Specification described in the security specification of the Cablelabs Data-over-Cable Service Interface Specification (DOCSIS). Brief summary of BPI+ symmetric cryp

Re: [dpdk-dev] [PATCH v2] crypto/qat: fix to avoid buffer overwrite in OOP case

2016-12-16 Thread De Lara Guarch, Pablo
> -Original Message- > From: Griffin, John > Sent: Friday, December 16, 2016 11:21 AM > To: Trahe, Fiona; dev@dpdk.org > Cc: De Lara Guarch, Pablo; Trahe, Fiona; sta...@dpdk.org > Subject: RE: [dpdk-dev] [PATCH v2] crypto/qat: fix to avoid buffer overwrite > in OOP case > > > > > -

Re: [dpdk-dev] [PATCH] crypto/openssl: fix extra bytes being written at end of data

2016-12-16 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of De Lara Guarch, > Pablo > Sent: Friday, December 16, 2016 10:30 AM > To: Azarewicz, PiotrX T > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] crypto/openssl: fix extra bytes being > written at

[dpdk-dev] [PATCH] performance-thread: add software packet type parsing

2016-12-16 Thread Tomasz Kulasek
Last changes in Niantic and Fortville NIC drivers causes that vector Rx path is chosen by default in l3fwd-thread application. This path doesn't support propagation of hw packet type recognition to the packet_type field in mbuf, and packets cannot be classified properly. The approach to solve this

Re: [dpdk-dev] [PATCH 12/22] app/testpmd: add rte_flow item spec handler

2016-12-16 Thread Adrien Mazarguil
Hi Beilei, On Fri, Dec 16, 2016 at 12:22:52PM +, Xing, Beilei wrote: > Thanks Adrien. > > I have two questions: > 1. when I set " / vlan tci fix 10" with testpmd, I find the mask of tci is > 0x. > Actually tci includes PRI, CFI, and Vlan_id which holds 12 bits, so is > it possible

Re: [dpdk-dev] [PATCH v12 0/6] add Tx preparation

2016-12-16 Thread Ananyev, Konstantin
Hi Jan, ​>Hello, ​ >>Is there any update on that subject? ​>At this point we need to have only pseudo-header checksum for TSO. Maybe there will be new requirements, but that's something I cannot predict at this point. Ok great, then we'll add a patch for ENA for v14, unless you guys would li

Re: [dpdk-dev] [PATCH v12 0/6] add Tx preparation

2016-12-16 Thread Jan Mędala
> > ​>At this point we need to have only pseudo-header checksum for TSO. Maybe > there will be new requirements, but that's something I cannot predict at > this point. > > Ok great, then we'll add a patch for ENA for v14, unless you guys would > like to do it yourself. > ​ ​That'd be great!​ >We

[dpdk-dev] [PATCH v3] vmxnet3: fix Rx deadlock

2016-12-16 Thread Stefan Puiu
Our use case is that we have an app that needs to keep mbufs around for a while. We've seen cases when calling vmxnet3_post_rx_bufs() from vmxet3_recv_pkts(), it might not succeed to add any mbufs to any RX descriptors (where it returns -err). Since there are no mbufs that the virtual hardware can

Re: [dpdk-dev] [PATCH v1] doc: add details of sub-trees and maintainers

2016-12-16 Thread Bruce Richardson
On Tue, Dec 06, 2016 at 06:32:37PM +0100, Thomas Monjalon wrote: > Thanks for documenting the process, John. > > 2016-12-02 16:44, John McNamara: > > +The role of the component maintainers is to: > > + > > I would add: > * Coordinate how improvements and fixes are done. > > > +* Review patches f

Re: [dpdk-dev] [PATCH 3/3] driver: vHost support to free consumed buffers

2016-12-16 Thread Stephen Hemminger
On Fri, 16 Dec 2016 07:48:51 -0500 Billy McFall wrote: > Add support to the vHostdriver for the new API to force free consumed > buffers on TX ring. vHost does not cache the mbufs so there is no work > to do. > > Signed-off-by: Billy McFall > --- > drivers/net/vhost/rte_eth_vhost.c | 11 ++

[dpdk-dev] [PATCH v2 01/25] ethdev: introduce generic flow API

2016-12-16 Thread Adrien Mazarguil
This new API supersedes all the legacy filter types described in rte_eth_ctrl.h. It is slightly higher level and as a result relies more on PMDs to process and validate flow rules. Benefits: - A unified API is easier to program for, applications do not have to be written for a specific filter t

[dpdk-dev] [PATCH v2 00/25] Generic flow API (rte_flow)

2016-12-16 Thread Adrien Mazarguil
As previously discussed in RFC v1 [1], RFC v2 [2], with changes described in [3] (also pasted below), here is the first non-draft series for this new API. Its capabilities are so generic that its name had to be vague, it may be called "Generic flow API", "Generic flow interface" (possibly shortene

[dpdk-dev] [PATCH v2 02/25] doc: add rte_flow prog guide

2016-12-16 Thread Adrien Mazarguil
This documentation is based on the latest RFC submission, subsequently updated according to feedback from the community. Signed-off-by: Adrien Mazarguil --- doc/guides/prog_guide/index.rst|1 + doc/guides/prog_guide/rte_flow.rst | 1853 +++ 2 files changed, 18

[dpdk-dev] [PATCH v2 03/25] doc: announce depreciation of legacy filter types

2016-12-16 Thread Adrien Mazarguil
They are superseded by the generic flow API (rte_flow). Target release is not defined yet. Suggested-by: Kevin Traynor Signed-off-by: Adrien Mazarguil --- doc/guides/rel_notes/deprecation.rst | 7 +++ 1 file changed, 7 insertions(+) diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/

[dpdk-dev] [PATCH v2 04/25] cmdline: add support for dynamic tokens

2016-12-16 Thread Adrien Mazarguil
Considering tokens must be hard-coded in a list part of the instruction structure, context-dependent tokens cannot be expressed. This commit adds support for building dynamic token lists through a user-provided function, which is called when the static token list is empty (a single NULL entry). B

[dpdk-dev] [PATCH v2 05/25] cmdline: add alignment constraint

2016-12-16 Thread Adrien Mazarguil
This prevents sigbus errors on architectures that cannot handle unexpected unaligned accesses to the output buffer. Signed-off-by: Adrien Mazarguil --- lib/librte_cmdline/cmdline_parse.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/lib/librte_cmdline/cmdline_parse

  1   2   >