[dpdk-dev] [PATCH v3 0/5] vhost: optimize enqueue

2016-10-13 Thread Wang, Zhihong
> -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Wednesday, October 12, 2016 11:31 PM > To: Wang, Zhihong > Cc: Yuanhan Liu ; Jianbo Liu > ; Maxime Coquelin ; > dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v3 0/5] vhost: optimize enqueue > >

[dpdk-dev] [PATCH 2/5] i40e: implement vector PMD for ARM architecture

2016-10-13 Thread Jianbo Liu
On 12 October 2016 at 10:46, Zhang, Qi Z wrote: > Hi Jianbo: > >> -Original Message- >> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Jianbo Liu >> Sent: Wednesday, August 24, 2016 5:54 PM >> To: Zhang, Helin ; Wu, Jingjing >> ; jerin.jacob at caviumnetworks.com; dev at >> dpdk.

[dpdk-dev] [Qemu-devel] [PATCH 1/2] vhost: enable any layout feature

2016-10-13 Thread Yang, Zhiyong
Hi, Yuanhan: > -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Yuanhan Liu > Sent: Wednesday, October 12, 2016 11:22 AM > To: Michael S. Tsirkin ; Thomas Monjalon > > Cc: Wang, Zhihong ; Maxime Coquelin > ; Stephen Hemminger > ; dev at dpdk.org; qemu- > devel

[dpdk-dev] [PATCH 1/5] i40e: extract non-x86 specific code from vector driver

2016-10-13 Thread Jianbo Liu
On 12 October 2016 at 10:55, Zhang, Qi Z wrote: > Hi Jianbo > >> -Original Message- >> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Jianbo Liu >> Sent: Wednesday, August 24, 2016 5:54 PM >> To: Zhang, Helin ; Wu, Jingjing >> ; jerin.jacob at caviumnetworks.com; dev at >> dpdk.o

[dpdk-dev] 17.02 Roadmap

2016-10-13 Thread Tan, Jianfeng
Hi Thomas, On 10/11/2016 4:42 AM, Thomas Monjalon wrote: > Thanks Tim for the interesting inputs. > Some of them may require a dedicated thread to continue the discussion > based on some preliminary specifications or drafts. [...] >> Interrupt Mode Support in Virtio PMD: Support for interrupt mod

[dpdk-dev] [PATCH v3 0/5] vhost: optimize enqueue

2016-10-13 Thread Jianbo Liu
Hi Thomas, On 12 October 2016 at 23:31, Thomas Monjalon wrote: > Sorry guys, you lost me in the discussion. > > Is there some regression only on ARM? > Does it need some work specifically on memcpy for ARM, I don't know if there is common way to improve memcpy on different ARM hardware. Even t

[dpdk-dev] [PATCH v3 0/5] vhost: optimize enqueue

2016-10-13 Thread Yuanhan Liu
On Wed, Oct 12, 2016 at 12:22:08PM +, Wang, Zhihong wrote: > > > >> > 3. How many percentage of drop are you seeing? > > > The testing result: > > > size (bytes) improvement (%) > > > 64 3.92 > > > 128 11.51 > > > 256 24.16 > > > 512

[dpdk-dev] [PATCH v3 0/5] vhost: optimize enqueue

2016-10-13 Thread Yuanhan Liu
On Thu, Oct 13, 2016 at 01:33:24PM +0800, Yuanhan Liu wrote: > That would be a clean way to optimize vhost mergeable Rx path: > > - you don't touch non-mrg Rx path (well, you may could apply the > shadow_used_ring trick to it as wel) I meant "to non-mrg Rx as well". --yliu

[dpdk-dev] [PATCH v3 0/5] vhost: optimize enqueue

2016-10-13 Thread Wang, Zhihong
> -Original Message- > From: Yuanhan Liu [mailto:yuanhan.liu at linux.intel.com] > Sent: Thursday, October 13, 2016 1:33 PM > To: Wang, Zhihong > Cc: Jianbo Liu ; Thomas Monjalon > ; Maxime Coquelin > ; dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v3 0/5] vhost: optimize enqueue > >

[dpdk-dev] [dpdk-users] Project Governance and Linux Foundation

2016-10-13 Thread Muhammad Zain-ul-Abideen
I agree with Mr. Thomas Monjalon. Any optimization in DPDK structure should be made open.

[dpdk-dev] [PATCH 1/2] net/i40e: fix link status change interrupt

2016-10-13 Thread Qiming Yang
Previously, link status interrupt in i40e is achieved by checking LINK_STAT_CHANGE_MASK in PFINT_ICR0 register which is provided only for diagnostic use. Instead, drivers need to get the link status change notification by using LSE (Link Status Event). This patch enables LSE and calls LSC callback

[dpdk-dev] [PATCH 2/2] net/i40e: fix VF bonded device link down

2016-10-13 Thread Qiming Yang
Originally, using DPDK as host driver, when VF bonded device uses I40E_VIRTCHNL_OP_GET_LINK_STAT to query PF the link status, VF will wait for the interrupt from PF to get this link status. PF uses interrupt which already exists to communication with VF. These two kinds of interrupt will be confusi

[dpdk-dev] [dpdk-stable] [PATCH v6 1/6] vhost: fix windows vm hang

2016-10-13 Thread Yuanhan Liu
On Mon, Sep 19, 2016 at 10:00:12PM -0400, Zhihong Wang wrote: > This patch fixes a Windows VM compatibility issue in DPDK 16.07 vhost code > which causes the guest to hang once any packets are enqueued when mrg_rxbuf > is turned on by setting the right id and len in the used ring. > > As defined i

[dpdk-dev] [PATCH v1 0/4] Generalize PCI specific EAL function/structures

2016-10-13 Thread Shreyansh Jain
Hi David, On Friday 30 September 2016 09:01 PM, David Marchand wrote: > On Tue, Sep 27, 2016 at 4:12 PM, Shreyansh Jain > wrote: >> (I rebased these over HEAD 7b3c4f3) >> >> These patches were initially part of Jan's original series on SoC >> Framework ([1],[2]). An update to that series, withou

[dpdk-dev] [PATCH v4 1/6] ethdev: add Tx preparation

2016-10-13 Thread Thomas Monjalon
Hi Tomasz, Any news? Sorry to speed up, we are very very late for RC1. 2016-10-10 16:08, Thomas Monjalon: > Hi, > > Now that the feature seems to meet a consensus, I've looked at it more > closely before integrating. Sorry if it appears like a late review. > > 2016-09-30 11:00, Tomasz Kulasek:

[dpdk-dev] [PATCH v2 0/2] examples/l2fwd: Add option to enable/disable MAC addresses updating

2016-10-13 Thread Thomas Monjalon
2016-09-23 15:50, Maxime Coquelin: > This series adds a new option to enable/disable MAC addresses updating in > l2fwd example. > > Doing that, we can enable basic VM 2 VM communication easily, without > external projects dependencies, nor real NIC (as with vhost example). > > Example of cli with

[dpdk-dev] [PATCH v2 03/12] virtio: reinitialize the device in configure callback

2016-10-13 Thread Yuanhan Liu
On Wed, Oct 12, 2016 at 06:01:25PM +0200, Olivier MATZ wrote: > Hello Yuanhan, > > On 10/12/2016 04:41 PM, Yuanhan Liu wrote: > >On Mon, Oct 03, 2016 at 11:00:14AM +0200, Olivier Matz wrote: > >>@@ -1344,6 +1347,7 @@ virtio_dev_configure(struct rte_eth_dev *dev) > >> { > >>const struct rte_et

[dpdk-dev] [PATCH v3 0/5] vhost: optimize enqueue

2016-10-13 Thread Maxime Coquelin
On 10/13/2016 08:02 AM, Wang, Zhihong wrote: >> > Yes, that's great effort! With your hardwork, we know what the bottleneck >> > is and how it could be improved. >> > >> > However, you don't have to do code refactor (merge two code path to one) >> > to apply those improvements. From what I know,

[dpdk-dev] [PATCH v2 12/12] virtio: add Tso support

2016-10-13 Thread Yuanhan Liu
On Mon, Oct 03, 2016 at 11:00:23AM +0200, Olivier Matz wrote: > +/* When doing TSO, the IP length is not included in the pseudo header > + * checksum of the packet given to the PMD, but for virtio it is > + * expected. > + */ > +static void > +virtio_tso_fix_cksum(struct rte_mbuf *m) > +{ > + /

[dpdk-dev] [PATCH] examples/l3fwd: enabling 4m hash for all 64 bit archs

2016-10-13 Thread Thomas Monjalon
2016-08-23 20:24, Hemant Agrawal: > This patch enables the support for 4 million hash entries > for all 64 bit architectures. > > Signed-off-by: Hemant Agrawal Applied, thanks

[dpdk-dev] [PATCH v2 10/12] virtio: add Tx checksum offload support

2016-10-13 Thread Yuanhan Liu
On Mon, Oct 03, 2016 at 11:00:21AM +0200, Olivier Matz wrote: > + /* Checksum Offload */ > + switch (cookie->ol_flags & PKT_TX_L4_MASK) { > + case PKT_TX_UDP_CKSUM: > + hdr->csum_start = cookie->l2_len + cookie->l3_len; > + hdr->csum_offset = 6; > + h

[dpdk-dev] [PATCH v2] app/test: fix crypto mbuf pool size

2016-10-13 Thread Jastrzebski, MichalX K
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Piotr Azarewicz > Sent: Tuesday, October 11, 2016 12:07 PM > To: Trahe, Fiona > Cc: dev at dpdk.org > Subject: [dpdk-dev] [PATCH v2] app/test: fix crypto mbuf pool size > > This patch fix that created pool for

[dpdk-dev] [PATCH] examples/l2fwd-crypto: fix verify with decrypt in chain

2016-10-13 Thread Jastrzebski, MichalX K
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Piotr Azarewicz > Sent: Wednesday, October 12, 2016 10:59 AM > To: De Lara Guarch, Pablo ; Yang, GangX > > Cc: dev at dpdk.org > Subject: [dpdk-dev] [PATCH] examples/l2fwd-crypto: fix verify with decrypt > in ch

[dpdk-dev] [PATCH v3 1/3] lib/librte_port: enable file descriptor port support

2016-10-13 Thread Jasvinder Singh
This patch adds File Descriptor(FD) port type (e.g. TAP port) to the packet framework library that allows interface with the kernel network stack. The FD port APIs are defined that allow port creation, writing and reading packet from the kernel interface. Signed-off-by: Jasvinder Singh Acked-by:

[dpdk-dev] [PATCH v3 2/3] examples/ip_pipeline: integrate TAP port

2016-10-13 Thread Jasvinder Singh
The TAP port support is added to ip_pipeline app. To parse configuration file with TAP port entries, parsing function is implemented. The TAP ports configuration check and initialization routines have been included in application code. Signed-off-by: Jasvinder Singh Acked-by: Cristian Dumitrescu

[dpdk-dev] [PATCH v3 3/3] examples/ip_pipeline: add sample config file with TAP port usage

2016-10-13 Thread Jasvinder Singh
To illustrate the TAP port usage, the sample configuration file with passthrough pipeline connected to TAP interface is added. Signed-off-by: Jasvinder Singh Acked-by: Cristian Dumitrescu --- examples/ip_pipeline/config/tap.cfg | 64 + 1 file changed, 64 inse

[dpdk-dev] [PATCH v3 0/5] vhost: optimize enqueue

2016-10-13 Thread Maxime Coquelin
On 10/13/2016 09:54 AM, Maxime Coquelin wrote: > > > On 10/13/2016 08:02 AM, Wang, Zhihong wrote: >>> > Yes, that's great effort! With your hardwork, we know what the >>> bottleneck >>> > is and how it could be improved. >>> > >>> > However, you don't have to do code refactor (merge two code path

[dpdk-dev] [PATCH v2 0/4] random fixes for bugs identified by Coverity

2016-10-13 Thread Bruce Richardson
On Thu, Sep 29, 2016 at 01:39:32PM -0400, John W. Linville wrote: > Today I attempted to exercise my brain between meetings by handling > a few bugs identified by Coverity. > > All of the fixes are simple and (hopefully) obvious. They are > compile-tested only. > > v2: fix-up changelog entries ba

[dpdk-dev] [PATCH] doc: add ixgbe supported chipsets and NICs

2016-10-13 Thread Bruce Richardson
On Mon, Sep 26, 2016 at 10:11:39AM +, Mcnamara, John wrote: > > -Original Message- > > From: Dai, Wei > > Sent: Monday, September 26, 2016 2:24 AM > > To: dev at dpdk.org; thomas.monjalon at 6wind.com; Butler, Siobhan A > > ; Mcnamara, John > intel.com>; > > Zhang, Helin ; Ananyev, Kon

[dpdk-dev] [PATCH] net/enic: add Ethernet VLAN ptype

2016-10-13 Thread Bruce Richardson
On Wed, Aug 24, 2016 at 12:07:02PM -0700, John Daley wrote: > Enic is capable of recognizing packets to be delivered to the > app with single VLAN tags. Advertise this with the ptype > RTE_PTYPE_L2_ETHER_VLAN and set the ptype for VLAN packets. > > Signed-off-by: John Daley > --- Applied to dpdk-

[dpdk-dev] [PATCH] mempool: fix search of maximum contiguous pages

2016-10-13 Thread Wei Dai
paddr[i] + pg_sz always points to the start physical address of the 2nd page after pddr[i], so only up to 2 pages can be combinded to be used. With this revision, more than 2 pages can be used. Fixes: 84121f197187 ("mempool: store memory chunks in a list") Signed-off-by: Wei Dai --- lib/librte_

[dpdk-dev] [PATCH] net/mlx5: fix Rx function selection

2016-10-13 Thread Bruce Richardson
On Tue, Oct 11, 2016 at 05:01:36PM +0200, Adrien Mazarguil wrote: > On Tue, Oct 11, 2016 at 04:44:50PM +0200, Nelio Laranjeiro wrote: > > mlx5_rx_queue_setup() was setting the Rx function by itself instead of > > using priv_select_rx_function() written for that purpose. > > > > Fixes: cdab90cb5c8d

[dpdk-dev] [PATCH 0/2] Two offloading issues of tep_term

2016-10-13 Thread Thomas Monjalon
2016-08-04 07:58, Jianfeng Tan: > This patch set depends on: > - http://dpdk.org/ml/archives/dev/2016-August/044924.html > > Patch 1: fill tunneling type. > Patch 2: inner L4 checksum error. > > Signed-off-by: Jianfeng Tan Applied, thanks

[dpdk-dev] [PATCH v3 01/10] net/bnx2x: set cache line based on build configuration

2016-10-13 Thread Bruce Richardson
On Tue, Oct 11, 2016 at 07:04:52PM -0400, Chas Williams wrote: > Correctly hint the cache line size. Remove unused macros associated > with the cache line size. > > Fixes: 540a211084a7 ("bnx2x: driver core") > > Signed-off-by: Chas Williams <3chas3 at gmail.com> > Acked-by: Harish Patil Series

[dpdk-dev] [PATCH] mempool: fix search of maximum contiguous pages

2016-10-13 Thread Sergio Gonzalez Monroy
+Olivier On 13/10/2016 10:37, Wei Dai wrote: > paddr[i] + pg_sz always points to the start physical address of the > 2nd page after pddr[i], so only up to 2 pages can be combinded to > be used. With this revision, more than 2 pages can be used. > > Fixes: 84121f197187 ("mempool: store memory chunk

[dpdk-dev] [PATCH] mempool: fix search of maximum contiguous pages

2016-10-13 Thread Ananyev, Konstantin
Hi > > Signed-off-by: Wei Dai > --- > lib/librte_mempool/rte_mempool.c | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/lib/librte_mempool/rte_mempool.c > b/lib/librte_mempool/rte_mempool.c > index 71017e1..e3e254a 100644 > --- a/lib/librte_mempool/rte_mempool.c >

[dpdk-dev] [PATCH 0/4] bnxt patch series

2016-10-13 Thread Bruce Richardson
On Thu, Sep 29, 2016 at 06:32:59PM +0100, Ferruh Yigit wrote: > On 9/29/2016 6:03 PM, Ajit Khaparde wrote: > > Please consider applying this patch series. > > This series is expected to be applied over the previous patchset > > once it is accepted. > > Depends on: [v2,15/15] bnxt: Update struct def

[dpdk-dev] [PATCH] mempool: fix search of maximum contiguous pages

2016-10-13 Thread Ananyev, Konstantin
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Ananyev, Konstantin > Sent: Thursday, October 13, 2016 10:54 AM > To: Dai, Wei ; dev at dpdk.org; Gonzalez Monroy, Sergio > ; Tan, Jianfeng > ; Dai, Wei > Subject: Re: [dpdk-dev] [PATCH] mempool: fix search o

[dpdk-dev] [PATCH] app/test: add tests with corrupted data for QAT test suite

2016-10-13 Thread Arek Kusztal
This commit adds tests with corrupted data to the Intel QuickAssist Technology tests suite in test_cryptodev.c Signed-off-by: Arek Kusztal --- app/test/test_cryptodev.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c index

[dpdk-dev] [PATCH] net/i40e: add additional prefetch instructions for bulk rx

2016-10-13 Thread Bruce Richardson
On Wed, Oct 12, 2016 at 12:04:39AM +, Ananyev, Konstantin wrote: > Hi Vladislav, > > > > > > > > > > > > > On 7/14/2016 6:27 PM, Vladyslav Buslov wrote: > > > > > > > Added prefetch of first packet payload cacheline in > > > > > > > i40e_rx_scan_hw_ring Added prefetch of second mbuf cacheline

[dpdk-dev] [PATCH] net/ring: fix ring eth dev creation via devargs

2016-10-13 Thread Bruce Richardson
On Wed, Aug 31, 2016 at 05:51:11PM +0100, Ferruh Yigit wrote: > Using nodeaction devarg lets creating multiple ring eth devices: > "eth_ring0,nodeaction=R0:0:CREATE,nodeaction=R1:0:CREATE" > > Trying to create all devices with same name fails. Since first part of > the nodeaction devarg is name (i

[dpdk-dev] [PATCH] net/ring: fix param string info

2016-10-13 Thread Bruce Richardson
On Wed, Aug 31, 2016 at 05:53:51PM +0100, Ferruh Yigit wrote: > Fixes: 65eca099f405 ("drivers: split parameters infos in multiple lines") > > Signed-off-by: Ferruh Yigit > --- Acked-by: Bruce Richardson

[dpdk-dev] [PATCH] net/i40e: add additional prefetch instructions for bulk rx

2016-10-13 Thread Ananyev, Konstantin
> -Original Message- > From: Richardson, Bruce > Sent: Thursday, October 13, 2016 11:19 AM > To: Ananyev, Konstantin > Cc: Vladyslav Buslov ; Wu, Jingjing > ; Yigit, Ferruh ; > Zhang, Helin ; dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH] net/i40e: add additional prefetch > instruct

[dpdk-dev] [PATCH v4 1/6] ethdev: add Tx preparation

2016-10-13 Thread Kulasek, TomaszX
Hi Thomas, > -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Thursday, October 13, 2016 09:09 > To: Kulasek, TomaszX > Cc: dev at dpdk.org; Ananyev, Konstantin > Subject: Re: [dpdk-dev] [PATCH v4 1/6] ethdev: add Tx preparation > > Hi Tomasz, >

[dpdk-dev] [PATCH] eal: avoid unnecessary conflicts over rte_config file

2016-10-13 Thread Ananyev, Konstantin
Hi John, > Before this patch, DPDK used the file ~/.rte_config as a lock to detect > potential interference between multiple DPDK applications running on the > same machine. However, if a single user ran DPDK applications concurrently > on several different machines, and if the user's home direct

[dpdk-dev] [PATCH v2 2/3] app/testpmd: fix wrong flow director mask

2016-10-13 Thread Ferruh Yigit
Hi Wenzhuo, On 10/12/2016 7:24 AM, Wenzhuo Lu wrote: > In mac-vlan mode, MAC address mask is not supported by HW. > The MAC address mask should not be set in mac-vlan mode. > Remove this parameter from the CLI. Remove MAC address > from mask print too. > > Fixes: 53b2bb9b7ea7 ("app/testpmd: new f

[dpdk-dev] [PATCH] net/i40e: Fix a typo in a comment (Fortville instead of IXGBE).

2016-10-13 Thread Ferruh Yigit
On 9/25/2016 11:03 AM, Wu, Jingjing wrote: > > >> -Original Message- >> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Rami Rosen >> Sent: Monday, August 1, 2016 12:52 PM >> To: dev at dpdk.org >> Cc: Rosen, Rami >> Subject: [dpdk-dev] [PATCH] net/i40e: Fix a typo in a comment (

[dpdk-dev] [PATCH] pdump: fix dir permissions value in mkdir call

2016-10-13 Thread Tan, Jianfeng
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Reshma Pattan > Sent: Monday, October 10, 2016 10:36 PM > To: dev at dpdk.org > Cc: Pattan, Reshma > Subject: [dpdk-dev] [PATCH] pdump: fix dir permissions value in mkdir call > > From: Reshma Pattan > > Ins

[dpdk-dev] [PATCH] mempool: fix search of maximum contiguous pages

2016-10-13 Thread Dai, Wei
> > > diff --git a/lib/librte_mempool/rte_mempool.c > > > b/lib/librte_mempool/rte_mempool.c > > > index 71017e1..e3e254a 100644 > > > --- a/lib/librte_mempool/rte_mempool.c > > > +++ b/lib/librte_mempool/rte_mempool.c > > > @@ -426,9 +426,12 @@ rte_mempool_populate_phys_tab(struct > > > rte_mempoo

[dpdk-dev] [PATCH 1/5] i40e: extract non-x86 specific code from vector driver

2016-10-13 Thread Zhang, Qi Z
Hi Jianbo > -Original Message- > From: Jianbo Liu [mailto:jianbo.liu at linaro.org] > Sent: Thursday, October 13, 2016 11:00 AM > To: Zhang, Qi Z > Cc: Zhang, Helin ; Wu, Jingjing > ; jerin.jacob at caviumnetworks.com; dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH 1/5] i40e: extract no

[dpdk-dev] [PATCH] app/test: add crypto continual tests

2016-10-13 Thread Arek Kusztal
This commit adds continual performace tests to Intel(R) QuickAssist Technology tests suite. Performance tests are run continually with some number of repeating loops. Signed-off-by: Arek Kusztal --- app/test/test_cryptodev_perf.c | 133 - 1 file changed, 1

[dpdk-dev] [PATCH] mempool: fix search of maximum contiguous pages

2016-10-13 Thread Ananyev, Konstantin
> > > > > diff --git a/lib/librte_mempool/rte_mempool.c > > > > b/lib/librte_mempool/rte_mempool.c > > > > index 71017e1..e3e254a 100644 > > > > --- a/lib/librte_mempool/rte_mempool.c > > > > +++ b/lib/librte_mempool/rte_mempool.c > > > > @@ -426,9 +426,12 @@ rte_mempool_populate_phys_tab(struct

[dpdk-dev] [PATCH v3 1/3] lib/librte_port: enable file descriptor port support

2016-10-13 Thread Thomas Monjalon
2016-10-13 10:17, Jasvinder Singh: > This patch adds File Descriptor(FD) port type (e.g. TAP port) to the > packet framework library that allows interface with the kernel network > stack. The FD port APIs are defined that allow port creation, writing > and reading packet from the kernel interface.

[dpdk-dev] [PATCH] test: fix hash multiwriter test

2016-10-13 Thread Thomas Monjalon
2016-10-06 23:34, Pablo de Lara: > Hash multiwriter test consists of two subtests. > If the any of the subtests fails, the overall test should fail, > but the overall test only passed if the second subtest passed, > because the return of the first subtest was being overwritten. > > Fixes: be856325

[dpdk-dev] [PATCH v3 2/2] mempool: pktmbuf pool default fallback for mempool ops error

2016-10-13 Thread Hemant Agrawal
Hi Olivier, Any updates w.r.t this patch set? Regards Hemant On 9/22/2016 6:42 PM, Hemant Agrawal wrote: > Hi Olivier > > On 9/19/2016 7:27 PM, Olivier Matz wrote: >> Hi Hemant, >> >> On 09/16/2016 06:46 PM, Hemant Agrawal wrote: >>> In the rte_pktmbuf_pool_create, if the default external

[dpdk-dev] [PATCH] net/enic: remove assert which causes compile error

2016-10-13 Thread Bruce Richardson
On Wed, Oct 12, 2016 at 11:09:35AM -0700, John Daley wrote: > Remove an RTE_ASSERT which will not compile if enabled and is not needed. > > Fixes: a1f7c7b3b5b2 ("net/enic: extend fdir support for 1300 series adapters") > > Signed-off-by: John Daley > --- > Would have been nice if I caught this y

[dpdk-dev] [PATCH v2] app/test: remove large lpm test head file

2016-10-13 Thread Thomas Monjalon
2016-09-28 01:38, Wei Dai: > remove the large file app/test/test_lpm_routes.h and add codes to > auto-generate similar large route rule talbe which keeps same depth > and IP class distribution as previous one in test_lpm_routes.h . > With the rule table auto-generated at run time, the performance >

[dpdk-dev] [PATCH v2] examples/l3fwd: em: use hw accelerated crc hash function for arm64

2016-10-13 Thread Jerin Jacob
On Fri, Oct 14, 2016 at 12:17:05AM +0530, Hemant Agrawal wrote: > if machine level CRC extension are available, offload the > hash to machine provide functions e.g. armv8-a CRC extensions > support it > > Signed-off-by: Hemant Agrawal > Reviewed-by: Jerin Jacob > --- > examples/l3fwd/l3fwd_em.c

[dpdk-dev] [PATCH] net/enic: remove assert which causes compile error

2016-10-13 Thread Bruce Richardson
On Thu, Oct 13, 2016 at 02:22:16PM +0100, Bruce Richardson wrote: > On Wed, Oct 12, 2016 at 11:09:35AM -0700, John Daley wrote: > > Remove an RTE_ASSERT which will not compile if enabled and is not needed. > > > > Fixes: a1f7c7b3b5b2 ("net/enic: extend fdir support for 1300 series > > adapters")

[dpdk-dev] [PATCH] testpmd: fix tso with csum engine

2016-10-13 Thread Olivier Matz
The commit that disabled tso for small packets was broken during the rebase. The problem is the IP checksum is not calculated in software if: - TX IP checksum is disabled - TSO is enabled - the current packet is smaller than tso segment size When checking if the PKT_TX_IP_CKSUM flag should be set

[dpdk-dev] [PATCH] app/test: reduce lpm6 test case size

2016-10-13 Thread Thomas Monjalon
2016-09-30 02:11, Wei Dai: > copy app/test/test_lpm6_routes.h to app/test/test_lpm6_data.h . > and then delete app/test/test_lpm6_routes.h and clear the > large_ips_table[ ] to make LPM6 test case size much smaller than > before. Also add codes in app/test/test_lpm6_data.h to generate test > data i

[dpdk-dev] [PATCH] net/ring: fix ring eth dev creation via devargs

2016-10-13 Thread Bruce Richardson
On Thu, Oct 13, 2016 at 11:21:57AM +0100, Bruce Richardson wrote: > On Wed, Aug 31, 2016 at 05:51:11PM +0100, Ferruh Yigit wrote: > > Using nodeaction devarg lets creating multiple ring eth devices: > > "eth_ring0,nodeaction=R0:0:CREATE,nodeaction=R1:0:CREATE" > > > > Trying to create all devices

[dpdk-dev] [PATCH] net/ring: fix param string info

2016-10-13 Thread Bruce Richardson
On Thu, Oct 13, 2016 at 11:22:25AM +0100, Bruce Richardson wrote: > On Wed, Aug 31, 2016 at 05:53:51PM +0100, Ferruh Yigit wrote: > > Fixes: 65eca099f405 ("drivers: split parameters infos in multiple lines") > > > > Signed-off-by: Ferruh Yigit > > --- > Acked-by: Bruce Richardson Applied to dpdk

[dpdk-dev] [PATCH v9 0/2] add API's for VF management

2016-10-13 Thread Bruce Richardson
On Wed, Oct 12, 2016 at 06:54:10PM +0100, Bernard Iremonger wrote: > This patchset contains new DPDK API's for use > with the Virtual Function Daemon (VFD). > > The need to configure and manage VF's on a NIC has grown to the > point where a DPDK based tool, VFD, has been developed to do this. > >

[dpdk-dev] [PATCH] app/test: add mempool walk

2016-10-13 Thread Thomas Monjalon
2016-10-05 14:22, Olivier Matz: > Hi Thomas, > > On 10/03/2016 10:58 PM, Thomas Monjalon wrote: > > The mempool function rte_mempool_walk was not tested. > > It will print the name of all mempools. > > > > Signed-off-by: Thomas Monjalon > > Acked-by: Olivier Matz Applied

[dpdk-dev] [PATCH 2/2] app/testpmd: use consistent vdev names

2016-10-13 Thread Thomas Monjalon
2016-10-07 02:27, De Lara Guarch, Pablo: > > > -Original Message- > > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > > Sent: Thursday, October 06, 2016 3:34 AM > > To: De Lara Guarch, Pablo > > Cc: dev at dpdk.org > > Subject: [PATCH 2/2] app/testpmd: use consistent vdev nam

[dpdk-dev] [PATCH v2 03/12] virtio: reinitialize the device in configure callback

2016-10-13 Thread Olivier MATZ
On 10/13/2016 09:54 AM, Yuanhan Liu wrote: > On Wed, Oct 12, 2016 at 06:01:25PM +0200, Olivier MATZ wrote: >> Hello Yuanhan, >> >> On 10/12/2016 04:41 PM, Yuanhan Liu wrote: >>> On Mon, Oct 03, 2016 at 11:00:14AM +0200, Olivier Matz wrote: @@ -1344,6 +1347,7 @@ virtio_dev_configure(struct rt

[dpdk-dev] [PATCH v2 10/12] virtio: add Tx checksum offload support

2016-10-13 Thread Olivier MATZ
On 10/13/2016 10:38 AM, Yuanhan Liu wrote: > On Mon, Oct 03, 2016 at 11:00:21AM +0200, Olivier Matz wrote: >> +/* Checksum Offload */ >> +switch (cookie->ol_flags & PKT_TX_L4_MASK) { >> +case PKT_TX_UDP_CKSUM: >> +hdr->csum_start = cookie->l2_len + cookie->l3_len; >> +

[dpdk-dev] [PATCH] testpmd: fix tso with csum engine

2016-10-13 Thread Thomas Monjalon
2016-10-13 15:40, Olivier Matz: > The commit that disabled tso for small packets was broken during the > rebase. The problem is the IP checksum is not calculated in software if: > - TX IP checksum is disabled > - TSO is enabled > - the current packet is smaller than tso segment size > > When check

[dpdk-dev] [PATCH v2 12/12] virtio: add Tso support

2016-10-13 Thread Olivier MATZ
On 10/13/2016 10:18 AM, Yuanhan Liu wrote: > On Mon, Oct 03, 2016 at 11:00:23AM +0200, Olivier Matz wrote: >> +/* When doing TSO, the IP length is not included in the pseudo header >> + * checksum of the packet given to the PMD, but for virtio it is >> + * expected. >> + */ >> +static void >> +vi

[dpdk-dev] [PATCH v2] app/testpmd: fix RSS-hash-key size

2016-10-13 Thread Thomas Monjalon
> > RSS hash-key-size is retrieved from device configuration instead of > > using a fixed size of 40 bytes. > > > > Fixes: f79959ea1504 ("app/testpmd: allow to configure RSS hash key") > > > > Signed-off-by: Mohammad Abdul Awal > > Acked-by: Konstantin Ananyev Applied, thanks

[dpdk-dev] [PATCH v3 00/12] net/virtio: add offload support

2016-10-13 Thread Olivier Matz
This patchset, targetted for 16.11, introduces the support of rx and tx offload in virtio pmd. To achieve this, some new mbuf flags must be introduced, as discussed in [1]. It applies on master + a patch fixing the testpmd csum engine: http://dpdk.org/dev/patchwork/patch/16538/ The new mbuf chec

[dpdk-dev] [PATCH v3 01/12] net/virtio: move device initialization in a function

2016-10-13 Thread Olivier Matz
Move all code related to device initialization in a new function virtio_init_device(). This commit brings no functional change, it prepares the next commits that will add the offload support. For that, it will be needed to reinitialize the device from ethdev->configure(), using this new function.

[dpdk-dev] [PATCH v3 02/12] net/virtio: setup and start cq in configure callback

2016-10-13 Thread Olivier Matz
Move the configuration of control queue in the configure callback. This is needed by next commit, which introduces the reinitialization of the device in the configure callback to change the feature flags. Therefore, the control queue will have to be restarted at the same place. As virtio_dev_cq_qu

[dpdk-dev] [PATCH v3 03/12] net/virtio: reinitialize the device in configure callback

2016-10-13 Thread Olivier Matz
Add the ability to reset the virtio device in the configure callback if the features flag changed since previous reset. This will be possible with the introduction of offload support in next commits. Signed-off-by: Olivier Matz Reviewed-by: Maxime Coquelin --- drivers/net/virtio/virtio_ethdev.c

[dpdk-dev] [PATCH v3 04/12] net: add function to calculate a checksum in a mbuf

2016-10-13 Thread Olivier Matz
This function can be used to calculate the checksum of data embedded in mbuf, that can be composed of several segments. This function will be used by the virtio pmd in next commits to calculate the checksum in software in case the protocol is not recognized. Signed-off-by: Olivier Matz --- doc/

[dpdk-dev] [PATCH v3 05/12] mbuf: add new Rx checksum mbuf flags

2016-10-13 Thread Olivier Matz
Following discussions in [1] and [2], introduce a new bit to describe the Rx checksum status in mbuf. Before this patch, only one flag was available: PKT_RX_L4_CKSUM_BAD: L4 cksum of RX pkt. is not OK. And same for L3: PKT_RX_IP_CKSUM_BAD: IP cksum of RX pkt. is not OK. This had 2 issues: -

[dpdk-dev] [PATCH v3 07/12] mbuf: new flag for LRO

2016-10-13 Thread Olivier Matz
When receiving coalesced packets in virtio, the original size of the segments is provided. This is a useful information because it allows to resegment with the same size. Add a RX new flag in mbuf, that can be set when packets are coalesced by a hardware or virtual driver when the m->tso_segsz fie

[dpdk-dev] [PATCH v3 08/12] app/testpmd: display lro segment size

2016-10-13 Thread Olivier Matz
In csumonly engine, display the value of LRO segment if the LRO flag is set. Signed-off-by: Olivier Matz Reviewed-by: Maxime Coquelin --- app/test-pmd/csumonly.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/app/test-pmd/csumonly.c b/app/test-pmd/csumonly.c index da15185..57e6ae2 100644

[dpdk-dev] [PATCH v3 09/12] net/virtio: add Rx checksum offload support

2016-10-13 Thread Olivier Matz
Signed-off-by: Olivier Matz --- drivers/net/virtio/virtio_ethdev.c | 21 ++ drivers/net/virtio/virtio_ethdev.h | 2 +- drivers/net/virtio/virtio_rxtx.c | 79 ++ drivers/net/virtio/virtqueue.h | 1 + 4 files changed, 95 insertions(+), 8 deletions

[dpdk-dev] [PATCH v3 06/12] app/testpmd: adapt checksum stats in csum engine

2016-10-13 Thread Olivier Matz
Reviewed-by: Maxime Coquelin --- app/test-pmd/csumonly.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/app/test-pmd/csumonly.c b/app/test-pmd/csumonly.c index 27d0f08..da15185 100644 --- a/app/test-pmd/csumonly.c +++ b/app/test-pmd/csumonly.c @@ -697,8 +697,10 @@ pkt_b

[dpdk-dev] [PATCH v3 11/12] net/virtio: add Lro support

2016-10-13 Thread Olivier Matz
Signed-off-by: Olivier Matz Reviewed-by: Maxime Coquelin --- drivers/net/virtio/virtio_ethdev.c | 15 ++- drivers/net/virtio/virtio_ethdev.h | 9 - drivers/net/virtio/virtio_rxtx.c | 25 - 3 files changed, 38 insertions(+), 11 deletions(-) diff --g

[dpdk-dev] [PATCH v3 12/12] net/virtio: add Tso support

2016-10-13 Thread Olivier Matz
Signed-off-by: Olivier Matz --- drivers/net/virtio/virtio_ethdev.c | 6 ++ drivers/net/virtio/virtio_ethdev.h | 2 + drivers/net/virtio/virtio_rxtx.c | 133 +++-- 3 files changed, 136 insertions(+), 5 deletions(-) diff --git a/drivers/net/virtio/virtio_ethde

[dpdk-dev] [PATCH v2 12/12] virtio: add Tso support

2016-10-13 Thread Yuanhan Liu
On Thu, Oct 13, 2016 at 04:02:49PM +0200, Olivier MATZ wrote: > > > On 10/13/2016 10:18 AM, Yuanhan Liu wrote: > >On Mon, Oct 03, 2016 at 11:00:23AM +0200, Olivier Matz wrote: > >>+/* When doing TSO, the IP length is not included in the pseudo header > >>+ * checksum of the packet given to the PM

[dpdk-dev] [PATCH v3 10/12] net/virtio: add Tx checksum offload support

2016-10-13 Thread Olivier Matz
Signed-off-by: Olivier Matz --- drivers/net/virtio/virtio_ethdev.c | 7 drivers/net/virtio/virtio_ethdev.h | 1 + drivers/net/virtio/virtio_rxtx.c | 73 +++--- 3 files changed, 61 insertions(+), 20 deletions(-) diff --git a/drivers/net/virtio/virtio_ethde

[dpdk-dev] 17.02 Roadmap

2016-10-13 Thread Hunt, David
Hi Thomas, On 10/10/2016 9:42 PM, Thomas Monjalon wrote: > Thanks Tim for the interesting inputs. > Some of them may require a dedicated thread to continue the discussion > based on some preliminary specifications or drafts. > > 2016-10-10 16:13, O'Driscoll, Tim: >> Packet Distributor Enhancement

[dpdk-dev] [PATCH 0/3] Improvements in packet timestamps support

2016-10-13 Thread Oleg Kuporosov
Hello DPDK Developers, Financial Services Industry which is pretty eager for several DPDK features especially low latency while high throughput. The major issue so far for increasing DPDK adoption there is requirement for several applications (capturers, some trading algorithms) to support of acc

[dpdk-dev] [PATCH 1/3] mbuf: embedding timestamp into the packet

2016-10-13 Thread Oleg Kuporosov
The hard requirement of financial services industry is accurate timestamping aligned with the packet itself. This patch is to satisfy this requirement: - include uint64_t timestamp field into rte_mbuf with minimal impact to throughput/latency. Keep it just simple uint64_t in ns (more than 580

[dpdk-dev] [PATCH 3/3] net/mlx5: implementation of Rx packet timestamping support

2016-10-13 Thread Oleg Kuporosov
Accurate RX timestaping is minimal requirement for several important financial services industry requirement for several applications like packet capture. Support of periodic time synchronization with system time and adjusting clock deviation was also added. We assume the system is synchronized by

[dpdk-dev] [PATCH 2/3] app/testpmd: enabled control for packet timestamps

2016-10-13 Thread Oleg Kuporosov
Implemented two methods of control - by --enable-timestamps CL testpmd application we can enable timestamping for all ports; - in interactive mode port config timestamps on|off is able to configure timestamping per specific port. The control doesn't interact with IEEE1588 PTP implementation

[dpdk-dev] 17.02 Roadmap

2016-10-13 Thread Thomas Monjalon
2016-10-13 15:18, Hunt, David: > Hi Thomas, > > On 10/10/2016 9:42 PM, Thomas Monjalon wrote: > > 2016-10-10 16:13, O'Driscoll, Tim: > >> Packet Distributor Enhancements: Enhancements will be made to the Packet > >> Distributor library to improve performance: > >> 1. Introduce burst functionality

[dpdk-dev] [PATCH v6] drivers/net:new PMD using tun/tap host interface

2016-10-13 Thread Ferruh Yigit
On 10/12/2016 9:54 PM, Keith Wiles wrote: > The rte_eth_tap.c PMD creates a device using TUN/TAP interfaces > on the local host. The PMD allows for DPDK and the host to > communicate using a raw device interface on the host and in > the DPDK application. The device created is a Tap device with > a

[dpdk-dev] [PATCH v2 12/12] virtio: add Tso support

2016-10-13 Thread Olivier MATZ
On 10/13/2016 04:16 PM, Yuanhan Liu wrote: > On Thu, Oct 13, 2016 at 04:02:49PM +0200, Olivier MATZ wrote: >> >> >> On 10/13/2016 10:18 AM, Yuanhan Liu wrote: >>> On Mon, Oct 03, 2016 at 11:00:23AM +0200, Olivier Matz wrote: +/* When doing TSO, the IP length is not included in the pseudo hea

[dpdk-dev] [PATCH v2 12/12] virtio: add Tso support

2016-10-13 Thread Yuanhan Liu
On Thu, Oct 13, 2016 at 04:52:25PM +0200, Olivier MATZ wrote: > > > On 10/13/2016 04:16 PM, Yuanhan Liu wrote: > >On Thu, Oct 13, 2016 at 04:02:49PM +0200, Olivier MATZ wrote: > >> > >> > >>On 10/13/2016 10:18 AM, Yuanhan Liu wrote: > >>>On Mon, Oct 03, 2016 at 11:00:23AM +0200, Olivier Matz wrot

[dpdk-dev] [PATCH v2 12/12] virtio: add Tso support

2016-10-13 Thread Yuanhan Liu
On Thu, Oct 13, 2016 at 04:52:25PM +0200, Olivier MATZ wrote: > >In the "else" clause, the ip header is still in the mbuf, right? > >Why do you have to access it the way like: > > > > ip_version = *rte_pktmbuf_mtod_offset(m, uint8_t *, > > m->l2_len) >> 4; > > > >Why can't you just

[dpdk-dev] [PATCH] mempool: fix search of maximum contiguous pages

2016-10-13 Thread Olivier MATZ
Hi Wei, On 10/13/2016 02:31 PM, Ananyev, Konstantin wrote: > >> > diff --git a/lib/librte_mempool/rte_mempool.c > b/lib/librte_mempool/rte_mempool.c > index 71017e1..e3e254a 100644 > --- a/lib/librte_mempool/rte_mempool.c > +++ b/lib/librte_mempool/rte_mempool.c > @@ -426,9

[dpdk-dev] [PATCH] doc: add note on primary process dependency

2016-10-13 Thread Reshma Pattan
The note i.e. "The dpdk-pdump tool can only be used in conjunction with a primary process which has the packet capture framework initialized already" is added to doc/guides/sample_app_ug/pdump.rst to facilitate easy understanding on the usage of the tool. Suggested-by: Jianfeng Tan Signed-off-by:

[dpdk-dev] [PATCH v2] app/testpmd: fix DCB config issue

2016-10-13 Thread Thomas Monjalon
> > An issue is found that DCB cannot be configured on ixgbe NICs. It's said the > > TX queue number is not right. > > On ixgbe the max TX queue number is not fixed, it depends on the multi- > > queue mode. > > > > This patch adds the device configuration before getting info in the DCB > > configu

[dpdk-dev] [PATCH v2 12/12] virtio: add Tso support

2016-10-13 Thread Olivier MATZ
On 10/13/2016 05:01 PM, Yuanhan Liu wrote: > On Thu, Oct 13, 2016 at 04:52:25PM +0200, Olivier MATZ wrote: >> >> >> On 10/13/2016 04:16 PM, Yuanhan Liu wrote: >>> On Thu, Oct 13, 2016 at 04:02:49PM +0200, Olivier MATZ wrote: On 10/13/2016 10:18 AM, Yuanhan Liu wrote: > On Mon,

[dpdk-dev] [PATCH] app/testpmd: configure flowgen packet size though --txpkts

2016-10-13 Thread Thomas Monjalon
> > "flowgen" forwarding mode has fixed packet size (300). > > Let it re-use --txpkts option for specifying generated packet size. > > > > Signed-off-by: Maciej Czekaj > > Acked-by: Pablo de Lara Applied, thanks

  1   2   >