[dpdk-dev] [DPDK16.04: Error While compiling]

2016-06-26 Thread amartya....@wipro.com
Thanks. It has supports sse3. I was not able to nail the problem. But replaced the vm with other working VM for now which is working fine. -Original Message- From: Anupam Kapoor [mailto:anupam.kap...@gmail.com] Sent: Tuesday, June 21, 2016 3:34 PM To: Amartya Kumar Das (MFG & Tech) Cc:

[dpdk-dev] [Crypto API use error]

2016-06-26 Thread amartya....@wipro.com
Hi, I am trying to run one sample application with crypto library with DPDK 16.04 from below path in VM: dpdk-16.04/examples/l2fwd-crypto Command use: ./build/l2fwd-crypto -c 0x1 -n 4 --vdev "cryptodev_aesni_mb_pmd" --vdev "cryptodev_aesni_mb_pmd" -- -p 0x1 --chain CIPHER_HASH --cipher_op ENCRY

[dpdk-dev] [PATCH v2] net/virtio-user: fix implicit int to enum conversion

2016-06-26 Thread Jianfeng Tan
Implicit int to enum conversion is not allowed when icc is used as the compiler. It raises the compiling error like, /.../dpdk/drivers/net/virtio/virtio_user/vhost_user.c(257): error #188: enumerated type mixed with another type msg.request = req; ^ The fix

[dpdk-dev] [PATCH] net/virtio-user: fix O_CLOEXEC undeclared error

2016-06-26 Thread Jianfeng Tan
On some older systems, such as SUSE 11, the compiling error shows as: .../dpdk/drivers/net/virtio/virtio_user/virtio_user_dev.c:67:22: error: ?O_CLOEXEC? undeclared (first use in this function) The fix is to declare _GNU_SOURCE macro before include fcntl.h. Fixes: 37a7eb2ae816 ("net/v

[dpdk-dev] [PATCH 1/2] e1000:fix gcc test for clang builds

2016-06-26 Thread Keith Wiles
Signed-off-by: Keith Wiles --- drivers/net/e1000/Makefile | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/net/e1000/Makefile b/drivers/net/e1000/Makefile index 5b801f5..1305163 100644 --- a/drivers/net/e1000/Makefile +++ b/drivers/net/e1000/Makefile @@ -48,7 +48,7

[dpdk-dev] [PATCH 2/2] fix building with clang-3.8.0 compiler

2016-06-26 Thread Keith Wiles
Latest clang compiler 3.8.0 on latest update of Ubuntu creates a few more warnings on -Warray-bounds and extra () around 'if' expressions. Signed-off-by: Keith Wiles --- app/test-pmd/Makefile| 3 +++ app/test/Makefile| 3 +++ drivers/net/bonding/Makefile

[dpdk-dev] [PATCH v2 0/2] fix coverity issues

2016-06-26 Thread Helin Zhang
It fixes several problematic dereference issues and missing break issue reported by Coverity. Helin Zhang (2): i40e: fix problematic dereference i40e: fix missing break in switch drivers/net/i40e/i40e_pf.c | 11 +-- drivers/net/i40e/i40e_rxtx.c | 12 2 files changed, 1

[dpdk-dev] [PATCH v2 1/2] i40e: fix problematic dereference

2016-06-26 Thread Helin Zhang
It fixes the issue reported by Coverity of 'Dereference before null check', by deleting null checks as they are not necessary at all, or move null checks before where uses it. Coverity ID 119267: Dereference before null check. Coverity ID 13301: Dereference before null check. Coverity ID 13294: De

[dpdk-dev] [PATCH v2 2/2] i40e: fix missing break in switch

2016-06-26 Thread Helin Zhang
It fixes the issue reported by Coverity of 'Missing break in switch', by deleting 'case I40E_VIRTCHNL_OP_FCOE', as it is not necessary at all. Coverity ID 13265: Missing break in switch. Fixes: 4861cde46116 ("i40e: new poll mode driver") Signed-off-by: Helin Zhang --- drivers/net/i40e/i40e_pf.

[dpdk-dev] [PATCH 1/2] e1000:fix gcc test for clang builds

2016-06-26 Thread Wiles, Keith
On 6/26/16, 10:32 AM, "dev on behalf of Keith Wiles" wrote: >Signed-off-by: Keith Wiles >--- > drivers/net/e1000/Makefile | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > >diff --git a/drivers/net/e1000/Makefile b/drivers/net/e1000/Makefile >index 5b801f5..1305163 100644 >--- a/driv

[dpdk-dev] [PATCH 2/2] fix building with clang-3.8.0 compiler

2016-06-26 Thread Wiles, Keith
On 6/26/16, 10:32 AM, "dev on behalf of Keith Wiles" wrote: >Latest clang compiler 3.8.0 on latest update of Ubuntu >creates a few more warnings on -Warray-bounds and extra >() around 'if' expressions. > >Signed-off-by: Keith Wiles >--- > app/test-pmd/Makefile| 3 +++ > app/test/M

[dpdk-dev] [PATCH v2 1/2] e1000:fix gcc test for clang builds

2016-06-26 Thread Keith Wiles
Signed-off-by: Keith Wiles --- drivers/net/e1000/Makefile | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/net/e1000/Makefile b/drivers/net/e1000/Makefile index 5b801f5..1305163 100644 --- a/drivers/net/e1000/Makefile +++ b/drivers/net/e1000/Makefile @@ -48,7 +48,7

[dpdk-dev] [PATCH v2 2/2] fix building with clang-3.8.0 compiler

2016-06-26 Thread Keith Wiles
Latest clang compiler 3.8.0 on latest update of Ubuntu creates a few more warnings on -Warray-bounds and extra () around 'if' expressions. Signed-off-by: Keith Wiles --- app/test-pmd/Makefile| 3 +++ app/test/Makefile| 3 +++ drivers/net/bonding/Makefile

[dpdk-dev] [PATCH v2] cryptodev: uninline parameter parsing

2016-06-26 Thread Thomas Monjalon
2016-06-25 15:24, De Lara Guarch, Pablo: > > +DPDK_16.07 { > > + global: > > + > > + rte_cryptodev_parse_vdev_init_params; > > I think this function does not need to be public. > This function is only called in the PMDs, and the only public function > to initialize a crypto device is rte_eal_v

[dpdk-dev] [PATCH v3] cryptodev: uninline parameter parsing

2016-06-26 Thread Thomas Monjalon
There is no need to have this parsing inlined in the header. It brings kvargs dependency to every crypto drivers. The functions are moved into rte_cryptodev.c. Signed-off-by: Thomas Monjalon --- v2: - remove kvargs dep in null PMD - add function in .map file v3: - remove kvargs include in drivers

[dpdk-dev] [PATCH v2 0/7] fix dependencies

2016-06-26 Thread Thomas Monjalon
Thanks to the option '-z defs' it is possible to check for missing link dependencies. This series add the missing internal and external dependencies, fix use of rte.extlib.mk and force the check with '-z defs'. v2: - remove traces of combined library - fix a lot more internal dependencies - fix ex

[dpdk-dev] [PATCH v2 1/7] mk: remove traces of combined library

2016-06-26 Thread Thomas Monjalon
Fixes: 948fd64befc3 ("mk: replace the combined library with a linker script") Signed-off-by: Thomas Monjalon --- mk/rte.lib.mk | 18 -- 1 file changed, 18 deletions(-) diff --git a/mk/rte.lib.mk b/mk/rte.lib.mk index 1ff403f..d2523ee 100644 --- a/mk/rte.lib.mk +++ b/mk/rte.lib.m

[dpdk-dev] [PATCH v2 2/7] mk: fix external library link

2016-06-26 Thread Thomas Monjalon
When building an external library with rte.extlib.mk, the internal libraries were not found because the linker search path was the external library install directory (RTE_OUTPUT/lib). It is fixed by searching in the internal library install directory (RTE_SDK_BIN/lib). When building an internal lib

[dpdk-dev] [PATCH v2 3/7] pipeline: fix truncated dependency list

2016-06-26 Thread Thomas Monjalon
From: Panu Matilainen In other libraries, dependency list is always appended to, but in commit 6cbf4f75e059 it with an assignment. This causes the librte_eal dependency added in commit 6cbf4f75e059 to get discarded, resulting in missing dependency on librte_eal. Fixes: 6cbf4f75e059 ("mk: fix mis

[dpdk-dev] [PATCH v2 4/7] mk: fix internal dependencies

2016-06-26 Thread Thomas Monjalon
Some libraries were missing their dependency on eal, mbuf, mempool, ring and kvargs. It is revealed by the linker option "-z defs". Signed-off-by: Thomas Monjalon --- drivers/crypto/aesni_gcm/Makefile | 2 ++ drivers/crypto/aesni_mb/Makefile | 2 ++ drivers/crypto/kasumi/Makefile| 2 ++ dri

[dpdk-dev] [PATCH v2 5/7] mk: fix external dependencies of crypto drivers

2016-06-26 Thread Thomas Monjalon
When linking drivers as shared libraries, the dependencies need to be marked as DT_NEEDED entries. The crypto dependencies (libsso and libIPSec) are static libraries. To make them linked in the shared PMDs, the code must relocatable: - libIPSec_MB.a must be built with -fPIC - libsso_kasumi

[dpdk-dev] [PATCH v2 6/7] pdump: fix missing dependency on libpthread

2016-06-26 Thread Thomas Monjalon
From: Panu Matilainen Fixes: 278f945402c5 ("pdump: add new library for packet capture") Signed-off-by: Panu Matilainen --- lib/librte_pdump/Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/librte_pdump/Makefile b/lib/librte_pdump/Makefile index 14cd53e..166441a 100644 --- a/lib

[dpdk-dev] [PATCH v2 7/7] mk: check shared library dependencies

2016-06-26 Thread Thomas Monjalon
From: Panu Matilainen Require all symbols used by a DSO to be resolvable via LDLIBS at build-time. Previously it was possible to build a library with incomplete dependencies which could then fail at run-time. Signed-off-by: Panu Matilainen --- mk/rte.lib.mk | 2 +- 1 file changed, 1 insertion(

[dpdk-dev] [PATCH v2 1/2] i40e: fix problematic dereference

2016-06-26 Thread Mcnamara, John
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Helin Zhang > Sent: Sunday, June 26, 2016 4:46 PM > To: dev at dpdk.org > Cc: Zhang, Helin > Subject: [dpdk-dev] [PATCH v2 1/2] i40e: fix problematic dereference > > It fixes the issue reported by Coverity of

[dpdk-dev] [PATCH v2 2/2] i40e: fix missing break in switch

2016-06-26 Thread Mcnamara, John
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Helin Zhang > Sent: Sunday, June 26, 2016 4:46 PM > To: dev at dpdk.org > Cc: Zhang, Helin > Subject: [dpdk-dev] [PATCH v2 2/2] i40e: fix missing break in switch > > It fixes the issue reported by Coverity of '

[dpdk-dev] [PATCH] doc: update vhost guide

2016-06-26 Thread Mcnamara, John
> -Original Message- > From: Yuanhan Liu [mailto:yuanhan.liu at linux.intel.com] > Sent: Friday, June 24, 2016 8:53 AM > To: dev at dpdk.org > Cc: Xie, Huawei ; Mcnamara, John > ; Thomas Monjalon ; > Yuanhan Liu > Subject: [PATCH] doc: update vhost guide > > Mainly on updating vhost-user