inside pdump_get_socket_path(), getenv can return
a NULL pointer if the match for SOCKET_PATH_HOME is
not found in the environment. NULL check is added to
return -1 immediately without calling mkdir.
Since pdump_get_socket_path() returns -1 now,
wherever this function is called there the return
val
This patchset fixes coverity issues in pdump library and pdump tool.
v2:
fixed code review comment to use snprintf instead of strncpy.
Reshma Pattan (3):
pdump: check getenv return value
pdump: fix string overflow
app/pdump: fix string overflow
app/pdump/main.c | 4 ++--
lib/
replaced strncpy with snprintf for safely
copying the strings.
Cverity issue 127350: string overflow
Fixes: 278f945402c5 ("pdump: add new library for packet capture")
Signed-off-by: Reshma Pattan
---
lib/librte_pdump/rte_pdump.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff
replaced strncpy with snprintf for safely
copying the strings.
Coverity issue 127351: string overflow
Fixes: caa7028276b8 ("app/pdump: add tool for packet capturing")
Signed-off-by: Reshma Pattan
---
app/pdump/main.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/app/p
Thomas,
Thanks. That fixes it of course.
--TFH
On 6/22/16 3:39 PM, Thomas Monjalon wrote:
> 2016-06-22 14:27, Thomas F Herbert:
>> Program received signal SIGSEGV, Segmentation fault.
>> 0x00616172 in vtpci_init (dev=0xbfb0f0, hw=0x7fffd57d0700,
>> dev_flags=0x7fffdf9c)
>>
2016-06-22 18:33, Jerin Jacob:
> - added VXLAN, GENEVE and NVGRE tunnel flow types
> - added PORT flow type for accounting physical/virtual
> port or channel number in flow creation
[...]
> +#define RTE_ETH_FLOW_PORT 18
> + /**< Physical/virtual port number based flow */
What abo
On 06/22/2016 02:20 PM, Thomas Monjalon wrote:
> 2016-06-22 13:57, Olivier Matz:
>> Hi Thomas,
>>
>> On 06/22/2016 01:49 PM, Thomas Monjalon wrote:
>>> 2016-06-22 14:34, Panu Matilainen:
--- a/lib/librte_port/Makefile
+++ b/lib/librte_port/Makefile
@@ -82,6 +82,8 @@ DEPDIRS-$(CONFIG_
This patch fix all cases to do proper handle all munmap if pointer
of hugepage is not NULL which prohibits resource leak.
Coverity issue: 97920
Fixes: b6a468ad41d5 ("memory: add --socket-mem option")
Signed-off-by: Daniel Mrzyglod
---
lib/librte_eal/linuxapp/eal/eal_memory.c | 6 --
1 file
Icc complains about variable may be used without setting.
Fixes: 97fe6461c7cbfb ("app/test: add SNOW 3G performance test)
Signed-off-by: Deepak Kumar Jain
---
app/test/test_cryptodev_perf.c | 10 --
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/app/test/test_cryptodev_pe
On 22/06/16 17:13, Deepak Kumar Jain wrote:
> Icc complains about variable may be used without setting.
>
> Fixes: 97fe6461c7cbfb ("app/test: add SNOW 3G performance test)
>
> Signed-off-by: Deepak Kumar Jain
Acked-by: John Griffin
On Wed, Jun 22, 2016 at 05:06:30PM +0200, Thomas Monjalon wrote:
> 2016-06-22 18:33, Jerin Jacob:
> > - added VXLAN, GENEVE and NVGRE tunnel flow types
> > - added PORT flow type for accounting physical/virtual
> > port or channel number in flow creation
> [...]
> > +#define RTE_ETH_FLOW_PORT
2016-05-06 05:33, Wenzhuo Lu:
> An issue is found that DCB cannot be configured on ixgbe
> NICs. It's said the TX queue number is not right.
> On ixgbe the max TX queue number is not fixed, it depends
> on the multi-queue mode. The API rte_eth_dev_configure
> should be used to configure this mode.
> Jerin Jacob (2):
> ethdev: add tunnel and port RSS offload types
> ethdev: add ETH_RSS_RETA_SIZE_256
Applied with suggested rewording, thanks
2016-05-03 18:12, Jerin Jacob:
> Elements of struct rte_eth_dev used in the fast path.
> Make struct rte_eth_dev cache aligned to avoid the cases where
> rte_eth_dev elements share the same cache line with other structures.
>
> Signed-off-by: Jerin Jacob
Let's try it in real tests.
Applied, than
2016-02-17 14:20, Ferruh Yigit:
> This is to provide abstraction and reduce global variable access.
>
> Global variable rte_eth_devices kept exported to not break ABI.
>
> Bonding driver not selected on purpose, just it seems it is using
> rte_eth_devices heavily.
The struct rte_eth_dev is mark
2016-06-18 02:27, Hiroyuki Mikita:
> This commit fixes some functions missing in API documentation.
>
> Signed-off-by: Hiroyuki Mikita
Applied, thanks
101 - 116 of 116 matches
Mail list logo