Hi Yuanhan,
On 4/28/2016 6:37 AM, Yuanhan Liu wrote:
> On Tue, Apr 26, 2016 at 12:32:12PM +, Jianfeng Tan wrote:
>> Issue: When virtio was proposed in DPDK, there is no API to free memzones.
>> But this has changed since rte_memzone_free() has been implemented by
>> commit ff909fe21f.
> The m
It fixes the issue reported by Coverity of 'Dereference before
null check', by deleting null checks as they are not necessary
at all, or move null checks before where uses it.
Coverity ID 119267: Dereference before null check.
Coverity ID 13301: Dereference before null check.
Coverity ID 13294: De
It fixes the issue reported by Coverity of 'Missing break in
switch', by deleting 'case I40E_VIRTCHNL_OP_FCOE', as it is
not necessary at all.
Coverity ID 13265: Missing break in switch.
Fixes: 4861cde46116 ("i40e: new poll mode driver")
Signed-off-by: Helin Zhang
---
drivers/net/i40e/i40e_pf.
It fixes the issue reported by Coverity of 'Missing break in
switch', by deleting 'case I40E_VIRTCHNL_OP_FCOE', as it is
not necessary at all.
It also fixes the issue reported by Coverity of 'Dereference
before null check', by deleting null checks as they are not
necessary at all, or move null chec
Add 3 vf ops: rx_queue_count, rxq_info_get and
txq_info_get. They can reuse corresponding pf APIs.
Signed-off-by: Beilei Xing
---
drivers/net/i40e/i40e_ethdev_vf.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/net/i40e/i40e_ethdev_vf.c
b/drivers/net/i40e/i40e_ethdev_vf.c
index
This patch enables configuring MTU for i40e.
Since changing MTU needs to reconfigure queue, stop port first
before configuring MTU.
Signed-off-by: Beilei Xing
---
drivers/net/i40e/i40e_ethdev.c | 35 +++
1 file changed, 35 insertions(+)
diff --git a/drivers/net/i
> -Original Message-
> From: Xing, Beilei
> Sent: Thursday, April 28, 2016 11:18 AM
> To: Wu, Jingjing
> Cc: dev at dpdk.org; Xing, Beilei
> Subject: [PATCH V2] i40evf: add ops for rx queue and tx queue
>
> Add 3 vf ops: rx_queue_count, rxq_info_get and txq_info_get. They can
> reuse cor
> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Yuanhan Liu
> Sent: Tuesday, April 26, 2016 12:46 PM
> To: dev at dpdk.org
> Cc: Xie, Huawei ; Yuanhan Liu
>
> Subject: [dpdk-dev] [PATCH 0/7] vhost/example cleanup/fix
>
> I'm starting to work on the vhost AB
On 2016/04/27 20:02, Panu Matilainen wrote:
> This is a pre-requisite for adding DT_NEEDED dependencies
> between internal libraries.
>
> Signed-off-by: Panu Matilainen
> ---
> mk/rte.lib.mk | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/mk/rte.lib.mk b/mk/rte.lib.mk
2016-04-27 23:19, Yuanhan Liu:
> And applied to dpdk-next-virtio, with few tiny changes:
>
> - we normally put suggested/reported-by above the SoB.
Yes we must keep the chronological order in these lines.
> -Original Message-
> From: maciej.czekaj at caviumnetworks.com
> [mailto:maciej.czekaj at caviumnetworks.com]
> Sent: Friday, April 22, 2016 3:51 PM
> To: dev at dpdk.org
> Cc: De Lara Guarch, Pablo; Mcnamara, John; Maciej Czekaj
> Subject: [PATCH v2 0/3] testpmd: extend commands for be
On 4/24/2016 9:24 PM, Xie, Huawei wrote:
> On 4/24/2016 5:15 PM, Michael S. Tsirkin wrote:
>> On Sun, Apr 24, 2016 at 02:45:22AM +, Xie, Huawei wrote:
>>> Forget to cc the mailing list.
>>>
>>> On 4/22/2016 9:53 PM, Xie, Huawei wrote:
Hi:
This is a series of virtio/vhost idx/ring
> -Original Message-
> From: Mrozowicz, SlawomirX
> Sent: Wednesday, April 13, 2016 12:47 PM
> To: Dumitrescu, Cristian
> Cc: dev at dpdk.org; Mrozowicz, SlawomirX
>
> Subject: [PATCH] examples: fix CID 30699 copy-paste error
>
> It fix coverity issue:
> CID 30699 (#1 of 1): Copy-paste
> -Original Message-
> From: Kobylinski, MichalX
> Sent: Wednesday, April 13, 2016 1:15 PM
> To: dev at dpdk.org; Dumitrescu, Cristian
> Cc: Kobylinski, MichalX
> Subject: [PATCH] cfgfile: fix uninitialized scalar variable
>
> CID 13323:
> Uninitialized scalar variable. Using uninitial
> -Original Message-
> From: Kerlin, MarcinX
> Sent: Thursday, April 14, 2016 10:54 AM
> To: dev at dpdk.org
> Cc: Dumitrescu, Cristian ; Kerlin, MarcinX
>
> Subject: [PATCH] examples/ip_pipeline: fix out-of-bounds write
>
> CID 124567:
> In the function app_init_eal(struct app params *
> -Original Message-
> From: Mrozowicz, SlawomirX
> Sent: Thursday, April 14, 2016 10:53 AM
> To: Dumitrescu, Cristian
> Cc: dev at dpdk.org; Mrozowicz, SlawomirX
>
> Subject: [PATCH] examples: fix CID 30708 out-of-bounds read
>
> It fix coverity issue:
> CID 30708 (#1 of 1): Out-of-bo
> -Original Message-
> From: Mrozowicz, SlawomirX
> Sent: Thursday, April 14, 2016 12:16 PM
> To: Dumitrescu, Cristian
> Cc: dev at dpdk.org; Mrozowicz, SlawomirX
>
> Subject: [PATCH] examples: fix CID 30704 negative loop bound
>
> Fixes: de3cfa2c9823 ("sched: initial import")
> Signed
> -Original Message-
> From: Jastrzebski, MichalX K
> Sent: Thursday, April 21, 2016 12:48 PM
> To: Dumitrescu, Cristian ; Zhang, Roy Fan
> ; Singh, Jasvinder
> Cc: dev at dpdk.org; Mrozowicz, SlawomirX
>
> Subject: [PATCH v2] examples/qos_sched: fix copy-paste error
>
> From: Slawomir
> -Original Message-
> From: Jastrzebski, MichalX K
> Sent: Thursday, April 21, 2016 12:48 PM
> To: Dumitrescu, Cristian ; Zhang, Roy Fan
> ; Singh, Jasvinder
> Cc: dev at dpdk.org; Mrozowicz, SlawomirX
>
> Subject: [PATCH v2] examples/qos_sched: fix negative loop bound
>
> From: Slawo
> -Original Message-
> From: Jastrzebski, MichalX K
> Sent: Thursday, April 21, 2016 12:48 PM
> To: Dumitrescu, Cristian ; Zhang, Roy Fan
> ; Singh, Jasvinder
> Cc: dev at dpdk.org; Mrozowicz, SlawomirX
>
> Subject: [PATCH v2] examples/qos_sched: fix out-of-bounds read
>
> From: Slawom
> -Original Message-
> From: Jastrzebski, MichalX K
> Sent: Thursday, April 21, 2016 2:08 PM
> To: Dumitrescu, Cristian ; Zhang, Roy Fan
> ; Singh, Jasvinder
> Cc: dev at dpdk.org; Mrozowicz, SlawomirX
>
> Subject: [PATCH v3] examples/qos_sched: fix negative loop bound
>
> From: Slawom
> -Original Message-
> From: Jastrzebski, MichalX K
> Sent: Thursday, April 21, 2016 2:08 PM
> To: Dumitrescu, Cristian ; Zhang, Roy Fan
> ; Singh, Jasvinder
> Cc: dev at dpdk.org; Mrozowicz, SlawomirX
>
> Subject: [PATCH v3] examples/qos_sched: fix copy-paste error
>
> From: Slawomir
> -Original Message-
> From: Kobylinski, MichalX
> Sent: Friday, April 22, 2016 11:41 AM
> To: Dumitrescu, Cristian ; dev at dpdk.org
> Cc: Kobylinski, MichalX
> Subject: [PATCH] cfgfile: fix integer overflow
>
> Fix issue reported by Coverity.
>
> Coverity ID 13289: Integer overflowed
> -Original Message-
> From: Jastrzebski, MichalX K
> Sent: Thursday, April 21, 2016 2:08 PM
> To: Dumitrescu, Cristian ; Zhang, Roy Fan
> ; Singh, Jasvinder
> Cc: dev at dpdk.org; Mrozowicz, SlawomirX
>
> Subject: [PATCH v3] examples/qos_sched: fix bad bit shift operation
>
> From: Sl
> -Original Message-
> From: Jastrzebski, MichalX K
> Sent: Thursday, April 21, 2016 12:48 PM
> To: Dumitrescu, Cristian ; Zhang, Roy Fan
> ; Singh, Jasvinder
> Cc: dev at dpdk.org; Mrozowicz, SlawomirX
>
> Subject: [PATCH v2] examples/qos_meter: fix unchecked return value
>
> From: Sl
Include stdint.h for the definition of uint*_t types.
Signed-off-by: Igor Ryzhov
---
lib/librte_lpm/rte_lpm6.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/lib/librte_lpm/rte_lpm6.h b/lib/librte_lpm/rte_lpm6.h
index cedcea8..13d027f 100644
--- a/lib/librte_lpm/rte_lpm6.h
+++ b/lib/librt
On Thu, 28 Apr 2016 08:52:59 + De Lara Guarch, Pablo wrote:
>
>
>> -Original Message-
>> From: maciej.czekaj at caviumnetworks.com
>> [mailto:maciej.czekaj at caviumnetworks.com]
>> Sent: Friday, April 22, 2016 3:51 PM
>> To: dev at dpdk.org
>> Cc: De Lara Guarch, Pablo; Mcnamara, John;
> -Original Message-
> From: Maciej Czekaj [mailto:maciej.czekaj at caviumnetworks.com]
> Sent: Thursday, April 28, 2016 1:10 PM
> To: De Lara Guarch, Pablo; dev at dpdk.org
> Cc: Mcnamara, John
> Subject: Re: [dpdk-dev] [PATCH v2 0/3] testpmd: extend commands for
> better scatter-gather
On 4/28/2016 4:14 PM, Thomas Monjalon wrote:
> 2016-04-27 23:19, Yuanhan Liu:
>> And applied to dpdk-next-virtio, with few tiny changes:
>>
>> - we normally put suggested/reported-by above the SoB.
> Yes we must keep the chronological order in these lines.
>
Thanks for reminder
On Thu, 28 Apr 2016 13:13:20 + De Lara Guarch, Pablo wrote:
>
>
>> -Original Message-
>> From: Maciej Czekaj [mailto:maciej.czekaj at caviumnetworks.com]
>> Sent: Thursday, April 28, 2016 1:10 PM
>> To: De Lara Guarch, Pablo; dev at dpdk.org
>> Cc: Mcnamara, John
>> Subject: Re: [dpdk-d
Hi John,
(adding some PMD maintainers in the loop)
> From: Olivier Matz [mailto:olivier.matz at 6wind.com]
>> It seems the meaning of the PKT_RX_VLAN_PKT bit depends on the port
>> configuration:
>> - if vlan stripping is configured, it means VLAN is present in vlan_tci
>>mbuf field
>> - if n
Hi Keith,
On 04/15/2016 04:41 PM, Wiles, Keith wrote:
>> While parsing token string there may be several modes:
>> - fixed single string
>> - multi-choice single string
>> - any single string
>>
>> This patch add one more mode - any multi string.
>>
>> Signed-off-by: Piotr Azarewicz
>
> Does this
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of David Harton
> (dharton)
> Sent: Wednesday, April 20, 2016 5:04 PM
> To: Horton, Remy ; dev at dpdk.org
> Subject: Re: [dpdk-dev] [RFC PATCH v1 0/3] Remove string operations
> from xstats
>
> > -Original Message-
> > From: dev [mail
> -Original Message-
> From: Tahhan, Maryam [mailto:maryam.tahhan at intel.com]
> Sent: Thursday, April 28, 2016 10:56 AM
> To: David Harton (dharton) ; Horton, Remy
> ; dev at dpdk.org
> Cc: Mcnamara, John ; Van Haaren, Harry
>
> Subject: RE: [dpdk-dev] [RFC PATCH v1 0/3] Remove string op
Issue: virtio's drv_flags are decided by devices types (modern vs legacy),
and which kernel driver is used, and the negotiated features (especially
VIRTIO_NET_STATUS) with backend, which makes it possible to multiple
virtio devices have different versions of drv_flags, but this variable
is currentl
Commit 1: Do some cleanup in virtio_dev_queue_setup();
Commit 2: Fix the memory leak bug.
Signed-off-by: Jianfeng Tan
Jianfeng Tan (2):
virtio: cleanup virtio_dev_queue_setup()
virtio: fix memory leak of virtqueue memzones
drivers/net/virtio/virtio_ethdev.c | 66 +--
Signed-off-by: Jianfeng Tan
---
drivers/net/virtio/virtio_ethdev.c | 47 +++---
1 file changed, 24 insertions(+), 23 deletions(-)
diff --git a/drivers/net/virtio/virtio_ethdev.c
b/drivers/net/virtio/virtio_ethdev.c
index 1fe90ae..0553b67 100644
--- a/drivers/net/
Issue: When virtio was proposed in DPDK, there is no API to free memzones.
But this has changed since rte_memzone_free() has been implemented by
commit ff909fe21f0a ("mem: introduce memzone freeing").
This patch is to make sure memzones in struct virtqueue, like mz and
virtio_net_hdr_mz, are freed
Self NACK.
Missed to reset vq->started.
> -Original Message-
> From: Tan, Jianfeng
> Sent: Friday, April 29, 2016 3:04 AM
> To: dev at dpdk.org
> Cc: Xie, Huawei; yuanhan.liu at linux.intel.com; Tan, Jianfeng
> Subject: [PATCH v2 0/2] virtio: fix memory leak of virtqueue memzones
>
> Com
> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Tan, Jianfeng
> Sent: Friday, April 29, 2016 3:05 AM
> To: dev at dpdk.org
> Cc: Xie, Huawei; yuanhan.liu at linux.intel.com
> Subject: Re: [dpdk-dev] [PATCH v2 0/2] virtio: fix memory leak of virtqueue
> memzo
On Fri, Apr 22, 2016 at 03:43:59PM +0200, Thomas Monjalon wrote:
> The debug logs must be enabled at compile-time and run-time.
> There are also some internal flags in some examples to enable the debug
> logs of the applications. They are now enabled in debug configs and
> can be disabled thanks to
On Fri, Apr 29, 2016 at 12:48:46AM +, Jianfeng Tan wrote:
> @@ -447,6 +453,7 @@ int virtio_dev_queue_setup(struct rte_eth_dev *dev,
>
> hw->vtpci_ops->setup_queue(hw, vq);
>
> + vq->started = 1;
Judging that this is in the "_queue_setup" stage, and we have another
stage called "_
42 matches
Mail list logo
