[dpdk-dev] [PATCH] virtio: fix segfault when transmit pkts

Hi Yuanhan & Huawei, On 4/22/2016 10:23 PM, Xie, Huawei wrote: > On 4/22/2016 6:43 AM, Yuanhan Liu wrote: >> On Thu, Apr 21, 2016 at 12:36:10PM +, Jianfeng Tan wrote: >>> Issue: when using virtio nic to transmit pkts, it causes segment fault. >> Jianfeng, >> >> It's good to describe the issues

[dpdk-dev] Byte order of vlan_tci of rte_mbuf is different on different source

When using I350 working on SR-IOV mode, we got confused that byte order of vlan_tci in the VF received packet descriptor is different when the packet source is different. 1) Packets from VF to VF, the byte order is big-endian. (e.g. 0xF00) 2) Packets from PC to VF, the byte order is little-endian

[dpdk-dev] [PATCH v2] virtio: fix segfault when transmit pkts

Issue: when using virtio nic to transmit pkts, it causes segment fault. How to reproduce: Basically, we need to construct a case with vm send packets to vhost-user, and this issue does not happen when transmitting packets using indirect desc. Besides, make sure all descriptors are exhausted before

[dpdk-dev] [PATCH v2] i40e: fix problematic dereference

Fix issue reported by Coverity. Coverity ID 119267: Dereference before null check. Coverity ID 13301: Dereference before null check. Coverity ID 13294: Dereference before null check. Coverity ID 13299: Dereference before null check. Coverity ID 13298: Dereference before null check. Coverity ID 132

[dpdk-dev] [PATCH v2] virtio: fix segfault when transmit pkts

On 4/25/2016 10:37 AM, Tan, Jianfeng wrote: > Issue: when using virtio nic to transmit pkts, it causes segment fault. > > How to reproduce: > Basically, we need to construct a case with vm send packets to vhost-user, > and this issue does not happen when transmitting packets using indirect > desc.

[dpdk-dev] [RFC] Link ibrte_vhost to librte_pmd_vhost

Hi Yuanhan, I want to apply a patch to vhost PMD. Before submitting, could you please let me know your guess about the patch? Here is my problem. I am using below shared library configuration to build my application. CONFIG_RTE_BUILD_SHARED_LIB=y Normally, My application doesn't need vhost facili

[dpdk-dev] [RFC] eal: provide option to set vhost_user socket owner/permissions

The API doesn't hold a way to specify a owner/permission set for vhost_user created sockets. I don't even think an API change would make that much sense. Projects consuming DPDK start to do 'their own workarounds' like openvswitch https://patchwork.ozlabs.org/patch/559043/ https://patchwork.ozlabs

[dpdk-dev] [RFC] Link ibrte_vhost to librte_pmd_vhost

On 04/25/2016 12:05 PM, Tetsuya Mukawa wrote: > Hi Yuanhan, > > I want to apply a patch to vhost PMD. > Before submitting, could you please let me know your guess about the patch? > > Here is my problem. > I am using below shared library configuration to build my application. > CONFIG_RTE_BUILD_SHA

[dpdk-dev] [PATCH v2] i40e: fix problematic dereference

On Mon, Apr 25, 2016 at 01:44:02PM +0800, Helin Zhang wrote: > Fix issue reported by Coverity. > > Coverity ID 119267: Dereference before null check. > Coverity ID 13301: Dereference before null check. > Coverity ID 13294: Dereference before null check. > Coverity ID 13299: Dereference before null

[dpdk-dev] [RFC] Link ibrte_vhost to librte_pmd_vhost

On 2016/04/25 18:28, Panu Matilainen wrote: > On 04/25/2016 12:05 PM, Tetsuya Mukawa wrote: >> Hi Yuanhan, >> >> I want to apply a patch to vhost PMD. >> Before submitting, could you please let me know your guess about the >> patch? >> >> Here is my problem. >> I am using below shared library confi

[dpdk-dev] Git repository might be down

Hi, I've faced below error while connecting to DPDK git repository. $ git clone git://dpdk.org/dpdk Cloning into 'dpdk'... fatal: read error: Connection reset by peer It might be caused by my environment, but report it just in case. Thanks, Tetsuya

[dpdk-dev] Git repository might be down

Hi, we were discussing on #DPDK about the same. So far it seems via git:// it fails, but http works for now - thanks to David Marchland for identifying this fallback. Christian Ehrhardt Software Engineer, Ubuntu Server Canonical Ltd On Mon, Apr 25, 2016 at 11:59 AM, Tetsuya Mukawa wrote: > Hi

[dpdk-dev] [PATCH] version: 16.07-rc0

On Fri, Apr 22, 2016 at 04:04:20PM +0200, Thomas Monjalon wrote: > After having removed the deprecated stuff, we can start pushing > new fixes and features in the version 16.07. > > Signed-off-by: Thomas Monjalon Acked-by: Bruce Richardson

[dpdk-dev] [PATCH v2] ixgbe: fix bad shift operation in ixgbe_set_pool_rx/tx

On Fri, Apr 22, 2016 at 05:35:57PM +0200, Tomasz Kulasek wrote: > Fix issue reported by Coverity. > > Coverity ID 13193: Bad bit shift operation (BAD_SHIFT) > large_shift: In expression 1 << pool, left shifting by more than 31 bits > has undefined behavior. The shift amount, pool, is at least 32.

[dpdk-dev] [PATCH v2] ixgbe: fix bad shift operation in ixgbe_set_pool_rx/tx

On Mon, Apr 25, 2016 at 11:35:44AM +0100, Bruce Richardson wrote: > On Fri, Apr 22, 2016 at 05:35:57PM +0200, Tomasz Kulasek wrote: > > Fix issue reported by Coverity. > > > > Coverity ID 13193: Bad bit shift operation (BAD_SHIFT) > > large_shift: In expression 1 << pool, left shifting by more tha

[dpdk-dev] Git repository might be down

Thanks for reporting. It has been fixed by resetting git-daemon and related zombies. 2016-04-25 12:13, Christian Ehrhardt: > Hi, > we were discussing on #DPDK about the same. > > So far it seems via git:// it fails, but http works for now - thanks to > David Marchland for identifying this fallb

[dpdk-dev] PKT_RX_VLAN_PKT when VLAN stripping is disabled

Hi John, >From rte_mbuf.h: #define PKT_RX_VLAN_PKT (1ULL << 0) /**< RX packet is a 802.1q VLAN packet. */ So yes, in theory it should be set up for vlan packet with both stripping on/off. The problem is that (as far as I know) when VLAN stripping is disabled FVL RXD doesn't contain inform

[dpdk-dev] [RFC PATCH] ivshmem ring aliases

> The goal of this parch is to allow VMs to use standard ring names regardless > of the names given to the rings by host environment. It applies to > configurations using ivshmem. > > With shared memory rings, all VMs share a single namespace for the rings. > However, a VM will typically expect to

[dpdk-dev] PKT_RX_VLAN_PKT when VLAN stripping is disabled

Hi, On 04/25/2016 02:02 PM, Ananyev, Konstantin wrote: > Hi John, > From rte_mbuf.h: > #define PKT_RX_VLAN_PKT (1ULL << 0) /**< RX packet is a 802.1q VLAN > packet. */ > So yes, in theory it should be set up for vlan packet with both stripping > on/off. > The problem is that (as far as I k

[dpdk-dev] [PATCH] kni: add chained mbufs support

rx_q fifo may have chained mbufs, merge them into single skb before handing to the network stack. Signed-off-by: Ferruh Yigit --- .../linuxapp/eal/include/exec-env/rte_kni_common.h | 4 +- lib/librte_eal/linuxapp/kni/kni_net.c | 83 -- 2 files changed, 64 insert

[dpdk-dev] PKT_RX_VLAN_PKT when VLAN stripping is disabled

Hi Olivier, > -Original Message- > From: Olivier Matz [mailto:olivier.matz at 6wind.com] > Sent: Monday, April 25, 2016 2:51 PM > To: Ananyev, Konstantin; 'John Daley (johndale)'; dev at dpdk.org > Subject: Re: [dpdk-dev] PKT_RX_VLAN_PKT when VLAN stripping is disabled > > Hi, > > On 04/

[dpdk-dev] [PATCH 1/4] ixgbe: rearrange vector PMD code for x86

On Wed, Apr 20, 2016 at 09:44:59PM +0800, Jianbo Liu wrote: > move SSE-dependent code to new file "ixgbe_rxtx_vec_sse.h" > > Signed-off-by: Jianbo Liu > --- > drivers/net/ixgbe/ixgbe_rxtx_vec.c | 369 + > drivers/net/ixgbe/ixgbe_rxtx_vec_sse.h | 408 > +++

[dpdk-dev] ixgbe : query regarding your code changes for VF mac add

Hi Ivan ixgbevf_set_default_mac_addr() could not find in our code base. put traces at other places as suggested by you. Log at "eth_ixgbevf_dev_init" never displayed Rest logs displayed as shown below. I re-build the driver module and loaded on our virtual router and rebooted the system. 1

[dpdk-dev] [PATCH v2] virtio: fix segfault when transmit pkts

On Mon, Apr 25, 2016 at 02:37:45AM +, Jianfeng Tan wrote: > Issue: when using virtio nic to transmit pkts, it causes segment fault. > > How to reproduce: > Basically, we need to construct a case with vm send packets to vhost-user, > and this issue does not happen when transmitting packets usin

[dpdk-dev] [RFC] Link ibrte_vhost to librte_pmd_vhost

On Mon, Apr 25, 2016 at 12:28:37PM +0300, Panu Matilainen wrote: > > >Another way is applying a below patch. > >--- a/drivers/net/vhost/Makefile > >+++ b/drivers/net/vhost/Makefile > >@@ -38,6 +38,7 @@ LIB = librte_pmd_vhost.a > > > > CFLAGS += -O3 > > CFLAGS += $(WERROR_FLAGS) > >+LDLIBS += -lr

[dpdk-dev] [RFC] eal: provide option to set vhost_user socket owner/permissions

On Mon, Apr 25, 2016 at 11:18:16AM +0200, Christian Ehrhardt wrote: > The API doesn't hold a way to specify a owner/permission set for vhost_user > created sockets. Yes, it's kind of like a known issue. So, thanks for bringing it, with a solution, for dicussion (cc'ed more people). > I don't even

[dpdk-dev] [PATCH 0/7] vhost/example cleanup/fix

I'm starting to work on the vhost ABI refactoring, that I also have to touch the vhost example code, to make it work. The vhost example code, however, is very messy, full of __very__ long lines. This would make a later diff to apply the new vhost API be very ugly, therefore, not friendly for review

[dpdk-dev] [PATCH 1/7] examples/vhost: remove the non-working zero copy code

It's reported that it's has not been working for a long while. And due to it's complex, it's better to redesign it than to fixing it to make it work again. Meanwhile, I was working on the zero copy re-implemenation. Therefore, I may bring it back this release, with a much cleaner code. Well, it ma

[dpdk-dev] [PATCH 2/7] examples/vhost: remove unused macro and struct

Interestingly, DESC_PER_CACHELINE has never been used since the introduction of vhost example. Remove it. vlan_ethhdr struct and VLAN_ETH_HLEN macro reference had been removed by commit 4d50b6acbd95 "examples/vhost: adapt Tx routing to lib", but had forgot to remove the definition. Fixes: 4d50b6a

[dpdk-dev] [PATCH 3/7] examples/vhost: use tailq to link vhost devices

To simplify code and logic. Signed-off-by: Yuanhan Liu --- examples/vhost/main.c | 457 +- examples/vhost/main.h | 32 ++-- 2 files changed, 128 insertions(+), 361 deletions(-) diff --git a/examples/vhost/main.c b/examples/vhost/main.c index b5dd

[dpdk-dev] [PATCH 4/7] examples/vhost: use mac compare helper function directly

rte_ether.h already provides a helper function to do mac address compare. No need to define our own, use it directly. Signed-off-by: Yuanhan Liu --- examples/vhost/main.c | 14 +- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git a/examples/vhost/main.c b/examples/vhost/mai

[dpdk-dev] [PATCH 5/7] examples/vhost: handle broadcast packet

Every time I do a VM2VM iperf test with vhost example, I have to set the arp table manually, as vhost-switch just ignores the broadcast packet, leaving the ARP request not served. Here we do a transmit a broadcast packet (such as ARP request) to every vhost device, as well as the physical port, to

[dpdk-dev] [PATCH 6/7] examples/vhost: fix mbuf allocation failures

It has always been a mystery (at least to me before) that how many mbuf is enough while creating an mbuf pool. While current macro NUM_MBUFS_PER_PORT gives your some insights, it's not that accurate: it doesn't consider the case we may receive a big packet, say 64K when TSO is enabled. So, while t

[dpdk-dev] [PATCH 7/7] examples/vhost: switch_worker cleanup

switch_worker() is the last piece of code that is messy yet it touches virtio/vhost device. Here do a cleanup, so that we will be less painful for later vhost ABI refactoring. The cleanup is straigforward: break long lines, move some code into functions, the last, comment a bit on switch_worker()

[dpdk-dev] [PATCH] virtio: fix segfault when transmit pkts

On Thu, 21 Apr 2016 12:36:10 + Jianfeng Tan wrote: > Issue: when using virtio nic to transmit pkts, it causes segment fault. > > How to reproduce: > a. start testpmd with vhost. > $testpmd -c 0x3 -n 4 --socket-mem 1024,0 --no-pci \ > --vdev 'eth_vhost0,iface=/tmp/sock0,queues=1' -- -i --nb

[dpdk-dev] [PATCH v6 0/8] qede: Add qede PMD

Hi Bruce, Thomas, The v6 series incorporates the following review comments: - Merged MAINTAINERS, documentation and license patches - MAINTAINERS: re-ordered qede PMD below bnx2x PMD - Renamed CFLAGS_ECORE_DRIVER options to CFLAGS_BASE_DRIVER - Makefile split for base and core driver - Fix cl

[dpdk-dev] [PATCH v6 1/8] qede: Add maintainers, documentation and license

Signed-off-by: Harish Patil Signed-off-by: Rasesh Mody Signed-off-by: Sony Chacko --- MAINTAINERS |7 + doc/guides/nics/index.rst |1 + doc/guides/nics/overview.rst | 86 +- doc/guides/nics/qede.rst | 314 +++

[dpdk-dev] [PATCH v6 3/8] qede: Add core driver

The Qlogic Everest Driver for Ethernet(QEDE) Poll Mode Driver(PMD) is the DPDK specific module for QLogic FastLinQ QL4 25G/40G CNA family of adapters as well as their virtual functions (VF) in SR-IOV context. This patch adds QEDE PMD, which interacts with base driver and initialises the HW. T

[dpdk-dev] [PATCH v6 4/8] qede: Add L2 support

This patch adds the features to supports configuration of various Layer 2 elements, such as channels and filtering options. Signed-off-by: Harish Patil Signed-off-by: Rasesh Mody Signed-off-by: Sony Chacko --- drivers/net/qede/Makefile|2 + drivers/net/qede/base/ecore_chain.h

[dpdk-dev] [PATCH v6 5/8] qede: Add SRIOV support

This patch adds following SRIOV features to qede PMD: - VF configuration - VF intialization/de-initialization - VF PF communications channel - statistics capture and query Signed-off-by: Harish Patil Signed-off-by: Rasesh Mody Signed-off-by: Sony Chacko --- drivers/net/qede/Makefile

[dpdk-dev] [PATCH v6 7/8] qede: Add DCBX support

This patch adds LLDP and DCBX capabilities to the qede PMD. Signed-off-by: Harish Patil Signed-off-by: Rasesh Mody Signed-off-by: Sony Chacko --- drivers/net/qede/Makefile |1 + drivers/net/qede/base/bcm_osal.h |1 + drivers/net/qede/base/ecore.h |

[dpdk-dev] [PATCH v6 8/8] qede: Enable PMD build

This patch enables the QEDE PMD build. Signed-off-by: Harish Patil Signed-off-by: Rasesh Mody Signed-off-by: Sony Chacko --- config/common_base | 12 drivers/net/Makefile |1 + mk/rte.app.mk|2 ++ 3 files changed, 15 insertions(+) diff --git a/config/common_ba

[dpdk-dev] [RFC] Link ibrte_vhost to librte_pmd_vhost

On Tue, Apr 26, 2016 at 02:37:37PM +0900, Tetsuya Mukawa wrote: > On 2016/04/26 12:47, Yuanhan Liu wrote: > > On Mon, Apr 25, 2016 at 12:28:37PM +0300, Panu Matilainen wrote: > > > > >>> Another way is applying a below patch. > >>> --- a/drivers/net/vhost/Makefile > >>> +++ b/drivers/net/vhost/Mak

[dpdk-dev] [PATCH] virtio: check if virtio net header could fit in mbuf headroom

check merge-able header as it is supported. previously we don't support merge-able feature, so non merge-able header is checked. --- drivers/net/virtio/virtio_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virti

[dpdk-dev] [PATCH v6 2/8] qede: Add base driver

The base driver is the backend module for the QLogic FastLinQ QL4 25G/40G CNA family of adapters as well as their virtual functions (VF) in SR-IOV context. The purpose of the base module is to: - provide all the common code that will be shared between the various drivers that would be used

[dpdk-dev] [PATCH v6 6/8] qede: Add attention support

Physical link is handled by the management Firmware. This patch lays the infrastructure for attention handling in the driver, as link change notifications arrive via async attentions, as well as the handling of such notifications. It adds async event notification handler interfaces to the PMD. Sig