[dpdk-dev] [RFC 27/35] eal/xen: return machine address without knowing memseg id

2016-03-09 Thread Olivier Matz
The conversion from guest physical address to machine physical address is fast when the caller knows the memseg corresponding to the gpa. But in case the user does not know this information, just find it by browsing the segments. This feature will be used by next commit. Signed-off-by: Olivier Ma

[dpdk-dev] [RFC 28/35] mempool: rework support of xen dom0

2016-03-09 Thread Olivier Matz
Avoid to have a specific file for that, and remove #ifdefs. Now that we have introduced a function to populate a mempool with a virtual area, the support of xen dom0 is much easier. The only thing we need to do is to convert the guest physical address into the machine physical address using rte_me

[dpdk-dev] [RFC 29/35] mempool: create the internal ring when populating

2016-03-09 Thread Olivier Matz
Instead of creating the internal ring at mempool creation, do it when populating the mempool with the first memory chunk. The objective here is to simplify the change of external handler when it will be introduced. For instance, this will be possible: mp = rte_mempool_create_empty(...) rte_me

[dpdk-dev] [RFC 32/35] mempool: make mempool populate and free api public

2016-03-09 Thread Olivier Matz
Add the following functions to the public mempool API: - rte_mempool_create_empty() - rte_mempool_populate_phys() - rte_mempool_populate_phys_tab() - rte_mempool_populate_virt() - rte_mempool_populate_default() - rte_mempool_populate_anon() - rte_mempool_free() Signed-off-by: Olivier Matz --- l

[dpdk-dev] [RFC 31/35] test-pmd: remove specific anon mempool code

2016-03-09 Thread Olivier Matz
Now that mempool library provide functions to populate with anonymous mmap'd memory, we can remove this specific code from test-pmd. Signed-off-by: Olivier Matz --- app/test-pmd/Makefile| 4 - app/test-pmd/mempool_anon.c | 201 --- app/test-pmd/

[dpdk-dev] [RFC 33/35] mem: avoid memzone/mempool/ring name truncation

2016-03-09 Thread Olivier Matz
Check the return value of snprintf to ensure that the name of the object is not truncated. By the way, update the test to avoid to trigger an error in that case. Signed-off-by: Olivier Matz --- app/test/test_mempool.c| 12 lib/librte_eal/common/eal_common_memzon

[dpdk-dev] [RFC 12/35] mempool: use the list to initialize mempool objects

2016-03-09 Thread Olivier Matz
Before this patch, the mempool elements were initialized at the time they were added to the mempool. This patch changes this to do the initialization of all objects once the mempool is populated, using rte_mempool_obj_iter() introduced in previous commits. Thanks to this modification, we are getti

[dpdk-dev] [RFC 34/35] mempool: new flag when phys contig mem is not needed

2016-03-09 Thread Olivier Matz
Add a new flag to remove the constraint of having physically contiguous objects inside a mempool. Add this flag to the log history mempool to start, but we could add it in most cases where objects are not mbufs. Signed-off-by: Olivier Matz --- lib/librte_eal/common/eal_common_log.c | 2 +- lib

[dpdk-dev] [RFC 30/35] mempool: populate a mempool with anonymous memory

2016-03-09 Thread Olivier Matz
Now that we can populate a mempool with any virtual memory, it is easier to introduce a function to populate a mempool with memory coming from an anonymous mapping, as it's done in test-pmd. The next commit will replace test-pmd anonymous mapping by this function. Signed-off-by: Olivier Matz ---

[dpdk-dev] [RFC 35/35] mempool: update copyright

2016-03-09 Thread Olivier Matz
Update the copyright of files touched by this patch series. Signed-off-by: Olivier Matz --- lib/librte_mempool/rte_mempool.c | 1 + lib/librte_mempool/rte_mempool.h | 1 + 2 files changed, 2 insertions(+) diff --git a/lib/librte_mempool/rte_mempool.c b/lib/librte_mempool/rte_mempool.c index 209

[dpdk-dev] [PATCH v2 1/2] ethdev: add buffered tx api

2016-03-09 Thread Thomas Monjalon
2016-03-09 16:17, Ananyev, Konstantin: > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > > 2016-03-09 15:42, Ananyev, Konstantin: > > > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > > > > 2016-03-09 15:23, Ananyev, Konstantin: > > > > > > > > > > > > 2016-03-09 13:36,

[dpdk-dev] [PATCH v3 0/7] Performance optimizations for mlx5 and mlx4

2016-03-09 Thread Bruce Richardson
On Thu, Mar 03, 2016 at 03:27:10PM +0100, Adrien Mazarguil wrote: > This patchset improves the mlx5 PMD performance by doing better prefetching, > by reordering internal structure fields and by removing a few unnecessary > operations. > > Note: should be applied after "Add flow director and RX VLA

[dpdk-dev] [PATCH v3 4/4] mempool: add in the RTE_NEXT_ABI for ABI breakages

2016-03-09 Thread Hunt, David
Hi Olivier, On 3/9/2016 2:59 PM, Olivier MATZ wrote: > Hi David, > > On 03/09/2016 12:30 PM, Hunt, David wrote: >> Hi Panu, >> >> On 3/9/2016 10:46 AM, Panu Matilainen wrote: >>> On 03/09/2016 11:50 AM, David Hunt wrote: This patch is for those people who want to be easily able to switch

[dpdk-dev] [PATCH v3 4/4] mempool: add in the RTE_NEXT_ABI for ABI breakages

2016-03-09 Thread Olivier MATZ
Hi David, On 03/09/2016 05:28 PM, Hunt, David wrote: >> Sorry, maybe I wasn't very clear in my previous messages. For me, the >> NEXT_ABI is not the proper solution because, as Panu stated, it makes >> the patch hard to read. My understanding of NEXT_ABI is that it should >> only be used if the ch

[dpdk-dev] [PATCH v2 1/2] ethdev: add buffered tx api

2016-03-09 Thread Kulasek, TomaszX
> -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Tuesday, March 8, 2016 23:52 > To: Kulasek, TomaszX > Cc: dev at dpdk.org; Ananyev, Konstantin > Subject: Re: [dpdk-dev] [PATCH v2 1/2] ethdev: add buffered tx api > > Hi, > [...] > > +/** > >

[dpdk-dev] [PATCH v3 4/4] mempool: add in the RTE_NEXT_ABI for ABI breakages

2016-03-09 Thread Hunt, David
Hi Olivier, On 3/9/2016 4:31 PM, Olivier MATZ wrote: > Hi David, > > On 03/09/2016 05:28 PM, Hunt, David wrote: > >> Sure, v4 will remove the NEXT_ABI patch , and replace it with just the >> ABI break announcement for 16.07. For anyone who what's to try out the >> patch, they can always get it fro

[dpdk-dev] [RFC 00/35] mempool: rework memory allocation

2016-03-09 Thread Olivier MATZ
On 03/09/2016 05:19 PM, Olivier Matz wrote: > This series is a rework of mempool. > > [...] I forgot to mention that this series applies on top of Keith's patch, which is also planned for 16.07: http://www.dpdk.org/dev/patchwork/patch/10492/ Olivier

[dpdk-dev] Client Server Application using DPDK API

2016-03-09 Thread Remy Horton
'noon, On 09/03/2016 08:45, Vivek Gupta wrote: > Hi > > I want to write a Client Server application using DPDK API on a > single machine. What are the basic building block for that. How can > we write such application? examples/l2fwd/main.c and examples/ethtool/ethtool-app/main.c are probably th

[dpdk-dev] [PATCH v5 0/2] Increased number of next hops for LPM IPv4.

2016-03-09 Thread Michal Jastrzebski
From: Michal Kobylinski This patchset extend next_hop field from 8-bits to 24-bits in LPM library for IPv4. As next_hop field is increased now the maximum number of tbl8s is 2^24. A new rte_lpm_config structure is used so LPM library will allocate exactly the amount of memory which is necessar

[dpdk-dev] [PATCH v5 1/2] lpm: extended ipv4 next_hop field

2016-03-09 Thread Michal Jastrzebski
From: Michal Kobylinski This patch extend next_hop field from 8-bits to 24-bits in LPM library for IPv4. Added versioning symbols to functions and updated library and applications that have a dependency on LPM library. Signed-off-by: Michal Kobylinski Acked-by: David Hunt --- app/test/test_l

[dpdk-dev] [PATCH v5 2/2] lpm: added a new rte_lpm_config structure for ipv4

2016-03-09 Thread Michal Jastrzebski
From: Michal Kobylinski This patch has depend on: lpm: extended ipv4 next_hop field (v4). A new rte_lpm_config structure is used so LPM library will allocate exactly the amount of memory which is necessary to hold application?s rules. Signed-off-by: Michal Kobylinski Acked-by: David Hunt ---

[dpdk-dev] [PATCH v3 0/2] doc: add i40e pmd driver introduction

2016-03-09 Thread Thomas Monjalon
2016-03-09 15:28, Jingjing Wu: > A new doc "i40e.rst" is added to introduce i40e pmd driver. > > v3 changes: > - update table in overview.rst. > - rework index.rst to keep an alphabetical order. > > v2 changes: > - restrict long code line > - fix typo > > Jingjing Wu (2): > doc: add doc fo

[dpdk-dev] [PATCH v2 1/2] ethdev: add buffered tx api

2016-03-09 Thread Thomas Monjalon
2016-03-09 16:35, Kulasek, TomaszX: > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > > > +void > > > +rte_eth_count_unsent_packet_callback(struct rte_mbuf **pkts, uint16_t > > unsent, > > > + void *userdata); > > > > What about rte_eth_tx_buffer_default_callback as name? >

[dpdk-dev] [PATCH] doc: add szedata2 features into networking driver matrix

2016-03-09 Thread Thomas Monjalon
> Signed-off-by: Matej Vido > --- > doc/guides/nics/overview.rst | 20 ++-- > 1 file changed, 10 insertions(+), 10 deletions(-) Applied, thanks

[dpdk-dev] [PATCH v3] doc/nic: add ixgbe statistics on read frequency

2016-03-09 Thread Thomas Monjalon
2016-03-08 14:29, Harry van Haaren: > This patch adds a note to the ixgbe PMD guide, stating > the minimum time that statistics must be polled from > the hardware in order to avoid register values becoming > saturated and "sticking" to the max value. > > Reported-by: Jerry Zhang > Tested-by: Marc

[dpdk-dev] [PATCH v3] docs: add statistics read frequency to fm10k guide

2016-03-09 Thread Thomas Monjalon
2016-03-08 17:16, Harry van Haaren: > This patch documents that the statistics of fm10k based NICs must be > read regularly in order to avoid an undetected 32 bit integer-overflow. > > Signed-off-by: Harry van Haaren > Acked-by: John McNamara Applied, thanks

[dpdk-dev] [PATCH v3] doc: add Vector FM10K introductions

2016-03-09 Thread Thomas Monjalon
> > From: "Chen Jing D(Mark)" > > Acked-by: John McNamara Applied, thanks Next step: fill the matrix in overview.rst :)

[dpdk-dev] [PATCH] mempool: avoid memory waste with large pagesize

2016-03-09 Thread Olivier MATZ
On 03/09/2016 03:29 AM, Stephen Hemminger wrote: > If page size is large (like 64K on ARM) and object size is small > then don't waste lots of memory by rounding up to page size. > Instead, round up so that 1 or more objects all fit in a page. > > This preserves the requirement that an object must

[dpdk-dev] [PATCH v2 1/2] ethdev: add buffered tx api

2016-03-09 Thread Kulasek, TomaszX
> -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Wednesday, March 9, 2016 18:07 > To: Kulasek, TomaszX > Cc: dev at dpdk.org; Ananyev, Konstantin > Subject: Re: [dpdk-dev] [PATCH v2 1/2] ethdev: add buffered tx api > > 2016-03-09 16:35, Kulasek

[dpdk-dev] don't use printf!

2016-03-09 Thread Stephen Hemminger
One thing I noticed while fixing mempool bug, was that there was a printf in the library there. A reminder, code in DPDK library should never call printf directly. printf in a real application is often ratholed off to /dev/null and real output is through API's or syslog. Offenders now: rte_mempoo

[dpdk-dev] [PATCH] pcap: fix captured frame length

2016-03-09 Thread Bruce Richardson
On Thu, Jan 28, 2016 at 06:14:45PM +, Nicolas Pernas Maradei wrote: > Hi Dror, > > Good catch. What you are saying makes sense and it is also explained in > pcap's documentation. Was your setup unusual though? > This might sound like a silly question but I don't remember seeing that > issue an

[dpdk-dev] [RFC 35/35] mempool: update copyright

2016-03-09 Thread Stephen Hemminger
I understand that 6Wind has made major contributions to DPDK in many places. I would prefer that each file not get copyright additions from each contributor, otherwise this starts a bad precedent where the source gets cluttered with every contributor. On Wed, Mar 9, 2016 at 8:19 AM, Olivier Matz

[dpdk-dev] [RFC 10/35] eal: introduce RTE_DECONST macro

2016-03-09 Thread Stephen Hemminger
Can't we just write correct code rather than trying to trick the compiler. On Wed, Mar 9, 2016 at 8:19 AM, Olivier Matz wrote: > This macro removes the const attribute of a variable. It must be used > with care in specific situations. It's better to use this macro instead > of a manual cast, as

[dpdk-dev] [PATCH] eal: add option --avail-cores to detect lcores

2016-03-09 Thread Ananyev, Konstantin
> On 3/8/2016 4:54 PM, Panu Matilainen wrote: > > On 03/04/2016 12:05 PM, Jianfeng Tan wrote: > >> This patch adds option, --avail-cores, to use lcores which are > >> available > >> by calling pthread_getaffinity_np() to narrow down detected cores > >>

[dpdk-dev] [RFC 10/35] eal: introduce RTE_DECONST macro

2016-03-09 Thread Olivier MATZ
Hi, On 03/09/2016 07:53 PM, Stephen Hemminger wrote: > Can't we just write correct code rather than trying to trick the compiler. Thank you for your comment. This macro is introduced for next commit, I would be happy if you could help me to remove it. My opinion is that using a macro like this i

[dpdk-dev] [PATCH v9 0/4] ethdev: add speed capabilities and refactor link API

2016-03-09 Thread Marc
On 9 March 2016 at 11:09, N?lio Laranjeiro wrote: > On Wed, Mar 09, 2016 at 10:29:38AM +0100, N?lio Laranjeiro wrote: > > On Tue, Mar 08, 2016 at 05:53:05PM +0100, N?lio Laranjeiro wrote: > > > On Tue, Mar 08, 2016 at 04:00:29PM +0100, Marc Sune wrote: > > > > 2016-03-01 1:45 GMT+01:00 Marc Sune

[dpdk-dev] [RFC 10/35] eal: introduce RTE_DECONST macro

2016-03-09 Thread Stephen Hemminger
On Wed, 9 Mar 2016 21:47:35 +0100 Olivier MATZ wrote: > Hi, > > On 03/09/2016 07:53 PM, Stephen Hemminger wrote: > > Can't we just write correct code rather than trying to trick the compiler. > > Thank you for your comment. This macro is introduced for next > commit, I would be happy if you cou

[dpdk-dev] [PATCH, v2] mempool: avoid memory waste with large pagesize

2016-03-09 Thread Stephen Hemminger
If page size is large (like 64K on ARM) and object size is small then don't waste lots of memory by rounding up to page size. Instead, round up so that 1 or more objects all fit in a page. This preserves the requirement that an object must not a page or virt2phys would break, and makes sure 62K is

[dpdk-dev] [RFC 10/35] eal: introduce RTE_DECONST macro

2016-03-09 Thread Bruce Richardson
On Wed, Mar 09, 2016 at 09:47:35PM +0100, Olivier MATZ wrote: > Hi, > > On 03/09/2016 07:53 PM, Stephen Hemminger wrote: > > Can't we just write correct code rather than trying to trick the compiler. > > Thank you for your comment. This macro is introduced for next > commit, I would be happy if y

[dpdk-dev] [PATCH] hash: fix memcmp function pointer in multi-process environment

2016-03-09 Thread Dhananjaya Reddy Eadala
Hi Michael If you agree on the #ifdef protection I explained in my previous mail, I will re-submit the patch with refactoring the the commit log with less than 80 characters per line. Thanks Dhana On Thu, Mar 3, 2016 at 8:00 PM, Dhananjaya Reddy Eadala wrote: > Hi Michael > > Please see my an

[dpdk-dev] [PATCH] virtio: fix rx ring descriptor starvation

2016-03-09 Thread Bruce Richardson
On Fri, Mar 04, 2016 at 08:25:07AM -0500, Kyle Larose wrote: > On Fri, Mar 4, 2016 at 3:11 AM, Tom Kiely wrote: > > Sure. > >Tom > > > > > > On 03/04/2016 06:16 AM, Xie, Huawei wrote: > >> > >> On 2/23/2016 12:23 AM, Tom Kiely wrote: > >>> > >>> Hi, > >>> Sorry I missed the last few messa

[dpdk-dev] [PATCH] i40e: remove redundant compiler warning disablers

2016-03-09 Thread Bruce Richardson
On Mon, Feb 29, 2016 at 05:51:23AM +, Pei, Yulong wrote: > This patch caused build error with i686-native-linuxapp-gcc (gcc version is > 4.8.3) > Yes. It also breaks the build with gcc 4.4 (strict aliasing rules errors). There are probably some combination of flags can we can remove, but t

[dpdk-dev] [PATCH v5 0/2] Increased number of next hops for LPM IPv4.

2016-03-09 Thread Thomas Monjalon
2016-03-09 17:57, Michal Jastrzebski: > From: Michal Kobylinski > > This patchset extend next_hop field from 8-bits to 24-bits in LPM library for > IPv4. > > As next_hop field is increased now the maximum number of tbl8s is 2^24. > A new rte_lpm_config structure is used so LPM library will all

[dpdk-dev] [PATCH v5 6/6] virtio: return 1 to tell the upper layer we don't take over this device

2016-03-09 Thread Thomas Monjalon
2016-03-08 23:33, Huawei Xie: > PMD_INIT_LOG(INFO, "trying with legacy virtio pci."); > - if (legacy_virtio_resource_init(dev, hw) < 0) > + if (legacy_virtio_resource_init(dev, hw) < 0) { > + if (dev->kdrv == RTE_KDRV_UNKNOWN && > + dev->devargs->type != RT

[dpdk-dev] [PATCH] example/ipsec-secgw: ipsec security gateway

2016-03-09 Thread Sergio Gonzalez Monroy
On 01/02/2016 11:26, Jerin Jacob wrote: > On Mon, Feb 01, 2016 at 11:09:16AM +, Sergio Gonzalez Monroy wrote: >> On 31/01/2016 14:39, Jerin Jacob wrote: >>> On Fri, Jan 29, 2016 at 08:29:12PM +, Sergio Gonzalez Monroy wrote: >>> >>> IMO, an option for single SA based outbound processing wo

<    1   2   3