Hi Thomas,
Marvin has already tested the patches with a recent HEAD release of DPDK and
are ready to test them as part of RC2. As you say the changes are localized to
the Intel drivers and from our review they look like low risk of breaking
anything else.
Thanks
Waterman
-Original Message
On 10/30/2015 2:52 PM, Jianfeng Tan wrote:
> This patch fixes a bug under lower version linux kernel, mmap() fails when
Since which version Linux hugetlbfs changes the requirement of size
alignment?
> length is not aligned with hugepage size.
>
> Signed-off-by: Jianfeng Tan
> ---
> lib/librte_vho
This fixes the issue of not freeing memzone in a call to free the
memory for adminq DMA.
Fixes: 4861cde46116 ("i40e: new poll mode driver")
Signed-off-by: Helin Zhang
---
doc/guides/rel_notes/release_2_2.rst | 5 +
drivers/net/i40e/base/i40e_osdep.h | 2 +-
drivers/net/i40e/i40e_ethdev.
It fixes compile issues for i40e, and testpmd on ICC 13.0.0.
v2 changes:
Corrected the variable/function type, to replace casting.
v3 changes:
Added 'Fixes' line in the commit logs.
Helin Zhang (2):
i40e: fix ICC compile issue
app/testpmd: fix ICC compile issue
app/test-pmd/cmdline.c
It fixes compile issue on ICC 13.0.0.
Error logs:
i40e_ethdev.c(7943): error #188: enumerated type mixed with another type
PMD_INIT_LOG(ERR,
Fixes: c8b9a3e3fe1b ("i40e: support DCB mode")
Signed-off-by: Helin Zhang
---
drivers/net/i40e/i40e_ethdev.c | 34 +++---
It fixes compile issue on ICC 13.0.0.
Error logs:
app/test-pmd/cmdline.c(8160): error #188: enumerated type mixed
with another type
entry.input.flow.tunnel_flow.tunnel_type =
str2fdir_tunneltype(res->tunnel_type);
Fixes: 53b2bb9b7ea7 ("app/testpmd: new flow director commands")
Signed
Adds virtio offload support in us-vhost.
The patch set adds the negotiation support between us-vhost and vanilla Linux
virtio guest for TX offload(checksum and TSO), and add the offload support in
the vhost libs and change vhost sample to test these changes.
v4 change:
remove virtio-net chang
The virtual address for virtio net header need to be recorded.
Signed-off-by: Jijiang Liu
---
drivers/net/virtio/virtqueue.h |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/net/virtio/virtqueue.h b/drivers/net/virtio/virtqueue.h
index 689c321..5b43eeb 100644
---
Record virtual address of virtio net header.
Signed-off-by: Jijiang Liu
---
drivers/net/virtio/virtio_ethdev.c |3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/drivers/net/virtio/virtio_ethdev.c
b/drivers/net/virtio/virtio_ethdev.c
index 74c00ee..dd39715 100644
--- a/d
Dequeue vhost TX offload(CSUM and TSO) in vhost lib
Signed-off-by: Jijiang Liu
---
lib/librte_vhost/vhost_rxtx.c | 104 -
1 files changed, 103 insertions(+), 1 deletions(-)
diff --git a/lib/librte_vhost/vhost_rxtx.c b/lib/librte_vhost/vhost_rxtx.c
index
Remove the ip_hdr structure defination.
Signed-off-by: Jijiang Liu
---
examples/vhost/main.c | 15 +--
1 files changed, 1 insertions(+), 14 deletions(-)
diff --git a/examples/vhost/main.c b/examples/vhost/main.c
index c081b18..044c680 100644
--- a/examples/vhost/main.c
+++ b/examp
Change the vhost sample to support and test TX offload.
Signed-off-by: Jijiang Liu
---
examples/vhost/main.c | 110 +++-
1 files changed, 107 insertions(+), 3 deletions(-)
diff --git a/examples/vhost/main.c b/examples/vhost/main.c
index 044c680..24e2
Add virtio guest offload capabilities.
Signed-off-by: Jijiang Liu
---
lib/librte_vhost/virtio-net.c |5 -
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/lib/librte_vhost/virtio-net.c b/lib/librte_vhost/virtio-net.c
index 81bd309..839a333 100644
--- a/lib/librte_vhost/virt
Add vhost TX offload(CSUM and TSO) support capabilities.
Signed-off-by: Jijiang Liu
---
lib/librte_vhost/virtio-net.c |6 +-
1 files changed, 5 insertions(+), 1 deletions(-)
diff --git a/lib/librte_vhost/virtio-net.c b/lib/librte_vhost/virtio-net.c
index 14278de..81bd309 100644
--- a/li
Enqueue guest offload(CSUM and TSO) handle.
Signed-off-by: Jijiang Liu
---
lib/librte_vhost/vhost_rxtx.c | 45 +++-
1 files changed, 43 insertions(+), 2 deletions(-)
diff --git a/lib/librte_vhost/vhost_rxtx.c b/lib/librte_vhost/vhost_rxtx.c
index 9e70990..4
Hi Zhongliang,
After looked at the log messages, I think the problem is that VF is reset by PF.
For there's a feature named "malicious driver detection". It means the HW will
check if there's malicious behavior on VF. If so, VF will be reset. For there's
many reasons, for example, the packet leng
> -Original Message-
> From: Yuanhan Liu [mailto:yuanhan.liu at linux.intel.com]
> Sent: Monday, November 09, 2015 12:17 PM
> To: Liu, Jijiang
> Cc: dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v3 8/8] examples/vhost:support TX offload in
> vhost sample
>
> On Wed, Nov 04, 2015 at 06
Tested-by: Min Cao
- OS/Kernel: Fedora 21/ 3.17.4-301
- GCC: gcc (GCC) 4.9.2 20150212 (Red Hat 4.9.2-6)
- CPU: Intel(R) Xeon(R) CPU E5-2658 0 @ 2.10GHz
- NIC: Intel Corporation 82599ES 10-Gigabit SFI/SFP+ Network Connection (rev 01)
- Total 3 cases, 3 passed, 0 failed.
Test Case 1: Disable/Ena
Problem:if I firstly insert my kmod_test.ko, then insert eventfd_link.ko,
error will happen with hint " Device or resource busy". This is because
the default minor device number, 0, has been occupied by my kmod_test.ko .
root at distro:~/test$ lsmod
Module Size Used by
kmod_test
Acked-by: Yuanhan Liu
--yliu
On Wed, Nov 11, 2015 at 02:57:23PM +0800, Xiaobo Chi wrote:
> Problem:if I firstly insert my kmod_test.ko, then insert eventfd_link.ko,
> error will happen with hint " Device or resource busy". This is because
> the default minor device number, 0, has been occ
On 09/24/2015 01:23 PM, Neil Horman wrote:
> On Thu, Sep 24, 2015 at 10:50:56AM +0300, Panu Matilainen wrote:
>> For giggles, tried running abi-validator between 2.0 and 2.1 on
>> my Fedora 22 laptop, didn't work due to various build failures.
>> With this patch series the following now succeeds:
>
Dear DPDK experts.
Thank you very much for your best great efforts and precious answers.
I have a question about execution option for load balancer in
~/dpdk/examples/load_balancer/
How can I run load balancer to configure the figure 18.5 in the
http://dpdk.org/doc/guides/sample_app_ug/load_
> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Helin Zhang
> Sent: Wednesday, November 11, 2015 6:11 AM
> To: dev at dpdk.org
> Subject: [dpdk-dev] [PATCH v3 0/2] fix compile issues on ICC
>
> It fixes compile issues for i40e, and testpmd on ICC 13.0.0.
>
Regarding to your patch title, there are two minor pits:
- the prefix should be "vhost" but not "virtio/lib".
- you should add an extra space after ":"
On Wed, Nov 11, 2015 at 02:40:46PM +0800, Jijiang Liu wrote:
> Enqueue guest offload(CSUM and TSO) handle.
(ALL) Your patch lacks some explanat
On Wed, Nov 11, 2015 at 02:40:41PM +0800, Jijiang Liu wrote:
> Add vhost TX offload(CSUM and TSO) support capabilities.
Claiming first that we support something, and then actually implementing
in a later patch is wrong, as at this stage, we actually does not support
that, hence, the functionality
On Wed, Nov 11, 2015 at 02:40:45PM +0800, Jijiang Liu wrote:
> Add virtio guest offload capabilities.
>
> Signed-off-by: Jijiang Liu
> ---
> lib/librte_vhost/virtio-net.c |5 -
> 1 files changed, 4 insertions(+), 1 deletions(-)
>
> diff --git a/lib/librte_vhost/virtio-net.c b/lib/librte
On Wed, Nov 11, 2015 at 02:40:43PM +0800, Jijiang Liu wrote:
> Remove the ip_hdr structure defination.
Even for such simple patch, you need state why. Stating that
"remove ip_hdr structure defination because we already have
that in rte_ip.h" will definitely let others to accept your
patch eaiser.
> -Original Message-
> From: Yuanhan Liu [mailto:yuanhan.liu at linux.intel.com]
> Sent: Wednesday, November 11, 2015 4:31 PM
> To: Liu, Jijiang; Michael S. Tsirkin
> Cc: dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v4 7/8] virtio/lib:add virtio guest offload
> capabilities
>
> On We
On Wed, Nov 11, 2015 at 08:38:29AM +, Liu, Jijiang wrote:
>
>
> > -Original Message-
> > From: Yuanhan Liu [mailto:yuanhan.liu at linux.intel.com]
> > Sent: Wednesday, November 11, 2015 4:31 PM
> > To: Liu, Jijiang; Michael S. Tsirkin
> > Cc: dev at dpdk.org
> > Subject: Re: [dpdk-dev
> -Original Message-
> From: Yuanhan Liu [mailto:yuanhan.liu at linux.intel.com]
> Sent: Wednesday, November 11, 2015 4:44 PM
> To: Liu, Jijiang
> Cc: Michael S. Tsirkin; dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v4 7/8] virtio/lib:add virtio guest offload
> capabilities
>
> On We
It fixes the issue of cannot using more than 1 poor for VMDq,
according to the queues left.
Fixes: 705b57f82054 ("i40e: enlarge the number of supported queues")
Signed-off-by: Helin Zhang
---
drivers/net/i40e/i40e_ethdev.c | 36 ++--
1 file changed, 26 insertions
Frank,
Thanks
Qian
-Original Message-
From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Liu, Jijiang
Sent: Wednesday, November 11, 2015 4:53 PM
To: Yuanhan Liu
Cc: dev at dpdk.org; Michael S. Tsirkin
Subject: Re: [dpdk-dev] [PATCH v4 7/8] virtio/lib:add virtio guest offload
capabili
On 10/11/2015 14:02, Thomas Monjalon wrote:
> Why ptr_timer is unused?
Use as rte_timer callback requires the parameter be present, but
responsibility for setting this up is delegated to the application.
..Remy
2015-11-11 16:34, Yuanhan Liu:
> On Wed, Nov 11, 2015 at 02:40:43PM +0800, Jijiang Liu wrote:
> > Remove the ip_hdr structure defination.
>
> Even for such simple patch, you need state why. Stating that
> "remove ip_hdr structure defination because we already have
> that in rte_ip.h" will definite
2015-11-11 08:53, Liu, Jijiang:
> From: Yuanhan Liu [mailto:yuanhan.liu at linux.intel.com]
> > On Wed, Nov 11, 2015 at 08:38:29AM +, Liu, Jijiang wrote:
> > > According to virtio standard, those fileds should be set.
> >
> > If so, you'd better quote them here, or even to your patch commit.
>
Comments on the git message:
After the word "fix" in the title, the word "issue" is useless.
It's better to have a short title, easy to parse in the commit list.
What is a poor? Do you mean pool?
2015-11-11 16:56, Helin Zhang:
> It fixes the issue of cannot using more than 1 poor for VMDq,
> acc
2015-11-11 09:07, Panu Matilainen:
> On 09/24/2015 01:23 PM, Neil Horman wrote:
> > On Thu, Sep 24, 2015 at 10:50:56AM +0300, Panu Matilainen wrote:
> >> For giggles, tried running abi-validator between 2.0 and 2.1 on
> >> my Fedora 22 laptop, didn't work due to various build failures.
> >> With th
Yuanhan,
You deserve a "review award"!
Thanks a lot
2015-11-11 16:23, Yuanhan Liu:
> Regarding to your patch title, there are two minor pits:
>
> - the prefix should be "vhost" but not "virtio/lib".
>
> - you should add an extra space after ":"
>
> On Wed, Nov 11, 2015 at 02:40:46PM +0800, Jiji
On 11/11/2015 12:16 PM, Thomas Monjalon wrote:
> 2015-11-11 09:07, Panu Matilainen:
>> On 09/24/2015 01:23 PM, Neil Horman wrote:
>>> On Thu, Sep 24, 2015 at 10:50:56AM +0300, Panu Matilainen wrote:
For giggles, tried running abi-validator between 2.0 and 2.1 on
my Fedora 22 laptop, didn'
> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Thomas Monjalon
> Sent: Tuesday, November 10, 2015 11:26 AM
> To: Mrzyglod, DanielX T
> Cc: dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v5 2/7] net: Add common PTP structures and
> functions
>
> 2015-11-05
On Tue, Nov 10, 2015 at 11:25:39PM +, Arevalo, Mario Alfredo C wrote:
> Hi Aaron,
>
>
> I have been working on series of patches in order to improve
> the installation process of dpdk, I sent my first version at
> sep 18.
>
> http://dpdk.org/ml/archives/dev/2015-September/023761.html
>
>
On Tue, Nov 10, 2015 at 06:12:28PM +0100, Adrien Mazarguil wrote:
> On Tue, Nov 10, 2015 at 04:21:10PM +, Richardson, Bruce wrote:
> >
> >
> > > -Original Message-
> > > From: Adrien Mazarguil [mailto:adrien.mazarguil at 6wind.com]
> > > Sent: Tuesday, November 10, 2015 4:08 PM
> > >
On Tue, Nov 10, 2015 at 11:32:57PM -0200, Victor Detoni wrote:
> Hi,
>
> is there some way to pin what port I want to use? For example, eth0 is my
> port 1 and eth1 is my port 0?
>
> Thanks
> Victor
Hi Victor,
the ports will always be in pci address order inside DPDK, since the port
numbers
ar
Hi Qian,
>
> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Liu, Jijiang
> Sent: Wednesday, November 11, 2015 4:53 PM
> To: Yuanhan Liu
> Cc: dev at dpdk.org; Michael S. Tsirkin
> Subject: Re: [dpdk-dev] [PATCH v4 7/8] virtio/lib:add virtio guest offload
> c
2015-11-11 10:45, Mcnamara, John:
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Thomas Monjalon
> > The library librte_net gather some structures and functions for network
> > headers/layers parsing.
> > These PTP functions looks really generic. Why not add them in EAL?
> > Maybe they c
On Wed, Nov 11, 2015 at 08:53:08AM +, Liu, Jijiang wrote:
...
> > If so, you'd better quote them here, or even to your patch commit.
>
> In the Virtual I/O Device (VIRTIO) Version 1.0 Committee Specification 02,
>
> (1) VIRTIO_NET_F_GUEST_CSUM (1) Driver handles packets with partial checksum
It is probably the usual MS operation issues, I'll resubmit.
-Original Message-
From: Stephen Hemminger [mailto:step...@networkplumber.org]
Sent: Tuesday, November 10, 2015 9:03 AM
To: Polehn, Mike A
Cc: dev at dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] ethdev: Prefetch driver variable s
Adds ethdev driver prefetch of variable structure to CPU cache 0
while calling into tx or rx device driver operation.
RFC 2544 test of NIC task test measurement points show improvement
of lower latency and/or better packet throughput indicating clock
cycles saved.
Signed-off-by: Mike A. Polehn
-
Hi,
Is there a way to permanently (i.e., have the configuration automatically
applied after reboot) bind a NIC port to DPDK?
In case there's none, I'm thinking to save in my software a list of the NIC
ports chosen by the user for use with DPDK and then, upon software startup to
just do
for
In general, try not to introduce new thinks and avoid extra code.
Also Linux has more robust mechanism in the watchdog timers, why not use that?
Could you use RTE_PER_LCORE some how?
> +#ifdef KEEPALIVE_DEBUG_MSGS
Any #ifdef must have a config option to enable it.
> +static void
> +print_tra
On Wed, Nov 11, 2015 at 04:13:01PM +, Montorsi, Francesco wrote:
> Hi,
> Is there a way to permanently (i.e., have the configuration automatically
> applied after reboot) bind a NIC port to DPDK?
>
> In case there's none, I'm thinking to save in my software a list of the NIC
> ports chosen b
Hi Bruce,
> -Original Message-
> From: Bruce Richardson [mailto:bruce.richardson at intel.com]
> I'm not aware of any way to make the bindings permanent across reboots.
> What you have suggested will work, but there are probably better ways to
> do the same thing.
I agree... let's see if
On Wed, 11 Nov 2015 16:59:14 +
"Montorsi, Francesco" wrote:
> Hi Bruce,
>
> > -Original Message-
> > From: Bruce Richardson [mailto:bruce.richardson at intel.com]
> > I'm not aware of any way to make the bindings permanent across reboots.
> > What you have suggested will work, but th
On Wed, 11 Nov 2015 16:26:57 +0800
Yuanhan Liu wrote:
> On Wed, Nov 11, 2015 at 02:40:41PM +0800, Jijiang Liu wrote:
> > Add vhost TX offload(CSUM and TSO) support capabilities.
>
> Claiming first that we support something, and then actually implementing
> in a later patch is wrong, as at this s
Hi Bruce,
First thank you for your help during this time, and you are right, the
objective of this is try to have a more standard installation process, I have
taken a look to your patches, and you rename targets as first step in order to
improve the installation process, I have the same
2015-11-11 13:28, Helin Zhang:
> This fixes the issue of not freeing memzone in a call to free the
> memory for adminq DMA.
>
> Fixes: 4861cde46116 ("i40e: new poll mode driver")
>
> Signed-off-by: Helin Zhang
Applied, thanks
> > It fixes compile issues for i40e, and testpmd on ICC 13.0.0.
> >
> > v2 changes:
> > Corrected the variable/function type, to replace casting.
> >
> > v3 changes:
> > Added 'Fixes' line in the commit logs.
> >
> > Helin Zhang (2):
> > i40e: fix ICC compile issue
> > app/testpmd: fix ICC
2015-11-11 16:56, Helin Zhang:
> It fixes the issue of cannot using more than 1 poor for VMDq,
> according to the queues left.
>
> Fixes: 705b57f82054 ("i40e: enlarge the number of supported queues")
>
> Signed-off-by: Helin Zhang
Applied, thanks
In my development environment I set up an at-boot provisioning script that
does it. I recommend using scripts and not shelling out from C code. ;)
On Wed, Nov 11, 2015 at 04:13:01PM +, Montorsi, Francesco wrote:
> Hi,
> Is there a way to permanently (i.e., have the configuration automatically
59 matches
Mail list logo
