[dpdk-dev] [PATCH v6] Add toeplitz hash algorithm used by RSS

2015-06-30 Thread Vladimir Medvedkin
Software implementation of the Toeplitz hash function used by RSS. Can be used either for packet distribution on single queue NIC or for simulating of RSS computation on specific NIC (for example after GRE header decapsulating). v6 changes - Fix compilation error - Rename some defines and function

[dpdk-dev] [PATCH v4] Add unit test for thash library

2015-06-30 Thread Vladimir Medvedkin
Add unit test for thash library v4 changes - Reflect rte_thash.h changes v3 changes - Fix checkpatch errors v2 changes - fix typo - remove unnecessary comments Signed-off-by: Vladimir Medvedkin --- app/test/Makefile | 1 + app/test/test_thash.c | 176

[dpdk-dev] dpdk-2.0.0: crash in ixgbe_recv_scattered_pkts_vec->_recv_raw_pkts_vec->desc_to_olflags_v

2015-06-30 Thread Gopakumar Choorakkot Edakkunni
So update on this. Summary is that its purely my fault, apologies for prematurely suspecting the wrong areas. Details below 1. So my AWS box had an eth0 interface without DPDK, I enabled dpdk AND created a KNI interface also AND named the KNI interface to be eth0 2. So Ubuntu started its dhcpclie

[dpdk-dev] RTM instruction compile failure for XABORT when AVX is active

2015-06-30 Thread Matthew Hall
On Jun 29, 2015, at 3:19 AM, Thomas Monjalon wrote: > There is no such bug with my compiler: > clang version 3.6.1 (tags/RELEASE_361/final) > Target: x86_64-unknown-linux-gnu > > Matthew, which version are you using? Hi Thomas and Roman, It seems to happen if I have set -mavx in C

[dpdk-dev] RTM instruction compile failure for XABORT when AVX is active

2015-06-30 Thread Matthew Hall
To be a bit more specific, this is what I had to do to fix it for clang 3.6 SVN snapshot release. I am not sure if there is a better way of handling this situation. I'd love to know where I could improve it. Matthew. diff --git a/mk/rte.cpuflags.mk b/mk/rte.cpuflags.mk index f595cd0..8c883ee 1

[dpdk-dev] RTM instruction compile failure for XABORT when AVX is active

2015-06-30 Thread Matthew Hall
With those two items commented out, and these CFLAGS: "-g -O0 -fPIC -msse4.2" it looks like I can reproduce the issue in clang 2.6 series: /vagrant/external/dpdk/build/include/rte_rtm.h:56:15: error: invalid operand for inline asm constraint 'i' asm volatile(".byte 0xc6,0xf8,%P0" :: "i"

[dpdk-dev] rte_lpm4 with expanded next hop support now available

2015-06-30 Thread Matthew Hall
Hello, Based on the wonderful assistance from Vladimir and Stephen and a close friend of mine that is a hypervisor developer who helped me reverse engineer and rewrite rte_lpm_lookupx4, I have got a known-working version of rte_lpm4 with expanded 24 bit next hop support available here: https:/

[dpdk-dev] Could not achieve wire speed for 40GE with any DPDK version on XL710 NIC's

2015-06-30 Thread Keunhong Lee
I have not used XL710 or i40e. I have no opinion for those NICs. Keunhong. 2015-06-29 15:59 GMT+09:00 Pavel Odintsov : > Hello! > > Lee, thank you so much for sharing your experience! What do you think > about 40GE version of 82599? > > On Mon, Jun 29, 2015 at 2:35 AM, Keunhong Lee wrote: > > D

[dpdk-dev] Receiving packets on only one port

2015-06-30 Thread Keunhong Lee
Actually I have no idea why this happens. If your switch configuration is correct, your program should work just like Wireshark does. I wander whether your program uses RSS. In my opinion, program bug is the most probable reason. Keunhong. 2015-06-29 23:32 GMT+09:00 Daeyoung Kim : > Hi Keunhong

[dpdk-dev] Receiving packets on only one port

2015-06-30 Thread Keunhong Lee
Check that whether you are polling all RX queues of your program. You said that your configuration works well with Wireshark. So I don't think that this is the problem. You can check your port statistics for the number of received packets. If the statistics show 2 packets, but you received 1 packe

[dpdk-dev] [PATCH v3 3/9] cxgbe: add device configuration and RX support for cxgbe PMD.

2015-06-30 Thread Rahul Lakkireddy
On Sun, Jun 28, 2015 at 21:34:28 +0200, Thomas Monjalon wrote: > 2015-06-18 17:47, Rahul Lakkireddy: > > Adds RX support for the cxgbe poll mode driver. This patch: > > > > 1. Adds rx queue related eth_dev_ops. > > 2. Adds RSS support. > > 3. Adds dev_configure() and dev_infos_get() eth_dev_ops.

[dpdk-dev] [PATCH v3 2/9] cxgbe: add cxgbe poll mode driver.

2015-06-30 Thread Rahul Lakkireddy
Hi Thomas, On Sun, Jun 28, 2015 at 21:32:32 +0200, Thomas Monjalon wrote: > 2015-06-18 17:47, Rahul Lakkireddy: > > +Chelsio cxgbe > > +M: Rahul Lakkireddy > > +F: drivers/net/cxgbe/ > > +F: doc/guides/nics/cxgbe.rst > > Just a detail: the doc file is added in a later patch. > For consistency, t

[dpdk-dev] [PATCH v4 0/9] Chelsio Terminator 5 (T5) 10G/40G Poll Mode Driver

2015-06-30 Thread Rahul Lakkireddy
This series of patches add the CXGBE Poll Mode Driver support for Chelsio Terminator 5 series of 10G/40G adapters. The CXGBE PMD is split into multiple patches. The first patch adds the hardware specific api for all supported Chelsio T5 adapters and the patches from 2 to 8 add the actual DPDK CXG

[dpdk-dev] [PATCH v4 1/9] cxgbe: add hardware specific api for all supported Chelsio T5 series adapters.

2015-06-30 Thread Rahul Lakkireddy
Adds hardware specific api for all the Chelsio T5 adapters under drivers/net/cxgbe/base directory. Signed-off-by: Rahul Lakkireddy Signed-off-by: Kumar Sanghvi --- v4: - No changes v3: - No changes v2: - Move files to new directory under drivers/net/cxgbe/base and update commit log. - Few bu

[dpdk-dev] [PATCH v4 2/9] cxgbe: add cxgbe poll mode driver.

2015-06-30 Thread Rahul Lakkireddy
Adds cxgbe poll mode driver for DPDK under drivers/net/cxgbe directory. This patch: 1. Adds the Makefile to compile cxgbe pmd. 2. Registers and initializes the cxgbe pmd driver. Enable cxgbe PMD for compilation and linking with changes to: 1. config/common_linuxapp to add macros for cxgbe pmd. 2.

[dpdk-dev] [PATCH v4 3/9] cxgbe: add device configuration and RX support for cxgbe PMD.

2015-06-30 Thread Rahul Lakkireddy
Adds RX support for the cxgbe poll mode driver. This patch: 1. Adds rx queue related eth_dev_ops. 2. Adds RSS support. 3. Adds dev_configure() and dev_infos_get() eth_dev_ops. 4. Adds rx_pkt_burst for receiving packets. Signed-off-by: Rahul Lakkireddy Signed-off-by: Kumar Sanghvi --- v4: - Fix

[dpdk-dev] [PATCH v4 4/9] cxgbe: add TX support for cxgbe PMD.

2015-06-30 Thread Rahul Lakkireddy
Adds TX support for the cxgbe poll mode driver. This patch: 1. Adds tx queue related eth_dev_ops. 2. Adds tx_pkt_burst for transmitting packets. Signed-off-by: Rahul Lakkireddy Signed-off-by: Kumar Sanghvi --- v4: - Remove unused code to fix clang compilation. v3: - No changes. v2: - This pa

[dpdk-dev] [PATCH v4 5/9] cxgbe: add device related operations for cxgbe PMD.

2015-06-30 Thread Rahul Lakkireddy
Adds dev_start(), dev_stop(), and dev_close() eth_dev_ops for cxgbe poll mode driver. Signed-off-by: Rahul Lakkireddy Signed-off-by: Kumar Sanghvi --- v4: - No changes. v3: - No changes. v2: - This patch is a subset of patch 2/5 submitted in v1. - Few changes related to tx bug fixes. drivers

[dpdk-dev] [PATCH v4 6/9] cxgbe: add port statistics for cxgbe PMD.

2015-06-30 Thread Rahul Lakkireddy
Adds stats_get() and stats_reset() eth_dev_ops for cxgbe poll mode driver. Signed-off-by: Rahul Lakkireddy Signed-off-by: Kumar Sanghvi --- v4: - No changes. v3: - No changes. v2: - This patch is a subset of patch 2/5 submitted in v1. drivers/net/cxgbe/cxgbe.h| 2 + drivers/net/cxgb

[dpdk-dev] [PATCH v4 7/9] cxgbe: add link related functions for cxgbe PMD.

2015-06-30 Thread Rahul Lakkireddy
Adds link update, promiscuous and multicast related eth_dev_ops for cxgbe poll mode driver. Signed-off-by: Rahul Lakkireddy Signed-off-by: Kumar Sanghvi --- v4: - No changes. v3: - No changes. v2: - This patch is a subset of patch 2/5 submitted in v1. - Update cxgbe_dev_link_update() to return

[dpdk-dev] [PATCH v4 8/9] cxgbe: add flow control functions for cxgbe PMD.

2015-06-30 Thread Rahul Lakkireddy
Adds flow control related eth_dev_ops for cxgbe poll mode driver. Signed-off-by: Rahul Lakkireddy Signed-off-by: Kumar Sanghvi --- v4: - No changes. v3: - No changes. v2: - This patch is a subset of patch 2/5 submitted in v1. drivers/net/cxgbe/cxgbe_ethdev.c | 54

[dpdk-dev] [PATCH v4 9/9] doc: add cxgbe PMD documentation under doc/guides/nics/cxgbe.rst

2015-06-30 Thread Rahul Lakkireddy
Adds cxgbe poll mode driver documentation under the usual doc/guides/nics/ directory with the rest of the drivers. The documentation covers cxgbe implementation details, features and limitations, prerequisites, configuration, and a sample application usage. Signed-off-by: Rahul Lakkireddy Signed

[dpdk-dev] [PATCH v2] librte_ether: release memory in uninit function.

2015-06-30 Thread Qiu, Michael
On 6/30/2015 12:42 AM, Iremonger, Bernard wrote: > >> -Original Message- >> From: Qiu, Michael >> Sent: Monday, June 29, 2015 4:22 PM >> To: Iremonger, Bernard; dev at dpdk.org >> Cc: Zhang, Helin; Ananyev, Konstantin; mukawa at igel.co.jp; Stephen >> Hemminger >> Subject: Re: [PATCH v2] li

[dpdk-dev] Why pktgen-dpdk will receive more packet than sent

2015-06-30 Thread Jiang, Yunhong
Hi, all I'm trying to test the l2fwd throughput using https://github.com/pktgen/Pktgen-DPDK/blob/master/dpdk/examples/pktgen/scripts/rfc2544.lua . However, the pktgen will receive more packets than it sent out like " Total sent 14786446 recv 14786597, delta 151". I'm really confused why

[dpdk-dev] [PATCH v3 1/8] eal: Add pci_uio_alloc_uio_resource()

2015-06-30 Thread Tetsuya Mukawa
On 2015/06/29 22:24, Iremonger, Bernard wrote: > >> -Original Message- >> From: Tetsuya Mukawa [mailto:mukawa at igel.co.jp] >> Sent: Monday, June 29, 2015 3:57 AM >> To: dev at dpdk.org >> Cc: Iremonger, Bernard; david.marchand at 6wind.com; Tetsuya.Mukawa >> Subject: [PATCH v3 1/8] eal: A

[dpdk-dev] [PATCH v3 2/8] eal: Add pci_uio_map_uio_resource_by_index()

2015-06-30 Thread Tetsuya Mukawa
On 2015/06/29 22:36, Iremonger, Bernard wrote: > >> -Original Message- >> From: Tetsuya Mukawa [mailto:mukawa at igel.co.jp] >> Sent: Monday, June 29, 2015 3:57 AM >> To: dev at dpdk.org >> Cc: Iremonger, Bernard; david.marchand at 6wind.com; Tetsuya.Mukawa >> Subject: [PATCH v3 2/8] eal: A

[dpdk-dev] [PATCH v3 7/8] eal: Consolidate pci uio functions of linuxapp and bsdapp

2015-06-30 Thread Tetsuya Mukawa
On 2015/06/29 23:03, Iremonger, Bernard wrote: > >> -Original Message- >> From: Tetsuya Mukawa [mailto:mukawa at igel.co.jp] >> Sent: Monday, June 29, 2015 3:57 AM >> To: dev at dpdk.org >> Cc: Iremonger, Bernard; david.marchand at 6wind.com; Tetsuya.Mukawa >> Subject: [PATCH v3 7/8] eal: C

[dpdk-dev] Why pktgen-dpdk will receive more packet than sent

2015-06-30 Thread Wiles, Keith
On 6/29/15, 9:01 PM, "dev on behalf of Jiang, Yunhong" wrote: >Hi, all > I'm trying to test the l2fwd throughput using >https://github.com/pktgen/Pktgen-DPDK/blob/master/dpdk/examples/pktgen/scr >ipts/rfc2544.lua . However, the pktgen will receive more packets than it >sent out like " To

[dpdk-dev] [PATCH] fm10k: support XEN domain0

2015-06-30 Thread He, Shaopeng
Hi Thomas, Stephen, > -Original Message- > From: He, Shaopeng > Sent: Tuesday, June 23, 2015 9:21 AM > To: Thomas Monjalon > Cc: Liu, Jijiang; dev at dpdk.org; Stephen Hemminger > Subject: RE: [dpdk-dev] [PATCH] fm10k: support XEN domain0 > > Hi Thomas, > > > -Original Message- >

[dpdk-dev] [PATCH v3 1/2] vhost: vhost unix domain socket cleanup

2015-06-30 Thread Xie, Huawei
On 6/30/2015 5:04 AM, Thomas Monjalon wrote: > Huawei, > I don't understand this reply. You forgot quoting, you didn't remove useless > lines, > and you seem to reply to yourself. > Should this patch be applied? > Thomas: Oh, here i remove useless lines. I am sending a new patch to fix a potentia

[dpdk-dev] [PATCH v3 2/7] mbuf: use the reserved 16 bits for double vlan

2015-06-30 Thread Olivier MATZ
Hi, On 06/28/2015 10:36 PM, Thomas Monjalon wrote: > Neil, Olivier, > Your opinions are requested here. > Thanks > > 2015-06-25 08:31, Zhang, Helin: >> Hi Neil > [...] >>> -279,7 +285,7 @@ struct rte_mbuf { >>> uint16_t data_len;/**< Amount of data in segment buffer. */ >>> uint32_

[dpdk-dev] [PATCH v3 4/8] eal: Consolidate rte_eal_pci_probe/close_one_driver() of linuxapp and bsdapp

2015-06-30 Thread Tetsuya Mukawa
On 2015/06/30 0:28, Bruce Richardson wrote: > On Mon, Jun 29, 2015 at 11:56:46AM +0900, Tetsuya Mukawa wrote: >> From: "Tetsuya.Mukawa" >> >> This patch consolidates below functions, and implements these in common >> eal code. >> - rte_eal_pci_probe_one_driver() >> - rte_eal_pci_close_one_driver

[dpdk-dev] [PATCH v3 0/8] Add Port Hotplug support to BSD

2015-06-30 Thread Tetsuya Mukawa
On 2015/06/30 0:30, Bruce Richardson wrote: > On Mon, Jun 29, 2015 at 11:56:42AM +0900, Tetsuya Mukawa wrote: >> This patch series adds port hotplug support to BSD. >> Before applying, following patches should be applied. >> - [PATCH v6 1/5] eal: Fix coding style of eal_pci.c and eal_pci_uio.c >>

[dpdk-dev] [PATCH v7 00/12] Clean up pci uio implementations

2015-06-30 Thread Tetsuya Mukawa
Currently Linux implementation and BSD implementation have almost same code about pci uio. This patch series cleans up it. PATCH v7 changes: - Add below patches. Also, the order of patches are changed. - eal: Add pci_uio_alloc_resource() - eal: Add pci_uio_map_resource_by_index() - eal:

[dpdk-dev] [PATCH v7 01/12] eal: Fix coding style of eal_pci.c and eal_pci_uio.c

2015-06-30 Thread Tetsuya Mukawa
From: "Tetsuya.Mukawa" This patch fixes coding style of below files in linuxapp and bsdapp. - eal_pci.c - eal_pci_uio.c Signed-off-by: Tetsuya Mukawa Acked-by: Stephen Hemminger --- lib/librte_eal/bsdapp/eal/eal_pci.c | 12 +++- lib/librte_eal/linuxapp/eal/eal_pci_uio.c | 12 +

[dpdk-dev] [PATCH v7 02/12] eal: Close file descriptor of uio configuration

2015-06-30 Thread Tetsuya Mukawa
From: "Tetsuya.Mukawa" When pci_uio_unmap_resource() is called, a file descriptor that is used for uio configuration should be closed. Signed-off-by: Tetsuya Mukawa Acked-by: Stephen Hemminger --- lib/librte_eal/linuxapp/eal/eal_pci_uio.c | 6 +- 1 file changed, 5 insertions(+), 1 deletio

[dpdk-dev] [PATCH v7 03/12] eal: Fix memory leaks and needless increment of pci_map_addr

2015-06-30 Thread Tetsuya Mukawa
From: "Tetsuya.Mukawa" This patch fixes following memory leaks. - When open() is failed, uio_res and fds won't be freed in pci_uio_map_resource(). - When pci_map_resource() is failed but path is allocated correctly, path and fds won't be freed in pci_uio_map_recource(). Also, some mapped re

[dpdk-dev] [PATCH v7 04/12] eal/bsdapp: Change names of pci related data structure

2015-06-30 Thread Tetsuya Mukawa
From: "Tetsuya.Mukawa" To merge pci code of linuxapp and bsdapp, this patch changes names like below. - uio_map to pci_map - uio_resource to mapped_pci_resource - uio_res_list to mapped_pci_res_list Signed-off-by: Tetsuya Mukawa --- lib/librte_eal/bsdapp/eal/eal_pci.c | 24 -

[dpdk-dev] [PATCH v7 05/12] eal: Fix uio mapping differences between linuxapp and bsdapp

2015-06-30 Thread Tetsuya Mukawa
From: "Tetsuya.Mukawa" This patch fixes below. - bsdapp - Use map_id in pci_uio_map_resource(). - Fix interface of pci_map_resource(). - Move path variable of mapped_pci_resource structure to pci_map. - linuxapp - Remove redundant error message of linuxapp. 'pci_uio_map_resource()' is implem

[dpdk-dev] [PATCH v7 06/12] eal: Add pci_uio_alloc_resource()

2015-06-30 Thread Tetsuya Mukawa
From: "Tetsuya.Mukawa" This patch adds a new function called pci_uio_alloc_resource(). The function hides how to prepare uio resource in linuxapp and bsdapp. With the function, pci_uio_map_resource() will be more abstracted. Signed-off-by: Tetsuya Mukawa --- lib/librte_eal/bsdapp/eal/eal_pci.c

[dpdk-dev] [PATCH v7 07/12] eal: Add pci_uio_map_resource_by_index()

2015-06-30 Thread Tetsuya Mukawa
From: "Tetsuya.Mukawa" This patch adds a new function called pci_uio_map_resource_by_index(). The function hides how to map uio resource in linuxapp and bsdapp. With the function, pci_uio_map_resource() will be more abstracted. Signed-off-by: Tetsuya Mukawa --- lib/librte_eal/bsdapp/eal/eal_pc

[dpdk-dev] [PATCH v7 08/12] eal: Consolidate pci_map and mapped_pci_resource of linuxapp and bsdapp

2015-06-30 Thread Tetsuya Mukawa
From: "Tetsuya.Mukawa" This patch consolidates below structures, and defines them in common code. - struct pci_map - strucy mapped_pci_resouces Signed-off-by: Tetsuya Mukawa --- lib/librte_eal/bsdapp/eal/eal_pci.c| 24 lib/librte_eal/common/include/rte_pci.h

[dpdk-dev] [PATCH v7 09/12] eal: Consolidate pci_map/unmap_resource() of linuxapp and bsdapp

2015-06-30 Thread Tetsuya Mukawa
From: "Tetsuya.Mukawa" The patch consolidates below functions, and implemented in common eal code. - pci_map_resource() - pci_unmap_resource() Signed-off-by: Tetsuya Mukawa --- lib/librte_eal/bsdapp/eal/eal_pci.c| 22 lib/librte_eal/common/eal_common_pci.c | 39 +

[dpdk-dev] [PATCH v7 10/12] eal: Consolidate pci uio functions of linuxapp and bsdapp

2015-06-30 Thread Tetsuya Mukawa
From: "Tetsuya.Mukawa" The patch consolidates below functions, and implement these in eal_common_pci_uio.c. - pci_uio_map_secondary() - pci_uio_map_resource() - pci_uio_unmap() - pci_uio_find_resource() - pci_uio_unmap_resource() Signed-off-by: Tetsuya Mukawa --- lib/librte_eal/bsdapp/eal

[dpdk-dev] [PATCH v7 11/12] eal: Consolidate pci_map/unmap_device() of linuxapp and bsdapp

2015-06-30 Thread Tetsuya Mukawa
From: "Tetsuya.Mukawa" The patch consolidates below functions, and implemented in common eal code. - pci_map_device() - pci_unmap_device() Signed-off-by: Tetsuya Mukawa --- lib/librte_eal/bsdapp/eal/eal_pci.c | 3 ++ lib/librte_eal/common/eal_common_pci.c | 57 +

[dpdk-dev] [PATCH v7 12/12] eal: Consolidate rte_eal_pci_probe/close_one_driver() of linuxapp and bsdapp

2015-06-30 Thread Tetsuya Mukawa
From: "Tetsuya.Mukawa" This patch consolidates below functions, and implements these in common eal code. - rte_eal_pci_probe_one_driver() - rte_eal_pci_close_one_driver() Because pci_map_device() is only implemented in linuxapp, the patch implements it in bsdapp too. This implemented function

[dpdk-dev] [PATCH v4] Add Port Hotplug support to BSD

2015-06-30 Thread Tetsuya Mukawa
This patch adds port hotplug support to BSD. Before applying, following patches should be applied. - [PATCH v7 01/12] eal: Fix coding style of eal_pci.c and eal_pci_uio.c - [PATCH v7 02/12] eal: Close file descriptor of uio configuration - [PATCH v7 03/12] eal: Fix memory leaks and needless incr

[dpdk-dev] [PATCH v4] eal: Enable Port Hotplug as default in Linux and BSD

2015-06-30 Thread Tetsuya Mukawa
From: "Tetsuya.Mukawa" This patch removes CONFIG_RTE_LIBRTE_EAL_HOTPLUG option, and enables it as default in both Linux and BSD. Also, to support port hotplug, rte_eal_pci_scan() and below missing symbols should be exported to ethdev library. - rte_eal_parse_devargs_str() - rte_eal_pci_close_on

[dpdk-dev] [PATCH v3 7/8] eal: Consolidate pci uio functions of linuxapp and bsdapp

2015-06-30 Thread Tetsuya Mukawa
On 2015/06/30 11:43, Tetsuya Mukawa wrote: > On 2015/06/29 23:03, Iremonger, Bernard wrote: >>> -Original Message- >>> From: Tetsuya Mukawa [mailto:mukawa at igel.co.jp] >>> Sent: Monday, June 29, 2015 3:57 AM >>> To: dev at dpdk.org >>> Cc: Iremonger, Bernard; david.marchand at 6wind.com;

[dpdk-dev] [PATCH v8 03/18] mbuf: add definitions of unified packet types

2015-06-30 Thread Olivier MATZ
Hi Helin, This is greatly documented, thanks! Please find a small comment below. On 06/23/2015 03:50 AM, Helin Zhang wrote: > As there are only 6 bit flags in ol_flags for indicating packet > types, which is not enough to describe all the possible packet > types hardware can recognize. For exampl

[dpdk-dev] [PATCH v4 0/4] vhost: vhost unix domain socket cleanup

2015-06-30 Thread Huawei Xie
vhost user could register multiple unix domain socket server, and use the path to identify the virtio device connecting to it. rte_vhost_driver_unregister will clean up the unix domain socket for the specified path. v2 changes: -minor code style fix, remove unnecessary new line v3 changes: update

[dpdk-dev] [PATCH v4 1/4] vhost: call fdset_del_slot to remove connection fd

2015-06-30 Thread Huawei Xie
In the event handler of connection fd, the connection fd could be possibly closed. The event dispatch loop would then try to remove the fd from fdset. Between these two actions, another thread might register a new listenfd reusing the val of just closed fd, so we couldn't call fdset_del which would

[dpdk-dev] [PATCH v4 2/4] vhost: vhost unix domain socket cleanup

2015-06-30 Thread Huawei Xie
rte_vhost_driver_unregister API will remove the listenfd from event list, and then close it. v2 changes: -minor code style fix, remove unnecessary new line Signed-off-by: Huawei Xie Signed-off-by: Peng Sun --- lib/librte_vhost/rte_virtio_net.h| 3 ++ lib/librte_vhost/vhost_cuse/vh

[dpdk-dev] [PATCH v4 3/4] vhost: version map file update

2015-06-30 Thread Huawei Xie
update version map file for rte_vhost_driver_unregister API v3 changes: update version map file Signed-off-by: Huawei Xie --- lib/librte_vhost/rte_vhost_version.map | 8 1 file changed, 8 insertions(+) diff --git a/lib/librte_vhost/rte_vhost_version.map b/lib/librte_vhost/rte_vhost_v

[dpdk-dev] [PATCH v4 4/4] vhost: add comment for potential unwanted callback on listenfds

2015-06-30 Thread Huawei Xie
add comment for potential unwanted callback on listenfds v4 changes: add comment for potential unwanted callback on listenfds Signed-off-by: Huawei Xie --- lib/librte_vhost/vhost_user/fd_man.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/lib/librte_vhost/vhost_user/fd_man.c b/lib

[dpdk-dev] [PATCH v2 00/23] mlx4: MOFED 3.0 support, bugfixes and enhancements

2015-06-30 Thread Adrien Mazarguil
This patchset adds compatibility with the upcoming Mellanox OFED 3.0 release (new kernel drivers and userland support libraries), which supports new features such as L3/L4 checksum validation offloads and addresses several bugs and limitations at the same time. v2: - Bugfix for a possible crash w

[dpdk-dev] [PATCH v2 01/23] mlx4: fix possible crash on scattered mbuf allocation failure

2015-06-30 Thread Adrien Mazarguil
When failing to allocate a segment, mlx4_rx_burst_sp() may call rte_pktmbuf_free() on an incomplete scattered mbuf whose next pointer in the last segment is not set. Signed-off-by: Adrien Mazarguil --- drivers/net/mlx4/mlx4.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a

[dpdk-dev] [PATCH v2 02/23] mlx4: add MOFED 3.0 compatibility to interfaces names retrieval

2015-06-30 Thread Adrien Mazarguil
Since Mellanox OFED 3.0 and Linux 3.15, interface port numbers are stored in dev_port instead of dev_id sysfs files. Signed-off-by: Or Ami Signed-off-by: Nitzan Weller Signed-off-by: Adrien Mazarguil --- drivers/net/mlx4/mlx4.c | 51 + 1 file cha

[dpdk-dev] [PATCH v2 03/23] mlx4: make sure experimental device query function is implemented

2015-06-30 Thread Adrien Mazarguil
From: Olga Shern HAVE_EXP_QUERY_DEVICE is used to check whether ibv_exp_query_device() can be used. RSS and inline receive features depend on it. Signed-off-by: Olga Shern Signed-off-by: Adrien Mazarguil --- drivers/net/mlx4/Makefile | 4 drivers/net/mlx4/mlx4.c | 17 ++---

[dpdk-dev] [PATCH v2 04/23] mlx4: avoid looking up WR ID to improve RX performance

2015-06-30 Thread Adrien Mazarguil
From: Alex Rosenbaum This is done by storing the current index in the RX queue structure. Signed-off-by: Alex Rosenbaum Signed-off-by: Adrien Mazarguil --- drivers/net/mlx4/mlx4.c | 24 ++-- 1 file changed, 22 insertions(+), 2 deletions(-) diff --git a/drivers/net/mlx4/ml

[dpdk-dev] [PATCH v2 05/23] mlx4: merge RX queue setup functions

2015-06-30 Thread Adrien Mazarguil
From: Alex Rosenbaum Make rxq_setup_qp() handle inline support like rxq_setup_qp_rss() instead of having two separate functions. Signed-off-by: Alex Rosenbaum Signed-off-by: Adrien Mazarguil --- drivers/net/mlx4/mlx4.c | 61 - 1 file changed, 9

[dpdk-dev] [PATCH v2 06/23] mlx4: allow applications to partially use fork()

2015-06-30 Thread Adrien Mazarguil
From: Olga Shern Although using the PMD from a forked process is still unsupported, this commit makes Verbs safe enough for applications to call fork() for other purposes. Signed-off-by: Olga Shern Signed-off-by: Adrien Mazarguil --- drivers/net/mlx4/mlx4.c | 8 1 file changed, 8 ins

[dpdk-dev] [PATCH v2 07/23] mlx4: improve accuracy of link status information

2015-06-30 Thread Adrien Mazarguil
From: Olga Shern Query interface properties using the ethtool API instead of Verbs through ibv_query_port(). The returned information is more accurate for Ethernet links since several link speeds cannot be mapped to Verbs semantics. Signed-off-by: Olga Shern Signed-off-by: Alex Rosenbaum Signe

[dpdk-dev] [PATCH v2 08/23] mlx4: use MOFED 3.0 extended flow steering API

2015-06-30 Thread Adrien Mazarguil
From: Alex Rosenbaum This commit drops "exp" from related function and type names to stop using the experimental API. Signed-off-by: Olga Shern Signed-off-by: Alex Rosenbaum Signed-off-by: Adrien Mazarguil --- drivers/net/mlx4/mlx4.c | 54 - 1

[dpdk-dev] [PATCH v2 09/23] mlx4: fix error message for invalid number of descriptors

2015-06-30 Thread Adrien Mazarguil
From: Or Ami The number of descriptors must be a multiple of MLX4_PMD_SGE_WR_N. Signed-off-by: Or Ami Signed-off-by: Olga Shern Signed-off-by: Adrien Mazarguil --- drivers/net/mlx4/mlx4.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/mlx4/mlx4.c b/driver

[dpdk-dev] [PATCH v2 10/23] mlx4: remove provision for flow creation failure in DMFS A0 mode

2015-06-30 Thread Adrien Mazarguil
From: Or Ami Starting from MLNX_OFED 3.0 FW 2.34.5000 when working with optimized steering mode (-7) QPs can be attached to the port's MAC, therefore no need for the check. Signed-off-by: Or Ami Signed-off-by: Olga Shern Signed-off-by: Adrien Mazarguil --- drivers/net/mlx4/mlx4.c | 20 --

[dpdk-dev] [PATCH v2 11/23] mlx4: fix support for multiple VLAN filters

2015-06-30 Thread Adrien Mazarguil
From: Olga Shern This commit fixes the "Multiple RX VLAN filters can be configured, but only the first one works" bug. Since a single flow specification cannot contain several VLAN definitions, the flows table is extended with MLX4_MAX_VLAN_IDS possible specifications per configured MAC address.

[dpdk-dev] [PATCH v2 12/23] mlx4: query netdevice to get initial MAC address

2015-06-30 Thread Adrien Mazarguil
From: Or Ami Querying the netdevice instead of deriving the port's MAC address from its GID is less prone to errors. There is no guarantee that the GID will always contain it nor that the algorithm won't change. Signed-off-by: Or Ami Signed-off-by: Olga Shern Signed-off-by: Adrien Mazarguil -

[dpdk-dev] [PATCH v2 13/23] mlx4: use MOFED 3.0 fast verbs interface for RX operations

2015-06-30 Thread Adrien Mazarguil
From: Alex Rosenbaum This commit replaces the CQ polling and QP posting functions (mlx4_rx_burst() only) with a new low level interface to improve performance. Signed-off-by: Alex Rosenbaum Signed-off-by: Gilad Berman Signed-off-by: Adrien Mazarguil --- drivers/net/mlx4/mlx4.c | 249

[dpdk-dev] [PATCH v2 14/23] mlx4: improve performance by requesting TX completion events less often

2015-06-30 Thread Adrien Mazarguil
From: Alex Rosenbaum Instead of requesting a completion event for each TX burst, request it on a fixed schedule once every MLX4_PMD_TX_PER_COMP_REQ (currently 64) packets to improve performance. Signed-off-by: Alex Rosenbaum Signed-off-by: Adrien Mazarguil --- drivers/net/mlx4/mlx4.c | 54 +++

[dpdk-dev] [PATCH v2 15/23] mlx4: use MOFED 3.0 fast verbs interface for TX operations

2015-06-30 Thread Adrien Mazarguil
The "raw" post send interface was experimental and has been deprecated. This commit replaces it with a new low level interface that dissociates post and flush (doorbell) operations for improved QP performance. The CQ polling function is updated as well. Signed-off-by: Alex Rosenbaum Signed-off-b

[dpdk-dev] [PATCH v2 16/23] mlx4: move scattered TX processing to helper function

2015-06-30 Thread Adrien Mazarguil
This commit makes scattered TX support entirely optional by moving it to a separate function that is only available when MLX4_PMD_SGE_WR_N > 1. Improves performance when scattered support is not needed. Signed-off-by: Alex Rosenbaum Signed-off-by: Adrien Mazarguil --- drivers/net/mlx4/mlx4.c |

[dpdk-dev] [PATCH v2 17/23] mlx4: shrink TX queue elements for better performance

2015-06-30 Thread Adrien Mazarguil
From: Alex Rosenbaum TX queue elements (struct txq_elt) contain WR and SGE structures required by ibv_post_send(). This commit replaces them with a single pointer to the related TX mbuf considering that: - There is no need to keep these structures around forever since the hardware doesn't acce

[dpdk-dev] [PATCH v2 18/23] mlx4: prefetch completed TX mbufs before releasing them

2015-06-30 Thread Adrien Mazarguil
From: Alex Rosenbaum Signed-off-by: Alex Rosenbaum Signed-off-by: Adrien Mazarguil --- drivers/net/mlx4/mlx4.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/net/mlx4/mlx4.c b/drivers/net/mlx4/mlx4.c index f251eb4..52f3fbb 100644 --- a/drivers/net/mlx4/mlx4

[dpdk-dev] [PATCH v2 19/23] mlx4: add L3 and L4 checksum offload support

2015-06-30 Thread Adrien Mazarguil
From: Gilad Berman Mellanox ConnectX-3 adapters can handle L3 (IPv4) and L4 (TCP, UDP, TCP6, UDP6) RX checksums validation and TX checksums generation, with and without 802.1Q (VLAN) headers. Signed-off-by: Gilad Berman Signed-off-by: Olga Shern Signed-off-by: Adrien Mazarguil --- drivers/ne

[dpdk-dev] [PATCH v2 20/23] mlx4: add L2 tunnel (VXLAN) checksum offload support

2015-06-30 Thread Adrien Mazarguil
Depending on adapters features and VXLAN support in the kernel, VXLAN frames can be automatically recognized, in which case checksum validation and generation occurs on inner and outer L3 and L4. Signed-off-by: Olga Shern Signed-off-by: Adrien Mazarguil --- drivers/net/mlx4/mlx4.c | 49

[dpdk-dev] [PATCH v2 21/23] mlx4: associate resource domain with CQs and QPs to enhance performance

2015-06-30 Thread Adrien Mazarguil
From: Alex Rosenbaum RDs are a new feature of MOFED 3.0 that makes Verbs aware of how CQ and QP resources are being used for internal performance tuning. Signed-off-by: Alex Rosenbaum Signed-off-by: Olga Shern Signed-off-by: Adrien Mazarguil --- drivers/net/mlx4/mlx4.c | 96 +

[dpdk-dev] [PATCH v2 22/23] mlx4: disable multicast echo when device is not VF

2015-06-30 Thread Adrien Mazarguil
From: Olga Shern Multicast loopback must be disabled on PF devices to prevent the adapter from sending frames back. Required with MOFED 3.0. Signed-off-by: Olga Shern Signed-off-by: Adrien Mazarguil --- drivers/net/mlx4/Makefile | 5 + drivers/net/mlx4/mlx4.c | 7 +++ 2 files change

[dpdk-dev] [PATCH v2 23/23] doc: update mlx4 documentation following MOFED 3.0 changes

2015-06-30 Thread Adrien Mazarguil
- Add RX/TX L3/L4 checksum offloading and validation. - Update kernel module parameters section. - Update prerequisites for MOFED and firmware versions. - Remove optimized external libraries section. MOFED now provides enhanced support directly without having to install modified libraries. Signe

[dpdk-dev] [PATCH] add rx and tx byte counter statistics for PCAP PMD

2015-06-30 Thread Klaus Degner
PCAP PMD vdev accounts only rx and tx packet statistics. This patch adds support for rx and tx bytes statistics. Signed-off-by: Klaus Degner --- drivers/net/pcap/rte_eth_pcap.c | 21 +++-- 1 file changed, 19 insertions(+), 2 deletions(-) diff --git a/drivers/net/pcap/rte_eth_pca

[dpdk-dev] [PATCH] mempool: improbe cache search

2015-06-30 Thread Olivier MATZ
Hi Zoltan, On 06/25/2015 08:48 PM, Zoltan Kiss wrote: > The current way has a few problems: > > - if cache->len < n, we copy our elements into the cache first, then >into obj_table, that's unnecessary > - if n >= cache_size (or the backfill fails), and we can't fulfil the >request from the

[dpdk-dev] [PATCH v5] Add toeplitz hash algorithm used by RSS

2015-06-30 Thread Vladimir Medvedkin
Hi Bruce, 2015-06-29 15:40 GMT+03:00 Bruce Richardson : > On Fri, Jun 19, 2015 at 01:31:13PM -0400, Vladimir Medvedkin wrote: > > Software implementation of the Toeplitz hash function used by RSS. > > Can be used either for packet distribution on single queue NIC > > or for simulating of RSS comp

[dpdk-dev] [PATCH v7 04/12] eal/bsdapp: Change names of pci related data structure

2015-06-30 Thread Iremonger, Bernard
> -Original Message- > From: Tetsuya Mukawa [mailto:mukawa at igel.co.jp] > Sent: Tuesday, June 30, 2015 9:24 AM > To: dev at dpdk.org > Cc: Iremonger, Bernard; david.marchand at 6wind.com; Richardson, Bruce; > Tetsuya.Mukawa > Subject: [PATCH v7 04/12] eal/bsdapp: Change names of pci relat

[dpdk-dev] [PATCH v7 03/12] eal: Fix memory leaks and needless increment of pci_map_addr

2015-06-30 Thread Iremonger, Bernard
> -Original Message- > From: Tetsuya Mukawa [mailto:mukawa at igel.co.jp] > Sent: Tuesday, June 30, 2015 9:24 AM > To: dev at dpdk.org > Cc: Iremonger, Bernard; david.marchand at 6wind.com; Richardson, Bruce; > Tetsuya.Mukawa > Subject: [PATCH v7 03/12] eal: Fix memory leaks and needless in

[dpdk-dev] DPDK Issues with OVS

2015-06-30 Thread Sundar Ramakrishnan
Hello, I have openvswitch compiled with dpdk. The way I installed is posted?sundar-ramki/ovs-dpdk. | ? | | ? | | ? | ? | ? | ? | ? | | sundar-ramki/ovs-dpdkovs-dpdk - Openvswitch with DPDK | | | | View on?github.com | Preview by Yahoo | | | | ? | I have the following questions -? 1. How do I

[dpdk-dev] [PATCH v5] Add toeplitz hash algorithm used by RSS

2015-06-30 Thread Bruce Richardson
On Tue, Jun 30, 2015 at 03:14:55PM +0300, Vladimir Medvedkin wrote: > Hi Bruce, > > 2015-06-29 15:40 GMT+03:00 Bruce Richardson : > > > On Fri, Jun 19, 2015 at 01:31:13PM -0400, Vladimir Medvedkin wrote: > > > Software implementation of the Toeplitz hash function used by RSS. > > > Can be used ei

[dpdk-dev] [PATCH v3 4/8] eal: Consolidate rte_eal_pci_probe/close_one_driver() of linuxapp and bsdapp

2015-06-30 Thread Bruce Richardson
On Tue, Jun 30, 2015 at 05:08:41PM +0900, Tetsuya Mukawa wrote: > On 2015/06/30 0:28, Bruce Richardson wrote: > > On Mon, Jun 29, 2015 at 11:56:46AM +0900, Tetsuya Mukawa wrote: > >> From: "Tetsuya.Mukawa" > >> > >> This patch consolidates below functions, and implements these in common > >> eal c

[dpdk-dev] [PATCH v7 05/12] eal: Fix uio mapping differences between linuxapp and bsdapp

2015-06-30 Thread Iremonger, Bernard
> -Original Message- > From: Tetsuya Mukawa [mailto:mukawa at igel.co.jp] > Sent: Tuesday, June 30, 2015 9:24 AM > To: dev at dpdk.org > Cc: Iremonger, Bernard; david.marchand at 6wind.com; Richardson, Bruce; > Tetsuya.Mukawa > Subject: [PATCH v7 05/12] eal: Fix uio mapping differences betw

[dpdk-dev] [PATCH] mempool: improbe cache search

2015-06-30 Thread Zoltan Kiss
On 30/06/15 12:58, Olivier MATZ wrote: > Hi Zoltan, > > On 06/25/2015 08:48 PM, Zoltan Kiss wrote: >> The current way has a few problems: >> >> - if cache->len < n, we copy our elements into the cache first, then >>into obj_table, that's unnecessary >> - if n >= cache_size (or the backfill fa

[dpdk-dev] [PATCH v7 08/12] eal: Consolidate pci_map and mapped_pci_resource of linuxapp and bsdapp

2015-06-30 Thread Iremonger, Bernard
> -Original Message- > From: Tetsuya Mukawa [mailto:mukawa at igel.co.jp] > Sent: Tuesday, June 30, 2015 9:24 AM > To: dev at dpdk.org > Cc: Iremonger, Bernard; david.marchand at 6wind.com; Richardson, Bruce; > Tetsuya.Mukawa > Subject: [PATCH v7 08/12] eal: Consolidate pci_map and > mapp

[dpdk-dev] [PATCH v7 09/12] eal: Consolidate pci_map/unmap_resource() of linuxapp and bsdapp

2015-06-30 Thread Iremonger, Bernard
> -Original Message- > From: Tetsuya Mukawa [mailto:mukawa at igel.co.jp] > Sent: Tuesday, June 30, 2015 9:24 AM > To: dev at dpdk.org > Cc: Iremonger, Bernard; david.marchand at 6wind.com; Richardson, Bruce; > Tetsuya.Mukawa > Subject: [PATCH v7 09/12] eal: Consolidate pci_map/unmap_resour

[dpdk-dev] [PATCH v7 11/12] eal: Consolidate pci_map/unmap_device() of linuxapp and bsdapp

2015-06-30 Thread Iremonger, Bernard
> -Original Message- > From: Tetsuya Mukawa [mailto:mukawa at igel.co.jp] > Sent: Tuesday, June 30, 2015 9:24 AM > To: dev at dpdk.org > Cc: Iremonger, Bernard; david.marchand at 6wind.com; Richardson, Bruce; > Tetsuya.Mukawa > Subject: [PATCH v7 11/12] eal: Consolidate pci_map/unmap_devi

[dpdk-dev] [PATCH v7 12/12] eal: Consolidate rte_eal_pci_probe/close_one_driver() of linuxapp and bsdapp

2015-06-30 Thread Iremonger, Bernard
> -Original Message- > From: Tetsuya Mukawa [mailto:mukawa at igel.co.jp] > Sent: Tuesday, June 30, 2015 9:24 AM > To: dev at dpdk.org > Cc: Iremonger, Bernard; david.marchand at 6wind.com; Richardson, Bruce; > Tetsuya.Mukawa > Subject: [PATCH v7 12/12] eal: Consolidate > rte_eal_pci_probe/

[dpdk-dev] [PATCH v4] eal: Enable Port Hotplug as default in Linux and BSD

2015-06-30 Thread Iremonger, Bernard
> -Original Message- > From: Tetsuya Mukawa [mailto:mukawa at igel.co.jp] > Sent: Tuesday, June 30, 2015 9:27 AM > To: dev at dpdk.org > Cc: Iremonger, Bernard; david.marchand at 6wind.com; Richardson, Bruce; > Tetsuya.Mukawa > Subject: [PATCH v4] eal: Enable Port Hotplug as default in Lin

[dpdk-dev] Strange behavior with dpdk-2.0.0/examples/rxtx_callbacks

2015-06-30 Thread Abhishek Verma
Hi, I am trying to understand DPDK and i modified dpdk-2.0.0/examples/rxtx_callbacks so that i get a message whenever i RX and TX a frame. I added a printf in add_timestamps() and calc_latency() to know whenever i am able to RX and TX a packet along with the # of pkts that i get -- print nb_pkts.

[dpdk-dev] [PATCH v4] eal: Enable Port Hotplug as default in Linux and BSD

2015-06-30 Thread Bruce Richardson
On Tue, Jun 30, 2015 at 04:08:08PM +0100, Iremonger, Bernard wrote: > > > -Original Message- > > From: Tetsuya Mukawa [mailto:mukawa at igel.co.jp] > > Sent: Tuesday, June 30, 2015 9:27 AM > > To: dev at dpdk.org > > Cc: Iremonger, Bernard; david.marchand at 6wind.com; Richardson, Bruce; >

[dpdk-dev] dpdk-2.0.0: crash in ixgbe_recv_scattered_pkts_vec->_recv_raw_pkts_vec->desc_to_olflags_v

2015-06-30 Thread Gopakumar Choorakkot Edakkunni
Hi, I am starting to tryout dpdk-2.0.0 with a simple Rx routine very similar to the l2fwd example - I am running this on a c3.8xlarge aws sr-iov enabled vpc instance (inside the vm it uses ixgbevf driver). Once in every 10 minutes my application crashes in the recieve path. And whenever I check t

[dpdk-dev] [PATCH] lib: remove redundant definition of local symbols

2015-06-30 Thread Thomas Monjalon
2015-06-29 18:35, Thomas Monjalon: > The new version nodes inherit from the previous ones which > already include a default catch-all line for not exported symbols. > > Reported-by: Helin Zhang > Signed-off-by: Thomas Monjalon Applied

[dpdk-dev] [PATCH v4 0/4] vhost: vhost unix domain socket cleanup

2015-06-30 Thread Thomas Monjalon
2015-06-30 17:20, Huawei Xie: > vhost user could register multiple unix domain socket server, and use the path > to identify the virtio device connecting to it. rte_vhost_driver_unregister > will clean up the unix domain socket for the specified path. > > v2 changes: > -minor code style fix, remov

[dpdk-dev] dpdk-2.0.0: crash in ixgbe_recv_scattered_pkts_vec->_recv_raw_pkts_vec->desc_to_olflags_v

2015-06-30 Thread Bruce Richardson
On Tue, Jun 30, 2015 at 08:49:32AM -0700, Gopakumar Choorakkot Edakkunni wrote: > Hi, > > I am starting to tryout dpdk-2.0.0 with a simple Rx routine very > similar to the l2fwd example - I am running this on a c3.8xlarge aws > sr-iov enabled vpc instance (inside the vm it uses ixgbevf driver). >

  1   2   >