Hi Raz,
Thanks for identifying this issue.
A comments below.
> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Raz Amir
> Sent: Monday, April 13, 2015 7:54 PM
> To: 'Thomas Monjalon'
> Cc: dev at dpdk.org
> Subject: Re: [dpdk-dev] Crash related to virtio NICs
Hi
> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Thomas Monjalon
> Sent: Monday, April 13, 2015 8:55 PM
> To: Raz Amir
> Cc: dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v3] Restore support for virtio on FreeBSD
>
> Please provide more information in
From: Igor Ryzhov [mailto:iryz...@nfware.com]
Sent: Monday, April 13, 2015 3:14 PM
To: Ouyang, Changchun
Cc: dev at dpdk.org
Subject: Re: [dpdk-dev] [PATCH] doc: fix vhost guide
Sorry, I used wrong email address to reply from. This one is correct.
On Mon, Apr 13, 2015 at 10:11 AM, Igor Ryzhov m
> -Original Message-
> From: Stephen Hemminger [mailto:stephen at networkplumber.org]
> Sent: Friday, April 10, 2015 11:18 PM
> To: Zhang, Helin; Ananyev, Konstantin
> Cc: dev at dpdk.org; Stephen Hemminger
> Subject: [PATCH 1/2] ixgbe: silence noisy log messages
>
> The ixgbe driver lik
On 4/14/2015 6:11 AM, Stephen Hemminger wrote:
> Fix whitespace errors reported by checkpatch, including
> missing space around operators and places where tab should
> be used instead of space.
>
> Signed-off-by: Stephen Hemminger
Acked-by: Michael Qiu
> ---
> lib/librte_eal/linuxapp/eal/eal_p
On 4/14/2015 6:11 AM, Stephen Hemminger wrote:
> Do some cleanup of pci scan loop.
> * check errors first
> * don't initialize variables where not necessary
Why? It should be better to initialize variables when define it.
Thanks,
Michael
> * cuddle else (follow existing style)
> * chop of
With GCC 4.4.7 from CentOS 6.5, the following errors arise:
lib/librte_pmd_ixgbe/ixgbe_rxtx.c: In function ?ixgbe_dev_rx_queue_setup?:
lib/librte_pmd_ixgbe/ixgbe_rxtx.c:2509: error: missing initializer
lib/librte_pmd_ixgbe/ixgbe_rxtx.c:2509: error: (near initialization for
?dev_info.driver_name?)
On 2015/4/14 4:25, Marc Sune wrote:
>
>
> On 10/04/15 07:53, Linhaifeng wrote:
>> Hi, all
>>
>> I'am trying to use valgrind to check memory leak with my dpdk application
>> but dpdk always failed to mmap hugepages.
>>
>> Without valgrind it works well.How to run dpdk applications with valgrind
Dequeuing is done in bulk (that's what shows as CPU consuming, as
well). Enqueuing is not due to some constraint we have.
It seemed likely that the dequeue function is falsely blamed for
taking up CPU, but in my tests there are constant incoming packets so
I don't see when it will poll and receive
2015-04-10 16:39, John McNamara:
> Converted the Glossary table in the Programmer's Guide
> to a definition list to improve rendering.
>
> Signed-off-by: John McNamara
Applied, thanks
On 04/14/15 12:31, Thomas Monjalon wrote:
> With GCC 4.4.7 from CentOS 6.5, the following errors arise:
>
> lib/librte_pmd_ixgbe/ixgbe_rxtx.c: In function ?ixgbe_dev_rx_queue_setup?:
> lib/librte_pmd_ixgbe/ixgbe_rxtx.c:2509: error: missing initializer
> lib/librte_pmd_ixgbe/ixgbe_rxtx.c:2509: err
On 04/14/15 12:31, Thomas Monjalon wrote:
> With GCC 4.4.7 from CentOS 6.5, the following errors arise:
>
> lib/librte_pmd_ixgbe/ixgbe_rxtx.c: In function ?ixgbe_dev_rx_queue_setup?:
> lib/librte_pmd_ixgbe/ixgbe_rxtx.c:2509: error: missing initializer
> lib/librte_pmd_ixgbe/ixgbe_rxtx.c:2509: err
Hi Stephen,
Thanks for the feedback. Comments and questions inline below.
Jay
On Mon, Apr 13, 2015 at 8:09 PM, Stephen Hemminger <
stephen at networkplumber.org> wrote:
> On Wed, 17 Dec 2014 07:57:02 -0600
> Jay Rolette wrote:
>
> > Signed-off-by: Jay Rolette
> > ---
> > lib/librte_kni/rte_k
> -Original Message-
> From: Vlad Zolotarov [mailto:vladz at cloudius-systems.com]
> Sent: Tuesday, April 14, 2015 1:49 PM
> To: Thomas Monjalon; Ananyev, Konstantin; Zhang, Helin
> Cc: dev at dpdk.org
> Subject: Re: [PATCH] ixgbe: fix build with gcc 4.4
>
>
>
> On 04/14/15 12:31, Thom
> -Original Message-
> From: Vlad Zolotarov [mailto:vladz at cloudius-systems.com]
> Sent: Tuesday, April 14, 2015 1:52 PM
> To: Thomas Monjalon; Ananyev, Konstantin; Zhang, Helin
> Cc: dev at dpdk.org
> Subject: Re: [PATCH] ixgbe: fix build with gcc 4.4
>
>
>
> On 04/14/15 12:31, Thom
On 04/14/15 16:06, Ananyev, Konstantin wrote:
>
>> -Original Message-
>> From: Vlad Zolotarov [mailto:vladz at cloudius-systems.com]
>> Sent: Tuesday, April 14, 2015 1:49 PM
>> To: Thomas Monjalon; Ananyev, Konstantin; Zhang, Helin
>> Cc: dev at dpdk.org
>> Subject: Re: [PATCH] ixgbe: fix
On 04/14/15 16:23, Ananyev, Konstantin wrote:
>
>> -Original Message-
>> From: Vlad Zolotarov [mailto:vladz at cloudius-systems.com]
>> Sent: Tuesday, April 14, 2015 1:52 PM
>> To: Thomas Monjalon; Ananyev, Konstantin; Zhang, Helin
>> Cc: dev at dpdk.org
>> Subject: Re: [PATCH] ixgbe: fix
Hi Ravi,
2015-04-09 12:40, Ravi Kerur:
> --- a/lib/librte_eal/common/eal_common_thread.c
> +++ b/lib/librte_eal/common/eal_common_thread.c
[...]
> +#ifdef RTE_EXEC_ENV_BSDAPP
> +#include
> +#include
> +#else /* RTE_EXEC_ENV_BSDAPP */
> #include
> +#endif /* RTE_EXEC_ENV_BSDAPP */
[...]
> +#ifd
2015-04-14 16:38, Vlad Zolotarov:
> On 04/14/15 16:06, Ananyev, Konstantin wrote:
> > From: Vlad Zolotarov [mailto:vladz at cloudius-systems.com]
> >> On 04/14/15 12:31, Thomas Monjalon wrote:
> >>> - struct rte_eth_dev_info dev_info = { 0 };
> >>> + struct rte_eth_dev_info dev_info = { .max_rx_que
On Wed, Apr 08, 2015 at 07:54:40PM +, Butler, Siobhan A wrote:
>
>
> > -Original Message-
> > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com]
> > Sent: Wednesday, April 8, 2015 5:16 PM
> > To: Wiles, Keith; Butler, Siobhan A
> > Cc: dev at dpdk.org
> > Subject: Re: [dpdk-d
This field is not supposed to contain the RX queue index. Applications can
rely on it to determine the port a given mbuf comes from.
Signed-off-by: Adrien Mazarguil
---
lib/librte_pmd_enic/enic.h| 1 +
lib/librte_pmd_enic/enic_ethdev.c | 1 +
lib/librte_pmd_enic/enic_main.c | 4 ++--
3
On Fri Apr 10 09:40:09 +0200 2015, Pawel Wodkowski wrote:
> On 2015-04-06 19:01, Eric Kinzie wrote:
> >If a device to be enslaved already has transmit and/or receive queues
> >allocated, use those and then create any additional queues that are
> >necessary.
> >
> >Signed-off-by: Eric Kinzie
> >---
On 04/14/15 17:17, Thomas Monjalon wrote:
> 2015-04-14 16:38, Vlad Zolotarov:
>> On 04/14/15 16:06, Ananyev, Konstantin wrote:
>>> From: Vlad Zolotarov [mailto:vladz at cloudius-systems.com]
On 04/14/15 12:31, Thomas Monjalon wrote:
> - struct rte_eth_dev_info dev_info = { 0 };
> + s
>
> Pawel,
>
> I generally test things I've just built using virtio devices and calling
> rte_eth_tx_queue_setup() more than once for a given queue id fails.
> However, it seems that most PMDs allow re-allocating device queues while
> virtio does not (xenvirt also seems to lack this functionality
On Tue, Apr 14, 2015 at 03:21:53PM +0100, Bruce Richardson wrote:
> On Wed, Apr 08, 2015 at 07:54:40PM +, Butler, Siobhan A wrote:
> >
> >
> > > -Original Message-
> > > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com]
> > > Sent: Wednesday, April 8, 2015 5:16 PM
> > > To:
2015-04-14 10:38, Neil Horman:
> On Tue, Apr 14, 2015 at 03:21:53PM +0100, Bruce Richardson wrote:
> > On Wed, Apr 08, 2015 at 07:54:40PM +, Butler, Siobhan A wrote:
> > >
> > >
> > > > -Original Message-
> > > > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com]
> > > > Sent
On Wed, Apr 08, 2015 at 02:16:55PM +, Wiles, Keith wrote:
>
>
> On 4/8/15, 5:43 AM, "Butler, Siobhan A" wrote:
>
> >Hi all,
> >To add to the tools brainstorming - I propose we use the following Coding
> >Standards as the basis of guidelines on coding style going forward.
> >The style outlin
On Wed, Apr 08, 2015 at 06:16:12PM +0200, Thomas Monjalon wrote:
> 2015-04-08 15:53, Wiles, Keith:
> > One of the biggest problems with any style is helping the developer
> > maintain the style. Using some tool does help and I have used astyle
> > before, not bad code formatter. Here is a few that
2015-04-14 17:30, Vlad Zolotarov:
> On 04/14/15 17:17, Thomas Monjalon wrote:
> > 2015-04-14 16:38, Vlad Zolotarov:
> >> On 04/14/15 16:06, Ananyev, Konstantin wrote:
> >>> From: Vlad Zolotarov [mailto:vladz at cloudius-systems.com]
> On 04/14/15 12:31, Thomas Monjalon wrote:
> > - s
On Tue, Apr 14, 2015 at 04:47:47PM +0200, Thomas Monjalon wrote:
> 2015-04-14 10:38, Neil Horman:
> > On Tue, Apr 14, 2015 at 03:21:53PM +0100, Bruce Richardson wrote:
> > > On Wed, Apr 08, 2015 at 07:54:40PM +, Butler, Siobhan A wrote:
> > > >
> > > >
> > > > > -Original Message-
> >
On 04/14/15 17:17, Thomas Monjalon wrote:
> 2015-04-14 16:38, Vlad Zolotarov:
>> On 04/14/15 16:06, Ananyev, Konstantin wrote:
>>> From: Vlad Zolotarov [mailto:vladz at cloudius-systems.com]
On 04/14/15 12:31, Thomas Monjalon wrote:
> - struct rte_eth_dev_info dev_info = { 0 };
> + s
2015-04-14 17:59, Vlad Zolotarov:
> On 04/14/15 17:17, Thomas Monjalon wrote:
> > 2015-04-14 16:38, Vlad Zolotarov:
> >> On 04/14/15 16:06, Ananyev, Konstantin wrote:
> >>> From: Vlad Zolotarov [mailto:vladz at cloudius-systems.com]
> On 04/14/15 12:31, Thomas Monjalon wrote:
> > - s
On 04/14/15 17:53, Thomas Monjalon wrote:
> 2015-04-14 17:30, Vlad Zolotarov:
>> On 04/14/15 17:17, Thomas Monjalon wrote:
>>> 2015-04-14 16:38, Vlad Zolotarov:
On 04/14/15 16:06, Ananyev, Konstantin wrote:
> From: Vlad Zolotarov [mailto:vladz at cloudius-systems.com]
>> On 04/14/15
On 04/14/15 18:13, Thomas Monjalon wrote:
> 2015-04-14 17:59, Vlad Zolotarov:
>> On 04/14/15 17:17, Thomas Monjalon wrote:
>>> 2015-04-14 16:38, Vlad Zolotarov:
On 04/14/15 16:06, Ananyev, Konstantin wrote:
> From: Vlad Zolotarov [mailto:vladz at cloudius-systems.com]
>> On 04/14/15
2015-04-14 15:52, Bruce Richardson:
> On Wed, Apr 08, 2015 at 06:16:12PM +0200, Thomas Monjalon wrote:
> > When a consensus is done, it must be added with a patch with custom
> > checkpatch addition.
> >
> My personal feeling is that we should try and keep checkpatch modifications
> to a
> minimu
2015-04-14 18:21, Vlad Zolotarov:
>
> On 04/14/15 18:13, Thomas Monjalon wrote:
> > 2015-04-14 17:59, Vlad Zolotarov:
> >> On 04/14/15 17:17, Thomas Monjalon wrote:
> >>> 2015-04-14 16:38, Vlad Zolotarov:
> On 04/14/15 16:06, Ananyev, Konstantin wrote:
> > From: Vlad Zolotarov [mailto:vla
On Wed, Apr 08, 2015 at 11:16:03AM -0700, Stephen Hemminger wrote:
> Thanks for doing this, it is a great start.
> I admit strong bias towards Linux kernel style.
>
> Could you use one of the standard markup styles so that it could get put in
> documentation?
>
>
> > License Header
> > ---
On 04/14/15 18:28, Thomas Monjalon wrote:
> 2015-04-14 18:21, Vlad Zolotarov:
>> On 04/14/15 18:13, Thomas Monjalon wrote:
>>> 2015-04-14 17:59, Vlad Zolotarov:
On 04/14/15 17:17, Thomas Monjalon wrote:
> 2015-04-14 16:38, Vlad Zolotarov:
>> On 04/14/15 16:06, Ananyev, Konstantin wro
Thomas, I will add more information to the commit message, but regarding
your feedback on the iopl comment, it is called also iopl on FreeBSD.
See this link to FreeBSD source code, for the io driver code - the flag name
is PSL_IOPL:
https://github.com/freebsd/freebsd/blob/master/sys/i386/i386/io.c#
On 4/14/15, 10:24 AM, "Thomas Monjalon" wrote:
>2015-04-14 15:52, Bruce Richardson:
>> On Wed, Apr 08, 2015 at 06:16:12PM +0200, Thomas Monjalon wrote:
>> > When a consensus is done, it must be added with a patch with custom
>> > checkpatch addition.
>> >
>> My personal feeling is that we shou
Fixes: 8a312224bcde ("eal/bsd: fix fd leak")
Closing /dev/io fd causes SIGBUS in inb/outb instructions
as the process loses the IOPL privileges once the fd is closed:
(gdb) bt
0 0x00492f2c in outb (port=49170, data=0 '\000')
at /usr/include/machine/cpufunc.h:244
1 0x00492f7a
Hi,
I am trying to use DPDK-2.0.0 on Fedora 20 running in a qemu virtual
machine.
After loading the uio and igb_uio module and setting up hugepages, I try
to run the helloworld demo application.
As soon as the helloworld displays the "hello from core 1, hello from
core 0" messages, I loose all
There is no need to initialize a variable that is only used as a loop
variable.
On Tue, Apr 14, 2015 at 2:30 AM, Qiu, Michael wrote:
> On 4/14/2015 6:11 AM, Stephen Hemminger wrote:
> > Do some cleanup of pci scan loop.
> > * check errors first
> > * don't initialize variables where not ne
Since rte_pci_probe always returns 0 or exits via rte_exit()
there is no point in having it return a value.
Just make it void
Signed-off-by: Stephen Hemminger
---
lib/librte_eal/bsdapp/eal/eal.c | 3 +--
lib/librte_eal/common/eal_common_pci.c | 9 +++--
lib/librte_eal/common/includ
On 4/14/15, 11:19 AM, "Wiles, Keith" wrote:
>
>
>On 4/14/15, 10:24 AM, "Thomas Monjalon" wrote:
>
>>2015-04-14 15:52, Bruce Richardson:
>>> On Wed, Apr 08, 2015 at 06:16:12PM +0200, Thomas Monjalon wrote:
>>> > When a consensus is done, it must be added with a patch with custom
>>> > checkpatc
DPDK team,
I am looking at rte_memcpy.h implementation and I wasn't sure whether
coding in that file is done for any specific reason. I see superfluous type
casting in functions and instead of using loop for offset changes during
copy, separate invocation (same function) is done repeatedly.
I mod
rte_memcpy.h has
sperfluous type casting in several functions, remove those unnecessary casting.
while copying separate invocations of functions with changing offset, instead
offset can be calculated with loop.
Testing:
Compared code generated with and without changes with following gcc commands
Remove unnecessary type casting in functions.
Use loop to adjust offset during copy instead of separate invocations.
Signed-off-by: Ravi Kerur
---
.../common/include/arch/x86/rte_memcpy.h | 317 ++---
1 file changed, 151 insertions(+), 166 deletions(-)
diff --git a/lib
On Tue, Apr 14, 2015 at 6:59 AM, Thomas Monjalon
wrote:
> Hi Ravi,
>
> 2015-04-09 12:40, Ravi Kerur:
> > --- a/lib/librte_eal/common/eal_common_thread.c
> > +++ b/lib/librte_eal/common/eal_common_thread.c
> [...]
> > +#ifdef RTE_EXEC_ENV_BSDAPP
> > +#include
> > +#include
> > +#else /* RTE_EXEC
Hi,
> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Raz Amir
> Sent: Tuesday, April 14, 2015 5:23 PM
> To: dev at dpdk.org
> Cc: Raz Amir
> Subject: [dpdk-dev] [PATCH v5] Restore support for virtio on FreeBSD
>
> Fixes: 8a312224bcde ("eal/bsd: fix fd leak")
Hi,
> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of WangDong
> Sent: Saturday, April 11, 2015 4:34 PM
> To: dev at dpdk.org
> Subject: [dpdk-dev] [PATCH] ixgbe:Add write memory barrier for recv pkts.
>
> Like transmit packets, before update receive descripto
Hi,
> -Original Message-
> From: xuelin.shi at freescale.com [mailto:xuelin.shi at freescale.com]
> Sent: Tuesday, March 31, 2015 8:26 AM
> To: Ananyev, Konstantin
> Cc: dev at dpdk.org; thomas.monjalon at 6wind.com; Xuelin Shi
> Subject: [PATCH v3] ixgbe: fix data access on big endian cpu
The addition of uio pci-generic broke use if igb_uio because
the wrong file descriptor is being used.
If I was a hard ass I would recommend uio pci-generic support
be reverted from 2.0 until/unless this fixed.
Failure mode is on startup:
EAL: Error reading interrupts status for fd 0
PANIC in st
On Tue, 14 Apr 2015 14:31:53 -0700
Ravi Kerur wrote:
> +
> + for (i = 0; i < 2; i++)
> + rte_mov32(dst + i * 32, src + i * 32);
> }
Unless you force compiler to unroll the loop, it will be slower.
54 matches
Mail list logo
